fastlane 2.240.1 → 2.241.0

data/fastlane/lib/fastlane/actions/appium.rb

@@ -37,7 +37,7 @@ module Fastlane
 
       def self.invoke_appium_server(params)
         appium = detect_appium(params)
-        Process.spawn("#{appium} -a #{params[:host]} -p #{params[:port]}")
+        Process.spawn(appium, "-a", params[:host].to_s, "-p", params[:port].to_s)
       end
 
       def self.detect_appium(params)

data/fastlane/lib/fastlane/actions/apteligent.rb

@@ -99,7 +99,14 @@ module Fastlane
       end
 
       def self.category
-        :beta
+        :deprecated
+      end
+
+      def self.deprecated_notes
+        [
+          "VMware stopped selling Apteligent to new customers on February 4, 2019, and announced moving its capabilities to VMware Workspace ONE Intelligence.",
+          "See [Apteligent moving to Workspace ONE Intelligence](https://vcdx181.com/2019/01/20/apteligent-moving-to-workspace-one-intelligence/)."
+        ].join("\n")
       end
     end
   end

data/fastlane/lib/fastlane/actions/build_and_upload_to_appetize.rb

@@ -4,7 +4,7 @@ module Fastlane
   module Actions
     class BuildAndUploadToAppetizeAction < Action
       def self.run(params)
-        tmp_path = File.join(Dir.tmpdir, "fastlane_build")
+        tmp_path = Dir.mktmpdir("fastlane_build-")
 
         xcodebuild_configs = params[:xcodebuild]
         xcodebuild_configs[:sdk] = "iphonesimulator"

data/fastlane/lib/fastlane/actions/clean_build_artifacts.rb

@@ -45,6 +45,9 @@ module Fastlane
         [
           "This action deletes the files that get created in your repo as a result of running the _gym_ and _sigh_ commands. It doesn't delete the `fastlane/report.xml` though, this is probably more suited for the .gitignore.",
           "",
+          "From _cert_ it only deletes the `.cer` file. The private key (`<certificate id>.p12`, despite its name an unencrypted PEM key) and the `.certSigningRequest` that _cert_ writes to its `output_path` when it creates a certificate are kept: " \
+          "_cert_ uses that `.p12` to install the certificate on a machine that doesn't have it, and on systems other than macOS it is the only copy of the key. Keep them out of version control.",
+          "",
           "Useful if you quickly want to send out a test build by dropping down to the command line and typing something like `fastlane beta`, without leaving your repo in a messy state afterwards."
         ].join("\n")
       end

data/fastlane/lib/fastlane/actions/danger.rb

@@ -14,15 +14,15 @@ module Fastlane
         base = params[:base]
         head = params[:head]
         pr = params[:pr]
-        cmd << "--danger_id=#{danger_id}" if danger_id
-        cmd << "--dangerfile=#{dangerfile}" if dangerfile
+        cmd << "--danger_id=#{danger_id.shellescape}" if danger_id
+        cmd << "--dangerfile=#{dangerfile.shellescape}" if dangerfile
         cmd << "--fail-on-errors=true" if params[:fail_on_errors]
         cmd << "--fail-if-no-pr=true" if params[:fail_if_no_pr]
         cmd << "--new-comment" if params[:new_comment]
         cmd << "--remove-previous-comments" if params[:remove_previous_comments]
-        cmd << "--base=#{base}" if base
-        cmd << "--head=#{head}" if head
-        cmd << "pr #{pr}" if pr
+        cmd << "--base=#{base.shellescape}" if base
+        cmd << "--head=#{head.shellescape}" if head
+        cmd << "pr #{pr.shellescape}" if pr
 
         ENV['DANGER_GITHUB_API_TOKEN'] = params[:github_api_token] if params[:github_api_token]
         ENV['DANGER_GITHUB_HOST'] = params[:github_enterprise_host] if params[:github_enterprise_host]

data/fastlane/lib/fastlane/actions/docs/build_app.md

@@ -6,8 +6,7 @@
 
 <p align="center">
     <a href="#whats-gym">Features</a> &bull;
-    <a href="#usage">Usage</a> &bull;
-    <a href="#tips">Tips</a>
+    <a href="#usage">Usage</a>
 </p>
 
 -------

data/fastlane/lib/fastlane/actions/docs/create_app_online.md

@@ -10,8 +10,7 @@ _produce_ creates new iOS apps on both the Apple Developer Portal and App Store
 
 <p align="center">
     <a href="#features">Features</a> &bull;
-    <a href="#usage">Usage</a> &bull;
-    <a href="#how-does-it-work">How does it work?</a>
+    <a href="#usage">Usage</a>
 </p>
 
 -------

data/fastlane/lib/fastlane/actions/docs/get_certificates.md

@@ -4,9 +4,7 @@
 
 -------
 <p align="center">
-    <a href="#why">Why?</a> &bull;
     <a href="#usage">Usage</a> &bull;
-    <a href="#how-does-it-work">How does it work?</a> &bull;
     <a href="#tips">Tips</a>
 </p>
 

data/fastlane/lib/fastlane/actions/docs/get_push_certificate.md

@@ -17,9 +17,7 @@ To automate iOS Provisioning profiles you can use [_match_](https://docs.fastlan
 <p align="center">
     <a href="#features">Features</a> &bull;
     <a href="#usage">Usage</a> &bull;
-    <a href="#how-does-it-work">How does it work?</a> &bull;
-    <a href="#tips">Tips</a> &bull;
-    <a href="#need-help">Need help?</a>
+    <a href="#how-does-it-work">How does it work?</a>
 </p>
 
 -------

data/fastlane/lib/fastlane/actions/docs/sync_code_signing.md

@@ -81,12 +81,15 @@ Use Git Storage to store all code signing identities in a private git repo, owne
 
 First, enter the URL to your private (!) Git repo (You can create one for free on e.g. [GitHub](https://github.com/new) or [BitBucket](https://bitbucket.org/repo/create)). The URL you enter can be either a `https://` or a `git` URL. `fastlane match init` won't read or modify your certificates or profiles yet, and also won't validate your git URL.
 
+You'll then be asked which branch of that repo to use, defaulting to `main` if you leave the answer blank.
+
 This will create a `Matchfile` in your current directory (or in your `./fastlane/` folder).
 
 Example content (for more advanced setups check out the [fastlane section](#fastlane)):
 
 ```ruby-skip-tests
 git_url("https://github.com/fastlane/certificates")
+git_branch("main")
 
 app_identifier("tools.fastlane.app")
 username("user@fastlane.tools")
@@ -94,7 +97,7 @@ username("user@fastlane.tools")
 
 ##### Git Storage on GitHub
 
-If your machine is currently using SSH to authenticate with GitHub, you'll want to use a `git` URL, otherwise, you may see an authentication error when you attempt to use match. Alternatively, you can set a basic authorization for _match_:
+If your machine is currently using SSH to authenticate with GitHub, you'll want to use a `git` URL, otherwise, you may see an authentication error when you attempt to use match. Alternatively, you can set a basic authorization for _match_ (needs git 2.31 or later):
 
 Using parameter:
 
@@ -138,7 +141,7 @@ You can find more information about GitHub basic authentication and personal tok
 
 ##### Git Storage on Azure DevOps
 
-If you're running a pipeline on Azure DevOps and using git storage in a another repository on the same project, you might want to use `bearer` token authentication.
+If you're running a pipeline on Azure DevOps and using git storage in a another repository on the same project, you might want to use `bearer` token authentication (needs git 2.31 or later).
 
 Using parameter:
 
@@ -259,7 +262,7 @@ If you want to use a single developer and/or distribution certificate for multip
 
 ```ruby-skip-tests
 git_url("https://github.com/example/example-repo.git")
-git_branch("master")
+git_branch("main")
 ```
 
 _match_ will reuse certificates and will create separate provisioning profiles for each app.
@@ -408,6 +411,13 @@ If you're not using `Fastfile`, you can also use the `force_for_new_devices` opt
 fastlane match adhoc --force_for_new_devices
 ```
 
+##### Offline profile use
+
+If your profile requires the 'Offline support (7 day validity)' setting for use without Internet, use `offline_profile: true` to add this permission to generated profiles.
+
+> [!NOTE]
+> Offline profiles can only be created when logging in with an Apple ID. Apple's App Store Connect API (`api_key` / `api_key_path`) does not support this setting, so _match_ will fail with a clear error if both are combined.
+
 ##### Managed capabilities
 
 > [!IMPORTANT]

data/fastlane/lib/fastlane/actions/ensure_no_debug_code.rb

@@ -2,7 +2,7 @@ module Fastlane
   module Actions
     class EnsureNoDebugCodeAction < Action
       def self.run(params)
-        command = "grep -RE '#{params[:text]}' '#{File.absolute_path(params[:path])}'"
+        command = "grep -RE #{params[:text].shellescape} #{File.absolute_path(params[:path]).shellescape}"
 
         extensions = []
         extensions << params[:extension] unless params[:extension].nil?
@@ -20,7 +20,7 @@ module Fastlane
           command << " --include=\\*.#{extensions.join(',')}"
         end
 
-        command << " --exclude #{params[:exclude]}" if params[:exclude]
+        command << " --exclude #{params[:exclude].shellescape}" if params[:exclude]
 
         if params[:exclude_dirs]
           params[:exclude_dirs].each do |dir|

data/fastlane/lib/fastlane/actions/get_managed_play_store_publishing_rights.rb

@@ -92,6 +92,7 @@ module Fastlane
                                        conflicting_options: [:json_key],
                                        optional: true,
                                        description: "The raw service account JSON data used to authenticate with Google",
+                                       sensitive: true,
                                        code_gen_sensitive: true,
                                        default_value: CredentialsManager::AppfileConfig.try_fetch_value(:json_key_data_raw),
                                        default_value_dynamic: true,

data/fastlane/lib/fastlane/actions/github_api.rb

@@ -250,12 +250,11 @@ module Fastlane
         def call_endpoint(url, http_method, headers, body, secure)
           require 'excon'
 
-          Excon.defaults[:ssl_verify_peer] = secure
           middlewares = Excon.defaults[:middlewares] + [Excon::Middleware::RedirectFollower] # allow redirect in case of repo renames
 
           UI.verbose("#{http_method} : #{url}")
 
-          connection = Excon.new(url)
+          connection = Excon.new(url, ssl_verify_peer: secure)
           connection.request(
             method: http_method,
             headers: headers,

data/fastlane/lib/fastlane/actions/hg_commit_version_bump.rb

@@ -92,7 +92,7 @@ module Fastlane
         end
 
         # create a commit with a message
-        command = "hg commit -m '#{params[:message]}'"
+        command = "hg commit -m #{params[:message].shellescape}"
         return command if Helper.test?
         begin
           Actions.sh(command)

data/fastlane/lib/fastlane/actions/increment_build_number.rb

@@ -37,7 +37,7 @@ module Fastlane
         command = [
           command_prefix,
           'agvtool',
-          params[:build_number] ? "new-version#{mode} #{params[:build_number].to_s.strip}" : "next-version#{mode}",
+          params[:build_number] ? "new-version#{mode} #{params[:build_number].to_s.strip.shellescape}" : "next-version#{mode}",
           command_suffix
         ].join(' ')
 

data/fastlane/lib/fastlane/actions/increment_version_number.rb

@@ -77,7 +77,7 @@ module Fastlane
 
         command = [
           command_prefix,
-          "agvtool new-marketing-version #{next_version_number.to_s.strip}"
+          "agvtool new-marketing-version #{next_version_number.to_s.strip.shellescape}"
         ].join(' ')
 
         if Helper.test?

data/fastlane/lib/fastlane/actions/install_xcode_plugin.rb

@@ -25,11 +25,14 @@ module Fastlane
           end
         end
 
-        zip_path = File.join(Dir.tmpdir, 'plugin.zip')
-        Action.sh("curl", "-L", "-s", "-o", zip_path, params[:url])
-        plugins_path = "#{ENV['HOME']}/Library/Application Support/Developer/Shared/Xcode/Plug-ins"
-        FileUtils.mkdir_p(plugins_path)
-        Action.sh("unzip", "-qo", zip_path, "-d", plugins_path)
+        Dir.mktmpdir do |dir|
+          zip_path = File.join(dir, 'plugin.zip')
+          # -f fails on an HTTP error instead of saving the error page; --proto also applies to redirects
+          Action.sh("curl", "-f", "-L", "-s", "--proto", "=https", "-o", zip_path, params[:url])
+          plugins_path = "#{ENV['HOME']}/Library/Application Support/Developer/Shared/Xcode/Plug-ins"
+          FileUtils.mkdir_p(plugins_path)
+          Action.sh("unzip", "-qo", zip_path, "-d", plugins_path)
+        end
 
         UI.success("Plugin #{File.basename(params[:url], '.zip')} installed successfully")
         UI.message("Please restart Xcode to use the newly installed plugin")
@@ -85,7 +88,14 @@ module Fastlane
       end
 
       def self.category
-        :misc
+        :deprecated
+      end
+
+      def self.deprecated_notes
+        [
+          "Since Xcode 8, which added runtime library validation and source editor extensions ([New Features in Xcode 8](https://developer.apple.com/library/archive/documentation/DeveloperTools/Conceptual/WhatsNewXcode/Chapters/xcode_8_0.html)), Xcode only loads plugins once you re-sign it yourself, and Xcode 14 removed its plugin system.",
+          "A source editor extension ships inside a macOS app: install the app, then enable the extension in the Extensions section of System Settings."
+        ].join("\n")
       end
     end
   end

data/fastlane/lib/fastlane/actions/lcov.rb

@@ -44,7 +44,7 @@ module Fastlane
       end
 
       def self.gen_cov(options)
-        tmp_cov_file = File.join(Dir.tmpdir, "coverage.info")
+        tmp_cov_file = File.join(Dir.mktmpdir("lcov-"), "coverage.info")
         output_dir = options[:output_dir]
         derived_data_path = derived_data_dir(options)
 
@@ -93,7 +93,14 @@ module Fastlane
       end
 
       def self.category
-        :testing
+        :deprecated
+      end
+
+      def self.deprecated_notes
+        [
+          "Xcode records coverage as LLVM `.profdata`, not the gcov `.gcda` files that `lcov --capture --directory` reads, and this action looks for them under `Build/Intermediates`, which Xcode now names `Build/Intermediates.noindex`.",
+          "Use `slather`, or `xcrun llvm-cov export -format=lcov` to produce an lcov file."
+        ].join("\n")
       end
     end
   end

data/fastlane/lib/fastlane/actions/nexus_upload.rb

@@ -9,9 +9,24 @@ module Fastlane
         command += ssl_options(params)
         command += proxy_options(params)
         command += upload_options(params)
+        command << "--config -"
         command << upload_url(params)
 
-        Fastlane::Actions.sh(command.join(' '), log: params[:verbose])
+        Fastlane::Actions.sh(command.join(' '), log: params[:verbose], stdin: curl_config(params))
+      end
+
+      def self.curl_config(params)
+        config = "user = #{curl_config_string("#{params[:username]}:#{params[:password]}")}\n"
+        if params[:proxy_address] && params[:proxy_port] && params[:proxy_username] && params[:proxy_password]
+          config << "proxy-user = #{curl_config_string("#{params[:proxy_username]}:#{params[:proxy_password]}")}\n"
+        end
+        config
+      end
+
+      # Quotes a value for a curl config file, using the escapes listed under `-K, --config` in `man curl`.
+      def self.curl_config_string(value)
+        escapes = { "\\" => "\\\\", "\"" => "\\\"", "\t" => "\\t", "\n" => "\\n", "\r" => "\\r", "\v" => "\\v" }
+        "\"#{value.gsub(/[\\"\t\n\r\v]/, escapes)}\""
       end
 
       def self.upload_url(params)
@@ -61,8 +76,6 @@ module Fastlane
           options << "--upload-file #{file_path}"
         end
 
-        options << "-u #{params[:username].shellescape}:#{params[:password].shellescape}"
-
         options
       end
 
@@ -79,7 +92,6 @@ module Fastlane
         options = []
         if params[:proxy_address] && params[:proxy_port] && params[:proxy_username] && params[:proxy_password]
           options << "-x #{params[:proxy_address].shellescape}:#{params[:proxy_port].shellescape}"
-          options << "--proxy-user #{params[:proxy_username].shellescape}:#{params[:proxy_password].shellescape}"
         end
 
         options

data/fastlane/lib/fastlane/actions/notification.rb

@@ -43,10 +43,11 @@ module Fastlane
                                        description: "Bundle identifier of application to be opened when the notification is clicked",
                                        optional: true),
           FastlaneCore::ConfigItem.new(key: :app_icon,
-                                       description: "The URL of an image to display instead of the application icon (Mavericks+ only)",
+                                       deprecated: true,
+                                       description: "The URL of an image to display instead of the application icon",
                                        optional: true),
           FastlaneCore::ConfigItem.new(key: :content_image,
-                                       description: "The URL of an image to display attached to the notification (Mavericks+ only)",
+                                       description: "The local path of an image to display attached to the notification (Mavericks+)",
                                        optional: true),
           FastlaneCore::ConfigItem.new(key: :open,
                                        description: "URL of the resource to be opened when the notification is clicked",

data/fastlane/lib/fastlane/actions/oclint.rb

@@ -37,16 +37,16 @@ module Fastlane
         exclude_regex = ensure_regex_is_not_string!(exclude_regex)
 
         files = JSON.parse(File.read(compile_commands)).map do |compile_command|
-          file = compile_command['file']
+          # Paths taken from xcodebuild's output escape spaces with a backslash
+          file = compile_command['file'].gsub('\ ', ' ')
           File.exist?(file) ? file : File.join(compile_command['directory'], file)
         end
 
         files.uniq!
         files.select! do |file|
-          file_ruby = file.gsub('\ ', ' ')
-          File.exist?(file_ruby) and
-            (!select_regex or file_ruby =~ select_regex) and
-            (!exclude_regex or file_ruby !~ exclude_regex)
+          File.exist?(file) and
+            (!select_regex or file =~ select_regex) and
+            (!exclude_regex or file !~ exclude_regex)
         end
 
         command_prefix = [
@@ -58,7 +58,7 @@ module Fastlane
         report_type = params[:report_type]
         report_path = params[:report_path] ? params[:report_path] : 'oclint_report.' + report_type
 
-        oclint_args = ["-report-type=#{report_type}", "-o=#{report_path}"]
+        oclint_args = ["-report-type=#{report_type}", "-o=#{report_path.shellescape}"]
 
         oclint_args << "-list-enabled-rules" if params[:list_enabled_rules]
 
@@ -85,9 +85,9 @@ module Fastlane
 
         command = [
           command_prefix,
-          oclint_path,
+          oclint_path.shellescape,
           oclint_args,
-          '"' + files.join('" "') + '"'
+          files.shelljoin
         ].join(' ')
 
         Actions.lane_context[SharedValues::FL_OCLINT_REPORT_PATH] = File.expand_path(report_path)

data/fastlane/lib/fastlane/actions/push_to_git_remote.rb

@@ -3,22 +3,27 @@ module Fastlane
     # Push local changes to the remote branch
     class PushToGitRemoteAction < Action
       def self.run(params)
-        # Find the local git branch using HEAD or fallback to CI's ENV git branch if you're in detached HEAD state
+        # Find the current branch, or on a detached HEAD the branch CI names in its environment variables
         local_git_branch = Actions.git_branch_name_using_HEAD
-        local_git_branch = Actions.git_branch unless local_git_branch && local_git_branch != "HEAD"
+        detached_head = local_git_branch == "HEAD"
+        local_git_branch = Actions.git_branch unless local_git_branch && !detached_head
 
         local_branch = params[:local_branch]
         local_branch ||= local_git_branch.gsub(%r{#{params[:remote]}\/}, '') if local_git_branch
         UI.user_error!('Failed to get the current branch.') unless local_branch
 
         remote_branch = params[:remote_branch] || local_branch
+        UI.user_error!("HEAD is detached and no branch name was found in the CI environment variables; pass remote_branch") if remote_branch == "HEAD"
+
+        # On a detached HEAD the branch name comes from CI, and its local branch does not have the commits made on HEAD
+        source = params[:local_branch] || (detached_head ? "HEAD" : local_branch)
 
         # construct our command as an array of components
         command = [
           'git',
           'push',
           params[:remote],
-          "#{local_branch.shellescape}:#{remote_branch.shellescape}"
+          "#{source.shellescape}:#{remote_branch.shellescape}"
         ]
 
         # optionally add the tags component
@@ -37,7 +42,7 @@ module Fastlane
         command << '--set-upstream' if params[:set_upstream]
 
         # optionally add the --push_options components
-        params[:push_options].each { |push_option| command << "--push-option=#{push_option}" } if params[:push_options]
+        params[:push_options].each { |push_option| command << "--push-option=#{push_option.shellescape}" } if params[:push_options]
 
         # execute our command
         return command.join(' ') if Helper.test?

data/fastlane/lib/fastlane/actions/register_device.rb

@@ -4,7 +4,7 @@ module Fastlane
   module Actions
     class RegisterDeviceAction < Action
       def self.is_supported?(platform)
-        platform == :ios
+        [:ios, :mac].include?(platform)
       end
 
       def self.run(params)

data/fastlane/lib/fastlane/actions/say.rb

@@ -2,15 +2,13 @@ module Fastlane
   module Actions
     class SayAction < Action
       def self.run(params)
-        text = params[:text]
-        text = text.join(' ')
-        text = text.tr("'", '"')
+        text = params[:text].join(' ')
 
         if params[:mute]
           UI.message(text)
           return text
         else
-          Actions.sh("say '#{text}'")
+          Actions.sh('say', text)
         end
       end
 

data/fastlane/lib/fastlane/actions/set_pod_key.rb

@@ -8,9 +8,9 @@ module Fastlane
         cmd << ['bundle exec'] if params[:use_bundle_exec] && shell_out_should_use_bundle_exec?
         cmd << ['pod keys set']
 
-        cmd << ["\"#{params[:key]}\""]
-        cmd << ["\"#{params[:value]}\""]
-        cmd << ["\"#{params[:project]}\""] if params[:project]
+        cmd << [params[:key].shellescape]
+        cmd << [params[:value].shellescape]
+        cmd << [params[:project].shellescape] if params[:project]
 
         Actions.sh(cmd.join(' '))
       end

data/fastlane/lib/fastlane/actions/sonar.rb

@@ -11,22 +11,22 @@ module Fastlane
         ].join(' ')
 
         sonar_scanner_args = []
-        sonar_scanner_args << "-Dproject.settings=\"#{params[:project_configuration_path]}\"" if params[:project_configuration_path]
-        sonar_scanner_args << "-Dsonar.projectKey=\"#{params[:project_key]}\"" if params[:project_key]
-        sonar_scanner_args << "-Dsonar.projectName=\"#{params[:project_name]}\"" if params[:project_name]
-        sonar_scanner_args << "-Dsonar.projectVersion=\"#{params[:project_version]}\"" if params[:project_version]
-        sonar_scanner_args << "-Dsonar.sources=\"#{params[:sources_path]}\"" if params[:sources_path]
-        sonar_scanner_args << "-Dsonar.exclusions=\"#{params[:exclusions]}\"" if params[:exclusions]
-        sonar_scanner_args << "-Dsonar.language=\"#{params[:project_language]}\"" if params[:project_language]
-        sonar_scanner_args << "-Dsonar.sourceEncoding=\"#{params[:source_encoding]}\"" if params[:source_encoding]
-        sonar_scanner_args << "-Dsonar.login=\"#{params[:sonar_login]}\"" if params[:sonar_login]
-        sonar_scanner_args << "-Dsonar.token=\"#{params[:sonar_token]}\"" if params[:sonar_token]
-        sonar_scanner_args << "-Dsonar.host.url=\"#{params[:sonar_url]}\"" if params[:sonar_url]
-        sonar_scanner_args << "-Dsonar.organization=\"#{params[:sonar_organization]}\"" if params[:sonar_organization]
-        sonar_scanner_args << "-Dsonar.branch.name=\"#{params[:branch_name]}\"" if params[:branch_name]
-        sonar_scanner_args << "-Dsonar.pullrequest.branch=\"#{params[:pull_request_branch]}\"" if params[:pull_request_branch]
-        sonar_scanner_args << "-Dsonar.pullrequest.base=\"#{params[:pull_request_base]}\"" if params[:pull_request_base]
-        sonar_scanner_args << "-Dsonar.pullrequest.key=\"#{params[:pull_request_key]}\"" if params[:pull_request_key]
+        sonar_scanner_args << "-Dproject.settings=#{params[:project_configuration_path].shellescape}" if params[:project_configuration_path]
+        sonar_scanner_args << "-Dsonar.projectKey=#{params[:project_key].shellescape}" if params[:project_key]
+        sonar_scanner_args << "-Dsonar.projectName=#{params[:project_name].shellescape}" if params[:project_name]
+        sonar_scanner_args << "-Dsonar.projectVersion=#{params[:project_version].shellescape}" if params[:project_version]
+        sonar_scanner_args << "-Dsonar.sources=#{params[:sources_path].shellescape}" if params[:sources_path]
+        sonar_scanner_args << "-Dsonar.exclusions=#{params[:exclusions].shellescape}" if params[:exclusions]
+        sonar_scanner_args << "-Dsonar.language=#{params[:project_language].shellescape}" if params[:project_language]
+        sonar_scanner_args << "-Dsonar.sourceEncoding=#{params[:source_encoding].shellescape}" if params[:source_encoding]
+        sonar_scanner_args << "-Dsonar.login=#{params[:sonar_login].shellescape}" if params[:sonar_login]
+        sonar_scanner_args << "-Dsonar.token=#{params[:sonar_token].shellescape}" if params[:sonar_token]
+        sonar_scanner_args << "-Dsonar.host.url=#{params[:sonar_url].shellescape}" if params[:sonar_url]
+        sonar_scanner_args << "-Dsonar.organization=#{params[:sonar_organization].shellescape}" if params[:sonar_organization]
+        sonar_scanner_args << "-Dsonar.branch.name=#{params[:branch_name].shellescape}" if params[:branch_name]
+        sonar_scanner_args << "-Dsonar.pullrequest.branch=#{params[:pull_request_branch].shellescape}" if params[:pull_request_branch]
+        sonar_scanner_args << "-Dsonar.pullrequest.base=#{params[:pull_request_base].shellescape}" if params[:pull_request_base]
+        sonar_scanner_args << "-Dsonar.pullrequest.key=#{params[:pull_request_key].shellescape}" if params[:pull_request_key]
 
         sonar_scanner_args << params[:sonar_runner_args] if params[:sonar_runner_args]
 

data/fastlane/lib/fastlane/actions/sourcedocs.rb

@@ -6,20 +6,20 @@ module Fastlane
 
         command =  "sourcedocs generate"
         command << " --all-modules" if params[:all_modules]
-        command << " --spm-module #{params[:spm_module]}" unless params[:spm_module].nil?
-        command << " --module-name #{params[:module_name]}" unless params[:module_name].nil?
-        command << " --link-beginning #{params[:link_beginning]}" unless params[:link_beginning].nil?
-        command << " --link-ending #{params[:link_ending]}" unless params[:link_ending].nil?
-        command << " --output-folder #{params[:output_folder]}" unless params[:output_folder].nil?
-        command << " --min-acl #{params[:min_acl]}" unless params[:min_acl].nil?
+        command << " --spm-module #{params[:spm_module].shellescape}" unless params[:spm_module].nil?
+        command << " --module-name #{params[:module_name].shellescape}" unless params[:module_name].nil?
+        command << " --link-beginning #{params[:link_beginning].shellescape}" unless params[:link_beginning].nil?
+        command << " --link-ending #{params[:link_ending].shellescape}" unless params[:link_ending].nil?
+        command << " --output-folder #{params[:output_folder].shellescape}" unless params[:output_folder].nil?
+        command << " --min-acl #{params[:min_acl].shellescape}" unless params[:min_acl].nil?
         command << " --module-name-path" if params[:module_name_path]
         command << " --clean" if params[:clean]
         command << " --collapsible" if params[:collapsible]
         command << " --table-of-contents" if params[:table_of_contents]
         command << " --reproducible-docs" if params[:reproducible]
         unless params[:scheme].nil?
-          command << " -- -scheme #{params[:scheme]}"
-          command << " -sdk #{params[:sdk_platform]}" unless params[:sdk_platform].nil?
+          command << " -- -scheme #{params[:scheme].shellescape}"
+          command << " -sdk #{params[:sdk_platform].shellescape}" unless params[:sdk_platform].nil?
         end
         Actions.sh(command)
       end

data/fastlane/lib/fastlane/actions/splunkmint.rb

@@ -149,7 +149,14 @@ module Fastlane
       end
 
       def self.category
-        :beta
+        :deprecated
+      end
+
+      def self.deprecated_notes
+        [
+          "Splunk MINT reached End of Life in December 2021 for all MINT products, including the SDK and its Web Service.",
+          "See [Splunk MINT SDK for iOS (EOL)](https://docs.splunk.com/Documentation/MintIOSSDK/latest/DevGuide/APIReference)."
+        ].join("\n")
       end
     end
   end

data/fastlane/lib/fastlane/actions/update_project_provisioning.rb

@@ -25,7 +25,7 @@ module Fastlane
           UI.message("Downloading root certificate from (#{ROOT_CERTIFICATE_URL}) to path '#{params[:certificate]}'")
           require 'open-uri'
           File.open(params[:certificate], "w:ASCII-8BIT") do |file|
-            file.write(URI.open(ROOT_CERTIFICATE_URL, "rb").read)
+            file.write(URI.parse(ROOT_CERTIFICATE_URL).open("rb").read)
           end
         end
 

data/fastlane/lib/fastlane/actions/upload_to_app_store.rb

@@ -10,8 +10,11 @@ module Fastlane
         begin
           config.load_configuration_file("Deliverfile")
           config[:screenshots_path] ||= Actions.lane_context[SharedValues::SNAPSHOT_SCREENSHOTS_PATH] if Actions.lane_context[SharedValues::SNAPSHOT_SCREENSHOTS_PATH]
-          config[:ipa] ||= Actions.lane_context[SharedValues::IPA_OUTPUT_PATH] if Actions.lane_context[SharedValues::IPA_OUTPUT_PATH]
-          config[:pkg] ||= Actions.lane_context[SharedValues::PKG_OUTPUT_PATH] if Actions.lane_context[SharedValues::PKG_OUTPUT_PATH]
+          # The build from gym wins over the newest *.ipa/*.pkg in the current directory, the options' default
+          unless config.specified?(:ipa) || config.specified?(:pkg)
+            config[:ipa] = Actions.lane_context[SharedValues::IPA_OUTPUT_PATH] if Actions.lane_context[SharedValues::IPA_OUTPUT_PATH]
+            config[:pkg] = Actions.lane_context[SharedValues::PKG_OUTPUT_PATH] if Actions.lane_context[SharedValues::PKG_OUTPUT_PATH]
+          end
 
           # Only set :api_key from SharedValues if :api_key_path isn't set (conflicting options)
           unless config[:api_key_path]

data/fastlane/lib/fastlane/actions/upload_to_testflight.rb

@@ -11,9 +11,12 @@ module Fastlane
         values[:changelog] ||= changelog if changelog
 
         unless distribute_only
-          values[:ipa] ||= Actions.lane_context[SharedValues::IPA_OUTPUT_PATH]
+          # The build from gym wins over the newest *.ipa/*.pkg in the current directory, the options' default
+          unless values.specified?(:ipa) || values.specified?(:pkg)
+            values[:ipa] = Actions.lane_context[SharedValues::IPA_OUTPUT_PATH] if Actions.lane_context[SharedValues::IPA_OUTPUT_PATH]
+            values[:pkg] = Actions.lane_context[SharedValues::PKG_OUTPUT_PATH] if Actions.lane_context[SharedValues::PKG_OUTPUT_PATH]
+          end
           values[:ipa] = File.expand_path(values[:ipa]) if values[:ipa]
-          values[:pkg] ||= Actions.lane_context[SharedValues::PKG_OUTPUT_PATH]
           values[:pkg] = File.expand_path(values[:pkg]) if values[:pkg]
         end