fastlane 2.240.0 → 2.241.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 7467cf01821db5d82582d55e830e209b07d0c3ed4793686fb31e91bba27b66a1
-  data.tar.gz: b517b0bdb057a42827caa42ba504cd450d3e40169c8191c280cee8c6ab2544b8
+  metadata.gz: 696cd16eb3defc78305bdebccbc787402841c1105199cfd437d15f019e617024
+  data.tar.gz: ab772bcd92b21da5da03746f3e7bdab86e60f5ff6771696e2beb5cbd5c673b4d
 SHA512:
-  metadata.gz: 683a57ea89b9bf4ae28def60d5bbfaa5221081dac34e840bf4c597f3788f7b8c295237a0862847a519aedd28ef51ffa7fb4da1a576afd2654e5548761ccf4b51
-  data.tar.gz: 9c436bf7d1ba66d55a8d68aeb38caf6d3c1d56fd5c48c90cd5642865163d80ddbe367f0b9cc4ddd18477b9f95d40ed733b9965cc42a9f16928774c490114ebd7
+  metadata.gz: fb16eaacf91b754e72424d9780054f13b49040aadb738c86746dba6fa75ff3e275af98621aeda98794b47a1a3ad982d91071b6c9b1642da7e243a0d187a86739
+  data.tar.gz: e116e4c1c5f59831e65a20e676f9f8735807ae86929efb06bc5d97d97e11182361ea2d783c9da2ced56276f6d2183bfbfd863e5fcb7e7add57f5f1961543e84f

data/README.md

@@ -9,17 +9,12 @@
 [![Gem](https://img.shields.io/gem/v/fastlane.svg?style=flat)](https://rubygems.org/gems/fastlane)
 [![Homebrew](https://img.shields.io/badge/dynamic/json.svg?url=https://formulae.brew.sh/api/formula/fastlane.json&query=$.versions.stable&label=homebrew)](https://formulae.brew.sh/formula/fastlane)
 [![Build Status](https://img.shields.io/circleci/project/github/fastlane/fastlane/master.svg)](https://circleci.com/gh/fastlane/fastlane)
-[![PRs welcome!](https://img.shields.io/badge/PRs-welcome-brightgreen.svg)](https://github.com/fastlane/fastlane/blob/master/CONTRIBUTING.md)
+[![PRs welcome!](https://img.shields.io/badge/PRs-welcome-brightgreen.svg)](https://github.com/fastlane/fastlane/blob/master/docs/CONTRIBUTING.md)
 [![OpenCollective!](https://opencollective.com/fastlane/tiers/badge.svg)](https://opencollective.com/fastlane)
+[![OpenSSF Scorecard](https://api.securityscorecards.dev/projects/github.com/fastlane/fastlane/badge)](https://scorecard.dev/viewer/?uri=github.com/fastlane/fastlane)
 
 _fastlane_ is a tool for iOS and Android developers to automate tedious tasks like generating screenshots, dealing with provisioning profiles, and releasing your application.
 
-<hr />
-<h2 align="center">
-  ✨ All fastlane docs were moved to <a href="https://docs.fastlane.tools/">docs.fastlane.tools</a> ✨
-</h2>
-<hr />
-
 ## Need Help?
 
 Before submitting a new GitHub issue, please make sure to
@@ -29,212 +24,102 @@ Before submitting a new GitHub issue, please make sure to
 
 If the above doesn't help, please [submit an issue](https://github.com/fastlane/fastlane/issues) on GitHub and provide information about your setup, in particular the output of the `fastlane env` command.
 
-**Note**: If you want to report a regression in _fastlane_ (something that has worked before, but broke with a new release), please mark your issue title as such using `[Regression] Your title here`. This enables us to quickly detect and fix regressions.
-
 ## _fastlane_ team
 
 <!-- This table is regenerated and resorted on each release -->
+<!-- team:start -->
 <table id='team'>
 <tr>
-<td id='danielle-tomlinson'>
-<a href='https://github.com/endocrimes'>
-<img src='https://github.com/endocrimes.png' width='140px;'>
-</a>
-<h4 align='center'><a href='https://twitter.com/endocrimes'>Danielle Tomlinson</a></h4>
-</td>
-<td id='connor-tumbleson'>
-<a href='https://github.com/ibotpeaches'>
-<img src='https://github.com/ibotpeaches.png' width='140px;'>
-</a>
-<h4 align='center'><a href='https://twitter.com/ibotpeaches'>Connor Tumbleson</a></h4>
-</td>
-<td id='luka-mirosevic'>
-<a href='https://github.com/lmirosevic'>
-<img src='https://github.com/lmirosevic.png' width='140px;'>
-</a>
-<h4 align='center'><a href='https://twitter.com/lmirosevic'>Luka Mirosevic</a></h4>
-</td>
-<td id='iulian-onofrei'>
-<a href='https://github.com/revolter'>
-<img src='https://github.com/revolter.png' width='140px;'>
-</a>
-<h4 align='center'><a href='https://twitter.com/Revolt666'>Iulian Onofrei</a></h4>
-</td>
-<td id='fumiya-nakamura'>
-<a href='https://github.com/nafu'>
-<img src='https://github.com/nafu.png' width='140px;'>
+<td id='jan-piotrowski'>
+<a href='https://github.com/janpio'>
+<img src='https://github.com/janpio.png?size=200' width='140'>
 </a>
-<h4 align='center'><a href='https://twitter.com/nafu003'>Fumiya Nakamura</a></h4>
+<h4 align='center'><a href='https://twitter.com/Sujan'>Jan Piotrowski</a></h4>
 </td>
-</tr>
-<tr>
 <td id='jérôme-lacoste'>
 <a href='https://github.com/lacostej'>
-<img src='https://github.com/lacostej.png' width='140px;'>
+<img src='https://github.com/lacostej.png?size=200' width='140'>
 </a>
 <h4 align='center'><a href='https://twitter.com/lacostej'>Jérôme Lacoste</a></h4>
 </td>
-<td id='aaron-brager'>
-<a href='https://github.com/getaaron'>
-<img src='https://github.com/getaaron.png' width='140px;'>
-</a>
-<h4 align='center'><a href='https://twitter.com/getaaron'>Aaron Brager</a></h4>
-</td>
-<td id='jimmy-dee'>
-<a href='https://github.com/jdee'>
-<img src='https://github.com/jdee.png' width='140px;'>
-</a>
-<h4 align='center'>Jimmy Dee</h4>
-</td>
-<td id='roger-oba'>
-<a href='https://github.com/rogerluan'>
-<img src='https://github.com/rogerluan.png' width='140px;'>
-</a>
-<h4 align='center'><a href='https://twitter.com/rogerluan_'>Roger Oba</a></h4>
-</td>
-<td id='matthew-ellis'>
-<a href='https://github.com/matthewellis'>
-<img src='https://github.com/matthewellis.png' width='140px;'>
-</a>
-<h4 align='center'><a href='https://twitter.com/mellis1995'>Matthew Ellis</a></h4>
-</td>
-</tr>
-<tr>
-<td id='max-ott'>
-<a href='https://github.com/max-ott'>
-<img src='https://github.com/max-ott.png' width='140px;'>
-</a>
-<h4 align='center'><a href='https://twitter.com/ott_max'>Max Ott</a></h4>
-</td>
-<td id='daniel-jankowski'>
-<a href='https://github.com/mollyIV'>
-<img src='https://github.com/mollyIV.png' width='140px;'>
-</a>
-<h4 align='center'><a href='https://twitter.com/mollyIV'>Daniel Jankowski</a></h4>
-</td>
-<td id='manish-rathi'>
-<a href='https://github.com/crazymanish'>
-<img src='https://github.com/crazymanish.png' width='140px;'>
+<td id='joshua-liebowitz'>
+<a href='https://github.com/taquitos'>
+<img src='https://github.com/taquitos.png?size=200' width='140'>
 </a>
-<h4 align='center'><a href='https://twitter.com/iammanishrathi'>Manish Rathi</a></h4>
+<h4 align='center'><a href='https://twitter.com/taquitos'>Joshua Liebowitz</a></h4>
 </td>
-<td id='manu-wallner'>
-<a href='https://github.com/milch'>
-<img src='https://github.com/milch.png' width='140px;'>
+<td id='josh-holtz'>
+<a href='https://github.com/joshdholtz'>
+<img src='https://github.com/joshdholtz.png?size=200' width='140'>
 </a>
-<h4 align='center'><a href='https://twitter.com/acrooow'>Manu Wallner</a></h4>
+<h4 align='center'><a href='https://twitter.com/joshdholtz'>Josh Holtz</a></h4>
 </td>
-<td id='satoshi-namai'>
-<a href='https://github.com/ainame'>
-<img src='https://github.com/ainame.png' width='140px;'>
+<td id='stefan-natchev'>
+<a href='https://github.com/snatchev'>
+<img src='https://github.com/snatchev.png?size=200' width='140'>
 </a>
-<h4 align='center'><a href='https://twitter.com/ainame'>Satoshi Namai</a></h4>
+<h4 align='center'><a href='https://twitter.com/snatchev'>Stefan Natchev</a></h4>
 </td>
 </tr>
 <tr>
-<td id='maksym-grebenets'>
-<a href='https://github.com/mgrebenets'>
-<img src='https://github.com/mgrebenets.png' width='140px;'>
-</a>
-<h4 align='center'><a href='https://twitter.com/mgrebenets'>Maksym Grebenets</a></h4>
-</td>
 <td id='olivier-halligon'>
 <a href='https://github.com/AliSoftware'>
-<img src='https://github.com/AliSoftware.png' width='140px;'>
+<img src='https://github.com/AliSoftware.png?size=200' width='140'>
 </a>
 <h4 align='center'><a href='https://twitter.com/aligatr'>Olivier Halligon</a></h4>
 </td>
-<td id='josh-holtz'>
-<a href='https://github.com/joshdholtz'>
-<img src='https://github.com/joshdholtz.png' width='140px;'>
-</a>
-<h4 align='center'><a href='https://twitter.com/joshdholtz'>Josh Holtz</a></h4>
-</td>
-<td id='jan-piotrowski'>
-<a href='https://github.com/janpio'>
-<img src='https://github.com/janpio.png' width='140px;'>
-</a>
-<h4 align='center'><a href='https://twitter.com/Sujan'>Jan Piotrowski</a></h4>
-</td>
 <td id='felix-krause'>
 <a href='https://github.com/KrauseFx'>
-<img src='https://github.com/KrauseFx.png' width='140px;'>
+<img src='https://github.com/KrauseFx.png?size=200' width='140'>
 </a>
 <h4 align='center'><a href='https://twitter.com/KrauseFx'>Felix Krause</a></h4>
 </td>
-</tr>
-<tr>
-<td id='joshua-liebowitz'>
-<a href='https://github.com/taquitos'>
-<img src='https://github.com/taquitos.png' width='140px;'>
-</a>
-<h4 align='center'><a href='https://twitter.com/taquitos'>Joshua Liebowitz</a></h4>
-</td>
-<td id='łukasz-grabowski'>
-<a href='https://github.com/lucgrabowski'>
-<img src='https://github.com/lucgrabowski.png' width='140px;'>
-</a>
-<h4 align='center'>Łukasz Grabowski</h4>
-</td>
-<td id='helmut-januschka'>
-<a href='https://github.com/hjanuschka'>
-<img src='https://github.com/hjanuschka.png' width='140px;'>
-</a>
-<h4 align='center'><a href='https://twitter.com/hjanuschka'>Helmut Januschka</a></h4>
-</td>
-<td id='stefan-natchev'>
-<a href='https://github.com/snatchev'>
-<img src='https://github.com/snatchev.png' width='140px;'>
+<td id='connor-tumbleson'>
+<a href='https://github.com/ibotpeaches'>
+<img src='https://github.com/ibotpeaches.png?size=200' width='140'>
 </a>
-<h4 align='center'><a href='https://twitter.com/snatchev'>Stefan Natchev</a></h4>
+<h4 align='center'><a href='https://twitter.com/ibotpeaches'>Connor Tumbleson</a></h4>
 </td>
-<td id='kohki-miki'>
-<a href='https://github.com/giginet'>
-<img src='https://github.com/giginet.png' width='140px;'>
+<td id='roger-oba'>
+<a href='https://github.com/rogerluan'>
+<img src='https://github.com/rogerluan.png?size=200' width='140'>
 </a>
-<h4 align='center'><a href='https://twitter.com/giginet'>Kohki Miki</a></h4>
+<h4 align='center'><a href='https://twitter.com/rogerluan_'>Roger Oba</a></h4>
 </td>
 </tr>
-<tr>
-<td id='jorge-revuelta-h'>
-<a href='https://github.com/minuscorp'>
-<img src='https://github.com/minuscorp.png' width='140px;'>
-</a>
-<h4 align='center'><a href='https://twitter.com/minuscorp'>Jorge Revuelta H</a></h4>
-</td>
-<td id='andrew-mcburney'>
-<a href='https://github.com/armcburney'>
-<img src='https://github.com/armcburney.png' width='140px;'>
-</a>
-<h4 align='center'><a href='https://twitter.com/armcburney'>Andrew McBurney</a></h4>
-</td>
 </table>
 
+### _fastlane_ alumni
+
+_fastlane_ wouldn't be what it is today without the countless hours these former team members have dedicated to the project ❤️
+
+<p id='alumni'>
+<a href='https://github.com/endocrimes'>Danielle Tomlinson</a>,
+<a href='https://github.com/crazymanish'>Manish Rathi</a>,
+<a href='https://github.com/ainame'>Satoshi Namai</a>,
+<a href='https://github.com/giginet'>Kohki Miki</a>,
+<a href='https://github.com/lmirosevic'>Luka Mirosevic</a>,
+<a href='https://github.com/minuscorp'>Jorge Revuelta H</a>,
+<a href='https://github.com/mollyIV'>Daniel Jankowski</a>,
+<a href='https://github.com/armcburney'>Andrew McBurney</a>,
+<a href='https://github.com/max-ott'>Max Ott</a>,
+<a href='https://github.com/lucgrabowski'>Łukasz Grabowski</a>,
+<a href='https://github.com/matthewellis'>Matthew Ellis</a>,
+<a href='https://github.com/jdee'>Jimmy Dee</a>,
+<a href='https://github.com/nafu'>Fumiya Nakamura</a>,
+<a href='https://github.com/hjanuschka'>Helmut Januschka</a>,
+<a href='https://github.com/milch'>Manu Wallner</a>,
+<a href='https://github.com/getaaron'>Aaron Brager</a>,
+<a href='https://github.com/mgrebenets'>Maksym Grebenets</a>,
+<a href='https://github.com/revolter'>Iulian Onofrei</a>
+</p>
+<!-- team:end -->
+
 Special thanks to all [contributors](https://github.com/fastlane/fastlane/graphs/contributors) for extending and improving _fastlane_.
 
 ## Contribute to _fastlane_
 
-Check out [CONTRIBUTING.md](CONTRIBUTING.md) for more information on how to help with _fastlane_.
-
-## Code of Conduct
-
-Help us keep _fastlane_ open and inclusive. Please read and follow our [Code of Conduct](https://github.com/fastlane/fastlane/blob/master/CODE_OF_CONDUCT.md).
-
-## Metrics
-
-_fastlane_ tracks a few key metrics to understand how developers are using the tool and to help us know what areas need improvement. No personal/sensitive information is ever collected. Metrics that are collected include:
-
-* The number of _fastlane_ runs
-* A salted hash of the app identifier or package name, which helps us anonymously identify unique usage of _fastlane_
-* How _fastlane_ is executed (Swift vs Ruby)
-* The _fastlane_ version
-* How _fastlane_ was installed (Homebrew, gem, bundler, etc)
-* The Ruby version
-* The Operating System in use
-* The Xcode version
-* Whether it was run in non-interactively or interactively
-
-You can easily opt-out of metrics collection by adding `opt_out_usage` at the top of your `Fastfile` or by setting the environment variable `FASTLANE_OPT_OUT_USAGE`. [Check out the metrics code on GitHub](https://github.com/fastlane/fastlane/tree/master/fastlane_core/lib/fastlane_core/analytics)
+Check out [CONTRIBUTING.md](docs/CONTRIBUTING.md) or [CODE_OF_CONDUCT.md](./docs/CODE_OF_CONDUCT.md) for more information on how to help with _fastlane_.
 
 ## License
 
@@ -242,8 +127,3 @@ This project is licensed under the terms of the MIT license. See the [LICENSE](L
 
 > This project and all fastlane tools are in no way affiliated with Apple Inc. This project is open source under the MIT license, which means you have full access to the source code and can modify it to fit your own needs. All fastlane tools run on your own computer or server, so your credentials or other sensitive information will never leave your own computer. You are responsible for how you use fastlane tools.
 
-<hr />
-<h2 align="center">
-  ✨ All fastlane docs were moved to <a href="https://docs.fastlane.tools/">docs.fastlane.tools</a> ✨
-</h2>
-<hr />

data/bin/fastlane

@@ -1,7 +1,9 @@
 #!/usr/bin/env ruby
 
-if RUBY_VERSION < '3.1.0'
-  abort("fastlane requires Ruby 3.1.0 or higher")
+require "fastlane/version"
+
+if Gem::Version.new(RUBY_VERSION) < Gem::Version.new(Fastlane::MINIMUM_RUBY)
+  abort("fastlane requires Ruby #{Fastlane::MINIMUM_RUBY} or higher")
 end
 
 def self.windows?

data/credentials_manager/README.md

@@ -55,7 +55,7 @@ puts data.password
 ```
 
 # Code of Conduct
-Help us keep _fastlane_ open and inclusive. Please read and follow our [Code of Conduct](https://github.com/fastlane/fastlane/blob/master/CODE_OF_CONDUCT.md).
+Help us keep _fastlane_ open and inclusive. Please read and follow our [Code of Conduct](https://github.com/fastlane/fastlane/blob/master/docs/CODE_OF_CONDUCT.md).
 
 # License
 

data/credentials_manager/lib/credentials_manager/account_manager.rb

@@ -50,8 +50,12 @@ module CredentialsManager
       end
 
       unless @password
-        item = Security::InternetPassword.find(server: server_name)
-        @password ||= item.password if item
+        begin
+          item = Security::InternetPassword.find(server: server_name)
+          @password ||= item.password if item
+        rescue Security::Error => ex
+          puts("Could not read the Keychain entry for user '#{user}': #{ex.message}".yellow)
+        end
       end
       ask_for_login while ask_if_missing && @password.to_s.length == 0
       return @password

data/deliver/lib/deliver/app_screenshot.rb

@@ -220,9 +220,7 @@ module Deliver
     end
 
     def is_messages?
-      # rubocop:disable Require/MissingRequireStatement
       return DisplayType::ALL_IMESSAGE.include?(self.display_type)
-      # rubocop:enable Require/MissingRequireStatement
     end
 
     def self.calculate_display_type(path)
@@ -247,7 +245,6 @@ module Deliver
         is_2gen = path_lower.include?("app_ipad_pro_129") ||
                   (path_lower.include?("12.9") && path_lower.include?("2nd generation")) # e.g. iPad Pro (12.9-inch) (2nd generation)
 
-        # rubocop:disable Require/MissingRequireStatement
         if is_2gen
           return is_imessage ? DisplayType::IMESSAGE_APP_IPAD_PRO_129 : DisplayType::APP_IPAD_PRO_129
         else
@@ -256,7 +253,6 @@ module Deliver
       # Apple TV vs Vision Pro conflict
       when [3840, 2160]
         return path_lower.include?("vision") ? DisplayType::APP_APPLE_VISION_PRO : DisplayType::APP_APPLE_TV
-        # rubocop:enable Require/MissingRequireStatement
       else
         matching_display_type
       end

data/deliver/lib/deliver/commands_generator.rb

@@ -133,7 +133,7 @@ module Deliver
           Deliver::Runner.new(options)
           html_path = Deliver::GenerateSummary.new.run(options)
           UI.success("Successfully generated HTML report at '#{html_path}'")
-          system("open '#{html_path}'") unless options[:force]
+          system("open", html_path) unless options[:force]
         end
       end
 

data/deliver/lib/deliver/detect_values.rb

@@ -83,7 +83,9 @@ module Deliver
       if options[:ipa]
         options[:platform] ||= FastlaneCore::IpaFileAnalyser.fetch_app_platform(options[:ipa])
       elsif options[:pkg]
-        options[:platform] = 'osx'
+        # :pkg defaults to any *.pkg in the current directory, so only infer
+        # osx from it when the user hasn't chosen a platform themselves
+        options[:platform] = 'osx' unless options.specified?(:platform)
       end
     end
 

data/deliver/lib/deliver/download_screenshots.rb

@@ -68,7 +68,14 @@ module Deliver
           end
 
           path = File.join(containing_folder, file_name)
-          File.binwrite(path, URI.open(url).read)
+          # URI.open falls back to Kernel#open for anything that isn't a URL, which runs "|command" strings
+          uri = begin
+                  URI.parse(url)
+                rescue URI::InvalidURIError
+                  nil
+                end
+          UI.user_error!("Unexpected screenshot URL '#{url}'") unless uri.kind_of?(URI::HTTP)
+          File.binwrite(path, uri.read)
         end
       end
     end

data/deliver/lib/deliver/sync_screenshots.rb

@@ -71,11 +71,11 @@ module Deliver
     def enable_localizations(locales)
       localizations = fetch_localizations
       locales_to_enable = locales - localizations.map(&:locale)
-      Helper.show_loading_indicator("Activating localizations for #{locales_to_enable.join(', ')}...")
-      locales_to_enable.each do |locale|
-        version.create_app_store_version_localization(attributes: { locale: locale })
+      Helper.with_loading_indicator("Activating localizations for #{locales_to_enable.join(', ')}...") do
+        locales_to_enable.each do |locale|
+          version.create_app_store_version_localization(attributes: { locale: locale })
+        end
       end
-      Helper.hide_loading_indicator
     end
 
     def replace_screenshots(iterator, screenshots, retries = 3)
@@ -127,35 +127,34 @@ module Deliver
 
     def wait_for_complete(iterator)
       retry_count = 0
-      Helper.show_loading_indicator("Waiting for all the screenshots processed...")
-      loop do
-        failing_screenshots = []
-        state_counts = iterator.each_app_screenshot.map { |_, _, app_screenshot| app_screenshot }.each_with_object({}) do |app_screenshot, hash|
-          state = app_screenshot.asset_delivery_state['state']
-          hash[state] ||= 0
-          hash[state] += 1
-          failing_screenshots << app_screenshot if app_screenshot.error?
+      Helper.with_loading_indicator("Waiting for all the screenshots processed...") do
+        loop do
+          failing_screenshots = []
+          state_counts = iterator.each_app_screenshot.map { |_, _, app_screenshot| app_screenshot }.each_with_object({}) do |app_screenshot, hash|
+            state = app_screenshot.asset_delivery_state['state']
+            hash[state] ||= 0
+            hash[state] += 1
+            failing_screenshots << app_screenshot if app_screenshot.error?
+          end
+
+          result = UploadResult.new(asset_delivery_state_counts: state_counts, failing_screenshots: failing_screenshots)
+          return result unless result.processing?
+
+          # sleep with exponential backoff
+          interval = 5 + (2**retry_count)
+          UI.message("There are still incomplete screenshots. Will check the states again in #{interval} secs - #{state_counts}")
+          sleep(interval)
+          retry_count += 1
         end
-
-        result = UploadResult.new(asset_delivery_state_counts: state_counts, failing_screenshots: failing_screenshots)
-        return result unless result.processing?
-
-        # sleep with exponential backoff
-        interval = 5 + (2**retry_count)
-        UI.message("There are still incomplete screenshots. Will check the states again in #{interval} secs - #{state_counts}")
-        sleep(interval)
-        retry_count += 1
       end
-    ensure
-      Helper.hide_loading_indicator
     end
 
     def sort_screenshots(iterator)
-      Helper.show_loading_indicator("Sorting screenshots uploaded...")
-      sort_worker = create_sort_worker
-      sort_worker.batch_enqueue(iterator.each_app_screenshot_set.to_a.map { |_, set| set })
-      sort_worker.start
-      Helper.hide_loading_indicator
+      Helper.with_loading_indicator("Sorting screenshots uploaded...") do
+        sort_worker = create_sort_worker
+        sort_worker.batch_enqueue(iterator.each_app_screenshot_set.to_a.map { |_, set| set })
+        sort_worker.start
+      end
     end
 
     private

data/deliver/lib/deliver/upload_app_clip_default_experience_header_images.rb

@@ -93,9 +93,9 @@ module Deliver
 
       UI.verbose('Uploading jobs are completed')
 
-      Helper.show_loading_indicator("Waiting for all the app clip header images to finish being processed...")
-      wait_for_complete(app_clip_default_experience.id)
-      Helper.hide_loading_indicator
+      Helper.with_loading_indicator("Waiting for all the app clip header images to finish being processed...") do
+        wait_for_complete(app_clip_default_experience.id)
+      end
 
       UI.message("Successfully uploaded all app clip header images")
     end

data/deliver/lib/deliver/upload_metadata.rb

@@ -535,16 +535,14 @@ module Deliver
       if locales_to_enable.count > 0
         lng_text = "language"
         lng_text += "s" if locales_to_enable.count != 1
-        Helper.show_loading_indicator("Activating info #{lng_text} #{locales_to_enable.join(', ')}...")
-
-        locales_to_enable.each do |locale|
-          app_info.create_app_info_localization(attributes: {
-            locale: locale
-          })
+        Helper.with_loading_indicator("Activating info #{lng_text} #{locales_to_enable.join(', ')}...") do
+          locales_to_enable.each do |locale|
+            app_info.create_app_info_localization(attributes: {
+              locale: locale
+            })
+          end
         end
 
-        Helper.hide_loading_indicator
-
         # Refresh version localizations
         localizations = app_info.get_app_info_localizations
       end
@@ -570,16 +568,14 @@ module Deliver
       if locales_to_enable.count > 0
         lng_text = "language"
         lng_text += "s" if locales_to_enable.count != 1
-        Helper.show_loading_indicator("Activating version #{lng_text} #{locales_to_enable.join(', ')}...")
-
-        locales_to_enable.each do |locale|
-          version.create_app_store_version_localization(attributes: {
-            locale: locale
-          })
+        Helper.with_loading_indicator("Activating version #{lng_text} #{locales_to_enable.join(', ')}...") do
+          locales_to_enable.each do |locale|
+            version.create_app_store_version_localization(attributes: {
+              locale: locale
+            })
+          end
         end
 
-        Helper.hide_loading_indicator
-
         # Refresh version localizations
         localizations = version.get_app_store_version_localizations
       end

data/deliver/lib/deliver/upload_screenshots.rb

@@ -41,25 +41,23 @@ module Deliver
       if locales_to_enable.count > 0
         lng_text = "language"
         lng_text += "s" if locales_to_enable.count != 1
-        Helper.show_loading_indicator("Activating #{lng_text} #{locales_to_enable.join(', ')}...")
-
-        locales_to_enable.each do |locale|
-          version.create_app_store_version_localization(attributes: {
-            locale: locale
-          })
+        Helper.with_loading_indicator("Activating #{lng_text} #{locales_to_enable.join(', ')}...") do
+          locales_to_enable.each do |locale|
+            version.create_app_store_version_localization(attributes: {
+              locale: locale
+            })
+          end
         end
 
-        Helper.hide_loading_indicator
-
         # Refresh version localizations
         localizations = version.get_app_store_version_localizations
       end
 
       upload_screenshots(localizations, screenshots_per_language, options[:screenshot_processing_timeout])
 
-      Helper.show_loading_indicator("Sorting screenshots uploaded...")
-      sort_screenshots(localizations)
-      Helper.hide_loading_indicator
+      Helper.with_loading_indicator("Sorting screenshots uploaded...") do
+        sort_screenshots(localizations)
+      end
 
       UI.success("Successfully uploaded screenshots to App Store Connect")
     end
@@ -159,9 +157,9 @@ module Deliver
 
       UI.verbose('Uploading jobs are completed')
 
-      Helper.show_loading_indicator("Waiting for all the screenshots to finish being processed...")
-      states = wait_for_complete(iterator, timeout_seconds)
-      Helper.hide_loading_indicator
+      states = Helper.with_loading_indicator("Waiting for all the screenshots to finish being processed...") do
+        wait_for_complete(iterator, timeout_seconds)
+      end
       retry_upload_screenshots_if_needed(iterator, states, total_number_of_screenshots, tries, timeout_seconds, localizations, screenshots_per_language)
 
       UI.message("Successfully uploaded all screenshots")

data/docs/README.md

@@ -0,0 +1,25 @@
+<h3 align="center">
+  <a href="https://github.com/fastlane/fastlane/blob/master/fastlane/assets/fastlane_text.png">
+  <img src="https://github.com/fastlane/fastlane/blob/master/fastlane/assets/fastlane_text.png?raw=true" alt="fastlane Logo" width="500">
+  </a>
+</h3>
+
+# _fastlane_ Documentation
+
+## Contributing
+
+- [Contributing to _fastlane_](CONTRIBUTING.md)
+- [Designing _fastlane_ code](Design.md)
+- [Tooling and Debugging](ToolsAndDebugging.md)
+
+## Testing
+
+- [Testing _fastlane_](Testing.md)
+- [When a spec passes alone and fails in the split](ParallelTesting.md)
+
+## Project
+
+- [_fastlane_'s Philosophy](VISION.md)
+- [Maintaining _fastlane_](Maintaining.md)
+- [Code of Conduct](CODE_OF_CONDUCT.md)
+- [Security Policy](SECURITY.md)