fastlane 2.237.0 → 2.239.0

data/fastlane/lib/fastlane/actions/register_devices.rb

@@ -11,6 +11,10 @@ module Fastlane
         ['Device ID', 'Device Name', 'Device Platform']
       end
 
+      def self.ignored_line?(row)
+        row.all? { |value| value.to_s.strip.empty? } || row.first.to_s.strip.start_with?('#')
+      end
+
       def self.run(params)
         platform = Spaceship::ConnectAPI::BundleIdPlatform.map(params[:platform])
 
@@ -22,6 +26,7 @@ module Fastlane
           require 'csv'
 
           devices_file = CSV.read(File.expand_path(File.join(params[:devices_file])), col_sep: "\t")
+          devices_file = devices_file.reject { |row| ignored_line?(row) }
           unless devices_file.first == file_column_headers.first(2) || devices_file.first == file_column_headers
             UI.user_error!("Please provide a file according to the Apple Sample UDID file (https://developer.apple.com/account/resources/downloads/Multiple-Upload-Samples.zip)")
           end
@@ -55,8 +60,14 @@ module Fastlane
         existing_devices = Spaceship::ConnectAPI::Device.all
 
         device_objs = new_devices.map do |device|
-          if existing_devices.map(&:udid).map(&:downcase).include?(device[0].downcase)
-            UI.verbose("UDID #{device[0]} already exists - Skipping...")
+          normalized_udid = device[0].tr("-", "")
+          existing_device = existing_devices.find do |ed|
+            ed.udid.tr("-", "").casecmp(normalized_udid).zero?
+          end
+
+          if existing_device
+            UI.verbose("UDID #{existing_device.udid} already exists - Skipping...")
+
             next
           end
 
@@ -74,8 +85,12 @@ module Fastlane
           try_create_device(name: device[1], platform: device_platform, udid: device[0])
         end
 
-        UI.success("Successfully registered new devices.")
-        return device_objs
+        if device_objs.compact.empty?
+          UI.success("No new devices to register")
+        else
+          UI.success("Successfully registered new devices.")
+        end
+        return device_objs.compact
       end
 
       def self.try_create_device(name: nil, platform: nil, udid: nil)
@@ -169,7 +184,8 @@ module Fastlane
         [
           "This will register iOS/Mac devices with the Developer Portal so that you can include them in your provisioning profiles.",
           "This is an optimistic action, in that it will only ever add new devices to the member center, and never remove devices. If a device which has already been registered within the member center is not passed to this action, it will be left alone in the member center and continue to work.",
-          "The action will connect to the Apple Developer Portal using the username you specified in your `Appfile` with `apple_id`, but you can override it using the `username` option, or by setting the env variable `ENV['DELIVER_USER']`."
+          "The action will connect to the Apple Developer Portal using the username you specified in your `Appfile` with `apple_id`, but you can override it using the `username` option, or by setting the env variable `ENV['DELIVER_USER']`.",
+          "When using `devices_file`, blank lines and lines starting with `#` are ignored, so you can group devices, add notes, or comment out a device row without removing it."
         ].join("\n")
       end
 

data/fastlane/lib/fastlane/actions/setup_ci.rb

@@ -41,7 +41,7 @@ module Fastlane
         UI.message("Creating temporary keychain: \"#{keychain_name}\".")
         Actions::CreateKeychainAction.run(
           name: keychain_name,
-          default_keychain: true,
+          default_keychain: params[:set_default_keychain],
           unlock: true,
           timeout: params[:timeout],
           lock_when_sleeps: true,
@@ -113,7 +113,12 @@ module Fastlane
                                        env_name: "FL_SETUP_CI_KEYCHAIN_NAME",
                                        description: "Set a custom keychain name",
                                        type: String,
-                                       default_value: "fastlane_tmp_keychain")
+                                       default_value: "fastlane_tmp_keychain"),
+          FastlaneCore::ConfigItem.new(key: :set_default_keychain,
+                                       env_name: "FL_SETUP_CI_SET_DEFAULT_KEYCHAIN",
+                                       description: "Set the temporary keychain as the system default",
+                                       type: Boolean,
+                                       default_value: true)
         ]
       end
 

data/fastlane/lib/fastlane/actions/spm.rb

@@ -10,6 +10,7 @@ module Fastlane
         cmd << "--package-path #{params[:package_path]}" if params[:package_path]
         cmd << "--configuration #{params[:configuration]}" if params[:configuration]
         cmd << "--disable-sandbox" if params[:disable_sandbox]
+        cmd << "--skip-update" if params[:skip_update]
         cmd << "--verbose" if params[:verbose]
         cmd << "--very-verbose" if params[:very_verbose]
         if params[:simulator]
@@ -113,6 +114,11 @@ module Fastlane
                                        description: "Pass in xcpretty additional command line arguments (e.g. '--test --no-color' or '--tap --no-utf'), requires xcpretty_output to be specified also",
                                        type: String,
                                        optional: true),
+          FastlaneCore::ConfigItem.new(key: :skip_update,
+                                       env_name: "FL_SPM_SKIP_UPDATE",
+                                       description: "Skip updating dependencies from their remote during a resolution",
+                                       type: Boolean,
+                                       default_value: false),
           FastlaneCore::ConfigItem.new(key: :verbose,
                                        short_option: "-v",
                                        env_name: "FL_SPM_VERBOSE",

data/fastlane/lib/fastlane/actions/testfairy.rb

@@ -9,16 +9,18 @@ module Fastlane
     class TestfairyAction < Action
       def self.upload_build(upload_url, ipa, options, timeout)
         require 'faraday'
-        require 'faraday_middleware'
+        require 'faraday/multipart'
+        require 'faraday/retry'
+        require 'faraday/follow_redirects'
 
         UI.success("Uploading to #{upload_url}...")
 
         connection = Faraday.new(url: upload_url) do |builder|
           builder.request(:multipart)
           builder.request(:url_encoded)
-          builder.request(:retry, max: 3, interval: 5)
+          builder.request(:retry, { max: 3, interval: 5 })
           builder.response(:json, content_type: /\bjson$/)
-          builder.use(FaradayMiddleware::FollowRedirects)
+          builder.response(:follow_redirects)
           builder.adapter(:net_http)
         end
 

data/fastlane/lib/fastlane/actions/tryouts.rb

@@ -24,14 +24,15 @@ module Fastlane
 
       def self.upload_build(params)
         require 'faraday'
-        require 'faraday_middleware'
+        require 'faraday/multipart'
+        require 'faraday/follow_redirects'
 
         url = TRYOUTS_API_BUILD_RELEASE_TEMPLATE % params[:app_id]
         connection = Faraday.new(url) do |builder|
           builder.request(:multipart)
           builder.request(:url_encoded)
           builder.response(:json, content_type: /\bjson$/)
-          builder.use(FaradayMiddleware::FollowRedirects)
+          builder.response(:follow_redirects)
           builder.adapter(:net_http)
         end
 

data/fastlane/lib/fastlane/actions/update_project_team.rb

@@ -8,10 +8,8 @@ module Fastlane
         project_path = params[:path]
         selected_targets = params[:targets]
 
-        UI.user_error!("Could not find path to xcodeproj '#{project_path}'. Pass the path to your project (not workspace)!") unless File.exist?(project_path)
-
         # Load .xcodeproj
-        project = Xcodeproj::Project.open(project_path)
+        project = Fastlane::Helper::XcodeprojHelper.get_project!(project_path)
 
         # Fetch target
         targets = project.native_targets
@@ -25,10 +23,20 @@ module Fastlane
 
         # Set teamid in target
         targets.each do |target|
-          UI.message("Updating development team (#{params[:teamid]}) for target `#{target.name}` in the project '#{project_path}'")
-          # Update the build settings
           target.build_configurations.each do |configuration|
-            configuration.build_settings['DEVELOPMENT_TEAM'] = params[:teamid]
+            # Iterate over any keys that start with DEVELOPMENT_TEAM
+            # This will also set keys that have filtering like [sdk=iphoneos*]
+            keys = configuration.build_settings.keys.select { |key| key.to_s.start_with?("DEVELOPMENT_TEAM") }
+            keys.each do |key|
+              configuration.build_settings[key] = params[:teamid]
+              UI.message("Updated build setting '#{key}' to '#{params[:teamid]}' for configuration '#{configuration.name}'")
+            end
+
+            # Explicitly set the key with value if keys don't exist
+            unless keys.include?('DEVELOPMENT_TEAM')
+              configuration.build_settings['DEVELOPMENT_TEAM'] = params[:teamid]
+              UI.message("Added build setting 'DEVELOPMENT_TEAM' with value '#{params[:teamid]}' for configuration '#{configuration.name}'")
+            end
           end
 
           project.save
@@ -42,7 +50,7 @@ module Fastlane
       end
 
       def self.details
-        "This action updates the Developer Team ID of your Xcode project."
+        "This action updates (or adds) the Developer Team ID of your Xcode project."
       end
 
       def self.available_options
@@ -69,8 +77,8 @@ module Fastlane
         ]
       end
 
-      def self.author
-        "lgaches"
+      def self.authors
+        ["lgaches", "iBotPeaches"]
       end
 
       def self.is_supported?(platform)

data/fastlane/lib/fastlane/actions/upload_symbols_to_crashlytics.rb

@@ -36,20 +36,29 @@ module Fastlane
         end
 
         worker = FastlaneCore::QueueWorker.new(max_worker_threads) do |dsym_path|
-          handle_dsym(params, dsym_path, max_worker_threads)
+          handle_dsym(params, dsym_path)
         end
         worker.batch_enqueue(dsym_paths)
-        worker.start
-        UI.success("Successfully uploaded dSYM files to Crashlytics 💯")
+        results = worker.start
+
+        if results.all?
+          UI.success("Successfully uploaded dSYM files to Crashlytics 💯")
+        elsif results.any?
+          UI.success("Successfully uploaded some dSYM files to Crashlytics 💯")
+          UI.important("Some dSYM files failed to upload, see the errors above")
+        else
+          UI.user_error!("Service failed to upload any dSYM files to Crashlytics")
+        end
       end
 
       # @param current_path this is a path to either a dSYM or a zipped dSYM
       #   this might also be either nested or not, we're flexible
-      def self.handle_dsym(params, current_path, max_worker_threads)
+      def self.handle_dsym(params, current_path)
         if current_path.end_with?(".dSYM", ".zip")
-          upload_dsym(params, current_path)
+          return upload_dsym(params, current_path)
         else
           UI.error("Don't know how to handle '#{current_path}'")
+          return false
         end
       end
 
@@ -69,12 +78,21 @@ module Fastlane
         end
         command << "-p #{params[:platform] == 'appletvos' ? 'tvos' : params[:platform]}"
         command << File.expand_path(path).shellescape
+
         begin
           command_to_execute = command.join(" ")
           UI.verbose("upload_dsym using command: #{command_to_execute}")
           Actions.sh(command_to_execute, log: params[:debug])
+          return true
         rescue => ex
-          UI.error(ex.to_s) # it fails, however we don't want to fail everything just for this
+          # If it fails - emit the warning, then continue (or crash) depending on "fail_on_error"
+          UI.error(ex.to_s)
+
+          if params[:fail_on_error] == true
+            raise
+          end
+
+          return false
         end
       end
 
@@ -118,7 +136,10 @@ module Fastlane
       end
 
       def self.details
-        "This action allows you to upload symbolication files to Crashlytics. It's extra useful if you use it to download the latest dSYM files from Apple when you use Bitcode. This action will not fail the build if one of the uploads failed. The reason for that is that sometimes some of dSYM files are invalid, and we don't want them to fail the complete build."
+        [
+          "This action allows you to upload symbolication files to Crashlytics. It's extra useful if you use it to download the latest dSYM files from Apple when you use Bitcode. This action will not fail the build if one of the uploads failed by default.",
+          "The reason for that is that sometimes some of dSYM files are invalid, and we don't want them to fail the complete build. However, fail_on_build parameter can be used to prevent this behavior."
+        ].join("\n")
       end
 
       def self.available_options
@@ -195,6 +216,11 @@ module Fastlane
                                          min_threads = 1
                                          UI.user_error!("Too few threads (#{value}) minimum number of threads: #{min_threads}") unless value >= min_threads
                                        end),
+          FastlaneCore::ConfigItem.new(key: :fail_on_error,
+                                       env_name: "FL_UPLOAD_SYMBOLS_TO_CRASHLYTICS_FAIL_ON_ERROR",
+                                       description: "Should the action fail when an upload fails?",
+                                       type: Boolean,
+                                       default_value: false),
           FastlaneCore::ConfigItem.new(key: :debug,
                                        env_name: "FL_UPLOAD_SYMBOLS_TO_CRASHLYTICS_DEBUG",
                                        description: "Enable debug mode for upload-symbols",

data/fastlane/lib/fastlane/helper/git_helper.rb

@@ -9,9 +9,10 @@ module Fastlane
       end.freeze
     end
 
-    def self.git_log_between(pretty_format, from, to, merge_commit_filtering, date_format = nil, ancestry_path, app_path)
+    def self.git_log_between(pretty_format, from, to, matching_pattern, merge_commit_filtering, date_format = nil, ancestry_path, app_path)
       command = %w(git log)
       command << "--pretty=#{pretty_format}"
+      command << "--grep=#{matching_pattern}" if matching_pattern
       command << "--date=#{date_format}" if date_format
       command << '--ancestry-path' if ancestry_path
       command << "#{from}...#{to}"
@@ -24,9 +25,10 @@ module Fastlane
       nil
     end
 
-    def self.git_log_last_commits(pretty_format, commit_count, merge_commit_filtering, date_format = nil, ancestry_path, app_path)
+    def self.git_log_last_commits(pretty_format, commit_count, matching_pattern, merge_commit_filtering, date_format = nil, ancestry_path, app_path)
       command = %w(git log)
       command << "--pretty=#{pretty_format}"
+      command << "--grep=#{matching_pattern}" if matching_pattern
       command << "--date=#{date_format}" if date_format
       command << '--ancestry-path' if ancestry_path
       command << '-n' << commit_count.to_s

data/fastlane/lib/fastlane/helper/sh_helper.rb

@@ -51,15 +51,23 @@ module Fastlane
         # sh "ls -la /Applications/Xcode\ 7.3.1.app"
         # sh "ls", "-la", "/Applications/Xcode 7.3.1.app"
         # sh({ "FOO" => "Hello" }, "echo $FOO")
+        sanitized_output = false
         Open3.popen2e(*command) do |stdin, io, thread|
           io.sync = true
           io.each do |line|
-            UI.command_output(line.strip) if print_command_output
+            if print_command_output
+              # Ensure the string being stripped is in valid UTF-8 format; Otherwise warn at the end
+              text = line.encode('UTF-8', invalid: :replace)
+              UI.command_output(text.strip)
+              sanitized_output = true if text != line
+            end
             result << line
           end
           exit_status = thread.value
         end
 
+        UI.important("Command output wasn't valid UTF-8 and was sanitized. Please report the issue.") if sanitized_output
+
         # Checking Process::Status#exitstatus instead of #success? makes for more
         # testable code. (Tests mock exitstatus only.) This is also consistent
         # with previous implementations of sh and... probably portable to all

data/fastlane/lib/fastlane/plugins/template/%gem_name%.gemspec.erb

@@ -15,7 +15,7 @@ Gem::Specification.new do |spec|
   spec.files         = Dir["lib/**/*"] + %w(README.md LICENSE)
   spec.require_paths = ['lib']
   spec.metadata['rubygems_mfa_required'] = 'true'
-  spec.required_ruby_version = '>= 3.0'
+  spec.required_ruby_version = '>= 3.1'
 
   # Don't add a dependency to fastlane or fastlane_re
   # since this would cause a circular dependency

data/fastlane/lib/fastlane/plugins/template/.rubocop.yml

@@ -3,7 +3,7 @@ require:
 - rubocop/require_tools
 - rubocop-performance
 AllCops:
-  TargetRubyVersion: 3.0
+  TargetRubyVersion: 3.1
   SuggestExtensions: false
   NewCops: enable
   Include:
@@ -21,6 +21,10 @@ AllCops:
   - "**/*.provisionprofile"
 Lint/ErbNewArguments:
   Enabled: false
+Style/HashSyntax:
+  EnforcedShorthandSyntax: either
+Naming/BlockForwarding:
+  EnforcedStyle: explicit
 Style/SlicingWithRange:
   Enabled: false
 Style/MultipleComparison:

data/fastlane/lib/fastlane/version.rb

@@ -1,5 +1,5 @@
 module Fastlane
-  VERSION = '2.237.0'.freeze
+  VERSION = '2.239.0'.freeze
   SUMMARY = "The easiest way to build and release mobile apps.".freeze
   DESCRIPTION = "The easiest way to automate beta deployments and releases for your iOS and Android apps".freeze
   MINIMUM_XCODE_RELEASE = "7.0".freeze

data/fastlane/swift/Deliverfile.swift

@@ -17,4 +17,4 @@ public class Deliverfile: DeliverfileProtocol {
     // during the `init` process, and you won't see this message
 }
 
-// Generated with fastlane 2.237.0
+// Generated with fastlane 2.239.0

data/fastlane/swift/DeliverfileProtocol.swift

@@ -125,7 +125,7 @@ public protocol DeliverfileProtocol: AnyObject {
     /// The name of your Developer Portal team if you're in multiple teams
     var devPortalTeamName: String? { get }
 
-    /// The provider short name to be used with the iTMSTransporter to identify your team. This value will override the automatically detected provider short name. To get provider short name run `pathToXcode.app/Contents/Applications/Application\ Loader.app/Contents/itms/bin/iTMSTransporter -m provider -u 'USERNAME' -p 'PASSWORD' -account_type itunes_connect -v off`. The short names of providers should be listed in the second column
+    /// The provider short name to be used with the iTMSTransporter to identify your team. This value will override the automatically detected provider short name. To get provider short name run `xcrun iTMSTransporter -m provider -u 'USERNAME' -p 'PASSWORD' -account_type itunes_connect -v off`. The short names of providers should be listed in the second column
     var itcProvider: String? { get }
 
     /// The provider public ID to be used with altool (--provider-public-id). This value will override the automatically detected provider value for altool uploads. Required after Xcode 26 when your account is associated with multiple providers and using username/app-password authentication
@@ -179,6 +179,9 @@ public protocol DeliverfileProtocol: AnyObject {
     /// Metadata: Path to the app review attachment file
     var appReviewAttachmentFile: String? { get }
 
+    /// Metadata: Path to the routing app coverage file (`.geojson`) that is required for routing apps
+    var routingAppCoverageFile: String? { get }
+
     /// Metadata: The localised app description
     var description: [String: Any]? { get }
 
@@ -465,6 +468,10 @@ public extension DeliverfileProtocol {
         return nil
     }
 
+    var routingAppCoverageFile: String? {
+        return nil
+    }
+
     var description: [String: Any]? {
         return nil
     }
@@ -532,4 +539,4 @@ public extension DeliverfileProtocol {
 
 // Please don't remove the lines below
 // They are used to detect outdated files
-// FastlaneRunnerAPIVersion [0.9.151]
+// FastlaneRunnerAPIVersion [0.9.153]