fastlane 2.236.1 → 2.238.0

data/fastlane/lib/fastlane/actions/tryouts.rb

@@ -24,14 +24,15 @@ module Fastlane
 
       def self.upload_build(params)
         require 'faraday'
-        require 'faraday_middleware'
+        require 'faraday/multipart'
+        require 'faraday/follow_redirects'
 
         url = TRYOUTS_API_BUILD_RELEASE_TEMPLATE % params[:app_id]
         connection = Faraday.new(url) do |builder|
           builder.request(:multipart)
           builder.request(:url_encoded)
           builder.response(:json, content_type: /\bjson$/)
-          builder.use(FaradayMiddleware::FollowRedirects)
+          builder.response(:follow_redirects)
           builder.adapter(:net_http)
         end
 

data/fastlane/lib/fastlane/actions/update_project_team.rb

@@ -8,10 +8,8 @@ module Fastlane
         project_path = params[:path]
         selected_targets = params[:targets]
 
-        UI.user_error!("Could not find path to xcodeproj '#{project_path}'. Pass the path to your project (not workspace)!") unless File.exist?(project_path)
-
         # Load .xcodeproj
-        project = Xcodeproj::Project.open(project_path)
+        project = Fastlane::Helper::XcodeprojHelper.get_project!(project_path)
 
         # Fetch target
         targets = project.native_targets
@@ -25,10 +23,20 @@ module Fastlane
 
         # Set teamid in target
         targets.each do |target|
-          UI.message("Updating development team (#{params[:teamid]}) for target `#{target.name}` in the project '#{project_path}'")
-          # Update the build settings
           target.build_configurations.each do |configuration|
-            configuration.build_settings['DEVELOPMENT_TEAM'] = params[:teamid]
+            # Iterate over any keys that start with DEVELOPMENT_TEAM
+            # This will also set keys that have filtering like [sdk=iphoneos*]
+            keys = configuration.build_settings.keys.select { |key| key.to_s.start_with?("DEVELOPMENT_TEAM") }
+            keys.each do |key|
+              configuration.build_settings[key] = params[:teamid]
+              UI.message("Updated build setting '#{key}' to '#{params[:teamid]}' for configuration '#{configuration.name}'")
+            end
+
+            # Explicitly set the key with value if keys don't exist
+            unless keys.include?('DEVELOPMENT_TEAM')
+              configuration.build_settings['DEVELOPMENT_TEAM'] = params[:teamid]
+              UI.message("Added build setting 'DEVELOPMENT_TEAM' with value '#{params[:teamid]}' for configuration '#{configuration.name}'")
+            end
           end
 
           project.save
@@ -42,7 +50,7 @@ module Fastlane
       end
 
       def self.details
-        "This action updates the Developer Team ID of your Xcode project."
+        "This action updates (or adds) the Developer Team ID of your Xcode project."
       end
 
       def self.available_options
@@ -69,8 +77,8 @@ module Fastlane
         ]
       end
 
-      def self.author
-        "lgaches"
+      def self.authors
+        ["lgaches", "iBotPeaches"]
       end
 
       def self.is_supported?(platform)

data/fastlane/lib/fastlane/actions/upload_symbols_to_crashlytics.rb

@@ -36,20 +36,29 @@ module Fastlane
         end
 
         worker = FastlaneCore::QueueWorker.new(max_worker_threads) do |dsym_path|
-          handle_dsym(params, dsym_path, max_worker_threads)
+          handle_dsym(params, dsym_path)
         end
         worker.batch_enqueue(dsym_paths)
-        worker.start
-        UI.success("Successfully uploaded dSYM files to Crashlytics 💯")
+        results = worker.start
+
+        if results.all?
+          UI.success("Successfully uploaded dSYM files to Crashlytics 💯")
+        elsif results.any?
+          UI.success("Successfully uploaded some dSYM files to Crashlytics 💯")
+          UI.important("Some dSYM files failed to upload, see the errors above")
+        else
+          UI.user_error!("Service failed to upload any dSYM files to Crashlytics")
+        end
       end
 
       # @param current_path this is a path to either a dSYM or a zipped dSYM
       #   this might also be either nested or not, we're flexible
-      def self.handle_dsym(params, current_path, max_worker_threads)
+      def self.handle_dsym(params, current_path)
         if current_path.end_with?(".dSYM", ".zip")
-          upload_dsym(params, current_path)
+          return upload_dsym(params, current_path)
         else
           UI.error("Don't know how to handle '#{current_path}'")
+          return false
         end
       end
 
@@ -69,12 +78,21 @@ module Fastlane
         end
         command << "-p #{params[:platform] == 'appletvos' ? 'tvos' : params[:platform]}"
         command << File.expand_path(path).shellescape
+
         begin
           command_to_execute = command.join(" ")
           UI.verbose("upload_dsym using command: #{command_to_execute}")
           Actions.sh(command_to_execute, log: params[:debug])
+          return true
         rescue => ex
-          UI.error(ex.to_s) # it fails, however we don't want to fail everything just for this
+          # If it fails - emit the warning, then continue (or crash) depending on "fail_on_error"
+          UI.error(ex.to_s)
+
+          if params[:fail_on_error] == true
+            raise
+          end
+
+          return false
         end
       end
 
@@ -118,7 +136,10 @@ module Fastlane
       end
 
       def self.details
-        "This action allows you to upload symbolication files to Crashlytics. It's extra useful if you use it to download the latest dSYM files from Apple when you use Bitcode. This action will not fail the build if one of the uploads failed. The reason for that is that sometimes some of dSYM files are invalid, and we don't want them to fail the complete build."
+        [
+          "This action allows you to upload symbolication files to Crashlytics. It's extra useful if you use it to download the latest dSYM files from Apple when you use Bitcode. This action will not fail the build if one of the uploads failed by default.",
+          "The reason for that is that sometimes some of dSYM files are invalid, and we don't want them to fail the complete build. However, fail_on_build parameter can be used to prevent this behavior."
+        ].join("\n")
       end
 
       def self.available_options
@@ -195,6 +216,11 @@ module Fastlane
                                          min_threads = 1
                                          UI.user_error!("Too few threads (#{value}) minimum number of threads: #{min_threads}") unless value >= min_threads
                                        end),
+          FastlaneCore::ConfigItem.new(key: :fail_on_error,
+                                       env_name: "FL_UPLOAD_SYMBOLS_TO_CRASHLYTICS_FAIL_ON_ERROR",
+                                       description: "Should the action fail when an upload fails?",
+                                       type: Boolean,
+                                       default_value: false),
           FastlaneCore::ConfigItem.new(key: :debug,
                                        env_name: "FL_UPLOAD_SYMBOLS_TO_CRASHLYTICS_DEBUG",
                                        description: "Enable debug mode for upload-symbols",

data/fastlane/lib/fastlane/helper/sh_helper.rb

@@ -65,12 +65,16 @@ module Fastlane
         # with previous implementations of sh and... probably portable to all
         # relevant platforms.
         if exit_status.exitstatus != 0
+          # Due to some output and build systems having 30-80k lines of output.
+          # We will truncate what we will show to recap the failure.
+          truncated_msg = result.length > 500 ? result[-500..-1] : result
+
           message = if print_command
-                      "Exit status of command '#{shell_command}' was #{exit_status.exitstatus} instead of 0."
+                      "Exit status of command '#{shell_command}' was #{exit_status.exitstatus} instead of 0.\n"
                     else
-                      "Shell command exited with exit status #{exit_status.exitstatus} instead of 0."
+                      "Shell command exited with exit status #{exit_status.exitstatus} instead of 0.\n"
                     end
-          message += "\n#{result}" if print_command_output
+          message += (truncated_msg).to_s if print_command_output && !$stdout.isatty
 
           if error_callback || block_given?
             UI.error(message)

data/fastlane/lib/fastlane/lane_manager.rb

@@ -55,7 +55,6 @@ module Fastlane
 
         print_lane_context
         print_error_line(ex)
-        UI.error(ex.to_s) if ex.kind_of?(StandardError) # we don't want to print things like 'system exit'
         e = ex
       end
 

data/fastlane/lib/fastlane/plugins/template/.github/workflows/test.yml

@@ -20,10 +20,3 @@ jobs:
 
       - name: Run tests
         run: bundle exec rake
-
-      - name: Upload artifact
-        uses: actions/upload-artifact@v5
-        if: failure()
-        with:
-          name: test-results-ruby-${{ matrix.ruby-version }}
-          path: test-results

data/fastlane/lib/fastlane/plugins/template/.gitignore

@@ -9,4 +9,3 @@ Gemfile.lock
 fastlane/README.md
 fastlane/report.xml
 coverage
-test-results

data/fastlane/lib/fastlane/plugins/template/.rspec

@@ -1,5 +1,3 @@
 --require spec_helper
 --color
 --format d
---format RspecJunitFormatter
---out test-results/rspec/rspec.xml

data/fastlane/lib/fastlane/plugins/template/Gemfile.erb

@@ -10,8 +10,6 @@ gem 'pry'
 gem 'rake'
 # Behavior-driven testing tool for Ruby.
 gem 'rspec'
-# Formatter for RSpec to generate JUnit compatible reports.
-gem 'rspec_junit_formatter'
 # A Ruby static code analyzer and formatter.
 gem 'rubocop', '<%= Fastlane::RUBOCOP_REQUIREMENT %>'
 # A collection of RuboCop cops for performance optimizations.

data/fastlane/lib/fastlane/version.rb

@@ -1,5 +1,5 @@
 module Fastlane
-  VERSION = '2.236.1'.freeze
+  VERSION = '2.238.0'.freeze
   SUMMARY = "The easiest way to build and release mobile apps.".freeze
   DESCRIPTION = "The easiest way to automate beta deployments and releases for your iOS and Android apps".freeze
   MINIMUM_XCODE_RELEASE = "7.0".freeze

data/fastlane/swift/Deliverfile.swift

@@ -17,4 +17,4 @@ public class Deliverfile: DeliverfileProtocol {
     // during the `init` process, and you won't see this message
 }
 
-// Generated with fastlane 2.236.1
+// Generated with fastlane 2.238.0

data/fastlane/swift/DeliverfileProtocol.swift

@@ -125,7 +125,7 @@ public protocol DeliverfileProtocol: AnyObject {
     /// The name of your Developer Portal team if you're in multiple teams
     var devPortalTeamName: String? { get }
 
-    /// The provider short name to be used with the iTMSTransporter to identify your team. This value will override the automatically detected provider short name. To get provider short name run `pathToXcode.app/Contents/Applications/Application\ Loader.app/Contents/itms/bin/iTMSTransporter -m provider -u 'USERNAME' -p 'PASSWORD' -account_type itunes_connect -v off`. The short names of providers should be listed in the second column
+    /// The provider short name to be used with the iTMSTransporter to identify your team. This value will override the automatically detected provider short name. To get provider short name run `xcrun iTMSTransporter -m provider -u 'USERNAME' -p 'PASSWORD' -account_type itunes_connect -v off`. The short names of providers should be listed in the second column
     var itcProvider: String? { get }
 
     /// The provider public ID to be used with altool (--provider-public-id). This value will override the automatically detected provider value for altool uploads. Required after Xcode 26 when your account is associated with multiple providers and using username/app-password authentication
@@ -532,4 +532,4 @@ public extension DeliverfileProtocol {
 
 // Please don't remove the lines below
 // They are used to detect outdated files
-// FastlaneRunnerAPIVersion [0.9.150]
+// FastlaneRunnerAPIVersion [0.9.152]