fastlane 2.229.1 → 2.230.0

data/deliver/lib/deliver/app_screenshot_validator.rb

@@ -3,25 +3,22 @@ require 'fastimage'
 module Deliver
   class AppScreenshotValidator
     # A simple structure that holds error information as well as formatted error messages consistently
-    # Set `to_skip` to `true` when just needing to skip uploading rather than causing a crash.
     class ValidationError
       # Constants that can be given to `type` param
       INVALID_SCREEN_SIZE = 'Invalid screen size'.freeze
-      UNACCEPTABLE_DEVICE = 'Not an accepted App Store Connect device'.freeze
       INVALID_FILE_EXTENSION = 'Invalid file extension'.freeze
       FILE_EXTENSION_MISMATCH = 'File extension mismatches its image format'.freeze
 
-      attr_reader :type, :path, :debug_info, :to_skip
+      attr_reader :type, :path, :debug_info
 
-      def initialize(type: nil, path: nil, debug_info: nil, to_skip: false)
+      def initialize(type: nil, path: nil, debug_info: nil)
         @type = type
         @path = path
         @debug_info = debug_info
-        @to_skip = to_skip
       end
 
       def to_s
-        "#{to_skip ? '🏃 Skipping' : '🚫 Error'}: #{path} - #{type} (#{debug_info})"
+        "🚫 Error: #{path} - #{type} (#{debug_info})"
       end
 
       def inspect
@@ -46,7 +43,6 @@ module Deliver
       errors_found = []
 
       validate_screen_size(screenshot, errors_found)
-      validate_device_type(screenshot, errors_found)
       validate_file_extension_and_format(screenshot, errors_found)
 
       # Merge errors found into given errors array
@@ -55,22 +51,10 @@ module Deliver
     end
 
     def self.validate_screen_size(screenshot, errors_found)
-      if screenshot.screen_size.nil?
+      if screenshot.display_type.nil?
         errors_found << ValidationError.new(type: ValidationError::INVALID_SCREEN_SIZE,
                                             path: screenshot.path,
-                                            debug_info: "Actual size is #{get_formatted_size(screenshot)}. See the specifications to fix #{APP_SCREENSHOT_SPEC_URL}")
-      end
-    end
-
-    # Checking if the device type exists in spaceship
-    # Ex: iPhone 6.1 inch isn't supported in App Store Connect but need
-    # to have it in there for frameit support
-    def self.validate_device_type(screenshot, errors_found)
-      if !screenshot.screen_size.nil? && screenshot.device_type.nil?
-        errors_found << ValidationError.new(type: ValidationError::UNACCEPTABLE_DEVICE,
-                                            path: screenshot.path,
-                                            debug_info: "Screen size #{screenshot.screen_size} is not accepted. See the specifications to fix #{APP_SCREENSHOT_SPEC_URL}",
-                                            to_skip: true)
+                                            debug_info: "Screenshot size is not supported. Actual size is #{get_formatted_size(screenshot)}. See the specifications to fix #{APP_SCREENSHOT_SPEC_URL}")
       end
     end
 

data/deliver/lib/deliver/loader.rb

@@ -100,16 +100,9 @@ module Deliver
       errors = []
       valid_screenshots = screenshots.select { |screenshot| Deliver::AppScreenshotValidator.validate(screenshot, errors) }
 
-      errors_to_skip, errors_to_crash = errors.partition(&:to_skip)
-
-      unless errors_to_skip.empty?
-        UI.important("🏃 Screenshots to be skipped are detected!")
-        errors_to_skip.each { |error| UI.message(error) }
-      end
-
-      unless errors_to_crash.empty?
+      unless errors.empty?
         UI.important("🚫 Invalid screenshots were detected! Here are the reasons:")
-        errors_to_crash.each { |error| UI.error(error) }
+        errors.each { |error| UI.error(error) }
         UI.user_error!("Canceled uploading screenshots. Please check the error messages above and fix the screenshots.")
       end
 

data/deliver/lib/deliver/upload_metadata.rb

@@ -705,6 +705,11 @@ module Deliver
     def app_rating(app_info)
       return unless options[:app_rating_config_path]
 
+      unless app_info
+        UI.important("Skipping age rating update because app info could not be fetched.")
+        return
+      end
+
       require 'json'
       begin
         json = JSON.parse(File.read(options[:app_rating_config_path]))

data/deliver/lib/deliver/upload_screenshots.rb

@@ -93,7 +93,9 @@ module Deliver
 
       # Verify all screenshots have been deleted
       # Sometimes API requests will fail but screenshots will still be deleted
-      count = iterator.each_app_screenshot_set.map { |_, app_screenshot_set| app_screenshot_set }
+      count = iterator.each_app_screenshot_set
+                      .select { |localization, _| screenshots_per_language.keys.include?(localization.locale) }
+                      .map { |_, app_screenshot_set| app_screenshot_set }
                       .reduce(0) { |sum, app_screenshot_set| sum + app_screenshot_set.app_screenshots.size }
 
       UI.important("Number of screenshots not deleted: #{count}")
@@ -134,7 +136,7 @@ module Deliver
         number_of_screenshots_per_set[app_screenshot_set] ||= (app_screenshot_set.app_screenshots || []).count
 
         if number_of_screenshots_per_set[app_screenshot_set] >= 10
-          UI.error("Too many screenshots found for device '#{screenshot.device_type}' in '#{screenshot.language}', skipping this one (#{screenshot.path})")
+          UI.error("Too many screenshots found for device '#{screenshot.display_type}' in '#{screenshot.language}', skipping this one (#{screenshot.path})")
           next
         end
 

data/fastlane/lib/fastlane/actions/docs/create_app_online.md

@@ -302,7 +302,7 @@ lane :release do
     app_version: '1.0',
     sku: '123',
     team_name: 'SunApps GmbH', # only necessary when in multiple teams
-    
+
     # Optional
     # App services can be enabled during app creation
     enable_services: {
@@ -317,6 +317,7 @@ lane :release do
       car_play_navigation_app: "on",            # Valid values: "on", "off"
       car_play_voip_calling_app: "on",          # Valid values: "on", "off"
       class_kit: "on",                          # Valid values: "on", "off"
+      declared_age_range: "on",                 # Valid values: "on", "off"
       icloud: "xcode5_compatible",              # Valid values: "xcode5_compatible", "xcode6_compatible", "off"
       critical_alerts: "on",                    # Valid values: "on", "off"
       custom_network_protocol: "on",            # Valid values: "on", "off"

data/fastlane/lib/fastlane/actions/docs/sync_code_signing.md

@@ -215,7 +215,9 @@ fastlane match development
 This will create a new certificate and provisioning profile (if required) and store them in your selected storage.
 If you previously ran _match_ with the configured storage it will automatically install the existing profiles from your storage.
 
-The provisioning profiles are installed in `~/Library/MobileDevice/Provisioning Profiles` while the certificates and private keys are installed in your Keychain.
+The provisioning profiles are installed in `~/Library/Developer/Xcode/UserData/Provisioning Profiles` (`~/Library/MobileDevice/Provisioning Profiles` for Xcode versions prior to 16.0) while the certificates and private keys are installed in your Keychain.
+
+> fastlane relies on the system's default Xcode version to determine the current version. The path where provisioning profiles are stored changed in Xcode 16. If you use the `xcode_select` or `xcodes` actions and you have Xcode 15 and 16 installed in your system, please make sure to execute them before invoking the `sync_code_signing` action.  
 
 To get a more detailed output of what _match_ is doing use
 

data/fastlane/lib/fastlane/actions/docs/upload_to_app_store.md.erb

@@ -597,7 +597,9 @@ Key | Editable While Live | Directory | Filename | Deprecated Filename
 - 2: Frequent/Intense (Legacy value, use `FREQUENT_OR_INTENSE`instead)
 
 - `NONE`
+- `INFREQUENT`
 - `INFREQUENT_OR_MILD`
+- `FREQUENT`
 - `FREQUENT_OR_INTENSE`
 
 **Keys**
@@ -605,19 +607,33 @@ Key | Editable While Live | Directory | Filename | Deprecated Filename
 - `alcoholTobaccoOrDrugUseOrReferences`
 - `contests`
 - `gamblingSimulated`
-- `medicalOrTreatmentInformation`
-- `profanityOrCrudeHumor`
-
+- `gunsOrOtherWeapons`
 - `horrorOrFearThemes`
-- `kidsAgeBand`
 - `matureOrSuggestiveThemes`
+- `medicalOrTreatmentInformation`
+- `profanityOrCrudeHumor`
 - `sexualContentGraphicAndNudity`
 - `sexualContentOrNudity`
 - `violenceCartoonOrFantasy`
 - `violenceRealistic`
 - `violenceRealisticProlongedGraphicOrSadistic`
 
-#### Fifteen Plus or Nineteen Plus
+#### Age Rating
+
+**Values**
+
+- `NONE`
+- `NINE_PLUS`
+- `THIRTEEN_PLUS`
+- `SIXTEEN_PLUS`
+- `EIGHTEEN_PLUS`
+- `UNRATED`
+
+**Keys**
+
+- `ageRatingOverrideV2`
+
+#### Korea Age Rating
 
 **Values**
 
@@ -629,13 +645,25 @@ Key | Editable While Live | Directory | Filename | Deprecated Filename
 
 - `koreaAgeRatingOverride`
 
+#### URL
+
+**Keys**
+
+- `developerAgeRatingInfoUrl`
+
 #### Boolean
 
 **Keys**
 
+- `advertising`
+- `ageAssurance`
 - `gambling`
-- `unrestrictedWebAccess`
+- `healthOrWellnessTopics`
 - `lootBox`
+- `messagingAndChat`
+- `parentalControls`
+- `unrestrictedWebAccess`
+- `userGeneratedContent`
 
 #### Kids Age
 

data/fastlane/lib/fastlane/actions/docs/upload_to_testflight.md

@@ -82,6 +82,8 @@ _pilot_ uses [_spaceship_](https://spaceship.airforce) to submit the build metad
 ### Upload from Linux
 
 To upload binaries from Linux:
+
+- have the package file and the `AppStoreInfo.plist` file in the same location on disk (_check [fastlane gym](https://docs.fastlane.tools/actions/gym/) on how to make them_)
 - make sure you have [Transporter on Linux](https://help.apple.com/itc/transporteruserguide/en.lproj/static.html) installed
 - set the following environment variables:
     - `FASTLANE_ITUNES_TRANSPORTER_USE_SHELL_SCRIPT=true`

data/fastlane/lib/fastlane/actions/install_xcode_plugin.rb

@@ -3,6 +3,7 @@ module Fastlane
     class InstallXcodePluginAction < Action
       def self.run(params)
         require 'fileutils'
+        require 'tmpdir'
 
         if params[:github]
           base_api_url = params[:github].sub('https://github.com', 'https://api.github.com/repos')
@@ -25,10 +26,10 @@ module Fastlane
         end
 
         zip_path = File.join(Dir.tmpdir, 'plugin.zip')
-        sh("curl -Lso #{zip_path} #{params[:url]}")
+        Action.sh("curl", "-L", "-s", "-o", zip_path, params[:url])
         plugins_path = "#{ENV['HOME']}/Library/Application Support/Developer/Shared/Xcode/Plug-ins"
         FileUtils.mkdir_p(plugins_path)
-        Action.sh("unzip -qo '#{zip_path}' -d '#{plugins_path}'")
+        Action.sh("unzip", "-qo", zip_path, "-d", plugins_path)
 
         UI.success("Plugin #{File.basename(params[:url], '.zip')} installed successfully")
         UI.message("Please restart Xcode to use the newly installed plugin")

data/fastlane/lib/fastlane/actions/modify_services.rb

@@ -49,6 +49,7 @@ module Fastlane
           associated_domains: 'associated_domains',
           auto_fill_credential: 'auto_fill_credential',
           class_kit: 'class_kit',
+          declared_age_range: 'declared_age_range',
           icloud: 'icloud',
           custom_network_protocol: 'custom_network_protocol',
           data_protection: 'data_protection',

data/fastlane/lib/fastlane/actions/notarize.rb

@@ -74,7 +74,7 @@ module Fastlane
         ] + auth_parts
 
         if verbose
-          submit_command << "--verbose"
+          submit_parts << "--verbose"
         end
 
         submit_command = submit_parts.join(' ')

data/fastlane/lib/fastlane/actions/xcov.rb

@@ -20,7 +20,7 @@ module Fastlane
       def self.details
         [
           "Create nice code coverage reports and post coverage summaries on Slack *(xcov gem is required)*.",
-          "More information: [https://github.com/nakiostudio/xcov](https://github.com/nakiostudio/xcov)."
+          "More information: [https://github.com/fastlane-community/xcov](https://github.com/fastlane-community/xcov)."
         ].join("\n")
       end
 
@@ -31,12 +31,6 @@ module Fastlane
       def self.available_options
         return [] unless Helper.mac?
 
-        # We call Gem::Specification.find_by_name in many more places than this, but for right now
-        # this is the only place we're having trouble. If there are other reports about RubyGems
-        # 2.6.2 causing problems, we may need to move this code and require it someplace better,
-        # like fastlane_core
-        require 'fastlane/core_ext/bundler_monkey_patch'
-
         begin
           Gem::Specification.find_by_name('xcov')
         rescue Gem::LoadError

data/fastlane/lib/fastlane/documentation/markdown_docs_generator.rb

@@ -97,7 +97,7 @@ module Fastlane
       if File.exist?(custom_file_location)
         UI.verbose("Using custom md.erb file for action #{action.action_name}")
 
-        result = ERB.new(File.read(custom_file_location), 0, '-').result(binding) # https://web.archive.org/web/20160430190141/www.rrn.dk/rubys-erb-templating-system
+        result = ERB.new(File.read(custom_file_location), trim_mode: '-').result(binding) # https://web.archive.org/web/20160430190141/www.rrn.dk/rubys-erb-templating-system
 
         return result
       end
@@ -122,7 +122,7 @@ module Fastlane
         end
 
         template = File.join(Fastlane::ROOT, "lib/assets/ActionDetails.md.erb")
-        result = ERB.new(File.read(template), 0, '-').result(binding)
+        result = ERB.new(File.read(template), trim_mode: '-').result(binding)
 
         action_mds[action.action_name] = result
       end
@@ -139,7 +139,7 @@ module Fastlane
 
       # Generate actions.md
       template = File.join(Fastlane::ROOT, "lib/assets/Actions.md.erb")
-      result = ERB.new(File.read(template), 0, '-').result(binding) # https://web.archive.org/web/20160430190141/www.rrn.dk/rubys-erb-templating-system
+      result = ERB.new(File.read(template), trim_mode: '-').result(binding) # https://web.archive.org/web/20160430190141/www.rrn.dk/rubys-erb-templating-system
       File.write(File.join(docs_dir, "generated", "actions.md"), result)
 
       # Generate actions sub pages (e.g. generated/actions/slather.md, generated/actions/scan.md)
@@ -165,7 +165,7 @@ module Fastlane
         end
 
         template = File.join(Fastlane::ROOT, "lib/assets/ActionDetails.md.erb")
-        result = ERB.new(File.read(template), 0, '-').result(binding) # https://web.archive.org/web/20160430190141/www.rrn.dk/rubys-erb-templating-system
+        result = ERB.new(File.read(template), trim_mode: '-').result(binding) # https://web.archive.org/web/20160430190141/www.rrn.dk/rubys-erb-templating-system
 
         # Actions get placed in "generated/actions" directory
         file_name = File.join(generated_actions_dir, "#{action.action_name}.md")

data/fastlane/lib/fastlane/plugins/template/.github/workflows/test.yml

@@ -6,24 +6,24 @@ on:
 jobs:
   test:
     runs-on: ubuntu-latest
+    strategy:
+      matrix:
+        ruby-version: ['3.0', '3.1', '3.2', '3.3', '3.4']
     steps:
-    - uses: actions/checkout@v2
-    - uses: actions/cache@v1
-      with:
-        path: vendor/bundle
-        key: ${{ runner.os }}-gem-${{ hashFiles('**/Gemfile') }}
-        restore-keys: |
-          ${{ runner.os }}-gem-
-    - name: Set up Ruby
-      uses: ruby/setup-ruby@v1
-      with:
-        ruby-version: 2.5
-    - name: Install dependencies
-      run: bundle check || bundle install --jobs=4 --retry=3 --path vendor/bundle
-    - name: Run tests
-      run: bundle exec rake
-    - name: Upload artifact
-      uses: actions/upload-artifact@v2
-      with:
-        name: test-results
-        path: test-results
+      - uses: actions/checkout@v6
+
+      - name: Set up Ruby
+        uses: ruby/setup-ruby@v1
+        with:
+          ruby-version: ${{ matrix.ruby-version }}
+          bundler-cache: true
+
+      - name: Run tests
+        run: bundle exec rake
+
+      - name: Upload artifact
+        uses: actions/upload-artifact@v5
+        if: failure()
+        with:
+          name: test-results-ruby-${{ matrix.ruby-version }}
+          path: test-results

data/fastlane/lib/fastlane/version.rb

@@ -1,5 +1,5 @@
 module Fastlane
-  VERSION = '2.229.1'.freeze
+  VERSION = '2.230.0'.freeze
   SUMMARY = "The easiest way to build and release mobile apps.".freeze
   DESCRIPTION = "The easiest way to automate beta deployments and releases for your iOS and Android apps".freeze
   MINIMUM_XCODE_RELEASE = "7.0".freeze

data/fastlane/swift/Deliverfile.swift

@@ -17,4 +17,4 @@ public class Deliverfile: DeliverfileProtocol {
     // during the `init` process, and you won't see this message
 }
 
-// Generated with fastlane 2.229.1
+// Generated with fastlane 2.230.0

data/fastlane/swift/DeliverfileProtocol.swift

@@ -272,4 +272,4 @@ public extension DeliverfileProtocol {
 
 // Please don't remove the lines below
 // They are used to detect outdated files
-// FastlaneRunnerAPIVersion [0.9.138]
+// FastlaneRunnerAPIVersion [0.9.139]