fastlane 2.211.0 → 2.212.0

data/fastlane_core/lib/fastlane_core/cert_checker.rb

@@ -1,6 +1,7 @@
 require 'tempfile'
 require 'openssl'
 
+require_relative 'features'
 require_relative 'helper'
 
 # WWDR Intermediate Certificates in https://www.apple.com/certificateauthority/
@@ -155,11 +156,17 @@ module FastlaneCore
       keychain = wwdr_keychain
       keychain = "-k #{keychain.shellescape}" unless keychain.empty?
 
-      require 'open3'
+      # Attempts to fix an issue installing WWDR cert tends to fail on CIs
+      # https://github.com/fastlane/fastlane/issues/20960
+      curl_extras = ""
+      if FastlaneCore::Feature.enabled?('FASTLANE_WWDR_USE_HTTP1_AND_RETRIES')
+        curl_extras = "--http1.1 --retry 3 --retry-all-errors "
+      end
 
-      import_command = "curl -f -o #{filename} #{url} && security import #{filename} #{keychain}"
+      import_command = "curl #{curl_extras}-f -o #{filename} #{url} && security import #{filename} #{keychain}"
       UI.verbose("Installing WWDR Cert: #{import_command}")
 
+      require 'open3'
       stdout, stderr, status = Open3.capture3(import_command)
       if FastlaneCore::Globals.verbose?
         UI.command_output(stdout)

data/fastlane_core/lib/fastlane_core/ui/implementations/shell.rb

@@ -86,11 +86,13 @@ module FastlaneCore
 
     def header(message)
       format = format_string
-      if message.length + 8 < TTY::Screen.width - format.length
+      # clamp to zero to prevent negative argument error below
+      available_width = [0, TTY::Screen.width - format.length].max
+      if message.length + 8 < available_width
         message = "--- #{message} ---"
         i = message.length
       else
-        i = TTY::Screen.width - format.length
+        i = available_width
       end
       success("-" * i)
       success(message)

data/gym/lib/gym/generators/build_command_generator.rb

@@ -39,6 +39,7 @@ module Gym
         options << "-destination '#{config[:destination]}'" if config[:destination]
         options << "-archivePath #{archive_path.shellescape}" unless config[:skip_archive]
         options << "-resultBundlePath '#{result_bundle_path}'" if config[:result_bundle]
+        options << "-showBuildTimingSummary" if config[:build_timing_summary]
         if config[:use_system_scm] && !options.include?("-scmProvider system")
           options << "-scmProvider system"
         end

data/gym/lib/gym/options.rb

@@ -239,6 +239,13 @@ module Gym
                                      default_value: Fastlane::Helper::XcodebuildFormatterHelper.xcbeautify_installed? ? 'xcbeautify' : 'xcpretty',
                                      default_value_dynamic: true),
 
+        FastlaneCore::ConfigItem.new(key: :build_timing_summary,
+                                     env_name: "GYM_BUILD_TIMING_SUMMARY",
+                                     description: "Create a build timing summary",
+                                     type: Boolean,
+                                     default_value: false,
+                                     optional: true),
+
         # xcpretty
         FastlaneCore::ConfigItem.new(key: :disable_xcpretty,
                                      env_name: "DISABLE_XCPRETTY",

data/match/lib/match/importer.rb

@@ -80,6 +80,10 @@ module Match
         certificate_type = [
           Spaceship::ConnectAPI::Certificate::CertificateType::MAC_INSTALLER_DISTRIBUTION
         ].join(',')
+      when :developer_id_installer
+        certificate_type = [
+          Spaceship::ConnectAPI::Certificate::CertificateType::DEVELOPER_ID_INSTALLER
+        ].join(',')
       else
         UI.user_error!("Cert type '#{cert_type}' is not supported")
       end

data/match/lib/match/module.rb

@@ -11,7 +11,7 @@ module Match
   DESCRIPTION = "Easily sync your certificates and profiles across your team"
 
   def self.environments
-    return %w(appstore adhoc development enterprise developer_id mac_installer_distribution)
+    return %w(appstore adhoc development enterprise developer_id mac_installer_distribution developer_id_installer)
   end
 
   def self.storage_modes

data/scan/lib/scan/options.rb

@@ -315,6 +315,11 @@ module Scan
                                      env_name: "SCAN_OUTPUT_XCTESTRUN",
                                      description: "Should provide additional copy of .xctestrun file (settings.xctestrun) and place in output path?",
                                      default_value: false),
+        FastlaneCore::ConfigItem.new(key: :result_bundle_path,
+                                     env_name: "SCAN_RESULT_BUNDLE_PATH",
+                                     description: "Custom path for the result bundle, overrides result_bundle",
+                                     type: String,
+                                     optional: true),
         FastlaneCore::ConfigItem.new(key: :result_bundle,
                                      short_option: "-z",
                                      env_name: "SCAN_RESULT_BUNDLE",

data/scan/lib/scan/test_command_generator.rb

@@ -53,7 +53,12 @@ module Scan
       if config[:use_system_scm] && !options.include?("-scmProvider system")
         options << "-scmProvider system"
       end
-      options << "-resultBundlePath '#{result_bundle_path(true)}'" if config[:result_bundle]
+      if config[:result_bundle_path]
+        options << "-resultBundlePath '#{config[:result_bundle_path].shellescape}'"
+        Scan.cache[:result_bundle_path] = config[:result_bundle_path]
+      elsif config[:result_bundle]
+        options << "-resultBundlePath '#{result_bundle_path(true)}'"
+      end
       if FastlaneCore::Helper.xcode_at_least?(10)
         options << "-parallel-testing-enabled #{config[:parallel_testing] ? 'YES' : 'NO'}" unless config[:parallel_testing].nil?
         options << "-parallel-testing-worker-count #{config[:concurrent_workers]}" if config[:concurrent_workers]

data/spaceship/lib/spaceship/connect_api/models/app_info_localization.rb

@@ -1,4 +1,5 @@
 require_relative '../model'
+require_relative '../../errors'
 module Spaceship
   class ConnectAPI
     class AppInfoLocalization
@@ -32,11 +33,15 @@ module Spaceship
         client ||= Spaceship::ConnectAPI
         attributes = reverse_attr_mapping(attributes)
         client.patch_app_info_localization(app_info_localization_id: id, attributes: attributes)
+      rescue
+        raise Spaceship::AppStoreLocalizationError, @locale
       end
 
       def delete!(client: nil, filter: {}, includes: nil, limit: nil, sort: nil)
         client ||= Spaceship::ConnectAPI
         client.delete_app_info_localization(app_info_localization_id: id)
+      rescue
+        raise Spaceship::AppStoreLocalizationError, @locale
       end
     end
   end

data/spaceship/lib/spaceship/connect_api/models/app_store_version_localization.rb

@@ -1,6 +1,7 @@
 require_relative '../model'
 require_relative './app_preview_set'
 require_relative './app_screenshot_set'
+require_relative '../../errors'
 
 module Spaceship
   class ConnectAPI
@@ -43,23 +44,31 @@ module Spaceship
         client ||= Spaceship::ConnectAPI
         resp = client.get_app_store_version_localization(app_store_version_localization_id: app_store_version_localization_id, filter: filter, includes: includes, limit: limit, sort: sort)
         return resp.to_models
+      rescue
+        raise Spaceship::AppStoreLocalizationError, @locale
       end
 
       def self.all(client: nil, app_store_version_id: nil, filter: {}, includes: nil, limit: nil, sort: nil)
         client ||= Spaceship::ConnectAPI
         resp = client.get_app_store_version_localizations(app_store_version_id: app_store_version_id, filter: filter, includes: includes, limit: limit, sort: sort)
         return resp.to_models
+      rescue
+        raise Spaceship::AppStoreLocalizationError, @locale
       end
 
       def update(client: nil, attributes: nil)
         client ||= Spaceship::ConnectAPI
         attributes = reverse_attr_mapping(attributes)
         client.patch_app_store_version_localization(app_store_version_localization_id: id, attributes: attributes)
+      rescue
+        raise Spaceship::AppStoreLocalizationError, @locale
       end
 
       def delete!(client: nil, filter: {}, includes: nil, limit: nil, sort: nil)
         client ||= Spaceship::ConnectAPI
         client.delete_app_store_version_localization(app_store_version_localization_id: id)
+      rescue
+        raise Spaceship::AppStoreLocalizationError, @locale
       end
 
       #
@@ -71,12 +80,16 @@ module Spaceship
         filter ||= {}
         filter["appStoreVersionLocalization"] = id
         return Spaceship::ConnectAPI::AppPreviewSet.all(client: client, filter: filter, includes: includes, limit: limit, sort: sort)
+      rescue
+        raise Spaceship::AppStoreAppPreviewError, @locale
       end
 
       def create_app_preview_set(client: nil, attributes: nil)
         client ||= Spaceship::ConnectAPI
         resp = client.post_app_preview_set(app_store_version_localization_id: id, attributes: attributes)
         return resp.to_models.first
+      rescue
+        raise Spaceship::AppStoreAppPreviewError, @locale
       end
 
       #
@@ -86,12 +99,16 @@ module Spaceship
       def get_app_screenshot_sets(client: nil, filter: {}, includes: "appScreenshots", limit: nil, sort: nil)
         client ||= Spaceship::ConnectAPI
         return Spaceship::ConnectAPI::AppScreenshotSet.all(client: client, app_store_version_localization_id: id, filter: filter, includes: includes, limit: limit, sort: sort)
+      rescue
+        raise Spaceship::AppStoreScreenshotError, @locale
       end
 
       def create_app_screenshot_set(client: nil, attributes: nil)
         client ||= Spaceship::ConnectAPI
         resp = client.post_app_screenshot_set(app_store_version_localization_id: id, attributes: attributes)
         return resp.to_models.first
+      rescue
+        raise Spaceship::AppStoreScreenshotError, @locale
       end
     end
   end

data/spaceship/lib/spaceship/connect_api/models/build_bundle.rb

@@ -1,4 +1,5 @@
 require_relative '../model'
+require_relative './build_bundle_file_sizes'
 module Spaceship
   class ConnectAPI
     class BuildBundle
@@ -54,6 +55,14 @@ module Spaceship
       def self.type
         return "buildBundles"
       end
+
+      #
+      # API
+      #
+
+      def build_bundle_file_sizes(client: nil)
+        @build_bundle_file_sizes ||= BuildBundleFileSizes.all(client: client, build_bundle_id: id)
+      end
     end
   end
 end

data/spaceship/lib/spaceship/connect_api/models/build_bundle_file_sizes.rb

@@ -0,0 +1,34 @@
+require_relative '../model'
+module Spaceship
+  class ConnectAPI
+    class BuildBundleFileSizes
+      include Spaceship::ConnectAPI::Model
+
+      attr_accessor :device_model
+      attr_accessor :os_version
+      attr_accessor :download_bytes
+      attr_accessor :install_bytes
+
+      attr_mapping({
+        "deviceModel" => "device_model",
+        "osVersion" => "os_version",
+        "downloadBytes" => "download_bytes",
+        "installBytes" => "install_bytes"
+      })
+
+      def self.type
+        return "buildBundleFileSizes"
+      end
+
+      #
+      # API
+      #
+
+      def self.all(client: nil, build_bundle_id: nil, limit: 30)
+        client ||= Spaceship::ConnectAPI
+        resps = client.get_build_bundles_build_bundle_file_sizes(build_bundle_id: build_bundle_id).all_pages
+        resps.flat_map(&:to_models)
+      end
+    end
+  end
+end

data/spaceship/lib/spaceship/connect_api/models/device.rb

@@ -61,7 +61,7 @@ module Spaceship
       # @param platform [String] The platform of the device.
       # @param include_disabled [Bool] Whether to include disable devices. false by default.
       # @return (Device) Find a device based on the UDID of the device. nil if no device was found.
-      def self.find_by_udid(device_udid, client: nil, platform: nil, include_disabled: false)
+      def self.find_by_udid(device_udid, client: nil, include_disabled: false)
         self.all(client: client).find do |device|
           device.udid.casecmp(device_udid) == 0 && (include_disabled ? true : device.enabled?)
         end
@@ -70,10 +70,9 @@ module Spaceship
       # @param client [ConnectAPI] ConnectAPI client.
       # @param name [String] The name to be assigned to the device, if it needs to be created.
       # @param platform [String] The platform of the device.
-      # @param include_disabled [Bool] Whether to include disable devices. false by default.
       # @return (Device) Find a device based on the UDID of the device. If no device was found,  nil if no device was found.
-      def self.find_or_create(device_udid, client: nil, name: nil, platform: nil, include_disabled: false)
-        existing = self.find_by_udid(device_udid, client: client, platform: platform)
+      def self.find_or_create(device_udid, client: nil, name: nil, platform: nil)
+        existing = self.find_by_udid(device_udid, client: client)
         return existing if existing
         return self.create(client: client, name: name, platform: platform, udid: device_udid)
       end
@@ -88,6 +87,47 @@ module Spaceship
         resp = client.post_device(name: name, platform: platform, udid: udid)
         return resp.to_models.first
       end
+
+      # @param device_udid [String] Device Provisioning UDID that needs to be modified.
+      # @param client [ConnectAPI] ConnectAPI client.
+      # @param enabled [Boolean] New enabled value. true - if device must be enabled, `false` - to disable device. nil if no status change needed.
+      # @param new_name [String] A new name for the device. nil if no name change needed.
+      # @return (Device) Modified device based on the UDID of the device. nil if no device was found.
+      def self.modify(device_udid, client: nil, enabled: nil, new_name: nil)
+        client ||= Spaceship::ConnectAPI
+        existing = self.find_by_udid(device_udid, client: client, include_disabled: true)
+        return nil if existing.nil?
+
+        enabled = existing.enabled? if enabled.nil?
+        new_name ||= existing.name
+        return existing if existing.name == new_name && existing.enabled? == enabled
+        new_status = enabled ? Status::ENABLED : Status::DISABLED
+
+        resp = client.patch_device(id: existing.id, new_name: new_name, status: new_status)
+        return resp.to_models.first
+      end
+
+      # @param device_udid [String] Device Provisioning UDID that needs to be enabled.
+      # @param client [ConnectAPI] ConnectAPI client.
+      # @return (Device) Modified device based on the UDID of the device. nil if no device was found.
+      def self.enable(device_udid, client: nil)
+        self.modify(device_udid, client: client, enabled: true)
+      end
+
+      # @param device_udid [String] Device Provisioning UDID that needs to be disabled.
+      # @param client [ConnectAPI] ConnectAPI client.
+      # @return (Device) Modified device based on the UDID of the device. nil if no device was found.
+      def self.disable(device_udid, client: nil)
+        self.modify(device_udid, client: client, enabled: false)
+      end
+
+      # @param device_udid [String] Device Provisioning UDID that needs to be renamed.
+      # @param new_name [String] A new name for the device.
+      # @param client [ConnectAPI] ConnectAPI client.
+      # @return (Device) Modified device based on the UDID of the device. nil if no device was found.
+      def self.rename(device_udid, new_name, client: nil)
+        self.modify(device_udid, client: client, new_name: new_name)
+      end
     end
   end
 end

data/spaceship/lib/spaceship/connect_api/provisioning/provisioning.rb

@@ -190,6 +190,25 @@ module Spaceship
           provisioning_request_client.post("devices", body)
         end
 
+        def patch_device(id: nil, status: nil, new_name: nil)
+          raise "Device id is nil" if id.nil?
+
+          attributes = {
+            name: new_name,
+            status: status
+          }
+
+          body = {
+            data: {
+              attributes: attributes,
+              id: id,
+              type: "devices"
+            }
+          }
+
+          provisioning_request_client.patch("devices/#{id}", body)
+        end
+
         #
         # profiles
         #

data/spaceship/lib/spaceship/connect_api/testflight/testflight.rb

@@ -412,6 +412,15 @@ module Spaceship
           test_flight_request_client.get("betaTesterMetrics", params)
         end
 
+        #
+        # buildBundles
+        #
+
+        def get_build_bundles_build_bundle_file_sizes(build_bundle_id:, limit: nil)
+          params = test_flight_request_client.build_params(filter: nil, includes: nil, limit: limit, sort: nil, cursor: nil)
+          test_flight_request_client.get("buildBundles/#{build_bundle_id}/buildBundleFileSizes", params)
+        end
+
         #
         # builds
         #

data/spaceship/lib/spaceship/connect_api.rb

@@ -33,6 +33,7 @@ require 'spaceship/connect_api/models/build'
 require 'spaceship/connect_api/models/build_delivery'
 require 'spaceship/connect_api/models/build_beta_detail'
 require 'spaceship/connect_api/models/build_bundle'
+require 'spaceship/connect_api/models/build_bundle_file_sizes'
 require 'spaceship/connect_api/models/custom_app_organization'
 require 'spaceship/connect_api/models/custom_app_user'
 require 'spaceship/connect_api/models/pre_release_version'

data/spaceship/lib/spaceship/errors.rb

@@ -98,4 +98,38 @@ module Spaceship
 
   # Raised when 403 is received from portal request
   class AccessForbiddenError < BasicPreferredInfoError; end
+
+  # Base class for errors coming from App Store Connect locale changes
+  class AppStoreLocaleError < BasicPreferredInfoError
+    def initialize(msg)
+      @message = (msg ? "An exception occurred for locale: #{msg}." : nil)
+      super
+    end
+
+    # no need to search github issues since the error is specific
+    def show_github_issues
+      false
+    end
+  end
+
+  # Raised for localized text errors from App Store Connect
+  class AppStoreLocalizationError < AppStoreLocaleError
+    def preferred_error_info
+      "#{@message} Check the localization requirements here: https://help.apple.com/app-store-connect/en.lproj/static.html#dev354659071"
+    end
+  end
+
+  # Raised for localized screenshots errors from App Store Connect
+  class AppStoreScreenshotError < AppStoreLocaleError
+    def preferred_error_info
+      "#{@message} Check the screenshot requirements here: https://help.apple.com/app-store-connect/en.lproj/static.html#devd274dd925"
+    end
+  end
+
+  # Raised for localized app preview errors from App Store Connect
+  class AppStoreAppPreviewError < AppStoreLocaleError
+    def preferred_error_info
+      "#{@message} Check the app preview requirements here: https://help.apple.com/app-store-connect/en.lproj/static.html#dev4e413fcb8"
+    end
+  end
 end

metadata

@@ -1,39 +1,39 @@
 --- !ruby/object:Gem::Specification
 name: fastlane
 version: !ruby/object:Gem::Version
-  version: 2.211.0
+  version: 2.212.0
 platform: ruby
 authors:
-- Josh Holtz
-- Łukasz Grabowski
-- Stefan Natchev
-- Jimmy Dee
-- Jérôme Lacoste
-- Daniel Jankowski
-- Aaron Brager
-- Matthew Ellis
-- Kohki Miki
-- Iulian Onofrei
-- Roger Oba
-- Andrew McBurney
-- Luka Mirosevic
 - Joshua Liebowitz
-- Danielle Tomlinson
-- Maksym Grebenets
-- Helmut Januschka
-- Manu Wallner
+- Łukasz Grabowski
 - Max Ott
-- Jan Piotrowski
-- Fumiya Nakamura
-- Satoshi Namai
 - Olivier Halligon
+- Maksym Grebenets
+- Danielle Tomlinson
+- Fumiya Nakamura
 - Felix Krause
+- Jérôme Lacoste
+- Helmut Januschka
+- Iulian Onofrei
+- Jimmy Dee
 - Jorge Revuelta H
+- Luka Mirosevic
+- Kohki Miki
+- Roger Oba
 - Manish Rathi
+- Josh Holtz
+- Satoshi Namai
+- Stefan Natchev
+- Daniel Jankowski
+- Jan Piotrowski
+- Andrew McBurney
+- Manu Wallner
+- Aaron Brager
+- Matthew Ellis
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2022-11-12 00:00:00.000000000 Z
+date: 2023-02-19 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: xcodeproj
@@ -1395,6 +1395,7 @@ files:
 - fastlane_core/README.md
 - fastlane_core/lib/assets/XMLTemplate.xml.erb
 - fastlane_core/lib/fastlane_core.rb
+- fastlane_core/lib/fastlane_core/.project.rb.swp
 - fastlane_core/lib/fastlane_core/analytics/action_completion_context.rb
 - fastlane_core/lib/fastlane_core/analytics/action_launch_context.rb
 - fastlane_core/lib/fastlane_core/analytics/analytics_event_builder.rb
@@ -1478,6 +1479,7 @@ files:
 - gym/lib/assets/GymfileTemplate.swift
 - gym/lib/assets/wrap_xcodebuild/xcbuild-safe.sh
 - gym/lib/gym.rb
+- gym/lib/gym/.code_signing_mapping.rb.swp
 - gym/lib/gym/code_signing_mapping.rb
 - gym/lib/gym/commands_generator.rb
 - gym/lib/gym/detect_values.rb
@@ -1702,6 +1704,7 @@ files:
 - spaceship/lib/spaceship/connect_api/models/build.rb
 - spaceship/lib/spaceship/connect_api/models/build_beta_detail.rb
 - spaceship/lib/spaceship/connect_api/models/build_bundle.rb
+- spaceship/lib/spaceship/connect_api/models/build_bundle_file_sizes.rb
 - spaceship/lib/spaceship/connect_api/models/build_delivery.rb
 - spaceship/lib/spaceship/connect_api/models/bundle_id.rb
 - spaceship/lib/spaceship/connect_api/models/bundle_id_capability.rb