fastlane 2.206.1 → 2.208.0

data/spaceship/lib/spaceship/connect_api/tunes/tunes.rb

@@ -134,7 +134,15 @@ module Spaceship
           tunes_request_client.post("apps", body)
         end
 
-        def patch_app(app_id: nil, attributes: {}, app_price_tier_id: nil, territory_ids: nil)
+        # Updates app attributes, price tier, visibility in regions or countries.
+        # Use territory_ids with allow_removing_from_sale to remove app from sale
+        # @param territory_ids updates app visibility in regions or countries.
+        #   Possible values:
+        #   empty array will remove app from sale if allow_removing_from_sale is true,
+        #   array with territory ids will set availability to territories with those ids,
+        #   nil will leave app availability on AppStore as is
+        # @param allow_removing_from_sale allows for removing app from sale when territory_ids is an empty array
+        def patch_app(app_id: nil, attributes: {}, app_price_tier_id: nil, territory_ids: nil, allow_removing_from_sale: false)
           relationships = {}
           included = []
 
@@ -173,13 +181,15 @@ module Spaceship
           end
 
           # Territories
-          territories_data = (territory_ids || []).map do |id|
-            { type: "territories", id: id }
-          end
-          unless territories_data.empty?
-            relationships[:availableTerritories] = {
-              data: territories_data
-            }
+          unless territory_ids.nil?
+            territories_data = territory_ids.map do |id|
+              { type: "territories", id: id }
+            end
+            if !territories_data.empty? || allow_removing_from_sale
+              relationships[:availableTerritories] = {
+                data: territories_data
+              }
+            end
           end
 
           # Data

data/spaceship/lib/spaceship/tunes/tunes_client.rb

@@ -9,6 +9,7 @@ require_relative 'errors'
 require_relative 'iap_subscription_pricing_tier'
 require_relative 'pricing_tier'
 require_relative 'territory'
+require_relative '../connect_api/response'
 module Spaceship
   # rubocop:disable Metrics/ClassLength
   class TunesClient < Spaceship::Client
@@ -254,8 +255,68 @@ module Spaceship
     #####################################################
 
     def applications
-      r = request(:get, 'ra/apps/manageyourapps/summary/v2')
-      parse_response(r, 'data')['summaries']
+      # Doing this real bad puts for now until a more formal deprecation logic can get made
+      puts("Spaceship::Tunes::Application.all is deprecated")
+      puts("  It's using a temporary patch to keep it from raising an error but things may not work correctly")
+      puts("  Please consider switching to Spaceship::ConnectAPI if you can")
+      puts("  For more details - https://github.com/fastlane/fastlane/pull/20480")
+
+      # This legacy endpoint went offline around July 7th, 2022. This is a rough attempt
+      # at retrofitting using the newer App Store Connect API endpoints
+      #
+      # This could all be done easily with Spaceship::ConnectAPI::App.find but there were a lot of
+      # circular dependency issues that were very difficult to solve because. Spaceship::Tunes would be
+      # using Spaceship::ConnectAPI which uses Spaceship::Tunes
+      #
+      # However, using Spaceship::ConnectAPI::Response works. This will fetch multiple pages of app
+      # if it needs to
+      #
+      # https://github.com/fastlane/fastlane/pull/20480
+      r = request(:get, "https://appstoreconnect.apple.com/iris/v1/apps?include=appStoreVersions,prices")
+      response = Spaceship::ConnectAPI::Response.new(
+        body: r.body,
+        status: r.status,
+        headers: r.headers,
+        client: nil
+      )
+
+      apps = response.all_pages do |url|
+        r = request(:get, url)
+        Spaceship::ConnectAPI::Response.new(
+          body: r.body,
+          status: r.status,
+          headers: r.headers,
+          client: nil
+        )
+      end.flat_map(&:to_models)
+
+      apps.map do |asc_app|
+        platforms = (asc_app.app_store_versions || []).map(&:platform).uniq.map do |asc_platform|
+          case asc_platform
+          when "TV_OS"
+            "appletvos"
+          when "MAC_OS"
+            "osx"
+          when "IOS"
+            "ios"
+          else
+            raise "Cannot find a matching platform for '#{asc_platform}'}"
+          end
+        end
+
+        {
+          'adamId' => asc_app.id,
+          'name' => asc_app.name,
+          'vendorId' => "",
+          'bundleId' => asc_app.bundle_id,
+          'lastModifiedDate' => nil,
+          'issuesCount' => nil,
+          'iconUrl' => nil,
+          'versionSets' => platforms.map do |platform|
+            { 'type' => 'app', 'platformString' => platform }
+          end
+        }
+      end
     end
 
     def app_details(app_id)

data/trainer/lib/trainer/junit_generator.rb

@@ -15,7 +15,7 @@ module Trainer
 
       lib_path = Trainer::ROOT
       xml_path = File.join(lib_path, "lib/assets/junit.xml.erb")
-      xml = ERB.new(File.read(xml_path), nil, '<>').result(binding) # http://www.rrn.dk/rubys-erb-templating-system
+      xml = ERB.new(File.read(xml_path), trim_mode: '<>').result(binding) # http://www.rrn.dk/rubys-erb-templating-system
 
       xml = xml.gsub('system_', 'system-').delete("\e") # Jenkins can not parse 'ESC' symbol
 

metadata

@@ -1,39 +1,39 @@
 --- !ruby/object:Gem::Specification
 name: fastlane
 version: !ruby/object:Gem::Version
-  version: 2.206.1
+  version: 2.208.0
 platform: ruby
 authors:
-- Satoshi Namai
+- Manu Wallner
+- Matthew Ellis
 - Maksym Grebenets
-- Felix Krause
-- Olivier Halligon
-- Jimmy Dee
 - Jorge Revuelta H
-- Luka Mirosevic
+- Fumiya Nakamura
+- Manish Rathi
+- Felix Krause
 - Kohki Miki
-- Joshua Liebowitz
+- Jimmy Dee
 - Jan Piotrowski
-- Helmut Januschka
-- Fumiya Nakamura
-- Iulian Onofrei
-- Stefan Natchev
-- Manu Wallner
+- Daniel Jankowski
 - Max Ott
-- Roger Oba
+- Luka Mirosevic
+- Helmut Januschka
 - Josh Holtz
 - Łukasz Grabowski
+- Joshua Liebowitz
+- Iulian Onofrei
 - Aaron Brager
-- Andrew McBurney
-- Daniel Jankowski
 - Jérôme Lacoste
+- Satoshi Namai
+- Olivier Halligon
+- Stefan Natchev
+- Andrew McBurney
+- Roger Oba
 - Danielle Tomlinson
-- Manish Rathi
-- Matthew Ellis
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2022-05-21 00:00:00.000000000 Z
+date: 2022-07-19 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: xcodeproj
@@ -1364,6 +1364,7 @@ files:
 - fastlane/swift/FastlaneSwiftRunner/FastlaneSwiftRunner.xcodeproj/project.pbxproj
 - fastlane/swift/FastlaneSwiftRunner/FastlaneSwiftRunner.xcodeproj/project.xcworkspace/contents.xcworkspacedata
 - fastlane/swift/FastlaneSwiftRunner/FastlaneSwiftRunner.xcodeproj/project.xcworkspace/xcshareddata/IDEWorkspaceChecks.plist
+- fastlane/swift/FastlaneSwiftRunner/FastlaneSwiftRunner.xcodeproj/project.xcworkspace/xcuserdata/joshholtz.xcuserdatad/UserInterfaceState.xcuserstate
 - fastlane/swift/FastlaneSwiftRunner/FastlaneSwiftRunner.xcodeproj/xcshareddata/xcschemes/FastlaneRunner.xcscheme
 - fastlane/swift/FastlaneSwiftRunner/README.txt
 - fastlane/swift/Gymfile.swift
@@ -1516,6 +1517,9 @@ files:
 - match/lib/match/spaceship_ensure.rb
 - match/lib/match/storage.rb
 - match/lib/match/storage/git_storage.rb
+- match/lib/match/storage/gitlab/client.rb
+- match/lib/match/storage/gitlab/secure_file.rb
+- match/lib/match/storage/gitlab_secure_files.rb
 - match/lib/match/storage/google_cloud_storage.rb
 - match/lib/match/storage/interface.rb
 - match/lib/match/storage/s3_storage.rb
@@ -1658,12 +1662,10 @@ files:
 - spaceship/lib/spaceship/client.rb
 - spaceship/lib/spaceship/commands_generator.rb
 - spaceship/lib/spaceship/connect_api.rb
-- spaceship/lib/spaceship/connect_api/.response.rb.swp
 - spaceship/lib/spaceship/connect_api/api_client.rb
 - spaceship/lib/spaceship/connect_api/client.rb
 - spaceship/lib/spaceship/connect_api/file_uploader.rb
 - spaceship/lib/spaceship/connect_api/model.rb
-- spaceship/lib/spaceship/connect_api/models/.app.rb.swp
 - spaceship/lib/spaceship/connect_api/models/.review_submission.rb.swp
 - spaceship/lib/spaceship/connect_api/models/age_rating_declaration.rb
 - spaceship/lib/spaceship/connect_api/models/app.rb
@@ -1780,6 +1782,7 @@ files:
 - spaceship/lib/spaceship/test_flight/group.rb
 - spaceship/lib/spaceship/test_flight/test_info.rb
 - spaceship/lib/spaceship/test_flight/tester.rb
+- spaceship/lib/spaceship/tunes/.tunes_client.rb.swp
 - spaceship/lib/spaceship/tunes/app_analytics.rb
 - spaceship/lib/spaceship/tunes/app_details.rb
 - spaceship/lib/spaceship/tunes/app_image.rb
@@ -1892,7 +1895,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: '2.5'
+      version: '2.6'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="