fastlane 2.202.0 → 2.212.1

data/spaceship/lib/spaceship/connect_api/models/device.rb

@@ -29,6 +29,9 @@ module Spaceship
         IPOD = "IPOD"
         APPLE_TV = "APPLE_TV"
         MAC = "MAC"
+
+        # As of 2022-11-12, this is not officially supported by App Store Connect API
+        APPLE_SILICON_MAC = "APPLE_SILICON_MAC"
       end
 
       module Status
@@ -58,7 +61,7 @@ module Spaceship
       # @param platform [String] The platform of the device.
       # @param include_disabled [Bool] Whether to include disable devices. false by default.
       # @return (Device) Find a device based on the UDID of the device. nil if no device was found.
-      def self.find_by_udid(device_udid, client: nil, platform: nil, include_disabled: false)
+      def self.find_by_udid(device_udid, client: nil, include_disabled: false)
         self.all(client: client).find do |device|
           device.udid.casecmp(device_udid) == 0 && (include_disabled ? true : device.enabled?)
         end
@@ -67,10 +70,9 @@ module Spaceship
       # @param client [ConnectAPI] ConnectAPI client.
       # @param name [String] The name to be assigned to the device, if it needs to be created.
       # @param platform [String] The platform of the device.
-      # @param include_disabled [Bool] Whether to include disable devices. false by default.
       # @return (Device) Find a device based on the UDID of the device. If no device was found,  nil if no device was found.
-      def self.find_or_create(device_udid, client: nil, name: nil, platform: nil, include_disabled: false)
-        existing = self.find_by_udid(device_udid, client: client, platform: platform)
+      def self.find_or_create(device_udid, client: nil, name: nil, platform: nil)
+        existing = self.find_by_udid(device_udid, client: client)
         return existing if existing
         return self.create(client: client, name: name, platform: platform, udid: device_udid)
       end
@@ -85,6 +87,47 @@ module Spaceship
         resp = client.post_device(name: name, platform: platform, udid: udid)
         return resp.to_models.first
       end
+
+      # @param device_udid [String] Device Provisioning UDID that needs to be modified.
+      # @param client [ConnectAPI] ConnectAPI client.
+      # @param enabled [Boolean] New enabled value. true - if device must be enabled, `false` - to disable device. nil if no status change needed.
+      # @param new_name [String] A new name for the device. nil if no name change needed.
+      # @return (Device) Modified device based on the UDID of the device. nil if no device was found.
+      def self.modify(device_udid, client: nil, enabled: nil, new_name: nil)
+        client ||= Spaceship::ConnectAPI
+        existing = self.find_by_udid(device_udid, client: client, include_disabled: true)
+        return nil if existing.nil?
+
+        enabled = existing.enabled? if enabled.nil?
+        new_name ||= existing.name
+        return existing if existing.name == new_name && existing.enabled? == enabled
+        new_status = enabled ? Status::ENABLED : Status::DISABLED
+
+        resp = client.patch_device(id: existing.id, new_name: new_name, status: new_status)
+        return resp.to_models.first
+      end
+
+      # @param device_udid [String] Device Provisioning UDID that needs to be enabled.
+      # @param client [ConnectAPI] ConnectAPI client.
+      # @return (Device) Modified device based on the UDID of the device. nil if no device was found.
+      def self.enable(device_udid, client: nil)
+        self.modify(device_udid, client: client, enabled: true)
+      end
+
+      # @param device_udid [String] Device Provisioning UDID that needs to be disabled.
+      # @param client [ConnectAPI] ConnectAPI client.
+      # @return (Device) Modified device based on the UDID of the device. nil if no device was found.
+      def self.disable(device_udid, client: nil)
+        self.modify(device_udid, client: client, enabled: false)
+      end
+
+      # @param device_udid [String] Device Provisioning UDID that needs to be renamed.
+      # @param new_name [String] A new name for the device.
+      # @param client [ConnectAPI] ConnectAPI client.
+      # @return (Device) Modified device based on the UDID of the device. nil if no device was found.
+      def self.rename(device_udid, new_name, client: nil)
+        self.modify(device_udid, client: client, new_name: new_name)
+      end
     end
   end
 end

data/spaceship/lib/spaceship/connect_api/models/profile.rb

@@ -51,6 +51,10 @@ module Spaceship
         MAC_CATALYST_APP_DEVELOPMENT = "MAC_CATALYST_APP_DEVELOPMENT"
         MAC_CATALYST_APP_STORE = "MAC_CATALYST_APP_STORE"
         MAC_CATALYST_APP_DIRECT = "MAC_CATALYST_APP_DIRECT"
+
+        # As of 2022-06-25, only available with Apple ID auth
+        MAC_APP_INHOUSE = "MAC_APP_INHOUSE"
+        MAC_CATALYST_APP_INHOUSE = "MAC_CATALYST_APP_INHOUSE"
       end
 
       def self.type

data/spaceship/lib/spaceship/connect_api/models/resolution_center_message.rb

@@ -0,0 +1,29 @@
+require_relative '../model'
+require_relative './actor'
+require_relative './review_rejection'
+
+module Spaceship
+  class ConnectAPI
+    class ResolutionCenterMessage
+      include Spaceship::ConnectAPI::Model
+
+      attr_accessor :message_body
+      attr_accessor :created_date
+      attr_accessor :rejections
+      attr_accessor :from_actor
+
+      attr_mapping({
+        messageBody: 'message_body',
+        createdDate: 'created_date',
+
+        # includes
+        rejections: 'rejections',
+        fromActor: 'from_actor'
+      })
+
+      def self.type
+        return 'resolutionCenterMessages'
+      end
+    end
+  end
+end

data/spaceship/lib/spaceship/connect_api/models/resolution_center_thread.rb

@@ -0,0 +1,67 @@
+require_relative '../model'
+
+module Spaceship
+  class ConnectAPI
+    class ResolutionCenterThread
+      include Spaceship::ConnectAPI::Model
+
+      attr_accessor :state
+      attr_accessor :can_developer_add_node
+      attr_accessor :objectionable_content
+      attr_accessor :thread_type
+      attr_accessor :created_date
+      attr_accessor :last_message_response_date
+
+      attr_accessor :resolution_center_messages
+      attr_accessor :app_store_version
+
+      module ThreadType
+        REJECTION_BINARY = 'REJECTION_BINARY'
+        REJECTION_METADATA = 'REJECTION_METADATA'
+        REJECTION_REVIEW_SUBMISSION = 'REJECTION_REVIEW_SUBMISSION'
+        APP_MESSAGE_ARC = 'APP_MESSAGE_ARC'
+        APP_MESSAGE_ARB = 'APP_MESSAGE_ARB'
+        APP_MESSAGE_COMM = 'APP_MESSAGE_COMM'
+      end
+
+      attr_mapping({
+        state: 'state',
+        canDeveloperAddNote: 'can_developer_add_node',
+        objectionableContent: 'objectionable_content',
+        threadType: 'thread_type',
+        createdDate: 'created_date',
+        lastMessageResponseDate: 'last_message_response_date',
+
+        # includes
+        resolutionCenterMessages: 'resolution_center_messages',
+        appStoreVersion: 'app_store_version'
+      })
+
+      def self.type
+        return "resolutionCenterThreads"
+      end
+
+      #
+      # API
+      #
+
+      def self.all(client: nil, filter:, includes: nil)
+        client ||= Spaceship::ConnectAPI
+        resps = client.get_resolution_center_threads(filter: filter, includes: includes).all_pages
+        return resps.flat_map(&:to_models)
+      end
+
+      def fetch_messages(client: nil, filter: {}, includes: nil)
+        client ||= Spaceship::ConnectAPI
+        resps = client.get_resolution_center_messages(thread_id: id, filter: filter, includes: includes).all_pages
+        return resps.flat_map(&:to_models)
+      end
+
+      def fetch_rejection_reasons(client: nil, includes: nil)
+        client ||= Spaceship::ConnectAPI
+        resp = client.get_review_rejection(filter: { 'resolutionCenterMessage.resolutionCenterThread': id }, includes: includes)
+        return resp.to_models
+      end
+    end
+  end
+end

data/spaceship/lib/spaceship/connect_api/models/review_rejection.rb

@@ -0,0 +1,19 @@
+require_relative '../model'
+
+module Spaceship
+  class ConnectAPI
+    class ReviewRejection
+      include Spaceship::ConnectAPI::Model
+
+      attr_accessor :reasons
+
+      attr_mapping({
+        reasons: 'reasons'
+      })
+
+      def self.type
+        return 'reviewRejections'
+      end
+    end
+  end
+end

data/spaceship/lib/spaceship/connect_api/models/review_submission.rb

@@ -20,6 +20,7 @@ module Spaceship
         COMPLETE = "COMPLETE"
         IN_REVIEW = "IN_REVIEW"
         READY_FOR_REVIEW = "READY_FOR_REVIEW"
+        UNRESOLVED_ISSUES = "UNRESOLVED_ISSUES"
         WAITING_FOR_REVIEW = "WAITING_FOR_REVIEW"
       end
 
@@ -68,6 +69,18 @@ module Spaceship
         resp = client.post_review_submission_item(review_submission_id: id, app_store_version_id: app_store_version_id)
         return resp.to_models.first
       end
+
+      def fetch_resolution_center_threads(client: nil)
+        client ||= Spaceship::ConnectAPI
+        resp = client.get_resolution_center_threads(filter: { reviewSubmission: id }, includes: 'reviewSubmission')
+        return resp.to_models
+      end
+
+      def latest_resolution_center_messages(client: nil)
+        client ||= Spaceship::ConnectAPI
+        threads = fetch_resolution_center_threads(client: client)
+        threads.first.fetch_messages(client: client)
+      end
     end
   end
 end

data/spaceship/lib/spaceship/connect_api/models/user.rb

@@ -57,6 +57,11 @@ module Spaceship
         return all(client: client, filter: { email: email }, includes: includes)
       end
 
+      def delete!(client: nil)
+        client ||= Spaceship::ConnectAPI
+        client.delete_user(user_id: id)
+      end
+
       def get_visible_apps(client: nil, limit: nil)
         client ||= Spaceship::ConnectAPI
         resp = client.get_user_visible_apps(user_id: id, limit: limit)

data/spaceship/lib/spaceship/connect_api/provisioning/provisioning.rb

@@ -190,6 +190,25 @@ module Spaceship
           provisioning_request_client.post("devices", body)
         end
 
+        def patch_device(id: nil, status: nil, new_name: nil)
+          raise "Device id is nil" if id.nil?
+
+          attributes = {
+            name: new_name,
+            status: status
+          }
+
+          body = {
+            data: {
+              attributes: attributes,
+              id: id,
+              type: "devices"
+            }
+          }
+
+          provisioning_request_client.patch("devices/#{id}", body)
+        end
+
         #
         # profiles
         #

data/spaceship/lib/spaceship/connect_api/response.rb

@@ -22,13 +22,17 @@ module Spaceship
         return links["next"]
       end
 
-      def next_page
+      def next_page(&block)
         url = next_url
         return nil if url.nil?
-        return client.get(url)
+        if block_given?
+          return yield(url)
+        else
+          return client.get(url)
+        end
       end
 
-      def next_pages(count: 1)
+      def next_pages(count: 1, &block)
         if !count.nil? && count < 0
           count = 0
         end
@@ -38,7 +42,7 @@ module Spaceship
 
         resp = self
         loop do
-          resp = resp.next_page
+          resp = resp.next_page(&block)
           break if resp.nil?
           responses << resp
           counter += 1
@@ -49,8 +53,8 @@ module Spaceship
         return responses
       end
 
-      def all_pages
-        return next_pages(count: nil)
+      def all_pages(&block)
+        return next_pages(count: nil, &block)
       end
 
       def to_models

data/spaceship/lib/spaceship/connect_api/testflight/testflight.rb

@@ -290,6 +290,28 @@ module Spaceship
           test_flight_request_client.post("bulkBetaTesterAssignments", body)
         end
 
+        # attributes - {email: "", firstName: "", lastName: ""}
+        def post_beta_tester_assignment(beta_group_ids: [], attributes: {})
+          body = {
+            data: {
+              attributes: attributes,
+              relationships: {
+                betaGroups: {
+                  data: beta_group_ids.map do |id|
+                    {
+                      type: "betaGroups",
+                      id: id
+                    }
+                  end
+                }
+              },
+              type: "betaTesters"
+            }
+          }
+
+          test_flight_request_client.post("betaTesters", body)
+        end
+
         def add_beta_tester_to_group(beta_group_id: nil, beta_tester_ids: nil)
           beta_tester_ids || []
           body = {
@@ -390,6 +412,15 @@ module Spaceship
           test_flight_request_client.get("betaTesterMetrics", params)
         end
 
+        #
+        # buildBundles
+        #
+
+        def get_build_bundles_build_bundle_file_sizes(build_bundle_id:, limit: nil)
+          params = test_flight_request_client.build_params(filter: nil, includes: nil, limit: limit, sort: nil, cursor: nil)
+          test_flight_request_client.get("buildBundles/#{build_bundle_id}/buildBundleFileSizes", params)
+        end
+
         #
         # builds
         #
@@ -448,9 +479,9 @@ module Spaceship
         # buildDeliveries
         #
 
-        def get_build_deliveries(filter: {}, includes: nil, limit: nil, sort: nil)
+        def get_build_deliveries(app_id:, filter: {}, includes: nil, limit: nil, sort: nil)
           params = test_flight_request_client.build_params(filter: filter, includes: includes, limit: limit, sort: sort)
-          test_flight_request_client.get("buildDeliveries", params)
+          test_flight_request_client.get("apps/#{app_id}/buildDeliveries", params)
         end
 
         #

data/spaceship/lib/spaceship/connect_api/token.rb

@@ -90,14 +90,17 @@ module Spaceship
       end
 
       def refresh!
-        @expiration = Time.now + @duration
+        now = Time.now
+        @expiration = now + @duration
 
         header = {
-          kid: key_id
+          kid: key_id,
+          typ: 'JWT'
         }
 
         payload = {
           iss: issuer_id,
+          iat: now.to_i,
           exp: @expiration.to_i,
           aud: 'appstoreconnect-v1'
         }

data/spaceship/lib/spaceship/connect_api/tunes/tunes.rb

@@ -134,7 +134,15 @@ module Spaceship
           tunes_request_client.post("apps", body)
         end
 
-        def patch_app(app_id: nil, attributes: {}, app_price_tier_id: nil, territory_ids: nil)
+        # Updates app attributes, price tier, visibility in regions or countries.
+        # Use territory_ids with allow_removing_from_sale to remove app from sale
+        # @param territory_ids updates app visibility in regions or countries.
+        #   Possible values:
+        #   empty array will remove app from sale if allow_removing_from_sale is true,
+        #   array with territory ids will set availability to territories with those ids,
+        #   nil will leave app availability on AppStore as is
+        # @param allow_removing_from_sale allows for removing app from sale when territory_ids is an empty array
+        def patch_app(app_id: nil, attributes: {}, app_price_tier_id: nil, territory_ids: nil, allow_removing_from_sale: false)
           relationships = {}
           included = []
 
@@ -173,13 +181,15 @@ module Spaceship
           end
 
           # Territories
-          territories_data = (territory_ids || []).map do |id|
-            { type: "territories", id: id }
-          end
-          unless territories_data.empty?
-            relationships[:availableTerritories] = {
-              data: territories_data
-            }
+          unless territory_ids.nil?
+            territories_data = territory_ids.map do |id|
+              { type: "territories", id: id }
+            end
+            if !territories_data.empty? || allow_removing_from_sale
+              relationships[:availableTerritories] = {
+                data: territories_data
+              }
+            end
           end
 
           # Data
@@ -1242,6 +1252,29 @@ module Spaceship
           params = tunes_request_client.build_params(filter: nil, includes: nil, limit: nil, sort: nil)
           tunes_request_client.get("territories", params)
         end
+
+        #
+        # resolutionCenter
+        #
+        # As of 2022-11-11:
+        # This is not official available throught the App Store Connect API using an API Key.
+        # This is only works with Apple ID auth.
+        #
+
+        def get_resolution_center_threads(filter: {}, includes: nil)
+          params = tunes_request_client.build_params(filter: filter, includes: includes)
+          tunes_request_client.get('resolutionCenterThreads', params)
+        end
+
+        def get_resolution_center_messages(thread_id:, filter: {}, includes: nil)
+          params = tunes_request_client.build_params(filter: filter, includes: includes)
+          tunes_request_client.get("resolutionCenterThreads/#{thread_id}/resolutionCenterMessages", params)
+        end
+
+        def get_review_rejection(filter: {}, includes: nil)
+          params = tunes_request_client.build_params(filter: filter, includes: includes)
+          tunes_request_client.get("reviewRejections", params)
+        end
       end
     end
   end

data/spaceship/lib/spaceship/connect_api.rb

@@ -33,6 +33,7 @@ require 'spaceship/connect_api/models/build'
 require 'spaceship/connect_api/models/build_delivery'
 require 'spaceship/connect_api/models/build_beta_detail'
 require 'spaceship/connect_api/models/build_bundle'
+require 'spaceship/connect_api/models/build_bundle_file_sizes'
 require 'spaceship/connect_api/models/custom_app_organization'
 require 'spaceship/connect_api/models/custom_app_user'
 require 'spaceship/connect_api/models/pre_release_version'
@@ -68,6 +69,11 @@ require 'spaceship/connect_api/models/reset_ratings_request'
 require 'spaceship/connect_api/models/sandbox_tester'
 require 'spaceship/connect_api/models/territory'
 
+require 'spaceship/connect_api/models/resolution_center_message'
+require 'spaceship/connect_api/models/resolution_center_thread'
+require 'spaceship/connect_api/models/review_rejection'
+require 'spaceship/connect_api/models/actor'
+
 module Spaceship
   class ConnectAPI
     # Defined in the App Store Connect API docs:

data/spaceship/lib/spaceship/errors.rb

@@ -98,4 +98,38 @@ module Spaceship
 
   # Raised when 403 is received from portal request
   class AccessForbiddenError < BasicPreferredInfoError; end
+
+  # Base class for errors coming from App Store Connect locale changes
+  class AppStoreLocaleError < BasicPreferredInfoError
+    def initialize(msg)
+      @message = (msg ? "An exception occurred for locale: #{msg}." : nil)
+      super
+    end
+
+    # no need to search github issues since the error is specific
+    def show_github_issues
+      false
+    end
+  end
+
+  # Raised for localized text errors from App Store Connect
+  class AppStoreLocalizationError < AppStoreLocaleError
+    def preferred_error_info
+      "#{@message} Check the localization requirements here: https://help.apple.com/app-store-connect/en.lproj/static.html#dev354659071"
+    end
+  end
+
+  # Raised for localized screenshots errors from App Store Connect
+  class AppStoreScreenshotError < AppStoreLocaleError
+    def preferred_error_info
+      "#{@message} Check the screenshot requirements here: https://help.apple.com/app-store-connect/en.lproj/static.html#devd274dd925"
+    end
+  end
+
+  # Raised for localized app preview errors from App Store Connect
+  class AppStoreAppPreviewError < AppStoreLocaleError
+    def preferred_error_info
+      "#{@message} Check the app preview requirements here: https://help.apple.com/app-store-connect/en.lproj/static.html#dev4e413fcb8"
+    end
+  end
 end

data/spaceship/lib/spaceship/hashcash.rb

@@ -0,0 +1,52 @@
+require 'digest'
+
+module Spaceship
+  module Hashcash
+    # This App Store Connect hashcash spec was generously donated by...
+    #
+    #                         __  _
+    #    __ _  _ __   _ __   / _|(_)  __ _  _   _  _ __  ___  ___
+    #   / _` || '_ \ | '_ \ | |_ | | / _` || | | || '__|/ _ \/ __|
+    #  | (_| || |_) || |_) ||  _|| || (_| || |_| || |  |  __/\__ \
+    #   \__,_|| .__/ | .__/ |_|  |_| \__, | \__,_||_|   \___||___/
+    #         |_|    |_|             |___/
+    #
+    #
+    # <summary>
+    #             1:11:20230223170600:4d74fb15eb23f465f1f6fcbf534e5877::6373
+    # X-APPLE-HC: 1:11:20230223170600:4d74fb15eb23f465f1f6fcbf534e5877::6373
+    #             ^  ^      ^                       ^                     ^
+    #             |  |      |                       |                     +-- Counter
+    #             |  |      |                       +-- Resource
+    #             |  |      +-- Date YYMMDD[hhmm[ss]]
+    #             |  +-- Bits (number of leading zeros)
+    #             +-- Version
+    #
+    # We can't use an off-the-shelf Hashcash because Apple's implementation is not quite the same as the spec/convention.
+    #  1. The spec calls for a nonce called "Rand" to be inserted between the Ext and Counter. They don't do that at all.
+    #  2. The Counter conventionally encoded as base-64 but Apple just uses the decimal number's string representation.
+    #
+    # Iterate from Counter=0 to Counter=N finding an N that makes the SHA1(X-APPLE-HC) lead with Bits leading zero bits
+    #
+    #
+    # We get the "Resource" from the X-Apple-HC-Challenge header and Bits from X-Apple-HC-Bits
+    #
+    # </summary>
+    def self.make(bits:, challenge:)
+      version = 1
+      date = Time.now.strftime("%Y%m%d%H%M%S")
+
+      counter = 0
+      loop do
+        hc = [
+          version, bits, date, challenge, ":#{counter}"
+        ].join(":")
+
+        if Digest::SHA1.digest(hc).unpack1('B*')[0, bits.to_i].to_i == 0
+          return hc
+        end
+        counter += 1
+      end
+    end
+  end
+end

data/spaceship/lib/spaceship/portal/certificate.rb

@@ -168,7 +168,7 @@ module Spaceship
         "R58UK2EWSO" => Production,
         "9RQEK7MSXA" => InHouse,
         "LA30L5BJEU" => Certificate,
-        "BKLRAVXMGM" => DevelopmentPush,
+        "JKG5JZ54H7" => DevelopmentPush,
         "UPV3DW712I" => ProductionPush,
         "Y3B2F3TYSI" => Passbook,
         "3T2ZP62QW8" => WebsitePush,
@@ -178,12 +178,13 @@ module Spaceship
       }
 
       OLDER_IOS_CERTIFICATE_TYPES = [
-        # those are also sent by the browser, but not sure what they represent
+        "3BQKVH9I2X", # old ProductionPush
+        "BKLRAVXMGM", # old DevelopmentPush
+        # those are also sent by the browser, but not sure what they represent:
         "T44PTHVNID",
         "DZQUP8189Y",
         "FGQUP4785Z",
         "S5WE21TULA",
-        "3BQKVH9I2X", # ProductionPush,
         "FUOY7LWJET"
       ]
 

data/spaceship/lib/spaceship/tunes/app_ratings.rb

@@ -8,22 +8,22 @@ module Spaceship
       #   this version is for
       attr_accessor :application
 
-      # @return (Integer) total number of ratings recevied
+      # @return (Integer) total number of ratings received
       attr_accessor :rating_count
 
-      # @return (Integer) total number of one star ratings recevied
+      # @return (Integer) total number of one star ratings received
       attr_accessor :one_star_rating_count
 
-      # @return (Integer) total number of two star ratings recevied
+      # @return (Integer) total number of two star ratings received
       attr_accessor :two_star_rating_count
 
-      # @return (Integer) total number of three star ratings recevied
+      # @return (Integer) total number of three star ratings received
       attr_accessor :three_star_rating_count
 
-      # @return (Integer) total number of four star ratings recevied
+      # @return (Integer) total number of four star ratings received
       attr_accessor :four_star_rating_count
 
-      # @return (Integer) total number of five star ratings recevied
+      # @return (Integer) total number of five star ratings received
       attr_accessor :five_star_rating_count
 
       attr_mapping({

data/spaceship/lib/spaceship/tunes/iap_families.rb

@@ -7,7 +7,7 @@ module Spaceship
       attr_accessor :application
 
       # Create a new Purchase Family
-      # a freshly created family has to have atleast one product.
+      # a freshly created family has to have at least one product.
       # the product will be created, and versions/pricing_intervals and so on
       # should be set by subsequent edit.
       # @param name (String) Familyname

data/spaceship/lib/spaceship/tunes/tunes.rb

@@ -14,7 +14,6 @@ require_relative 'app_version_ref'
 require_relative 'app_version_history'
 require_relative 'app_version_states_history'
 require_relative 'transit_app_file'
-require_relative 'user_detail'
 require_relative 'app_screenshot'
 require_relative 'language_converter'
 require_relative 'build'