fastlane 2.2.0 → 2.3.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 3f33587942312c51aef121133e597d5aab60056b
-  data.tar.gz: 642bf6bd44765a002f62977bc3c81b18f4772784
+  metadata.gz: 17ff4ad445269f4de13b6417670f5ecea7e0a73b
+  data.tar.gz: 225d33ffac4954be128f0ed45c57bf60460b613f
 SHA512:
-  metadata.gz: 5c5c3d1b84d4bd9914877a3d672b431253931f16346c77495f9ccc0c33e3d55442e87df3643624f05f81eb883d7ea39d03628e30dbe67add0aebd8ede5d87fe8
-  data.tar.gz: 4603c27be02b10644fcadcdb31ae3e52f61ca5989436d7420aa86abd6e9f2654c3871d3811917a2f0858e31a35a01a9ef8ba6c770b6a5a58a6bf9a5b4e6bc808
+  metadata.gz: c7a0e0c455834201b789ee34acac0e0e6fdc142e2d3b5885ab07fa64a1d7369139a7ca516a0d70cadd83e2e5eca07f5af27803a12b89464e4bec35e186f3feec
+  data.tar.gz: b5c7390d7e602f8306f0e37cea52c77f9a23b81224ee983e74386107f03f373aca845efeeec0659ea8f91934eae56254d51b8aa73f3f460f94ad09ec6626c466

data/README.md

@@ -43,7 +43,7 @@ Then to deploy a new 'beta' version of your app just run
 :rocket: | Saves you **hours** for every app update you release
 :pencil2: | Flexible configuration using a fully customisable `Fastfile`
 :mountain_cableway: | Implement a fully working Continuous Delivery process
-:ghost: | [Jenkins Integration](https://github.com/fastlane/fastlane/blob/master/fastlane/docs/Jenkins.md): Show output directly in test results
+:ghost: | [Jenkins Integration](https://docs.fastlane.tools/best-practices/continuous-integration/#jenkins-integration): Show output directly in test results
 :book: | Automatically generate Markdown documentation of your lane configurations
 :hatching_chick: | Over 170 built-in integrations available
 :computer: | Support for iOS, Mac, and Android apps

data/credentials_manager/README.md

@@ -10,14 +10,14 @@ Along with the [Ruby libraries](https://github.com/fastlane/fastlane/tree/master
 
 **Adding Credentials**
 ```
-fastlane-credentials add --username felix@krausefx.com
+fastlane fastlane-credentials add --username felix@krausefx.com
 Password: *********
 Credential felix@krausefx.com:********* added to keychain.
 ```
 
 **Removing Credentials**
 ```
-fastlane-credentials remove --username felix@krausefx.com
+fastlane fastlane-credentials remove --username felix@krausefx.com
 password has been deleted.
 ```
 

data/deliver/lib/deliver/options.rb

@@ -24,6 +24,11 @@ module Deliver
                                      env_name: "DELIVER_APP_ID",
                                      description: "The app ID of the app you want to use/modify",
                                      is_string: false), # don't add any verification here, as it's used to store a spaceship ref
+        FastlaneCore::ConfigItem.new(key: :edit_live,
+                                     short_option: "-o",
+                                     env_name: "DELIVER_EDIT_LIVE",
+                                     description: "Modify live metadata, this option disables ipa upload and screenshot upload",
+                                     is_string: false),
         FastlaneCore::ConfigItem.new(key: :ipa,
                                      short_option: "-i",
                                      optional: true,

data/deliver/lib/deliver/upload_assets.rb

@@ -1,6 +1,7 @@
 module Deliver
   class UploadAssets
     def upload(options)
+      return if options[:edit_live]
       app = options[:app]
 
       v = app.edit_version(platform: options[:platform])

data/deliver/lib/deliver/upload_metadata.rb

@@ -15,17 +15,35 @@ module Deliver
                                 :primary_first_sub_category, :primary_second_sub_category,
                                 :secondary_first_sub_category, :secondary_second_sub_category]
 
+    # Localized app details values, that are editable in live state
+    LOCALISED_LIVE_VALUES = [:description, :release_notes, :support_url, :marketing_url]
+
+    # Non localized app details values, that are editable in live state
+    NON_LOCALISED_LIVE_VALUES = [:privacy_url]
+
     # Make sure to call `load_from_filesystem` before calling upload
     def upload(options)
       return if options[:skip_metadata]
-      verify_available_languages!(options)
+      # it is not possible to create new languages, because
+      # :keywords is not write-able on published versions
+      # therefore skip it.
+      verify_available_languages!(options) unless options[:edit_live]
 
       app = options[:app]
 
       details = app.details
-      v = app.edit_version(platform: options[:platform])
+      if options[:edit_live]
+        # not all values are editable when using live_version
+        v = app.live_version(platform: options[:platform])
+        localised_options = LOCALISED_LIVE_VALUES
+        non_localised_options = NON_LOCALISED_LIVE_VALUES
+      else
+        v = app.edit_version(platform: options[:platform])
+        localised_options = (LOCALISED_VERSION_VALUES + LOCALISED_APP_VALUES)
+        non_localised_options = (NON_LOCALISED_VERSION_VALUES + NON_LOCALISED_APP_VALUES)
+      end
 
-      (LOCALISED_VERSION_VALUES + LOCALISED_APP_VALUES).each do |key|
+      localised_options.each do |key|
         current = options[key]
         next unless current
 
@@ -42,7 +60,7 @@ module Deliver
         end
       end
 
-      (NON_LOCALISED_VERSION_VALUES + NON_LOCALISED_APP_VALUES).each do |key|
+      non_localised_options.each do |key|
         current = options[key].to_s.strip
         next unless current.to_s.length > 0
         v.send("#{key}=", current) if NON_LOCALISED_VERSION_VALUES.include?(key)
@@ -57,7 +75,7 @@ module Deliver
       UI.message("Uploading metadata to iTunes Connect")
       v.save!
       details.save!
-      UI.success("Successfully uploaded initial set of metadata to iTunes Connect")
+      UI.success("Successfully uploaded set of metadata to iTunes Connect")
     end
 
     # If the user is using the 'default' language, then assign values where they are needed

data/deliver/lib/deliver/upload_screenshots.rb

@@ -3,6 +3,7 @@ module Deliver
   class UploadScreenshots
     def upload(options, screenshots)
       return if options[:skip_screenshots]
+      return if options[:edit_live]
 
       app = options[:app]
 

data/fastlane/README.md

@@ -86,7 +86,7 @@ fastlane release
 :rocket: | Saves you **hours** for every app update you release
 :pencil2: | Very flexible configuration using a fully customisable `Fastfile`
 :mountain_cableway: | Implement a fully working Continuous Delivery process
-:ghost: | [Jenkins Integration](https://github.com/fastlane/fastlane/blob/master/fastlane/docs/Jenkins.md): Show the output directly in the Jenkins test results
+:ghost: | [Jenkins Integration](https://docs.fastlane.tools/best-practices/continuous-integration/#jenkins-integration): Show the output directly in the Jenkins test results
 :book: | Automatically generate a markdown documentation of your lane config
 :hatching_chick: | Over 170 built-in integrations available
 :computer: | Support for both iOS, Mac OS and Android apps

data/fastlane/lib/fastlane/actions/badge.rb

@@ -3,7 +3,6 @@ module Fastlane
     class BadgeAction < Action
       def self.run(params)
         Actions.verify_gem!('badge')
-        check_imagemagick!
         require 'badge'
         options = {
           dark: params[:dark],
@@ -141,20 +140,6 @@ module Fastlane
       def self.is_supported?(platform)
         [:ios, :mac, :android].include?(platform)
       end
-
-      def self.check_imagemagick!
-        return if `which convert`.include?('convert')
-
-        UI.error("You have to install ImageMagick to use `badge`")
-        UI.error("")
-        UI.error("Install it using:")
-        UI.command("brew update && brew install imagemagick")
-        UI.error("")
-        UI.error("If you don't have homebrew, visit http://brew.sh")
-
-        UI.user_error!("Install ImageMagick and start your lane again!")
-      end
-      private_class_method :check_imagemagick!
     end
   end
 end

data/fastlane/lib/fastlane/actions/commit_version_bump.rb

@@ -67,6 +67,14 @@ module Fastlane
         expected_changed_files = []
         expected_changed_files << pbxproj_path
         expected_changed_files << info_plist_files
+
+        if params[:settings]
+          settings_plists_from_param(params[:settings]).each do |file|
+            settings_file_pathname = Pathname.new settings_bundle_file_path(project, file)
+            expected_changed_files << settings_file_pathname.relative_path_from(repo_pathname).to_s
+          end
+        end
+
         expected_changed_files.flatten!.uniq!
 
         # get the list of files that have actually changed in our git workdir
@@ -91,10 +99,6 @@ module Fastlane
           end
         end
 
-        if params[:settings]
-          expected_changed_files << 'Settings.bundle/Root.plist'
-        end
-
         # get the absolute paths to the files
         git_add_paths = expected_changed_files.map do |path|
           updated = path.gsub("$(SRCROOT)", ".").gsub("${SRCROOT}", ".")
@@ -193,6 +197,29 @@ module Fastlane
       def self.category
         :source_control
       end
+
+      class << self
+        def settings_plists_from_param(param)
+          if param.kind_of? String
+            # commit_version_bump xcodeproj: "MyProject.xcodeproj", settings: "About.plist"
+            return [param]
+          elsif param.kind_of? Array
+            # commit_version_bump xcodeproj: "MyProject.xcodeproj", settings: [ "Root.plist", "About.plist" ]
+            return param
+          end
+
+          # commit_version_bump xcodeproj: "MyProject.xcodeproj", settings: true # Root.plist
+          ["Root.plist"]
+        end
+
+        def settings_bundle_file_path(project, settings_file_name)
+          settings_bundle = project.files.find { |f| f.path =~ /Settings.bundle/ }
+          raise "No Settings.bundle in project" if settings_bundle.nil?
+
+          project_parent = File.dirname project.path
+          File.join(project_parent, settings_bundle.path, settings_file_name)
+        end
+      end
     end
   end
 end

data/fastlane/lib/fastlane/actions/reset_git_repo.rb

@@ -5,7 +5,7 @@ module Fastlane
     # Does a hard reset and clean on the repo
     class ResetGitRepoAction < Action
       def self.run(params)
-        if params[:force] || params[:force] || Actions.lane_context[SharedValues::GIT_REPO_WAS_CLEAN_ON_START]
+        if params[:force] || Actions.lane_context[SharedValues::GIT_REPO_WAS_CLEAN_ON_START]
           paths = params[:files]
 
           return paths if Helper.is_test?

data/fastlane/lib/fastlane/fast_file.rb

@@ -143,7 +143,7 @@ module Fastlane
 
     # Is used to look if the method is implemented as an action
     def method_missing(method_sym, *arguments, &_block)
-      self.runner.trigger_action_by_name(method_sym, nil, *arguments)
+      self.runner.trigger_action_by_name(method_sym, nil, false, *arguments)
     end
 
     #####################################################
@@ -227,35 +227,30 @@ module Fastlane
         # Checkout the repo
         repo_name = url.split("/").last
 
-        tmp_path = Dir.mktmpdir("fl_clone")
-        clone_folder = File.join(tmp_path, repo_name)
+        Dir.mktmpdir("fl_clone") do |tmp_path|
+          clone_folder = File.join(tmp_path, repo_name)
 
-        branch_option = ""
-        branch_option = "--branch #{branch}" if branch != 'HEAD'
+          branch_option = ""
+          branch_option = "--branch #{branch}" if branch != 'HEAD'
 
-        clone_command = "GIT_TERMINAL_PROMPT=0 git clone '#{url}' '#{clone_folder}' --depth 1 -n #{branch_option}"
+          clone_command = "GIT_TERMINAL_PROMPT=0 git clone '#{url}' '#{clone_folder}' --depth 1 -n #{branch_option}"
 
-        UI.message "Cloning remote git repo..."
-        Actions.sh(clone_command)
+          UI.message "Cloning remote git repo..."
+          Actions.sh(clone_command)
 
-        Actions.sh("cd '#{clone_folder}' && git checkout #{branch} '#{path}'")
+          Actions.sh("cd '#{clone_folder}' && git checkout #{branch} '#{path}'")
 
-        # We also want to check out all the local actions of this fastlane setup
-        containing = path.split(File::SEPARATOR)[0..-2]
-        containing = "." if containing.count == 0
-        actions_folder = File.join(containing, "actions")
-        begin
-          Actions.sh("cd '#{clone_folder}' && git checkout #{branch} '#{actions_folder}'")
-        rescue
-          # We don't care about a failure here, as local actions are optional
-        end
-
-        import(File.join(clone_folder, path))
+          # We also want to check out all the local actions of this fastlane setup
+          containing = path.split(File::SEPARATOR)[0..-2]
+          containing = "." if containing.count == 0
+          actions_folder = File.join(containing, "actions")
+          begin
+            Actions.sh("cd '#{clone_folder}' && git checkout #{branch} '#{actions_folder}'")
+          rescue
+            # We don't care about a failure here, as local actions are optional
+          end
 
-        if Dir.exist?(clone_folder)
-          # We want to re-clone if the folder already exists
-          UI.message "Clearing the git repo..."
-          Actions.sh("rm -rf '#{tmp_path}'")
+          import(File.join(clone_folder, path))
         end
       end
     end

data/fastlane/lib/fastlane/other_action.rb

@@ -22,6 +22,7 @@ module Fastlane
 
       self.runner.trigger_action_by_name(method_sym,
                                          "./fastlane",
+                                         true,
                                          *arguments)
     end
   end

data/fastlane/lib/fastlane/runner.rb

@@ -109,7 +109,9 @@ module Fastlane
 
     # This is being called from `method_missing` from the Fastfile
     # It's also used when an action is called from another action
-    def trigger_action_by_name(method_sym, custom_dir, *arguments)
+    # @param from_action Indicates if this action is being trigged by another action.
+    #                    If so, it won't show up in summary.
+    def trigger_action_by_name(method_sym, custom_dir, from_action, *arguments)
       # First, check if there is a predefined method in the actions folder
       class_ref = class_reference_from_action_name(method_sym)
       unless class_ref
@@ -130,7 +132,7 @@ module Fastlane
       if class_ref
         if class_ref.respond_to?(:run)
           # Action is available, now execute it
-          return self.execute_action(method_sym, class_ref, arguments, custom_dir: custom_dir)
+          return self.execute_action(method_sym, class_ref, arguments, custom_dir: custom_dir, from_action: from_action)
         else
           UI.user_error!("Action '#{method_sym}' of class '#{class_name}' was found, but has no `run` method.")
         end
@@ -197,7 +199,7 @@ module Fastlane
       end
     end
 
-    def execute_action(method_sym, class_ref, arguments, custom_dir: nil)
+    def execute_action(method_sym, class_ref, arguments, custom_dir: nil, from_action: false)
       if custom_dir.nil?
         custom_dir ||= "." if Helper.test?
         custom_dir ||= ".."
@@ -209,7 +211,10 @@ module Fastlane
 
       begin
         Dir.chdir(custom_dir) do # go up from the fastlane folder, to the project folder
-          Actions.execute_action(class_ref.step_text) do
+          # If another action is calling this action, we shouldn't show it in the summary
+          # (see https://github.com/fastlane/fastlane/issues/4546)
+          action_name = from_action ? nil : class_ref.step_text
+          Actions.execute_action(action_name) do
             # arguments is an array by default, containing an hash with the actual parameters
             # Since we usually just need the passed hash, we'll just use the first object if there is only one
             if arguments.count == 0

data/fastlane/lib/fastlane/version.rb

@@ -1,4 +1,4 @@
 module Fastlane
-  VERSION = '2.2.0'.freeze
+  VERSION = '2.3.0'.freeze
   DESCRIPTION = "The easiest way to automate beta deployments and releases for your iOS and Android apps".freeze
 end

data/fastlane_core/lib/fastlane_core/ui/implementations/shell.rb

@@ -7,7 +7,8 @@ module FastlaneCore
 
       $stdout.sync = true
 
-      if Helper.is_test?
+      if Helper.is_test? && !ENV.key?('DEBUG')
+        $stdout.puts "Logging disabled while running tests. Force them by setting the DEBUG environment variable"
         @log ||= Logger.new(nil) # don't show any logs when running tests
       else
         @log ||= Logger.new($stdout)

data/snapshot/lib/snapshot/options.rb

@@ -29,6 +29,11 @@ module Snapshot
                                        UI.user_error!("Project file invalid") unless File.directory?(v)
                                        UI.user_error!("Project file is not a project file, must end with .xcodeproj") unless v.include?(".xcodeproj")
                                      end),
+        FastlaneCore::ConfigItem.new(key: :xcargs,
+                                     short_option: "-X",
+                                     env_name: "SNAPSHOT_XCARGS",
+                                     description: "Pass additional arguments to xcodebuild for the test phase. Be sure to quote the setting names and values e.g. OTHER_LDFLAGS=\"-ObjC -lstdc++\"",
+                                     optional: true),
         FastlaneCore::ConfigItem.new(key: :devices,
                                      description: "A list of devices you want to take the screenshots from",
                                      short_option: "-d",
@@ -154,6 +159,10 @@ module Snapshot
                                      short_option: "-f",
                                      env_name: "SNAPSHOT_DERIVED_DATA_PATH",
                                      description: "The directory where build products and other derived data will go",
+                                     optional: true),
+        FastlaneCore::ConfigItem.new(key: :test_target_name,
+                                     env_name: "SNAPSHOT_TEST_TARGET_NAME",
+                                     description: "The name of the target you want to test (if you desire to override the Target Application from Xcode)",
                                      optional: true)
       ]
     end

data/snapshot/lib/snapshot/test_command_generator.rb

@@ -35,13 +35,16 @@ module Snapshot
         options += project_path_array
         options << "-sdk '#{config[:sdk]}'" if config[:sdk]
         options << "-derivedDataPath '#{derived_data_path}'"
-
+        options << config[:xcargs] if config[:xcargs]
         options
       end
 
       def build_settings
+        config = Snapshot.config
+
         build_settings = []
         build_settings << "FASTLANE_SNAPSHOT=YES"
+        build_settings << "TEST_TARGET_NAME='#{config[:test_target_name]}'" if config[:test_target_name]
 
         build_settings
       end

data/spaceship/README.md

@@ -112,10 +112,10 @@ This requires you to install `pry` using `sudo gem install pry`. `pry` is not in
 
 When your Apple account has 2 factor verification enabled, you'll automatically be asked to verify your identity using your phone. The resulting session will be stored in `~/.spaceship/[email]/cookie`. The session should be valid for about one month, however there is no way to test this without actually waiting for over a month.
 
-Since your CI system probably doesn't allow you to input values (like the verification code), you can use `spaceauth`:
+Since your CI system probably doesn't allow you to input values (like the verification code), you can use `fastlane spaceauth`:
 
 ```sh
-spaceauth -u apple@krausefx.com
+fastlane spaceauth -u apple@krausefx.com
 ```
 
 This will authenticate you and provide a string that can be transferred to your CI system:

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: fastlane
 version: !ruby/object:Gem::Version
-  version: 2.2.0
+  version: 2.3.0
 platform: ruby
 authors:
 - Felix Krause
@@ -14,7 +14,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-12-21 00:00:00.000000000 Z
+date: 2016-12-23 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: slack-notifier
@@ -703,9 +703,7 @@ files:
 - bin/bin-proxy
 - bin/fastlane
 - cert/README.md
-- cert/lib/.DS_Store
 - cert/lib/cert.rb
-- cert/lib/cert/.DS_Store
 - cert/lib/cert/commands_generator.rb
 - cert/lib/cert/options.rb
 - cert/lib/cert/runner.rb
@@ -752,8 +750,10 @@ files:
 - fastlane/lib/assets/s3_plist_template.erb
 - fastlane/lib/assets/s3_version_template.erb
 - fastlane/lib/fastlane.rb
+- fastlane/lib/fastlane/.DS_Store
 - fastlane/lib/fastlane/action.rb
 - fastlane/lib/fastlane/action_collector.rb
+- fastlane/lib/fastlane/actions/.DS_Store
 - fastlane/lib/fastlane/actions/README.md
 - fastlane/lib/fastlane/actions/actions_helper.rb
 - fastlane/lib/fastlane/actions/adb.rb
@@ -1003,7 +1003,6 @@ files:
 - fastlane/lib/fastlane/tools.rb
 - fastlane/lib/fastlane/version.rb
 - fastlane_core/README.md
-- fastlane_core/lib/.DS_Store
 - fastlane_core/lib/assets/XMLTemplate.xml.erb
 - fastlane_core/lib/fastlane_core.rb
 - fastlane_core/lib/fastlane_core/cert_checker.rb
@@ -1083,6 +1082,7 @@ files:
 - gym/lib/gym/xcodebuild_fixes/watchkit2_fix.rb
 - gym/lib/gym/xcodebuild_fixes/watchkit_fix.rb
 - match/README.md
+- match/lib/.DS_Store
 - match/lib/assets/MatchfileTemplate
 - match/lib/assets/READMETemplate.md
 - match/lib/match.rb
@@ -1288,7 +1288,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.5.1
+rubygems_version: 2.6.8
 signing_key: 
 specification_version: 4
 summary: The easiest way to automate beta deployments and releases for your iOS and