fastlane 2.199.0 → 2.200.0

data/fastlane/swift/RunnerArgument.swift

@@ -1,5 +1,5 @@
 // RunnerArgument.swift
-// Copyright (c) 2021 FastlaneTools
+// Copyright (c) 2022 FastlaneTools
 
 //
 //  ** NOTE **

data/fastlane/swift/Scanfile.swift

@@ -1,5 +1,5 @@
 // Scanfile.swift
-// Copyright (c) 2021 FastlaneTools
+// Copyright (c) 2022 FastlaneTools
 
 // This class is automatically included in FastlaneRunner during build
 
@@ -17,4 +17,4 @@ public class Scanfile: ScanfileProtocol {
     // during the `init` process, and you won't see this message
 }
 
-// Generated with fastlane 2.199.0
+// Generated with fastlane 2.200.0

data/fastlane/swift/ScanfileProtocol.swift

@@ -1,5 +1,5 @@
 // ScanfileProtocol.swift
-// Copyright (c) 2021 FastlaneTools
+// Copyright (c) 2022 FastlaneTools
 
 public protocol ScanfileProtocol: class {
     /// Path to the workspace file
@@ -296,4 +296,4 @@ public extension ScanfileProtocol {
 
 // Please don't remove the lines below
 // They are used to detect outdated files
-// FastlaneRunnerAPIVersion [0.9.97]
+// FastlaneRunnerAPIVersion [0.9.98]

data/fastlane/swift/Screengrabfile.swift

@@ -1,5 +1,5 @@
 // Screengrabfile.swift
-// Copyright (c) 2021 FastlaneTools
+// Copyright (c) 2022 FastlaneTools
 
 // This class is automatically included in FastlaneRunner during build
 
@@ -17,4 +17,4 @@ public class Screengrabfile: ScreengrabfileProtocol {
     // during the `init` process, and you won't see this message
 }
 
-// Generated with fastlane 2.199.0
+// Generated with fastlane 2.200.0

data/fastlane/swift/ScreengrabfileProtocol.swift

@@ -1,5 +1,5 @@
 // ScreengrabfileProtocol.swift
-// Copyright (c) 2021 FastlaneTools
+// Copyright (c) 2022 FastlaneTools
 
 public protocol ScreengrabfileProtocol: class {
     /// Path to the root of your Android SDK installation, e.g. ~/tools/android-sdk-macosx
@@ -96,4 +96,4 @@ public extension ScreengrabfileProtocol {
 
 // Please don't remove the lines below
 // They are used to detect outdated files
-// FastlaneRunnerAPIVersion [0.9.87]
+// FastlaneRunnerAPIVersion [0.9.88]

data/fastlane/swift/Snapshotfile.swift

@@ -1,5 +1,5 @@
 // Snapshotfile.swift
-// Copyright (c) 2021 FastlaneTools
+// Copyright (c) 2022 FastlaneTools
 
 // This class is automatically included in FastlaneRunner during build
 
@@ -17,4 +17,4 @@ public class Snapshotfile: SnapshotfileProtocol {
     // during the `init` process, and you won't see this message
 }
 
-// Generated with fastlane 2.199.0
+// Generated with fastlane 2.200.0

data/fastlane/swift/SnapshotfileProtocol.swift

@@ -1,5 +1,5 @@
 // SnapshotfileProtocol.swift
-// Copyright (c) 2021 FastlaneTools
+// Copyright (c) 2022 FastlaneTools
 
 public protocol SnapshotfileProtocol: class {
     /// Path the workspace file
@@ -200,4 +200,4 @@ public extension SnapshotfileProtocol {
 
 // Please don't remove the lines below
 // They are used to detect outdated files
-// FastlaneRunnerAPIVersion [0.9.81]
+// FastlaneRunnerAPIVersion [0.9.82]

data/fastlane/swift/SocketClient.swift

@@ -1,5 +1,5 @@
 // SocketClient.swift
-// Copyright (c) 2021 FastlaneTools
+// Copyright (c) 2022 FastlaneTools
 
 //
 //  ** NOTE **

data/fastlane/swift/SocketClientDelegateProtocol.swift

@@ -1,5 +1,5 @@
 // SocketClientDelegateProtocol.swift
-// Copyright (c) 2021 FastlaneTools
+// Copyright (c) 2022 FastlaneTools
 
 //
 //  ** NOTE **

data/fastlane/swift/SocketResponse.swift

@@ -1,5 +1,5 @@
 // SocketResponse.swift
-// Copyright (c) 2021 FastlaneTools
+// Copyright (c) 2022 FastlaneTools
 
 //
 //  ** NOTE **

data/fastlane/swift/formatting/Brewfile.lock.json

@@ -56,11 +56,11 @@
         "macOS": "11.6"
       },
       "monterey": {
-        "HOMEBREW_VERSION": "3.3.7-38-g6295b08",
+        "HOMEBREW_VERSION": "3.3.10-21-g3ba6afb",
         "HOMEBREW_PREFIX": "/opt/homebrew",
-        "Homebrew/homebrew-core": "e340d22f5ef83cf4acc489b34e2478426dbf53b9",
+        "Homebrew/homebrew-core": "54f307bcd04cec374c7fd3f22fe7e6b13f1ad783",
         "CLT": "13.1.0.0.1.1633545042",
-        "Xcode": "13.1",
+        "Xcode": "13.2.1",
         "macOS": "12.0.1"
       }
     }

data/fastlane/swift/main.swift

@@ -1,5 +1,5 @@
 // main.swift
-// Copyright (c) 2021 FastlaneTools
+// Copyright (c) 2022 FastlaneTools
 
 //
 //  ** NOTE **

data/fastlane_core/lib/fastlane_core/ipa_file_analyser.rb

@@ -73,12 +73,17 @@ module FastlaneCore
     end
 
     def self.fetch_info_plist_with_unzip(path)
-      list, error, = Open3.capture3("unzip", "-Z", "-1", path)
+      entry, error, = Open3.capture3("unzip", "-Z", "-1", path, "*Payload/*.app/Info.plist")
+
+      # unzip can return multiple Info.plist files if is an embedded app bundle (a WatchKit app)
+      #   - ContainsWatchApp/Payload/Sample.app/Watch/Sample WatchKit App.app/Info.plist
+      #   - ContainsWatchApp/Payload/Sample.app/Info.plist
+      #
+      # we can determine the main Info.plist by the shortest path
+      entry = entry.lines.map(&:chomp).min_by(&:size)
+
       UI.command_output(error) unless error.empty?
-      return nil if list.empty?
-      entry = list.chomp.split("\n").find do |e|
-        File.fnmatch("**/Payload/*.app/Info.plist", e, File::FNM_PATHNAME)
-      end
+      return nil if entry.nil? || entry.empty?
       data, error, = Open3.capture3("unzip", "-p", path, entry)
       UI.command_output(error) unless error.empty?
       return nil if data.empty?

data/fastlane_core/lib/fastlane_core/itunes_transporter.rb

@@ -2,6 +2,7 @@ require 'shellwords'
 require 'tmpdir'
 require 'fileutils'
 require 'credentials_manager/account_manager'
+require 'securerandom'
 
 require_relative 'features'
 require_relative 'helper'
@@ -501,7 +502,9 @@ module FastlaneCore
 
       actual_dir = if can_use_asset_path && !force_itmsp
                      # The asset gets deleted upon completion so copying to a temp directory
-                     tmp_asset_path = File.join(Dir.tmpdir, File.basename(asset_path))
+                     # (with randomized filename, for multibyte-mixed filename upload fails)
+                     new_file_name = "#{SecureRandom.uuid}#{File.extname(asset_path)}"
+                     tmp_asset_path = File.join(Dir.tmpdir, new_file_name)
                      FileUtils.cp(asset_path, tmp_asset_path)
                      tmp_asset_path
                    elsif package_path

data/gym/lib/gym/generators/build_command_generator.rb

@@ -43,7 +43,7 @@ module Gym
           options << "-scmProvider system"
         end
         options << config[:xcargs] if config[:xcargs]
-        options << "OTHER_SWIFT_FLAGS=\"-Xfrontend -debug-time-function-bodies\"" if config[:analyze_build_time]
+        options << "OTHER_SWIFT_FLAGS=\"\\\$(value) -Xfrontend -debug-time-function-bodies\"" if config[:analyze_build_time]
 
         options
       end

data/scan/lib/scan/runner.rb

@@ -126,7 +126,7 @@ module Scan
 
         test_cases = suite.split(":\n").fetch(1, []).split("\n").each
                           .select { |line| line.match?(/^\s+/) }
-                          .map { |line| line.strip.gsub(".", "/").gsub("()", "") }
+                          .map { |line| line.strip.gsub(/[\s\.]/, "/").gsub(/[\-\[\]\(\)]/, "") }
                           .map { |line| suite_name + "/" + line }
 
         retryable_tests += test_cases

data/spaceship/lib/spaceship/connect_api/models/app.rb

@@ -1,6 +1,7 @@
 require_relative '../model'
 require_relative './build'
 
+# rubocop:disable Metrics/ClassLength
 module Spaceship
   class ConnectAPI
     class App
@@ -414,6 +415,47 @@ module Spaceship
         })
       end
 
+      #
+      # Review Submissions
+      #
+
+      def get_ready_review_submission(client: nil, platform:, includes: nil)
+        client ||= Spaceship::ConnectAPI
+        filter = {
+          state: [
+            Spaceship::ConnectAPI::ReviewSubmission::ReviewSubmissionState::READY_FOR_REVIEW
+          ].join(","),
+          platform: platform
+        }
+
+        return get_review_submissions(client: client, filter: filter, includes: includes).first
+      end
+
+      def get_in_progress_review_submission(client: nil, platform:, includes: nil)
+        client ||= Spaceship::ConnectAPI
+        filter = {
+          state: [
+            Spaceship::ConnectAPI::ReviewSubmission::ReviewSubmissionState::WAITING_FOR_REVIEW
+          ].join(","),
+          platform: platform
+        }
+
+        return get_review_submissions(client: client, filter: filter, includes: includes).first
+      end
+
+      # appStoreVersionForReview,items
+      def get_review_submissions(client: nil, filter: {}, includes: nil, limit: nil, sort: nil)
+        client ||= Spaceship::ConnectAPI
+        resps = client.get_review_submissions(app_id: id, filter: filter, includes: includes, limit: limit, sort: sort).all_pages
+        return resps.flat_map(&:to_models)
+      end
+
+      def create_review_submission(client: nil, platform:)
+        client ||= Spaceship::ConnectAPI
+        resp = client.post_review_submission(app_id: id, platform: platform)
+        return resp.to_models.first
+      end
+
       #
       # Users
       #
@@ -434,3 +476,4 @@ module Spaceship
     end
   end
 end
+# rubocop:enable Metrics/ClassLength

data/spaceship/lib/spaceship/connect_api/models/app_info.rb

@@ -25,6 +25,7 @@ module Spaceship
         WAITING_FOR_REVIEW = "WAITING_FOR_REVIEW"
         DEVELOPER_REJECTED = "DEVELOPER_REJECTED"
         DEVELOPER_REMOVED_FROM_SALE = "DEVELOPER_REMOVED_FROM_SALE"
+        READY_FOR_REVIEW = "READY_FOR_REVIEW"
         REJECTED = "REJECTED"
         PREPARE_FOR_SUBMISSION = "PREPARE_FOR_SUBMISSION"
         METADATA_REJECTED = "METADATA_REJECTED"

data/spaceship/lib/spaceship/connect_api/models/app_screenshot_set.rb

@@ -38,6 +38,7 @@ module Spaceship
 
         APP_WATCH_SERIES_3 = "APP_WATCH_SERIES_3"
         APP_WATCH_SERIES_4 = "APP_WATCH_SERIES_4"
+        APP_WATCH_SERIES_7 = "APP_WATCH_SERIES_7"
 
         APP_APPLE_TV = "APP_APPLE_TV"
 
@@ -85,6 +86,7 @@ module Spaceship
 
           APP_WATCH_SERIES_3,
           APP_WATCH_SERIES_4,
+          APP_WATCH_SERIES_7,
 
           APP_DESKTOP
         ]

data/spaceship/lib/spaceship/connect_api/models/review_submission.rb

@@ -0,0 +1,73 @@
+require_relative '../model'
+require_relative './review_submission_item'
+
+module Spaceship
+  class ConnectAPI
+    class ReviewSubmission
+      include Spaceship::ConnectAPI::Model
+
+      attr_accessor :platform
+      attr_accessor :state
+      attr_accessor :submitted_date
+
+      attr_accessor :app_store_version_for_review
+      attr_accessor :items
+      attr_accessor :last_updated_by_actor
+      attr_accessor :submitted_by_actor
+
+      module ReviewSubmissionState
+        CANCELING = "CANCELING"
+        COMPLETE = "COMPLETE"
+        IN_REVIEW = "IN_REVIEW"
+        READY_FOR_REVIEW = "READY_FOR_REVIEW"
+        WAITING_FOR_REVIEW = "WAITING_FOR_REVIEW"
+      end
+
+      attr_mapping({
+         "platform" => "platform",
+         "state" => "state",
+         "submittedDate" => "submitted_date",
+
+         "appStoreVersionForReview" => "app_store_version_for_review",
+         "items" => "items",
+         "lastUpdatedByActor" => "last_updated_by_actor",
+         "submittedByActor" => "submitted_by_actor",
+       })
+
+      def self.type
+        return "reviewSubmissions"
+      end
+
+      #
+      # API
+      #
+
+      # appStoreVersionForReview,items,submittedByActor,lastUpdatedByActor
+      def self.get(client: nil, review_submission_id:, includes: nil)
+        client ||= Spaceship::ConnectAPI
+        resp = client.get_review_submission(review_submission_id: review_submission_id, includes: includes)
+        return resp.to_models.first
+      end
+
+      def submit_for_review(client: nil)
+        client ||= Spaceship::ConnectAPI
+        attributes = { submitted: true }
+        resp = client.patch_review_submission(review_submission_id: id, attributes: attributes)
+        return resp.to_models.first
+      end
+
+      def cancel_submission(client: nil)
+        client ||= Spaceship::ConnectAPI
+        attributes = { canceled: true }
+        resp = client.patch_review_submission(review_submission_id: id, attributes: attributes)
+        return resp.to_models.first
+      end
+
+      def add_app_store_version_to_review_items(client: nil, app_store_version_id:)
+        client ||= Spaceship::ConnectAPI
+        resp = client.post_review_submission_item(review_submission_id: id, app_store_version_id: app_store_version_id)
+        return resp.to_models.first
+      end
+    end
+  end
+end

data/spaceship/lib/spaceship/connect_api/models/review_submission_item.rb

@@ -0,0 +1,40 @@
+require_relative '../model'
+
+module Spaceship
+  class ConnectAPI
+    class ReviewSubmissionItem
+      include Spaceship::ConnectAPI::Model
+
+      attr_accessor :state
+
+      attr_accessor :app_store_version_experiment
+      attr_accessor :app_store_version
+      attr_accessor :app_store_product_page_version
+      attr_accessor :app_event
+
+      attr_mapping({
+         "state" =>  "state",
+
+         "appStoreVersionExperiment" => "app_store_version_experiment",
+         "appStoreVersion" => "app_store_version",
+         "appCustomProductPageVersion" => "app_store_product_page_version",
+         "appEvent" => "app_event",
+       })
+
+      def self.type
+        return "reviewSubmissionItems"
+      end
+
+      #
+      # API
+      #
+
+      # appCustomProductPageVersion,appEvent,appStoreVersion,appStoreVersionExperiment
+      def self.all(client: nil, review_submission_id:, includes: nil, limit: nil, sort: nil)
+        client ||= Spaceship::ConnectAPI
+        resps = client.get_review_submission_items(review_submission_id: review_submission_id, includes: includes, limit: limit, sort: sort).all_pages
+        return resps.flat_map(&:to_models)
+      end
+    end
+  end
+end

data/spaceship/lib/spaceship/connect_api/tunes/tunes.rb

@@ -1126,6 +1126,89 @@ module Spaceship
           tunes_request_client.delete("idfaDeclarations/#{idfa_declaration_id}", params)
         end
 
+        #
+        # reviewSubmissions
+        #
+
+        def get_review_submissions(app_id:, filter: {}, includes: nil, limit: nil, sort: nil)
+          params = tunes_request_client.build_params(filter: filter, includes: includes, limit: limit, sort: sort)
+          tunes_request_client.get("apps/#{app_id}/reviewSubmissions", params)
+        end
+
+        def get_review_submission(review_submission_id:, filter: {}, includes: nil, limit: nil, sort: nil)
+          params = tunes_request_client.build_params(filter: filter, includes: includes, limit: limit, sort: sort)
+          tunes_request_client.get("reviewSubmissions/#{review_submission_id}", params)
+        end
+
+        def post_review_submission(app_id:, platform:)
+          body = {
+            data: {
+              type: "reviewSubmissions",
+              attributes: {
+                platform: platform
+              },
+              relationships: {
+                app: {
+                  data: {
+                    type: "apps",
+                    id: app_id
+                  }
+                }
+              }
+            }
+          }
+
+          tunes_request_client.post("reviewSubmissions", body)
+        end
+
+        def patch_review_submission(review_submission_id:, attributes: nil)
+          body = {
+            data: {
+              type: "reviewSubmissions",
+              id: review_submission_id,
+              attributes: attributes,
+            }
+          }
+
+          tunes_request_client.patch("reviewSubmissions/#{review_submission_id}", body)
+        end
+
+        #
+        # reviewSubmissionItems
+        #
+
+        def get_review_submission_items(review_submission_id:, filter: {}, includes: nil, limit: nil, sort: nil)
+          params = tunes_request_client.build_params(filter: filter, includes: includes, limit: limit, sort: sort)
+          tunes_request_client.get("reviewSubmissions/#{review_submission_id}/items", params)
+        end
+
+        def post_review_submission_item(review_submission_id:, app_store_version_id: nil)
+          body = {
+            data: {
+              type: "reviewSubmissionItems",
+              relationships: {
+                reviewSubmission: {
+                  data: {
+                    type: "reviewSubmissions",
+                    id: review_submission_id
+                  }
+                }
+              }
+            }
+          }
+
+          unless app_store_version_id.nil?
+            body[:data][:relationships][:appStoreVersion] = {
+              data: {
+                type: "appStoreVersions",
+                id: app_store_version_id
+              }
+            }
+          end
+
+          tunes_request_client.post("reviewSubmissionItems", body)
+        end
+
         #
         # sandboxTesters
         #

data/spaceship/lib/spaceship/connect_api.rb

@@ -62,6 +62,8 @@ require 'spaceship/connect_api/models/app_store_version_localization'
 require 'spaceship/connect_api/models/app_store_version_phased_release'
 require 'spaceship/connect_api/models/app_store_version'
 require 'spaceship/connect_api/models/idfa_declaration'
+require 'spaceship/connect_api/models/review_submission'
+require 'spaceship/connect_api/models/review_submission_item'
 require 'spaceship/connect_api/models/reset_ratings_request'
 require 'spaceship/connect_api/models/sandbox_tester'
 require 'spaceship/connect_api/models/territory'

data/supply/lib/supply/options.rb

@@ -217,6 +217,14 @@ module Supply
                                      verify_block: proc do |value|
                                        UI.user_error!("'rollout' is no longer a valid track name - please use 'production' instead") if value.casecmp('rollout').zero?
                                      end),
+        FastlaneCore::ConfigItem.new(key: :track_promote_release_status,
+                                     env_name: "SUPPLY_TRACK_PROMOTE_RELEASE_STATUS",
+                                     optional: true,
+                                     description: "Promoted track release status (used when promoting a track) - valid values are #{Supply::ReleaseStatus::ALL.join(', ')}",
+                                     default_value: Supply::ReleaseStatus::COMPLETED,
+                                     verify_block: proc do |value|
+                                                     UI.user_error!("Value must be one of '#{Supply::RELEASE_STATUS}'") unless Supply::ReleaseStatus::ALL.include?(value)
+                                                   end),
         FastlaneCore::ConfigItem.new(key: :validate_only,
                                      env_name: "SUPPLY_VALIDATE_ONLY",
                                      optional: true,

data/supply/lib/supply/uploader.rb

@@ -164,6 +164,10 @@ module Supply
         UI.user_error!(%(Cannot specify rollout percentage when the release status is set to 'draft'))
       end
 
+      if Supply.config[:track_promote_release_status] == Supply::ReleaseStatus::DRAFT && Supply.config[:rollout]
+        UI.user_error!(%(Cannot specify rollout percentage when the track promote release status is set to 'draft'))
+      end
+
       unless Supply.config[:version_codes_to_retain].nil?
         Supply.config[:version_codes_to_retain] = Supply.config[:version_codes_to_retain].map(&:to_i)
       end
@@ -182,7 +186,7 @@ module Supply
         end
       else
         releases = releases.select do |release|
-          release.status == Supply::ReleaseStatus::COMPLETED
+          release.status == Supply.config[:release_status]
         end
       end
 
@@ -200,7 +204,7 @@ module Supply
         release.status = Supply::ReleaseStatus::IN_PROGRESS
         release.user_fraction = rollout
       else
-        release.status = Supply::ReleaseStatus::COMPLETED
+        release.status = Supply.config[:track_promote_release_status]
         release.user_fraction = nil
       end
 

metadata

@@ -1,38 +1,38 @@
 --- !ruby/object:Gem::Specification
 name: fastlane
 version: !ruby/object:Gem::Version
-  version: 2.199.0
+  version: 2.200.0
 platform: ruby
 authors:
-- Iulian Onofrei
-- Fumiya Nakamura
-- Aaron Brager
-- Olivier Halligon
-- Helmut Januschka
-- Manu Wallner
-- Luka Mirosevic
-- Jérôme Lacoste
 - Jimmy Dee
-- Felix Krause
-- Maksym Grebenets
-- Daniel Jankowski
+- Jérôme Lacoste
 - Danielle Tomlinson
-- Satoshi Namai
+- Maksym Grebenets
 - Matthew Ellis
-- Roger Oba
-- Manish Rathi
-- Jorge Revuelta H
 - Josh Holtz
+- Luka Mirosevic
+- Felix Krause
+- Iulian Onofrei
+- Satoshi Namai
+- Jan Piotrowski
 - Joshua Liebowitz
-- Kohki Miki
+- Manish Rathi
+- Helmut Januschka
+- Olivier Halligon
+- Stefan Natchev
 - Max Ott
+- Roger Oba
+- Kohki Miki
 - Andrew McBurney
-- Jan Piotrowski
-- Stefan Natchev
+- Jorge Revuelta H
+- Daniel Jankowski
+- Aaron Brager
+- Fumiya Nakamura
+- Manu Wallner
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2021-12-10 00:00:00.000000000 Z
+date: 2022-01-13 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: xcodeproj
@@ -1707,6 +1707,8 @@ files:
 - spaceship/lib/spaceship/connect_api/models/pre_release_version.rb
 - spaceship/lib/spaceship/connect_api/models/profile.rb
 - spaceship/lib/spaceship/connect_api/models/reset_ratings_request.rb
+- spaceship/lib/spaceship/connect_api/models/review_submission.rb
+- spaceship/lib/spaceship/connect_api/models/review_submission_item.rb
 - spaceship/lib/spaceship/connect_api/models/sandbox_tester.rb
 - spaceship/lib/spaceship/connect_api/models/territory.rb
 - spaceship/lib/spaceship/connect_api/models/user.rb