fastlane 2.196.0 → 2.212.2

data/fastlane/lib/fastlane/actions/download_dsyms.rb

@@ -12,11 +12,18 @@ module Fastlane
         require 'net/http'
         require 'date'
 
-        # Team selection passed though FASTLANE_ITC_TEAM_ID and FASTLANE_ITC_TEAM_NAME environment variables
-        # Prompts select team if multiple teams and none specified
-        UI.message("Login to App Store Connect (#{params[:username]})")
-        Spaceship::ConnectAPI.login(params[:username], use_portal: false, use_tunes: true)
-        UI.message("Login successful")
+        if (api_token = Spaceship::ConnectAPI::Token.from(hash: params[:api_key], filepath: params[:api_key_path]))
+          UI.message("Creating authorization token for App Store Connect API")
+          Spaceship::ConnectAPI.token = api_token
+        elsif !Spaceship::ConnectAPI.token.nil?
+          UI.message("Using existing authorization token for App Store Connect API")
+        else
+          # Team selection passed though FASTLANE_ITC_TEAM_ID and FASTLANE_ITC_TEAM_NAME environment variables
+          # Prompts select team if multiple teams and none specified
+          UI.message("Login to App Store Connect (#{params[:username]})")
+          Spaceship::ConnectAPI.login(params[:username], use_portal: false, use_tunes: true)
+          UI.message("Login successful")
+        end
 
         # Get App
         app = Spaceship::ConnectAPI::App.find(params[:app_identifier])
@@ -68,10 +75,11 @@ module Fastlane
 
         filter = { app: app.id }
         filter["preReleaseVersion.platform"] = platform
-        build_resps = Spaceship::ConnectAPI.get_builds(filter: filter, sort: "-uploadedDate", includes: "preReleaseVersion").all_pages
-        builds = build_resps.flat_map(&:to_models)
+        filter["preReleaseVersion.version"] = version if version
+        filter["version"] = build_number if build_number
+        build_resp = Spaceship::ConnectAPI.get_builds(filter: filter, sort: "-uploadedDate", includes: "preReleaseVersion,buildBundles")
 
-        builds.each do |build|
+        build_resp.all_pages_each do |build|
           asc_app_version = build.app_version
           asc_build_number = build.version
           uploaded_date = DateTime.parse(build.uploaded_date)
@@ -93,7 +101,7 @@ module Fastlane
 
           if after_uploaded_date && after_uploaded_date >= uploaded_date
             UI.verbose("Upload date #{after_uploaded_date} not reached: #{uploaded_date}")
-            next
+            break
           end
 
           message = []
@@ -107,46 +115,37 @@ module Fastlane
           end
 
           UI.verbose("Build_version: #{asc_build_number} matches #{build_number}, grabbing dsym_url") if build_number
-          get_details_and_download_dsym(app: app, train: asc_app_version, build_number: asc_build_number, uploaded_date: uploaded_date, platform: itc_platform, wait_for_dsym_processing: wait_for_dsym_processing, wait_timeout: wait_timeout, output_directory: output_directory)
+          download_dsym(build: build, app: app, wait_for_dsym_processing: wait_for_dsym_processing, wait_timeout: wait_timeout, output_directory: output_directory)
         end
       end
 
-      def self.get_details_and_download_dsym(app: nil, train: nil, build_number: nil, uploaded_date: nil, platform: nil, wait_for_dsym_processing: nil, wait_timeout: nil, output_directory: nil)
+      def self.download_dsym(build: nil, app: nil, wait_for_dsym_processing: nil, wait_timeout: nil, output_directory: nil)
         start = Time.now
-        download_url = nil
+        dsym_urls = []
 
         loop do
-          begin
-            resp = Spaceship::Tunes.client.build_details(app_id: app.id, train: train, build_number: build_number, platform: platform)
-
-            resp['apple_id'] = app.id
-            build_details = Spaceship::Tunes::BuildDetails.factory(resp)
-
-            download_url = build_details.dsym_url
-            UI.verbose("dsym_url: #{download_url}")
-          rescue Spaceship::TunesClient::ITunesConnectError => ex
-            UI.error("Error accessing dSYM file for build\n\n#{build}\n\nException: #{ex}")
-          end
-
-          unless download_url
-            if !wait_for_dsym_processing || (Time.now - start) > wait_timeout
-              # In some cases, AppStoreConnect does not process the dSYMs, thus no error should be thrown.
-              UI.message("Could not find any dSYM for #{build_number} (#{train})")
-            else
-              UI.message("Waiting for dSYM file to appear...")
-              sleep(30)
-              next
-            end
+          build_bundles = build.build_bundles.select { |b| b.includes_symbols == true }
+          dsym_urls = build_bundles.map(&:dsym_url).compact
+
+          break if build_bundles.count == dsym_urls.count
+
+          if !wait_for_dsym_processing || (Time.now - start) > wait_timeout
+            # In some cases, AppStoreConnect does not process the dSYMs, thus no error should be thrown.
+            UI.message("Could not find any dSYM for #{build.version} (#{build.app_version})")
+            break
+          else
+            UI.message("Waiting for dSYM file to appear...")
+            sleep(30) unless FastlaneCore::Helper.is_test?
+            build = Spaceship::ConnectAPI::Build.get(build_id: build.id)
           end
-
-          break
         end
 
-        if download_url
-          self.download(download_url, app.bundle_id, train, build_number, uploaded_date, output_directory)
-          return if build_number
+        if dsym_urls.count == 0
+          UI.message("No dSYM URL for #{build.version} (#{build.app_version})")
         else
-          UI.message("No dSYM URL for #{build_number} (#{train})")
+          dsym_urls.each do |url|
+            self.download(url, build, app, output_directory)
+          end
         end
       end
       # rubocop:enable Metrics/PerceivedComplexity
@@ -154,7 +153,7 @@ module Fastlane
       def self.get_latest_build!(app_id: nil, platform: nil)
         filter = { app: app_id }
         filter["preReleaseVersion.platform"] = platform
-        latest_build = Spaceship::ConnectAPI.get_builds(filter: filter, sort: "-uploadedDate", includes: "preReleaseVersion").first
+        latest_build = Spaceship::ConnectAPI.get_builds(filter: filter, sort: "-uploadedDate", includes: "preReleaseVersion,buildBundles").first
 
         if latest_build.nil?
           UI.user_error!("Could not find any build for platform #{platform}") if platform
@@ -164,18 +163,18 @@ module Fastlane
         return latest_build
       end
 
-      def self.download(download_url, bundle_id, train_number, build_version, uploaded_date, output_directory)
+      def self.download(download_url, build, app, output_directory)
         result = self.download_file(download_url)
-        path   = write_dsym(result, bundle_id, train_number, build_version, output_directory)
-        UI.success("🔑  Successfully downloaded dSYM file for #{train_number} - #{build_version} to '#{path}'")
+        path   = write_dsym(result, app.bundle_id, build.app_version, build.version, output_directory)
+        UI.success("🔑  Successfully downloaded dSYM file for #{build.app_version} - #{build.version} to '#{path}'")
 
         Actions.lane_context[SharedValues::DSYM_PATHS] ||= []
         Actions.lane_context[SharedValues::DSYM_PATHS] << File.expand_path(path)
 
-        unless uploaded_date.nil?
-          Actions.lane_context[SharedValues::DSYM_LATEST_UPLOADED_DATE] ||= uploaded_date
+        unless build.uploaded_date.nil?
+          Actions.lane_context[SharedValues::DSYM_LATEST_UPLOADED_DATE] ||= build.uploaded_date
           current_latest = Actions.lane_context[SharedValues::DSYM_LATEST_UPLOADED_DATE]
-          Actions.lane_context[SharedValues::DSYM_LATEST_UPLOADED_DATE] = [current_latest, uploaded_date].max
+          Actions.lane_context[SharedValues::DSYM_LATEST_UPLOADED_DATE] = [current_latest, build.uploaded_date].max
           UI.verbose("Most recent build uploaded_date #{Actions.lane_context[SharedValues::DSYM_LATEST_UPLOADED_DATE]}")
         end
       end
@@ -234,6 +233,23 @@ module Fastlane
         user ||= CredentialsManager::AppfileConfig.try_fetch_value(:apple_id)
 
         [
+          FastlaneCore::ConfigItem.new(key: :api_key_path,
+                                       env_names: ["DOWNLOAD_DSYMS_API_KEY_PATH", "APP_STORE_CONNECT_API_KEY_PATH"],
+                                       description: "Path to your App Store Connect API Key JSON file (https://docs.fastlane.tools/app-store-connect-api/#using-fastlane-api-key-json-file)",
+                                       optional: true,
+                                       conflicting_options: [:api_key],
+                                       verify_block: proc do |value|
+                                         UI.user_error!("Couldn't find API key JSON file at path '#{value}'") unless File.exist?(value)
+                                       end),
+          FastlaneCore::ConfigItem.new(key: :api_key,
+                                       env_names: ["DOWNLOAD_DSYMS_API_KEY", "APP_STORE_CONNECT_API_KEY"],
+                                       description: "Your App Store Connect API Key information (https://docs.fastlane.tools/app-store-connect-api/#use-return-value-and-pass-in-as-an-option)",
+                                       type: Hash,
+                                       default_value: Fastlane::Actions.lane_context[Fastlane::Actions::SharedValues::APP_STORE_CONNECT_API_KEY],
+                                       default_value_dynamic: true,
+                                       optional: true,
+                                       sensitive: true,
+                                       conflicting_options: [:api_key_path]),
           FastlaneCore::ConfigItem.new(key: :username,
                                        short_option: "-u",
                                        env_name: "DOWNLOAD_DSYMS_USERNAME",

data/fastlane/lib/fastlane/actions/ensure_git_status_clean.rb

@@ -8,8 +8,9 @@ module Fastlane
     class EnsureGitStatusCleanAction < Action
       def self.run(params)
         if params[:ignored]
-          ignored_file = params[:ignored]
-          repo_status = Actions.sh("git status --porcelain --ignored #{ignored_file}")
+          ignored_mode = params[:ignored]
+          ignored_mode = 'no' if ignored_mode == 'none'
+          repo_status = Actions.sh("git status --porcelain --ignored='#{ignored_mode}'")
         else
           repo_status = Actions.sh("git status --porcelain")
         end
@@ -74,8 +75,18 @@ module Fastlane
                                        type: Boolean),
           FastlaneCore::ConfigItem.new(key: :ignored,
                                        env_name: "FL_ENSURE_GIT_STATUS_CLEAN_IGNORED_FILE",
-                                       description: "The flag whether to ignore file the git status if the repo is dirty",
-                                       optional: true)
+                                       description: [
+                                         "The handling mode of the ignored files. The available options are: `'traditional'`, `'none'` (default) and `'matching'`.",
+                                         "Specifying `'none'` to this parameter is the same as not specifying the parameter at all, which means that no ignored file will be used to check if the repo is dirty or not.",
+                                         "Specifying `'traditional'` or `'matching'` causes some ignored files to be used to check if the repo is dirty or not (more info in the official docs: https://git-scm.com/docs/git-status#Documentation/git-status.txt---ignoredltmodegt)"
+                                       ].join(" "),
+                                       optional: true,
+                                       verify_block: proc do |value|
+                                         mode = value.to_s
+                                         modes = %w(traditional none matching)
+
+                                         UI.user_error!("Unsupported mode, must be: #{modes}") unless modes.include?(mode)
+                                       end)
         ]
       end
 

data/fastlane/lib/fastlane/actions/ensure_xcode_version.rb

@@ -75,7 +75,7 @@ module Fastlane
         [
           "If building your app requires a specific version of Xcode, you can invoke this command before using gym.",
           "For example, to ensure that a beta version of Xcode is not accidentally selected to build, which would make uploading to TestFlight fail.",
-          "You can either manually provide a specific version using `version: ` or you make use of the `.xcode-version` file.",
+          "You can either manually provide a specific version using `version:` or you make use of the `.xcode-version` file.",
           "Using the `strict` parameter, you can either verify the full set of version numbers strictly (i.e. `11.3.1`) or only a subset of them (i.e. `11.3` or `11`)."
         ].join("\n")
       end

data/fastlane/lib/fastlane/actions/get_push_certificate.rb

@@ -60,7 +60,7 @@ module Fastlane
       end
 
       def self.is_supported?(platform)
-        platform == :ios
+        [:ios, :mac].include?(platform)
       end
 
       def self.example_code

data/fastlane/lib/fastlane/actions/get_version_number.rb

@@ -109,8 +109,10 @@ module Fastlane
           options = plist_files.keys
           selected = UI.select("What build configuration would you like to use?", options)
           plist_file = plist_files[selected]
-        else
+        elsif plist_files_count > 0
           plist_file = plist_files.values.first
+        else
+          return nil
         end
 
         # $(SRCROOT) is the path of where the XcodeProject is
@@ -131,9 +133,12 @@ module Fastlane
       end
 
       def self.get_version_number_from_plist!(plist_file)
+        return '$(MARKETING_VERSION)' if plist_file.nil?
+
         plist = Xcodeproj::Plist.read_from_path(plist_file)
         UI.user_error!("Unable to read plist: #{plist_file}") unless plist
 
+        return '${MARKETING_VERSION}' if plist["CFBundleShortVersionString"].nil?
         plist["CFBundleShortVersionString"]
       end
 
@@ -146,14 +151,14 @@ module Fastlane
       end
 
       def self.details
-        "This action will return the current version number set on your project."
+        "This action will return the current version number set on your project. It first looks in the plist and then for '$(MARKETING_VERSION)' in the build settings."
       end
 
       def self.available_options
         [
           FastlaneCore::ConfigItem.new(key: :xcodeproj,
                              env_name: "FL_VERSION_NUMBER_PROJECT",
-                             description: "Path to the Xcode project to read version number from, or its containing directory, optional. If ommitted, or if a directory is passed instead, it will use the first Xcode project found within the given directory, or the project root directory if none is passed",
+                             description: "Path to the Xcode project to read version number from, or its containing directory, optional. If omitted, or if a directory is passed instead, it will use the first Xcode project found within the given directory, or the project root directory if none is passed",
                              optional: true,
                              verify_block: proc do |value|
                                UI.user_error!("Please pass the path to the project or its containing directory, not the workspace path") if value.end_with?(".xcworkspace")

data/fastlane/lib/fastlane/actions/git_commit.rb

@@ -2,22 +2,20 @@ module Fastlane
   module Actions
     class GitCommitAction < Action
       def self.run(params)
-        paths = params[:path].map(&:shellescape).join(' ')
-
-        skip_git_hooks = params[:skip_git_hooks] ? '--no-verify' : ''
+        paths = params[:path]
+        skip_git_hooks = params[:skip_git_hooks] ? ['--no-verify'] : []
 
         if params[:allow_nothing_to_commit]
           # Here we check if the path passed in parameter contains any modification
           # and we skip the `git commit` command if there is none.
           # That means you can have other files modified that are not in the path parameter
           # and still make use of allow_nothing_to_commit.
-          repo_clean = Actions.sh("git status #{paths} --porcelain").empty?
+          repo_clean = Actions.sh('git', 'status', *paths, '--porcelain').empty?
           UI.success("Nothing to commit, working tree clean ✅.") if repo_clean
           return if repo_clean
         end
 
-        command = "git commit -m #{params[:message].shellescape} #{paths} #{skip_git_hooks}".strip
-        result = Actions.sh(command)
+        result = Actions.sh('git', 'commit', '-m', params[:message], *paths, *skip_git_hooks)
         UI.success("Successfully committed \"#{params[:path]}\" 💾.")
         return result
       end

data/fastlane/lib/fastlane/actions/import_certificate.rb

@@ -58,7 +58,7 @@ module Fastlane
 
       def self.example_code
         [
-          'import_certificate(certificate_path: "certs/AppleWWDRCA.cer")',
+          'import_certificate(certificate_path: "certs/AppleWWDRCA6.cer")',
           'import_certificate(
             certificate_path: "certs/dist.p12",
             certificate_password: ENV["CERTIFICATE_PASSWORD"] || "default"

data/fastlane/lib/fastlane/actions/notarize.rb

@@ -5,6 +5,7 @@ module Fastlane
       def self.run(params)
         package_path = params[:package]
         bundle_id = params[:bundle_id]
+        skip_stapling = params[:skip_stapling]
         try_early_stapling = params[:try_early_stapling]
         print_log = params[:print_log]
         verbose = params[:verbose]
@@ -38,13 +39,13 @@ module Fastlane
         UI.user_error!('Could not read bundle identifier, provide as a parameter') unless bundle_id
 
         if use_notarytool
-          notarytool(params, package_path, bundle_id, try_early_stapling, print_log, verbose, api_key, compressed_package_path)
+          notarytool(params, package_path, bundle_id, skip_stapling, print_log, verbose, api_key, compressed_package_path)
         else
-          altool(params, package_path, bundle_id, try_early_stapling, print_log, verbose, api_key, compressed_package_path)
+          altool(params, package_path, bundle_id, try_early_stapling, skip_stapling, print_log, verbose, api_key, compressed_package_path)
         end
       end
 
-      def self.notarytool(params, package_path, bundle_id, try_early_stapling, print_log, verbose, api_key, compressed_package_path)
+      def self.notarytool(params, package_path, bundle_id, skip_stapling, print_log, verbose, api_key, compressed_package_path)
         temp_file = nil
 
         # Create authorization part of command with either API Key or Apple ID
@@ -89,10 +90,15 @@ module Fastlane
           submission_id = notarization_info["id"]
           UI.success("Successfully uploaded package to notarization service with request identifier #{submission_id}")
 
-          UI.message('Stapling package')
-          self.staple(package_path, verbose)
+          if skip_stapling
+            UI.success("Successfully notarized artifact")
+          else
+            UI.message('Stapling package')
 
-          UI.success("Successfully notarized and stapled package")
+            self.staple(package_path, verbose)
+
+            UI.success("Successfully notarized and stapled package")
+          end
         when 'Invalid'
           UI.user_error!("Could not notarize package with message '#{notarization_info['statusSummary']}'")
         else
@@ -102,7 +108,7 @@ module Fastlane
         temp_file.delete if temp_file
       end
 
-      def self.altool(params, package_path, bundle_id, try_early_stapling, print_log, verbose, api_key, compressed_package_path)
+      def self.altool(params, package_path, bundle_id, try_early_stapling, skip_stapling, print_log, verbose, api_key, compressed_package_path)
         UI.message('Uploading package to notarization service, might take a while')
 
         notarization_upload_command = "xcrun altool --notarize-app -t osx -f \"#{compressed_package_path || package_path}\" --primary-bundle-id #{bundle_id} --output-format xml"
@@ -133,7 +139,7 @@ module Fastlane
           while notarization_info.empty? || (notarization_info['Status'] == 'in progress')
             if notarization_info.empty?
               UI.message('Waiting to query request status')
-            elsif try_early_stapling
+            elsif try_early_stapling && !skip_stapling
               UI.message('Request in progress, trying early staple')
 
               begin
@@ -182,11 +188,15 @@ module Fastlane
 
         case notarization_info['Status']
         when 'success'
-          UI.message('Stapling package')
+          if skip_stapling
+            UI.success("Successfully notarized artifact#{log_suffix}")
+          else
+            UI.message('Stapling package')
 
-          self.staple(package_path, verbose)
+            self.staple(package_path, verbose)
 
-          UI.success("Successfully notarized and stapled package#{log_suffix}")
+            UI.success("Successfully notarized and stapled package#{log_suffix}")
+          end
         when 'invalid'
           UI.user_error!("Could not notarize package with message '#{notarization_info['Status Message']}'#{log_suffix}")
         else
@@ -262,6 +272,14 @@ module Fastlane
                                        env_name: 'FL_NOTARIZE_TRY_EARLY_STAPLING',
                                        description: 'Whether to try early stapling while the notarization request is in progress',
                                        optional: true,
+                                       conflicting_options: [:skip_stapling],
+                                       default_value: false,
+                                       type: Boolean),
+          FastlaneCore::ConfigItem.new(key: :skip_stapling,
+                                       env_name: 'FL_NOTARIZE_SKIP_STAPLING',
+                                       description: 'Do not staple the notarization ticket to the artifact; useful for single file executables and ZIP archives',
+                                       optional: true,
+                                       conflicting_options: [:try_early_stapling],
                                        default_value: false,
                                        type: Boolean),
           FastlaneCore::ConfigItem.new(key: :bundle_id,

data/fastlane/lib/fastlane/actions/pod_lib_lint.rb

@@ -29,7 +29,7 @@ module Fastlane
         command << "--analyze" if params[:analyze]
 
         result = Actions.sh(command.join(' '))
-        UI.success("Pod lib lint Successfully ⬆️ ")
+        UI.success("Pod lib lint successful ⬆️ ")
         return result
       end
 

data/fastlane/lib/fastlane/actions/pod_push.rb

@@ -59,6 +59,14 @@ module Fastlane
           command << "--synchronous"
         end
 
+        if params[:no_overwrite]
+          command << "--no-overwrite"
+        end
+
+        if params[:local_only]
+          command << "--local-only"
+        end
+
         result = Actions.sh(command.join(' '))
         UI.success("Successfully pushed Podspec ⬆️ ")
         return result
@@ -143,7 +151,17 @@ module Fastlane
                                        description: "If validation depends on other recently pushed pods, synchronize",
                                        optional: true,
                                        type: Boolean,
-                                       env_name: "FL_POD_PUSH_SYNCHRONOUS")
+                                       env_name: "FL_POD_PUSH_SYNCHRONOUS"),
+          FastlaneCore::ConfigItem.new(key: :no_overwrite,
+                                       description: "Disallow pushing that would overwrite an existing spec",
+                                       optional: true,
+                                       type: Boolean,
+                                       env_name: "FL_POD_PUSH_NO_OVERWRITE"),
+          FastlaneCore::ConfigItem.new(key: :local_only,
+                                       description: "Does not perform the step of pushing REPO to its remote",
+                                       optional: true,
+                                       type: Boolean,
+                                       env_name: "FL_POD_PUSH_LOCAL_ONLY")
         ]
       end
 

data/fastlane/lib/fastlane/actions/read_podspec.rb

@@ -79,7 +79,7 @@ module Fastlane
       end
 
       def self.return_type
-        :hash_of_strings
+        :hash
       end
 
       def self.category

data/fastlane/lib/fastlane/actions/run_tests.rb

@@ -4,6 +4,7 @@ module Fastlane
       SCAN_DERIVED_DATA_PATH = :SCAN_DERIVED_DATA_PATH
       SCAN_GENERATED_PLIST_FILE = :SCAN_GENERATED_PLIST_FILE
       SCAN_GENERATED_PLIST_FILES = :SCAN_GENERATED_PLIST_FILES
+      SCAN_GENERATED_XCRESULT_PATH = :SCAN_GENERATED_XCRESULT_PATH
       SCAN_ZIP_BUILD_PRODUCTS_PATH = :SCAN_ZIP_BUILD_PRODUCTS_PATH
     end
 
@@ -13,12 +14,12 @@ module Fastlane
         manager = Scan::Manager.new
 
         begin
-          manager.work(values)
+          results = manager.work(values)
 
           zip_build_products_path = Scan.cache[:zip_build_products_path]
           Actions.lane_context[SharedValues::SCAN_ZIP_BUILD_PRODUCTS_PATH] = zip_build_products_path if zip_build_products_path
 
-          return true
+          return results
         rescue FastlaneCore::Interface::FastlaneBuildFailure => ex
           # Specifically catching FastlaneBuildFailure to prevent build/compile errors from being
           # silenced when :fail_build is set to false
@@ -29,6 +30,12 @@ module Fastlane
             raise ex
           end
         ensure
+          if Scan.cache && (result_bundle_path = Scan.cache[:result_bundle_path])
+            Actions.lane_context[SharedValues::SCAN_GENERATED_XCRESULT_PATH] = File.absolute_path(result_bundle_path)
+          else
+            Actions.lane_context[SharedValues::SCAN_GENERATED_XCRESULT_PATH] = nil
+          end
+
           unless values[:derived_data_path].to_s.empty?
             plist_files_before = manager.plist_files_before || []
 
@@ -49,6 +56,14 @@ module Fastlane
         "More information: https://docs.fastlane.tools/actions/scan/"
       end
 
+      def self.return_value
+        'Outputs hash of results with the following keys: :number_of_tests, :number_of_failures, :number_of_retries, :number_of_tests_excluding_retries, :number_of_failures_excluding_retries'
+      end
+
+      def self.return_type
+        :hash
+      end
+
       def self.author
         "KrauseFx"
       end
@@ -56,13 +71,7 @@ module Fastlane
       def self.available_options
         require 'scan'
 
-        FastlaneCore::CommanderGenerator.new.generate(Scan::Options.available_options) + [
-          FastlaneCore::ConfigItem.new(key: :fail_build,
-                                       env_name: "SCAN_FAIL_BUILD",
-                                       description: "Should this step stop the build if the tests fail? Set this to false if you're using trainer",
-                                       type: Boolean,
-                                       default_value: true)
-        ]
+        FastlaneCore::CommanderGenerator.new.generate(Scan::Options.available_options)
       end
 
       def self.output
@@ -70,6 +79,7 @@ module Fastlane
           ['SCAN_DERIVED_DATA_PATH', 'The path to the derived data'],
           ['SCAN_GENERATED_PLIST_FILE', 'The generated plist file'],
           ['SCAN_GENERATED_PLIST_FILES', 'The generated plist files'],
+          ['SCAN_GENERATED_XCRESULT_PATH', 'The path to the generated .xcresult'],
           ['SCAN_ZIP_BUILD_PRODUCTS_PATH', 'The path to the zipped build products']
         ]
       end

data/fastlane/lib/fastlane/actions/set_github_release.rb

@@ -19,11 +19,12 @@ module Fastlane
 
         payload = {
           'tag_name' => params[:tag_name],
-          'name' => params[:name],
-          'body' => params[:description],
           'draft' => !!params[:is_draft],
-          'prerelease' => !!params[:is_prerelease]
+          'prerelease' => !!params[:is_prerelease],
+          'generate_release_notes' => !!params[:is_generate_release_notes]
         }
+        payload['name'] = params[:name] if params[:name]
+        payload['body'] = params[:description] if params[:description]
         payload['target_commitish'] = params[:commitish] if params[:commitish]
 
         GithubApiAction.run(
@@ -48,8 +49,7 @@ module Fastlane
               UI.user_error!("You are not authorized to access #{repo_name}, please make sure you provided a valid API token (GITHUB_API_TOKEN)")
             end,
             '*' => proc do |result|
-              UI.error("GitHub responded with #{result[:status]}:#{result[:body]}")
-              return nil
+              UI.user_error!("GitHub responded with #{result[:status]}:#{result[:body]}")
             end
           }
         ) do |result|
@@ -221,6 +221,12 @@ module Fastlane
                                        optional: true,
                                        default_value: false,
                                        type: Boolean),
+          FastlaneCore::ConfigItem.new(key: :is_generate_release_notes,
+                                       env_name: "FL_SET_GITHUB_RELEASE_IS_GENERATE_RELEASE_NOTES",
+                                       description: "Whether the name and body of this release should be generated automatically",
+                                       optional: true,
+                                       default_value: false,
+                                       type: Boolean),
           FastlaneCore::ConfigItem.new(key: :upload_assets,
                                        env_name: "FL_SET_GITHUB_RELEASE_UPLOAD_ASSETS",
                                        description: "Path to assets to be uploaded with the release",

data/fastlane/lib/fastlane/actions/setup_ci.rb

@@ -12,7 +12,7 @@ module Fastlane
           setup_output_paths
         end
 
-        setup_keychain
+        setup_keychain(params)
       end
 
       def self.should_run?(params)
@@ -23,7 +23,7 @@ module Fastlane
         params[:provider] || (Helper.is_circle_ci? ? 'circleci' : nil)
       end
 
-      def self.setup_keychain
+      def self.setup_keychain(params)
         unless Helper.mac?
           UI.message("Skipping Keychain setup on non-macOS CI Agent")
           return
@@ -43,7 +43,7 @@ module Fastlane
           name: keychain_name,
           default_keychain: true,
           unlock: true,
-          timeout: 3600,
+          timeout: params[:timeout],
           lock_when_sleeps: true,
           password: "",
           add_to_search_list: true
@@ -103,7 +103,12 @@ module Fastlane
                                          # Validate both 'travis' and 'circleci' for backwards compatibility, even
                                          # though only the latter receives special treatment by this action
                                          UI.user_error!("A given CI provider '#{value}' is not supported. Available CI providers: 'travis', 'circleci'") unless ["travis", "circleci"].include?(value)
-                                       end)
+                                       end),
+          FastlaneCore::ConfigItem.new(key: :timeout,
+                                       env_name: "FL_SETUP_CI_TIMEOUT",
+                                       description: "Set a custom timeout in seconds for keychain.  Set `0` if you want to specify 'no time-out'",
+                                       type: Integer,
+                                       default_value: 3600)
         ]
       end
 
@@ -119,6 +124,10 @@ module Fastlane
         [
           'setup_ci(
             provider: "circleci"
+          )',
+          'setup_ci(
+            provider: "circleci",
+            timeout: 0
           )'
         ]
       end