fastlane 2.196.0 → 2.199.0

data/fastlane/lib/fastlane/actions/notarize.rb

@@ -5,6 +5,7 @@ module Fastlane
       def self.run(params)
         package_path = params[:package]
         bundle_id = params[:bundle_id]
+        skip_stapling = params[:skip_stapling]
         try_early_stapling = params[:try_early_stapling]
         print_log = params[:print_log]
         verbose = params[:verbose]
@@ -38,13 +39,13 @@ module Fastlane
         UI.user_error!('Could not read bundle identifier, provide as a parameter') unless bundle_id
 
         if use_notarytool
-          notarytool(params, package_path, bundle_id, try_early_stapling, print_log, verbose, api_key, compressed_package_path)
+          notarytool(params, package_path, bundle_id, skip_stapling, print_log, verbose, api_key, compressed_package_path)
         else
-          altool(params, package_path, bundle_id, try_early_stapling, print_log, verbose, api_key, compressed_package_path)
+          altool(params, package_path, bundle_id, try_early_stapling, skip_stapling, print_log, verbose, api_key, compressed_package_path)
         end
       end
 
-      def self.notarytool(params, package_path, bundle_id, try_early_stapling, print_log, verbose, api_key, compressed_package_path)
+      def self.notarytool(params, package_path, bundle_id, skip_stapling, print_log, verbose, api_key, compressed_package_path)
         temp_file = nil
 
         # Create authorization part of command with either API Key or Apple ID
@@ -89,10 +90,15 @@ module Fastlane
           submission_id = notarization_info["id"]
           UI.success("Successfully uploaded package to notarization service with request identifier #{submission_id}")
 
-          UI.message('Stapling package')
-          self.staple(package_path, verbose)
+          if skip_stapling
+            UI.success("Successfully notarized artifact")
+          else
+            UI.message('Stapling package')
 
-          UI.success("Successfully notarized and stapled package")
+            self.staple(package_path, verbose)
+
+            UI.success("Successfully notarized and stapled package")
+          end
         when 'Invalid'
           UI.user_error!("Could not notarize package with message '#{notarization_info['statusSummary']}'")
         else
@@ -102,7 +108,7 @@ module Fastlane
         temp_file.delete if temp_file
       end
 
-      def self.altool(params, package_path, bundle_id, try_early_stapling, print_log, verbose, api_key, compressed_package_path)
+      def self.altool(params, package_path, bundle_id, try_early_stapling, skip_stapling, print_log, verbose, api_key, compressed_package_path)
         UI.message('Uploading package to notarization service, might take a while')
 
         notarization_upload_command = "xcrun altool --notarize-app -t osx -f \"#{compressed_package_path || package_path}\" --primary-bundle-id #{bundle_id} --output-format xml"
@@ -133,7 +139,7 @@ module Fastlane
           while notarization_info.empty? || (notarization_info['Status'] == 'in progress')
             if notarization_info.empty?
               UI.message('Waiting to query request status')
-            elsif try_early_stapling
+            elsif try_early_stapling && !skip_stapling
               UI.message('Request in progress, trying early staple')
 
               begin
@@ -182,11 +188,15 @@ module Fastlane
 
         case notarization_info['Status']
         when 'success'
-          UI.message('Stapling package')
+          if skip_stapling
+            UI.success("Successfully notarized artifact#{log_suffix}")
+          else
+            UI.message('Stapling package')
 
-          self.staple(package_path, verbose)
+            self.staple(package_path, verbose)
 
-          UI.success("Successfully notarized and stapled package#{log_suffix}")
+            UI.success("Successfully notarized and stapled package#{log_suffix}")
+          end
         when 'invalid'
           UI.user_error!("Could not notarize package with message '#{notarization_info['Status Message']}'#{log_suffix}")
         else
@@ -262,6 +272,14 @@ module Fastlane
                                        env_name: 'FL_NOTARIZE_TRY_EARLY_STAPLING',
                                        description: 'Whether to try early stapling while the notarization request is in progress',
                                        optional: true,
+                                       conflicting_options: [:skip_stapling],
+                                       default_value: false,
+                                       type: Boolean),
+          FastlaneCore::ConfigItem.new(key: :skip_stapling,
+                                       env_name: 'FL_NOTARIZE_SKIP_STAPLING',
+                                       description: 'Do not staple the notarization ticket to the artifact; useful for single file executables and ZIP archives',
+                                       optional: true,
+                                       conflicting_options: [:try_early_stapling],
                                        default_value: false,
                                        type: Boolean),
           FastlaneCore::ConfigItem.new(key: :bundle_id,

data/fastlane/lib/fastlane/actions/set_github_release.rb

@@ -19,11 +19,12 @@ module Fastlane
 
         payload = {
           'tag_name' => params[:tag_name],
-          'name' => params[:name],
-          'body' => params[:description],
           'draft' => !!params[:is_draft],
-          'prerelease' => !!params[:is_prerelease]
+          'prerelease' => !!params[:is_prerelease],
+          'generate_release_notes' => !!params[:is_generate_release_notes]
         }
+        payload['name'] = params[:name] if params[:name]
+        payload['body'] = params[:description] if params[:description]
         payload['target_commitish'] = params[:commitish] if params[:commitish]
 
         GithubApiAction.run(
@@ -48,8 +49,7 @@ module Fastlane
               UI.user_error!("You are not authorized to access #{repo_name}, please make sure you provided a valid API token (GITHUB_API_TOKEN)")
             end,
             '*' => proc do |result|
-              UI.error("GitHub responded with #{result[:status]}:#{result[:body]}")
-              return nil
+              UI.user_error!("GitHub responded with #{result[:status]}:#{result[:body]}")
             end
           }
         ) do |result|
@@ -221,6 +221,12 @@ module Fastlane
                                        optional: true,
                                        default_value: false,
                                        type: Boolean),
+          FastlaneCore::ConfigItem.new(key: :is_generate_release_notes,
+                                       env_name: "FL_SET_GITHUB_RELEASE_IS_GENERATE_RELEASE_NOTES",
+                                       description: "Whether the name and body of this release should be generated automatically",
+                                       optional: true,
+                                       default_value: false,
+                                       type: Boolean),
           FastlaneCore::ConfigItem.new(key: :upload_assets,
                                        env_name: "FL_SET_GITHUB_RELEASE_UPLOAD_ASSETS",
                                        description: "Path to assets to be uploaded with the release",

data/fastlane/lib/fastlane/actions/update_code_signing_settings.rb

@@ -50,6 +50,10 @@ module Fastlane
               set_build_setting(config, "PROVISIONING_PROFILE_SPECIFIER", params[:profile_name])
               UI.important("Set Provisioning Profile name to: #{params[:profile_name]} for target: #{target.name} for build configuration: #{config.name}")
             end
+            if params[:entitlements_file_path]
+              set_build_setting(config, "CODE_SIGN_ENTITLEMENTS", params[:entitlements_file_path])
+              UI.important("Set Entitlements file path to: #{params[:entitlements_file_path]} for target: #{target.name} for build configuration: #{config.name}")
+            end
             # Since Xcode 8, this is no longer needed, you simply use PROVISIONING_PROFILE_SPECIFIER
             if params[:profile_uuid]
               set_build_setting(config, "PROVISIONING_PROFILE", params[:profile_uuid])
@@ -143,6 +147,10 @@ module Fastlane
                                        env_name: "FL_CODE_SIGN_IDENTITY",
                                        description: "Code signing identity type (iPhone Developer, iPhone Distribution)",
                                        optional: true),
+          FastlaneCore::ConfigItem.new(key: :entitlements_file_path,
+                                       env_name: "FL_CODE_SIGN_ENTITLEMENTS_FILE_PATH",
+                                       description: "Path to your entitlements file",
+                                       optional: true),
           FastlaneCore::ConfigItem.new(key: :profile_name,
                                        env_name: "FL_PROVISIONING_PROFILE_SPECIFIER",
                                        description: "Provisioning profile name to use for code signing",
@@ -172,6 +180,15 @@ module Fastlane
           update_code_signing_settings(
             use_automatic_signing: true,
             path: "demo-project/demo/demo.xcodeproj"
+          )',
+          ' # more advanced manual code signing
+          update_code_signing_settings(
+            use_automatic_signing: true,
+            path: "demo-project/demo/demo.xcodeproj",
+            team_id: "QABC123DEV",
+            bundle_identifier: "com.demoapp.QABC123DEV",
+            profile_name: "Demo App Deployment Profile",
+            entitlements_file_path: "Demo App/generated/New.entitlements"
           )'
         ]
       end
@@ -185,7 +202,7 @@ module Fastlane
       end
 
       def self.authors
-        ["mathiasAichinger", "hjanuschka", "p4checo", "portellaa", "aeons", "att55"]
+        ["mathiasAichinger", "hjanuschka", "p4checo", "portellaa", "aeons", "att55", "abcdev"]
       end
 
       def self.is_supported?(platform)

data/fastlane/lib/fastlane/actions/xcversion.rb

@@ -5,6 +5,7 @@ module Fastlane
         Actions.verify_gem!('xcode-install')
 
         version = params[:version]
+
         xcode = Helper::XcversionHelper.find_xcode(version)
         UI.user_error!("Cannot find an installed Xcode satisfying '#{version}'") if xcode.nil?
 
@@ -14,16 +15,29 @@ module Fastlane
         ENV["DEVELOPER_DIR"] = File.join(xcode.path, "/Contents/Developer")
       end
 
+      def self.read_xcode_version_file
+        xcode_version_paths = Dir.glob(".xcode-version")
+
+        if xcode_version_paths.first
+          return File.read(xcode_version_paths.first).strip
+        end
+
+        return nil
+      end
+
       def self.description
         "Select an Xcode to use by version specifier"
       end
 
       def self.details
-        "Finds and selects a version of an installed Xcode that best matches the provided [`Gem::Version` requirement specifier](http://www.rubydoc.info/github/rubygems/rubygems/Gem/Version)"
+        [
+          "Finds and selects a version of an installed Xcode that best matches the provided [`Gem::Version` requirement specifier](http://www.rubydoc.info/github/rubygems/rubygems/Gem/Version)",
+          "You can either manually provide a specific version using `version:` or you make use of the `.xcode-version` file."
+        ].join("\n")
       end
 
       def self.authors
-        ["oysta"]
+        ["oysta", "rogerluan"]
       end
 
       def self.available_options
@@ -31,7 +45,8 @@ module Fastlane
           FastlaneCore::ConfigItem.new(key: :version,
                                        env_name: "FL_XCODE_VERSION",
                                        description: "The version of Xcode to select specified as a Gem::Version requirement string (e.g. '~> 7.1.0')",
-                                       optional: false,
+                                       default_value: self.read_xcode_version_file,
+                                       default_value_dynamic: true,
                                        verify_block: Helper::XcversionHelper::Verify.method(:requirement))
         ]
       end

data/fastlane/lib/fastlane/documentation/docs_generator.rb

@@ -4,21 +4,18 @@ module Fastlane
       output_path ||= File.join(FastlaneCore::FastlaneFolder.path || '.', 'README.md')
 
       output = ["fastlane documentation"]
-      output << "================"
+      output << "----"
+      output << ""
 
       output << "# Installation"
       output << ""
       output << "Make sure you have the latest version of the Xcode command line tools installed:"
       output << ""
-      output << "```"
+      output << "```sh"
       output << "xcode-select --install"
       output << "```"
       output << ""
-      output << "Install _fastlane_ using"
-      output << "```"
-      output << "[sudo] gem install fastlane -NV"
-      output << "```"
-      output << "or alternatively using `brew install fastlane`"
+      output << "For _fastlane_ installation instructions, see [Installing _fastlane_](https://docs.fastlane.tools/#installing-fastlane)"
       output << ""
       output << "# Available Actions"
 
@@ -32,7 +29,10 @@ module Fastlane
           next
         end
 
-        output << "## #{formatted_platform(platform)}" if platform
+        if platform
+          output << ""
+          output << "## #{formatted_platform(platform)}"
+        end
 
         lanes.each do |lane_name, lane|
           next if lane.is_private
@@ -45,8 +45,10 @@ module Fastlane
       end
 
       output << "This README.md is auto-generated and will be re-generated every time [_fastlane_](https://fastlane.tools) is run."
-      output << "More information about fastlane can be found on [fastlane.tools](https://fastlane.tools)."
-      output << "The documentation of fastlane can be found on [docs.fastlane.tools](https://docs.fastlane.tools)."
+      output << ""
+      output << "More information about _fastlane_ can be found on [fastlane.tools](https://fastlane.tools)."
+      output << ""
+      output << "The documentation of _fastlane_ can be found on [docs.fastlane.tools](https://docs.fastlane.tools)."
       output << ""
 
       begin
@@ -78,10 +80,13 @@ module Fastlane
       full_name = [platform, lane].reject(&:nil?).join(' ')
 
       output = []
+      output << ""
       output << "### #{full_name}"
+      output << ""
+      output << "```sh"
+      output << "[bundle exec] fastlane #{full_name}"
       output << "```"
-      output << "fastlane #{full_name}"
-      output << "```"
+      output << ""
       output << description
       output
     end

data/fastlane/lib/fastlane/version.rb

@@ -1,5 +1,5 @@
 module Fastlane
-  VERSION = '2.196.0'.freeze
+  VERSION = '2.199.0'.freeze
   DESCRIPTION = "The easiest way to automate beta deployments and releases for your iOS and Android apps".freeze
   MINIMUM_XCODE_RELEASE = "7.0".freeze
   RUBOCOP_REQUIREMENT = '1.12.1'.freeze

data/fastlane/swift/Deliverfile.swift

@@ -17,4 +17,4 @@ public class Deliverfile: DeliverfileProtocol {
     // during the `init` process, and you won't see this message
 }
 
-// Generated with fastlane 2.196.0
+// Generated with fastlane 2.199.0

data/fastlane/swift/DeliverfileProtocol.swift

@@ -260,4 +260,4 @@ public extension DeliverfileProtocol {
 
 // Please don't remove the lines below
 // They are used to detect outdated files
-// FastlaneRunnerAPIVersion [0.9.85]
+// FastlaneRunnerAPIVersion [0.9.89]