fastlane 2.192.0 → 2.195.0

data/spaceship/lib/spaceship/connect_api/models/app_store_version.rb

@@ -112,7 +112,7 @@ module Spaceship
 
       # @deprecated
       def fetch_age_rating_declaration(client: nil)
-        raise 'AppStoreVersion no longer as AgeRatingDelcaration as of App Store Connect API 1.3 - Use AppInfo instead'
+        raise 'AppStoreVersion no longer as AgeRatingDeclaration as of App Store Connect API 1.3 - Use AppInfo instead'
       end
 
       #

data/spaceship/lib/spaceship/connect_api/models/build.rb

@@ -86,6 +86,10 @@ module Spaceship
         return build_beta_detail.nil? == false && build_beta_detail.ready_for_internal_testing?
       end
 
+      def ready_for_external_testing?
+        return build_beta_detail.nil? == false && build_beta_detail.ready_for_external_testing?
+      end
+
       def ready_for_beta_submission?
         raise "No build_beta_detail included" unless build_beta_detail
         return build_beta_detail.ready_for_beta_submission?

data/spaceship/lib/spaceship/connect_api/models/build_beta_detail.rb

@@ -53,6 +53,10 @@ module Spaceship
         return internal_build_state == InternalState::READY_FOR_BETA_TESTING
       end
 
+      def processed?
+        return internal_build_state != InternalState::PROCESSING && external_build_state != ExternalState::PROCESSING
+      end
+
       def ready_for_beta_submission?
         return external_build_state == ExternalState::READY_FOR_BETA_SUBMISSION
       end

data/supply/lib/supply/uploader.rb

@@ -13,6 +13,8 @@ module Supply
       apk_version_codes.concat(upload_bundles) unless Supply.config[:skip_upload_aab]
       upload_mapping(apk_version_codes)
 
+      track_to_update = Supply.config[:track]
+
       apk_version_codes.concat(Supply.config[:version_codes_to_retain]) if Supply.config[:version_codes_to_retain]
 
       if !apk_version_codes.empty?
@@ -23,13 +25,14 @@ module Supply
       else
         # Only promote or rollout if we don't have version codes
         if Supply.config[:track_promote_to]
+          track_to_update = Supply.config[:track_promote_to]
           promote_track
         elsif !Supply.config[:rollout].nil? && Supply.config[:track].to_s != ""
           update_rollout
         end
       end
 
-      perform_upload_meta(apk_version_codes)
+      perform_upload_meta(apk_version_codes, track_to_update)
 
       if Supply.config[:validate_only]
         UI.message("Validating all changes with Google Play...")
@@ -70,7 +73,7 @@ module Supply
       end
     end
 
-    def perform_upload_meta(version_codes)
+    def perform_upload_meta(version_codes, track_name)
       if (!Supply.config[:skip_upload_metadata] || !Supply.config[:skip_upload_images] || !Supply.config[:skip_upload_changelogs] || !Supply.config[:skip_upload_screenshots]) && metadata_path
         # Use version code from config if version codes is empty and no nil or empty string
         version_codes = [Supply.config[:version_code]] if version_codes.empty?
@@ -81,7 +84,7 @@ module Supply
         version_codes.each do |version_code|
           UI.user_error!("Could not find folder #{metadata_path}") unless File.directory?(metadata_path)
 
-          track, release = fetch_track_and_release!(Supply.config[:track], version_code)
+          track, release = fetch_track_and_release!(track_name, version_code)
           UI.user_error!("Unable to find the requested track - '#{Supply.config[:track]}'") unless track
           UI.user_error!("Could not find release for version code '#{version_code}' to update changelog") unless release
 
@@ -98,7 +101,7 @@ module Supply
             release_notes << upload_changelog(language, version_code) unless Supply.config[:skip_upload_changelogs]
           end
 
-          upload_changelogs(release_notes, release, track) unless release_notes.empty?
+          upload_changelogs(release_notes, release, track, track_name) unless release_notes.empty?
         end
       end
     end
@@ -239,9 +242,9 @@ module Supply
       )
     end
 
-    def upload_changelogs(release_notes, release, track)
+    def upload_changelogs(release_notes, release, track, track_name)
       release.release_notes = release_notes
-      client.upload_changelogs(track, Supply.config[:track])
+      client.upload_changelogs(track, track_name)
     end
 
     def upload_metadata(language, listing)

metadata

@@ -1,38 +1,38 @@
 --- !ruby/object:Gem::Specification
 name: fastlane
 version: !ruby/object:Gem::Version
-  version: 2.192.0
+  version: 2.195.0
 platform: ruby
 authors:
-- Jan Piotrowski
-- Manu Wallner
-- Jérôme Lacoste
-- Helmut Januschka
-- Daniel Jankowski
-- Satoshi Namai
-- Joshua Liebowitz
-- Roger Oba
-- Josh Holtz
-- Matthew Ellis
-- Andrew McBurney
-- Aaron Brager
 - Stefan Natchev
-- Manish Rathi
-- Felix Krause
+- Roger Oba
+- Fumiya Nakamura
+- Jérôme Lacoste
+- Iulian Onofrei
 - Jorge Revuelta H
 - Max Ott
-- Maksym Grebenets
-- Iulian Onofrei
+- Daniel Jankowski
 - Olivier Halligon
-- Jimmy Dee
+- Helmut Januschka
+- Manish Rathi
+- Jan Piotrowski
 - Danielle Tomlinson
-- Kohki Miki
-- Fumiya Nakamura
 - Luka Mirosevic
+- Jimmy Dee
+- Andrew McBurney
+- Joshua Liebowitz
+- Satoshi Namai
+- Felix Krause
+- Kohki Miki
+- Aaron Brager
+- Matthew Ellis
+- Josh Holtz
+- Maksym Grebenets
+- Manu Wallner
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2021-08-24 00:00:00.000000000 Z
+date: 2021-09-25 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: xcodeproj
@@ -1056,7 +1056,6 @@ files:
 - fastlane/lib/fastlane/actions/commit_github_file.rb
 - fastlane/lib/fastlane/actions/commit_version_bump.rb
 - fastlane/lib/fastlane/actions/copy_artifacts.rb
-- fastlane/lib/fastlane/actions/crashlytics.rb
 - fastlane/lib/fastlane/actions/create_app_on_managed_play_store.rb
 - fastlane/lib/fastlane/actions/create_app_online.rb
 - fastlane/lib/fastlane/actions/create_keychain.rb
@@ -1278,7 +1277,6 @@ files:
 - fastlane/lib/fastlane/features.rb
 - fastlane/lib/fastlane/helper/README.md
 - fastlane/lib/fastlane/helper/adb_helper.rb
-- fastlane/lib/fastlane/helper/crashlytics_helper.rb
 - fastlane/lib/fastlane/helper/dotenv_helper.rb
 - fastlane/lib/fastlane/helper/gem_helper.rb
 - fastlane/lib/fastlane/helper/git_helper.rb
@@ -1713,7 +1711,6 @@ files:
 - spaceship/lib/spaceship/connect_api/provisioning/provisioning.rb
 - spaceship/lib/spaceship/connect_api/response.rb
 - spaceship/lib/spaceship/connect_api/spaceship.rb
-- spaceship/lib/spaceship/connect_api/testflight/.testflight.rb.swp
 - spaceship/lib/spaceship/connect_api/testflight/client.rb
 - spaceship/lib/spaceship/connect_api/testflight/testflight.rb
 - spaceship/lib/spaceship/connect_api/token.rb
@@ -1874,7 +1871,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.1.4
+rubygems_version: 3.1.6
 signing_key:
 specification_version: 4
 summary: The easiest way to automate beta deployments and releases for your iOS and

data/fastlane/lib/fastlane/actions/crashlytics.rb

@@ -1,207 +0,0 @@
-module Fastlane
-  module Actions
-    class CrashlyticsAction < Action
-      def self.run(params)
-        params.values # to validate all inputs before looking for the ipa/apk
-        tempfiles = []
-
-        # We need to store notes in a file, because the crashlytics CLI (iOS) says so
-        if params[:notes]
-          UI.error("Overwriting :notes_path, because you specified :notes") if params[:notes_path]
-
-          changelog = Helper::CrashlyticsHelper.write_to_tempfile(params[:notes], 'changelog')
-          tempfiles << changelog
-          params[:notes_path] = changelog.path
-        elsif Actions.lane_context[SharedValues::FL_CHANGELOG] && !params[:notes_path]
-          UI.message("Sending FL_CHANGELOG as release notes to Beta by Crashlytics")
-
-          changelog = Helper::CrashlyticsHelper.write_to_tempfile(
-            Actions.lane_context[SharedValues::FL_CHANGELOG], 'changelog'
-          )
-          tempfiles << changelog
-          params[:notes_path] = changelog.path
-        end
-
-        if params[:ipa_path]
-          command = Helper::CrashlyticsHelper.generate_ios_command(params)
-        elsif params[:apk_path]
-          android_manifest = Helper::CrashlyticsHelper.generate_android_manifest_tempfile
-          tempfiles << android_manifest
-          command = Helper::CrashlyticsHelper.generate_android_command(params, android_manifest.path)
-        else
-          UI.user_error!("You have to either pass an ipa or an apk file to the Crashlytics action")
-        end
-
-        UI.success('Uploading the build to Crashlytics Beta. Time for some ☕️.')
-
-        sanitizer = proc do |message|
-          message.gsub(params[:api_token], '[[API_TOKEN]]')
-                 .gsub(params[:build_secret], '[[BUILD_SECRET]]')
-        end
-
-        UI.verbose(sanitizer.call(command.join(' '))) if FastlaneCore::Globals.verbose?
-
-        error_callback = proc do |error|
-          clean_error = sanitizer.call(error)
-          UI.user_error!(clean_error)
-        end
-
-        result = Actions.sh_control_output(
-          command.join(" "),
-          print_command: false,
-          print_command_output: false,
-          error_callback: error_callback
-        )
-
-        tempfiles.each(&:unlink)
-        return command if Helper.test?
-
-        UI.verbose(sanitizer.call(result)) if FastlaneCore::Globals.verbose?
-
-        UI.success('Build successfully uploaded to Crashlytics Beta 🌷')
-        UI.success('Visit https://fabric.io/_/beta to add release notes and notify testers.')
-      end
-
-      def self.description
-        "Refer to [Firebase App Distribution](https://appdistro.page.link/fastlane-repo)"
-      end
-
-      def self.available_options
-        platform = Actions.lane_context[Actions::SharedValues::PLATFORM_NAME]
-
-        if platform == :ios || platform.nil?
-          ipa_path_default = Dir["*.ipa"].sort_by { |x| File.mtime(x) }.last
-        end
-
-        if platform == :android
-          apk_path_default = Dir["*.apk"].last || Dir[File.join("app", "build", "outputs", "apk", "app-release.apk")].last
-        end
-
-        [
-          # iOS Specific
-          FastlaneCore::ConfigItem.new(key: :ipa_path,
-                                       env_name: "CRASHLYTICS_IPA_PATH",
-                                       description: "Path to your IPA file. Optional if you use the _gym_ or _xcodebuild_ action",
-                                       default_value: Actions.lane_context[SharedValues::IPA_OUTPUT_PATH] || ipa_path_default,
-                                       default_value_dynamic: true,
-                                       optional: true,
-                                       verify_block: proc do |value|
-                                         UI.user_error!("Couldn't find ipa file at path '#{value}'") unless File.exist?(value)
-                                       end),
-          # Android Specific
-          FastlaneCore::ConfigItem.new(key: :apk_path,
-                                       env_name: "CRASHLYTICS_APK_PATH",
-                                       description: "Path to your APK file",
-                                       default_value: Actions.lane_context[SharedValues::GRADLE_APK_OUTPUT_PATH] || apk_path_default,
-                                       default_value_dynamic: true,
-                                       optional: true,
-                                       verify_block: proc do |value|
-                                         UI.user_error!("Couldn't find apk file at path '#{value}'") unless File.exist?(value)
-                                       end),
-          # General
-          FastlaneCore::ConfigItem.new(key: :crashlytics_path,
-                                       env_name: "CRASHLYTICS_FRAMEWORK_PATH",
-                                       description: "Path to the submit binary in the Crashlytics bundle (iOS) or `crashlytics-devtools.jar` file (Android)",
-                                       optional: true,
-                                       verify_block: proc do |value|
-                                         UI.user_error!("Couldn't find crashlytics at path '#{File.expand_path(value)}'`") unless File.exist?(File.expand_path(value))
-                                       end),
-          FastlaneCore::ConfigItem.new(key: :api_token,
-                                       env_name: "CRASHLYTICS_API_TOKEN",
-                                       description: "Crashlytics API Key",
-                                       sensitive: true,
-                                       verify_block: proc do |value|
-                                         UI.user_error!("No API token for Crashlytics given, pass using `api_token: 'token'`") unless value && !value.empty?
-                                       end),
-          FastlaneCore::ConfigItem.new(key: :build_secret,
-                                       env_name: "CRASHLYTICS_BUILD_SECRET",
-                                       description: "Crashlytics Build Secret",
-                                       sensitive: true,
-                                       verify_block: proc do |value|
-                                         UI.user_error!("No build secret for Crashlytics given, pass using `build_secret: 'secret'`") unless value && !value.empty?
-                                       end),
-          FastlaneCore::ConfigItem.new(key: :notes_path,
-                                       env_name: "CRASHLYTICS_NOTES_PATH",
-                                       description: "Path to the release notes",
-                                       optional: true,
-                                       verify_block: proc do |value|
-                                         UI.user_error!("Path '#{value}' not found") unless File.exist?(value)
-                                       end),
-          FastlaneCore::ConfigItem.new(key: :notes,
-                                       env_name: "CRASHLYTICS_NOTES",
-                                       description: "The release notes as string - uses :notes_path under the hood",
-                                       optional: true),
-          FastlaneCore::ConfigItem.new(key: :groups,
-                                       env_name: "CRASHLYTICS_GROUPS",
-                                       description: "The groups used for distribution, separated by commas",
-                                       type: Array,
-                                       optional: true),
-          FastlaneCore::ConfigItem.new(key: :emails,
-                                       env_name: "CRASHLYTICS_EMAILS",
-                                       description: "Pass email addresses of testers, separated by commas",
-                                       type: Array,
-                                       optional: true),
-          FastlaneCore::ConfigItem.new(key: :notifications,
-                                       env_name: "CRASHLYTICS_NOTIFICATIONS",
-                                       description: "Crashlytics notification option (true/false)",
-                                       default_value: true,
-                                       type: Boolean),
-          FastlaneCore::ConfigItem.new(key: :debug,
-                                       env_name: "CRASHLYTICS_DEBUG",
-                                       description: "Crashlytics debug option (true/false)",
-                                       default_value: false,
-                                       type: Boolean)
-
-        ]
-      end
-
-      def self.is_supported?(platform)
-        [:ios, :mac, :android].include?(platform)
-      end
-
-      def self.author
-        ["KrauseFx", "pedrogimenez"]
-      end
-
-      def self.details
-        [
-          "Additionally, you can specify `notes`, `emails`, `groups` and `notifications`.",
-          "Distributing to Groups: When using the `groups` parameter, it's important to use the group **alias** names for each group you'd like to distribute to. A group's alias can be found in the web UI. If you're viewing the Beta page, you can open the groups dialog by clicking the 'Manage Groups' button.",
-          "This action uses the `submit` binary provided by the Crashlytics framework. If the binary is not found in its usual path, you'll need to specify the path manually by using the `crashlytics_path` option."
-        ].join("\n")
-      end
-
-      def self.example_code
-        [
-          'crashlytics',
-          '# If you installed Crashlytics via CocoaPods
-          crashlytics(
-            crashlytics_path: "./Pods/Crashlytics/submit", # path to your Crashlytics submit binary.
-            api_token: "...",
-            build_secret: "...",
-            ipa_path: "./app.ipa"
-          )',
-          '# If you installed Crashlytics via Carthage for iOS platform
-          crashlytics(
-            crashlytics_path: "./Carthage/Build/iOS/Crashlytics.framework/submit", # path to your Crashlytics submit binary.
-            api_token: "...",
-            build_secret: "...",
-            ipa_path: "./app.ipa"
-          )'
-        ]
-      end
-
-      def self.category
-        :deprecated
-      end
-
-      def self.deprecated_notes
-        [
-          "Crashlytics Beta has been deprecated and replaced with Firebase App Distribution.",
-          "Beta will continue working until May 4, 2020.",
-          "Check out the [Firebase App Distribution docs](https://github.com/fastlane/fastlane-plugin-firebase_app_distribution) to get started."
-        ].join("\n")
-      end
-    end
-  end
-end

data/fastlane/lib/fastlane/helper/crashlytics_helper.rb

@@ -1,157 +0,0 @@
-require 'shellwords'
-
-module Fastlane
-  module Helper
-    class CrashlyticsHelper
-      class << self
-        def discover_crashlytics_path(params)
-          path = params[:crashlytics_path]
-
-          # Finding submit binary inside of given Crashlytics path (for backwards compatibility)
-          if path
-            if File.basename(path) != "submit"
-              path = Dir[File.join(path, '**', 'submit')].last
-              UI.verbose(":crashlytics_path passed through parameters did not point to a submit binary. Using this submit binary on that path instead: '#{path}'")
-            else
-              UI.verbose("Using :crashlytics_path passed in through parameters: '#{path}'")
-            end
-          end
-
-          # Check for submit binary outside of Crashlytics.framework (for Crashlytics 3.4.1 and over)
-          path ||= Dir["./Pods/Crashlytics/submit"].first
-
-          # Check for submit binary in Crashlytics.framework (for Crashlytics 3.4.1 and under)
-          path ||= Dir["./Pods/iOS/Crashlytics/Crashlytics.framework/submit"].last
-          path ||= Dir["./**/Crashlytics.framework/submit"].last
-
-          downcase_path = path ? path.downcase : nil
-          if downcase_path && downcase_path.include?("pods") && downcase_path.include?("crashlytics.framework")
-            UI.deprecated("Crashlytics has moved the submit binary outside of Crashlytics.framework directory as of 3.4.1. Please change :crashlytics_path to `<PODS_ROOT>/Crashlytics/submit`")
-          end
-
-          return path
-        end
-
-        def generate_ios_command(params)
-          submit_binary = discover_crashlytics_path(params)
-          unless submit_binary
-            UI.user_error!("Couldn't find Crashlytics' submit binary in current directory. Make sure to add the 'Crashlytics' pod to your 'Podfile' and run `pod update`")
-          end
-          if File.basename(submit_binary) != "submit"
-            UI.user_error!("Invalid crashlytics path was detected with '#{submit_binary}'. Path must point to the `submit` binary (example: './Pods/Crashlytics/submit')")
-          end
-          submit_binary = "Crashlytics.framework/submit" if Helper.test?
-
-          command = []
-          command << submit_binary.shellescape
-          command << params[:api_token]
-          command << params[:build_secret]
-          command << "-ipaPath '#{params[:ipa_path]}'"
-          command << "-emails '#{params[:emails].join(',')}'" if params[:emails]
-          command << "-notesPath '#{params[:notes_path]}'" if params[:notes_path]
-          command << "-groupAliases '#{params[:groups].join(',')}'" if params[:groups]
-          command << "-notifications #{(params[:notifications] ? 'YES' : 'NO')}"
-          command << "-debug #{(params[:debug] ? 'YES' : 'NO')}"
-
-          return command
-        end
-
-        def generate_android_command(params, android_manifest_path)
-          params[:crashlytics_path] = download_android_tools unless params[:crashlytics_path]
-
-          UI.user_error!("The `crashlytics_path` must be a jar file for Android") unless params[:crashlytics_path].end_with?(".jar") || Helper.test?
-
-          if ENV['JAVA_HOME'].nil?
-            command = ["java"]
-          else
-            command = [File.join(ENV['JAVA_HOME'], "/bin/java").shellescape]
-          end
-          command << "-jar #{File.expand_path(params[:crashlytics_path])}"
-          command << "-androidRes ."
-          command << "-apiKey #{params[:api_token]}"
-          command << "-apiSecret #{params[:build_secret]}"
-          command << "-uploadDist #{File.expand_path(params[:apk_path]).shellescape}"
-          command << "-androidManifest #{File.expand_path(android_manifest_path).shellescape}"
-
-          # Optional
-          command << "-betaDistributionEmails #{params[:emails].join(',').shellescape}" if params[:emails]
-          command << "-betaDistributionReleaseNotesFilePath #{File.expand_path(params[:notes_path]).shellescape}" if params[:notes_path]
-          command << "-betaDistributionGroupAliases #{params[:groups].join(',').shellescape}" if params[:groups]
-          command << "-betaDistributionNotifications #{(params[:notifications] ? 'true' : 'false')}"
-
-          return command
-        end
-
-        def download_android_tools
-          containing = File.join(File.expand_path("~/Library"), "CrashlyticsAndroid")
-          zip_path = File.join(containing, "crashlytics-devtools.zip")
-          jar_path = File.join(containing, "crashlytics-devtools.jar")
-
-          url = "https://ssl-download-crashlytics-com.s3.amazonaws.com/android/ant/crashlytics.zip"
-          require 'net/http'
-
-          FileUtils.mkdir_p(containing)
-
-          begin
-            # Work around ruby defect, where HTTP#get_response and HTTP#post_form don't use ENV proxy settings
-            # https://bugs.ruby-lang.org/issues/12724
-            uri = URI(url)
-            http_conn = Net::HTTP.new(uri.host, uri.port)
-            http_conn.use_ssl = true
-            result = http_conn.request_head(uri.path)
-
-            # ETag is returned with quotes, which net/http does not handle. Clean that up
-            etag = result['ETag'] && result['ETag'].tr('"', '')
-
-            # This is a no-op if the current version on disk matches the file on S3
-            return jar_path if File.exist?(zip_path) && etag == Digest::MD5.file(zip_path).hexdigest
-
-            UI.important("Downloading Crashlytics Support Library - this might take a minute...")
-            result = http_conn.request_get(uri.path)
-            UI.error("#{result.message} (#{result.code})") unless result.kind_of?(Net::HTTPSuccess)
-            File.write(zip_path, result.body)
-
-            # Now unzip the file
-            Action.sh("unzip -o '#{zip_path}' -d '#{containing}'")
-
-            UI.user_error!("Couldn't find 'crashlytics-devtools.jar'") unless File.exist?(jar_path)
-
-            UI.success("Successfully downloaded Crashlytics Support Library to '#{jar_path}'")
-          rescue => ex
-            UI.user_error!("Error fetching remote file: #{ex}")
-          end
-
-          return jar_path
-        end
-
-        def generate_android_manifest_tempfile
-          # We have to generate an empty XML file to make the crashlytics CLI happy :)
-          write_to_tempfile('<?xml version="1.0" encoding="utf-8"?><manifest></manifest>', 'xml')
-        end
-
-        def write_to_tempfile(value, tempfilename)
-          require 'tempfile'
-
-          Tempfile.new(tempfilename).tap do |t|
-            t.write(value)
-            t.close
-          end
-        end
-      end
-    end
-  end
-end
-
-# java \
-# -jar ~/Desktop/crashlytics-devtools.jar \
-# -androidRes . \
-# -uploadDist /Users/fkrause/AndroidStudioProjects/AppName/app/build/outputs/apk/app-release.apk \
-# -androidManifest /Users/fkrause/Downloads/manifest.xml \
-# -apiKey api_key \
-# -apiSecret secret_key \
-
-# -betaDistributionReleaseNotes "Yeah" \
-# -betaDistributionEmails "something11@krausefx.com" \
-# -betaDistributionGroupAliases "testgroup" \
-# -betaDistributionNotifications false
-# -projectPath . \