fastlane 2.191.0 → 2.194.0

data/precheck/lib/precheck/options.rb

@@ -35,7 +35,7 @@ module Precheck
                                      end),
         FastlaneCore::ConfigItem.new(key: :api_key,
                                      env_names: ["PRECHECK_API_KEY", "APP_STORE_CONNECT_API_KEY"],
-                                     description: "Your App Store Connect API Key information (https://docs.fastlane.tools/app-store-connect-api/#use-return-value-and-pass-in-as-an-option)",
+                                     description: "Your App Store Connect API Key information (https://docs.fastlane.tools/app-store-connect-api/#using-fastlane-api-key-hash-option)",
                                      type: Hash,
                                      optional: true,
                                      sensitive: true,

data/produce/lib/produce/service.rb

@@ -97,7 +97,7 @@ module Produce
         bundle_id.update_capability(ACCESS_WIFI_INFORMATION, enabled: on)
       end
 
-      if options.access_wifi
+      if options.app_attest
         UI.message("\tApp Attest")
         bundle_id.update_capability(APP_ATTEST, enabled: on)
       end

data/sigh/lib/assets/resign.sh

@@ -644,7 +644,7 @@ function resign {
         # Get the old and new app identifier (prefix)
         APP_ID_KEY="application-identifier"
         # Extract just the identifier from the value
-        # Use the fact that we are after some identifer, which is always at the start of the string
+        # Use the fact that we are after some identifier, which is always at the start of the string
         OLD_APP_ID=$(PlistBuddy -c "Print $APP_ID_KEY" "$APP_ENTITLEMENTS" | grep -E '^[A-Z0-9]*' -o | tr -d '\n')
         NEW_APP_ID=$(PlistBuddy -c "Print $APP_ID_KEY" "$PROFILE_ENTITLEMENTS" | grep -E '^[A-Z0-9]*' -o | tr -d '\n')
 

data/sigh/lib/sigh/options.rb

@@ -66,7 +66,7 @@ module Sigh
                                      end),
         FastlaneCore::ConfigItem.new(key: :api_key,
                                      env_names: ["SIGH_API_KEY", "APP_STORE_CONNECT_API_KEY"],
-                                     description: "Your App Store Connect API Key information (https://docs.fastlane.tools/app-store-connect-api/#use-return-value-and-pass-in-as-an-option)",
+                                     description: "Your App Store Connect API Key information (https://docs.fastlane.tools/app-store-connect-api/#using-fastlane-api-key-hash-option)",
                                      type: Hash,
                                      optional: true,
                                      sensitive: true,

data/snapshot/lib/snapshot/simulator_launchers/simulator_launcher_base.rb

@@ -116,7 +116,8 @@ module Snapshot
       device_udid = TestCommandGenerator.device_udid(device_type)
 
       UI.message("Launch Simulator #{device_type}")
-      Helper.backticks("xcrun instruments -w #{device_udid} &> /dev/null")
+      # Boot the simulator and wait for it to finish booting
+      Helper.backticks("xcrun simctl bootstatus #{device_udid} -b &> /dev/null")
 
       UI.message("Overriding Status Bar")
 

data/spaceship/lib/spaceship/connect_api/api_client.rb

@@ -208,7 +208,13 @@ module Spaceship
       # Overridden from Spaceship::Client
       def handle_error(response)
         body = response.body.empty? ? {} : response.body
-        body = JSON.parse(body) if body.kind_of?(String)
+
+        # Setting body nil if invalid JSON which can happen if 502
+        begin
+          body = JSON.parse(body) if body.kind_of?(String)
+        rescue
+          nil
+        end
 
         case response.status.to_i
         when 401
@@ -221,6 +227,14 @@ module Spaceship
           else
             raise AccessForbiddenError, format_errors(response)
           end
+        when 502
+          # Issue - https://github.com/fastlane/fastlane/issues/19264
+          # This 502 with "Could not process this request" body sometimes
+          # work and sometimes doesn't
+          # Usually retrying once or twice will solve the issue
+          if body && body.include?("Could not process this request")
+            raise BadGatewayError, "Could not process this request"
+          end
         end
       end
 

data/spaceship/lib/spaceship/connect_api/models/app.rb

@@ -385,11 +385,12 @@ module Spaceship
         return resps.flat_map(&:to_models)
       end
 
-      def create_beta_group(client: nil, group_name: nil, public_link_enabled: false, public_link_limit: 10_000, public_link_limit_enabled: false)
+      def create_beta_group(client: nil, group_name: nil, is_internal_group: false, public_link_enabled: false, public_link_limit: 10_000, public_link_limit_enabled: false)
         client ||= Spaceship::ConnectAPI
         resps = client.create_beta_group(
           app_id: id,
           group_name: group_name,
+          is_internal_group: is_internal_group,
           public_link_enabled: public_link_enabled,
           public_link_limit: public_link_limit,
           public_link_limit_enabled: public_link_limit_enabled

data/spaceship/lib/spaceship/connect_api/models/app_store_version.rb

@@ -112,7 +112,7 @@ module Spaceship
 
       # @deprecated
       def fetch_age_rating_declaration(client: nil)
-        raise 'AppStoreVersion no longer as AgeRatingDelcaration as of App Store Connect API 1.3 - Use AppInfo instead'
+        raise 'AppStoreVersion no longer as AgeRatingDeclaration as of App Store Connect API 1.3 - Use AppInfo instead'
       end
 
       #

data/spaceship/lib/spaceship/connect_api/models/build.rb

@@ -86,6 +86,10 @@ module Spaceship
         return build_beta_detail.nil? == false && build_beta_detail.ready_for_internal_testing?
       end
 
+      def ready_for_external_testing?
+        return build_beta_detail.nil? == false && build_beta_detail.ready_for_external_testing?
+      end
+
       def ready_for_beta_submission?
         raise "No build_beta_detail included" unless build_beta_detail
         return build_beta_detail.ready_for_beta_submission?

data/spaceship/lib/spaceship/connect_api/models/build_beta_detail.rb

@@ -53,6 +53,10 @@ module Spaceship
         return internal_build_state == InternalState::READY_FOR_BETA_TESTING
       end
 
+      def processed?
+        return internal_build_state != InternalState::PROCESSING && external_build_state != ExternalState::PROCESSING
+      end
+
       def ready_for_beta_submission?
         return external_build_state == ExternalState::READY_FOR_BETA_SUBMISSION
       end

data/spaceship/lib/spaceship/connect_api/testflight/testflight.rb

@@ -204,11 +204,13 @@ module Spaceship
           test_flight_request_client.delete("builds/#{build_id}/relationships/betaGroups", nil, body)
         end
 
-        def create_beta_group(app_id: nil, group_name: nil, public_link_enabled: false, public_link_limit: 10_000, public_link_limit_enabled: false)
+        def create_beta_group(app_id: nil, group_name: nil, is_internal_group: false, public_link_enabled: false, public_link_limit: 10_000, public_link_limit_enabled: false)
           body = {
             data: {
               attributes: {
                 name: group_name,
+                isInternalGroup: is_internal_group,
+                hasAccessToAllBuilds: is_internal_group ? true : false, # Undocumented of 2021-08-02 in ASC API docs and ASC Open API spec. This is the default behavior on App Store Connect and does work with both Apple ID and API Token
                 publicLinkEnabled: public_link_enabled,
                 publicLinkLimit: public_link_limit,
                 publicLinkLimitEnabled: public_link_limit_enabled
@@ -218,11 +220,11 @@ module Spaceship
                   data: {
                     id: app_id,
                     type: "apps"
-                  }
-                }
+                  },
+                },
               },
-              type: "betaGroups"
-            }
+              type: "betaGroups",
+            },
           }
           test_flight_request_client.post("betaGroups", body)
         end

data/spaceship/lib/spaceship/connect_api/token.rb

@@ -21,6 +21,8 @@ module Spaceship
       attr_reader :duration
       attr_reader :expiration
 
+      attr_reader :key_raw
+
       # Temporary attribute not needed to create the JWT text
       # There is no way to determine if the team associated with this
       # key is for App Store or Enterprise so this is the temporary workaround

data/supply/lib/supply/client.rb

@@ -163,11 +163,44 @@ module Supply
       ensure_active_edit!
 
       call_google_api do
-        client.commit_edit(
-          current_package_name,
-          current_edit.id,
-          changes_not_sent_for_review: Supply.config[:changes_not_sent_for_review]
-        )
+        begin
+          client.commit_edit(
+            current_package_name,
+            current_edit.id,
+            changes_not_sent_for_review: Supply.config[:changes_not_sent_for_review]
+          )
+        rescue Google::Apis::ClientError => e
+          unless Supply.config[:rescue_changes_not_sent_for_review]
+            raise
+          end
+
+          error = begin
+                    JSON.parse(e.body)
+                  rescue
+                    nil
+                  end
+
+          if error
+            message = error["error"] && error["error"]["message"]
+          else
+            message = e.body
+          end
+
+          if message.include?("The query parameter changesNotSentForReview must not be set")
+            client.commit_edit(
+              current_package_name,
+              current_edit.id
+            )
+          elsif message.include?("Please set the query parameter changesNotSentForReview to true")
+            client.commit_edit(
+              current_package_name,
+              current_edit.id,
+              changes_not_sent_for_review: true
+            )
+          else
+            raise
+          end
+        end
       end
 
       self.current_edit = nil

data/supply/lib/supply/options.rb

@@ -1,3 +1,5 @@
+# rubocop:disable Metrics/ClassLength
+
 require 'fastlane_core/configuration/config_item'
 require 'credentials_manager/appfile_config'
 
@@ -286,6 +288,11 @@ module Supply
                                      description: "Indicates that the changes in this edit will not be reviewed until they are explicitly sent for review from the Google Play Console UI",
                                      type: Boolean,
                                      default_value: false),
+        FastlaneCore::ConfigItem.new(key: :rescue_changes_not_sent_for_review,
+                                     env_name: "SUPPLY_RESCUE_CHANGES_NOT_SENT_FOR_REVIEW",
+                                     description: "Catches changes_not_sent_for_review errors when an edit is committed and retries with the configuration that the error message recommended",
+                                     type: Boolean,
+                                     default_value: true),
         FastlaneCore::ConfigItem.new(key: :in_app_update_priority,
                                      env_name: "SUPPLY_IN_APP_UPDATE_PRIORITY",
                                      optional: true,

data/supply/lib/supply/uploader.rb

@@ -13,6 +13,8 @@ module Supply
       apk_version_codes.concat(upload_bundles) unless Supply.config[:skip_upload_aab]
       upload_mapping(apk_version_codes)
 
+      track_to_update = Supply.config[:track]
+
       apk_version_codes.concat(Supply.config[:version_codes_to_retain]) if Supply.config[:version_codes_to_retain]
 
       if !apk_version_codes.empty?
@@ -23,13 +25,14 @@ module Supply
       else
         # Only promote or rollout if we don't have version codes
         if Supply.config[:track_promote_to]
+          track_to_update = Supply.config[:track_promote_to]
           promote_track
         elsif !Supply.config[:rollout].nil? && Supply.config[:track].to_s != ""
           update_rollout
         end
       end
 
-      perform_upload_meta(apk_version_codes)
+      perform_upload_meta(apk_version_codes, track_to_update)
 
       if Supply.config[:validate_only]
         UI.message("Validating all changes with Google Play...")
@@ -70,7 +73,7 @@ module Supply
       end
     end
 
-    def perform_upload_meta(version_codes)
+    def perform_upload_meta(version_codes, track_name)
       if (!Supply.config[:skip_upload_metadata] || !Supply.config[:skip_upload_images] || !Supply.config[:skip_upload_changelogs] || !Supply.config[:skip_upload_screenshots]) && metadata_path
         # Use version code from config if version codes is empty and no nil or empty string
         version_codes = [Supply.config[:version_code]] if version_codes.empty?
@@ -81,7 +84,7 @@ module Supply
         version_codes.each do |version_code|
           UI.user_error!("Could not find folder #{metadata_path}") unless File.directory?(metadata_path)
 
-          track, release = fetch_track_and_release!(Supply.config[:track], version_code)
+          track, release = fetch_track_and_release!(track_name, version_code)
           UI.user_error!("Unable to find the requested track - '#{Supply.config[:track]}'") unless track
           UI.user_error!("Could not find release for version code '#{version_code}' to update changelog") unless release
 
@@ -98,7 +101,7 @@ module Supply
             release_notes << upload_changelog(language, version_code) unless Supply.config[:skip_upload_changelogs]
           end
 
-          upload_changelogs(release_notes, release, track) unless release_notes.empty?
+          upload_changelogs(release_notes, release, track, track_name) unless release_notes.empty?
         end
       end
     end
@@ -239,9 +242,9 @@ module Supply
       )
     end
 
-    def upload_changelogs(release_notes, release, track)
+    def upload_changelogs(release_notes, release, track, track_name)
       release.release_notes = release_notes
-      client.upload_changelogs(track, Supply.config[:track])
+      client.upload_changelogs(track, track_name)
     end
 
     def upload_metadata(language, listing)

metadata

@@ -1,38 +1,38 @@
 --- !ruby/object:Gem::Specification
 name: fastlane
 version: !ruby/object:Gem::Version
-  version: 2.191.0
+  version: 2.194.0
 platform: ruby
 authors:
-- Andrew McBurney
-- Fumiya Nakamura
-- Manu Wallner
-- Jimmy Dee
-- Satoshi Namai
 - Josh Holtz
-- Felix Krause
-- Jérôme Lacoste
-- Manish Rathi
-- Kohki Miki
-- Iulian Onofrei
-- Matthew Ellis
-- Aaron Brager
 - Danielle Tomlinson
+- Jorge Revuelta H
+- Aaron Brager
+- Kohki Miki
+- Joshua Liebowitz
+- Olivier Halligon
+- Fumiya Nakamura
+- Satoshi Namai
 - Max Ott
+- Helmut Januschka
 - Roger Oba
-- Olivier Halligon
+- Felix Krause
 - Maksym Grebenets
-- Jan Piotrowski
-- Jorge Revuelta H
+- Jérôme Lacoste
+- Jimmy Dee
 - Luka Mirosevic
-- Daniel Jankowski
+- Manish Rathi
+- Manu Wallner
+- Andrew McBurney
 - Stefan Natchev
-- Helmut Januschka
-- Joshua Liebowitz
+- Daniel Jankowski
+- Jan Piotrowski
+- Matthew Ellis
+- Iulian Onofrei
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2021-08-06 00:00:00.000000000 Z
+date: 2021-09-15 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: xcodeproj
@@ -196,6 +196,20 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: 1.0.0
+- !ruby/object:Gem::Dependency
+  name: optparse
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 0.1.1
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 0.1.1
 - !ruby/object:Gem::Dependency
   name: tty-screen
   requirement: !ruby/object:Gem::Requirement
@@ -999,6 +1013,7 @@ files:
 - fastlane/lib/fastlane.rb
 - fastlane/lib/fastlane/action.rb
 - fastlane/lib/fastlane/action_collector.rb
+- fastlane/lib/fastlane/actions/.notarize.rb.swp
 - fastlane/lib/fastlane/actions/README.md
 - fastlane/lib/fastlane/actions/actions_helper.rb
 - fastlane/lib/fastlane/actions/adb.rb