fastlane 2.191.0 → 2.192.0

data/pilot/lib/pilot/build_manager.rb

@@ -558,7 +558,6 @@ module Pilot
       attributes[:autoNotifyEnabled] = info[:auto_notify_enabled] if info.key?(:auto_notify_enabled)
       build_beta_detail = build.build_beta_detail
 
-      # https://github.com/fastlane/fastlane/pull/16006
       if build_beta_detail
         Spaceship::ConnectAPI.patch_build_beta_details(build_beta_details_id: build_beta_detail.id, attributes: attributes)
       else

data/produce/lib/produce/service.rb

@@ -97,7 +97,7 @@ module Produce
         bundle_id.update_capability(ACCESS_WIFI_INFORMATION, enabled: on)
       end
 
-      if options.access_wifi
+      if options.app_attest
         UI.message("\tApp Attest")
         bundle_id.update_capability(APP_ATTEST, enabled: on)
       end

data/spaceship/lib/spaceship/connect_api/api_client.rb

@@ -208,7 +208,13 @@ module Spaceship
       # Overridden from Spaceship::Client
       def handle_error(response)
         body = response.body.empty? ? {} : response.body
-        body = JSON.parse(body) if body.kind_of?(String)
+
+        # Setting body nil if invalid JSON which can happen if 502
+        begin
+          body = JSON.parse(body) if body.kind_of?(String)
+        rescue
+          nil
+        end
 
         case response.status.to_i
         when 401
@@ -221,6 +227,14 @@ module Spaceship
           else
             raise AccessForbiddenError, format_errors(response)
           end
+        when 502
+          # Issue - https://github.com/fastlane/fastlane/issues/19264
+          # This 502 with "Could not process this request" body sometimes
+          # work and sometimes doesn't
+          # Usually retrying once or twice will solve the issue
+          if body && body.include?("Could not process this request")
+            raise BadGatewayError, "Could not process this request"
+          end
         end
       end
 

data/spaceship/lib/spaceship/connect_api/models/app.rb

@@ -385,11 +385,12 @@ module Spaceship
         return resps.flat_map(&:to_models)
       end
 
-      def create_beta_group(client: nil, group_name: nil, public_link_enabled: false, public_link_limit: 10_000, public_link_limit_enabled: false)
+      def create_beta_group(client: nil, group_name: nil, is_internal_group: false, public_link_enabled: false, public_link_limit: 10_000, public_link_limit_enabled: false)
         client ||= Spaceship::ConnectAPI
         resps = client.create_beta_group(
           app_id: id,
           group_name: group_name,
+          is_internal_group: is_internal_group,
           public_link_enabled: public_link_enabled,
           public_link_limit: public_link_limit,
           public_link_limit_enabled: public_link_limit_enabled

data/spaceship/lib/spaceship/connect_api/testflight/testflight.rb

@@ -204,11 +204,13 @@ module Spaceship
           test_flight_request_client.delete("builds/#{build_id}/relationships/betaGroups", nil, body)
         end
 
-        def create_beta_group(app_id: nil, group_name: nil, public_link_enabled: false, public_link_limit: 10_000, public_link_limit_enabled: false)
+        def create_beta_group(app_id: nil, group_name: nil, is_internal_group: false, public_link_enabled: false, public_link_limit: 10_000, public_link_limit_enabled: false)
           body = {
             data: {
               attributes: {
                 name: group_name,
+                isInternalGroup: is_internal_group,
+                hasAccessToAllBuilds: is_internal_group ? true : false, # Undocumented of 2021-08-02 in ASC API docs and ASC Open API spec. This is the default behavior on App Store Connect and does work with both Apple ID and API Token
                 publicLinkEnabled: public_link_enabled,
                 publicLinkLimit: public_link_limit,
                 publicLinkLimitEnabled: public_link_limit_enabled
@@ -218,11 +220,11 @@ module Spaceship
                   data: {
                     id: app_id,
                     type: "apps"
-                  }
-                }
+                  },
+                },
               },
-              type: "betaGroups"
-            }
+              type: "betaGroups",
+            },
           }
           test_flight_request_client.post("betaGroups", body)
         end

data/spaceship/lib/spaceship/connect_api/token.rb

@@ -21,6 +21,8 @@ module Spaceship
       attr_reader :duration
       attr_reader :expiration
 
+      attr_reader :key_raw
+
       # Temporary attribute not needed to create the JWT text
       # There is no way to determine if the team associated with this
       # key is for App Store or Enterprise so this is the temporary workaround

data/supply/lib/supply/client.rb

@@ -163,11 +163,44 @@ module Supply
       ensure_active_edit!
 
       call_google_api do
-        client.commit_edit(
-          current_package_name,
-          current_edit.id,
-          changes_not_sent_for_review: Supply.config[:changes_not_sent_for_review]
-        )
+        begin
+          client.commit_edit(
+            current_package_name,
+            current_edit.id,
+            changes_not_sent_for_review: Supply.config[:changes_not_sent_for_review]
+          )
+        rescue Google::Apis::ClientError => e
+          unless Supply.config[:rescue_changes_not_sent_for_review]
+            raise
+          end
+
+          error = begin
+                    JSON.parse(e.body)
+                  rescue
+                    nil
+                  end
+
+          if error
+            message = error["error"] && error["error"]["message"]
+          else
+            message = e.body
+          end
+
+          if message.include?("The query parameter changesNotSentForReview must not be set")
+            client.commit_edit(
+              current_package_name,
+              current_edit.id
+            )
+          elsif message.include?("Please set the query parameter changesNotSentForReview to true")
+            client.commit_edit(
+              current_package_name,
+              current_edit.id,
+              changes_not_sent_for_review: true
+            )
+          else
+            raise
+          end
+        end
       end
 
       self.current_edit = nil

data/supply/lib/supply/options.rb

@@ -1,3 +1,5 @@
+# rubocop:disable Metrics/ClassLength
+
 require 'fastlane_core/configuration/config_item'
 require 'credentials_manager/appfile_config'
 
@@ -286,6 +288,11 @@ module Supply
                                      description: "Indicates that the changes in this edit will not be reviewed until they are explicitly sent for review from the Google Play Console UI",
                                      type: Boolean,
                                      default_value: false),
+        FastlaneCore::ConfigItem.new(key: :rescue_changes_not_sent_for_review,
+                                     env_name: "SUPPLY_RESCUE_CHANGES_NOT_SENT_FOR_REVIEW",
+                                     description: "Catches changes_not_sent_for_review errors when an edit is committed and retries with the configuration that the error message recommended",
+                                     type: Boolean,
+                                     default_value: true),
         FastlaneCore::ConfigItem.new(key: :in_app_update_priority,
                                      env_name: "SUPPLY_IN_APP_UPDATE_PRIORITY",
                                      optional: true,

metadata

@@ -1,38 +1,38 @@
 --- !ruby/object:Gem::Specification
 name: fastlane
 version: !ruby/object:Gem::Version
-  version: 2.191.0
+  version: 2.192.0
 platform: ruby
 authors:
-- Andrew McBurney
-- Fumiya Nakamura
+- Jan Piotrowski
 - Manu Wallner
-- Jimmy Dee
+- Jérôme Lacoste
+- Helmut Januschka
+- Daniel Jankowski
 - Satoshi Namai
+- Joshua Liebowitz
+- Roger Oba
 - Josh Holtz
-- Felix Krause
-- Jérôme Lacoste
-- Manish Rathi
-- Kohki Miki
-- Iulian Onofrei
 - Matthew Ellis
+- Andrew McBurney
 - Aaron Brager
-- Danielle Tomlinson
+- Stefan Natchev
+- Manish Rathi
+- Felix Krause
+- Jorge Revuelta H
 - Max Ott
-- Roger Oba
-- Olivier Halligon
 - Maksym Grebenets
-- Jan Piotrowski
-- Jorge Revuelta H
+- Iulian Onofrei
+- Olivier Halligon
+- Jimmy Dee
+- Danielle Tomlinson
+- Kohki Miki
+- Fumiya Nakamura
 - Luka Mirosevic
-- Daniel Jankowski
-- Stefan Natchev
-- Helmut Januschka
-- Joshua Liebowitz
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2021-08-06 00:00:00.000000000 Z
+date: 2021-08-24 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: xcodeproj
@@ -196,6 +196,20 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: 1.0.0
+- !ruby/object:Gem::Dependency
+  name: optparse
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 0.1.1
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 0.1.1
 - !ruby/object:Gem::Dependency
   name: tty-screen
   requirement: !ruby/object:Gem::Requirement
@@ -1699,6 +1713,7 @@ files:
 - spaceship/lib/spaceship/connect_api/provisioning/provisioning.rb
 - spaceship/lib/spaceship/connect_api/response.rb
 - spaceship/lib/spaceship/connect_api/spaceship.rb
+- spaceship/lib/spaceship/connect_api/testflight/.testflight.rb.swp
 - spaceship/lib/spaceship/connect_api/testflight/client.rb
 - spaceship/lib/spaceship/connect_api/testflight/testflight.rb
 - spaceship/lib/spaceship/connect_api/token.rb
@@ -1859,7 +1874,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.1.6
+rubygems_version: 3.1.4
 signing_key:
 specification_version: 4
 summary: The easiest way to automate beta deployments and releases for your iOS and