fastlane 2.189.0 → 2.193.0

data/produce/lib/produce/service.rb

@@ -16,6 +16,10 @@ module Produce
       self.new.disable(options, args)
     end
 
+    def self.available_services(options, args)
+      self.new.available_services(options, args)
+    end
+
     def enable(options, _args)
       unless bundle_id
         UI.message("[DevCenter] App '#{Produce.config[:app_identifier]}' does not exist")
@@ -40,6 +44,17 @@ module Produce
       UI.success("Done! Disabled #{disabled} services.")
     end
 
+    def available_services(options, _args)
+      unless bundle_id
+        UI.message("[DevCenter] App '#{Produce.config[:app_identifier]}' does not exist")
+        return
+      end
+
+      UI.success("[DevCenter] App found '#{bundle_id.name}'")
+      UI.message("Fetching available services")
+      return Spaceship::ConnectAPI::Capabilities.all
+    end
+
     def valid_services_for(options)
       allowed_keys = [:access_wifi, :app_attest, :app_group, :apple_pay, :associated_domains, :auto_fill_credential, :car_play_audio_app, :car_play_messaging_app,
                       :car_play_navigation_app, :car_play_voip_calling_app, :class_kit, :icloud, :critical_alerts, :custom_network_protocol, :data_protection,
@@ -82,7 +97,7 @@ module Produce
         bundle_id.update_capability(ACCESS_WIFI_INFORMATION, enabled: on)
       end
 
-      if options.access_wifi
+      if options.app_attest
         UI.message("\tApp Attest")
         bundle_id.update_capability(APP_ATTEST, enabled: on)
       end

data/scan/lib/scan/xcpretty_reporter_options_generator.rb

@@ -13,7 +13,7 @@ module Scan
                Scan.config[:xcpretty_args])
     end
 
-    # Intialize with values from Scan.config matching these param names
+    # Initialize with values from Scan.config matching these param names
     def initialize(open_report, output_types, output_files, output_directory, use_clang_report_name, xcpretty_args)
       @open_report = open_report
       @output_types = output_types

data/sigh/lib/sigh/options.rb

@@ -149,7 +149,8 @@ module Sigh
                                      env_name: "SIGH_SKIP_CERTIFICATE_VERIFICATION",
                                      description: "Skips the verification of the certificates for every existing profiles. This will make sure the provisioning profile can be used on the local machine",
                                      is_string: false,
-                                     default_value: false),
+                                     default_value: !FastlaneCore::Helper.mac?,
+                                     default_value_dynamic: true),
         FastlaneCore::ConfigItem.new(key: :platform,
                                      short_option: '-p',
                                      env_name: "SIGH_PLATFORM",

data/spaceship/lib/spaceship/client.rb

@@ -41,6 +41,7 @@ module Spaceship
     attr_accessor :logger
 
     attr_accessor :csrf_tokens
+    attr_accessor :additional_headers
 
     attr_accessor :provider
 
@@ -717,8 +718,13 @@ module Spaceship
       @csrf_tokens || {}
     end
 
+    def additional_headers
+      @additional_headers || {}
+    end
+
     def request(method, url_or_path = nil, params = nil, headers = {}, auto_paginate = false, &block)
       headers.merge!(csrf_tokens)
+      headers.merge!(additional_headers)
       headers['User-Agent'] = USER_AGENT
 
       # Before encoding the parameters, log them

data/spaceship/lib/spaceship/connect_api/api_client.rb

@@ -208,7 +208,13 @@ module Spaceship
       # Overridden from Spaceship::Client
       def handle_error(response)
         body = response.body.empty? ? {} : response.body
-        body = JSON.parse(body) if body.kind_of?(String)
+
+        # Setting body nil if invalid JSON which can happen if 502
+        begin
+          body = JSON.parse(body) if body.kind_of?(String)
+        rescue
+          nil
+        end
 
         case response.status.to_i
         when 401
@@ -221,6 +227,14 @@ module Spaceship
           else
             raise AccessForbiddenError, format_errors(response)
           end
+        when 502
+          # Issue - https://github.com/fastlane/fastlane/issues/19264
+          # This 502 with "Could not process this request" body sometimes
+          # work and sometimes doesn't
+          # Usually retrying once or twice will solve the issue
+          if body && body.include?("Could not process this request")
+            raise BadGatewayError, "Could not process this request"
+          end
         end
       end
 

data/spaceship/lib/spaceship/connect_api/models/app.rb

@@ -385,11 +385,12 @@ module Spaceship
         return resps.flat_map(&:to_models)
       end
 
-      def create_beta_group(client: nil, group_name: nil, public_link_enabled: false, public_link_limit: 10_000, public_link_limit_enabled: false)
+      def create_beta_group(client: nil, group_name: nil, is_internal_group: false, public_link_enabled: false, public_link_limit: 10_000, public_link_limit_enabled: false)
         client ||= Spaceship::ConnectAPI
         resps = client.create_beta_group(
           app_id: id,
           group_name: group_name,
+          is_internal_group: is_internal_group,
           public_link_enabled: public_link_enabled,
           public_link_limit: public_link_limit,
           public_link_limit_enabled: public_link_limit_enabled
@@ -423,6 +424,13 @@ module Spaceship
           client.add_user_visible_apps(user_id: user_id, app_ids: [id])
         end
       end
+
+      def remove_users(client: nil, user_ids: nil)
+        client ||= Spaceship::ConnectAPI
+        user_ids.each do |user_id|
+          client.delete_user_visible_apps(user_id: user_id, app_ids: [id])
+        end
+      end
     end
   end
 end

data/spaceship/lib/spaceship/connect_api/models/build.rb

@@ -86,6 +86,10 @@ module Spaceship
         return build_beta_detail.nil? == false && build_beta_detail.ready_for_internal_testing?
       end
 
+      def ready_for_external_testing?
+        return build_beta_detail.nil? == false && build_beta_detail.ready_for_external_testing?
+      end
+
       def ready_for_beta_submission?
         raise "No build_beta_detail included" unless build_beta_detail
         return build_beta_detail.ready_for_beta_submission?

data/spaceship/lib/spaceship/connect_api/models/build_beta_detail.rb

@@ -53,6 +53,10 @@ module Spaceship
         return internal_build_state == InternalState::READY_FOR_BETA_TESTING
       end
 
+      def processed?
+        return internal_build_state != InternalState::PROCESSING && external_build_state != ExternalState::PROCESSING
+      end
+
       def ready_for_beta_submission?
         return external_build_state == ExternalState::READY_FOR_BETA_SUBMISSION
       end

data/spaceship/lib/spaceship/connect_api/models/capabilities.rb

@@ -0,0 +1,27 @@
+require_relative '../model'
+
+module Spaceship
+  class ConnectAPI
+    class Capabilities
+      include Spaceship::ConnectAPI::Model
+
+      attr_accessor :name
+      attr_accessor :description
+
+      attr_mapping({
+        "name" => "name",
+        "description" => "description",
+      })
+
+      def self.type
+        return "capabilities"
+      end
+
+      def self.all(client: nil)
+        client ||= Spaceship::ConnectAPI
+        resp = client.get_available_bundle_id_capabilities(bundle_id_id: id).all_pages
+        return resp.flat_map(&:to_models)
+      end
+    end
+  end
+end

data/spaceship/lib/spaceship/connect_api/models/user.rb

@@ -16,6 +16,8 @@ module Spaceship
       attr_accessor :email_vetting_required
       attr_accessor :notifications
 
+      attr_accessor :visible_apps
+
       attr_mapping({
         "username" => "username",
         "firstName" => "first_name",
@@ -27,9 +29,15 @@ module Spaceship
         "allAppsVisible" => "all_apps_visible",
         "provisioningAllowed" => "provisioning_allowed",
         "emailVettingRequired" => "email_vetting_required",
-        "notifications" => "notifications"
+        "notifications" => "notifications",
+
+        "visibleApps" => "visible_apps"
       })
 
+      ESSENTIAL_INCLUDES = [
+        "visibleApps"
+      ].join(",")
+
       def self.type
         return "users"
       end
@@ -38,16 +46,22 @@ module Spaceship
       # API
       #
 
-      def self.all(client: nil, filter: {}, includes: nil, limit: nil, sort: nil)
+      def self.all(client: nil, filter: {}, includes: ESSENTIAL_INCLUDES, limit: nil, sort: nil)
         client ||= Spaceship::ConnectAPI
         resps = client.get_users(filter: filter, includes: includes).all_pages
         return resps.flat_map(&:to_models)
       end
 
-      def self.find(client: nil, email: nil, includes: nil)
+      def self.find(client: nil, email: nil, includes: ESSENTIAL_INCLUDES)
         client ||= Spaceship::ConnectAPI
         return all(client: client, filter: { email: email }, includes: includes)
       end
+
+      def get_visible_apps(client: nil, limit: nil)
+        client ||= Spaceship::ConnectAPI
+        resp = client.get_user_visible_apps(user_id: id, limit: limit)
+        return resp.to_models
+      end
     end
   end
 end

data/spaceship/lib/spaceship/connect_api/models/user_invitation.rb

@@ -11,15 +11,23 @@ module Spaceship
       attr_accessor :all_apps_visible
       attr_accessor :provisioning_allowed
 
+      attr_accessor :visible_apps
+
       attr_mapping({
         "firstName" => "first_name",
         "lastName" => "last_name",
         "email" => "email",
         "roles" => "roles",
         "allAppsVisible" => "all_apps_visible",
-        "provisioningAllowed" => "provisioning_allowed"
+        "provisioningAllowed" => "provisioning_allowed",
+
+        "visibleApps" => "visible_apps"
       })
 
+      ESSENTIAL_INCLUDES = [
+        "visibleApps"
+      ].join(",")
+
       module UserRole
         ADMIN = "ADMIN"
         FINANCE = "FINANCE"
@@ -42,18 +50,23 @@ module Spaceship
       # Managing invitations
       #
 
-      def self.all(client: nil, filter: {}, includes: nil, sort: nil)
+      def self.all(client: nil, filter: {}, includes: ESSENTIAL_INCLUDES, sort: nil)
         client ||= Spaceship::ConnectAPI
         resps = client.get_user_invitations(filter: filter, includes: includes, sort: sort).all_pages
         return resps.flat_map(&:to_models)
       end
 
-      def self.find(client: nil, email: nil, includes: nil)
+      def self.find(client: nil, email: nil, includes: ESSENTIAL_INCLUDES)
         client ||= Spaceship::ConnectAPI
         return all(client: client, filter: { email: email }, includes: includes)
       end
 
-      def self.create(client: nil, email: nil, first_name: nil, last_name: nil, roles: [], provisioning_allowed: nil, all_apps_visible: nil)
+      # Create and post user invitation
+      # App Store Connect allows for the following combinations of `all_apps_visible` and `visible_app_ids`:
+      # - if `all_apps_visible` is `nil`, you don't have to provide values for `visible_app_ids`
+      # - if `all_apps_visible` is true, you must provide values for `visible_app_ids`.
+      # - if `all_apps_visible` is false, you must not provide values for `visible_app_ids`.
+      def self.create(client: nil, email: nil, first_name: nil, last_name: nil, roles: [], provisioning_allowed: nil, all_apps_visible: nil, visible_app_ids: [])
         client ||= Spaceship::ConnectAPI
         resp = client.post_user_invitation(
           email: email,
@@ -61,7 +74,8 @@ module Spaceship
           last_name: last_name,
           roles: roles,
           provisioning_allowed: provisioning_allowed,
-          all_apps_visible: all_apps_visible
+          all_apps_visible: all_apps_visible,
+          visible_app_ids: visible_app_ids
         )
         return resp.to_models.first
       end
@@ -70,6 +84,13 @@ module Spaceship
         client ||= Spaceship::ConnectAPI
         client.delete_user_invitation(user_invitation_id: id)
       end
+
+      # Get visible apps for invited user
+      def get_visible_apps(client: nil, limit: nil)
+        client ||= Spaceship::ConnectAPI
+        resp = client.get_user_invitation_visible_apps(user_invitation_id: id, limit: limit)
+        return resp.to_models
+      end
     end
   end
 end

data/spaceship/lib/spaceship/connect_api/provisioning/provisioning.rb

@@ -54,6 +54,11 @@ module Spaceship
           provisioning_request_client.get("bundleIds/#{bundle_id_id}/bundleIdCapabilities", params)
         end
 
+        def get_available_bundle_id_capabilities(bundle_id_id:)
+          params = provisioning_request_client.build_params(filter: { bundleId: bundle_id_id })
+          provisioning_request_client.get("capabilities", params)
+        end
+
         def post_bundle_id_capability(bundle_id_id:, capability_type:, settings: [])
           body = {
             data: {

data/spaceship/lib/spaceship/connect_api/testflight/client.rb

@@ -11,6 +11,9 @@ module Spaceship
 
           super(cookie: cookie, current_team_id: current_team_id, token: token, another_client: another_client)
 
+          # Used by most iris requests starting in July 2021
+          @additional_headers = { 'x-csrf-itc': '[asc-ui]' } if another_client
+
           self.extend(Spaceship::ConnectAPI::TestFlight::API)
           self.test_flight_request_client = self
         end

data/spaceship/lib/spaceship/connect_api/testflight/testflight.rb

@@ -191,11 +191,26 @@ module Spaceship
           test_flight_request_client.post("builds/#{build_id}/relationships/betaGroups", body)
         end
 
-        def create_beta_group(app_id: nil, group_name: nil, public_link_enabled: false, public_link_limit: 10_000, public_link_limit_enabled: false)
+        def delete_beta_groups_from_build(build_id: nil, beta_group_ids: [])
+          body = {
+            data: beta_group_ids.map do |id|
+              {
+                type: "betaGroups",
+                id: id
+              }
+            end
+          }
+
+          test_flight_request_client.delete("builds/#{build_id}/relationships/betaGroups", nil, body)
+        end
+
+        def create_beta_group(app_id: nil, group_name: nil, is_internal_group: false, public_link_enabled: false, public_link_limit: 10_000, public_link_limit_enabled: false)
           body = {
             data: {
               attributes: {
                 name: group_name,
+                isInternalGroup: is_internal_group,
+                hasAccessToAllBuilds: is_internal_group ? true : false, # Undocumented of 2021-08-02 in ASC API docs and ASC Open API spec. This is the default behavior on App Store Connect and does work with both Apple ID and API Token
                 publicLinkEnabled: public_link_enabled,
                 publicLinkLimit: public_link_limit,
                 publicLinkLimitEnabled: public_link_limit_enabled
@@ -205,11 +220,11 @@ module Spaceship
                   data: {
                     id: app_id,
                     type: "apps"
-                  }
-                }
+                  },
+                },
               },
-              type: "betaGroups"
-            }
+              type: "betaGroups",
+            },
           }
           test_flight_request_client.post("betaGroups", body)
         end
@@ -340,6 +355,32 @@ module Spaceship
           test_flight_request_client.post("betaTesters/#{beta_tester_id}/relationships/builds", body)
         end
 
+        def add_beta_testers_to_build(build_id: nil, beta_tester_ids: [])
+          body = {
+            data: beta_tester_ids.map do |id|
+              {
+                type: "betaTesters",
+                id: id
+              }
+            end
+          }
+
+          test_flight_request_client.post("builds/#{build_id}/relationships/individualTesters", body)
+        end
+
+        def delete_beta_testers_from_build(build_id: nil, beta_tester_ids: [])
+          body = {
+            data: beta_tester_ids.map do |id|
+              {
+                type: "betaTesters",
+                id: id
+              }
+            end
+          }
+
+          test_flight_request_client.delete("builds/#{build_id}/relationships/individualTesters", nil, body)
+        end
+
         #
         # betaTesterMetrics
         #

data/spaceship/lib/spaceship/connect_api/token.rb

@@ -13,6 +13,7 @@ module Spaceship
     class Token
       # maximum expiration supported by AppStore (20 minutes)
       MAX_TOKEN_DURATION = 1200
+      DEFAULT_TOKEN_DURATION = 500
 
       attr_reader :key_id
       attr_reader :issuer_id
@@ -20,6 +21,8 @@ module Spaceship
       attr_reader :duration
       attr_reader :expiration
 
+      attr_reader :key_raw
+
       # Temporary attribute not needed to create the JWT text
       # There is no way to determine if the team associated with this
       # key is for App Store or Enterprise so this is the temporary workaround
@@ -80,7 +83,7 @@ module Spaceship
         @duration = duration
         @in_house = in_house
 
-        @duration ||= MAX_TOKEN_DURATION
+        @duration ||= DEFAULT_TOKEN_DURATION
         @duration = @duration.to_i if @duration
 
         refresh!