fastlane 2.186.0 → 2.190.0

data/fastlane/lib/fastlane/actions/spm.rb

@@ -48,7 +48,7 @@ module Fastlane
           FastlaneCore::ConfigItem.new(key: :enable_code_coverage,
                                        env_name: "FL_SPM_ENABLE_CODE_COVERAGE",
                                        description: "Enables code coverage for the generated Xcode project when using the 'generate-xcodeproj' and the 'test' command",
-                                       is_string: false,
+                                       type: Boolean,
                                        optional: true),
           FastlaneCore::ConfigItem.new(key: :build_path,
                                        env_name: "FL_SPM_BUILD_PATH",
@@ -74,7 +74,7 @@ module Fastlane
                                        env_name: "FL_SPM_DISABLE_SANDBOX",
                                        description: "Disable using the sandbox when executing subprocesses",
                                        optional: true,
-                                       is_string: false,
+                                       type: Boolean,
                                        default_value: false),
           FastlaneCore::ConfigItem.new(key: :xcpretty_output,
                                        env_name: "FL_SPM_XCPRETTY_OUTPUT",
@@ -92,7 +92,7 @@ module Fastlane
                                        short_option: "-v",
                                        env_name: "FL_SPM_VERBOSE",
                                        description: "Increase verbosity of informational output",
-                                       is_string: false,
+                                       type: Boolean,
                                        default_value: false)
         ]
       end

data/fastlane/lib/fastlane/actions/ssh.rb

@@ -88,33 +88,28 @@ module Fastlane
           FastlaneCore::ConfigItem.new(key: :username,
                                        short_option: "-u",
                                        env_name: "FL_SSH_USERNAME",
-                                       description: "Username",
-                                       is_string: true),
+                                       description: "Username"),
           FastlaneCore::ConfigItem.new(key: :password,
                                        short_option: "-p",
                                        env_name: "FL_SSH_PASSWORD",
                                        sensitive: true,
                                        description: "Password",
-                                       optional: true,
-                                       is_string: true),
+                                       optional: true),
           FastlaneCore::ConfigItem.new(key: :host,
                                        short_option: "-H",
                                        env_name: "FL_SSH_HOST",
-                                       description: "Hostname",
-                                       is_string: true),
+                                       description: "Hostname"),
           FastlaneCore::ConfigItem.new(key: :port,
                                        short_option: "-P",
                                        env_name: "FL_SSH_PORT",
                                        description: "Port",
                                        optional: true,
-                                       default_value: "22",
-                                       is_string: true),
+                                       default_value: "22"),
           FastlaneCore::ConfigItem.new(key: :commands,
                                        short_option: "-C",
                                        env_name: "FL_SSH_COMMANDS",
                                        description: "Commands",
                                        optional: true,
-                                       is_string: false,
                                        type: Array),
           FastlaneCore::ConfigItem.new(key: :log,
                                        short_option: "-l",
@@ -122,7 +117,7 @@ module Fastlane
                                        description: "Log commands and output",
                                        optional: true,
                                        default_value: true,
-                                       is_string: false)
+                                       type: Boolean)
         ]
       end
 

data/fastlane/lib/fastlane/actions/testfairy.rb

@@ -192,7 +192,6 @@ module Fastlane
                                        env_name: "FL_TESTFAIRY_UPLOAD_URL", # The name of the environment variable
                                        description: "API URL for TestFairy", # a short description of this parameter
                                        default_value: "https://upload.testfairy.com",
-                                       is_string: true,
                                        optional: true),
           FastlaneCore::ConfigItem.new(key: :testers_groups,
                                        optional: true,

data/fastlane/lib/fastlane/actions/tryouts.rb

@@ -91,7 +91,6 @@ module Fastlane
           FastlaneCore::ConfigItem.new(key: :notes,
                                      env_name: "TRYOUTS_NOTES",
                                      description: "Release notes",
-                                     is_string: true,
                                      optional: true),
           FastlaneCore::ConfigItem.new(key: :notes_path,
                                      env_name: "TRYOUTS_NOTES_PATH",
@@ -103,7 +102,7 @@ module Fastlane
           FastlaneCore::ConfigItem.new(key: :notify,
                                      env_name: "TRYOUTS_NOTIFY",
                                      description: "Notify testers? 0 for no",
-                                     is_string: false,
+                                     type: Integer,
                                      default_value: 1),
           FastlaneCore::ConfigItem.new(key: :status,
                                      env_name: "TRYOUTS_STATUS",
@@ -112,7 +111,7 @@ module Fastlane
                                        available_options = ["1", "2"]
                                        UI.user_error!("'#{value}' is not a valid 'status' value. Available options are #{available_options.join(', ')}") unless available_options.include?(value.to_s)
                                      end,
-                                     is_string: false,
+                                     type: Integer,
                                      default_value: 2)
         ]
       end

data/fastlane/lib/fastlane/actions/twitter.rb

@@ -32,30 +32,25 @@ module Fastlane
                                        env_name: "FL_TW_CONSUMER_KEY",
                                        description: "Consumer Key",
                                        sensitive: true,
-                                       is_string: true,
                                        optional: false),
           FastlaneCore::ConfigItem.new(key: :consumer_secret,
                                        env_name: "FL_TW_CONSUMER_SECRET",
                                        sensitive: true,
                                        description: "Consumer Secret",
-                                       is_string: true,
                                        optional: false),
           FastlaneCore::ConfigItem.new(key: :access_token,
                                        env_name: "FL_TW_ACCESS_TOKEN",
                                        sensitive: true,
                                        description: "Access Token",
-                                       is_string: true,
                                        optional: false),
           FastlaneCore::ConfigItem.new(key: :access_token_secret,
                                        env_name: "FL_TW_ACCESS_TOKEN_SECRET",
                                        sensitive: true,
                                        description: "Access Token Secret",
-                                       is_string: true,
                                        optional: false),
           FastlaneCore::ConfigItem.new(key: :message,
                                        env_name: "FL_TW_MESSAGE",
                                        description: "The tweet",
-                                       is_string: true,
                                        optional: false)
 
         ]

data/fastlane/lib/fastlane/actions/unlock_keychain.rb

@@ -81,13 +81,13 @@ module Fastlane
                                        optional: false),
           FastlaneCore::ConfigItem.new(key: :add_to_search_list,
                                        env_name: "FL_UNLOCK_KEYCHAIN_ADD_TO_SEARCH_LIST",
-                                       description: "Add to keychain search list",
-                                       is_string: false,
+                                       description: "Add to keychain search list, valid values are true, false, :add, and :replace",
+                                       skip_type_validation: true, # allow Boolean, Symbol
                                        default_value: true),
           FastlaneCore::ConfigItem.new(key: :set_default,
                                        env_name: "FL_UNLOCK_KEYCHAIN_SET_DEFAULT",
                                        description: "Set as default keychain",
-                                       is_string: false,
+                                       type: Boolean,
                                        default_value: false)
 
         ]

data/fastlane/lib/fastlane/actions/update_app_group_identifiers.rb

@@ -53,10 +53,7 @@ module Fastlane
           FastlaneCore::ConfigItem.new(key: :app_group_identifiers,
                                        env_name: "FL_UPDATE_APP_GROUP_IDENTIFIER_APP_GROUP_IDENTIFIERS",
                                        description: "An Array of unique identifiers for the app groups. Eg. ['group.com.test.testapp']",
-                                       is_string: false,
-                                       verify_block: proc do |value|
-                                         UI.user_error!("The parameter app_group_identifiers need to be an Array.") unless value.kind_of?(Array)
-                                       end)
+                                       type: Array)
         ]
       end
 

data/fastlane/lib/fastlane/actions/update_code_signing_settings.rb

@@ -123,45 +123,38 @@ module Fastlane
           FastlaneCore::ConfigItem.new(key: :use_automatic_signing,
                                        env_name: "FL_PROJECT_USE_AUTOMATIC_SIGNING",
                                        description: "Defines if project should use automatic signing",
-                                       is_string: false,
+                                       type: Boolean,
                                        default_value: false),
           FastlaneCore::ConfigItem.new(key: :team_id,
                                        env_name: "FASTLANE_TEAM_ID",
                                        optional: true,
-                                       description: "Team ID, is used when upgrading project",
-                                       is_string: true),
+                                       description: "Team ID, is used when upgrading project"),
           FastlaneCore::ConfigItem.new(key: :targets,
                                        env_name: "FL_PROJECT_SIGNING_TARGETS",
                                        optional: true,
                                        type: Array,
-                                       description: "Specify targets you want to toggle the signing mech. (default to all targets)",
-                                       is_string: false),
+                                       description: "Specify targets you want to toggle the signing mech. (default to all targets)"),
           FastlaneCore::ConfigItem.new(key: :build_configurations,
                                        env_name: "FL_PROJECT_SIGNING_BUILD_CONFIGURATIONS",
                                        optional: true,
                                        type: Array,
-                                       description: "Specify build_configurations you want to toggle the signing mech. (default to all configurations)",
-                                       is_string: false),
+                                       description: "Specify build_configurations you want to toggle the signing mech. (default to all configurations)"),
           FastlaneCore::ConfigItem.new(key: :code_sign_identity,
                                        env_name: "FL_CODE_SIGN_IDENTITY",
                                        description: "Code signing identity type (iPhone Developer, iPhone Distribution)",
-                                       optional: true,
-                                       is_string: true),
+                                       optional: true),
           FastlaneCore::ConfigItem.new(key: :profile_name,
                                        env_name: "FL_PROVISIONING_PROFILE_SPECIFIER",
                                        description: "Provisioning profile name to use for code signing",
-                                       optional: true,
-                                       is_string: true),
+                                       optional: true),
           FastlaneCore::ConfigItem.new(key: :profile_uuid,
                                        env_name: "FL_PROVISIONING_PROFILE",
                                        description: "Provisioning profile UUID to use for code signing",
-                                       optional: true,
-                                       is_string: true),
+                                       optional: true),
           FastlaneCore::ConfigItem.new(key: :bundle_identifier,
                                        env_name: "FL_APP_IDENTIFIER",
                                        description: "Application Product Bundle Identifier",
-                                       optional: true,
-                                       is_string: true)
+                                       optional: true)
         ]
       end
 

data/fastlane/lib/fastlane/actions/update_fastlane.rb

@@ -122,12 +122,12 @@ module Fastlane
           FastlaneCore::ConfigItem.new(key: :no_update,
                                        env_name: "FL_NO_UPDATE",
                                        description: "Don't update during this run. This is used internally",
-                                       is_string: false,
+                                       type: Boolean,
                                        default_value: false),
           FastlaneCore::ConfigItem.new(key: :nightly,
                                        env_name: "FL_UPDATE_FASTLANE_NIGHTLY",
                                        description: "Opt-in to install and use nightly fastlane builds",
-                                       is_string: false,
+                                       type: Boolean,
                                        default_value: false,
                                        deprecated: "Nightly builds are no longer being made available")
         ]

data/fastlane/lib/fastlane/actions/update_icloud_container_identifiers.rb

@@ -61,10 +61,7 @@ module Fastlane
           FastlaneCore::ConfigItem.new(key: :icloud_container_identifiers,
                                        env_name: "FL_UPDATE_ICLOUD_CONTAINER_IDENTIFIERS_IDENTIFIERS",
                                        description: "An Array of unique identifiers for the iCloud containers. Eg. ['iCloud.com.test.testapp']",
-                                       is_string: false,
-                                       verify_block: proc do |value|
-                                         UI.user_error!("The parameter icloud_container_identifiers needs to be an Array.") unless value.kind_of?(Array)
-                                       end)
+                                       type: Array)
         ]
       end
 

data/fastlane/lib/fastlane/actions/update_info_plist.rb

@@ -98,7 +98,7 @@ module Fastlane
                                        description: 'The Display Name of your app',
                                        optional: true),
           FastlaneCore::ConfigItem.new(key: :block,
-                                       is_string: false,
+                                       type: :string_callback,
                                        description: 'A block to process plist with custom logic',
                                        optional: true)
 

data/fastlane/lib/fastlane/actions/update_keychain_access_groups.rb

@@ -56,10 +56,7 @@ module Fastlane
           FastlaneCore::ConfigItem.new(key: :identifiers,
                                        env_name: "FL_UPDATE_KEYCHAIN_ACCESS_GROUPS_IDENTIFIERS",
                                        description: "An Array of unique identifiers for the keychain access groups. Eg. ['your.keychain.access.groups.identifiers']",
-                                       is_string: false,
-                                       verify_block: proc do |value|
-                                         UI.user_error!("The parameter identifiers need to be an Array.") unless value.kind_of?(Array)
-                                       end)
+                                       type: Array)
         ]
       end
 

data/fastlane/lib/fastlane/actions/update_plist.rb

@@ -50,7 +50,7 @@ module Fastlane
                                        description: "Path to plist file",
                                        optional: true),
           FastlaneCore::ConfigItem.new(key: :block,
-                                       is_string: false,
+                                       type: :string_callback,
                                        description: 'A block to process plist with custom logic')
 
         ]

data/fastlane/lib/fastlane/actions/update_project_provisioning.rb

@@ -117,7 +117,7 @@ module Fastlane
                                        env_name: "FL_PROJECT_PROVISIONING_PROFILE_TARGET_FILTER",
                                        description: "A filter for the target name. Use a standard regex",
                                        optional: true,
-                                       is_string: false,
+                                       skip_type_validation: true, # allow Regexp, String
                                        verify_block: proc do |value|
                                          UI.user_error!("target_filter should be Regexp or String") unless [Regexp, String].any? { |type| value.kind_of?(type) }
                                        end),
@@ -129,7 +129,7 @@ module Fastlane
                                        env_name: "FL_PROJECT_PROVISIONING_PROFILE_BUILD_CONFIGURATION",
                                        description: "A filter for the build configuration name. Use a standard regex. Applied to all configurations if not specified",
                                        optional: true,
-                                       is_string: false,
+                                       skip_type_validation: true, # allow Regexp, String
                                        verify_block: proc do |value|
                                          UI.user_error!("build_configuration should be Regexp or String") unless [Regexp, String].any? { |type| value.kind_of?(type) }
                                        end),

data/fastlane/lib/fastlane/actions/update_urban_airship_configuration.rb

@@ -58,7 +58,6 @@ module Fastlane
                                        description: "The production app secret"),
           FastlaneCore::ConfigItem.new(key: :detect_provisioning_mode,
                                        env_name: "URBAN_AIRSHIP_DETECT_PROVISIONING_MODE",
-                                       is_string: false,
                                        type: Boolean,
                                        optional: true,
                                        description: "Automatically detect provisioning mode")

data/fastlane/lib/fastlane/actions/update_url_schemes.rb

@@ -51,33 +51,22 @@ module Fastlane
 
       def self.available_options
         [
-          FastlaneCore::ConfigItem.new(
-            key: :path,
-            env_name: 'FL_UPDATE_URL_SCHEMES_PATH',
-            description: 'The Plist file\'s path',
-            is_string: true,
-            optional: false,
-            verify_block: proc do |path|
-              UI.user_error!("Could not find plist at path '#{path}'") unless File.exist?(path)
-            end
-          ),
-
-          FastlaneCore::ConfigItem.new(
-            key: :url_schemes,
-            env_name: "FL_UPDATE_URL_SCHEMES_SCHEMES",
-            description: 'The new URL schemes',
-            is_string: false,
-            optional: true,
-            verify_block: proc do |url_schemes|
-              string = "The URL schemes must be an array of strings, got '#{url_schemes}'."
-              verify_schemes!(url_schemes, string)
-            end
-          ),
-
+          FastlaneCore::ConfigItem.new(key: :path,
+                                       env_name: 'FL_UPDATE_URL_SCHEMES_PATH',
+                                       description: 'The Plist file\'s path',
+                                       optional: false,
+                                       verify_block: proc do |path|
+                                         UI.user_error!("Could not find plist at path '#{path}'") unless File.exist?(path)
+                                       end),
+          FastlaneCore::ConfigItem.new(key: :url_schemes,
+                                       env_name: "FL_UPDATE_URL_SCHEMES_SCHEMES",
+                                       description: 'The new URL schemes',
+                                       type: Array,
+                                       optional: true),
           FastlaneCore::ConfigItem.new(key: :update_url_schemes,
-            description: "Block that is called to update schemes with current schemes passed in as parameter",
-            optional: true,
-            is_string: false)
+                                       description: "Block that is called to update schemes with current schemes passed in as parameter",
+                                       optional: true,
+                                       type: :string_callback)
         ]
       end
 

data/fastlane/lib/fastlane/actions/upload_app_privacy_details_to_app_store.rb

@@ -205,7 +205,7 @@ module Fastlane
                                        env_name: "FASTLANE_ITC_TEAM_ID",
                                        description: "The ID of your App Store Connect team if you're in multiple teams",
                                        optional: true,
-                                       is_string: false, # as we also allow integers, which we convert to strings anyway
+                                       skip_type_validation: true, # as we also allow integers, which we convert to strings anyway
                                        code_gen_sensitive: true,
                                        default_value: CredentialsManager::AppfileConfig.try_fetch_value(:itc_team_id),
                                        default_value_dynamic: true),
@@ -221,7 +221,6 @@ module Fastlane
           FastlaneCore::ConfigItem.new(key: :json_path,
                                        env_name: "UPLOAD_APP_PRIVACY_DETAILS_TO_APP_STORE_JSON_PATH",
                                        description: "Path to the app usage data JSON",
-                                       is_string: true,
                                        optional: true,
                                        verify_block: proc do |value|
                                          UI.user_error!("Could not find JSON file at path '#{File.expand_path(value)}'") unless File.exist?(value)

data/fastlane/lib/fastlane/actions/upload_symbols_to_sentry.rb

@@ -79,7 +79,6 @@ module Fastlane
           FastlaneCore::ConfigItem.new(key: :api_host,
                                        env_name: "SENTRY_HOST",
                                        description: "API host url for Sentry",
-                                       is_string: true,
                                        default_value: "https://app.getsentry.com/api/0",
                                        optional: true),
           FastlaneCore::ConfigItem.new(key: :api_key,
@@ -109,20 +108,14 @@ module Fastlane
                                        description: "Path to your symbols file. For iOS and Mac provide path to app.dSYM.zip",
                                        default_value: Actions.lane_context[SharedValues::DSYM_OUTPUT_PATH],
                                        default_value_dynamic: true,
-                                       optional: true,
-                                       verify_block: proc do |value|
-                                         # validation is done in the action
-                                       end),
+                                       optional: true),
           FastlaneCore::ConfigItem.new(key: :dsym_paths,
                                        env_name: "SENTRY_DSYM_PATHS",
                                        description: "Path to an array of your symbols file. For iOS and Mac provide path to app.dSYM.zip",
                                        default_value: Actions.lane_context[SharedValues::DSYM_PATHS],
                                        default_value_dynamic: true,
-                                       is_string: false,
-                                       optional: true,
-                                       verify_block: proc do |value|
-                                         # validation is done in the action
-                                       end)
+                                       type: Array,
+                                       optional: true)
         ]
       end
 

data/fastlane/lib/fastlane/actions/validate_play_store_json_key.rb

@@ -42,53 +42,49 @@ module Fastlane
 
       def self.available_options
         [
-          FastlaneCore::ConfigItem.new(
-            key: :json_key,
-            env_name: "SUPPLY_JSON_KEY",
-            short_option: "-j",
-            conflicting_options: [:json_key_data],
-            optional: true, # this shouldn't be optional but is until I find out how json_key OR json_key_data can be required
-            description: "The path to a file containing service account JSON, used to authenticate with Google",
-            code_gen_sensitive: true,
-            default_value: CredentialsManager::AppfileConfig.try_fetch_value(:json_key_file),
-            default_value_dynamic: true,
-            verify_block: proc do |value|
-              UI.user_error!("Could not find service account json file at path '#{File.expand_path(value)}'") unless File.exist?(File.expand_path(value))
-              UI.user_error!("'#{value}' doesn't seem to be a JSON file") unless FastlaneCore::Helper.json_file?(File.expand_path(value))
-            end
-          ),
-          FastlaneCore::ConfigItem.new(
-            key: :json_key_data,
-            env_name: "SUPPLY_JSON_KEY_DATA",
-            short_option: "-c",
-            conflicting_options: [:json_key],
-            optional: true,
-            description: "The raw service account JSON data used to authenticate with Google",
-            code_gen_sensitive: true,
-            default_value: CredentialsManager::AppfileConfig.try_fetch_value(:json_key_data_raw),
-            default_value_dynamic: true,
-            verify_block: proc do |value|
-              begin
-                JSON.parse(value)
-              rescue JSON::ParserError
-                UI.user_error!("Could not parse service account json: JSON::ParseError")
-              end
-            end
-          ),
+          FastlaneCore::ConfigItem.new(key: :json_key,
+                                       env_name: "SUPPLY_JSON_KEY",
+                                       short_option: "-j",
+                                       conflicting_options: [:json_key_data],
+                                       optional: true,
+                                       description: "The path to a file containing service account JSON, used to authenticate with Google",
+                                       code_gen_sensitive: true,
+                                       default_value: CredentialsManager::AppfileConfig.try_fetch_value(:json_key_file),
+                                       default_value_dynamic: true,
+                                       verify_block: proc do |value|
+                                         UI.user_error!("Could not find service account json file at path '#{File.expand_path(value)}'") unless File.exist?(File.expand_path(value))
+                                         UI.user_error!("'#{value}' doesn't seem to be a JSON file") unless FastlaneCore::Helper.json_file?(File.expand_path(value))
+                                       end),
+          FastlaneCore::ConfigItem.new(key: :json_key_data,
+                                       env_name: "SUPPLY_JSON_KEY_DATA",
+                                       short_option: "-c",
+                                       conflicting_options: [:json_key],
+                                       optional: true,
+                                       description: "The raw service account JSON data used to authenticate with Google",
+                                       code_gen_sensitive: true,
+                                       default_value: CredentialsManager::AppfileConfig.try_fetch_value(:json_key_data_raw),
+                                       default_value_dynamic: true,
+                                       verify_block: proc do |value|
+                                         begin
+                                           JSON.parse(value)
+                                         rescue JSON::ParserError
+                                           UI.user_error!("Could not parse service account json: JSON::ParseError")
+                                         end
+                                       end),
           # stuff
           FastlaneCore::ConfigItem.new(key: :root_url,
-            env_name: "SUPPLY_ROOT_URL",
-            description: "Root URL for the Google Play API. The provided URL will be used for API calls in place of https://www.googleapis.com/",
-            optional: true,
-            verify_block: proc do |value|
-              UI.user_error!("Could not parse URL '#{value}'") unless value =~ URI.regexp
-            end),
+                                       env_name: "SUPPLY_ROOT_URL",
+                                       description: "Root URL for the Google Play API. The provided URL will be used for API calls in place of https://www.googleapis.com/",
+                                       optional: true,
+                                       verify_block: proc do |value|
+                                         UI.user_error!("Could not parse URL '#{value}'") unless value =~ URI.regexp
+                                       end),
           FastlaneCore::ConfigItem.new(key: :timeout,
-            env_name: "SUPPLY_TIMEOUT",
-            optional: true,
-            description: "Timeout for read, open, and send (in seconds)",
-            type: Integer,
-            default_value: 300)
+                                       env_name: "SUPPLY_TIMEOUT",
+                                       optional: true,
+                                       description: "Timeout for read, open, and send (in seconds)",
+                                       type: Integer,
+                                       default_value: 300)
         ]
       end