fastlane 2.18.0.beta.20170218010103 → 2.18.0.beta.20170219010032

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 26344fc38e6bbb52df6730fd55f0aad3c5faa291
-  data.tar.gz: 7567c71aaf884fb1140d4541df84d79b06e4a7d5
+  metadata.gz: 17f99d6e6eaa0f5e45cfc24f92aa8b1fe2388837
+  data.tar.gz: b3e64049b4e7d5eae68893294836617a169ca53e
 SHA512:
-  metadata.gz: fbcca6ceea36efa4997e21bbe549204e21ee24fa0869c765aeefcbbb618d178dbe0aabaec6b4dbeeee1f26069ed2e06cc0cdb7a1ea64c47cf408985972d5cc2f
-  data.tar.gz: 8121a45f2868454cef211d3cbd6fd43bcbb1c9a2c516c7d63f2d3fc08b617e4cfe962a56bc52e15d535004a44588dad2e1182a6a9751ea9330ed9a9680824a18
+  metadata.gz: 6689923739a46a4c5fba3bda0b02d3917aaf1bb9a930cb13cc5feac8f03c1f7335cc8a2283a2719449368aacf21b6d80547e87a53bb084e2d588e02ca56c6d95
+  data.tar.gz: b9f562c9be1e85d839bfcd8247de788746c23ec2a08ad11b5ab50e0078252227899dbcef28f792e8c739f0a119b670f792dc55b5f7366312885208bb701e5e30

data/deliver/lib/assets/summary.html.erb

@@ -114,6 +114,16 @@
               float: left;
               margin-right: 20px;
           }
+
+          .app-review-information {
+            margin-left: 15px;
+            margin-right: 15px;
+            margin-top: 22px;
+          }
+
+          .app-review-information-key {
+            font-weight: 700;
+          }
         </style>
     </head>
     
@@ -228,5 +238,20 @@
         
         <hr />
       <% end # end data %>
+      <% if @options[:app_review_information] %>
+        <div class="app-review-information">
+          <div class="cat-headline">Review Information</div>
+          <dl class="app-review-information">
+            <% @options[:app_review_information].each do |key, value| %>
+                <dt class="app-review-information-key">
+                  <%= key.to_s.capitalize.gsub("_", " ") %>
+                </dt>
+                <dd class="app-review-information-text">
+                  <%= (value || '').gsub("\n", "<br />") %>
+                </dd>
+            <% end %>
+          </dl>
+        </div>
+    <% end %>
     </body>
 </html>

data/deliver/lib/deliver/setup.rb

@@ -66,6 +66,17 @@ module Deliver
         UI.message("Writing to '#{resulting_path}'")
       end
 
+      # Review information
+      UploadMetadata::REVIEW_INFORMATION_VALUES.each do |key, option_name|
+        content = v.send(key).to_s
+        content << "\n"
+        base_dir = File.join(path, UploadMetadata::REVIEW_INFORMATION_DIR)
+        FileUtils.mkdir_p(base_dir)
+        resulting_path = File.join(base_dir, "#{option_name}.txt")
+        File.write(resulting_path, content)
+        UI.message("Writing to '#{resulting_path}'")
+      end
+
       UI.success("Successfully created new configuration files.")
 
       # get App icon + watch icon

data/deliver/lib/deliver/upload_metadata.rb

@@ -15,12 +15,26 @@ module Deliver
                                 :primary_first_sub_category, :primary_second_sub_category,
                                 :secondary_first_sub_category, :secondary_second_sub_category]
 
+    # Review information values
+    REVIEW_INFORMATION_VALUES = {
+      review_first_name: :first_name,
+      review_last_name: :last_name,
+      review_phone_number: :phone_number,
+      review_email: :email_address,
+      review_demo_user: :demo_user,
+      review_demo_password: :demo_password,
+      review_notes: :notes
+    }
+
     # Localized app details values, that are editable in live state
     LOCALISED_LIVE_VALUES = [:description, :release_notes, :support_url, :marketing_url]
 
     # Non localized app details values, that are editable in live state
     NON_LOCALISED_LIVE_VALUES = [:privacy_url]
 
+    # Directory name it contains review information
+    REVIEW_INFORMATION_DIR = "review_information"
+
     # Make sure to call `load_from_filesystem` before calling upload
     def upload(options)
       return if options[:skip_metadata]
@@ -183,6 +197,17 @@ module Deliver
         UI.message("Loading '#{path}'...")
         options[key] ||= File.read(path)
       end
+
+      # Load review information
+      options[:app_review_information] ||= {}
+      REVIEW_INFORMATION_VALUES.values.each do |option_name|
+        path = File.join(options[:metadata_path], REVIEW_INFORMATION_DIR, "#{option_name}.txt")
+        next unless File.exist?(path)
+        next if options[:app_review_information][option_name].to_s.length > 0
+
+        UI.message("Loading '#{path}'...")
+        options[:app_review_information][option_name] ||= File.read(path)
+      end
     end
 
     private
@@ -192,14 +217,10 @@ module Deliver
       info = options[:app_review_information]
       UI.user_error!("`app_review_information` must be a hash", show_github_issues: true) unless info.kind_of?(Hash)
 
-      v.review_first_name = info[:first_name] if info[:first_name]
-      v.review_last_name = info[:last_name] if info[:last_name]
-      v.review_phone_number = info[:phone_number] if info[:phone_number]
-      v.review_email = info[:email_address] if info[:email_address]
-      v.review_demo_user = info[:demo_user] if info[:demo_user]
-      v.review_demo_password = info[:demo_password] if info[:demo_password]
+      REVIEW_INFORMATION_VALUES.each do |key, option_name|
+        v.send("#{key}=", info[option_name]) if info[option_name]
+      end
       v.review_user_needed = (v.review_demo_user.to_s + v.review_demo_password.to_s).length > 0
-      v.review_notes = info[:notes] if info[:notes]
     end
 
     def set_app_rating(v, options)

data/fastlane/lib/fastlane/version.rb

@@ -1,4 +1,4 @@
 module Fastlane
-  VERSION = '2.18.0.beta.20170218010103'.freeze
+  VERSION = '2.18.0.beta.20170219010032'.freeze
   DESCRIPTION = "The easiest way to automate beta deployments and releases for your iOS and Android apps".freeze
 end

data/sigh/lib/assets/resign.sh

@@ -703,7 +703,7 @@ function resign {
             # otherwise it interprets they key path as nested keys
             # TODO: Should be able to replace with echo ${KEY//\./\\\\.} and remove shellcheck disable directive
             # shellcheck disable=SC2001
-            PLUTIL_KEY=$(echo "$KEY" | sed 's/\./\\\\./g')
+            PLUTIL_KEY=$(echo "$KEY" | sed 's/\./\\\./g')
             plutil -insert "$PLUTIL_KEY" -xml "$ENTITLEMENTS_VALUE" "$PATCHED_ENTITLEMENTS"
 
             # Patch the ID value if specified

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: fastlane
 version: !ruby/object:Gem::Version
-  version: 2.18.0.beta.20170218010103
+  version: 2.18.0.beta.20170219010032
 platform: ruby
 authors:
 - Felix Krause
@@ -14,7 +14,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-02-18 00:00:00.000000000 Z
+date: 2017-02-19 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: slack-notifier
@@ -1294,23 +1294,23 @@ metadata: {}
 post_install_message: 
 rdoc_options: []
 require_paths:
-- spaceship/lib
-- sigh/lib
-- snapshot/lib
-- deliver/lib
-- cert/lib
-- pem/lib
 - gym/lib
+- deliver/lib
 - fastlane/lib
-- frameit/lib
-- scan/lib
-- supply/lib
-- pilot/lib
+- fastlane_core/lib
 - produce/lib
+- supply/lib
+- snapshot/lib
 - match/lib
-- fastlane_core/lib
-- credentials_manager/lib
+- spaceship/lib
+- cert/lib
 - screengrab/lib
+- scan/lib
+- frameit/lib
+- sigh/lib
+- pem/lib
+- credentials_manager/lib
+- pilot/lib
 required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="