fastlane 2.179.0 → 2.183.0

data/spaceship/lib/spaceship/commands_generator.rb

@@ -3,6 +3,7 @@ require 'highline'
 HighLine.track_eof = false
 
 require 'fastlane/version'
+require 'fastlane_core/ui/help_formatter'
 require_relative 'playground'
 require_relative 'spaceauth_runner'
 
@@ -21,7 +22,7 @@ module Spaceship
       program :help, 'Author', 'Felix Krause <spaceship@krausefx.com>'
       program :help, 'Website', 'https://fastlane.tools'
       program :help, 'GitHub', 'https://github.com/fastlane/fastlane/tree/master/spaceship'
-      program :help_formatter, :compact
+      program :help_formatter, FastlaneCore::HelpFormatter
 
       global_option('-u', '--user USERNAME', 'Specify the Apple ID you want to log in with')
       global_option('--verbose') { FastlaneCore::Globals.verbose = true }
@@ -39,9 +40,10 @@ module Spaceship
       command :spaceauth do |c|
         c.syntax = 'fastlane spaceship spaceauth'
         c.description = 'Authentication helper for spaceship/fastlane to work with Apple 2-Step/2FA'
+        c.option('--copy_to_clipboard', 'Whether the session string should be copied to clipboard. For more info see https://docs.fastlane.tools/best-practices/continuous-integration/#storing-a-manually-verified-session-using-spaceauth`')
 
         c.action do |args, options|
-          Spaceship::SpaceauthRunner.new(username: options.user).run
+          Spaceship::SpaceauthRunner.new(username: options.user, copy_to_clipboard: options.copy_to_clipboard).run
         end
       end
 

data/spaceship/lib/spaceship/connect_api/model.rb

@@ -30,7 +30,7 @@ module Spaceship
       # Creates alias for :minOsVersion to :min_os_version
       #
       def attr_mapping(attr_map)
-        self.reverse_attr_map ||= attr_map.invert.each_with_object({}) { |(k, v), memo| memo[k.to_sym] = v; }
+        self.reverse_attr_map ||= attr_map.invert.transform_keys(&:to_sym)
         attr_map.each do |key, value|
           # Actual
           reader = value.to_sym

data/spaceship/lib/spaceship/connect_api/models/app_screenshot.rb

@@ -112,7 +112,7 @@ module Spaceship
           timeout_minutes = (ENV["SPACESHIP_SCREENSHOT_UPLOAD_TIMEOUT"] || 20).to_i
 
           loop do
-            # This error handling needs to be revised since any error occured can reach here.
+            # This error handling needs to be revised since any error occurred can reach here.
             # It should handle errors based on what status code is.
             puts("Waiting for screenshots to appear before uploading. This is unlikely to be recovered unless it's 503 error. error=\"#{error}\"")
             sleep(30)

data/spaceship/lib/spaceship/connect_api/models/profile.rb

@@ -92,6 +92,12 @@ module Spaceship
         return resps.flat_map(&:to_models)
       end
 
+      def fetch_all_certificates(client: nil, filter: {}, includes: nil, sort: nil)
+        client ||= Spaceship::ConnectAPI
+        resps = client.get_certificates(profile_id: id, filter: filter, includes: includes).all_pages
+        return resps.flat_map(&:to_models)
+      end
+
       def delete!(client: nil)
         client ||= Spaceship::ConnectAPI
         return client.delete_profile(profile_id: id)

data/spaceship/lib/spaceship/connect_api/provisioning/provisioning.rb

@@ -84,9 +84,13 @@ module Spaceship
         # certificates
         #
 
-        def get_certificates(filter: {}, includes: nil, limit: nil, sort: nil)
+        def get_certificates(profile_id: nil, filter: {}, includes: nil, limit: nil, sort: nil)
           params = provisioning_request_client.build_params(filter: filter, includes: includes, limit: limit, sort: sort)
-          provisioning_request_client.get("certificates", params)
+          if profile_id.nil?
+            provisioning_request_client.get("certificates", params)
+          else
+            provisioning_request_client.get("profiles/#{profile_id}/certificates", params)
+          end
         end
 
         def get_certificate(certificate_id: nil, includes: nil)

data/spaceship/lib/spaceship/connect_api/token.rb

@@ -60,14 +60,16 @@ module Spaceship
           key_id: key_id,
           issuer_id: issuer_id,
           key: OpenSSL::PKey::EC.new(key),
+          key_raw: key,
           duration: duration,
           in_house: in_house
         )
       end
 
-      def initialize(key_id: nil, issuer_id: nil, key: nil, duration: nil, in_house: nil)
+      def initialize(key_id: nil, issuer_id: nil, key: nil, key_raw: nil, duration: nil, in_house: nil)
         @key_id = key_id
         @key = key
+        @key_raw = key_raw
         @issuer_id = issuer_id
         @duration = duration
         @in_house = in_house
@@ -97,6 +99,10 @@ module Spaceship
       def expired?
         @expiration < Time.now
       end
+
+      def write_key_to_file(path)
+        File.open(path, 'w') { |f| f.write(@key_raw) }
+      end
     end
   end
 end

data/spaceship/lib/spaceship/spaceauth_runner.rb

@@ -1,15 +1,17 @@
 require 'colored'
 require 'credentials_manager/appfile_config'
 require 'yaml'
+require 'fastlane_core'
 
 require_relative 'tunes/tunes_client'
 
 module Spaceship
   class SpaceauthRunner
-    def initialize(username: nil)
+    def initialize(username: nil, copy_to_clipboard: nil)
       @username = username
       @username ||= CredentialsManager::AppfileConfig.try_fetch_value(:apple_id)
       @username ||= ask("Username: ")
+      @copy_to_clipboard = copy_to_clipboard
     end
 
     def run
@@ -22,7 +24,7 @@ module Spaceship
         puts("Could not login to App Store Connect".red)
         puts("Please check your credentials and try again.".yellow)
         puts("This could be an issue with App Store Connect,".yellow)
-        puts("Please try unsetting the FASTLANE_SESSION environment variable".yellow)
+        puts("Please try unsetting the FASTLANE_SESSION environment variable by calling 'unset FASTLANE_SESSION'".yellow)
         puts("(if it is set) and re-run `fastlane spaceauth`".yellow)
         puts("")
         puts("Exception type: #{ex.class}")
@@ -49,22 +51,30 @@ module Spaceship
         cookie.name.start_with?("myacinfo") || cookie.name == "dqsid" || cookie.name.start_with?("DES")
       end
 
-      yaml = cookies.to_yaml.gsub("\n", "\\n")
+      @yaml = cookies.to_yaml.gsub("\n", "\\n")
 
       puts("---")
       puts("")
       puts("Pass the following via the FASTLANE_SESSION environment variable:")
-      puts(yaml.cyan.underline)
+      puts(@yaml.cyan.underline)
       puts("")
       puts("")
       puts("Example:")
-      puts("export FASTLANE_SESSION='#{yaml}'".cyan.underline)
+      puts("export FASTLANE_SESSION='#{@yaml}'".cyan.underline)
 
-      if mac? && Spaceship::Client::UserInterface.interactive? && agree("🙄 Should fastlane copy the cookie into your clipboard, so you can easily paste it? (y/n)", true)
-        require 'open3'
-        Open3.popen3('pbcopy') { |input, _, _| input << yaml }
-        puts("Successfully copied text into your clipboard 🎨".green)
+      if @copy_to_clipboard == false
+        puts("Skipped asking to copy the session string into your clipboard ⏭️".green)
+      elsif @copy_to_clipboard || (mac? && Spaceship::Client::UserInterface.interactive? && agree("🙄 Should fastlane copy the cookie into your clipboard, so you can easily paste it? (y/n)", true))
+        FastlaneCore::Clipboard.copy(content: @yaml)
+        puts("Successfully copied the session string into your clipboard 🎨".green)
       end
+
+      return self
+    end
+
+    def session_string
+      FastlaneCore::UI.user_error!("`#{__method__}` method called before calling `run` in `SpaceauthRunner`") unless @yaml
+      @yaml
     end
 
     def mac?

data/spaceship/lib/spaceship/tunes/members.rb

@@ -15,7 +15,7 @@ module Spaceship
 
         def find(email)
           all.each do |member|
-            if member.email_address == email
+            if member.email_address.casecmp?(email)
               return member
             end
           end

data/spaceship/lib/spaceship/ui.rb

@@ -18,10 +18,10 @@ module Spaceship
     end
 
     # Public getter for all UI related code
-    # rubocop:disable Style/MethodName
+    # rubocop:disable Naming/MethodName
     def UI
       UserInterface.new(self)
     end
-    # rubocop:enable Style/MethodName
+    # rubocop:enable Naming/MethodName
   end
 end

data/supply/lib/supply/client.rb

@@ -327,12 +327,14 @@ module Supply
     def upload_mapping(path_to_mapping, apk_version_code)
       ensure_active_edit!
 
+      extension = File.extname(path_to_mapping).downcase
+
       call_google_api do
         client.upload_edit_deobfuscationfile(
           current_package_name,
           current_edit.id,
           apk_version_code,
-          "proguard",
+          extension == ".zip" ? "nativeCode" : "proguard",
           upload_source: path_to_mapping,
           content_type: "application/octet-stream"
         )

data/supply/lib/supply/commands_generator.rb

@@ -1,5 +1,6 @@
 require "commander"
 require "fastlane_core"
+require 'fastlane_core/ui/help_formatter'
 require "supply"
 
 HighLine.track_eof = false
@@ -19,7 +20,7 @@ module Supply
       program :help, 'Author', 'Felix Krause <supply@krausefx.com>'
       program :help, 'Website', 'https://fastlane.tools'
       program :help, 'Documentation', 'https://docs.fastlane.tools/actions/supply/'
-      program :help_formatter, :compact
+      program :help_formatter, FastlaneCore::HelpFormatter
 
       always_trace!
 

data/supply/lib/supply/options.rb

@@ -223,7 +223,7 @@ module Supply
                                      default_value: false),
         FastlaneCore::ConfigItem.new(key: :mapping,
                                      env_name: "SUPPLY_MAPPING",
-                                     description: "Path to the mapping file to upload",
+                                     description: "Path to the mapping file to upload (mapping.txt or native-debug-symbols.zip alike)",
                                      short_option: "-d",
                                      conflicting_options: [:mapping_paths],
                                      optional: true,
@@ -235,7 +235,7 @@ module Supply
                                      conflicting_options: [:mapping],
                                      optional: true,
                                      type: Array,
-                                     description: "An array of paths to mapping files to upload",
+                                     description: "An array of paths to mapping files to upload (mapping.txt or native-debug-symbols.zip alike)",
                                      short_option: "-s",
                                      verify_block: proc do |value|
                                        UI.user_error!("Could not evaluate array from '#{value}'") unless value.kind_of?(Array)

data/supply/lib/supply/uploader.rb

@@ -304,6 +304,7 @@ module Supply
       mapping_paths = [Supply.config[:mapping]] unless (mapping_paths = Supply.config[:mapping_paths])
       mapping_paths.zip(apk_version_codes).each do |mapping_path, version_code|
         if mapping_path
+          UI.message("Preparing mapping at path '#{mapping_path}', version code #{version_code} for upload...")
           client.upload_mapping(mapping_path, version_code)
         end
       end

metadata

@@ -1,58 +1,38 @@
 --- !ruby/object:Gem::Specification
 name: fastlane
 version: !ruby/object:Gem::Version
-  version: 2.179.0
+  version: 2.183.0
 platform: ruby
 authors:
-- Luka Mirosevic
 - Max Ott
 - Joshua Liebowitz
-- Jérôme Lacoste
-- Manu Wallner
-- Stefan Natchev
+- Helmut Januschka
+- Aaron Brager
 - Andrew McBurney
+- Josh Holtz
+- Fumiya Nakamura
+- Iulian Onofrei
+- Olivier Halligon
 - Roger Oba
-- Daniel Jankowski
-- Satoshi Namai
+- Manu Wallner
+- Danielle Tomlinson
+- Maksym Grebenets
 - Jimmy Dee
-- Kohki Miki
-- Iulian Onofrei
-- Fumiya Nakamura
-- Josh Holtz
-- Helmut Januschka
+- Matthew Ellis
 - Felix Krause
 - Jan Piotrowski
-- Aaron Brager
-- Maksym Grebenets
+- Satoshi Namai
+- Luka Mirosevic
+- Kohki Miki
 - Jorge Revuelta H
-- Danielle Tomlinson
-- Matthew Ellis
-- Olivier Halligon
+- Daniel Jankowski
+- Stefan Natchev
+- Jérôme Lacoste
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2021-03-26 00:00:00.000000000 Z
+date: 2021-05-14 00:00:00.000000000 Z
 dependencies:
-- !ruby/object:Gem::Dependency
-  name: slack-notifier
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: 2.0.0
-    - - "<"
-      - !ruby/object:Gem::Version
-        version: 3.0.0
-  type: :runtime
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: 2.0.0
-    - - "<"
-      - !ruby/object:Gem::Version
-        version: 3.0.0
 - !ruby/object:Gem::Dependency
   name: xcodeproj
   requirement: !ruby/object:Gem::Requirement
@@ -304,25 +284,19 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: commander-fastlane
+  name: commander
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: 4.4.6
-    - - "<"
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: 5.0.0
+        version: '4.6'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: 4.4.6
-    - - "<"
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: 5.0.0
+        version: '4.6'
 - !ruby/object:Gem::Dependency
   name: excon
   requirement: !ruby/object:Gem::Requirement
@@ -429,22 +403,16 @@ dependencies:
   name: highline
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: 1.7.2
-    - - "<"
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: 2.0.0
+        version: '2.0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: 1.7.2
-    - - "<"
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: 2.0.0
+        version: '2.0'
 - !ruby/object:Gem::Dependency
   name: json
   requirement: !ruby/object:Gem::Requirement
@@ -616,45 +584,47 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '3'
 - !ruby/object:Gem::Dependency
-  name: google-api-client
+  name: google-apis-playcustomapp_v1
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: 0.37.0
-    - - "<"
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.39.0
+        version: '0.1'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.37.0
-    - - "<"
+        version: '0.1'
+- !ruby/object:Gem::Dependency
+  name: google-apis-androidpublisher_v3
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '0.1'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.39.0
+        version: '0.1'
 - !ruby/object:Gem::Dependency
   name: google-cloud-storage
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: 1.15.0
-    - - "<"
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: 2.0.0
+        version: '1.31'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: 1.15.0
-    - - "<"
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: 2.0.0
+        version: '1.31'
 - !ruby/object:Gem::Dependency
   name: emoji_regex
   requirement: !ruby/object:Gem::Requirement
@@ -835,28 +805,42 @@ dependencies:
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 0.49.1
+        version: 1.12.1
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 0.49.1
+        version: 1.12.1
+- !ruby/object:Gem::Dependency
+  name: rubocop-performance
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: rubocop-require_tools
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 0.1.2
+        version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 0.1.2
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: rb-readline
   requirement: !ruby/object:Gem::Requirement
@@ -1210,6 +1194,7 @@ files:
 - fastlane/lib/fastlane/actions/slather.rb
 - fastlane/lib/fastlane/actions/snapshot.rb
 - fastlane/lib/fastlane/actions/sonar.rb
+- fastlane/lib/fastlane/actions/sourcedocs.rb
 - fastlane/lib/fastlane/actions/spaceship_logs.rb
 - fastlane/lib/fastlane/actions/spaceship_stats.rb
 - fastlane/lib/fastlane/actions/splunkmint.rb
@@ -1295,6 +1280,7 @@ files:
 - fastlane/lib/fastlane/lane_manager_base.rb
 - fastlane/lib/fastlane/markdown_table_formatter.rb
 - fastlane/lib/fastlane/new_action.rb
+- fastlane/lib/fastlane/notification/slack.rb
 - fastlane/lib/fastlane/one_off.rb
 - fastlane/lib/fastlane/other_action.rb
 - fastlane/lib/fastlane/plugins/plugin_fetcher.rb
@@ -1364,6 +1350,7 @@ files:
 - fastlane/swift/MainProcess.swift
 - fastlane/swift/Matchfile.swift
 - fastlane/swift/MatchfileProtocol.swift
+- fastlane/swift/OptionalConfigValue.swift
 - fastlane/swift/Plugins.swift
 - fastlane/swift/Precheckfile.swift
 - fastlane/swift/PrecheckfileProtocol.swift
@@ -1397,6 +1384,7 @@ files:
 - fastlane_core/lib/fastlane_core/android_package_name_guesser.rb
 - fastlane_core/lib/fastlane_core/build_watcher.rb
 - fastlane_core/lib/fastlane_core/cert_checker.rb
+- fastlane_core/lib/fastlane_core/clipboard.rb
 - fastlane_core/lib/fastlane_core/command_executor.rb
 - fastlane_core/lib/fastlane_core/configuration/commander_generator.rb
 - fastlane_core/lib/fastlane_core/configuration/config_item.rb
@@ -1439,6 +1427,8 @@ files:
 - fastlane_core/lib/fastlane_core/ui/errors/fastlane_shell_error.rb
 - fastlane_core/lib/fastlane_core/ui/fastlane_runner.rb
 - fastlane_core/lib/fastlane_core/ui/github_issue_inspector_reporter.rb
+- fastlane_core/lib/fastlane_core/ui/help.erb
+- fastlane_core/lib/fastlane_core/ui/help_formatter.rb
 - fastlane_core/lib/fastlane_core/ui/implementations/shell.rb
 - fastlane_core/lib/fastlane_core/ui/interface.rb
 - fastlane_core/lib/fastlane_core/ui/ui.rb
@@ -1468,7 +1458,6 @@ files:
 - gym/lib/assets/GymfileTemplate.swift
 - gym/lib/assets/wrap_xcodebuild/xcbuild-safe.sh
 - gym/lib/gym.rb
-- gym/lib/gym/.runner.rb.swp
 - gym/lib/gym/code_signing_mapping.rb
 - gym/lib/gym/commands_generator.rb
 - gym/lib/gym/detect_values.rb
@@ -1528,7 +1517,6 @@ files:
 - pilot/lib/pilot/tester_exporter.rb
 - pilot/lib/pilot/tester_importer.rb
 - pilot/lib/pilot/tester_manager.rb
-- pilot/lib/pilot/tester_util.rb
 - precheck/README.md
 - precheck/lib/assets/PrecheckfileTemplate
 - precheck/lib/assets/PrecheckfileTemplate.swift
@@ -1655,6 +1643,7 @@ files:
 - spaceship/lib/spaceship/connect_api/client.rb
 - spaceship/lib/spaceship/connect_api/file_uploader.rb
 - spaceship/lib/spaceship/connect_api/model.rb
+- spaceship/lib/spaceship/connect_api/models/.app.rb.swp
 - spaceship/lib/spaceship/connect_api/models/.app_store_version_submission.rb.swp
 - spaceship/lib/spaceship/connect_api/models/age_rating_declaration.rb
 - spaceship/lib/spaceship/connect_api/models/app.rb
@@ -1865,7 +1854,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: '2.4'
+      version: '2.5'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="