fastlane 2.177.0 → 2.178.0

data/fastlane/lib/fastlane/erb_template_helper.rb

@@ -24,7 +24,13 @@ module Fastlane
     end
 
     def render(template)
-      ERB.new(template, nil, @trim_mode).result(binding)
+      # From Ruby 2.6, ERB.new takes keyword arguments and positional ones are deprecated
+      # https://bugs.ruby-lang.org/issues/14256
+      if Gem::Version.new(RUBY_VERSION) >= Gem::Version.new("2.6.0")
+        ERB.new(template, trim_mode: @trim_mode).result(binding)
+      else
+        ERB.new(template, nil, @trim_mode).result(binding)
+      end
     end
   end
 end

data/fastlane/lib/fastlane/fast_file.rb

@@ -201,13 +201,17 @@ module Fastlane
       # First accepts hash (or named keywords) like other actions
       # Otherwise uses sh method that doesn't have an interface like an action
       if args.count == 1 && args.first.kind_of?(Hash)
-        hash = args.first
-        command = hash.delete(:command)
+        options = args.first
+        command = options.delete(:command)
 
         raise ArgumentError, "sh requires :command keyword in argument" if command.nil?
-
-        new_args = [*command, hash]
-        FastFile.sh(*new_args, &b)
+        log = options[:log].nil? ? true : options[:log]
+        FastFile.sh(*command, step_name: options[:step_name], log: log, error_callback: options[:error_callback], &b)
+      elsif args.count != 1 && args.last.kind_of?(Hash)
+        new_args = args.dup
+        options = new_args.pop
+        log = options[:log].nil? ? true : options[:log]
+        FastFile.sh(*new_args, step_name: options[:step_name], log: log, error_callback: options[:error_callback], &b)
       else
         FastFile.sh(*args, &b)
       end

data/fastlane/lib/fastlane/version.rb

@@ -1,5 +1,5 @@
 module Fastlane
-  VERSION = '2.177.0'.freeze
+  VERSION = '2.178.0'.freeze
   DESCRIPTION = "The easiest way to automate beta deployments and releases for your iOS and Android apps".freeze
   MINIMUM_XCODE_RELEASE = "7.0".freeze
   RUBOCOP_REQUIREMENT = '0.49.1'.freeze

data/fastlane/swift/Deliverfile.swift

@@ -17,4 +17,4 @@ public class Deliverfile: DeliverfileProtocol {
     // during the `init` process, and you won't see this message
 }
 
-// Generated with fastlane 2.177.0
+// Generated with fastlane 2.178.0

data/fastlane/swift/DeliverfileProtocol.swift

@@ -256,4 +256,4 @@ public extension DeliverfileProtocol {
 
 // Please don't remove the lines below
 // They are used to detect outdated files
-// FastlaneRunnerAPIVersion [0.9.60]
+// FastlaneRunnerAPIVersion [0.9.61]

data/fastlane/swift/Fastlane.swift

@@ -2250,6 +2250,7 @@ public func cocoapods(repoUpdate: Bool = false,
     - repositoryName: The path to your repo, e.g. 'fastlane/fastlane'
     - serverUrl: The server url. e.g. 'https://your.internal.github.host/api/v3' (Default: 'https://api.github.com')
     - apiToken: Personal API Token for GitHub - generate one at https://github.com/settings/tokens
+    - apiBearer: Use a Bearer authorization token. Usually generated by Github Apps, e.g. GitHub Actions GITHUB_TOKEN environment variable
     - branch: The branch that the file should be committed on (default: master)
     - path: The relative path to your file from project root e.g. assets/my_app.xcarchive
     - message: The commit message. Defaults to the file name
@@ -2264,7 +2265,8 @@ public func cocoapods(repoUpdate: Bool = false,
  */
 @discardableResult public func commitGithubFile(repositoryName: String,
                                                 serverUrl: String = "https://api.github.com",
-                                                apiToken: String,
+                                                apiToken: String? = nil,
+                                                apiBearer: String? = nil,
                                                 branch: String = "master",
                                                 path: String,
                                                 message: String? = nil,
@@ -2273,6 +2275,7 @@ public func cocoapods(repoUpdate: Bool = false,
     let command = RubyCommand(commandID: "", methodName: "commit_github_file", className: nil, args: [RubyCommand.Argument(name: "repository_name", value: repositoryName),
                                                                                                       RubyCommand.Argument(name: "server_url", value: serverUrl),
                                                                                                       RubyCommand.Argument(name: "api_token", value: apiToken),
+                                                                                                      RubyCommand.Argument(name: "api_bearer", value: apiBearer),
                                                                                                       RubyCommand.Argument(name: "branch", value: branch),
                                                                                                       RubyCommand.Argument(name: "path", value: path),
                                                                                                       RubyCommand.Argument(name: "message", value: message),
@@ -3537,6 +3540,7 @@ public func getCertificates(development: Bool = false,
    - serverUrl: The server url. e.g. 'https://your.github.server/api/v3' (Default: 'https://api.github.com')
    - version: The version tag of the release to check
    - apiToken: GitHub Personal Token (required for private repositories)
+   - apiBearer: Use a Bearer authorization token. Usually generated by Github Apps, e.g. GitHub Actions GITHUB_TOKEN environment variable
 
  This will return all information about a release. For example:|
  |
@@ -3584,12 +3588,14 @@ public func getCertificates(development: Bool = false,
 public func getGithubRelease(url: String,
                              serverUrl: String = "https://api.github.com",
                              version: String,
-                             apiToken: String? = nil)
+                             apiToken: String? = nil,
+                             apiBearer: String? = nil)
 {
     let command = RubyCommand(commandID: "", methodName: "get_github_release", className: nil, args: [RubyCommand.Argument(name: "url", value: url),
                                                                                                       RubyCommand.Argument(name: "server_url", value: serverUrl),
                                                                                                       RubyCommand.Argument(name: "version", value: version),
-                                                                                                      RubyCommand.Argument(name: "api_token", value: apiToken)])
+                                                                                                      RubyCommand.Argument(name: "api_token", value: apiToken),
+                                                                                                      RubyCommand.Argument(name: "api_bearer", value: apiBearer)])
     _ = runner.executeCommand(command)
 }
 
@@ -4511,14 +4517,17 @@ public func importCertificate(certificatePath: String,
 
  - parameters:
    - buildNumber: Change to a specific version. When you provide this parameter, Apple Generic Versioning does not have to be enabled
+   - skipInfoPlist: Don't update Info.plist files when updating the build version
    - xcodeproj: optional, you must specify the path to your main Xcode project if it is not in the project root directory
 
  - returns: The new build number
  */
 @discardableResult public func incrementBuildNumber(buildNumber: Any? = nil,
+                                                    skipInfoPlist: Bool = false,
                                                     xcodeproj: String? = nil) -> String
 {
     let command = RubyCommand(commandID: "", methodName: "increment_build_number", className: nil, args: [RubyCommand.Argument(name: "build_number", value: buildNumber),
+                                                                                                          RubyCommand.Argument(name: "skip_info_plist", value: skipInfoPlist),
                                                                                                           RubyCommand.Argument(name: "xcodeproj", value: xcodeproj)])
     return runner.executeCommand(command)
 }
@@ -5438,7 +5447,7 @@ public func pem(development: Bool = false,
    - distributeOnly: Distribute a previously uploaded build (equivalent to the `fastlane pilot distribute` command)
    - usesNonExemptEncryption: Provide the 'Uses Non-Exempt Encryption' for export compliance. This is used if there is 'ITSAppUsesNonExemptEncryption' is not set in the Info.plist
    - distributeExternal: Should the build be distributed to external testers?
-   - notifyExternalTesters: Should notify external testers?
+   - notifyExternalTesters: Should notify external testers? (Not setting a value will use App Store Connect's default which is to notify)
    - appVersion: The version number of the application build to distribute. If the version number is not specified, then the most recent build uploaded to TestFlight will be distributed. If specified, the most recent build for the version number will be distributed
    - buildNumber: The build number of the application build to distribute. If the build number is not specified, the most recent build is distributed
    - expirePreviousBuilds: Should expire previous builds?
@@ -5478,7 +5487,7 @@ public func pilot(apiKeyPath: String? = nil,
                   distributeOnly: Bool = false,
                   usesNonExemptEncryption: Bool = false,
                   distributeExternal: Bool = false,
-                  notifyExternalTesters: Bool = true,
+                  notifyExternalTesters: Any? = nil,
                   appVersion: String? = nil,
                   buildNumber: String? = nil,
                   expirePreviousBuilds: Bool = false,
@@ -8127,7 +8136,7 @@ public func testfairy(apiKey: String,
    - distributeOnly: Distribute a previously uploaded build (equivalent to the `fastlane pilot distribute` command)
    - usesNonExemptEncryption: Provide the 'Uses Non-Exempt Encryption' for export compliance. This is used if there is 'ITSAppUsesNonExemptEncryption' is not set in the Info.plist
    - distributeExternal: Should the build be distributed to external testers?
-   - notifyExternalTesters: Should notify external testers?
+   - notifyExternalTesters: Should notify external testers? (Not setting a value will use App Store Connect's default which is to notify)
    - appVersion: The version number of the application build to distribute. If the version number is not specified, then the most recent build uploaded to TestFlight will be distributed. If specified, the most recent build for the version number will be distributed
    - buildNumber: The build number of the application build to distribute. If the build number is not specified, the most recent build is distributed
    - expirePreviousBuilds: Should expire previous builds?
@@ -8167,7 +8176,7 @@ public func testflight(apiKeyPath: String? = nil,
                        distributeOnly: Bool = false,
                        usesNonExemptEncryption: Bool = false,
                        distributeExternal: Bool = false,
-                       notifyExternalTesters: Bool = true,
+                       notifyExternalTesters: Any? = nil,
                        appVersion: String? = nil,
                        buildNumber: String? = nil,
                        expirePreviousBuilds: Bool = false,
@@ -9120,7 +9129,7 @@ public func uploadToPlayStoreInternalAppSharing(packageName: String,
    - distributeOnly: Distribute a previously uploaded build (equivalent to the `fastlane pilot distribute` command)
    - usesNonExemptEncryption: Provide the 'Uses Non-Exempt Encryption' for export compliance. This is used if there is 'ITSAppUsesNonExemptEncryption' is not set in the Info.plist
    - distributeExternal: Should the build be distributed to external testers?
-   - notifyExternalTesters: Should notify external testers?
+   - notifyExternalTesters: Should notify external testers? (Not setting a value will use App Store Connect's default which is to notify)
    - appVersion: The version number of the application build to distribute. If the version number is not specified, then the most recent build uploaded to TestFlight will be distributed. If specified, the most recent build for the version number will be distributed
    - buildNumber: The build number of the application build to distribute. If the build number is not specified, the most recent build is distributed
    - expirePreviousBuilds: Should expire previous builds?
@@ -9160,7 +9169,7 @@ public func uploadToTestflight(apiKeyPath: String? = nil,
                                distributeOnly: Bool = false,
                                usesNonExemptEncryption: Bool = false,
                                distributeExternal: Bool = false,
-                               notifyExternalTesters: Bool = true,
+                               notifyExternalTesters: Any? = nil,
                                appVersion: String? = nil,
                                buildNumber: String? = nil,
                                expirePreviousBuilds: Bool = false,
@@ -9519,7 +9528,7 @@ public func xcov(workspace: String? = nil,
                  coverallsServiceJobId: String? = nil,
                  coverallsRepoToken: String? = nil,
                  xcconfig: String? = nil,
-                 ideFoundationPath: String = "/Applications/Xcode-12.4.app/Contents/Developer/../Frameworks/IDEFoundation.framework/Versions/A/IDEFoundation",
+                 ideFoundationPath: String = "/Applications/Xcode-12.2.app/Contents/Developer/../Frameworks/IDEFoundation.framework/Versions/A/IDEFoundation",
                  legacySupport: Bool = false)
 {
     let command = RubyCommand(commandID: "", methodName: "xcov", className: nil, args: [RubyCommand.Argument(name: "workspace", value: workspace),
@@ -9665,4 +9674,4 @@ public let snapshotfile = Snapshotfile()
 
 // Please don't remove the lines below
 // They are used to detect outdated files
-// FastlaneRunnerAPIVersion [0.9.113]
+// FastlaneRunnerAPIVersion [0.9.114]

data/fastlane/swift/Gymfile.swift

@@ -17,4 +17,4 @@ public class Gymfile: GymfileProtocol {
     // during the `init` process, and you won't see this message
 }
 
-// Generated with fastlane 2.177.0
+// Generated with fastlane 2.178.0

data/fastlane/swift/GymfileProtocol.swift

@@ -196,4 +196,4 @@ public extension GymfileProtocol {
 
 // Please don't remove the lines below
 // They are used to detect outdated files
-// FastlaneRunnerAPIVersion [0.9.63]
+// FastlaneRunnerAPIVersion [0.9.64]

data/fastlane/swift/Matchfile.swift

@@ -17,4 +17,4 @@ public class Matchfile: MatchfileProtocol {
     // during the `init` process, and you won't see this message
 }
 
-// Generated with fastlane 2.177.0
+// Generated with fastlane 2.178.0

data/fastlane/swift/MatchfileProtocol.swift

@@ -184,4 +184,4 @@ public extension MatchfileProtocol {
 
 // Please don't remove the lines below
 // They are used to detect outdated files
-// FastlaneRunnerAPIVersion [0.9.57]
+// FastlaneRunnerAPIVersion [0.9.58]

data/fastlane/swift/Precheckfile.swift

@@ -17,4 +17,4 @@ public class Precheckfile: PrecheckfileProtocol {
     // during the `init` process, and you won't see this message
 }
 
-// Generated with fastlane 2.177.0
+// Generated with fastlane 2.178.0

data/fastlane/swift/PrecheckfileProtocol.swift

@@ -52,4 +52,4 @@ public extension PrecheckfileProtocol {
 
 // Please don't remove the lines below
 // They are used to detect outdated files
-// FastlaneRunnerAPIVersion [0.9.56]
+// FastlaneRunnerAPIVersion [0.9.57]

data/fastlane/swift/Scanfile.swift

@@ -17,4 +17,4 @@ public class Scanfile: ScanfileProtocol {
     // during the `init` process, and you won't see this message
 }
 
-// Generated with fastlane 2.177.0
+// Generated with fastlane 2.178.0

data/fastlane/swift/ScanfileProtocol.swift

@@ -288,4 +288,4 @@ public extension ScanfileProtocol {
 
 // Please don't remove the lines below
 // They are used to detect outdated files
-// FastlaneRunnerAPIVersion [0.9.68]
+// FastlaneRunnerAPIVersion [0.9.69]

data/fastlane/swift/Screengrabfile.swift

@@ -17,4 +17,4 @@ public class Screengrabfile: ScreengrabfileProtocol {
     // during the `init` process, and you won't see this message
 }
 
-// Generated with fastlane 2.177.0
+// Generated with fastlane 2.178.0

data/fastlane/swift/ScreengrabfileProtocol.swift

@@ -96,4 +96,4 @@ public extension ScreengrabfileProtocol {
 
 // Please don't remove the lines below
 // They are used to detect outdated files
-// FastlaneRunnerAPIVersion [0.9.58]
+// FastlaneRunnerAPIVersion [0.9.59]

data/fastlane/swift/Snapshotfile.swift

@@ -17,4 +17,4 @@ public class Snapshotfile: SnapshotfileProtocol {
     // during the `init` process, and you won't see this message
 }
 
-// Generated with fastlane 2.177.0
+// Generated with fastlane 2.178.0

data/fastlane/swift/SnapshotfileProtocol.swift

@@ -196,4 +196,4 @@ public extension SnapshotfileProtocol {
 
 // Please don't remove the lines below
 // They are used to detect outdated files
-// FastlaneRunnerAPIVersion [0.9.52]
+// FastlaneRunnerAPIVersion [0.9.53]

data/fastlane/swift/formatting/Brewfile.lock.json

@@ -33,11 +33,11 @@
   "system": {
     "macos": {
       "catalina": {
-        "HOMEBREW_VERSION": "3.0.4-52-gbc37074",
+        "HOMEBREW_VERSION": "3.0.4-64-g31a4989",
         "HOMEBREW_PREFIX": "/usr/local",
-        "Homebrew/homebrew-core": "6de8c1455224f0c7949aa103a6cf5721a7dcdde5",
+        "Homebrew/homebrew-core": "443ddf805144323198a5b37b071516534243377b",
         "CLT": "11.0.33.12",
-        "Xcode": "12.4",
+        "Xcode": "12.2",
         "macOS": "10.15.7"
       },
       "big_sur": {

data/fastlane_core/lib/fastlane_core/itunes_transporter.rb

@@ -94,6 +94,10 @@ module FastlaneCore
       return exit_status.zero?
     end
 
+    def displayable_errors
+      @errors.map { |error| "[Transporter Error Output]: #{error}" }.join("\n").gsub!(/"/, "")
+    end
+
     private
 
     def parse_line(line, hide_output)
@@ -107,7 +111,6 @@ module FastlaneCore
 
       elsif line =~ ERROR_REGEX
         @errors << $1
-        UI.error("[Transporter Error Output]: #{$1}")
 
         # Check if it's a login error
         if $1.include?("Your Apple ID or password was entered incorrectly") ||
@@ -117,9 +120,6 @@ module FastlaneCore
             CredentialsManager::AccountManager.new(user: @user).invalid_credentials
             UI.error("Please run this tool again to apply the new password")
           end
-        elsif $1.include?("Redundant Binary Upload. There already exists a binary upload with build")
-          UI.error($1)
-          UI.error("You have to change the build number of your app to upload your ipa file")
         end
 
         output_done = true
@@ -492,7 +492,7 @@ module FastlaneCore
         result = @transporter_executor.execute(command, ItunesTransporter.hide_transporter_output?)
       rescue TransporterRequiresApplicationSpecificPasswordError => ex
         handle_two_step_failure(ex)
-        return upload(app_id, dir)
+        return upload(app_id, dir, package_path: package_path)
       end
 
       if result
@@ -503,7 +503,11 @@ module FastlaneCore
         handle_error(@password)
       end
 
-      result
+      return result
+    end
+
+    def displayable_errors
+      @transporter_executor.displayable_errors
     end
 
     def provider_ids

data/fastlane_core/lib/fastlane_core/project.rb

@@ -68,22 +68,13 @@ module FastlaneCore
     # Is this project a workspace?
     attr_accessor :is_workspace
 
-    # Should the output of xcodebuild commands be silenced?
-    attr_accessor :xcodebuild_list_silent
-
-    # Should we redirect stderr to /dev/null for xcodebuild commands?
-    # Gets rid of annoying plugin info warnings.
-    attr_accessor :xcodebuild_suppress_stderr
-
     # @param options [FastlaneCore::Configuration|Hash] a set of configuration to run xcodebuild to work out build settings
     # @param xcodebuild_list_silent [Boolean] a flag to silent xcodebuild command's output
     # @param xcodebuild_suppress_stderr [Boolean] a flag to supress output to stderr from xcodebuild
-    def initialize(options, xcodebuild_list_silent: false, xcodebuild_suppress_stderr: false)
+    def initialize(options)
       @options = options
       @path = File.expand_path(self.options[:workspace] || self.options[:project])
       @is_workspace = (self.options[:workspace].to_s.length > 0)
-      @xcodebuild_list_silent = xcodebuild_list_silent
-      @xcodebuild_suppress_stderr = xcodebuild_suppress_stderr
 
       if !path || !File.directory?(path)
         UI.user_error!("Could not find project at path '#{path}'")
@@ -365,14 +356,12 @@ module FastlaneCore
       else
         command = "xcodebuild clean -showBuildSettings #{xcodebuild_parameters.join(' ')}"
       end
-      command += " 2> /dev/null" if xcodebuild_suppress_stderr
       command
     end
 
     def build_xcodebuild_resolvepackagedependencies_command
       return nil if options[:skip_package_dependencies_resolution]
       command = "xcodebuild -resolvePackageDependencies #{xcodebuild_parameters.join(' ')}"
-      command += " 2> /dev/null" if xcodebuild_suppress_stderr
       command
     end
 
@@ -395,7 +384,7 @@ module FastlaneCore
             FastlaneCore::CommandExecutor.execute(
               command: command,
               print_all: true,
-              print_command: !self.xcodebuild_list_silent
+              print_command: true
             )
           else
             UI.important("Skipped Swift Package Manager dependencies resolution.")
@@ -408,7 +397,7 @@ module FastlaneCore
         begin
           timeout = FastlaneCore::Project.xcode_build_settings_timeout
           retries = FastlaneCore::Project.xcode_build_settings_retries
-          @build_settings = FastlaneCore::Project.run_command(command, timeout: timeout, retries: retries, print: !self.xcodebuild_list_silent)
+          @build_settings = FastlaneCore::Project.run_command(command, timeout: timeout, retries: retries, print: true)
           if @build_settings.empty?
             UI.error("Could not read build settings. Make sure that the scheme \"#{options[:scheme]}\" is configured for running by going to Product → Scheme → Edit Scheme…, selecting the \"Build\" section, checking the \"Run\" checkbox and closing the scheme window.")
           end

data/fastlane_core/lib/fastlane_core/ui/interface.rb

@@ -138,7 +138,7 @@ module FastlaneCore
     # Basically this should be used when you actively catch the error
     # and want to show a nice error message to the user
     def user_error!(error_message, options = {})
-      raise FastlaneError.new(options), error_message.to_s
+      raise FastlaneError.new(show_github_issues: options[:show_github_issues], error_info: options[:error_info]), error_message.to_s
     end
 
     # Use this method to exit the program because of a shell command

data/match/lib/match/importer.rb

@@ -149,7 +149,7 @@ module Match
     end
 
     def api_token(params)
-      @api_token ||= Spaceship::ConnectAPI::Token.create(params[:api_key]) if params[:api_key]
+      @api_token ||= Spaceship::ConnectAPI::Token.create(**params[:api_key]) if params[:api_key]
       @api_token ||= Spaceship::ConnectAPI::Token.from_json_file(params[:api_key_path]) if params[:api_key_path]
       return @api_token
     end

data/match/lib/match/migrate.rb

@@ -91,7 +91,7 @@ module Match
     end
 
     def api_token(params)
-      @api_token ||= Spaceship::ConnectAPI::Token.create(params[:api_key]) if params[:api_key]
+      @api_token ||= Spaceship::ConnectAPI::Token.create(**params[:api_key]) if params[:api_key]
       @api_token ||= Spaceship::ConnectAPI::Token.from_json_file(params[:api_key_path]) if params[:api_key_path]
       return @api_token
     end

data/match/lib/match/nuke.rb

@@ -121,7 +121,7 @@ module Match
     end
 
     def api_token
-      @api_token ||= Spaceship::ConnectAPI::Token.create(params[:api_key]) if params[:api_key]
+      @api_token ||= Spaceship::ConnectAPI::Token.create(**params[:api_key]) if params[:api_key]
       @api_token ||= Spaceship::ConnectAPI::Token.from_json_file(params[:api_key_path]) if params[:api_key_path]
       return @api_token
     end

data/match/lib/match/runner.rb

@@ -139,7 +139,7 @@ module Match
     # rubocop:enable Metrics/PerceivedComplexity
 
     def api_token(params)
-      @api_token ||= Spaceship::ConnectAPI::Token.create(params[:api_key]) if params[:api_key]
+      @api_token ||= Spaceship::ConnectAPI::Token.create(**params[:api_key]) if params[:api_key]
       @api_token ||= Spaceship::ConnectAPI::Token.from_json_file(params[:api_key_path]) if params[:api_key_path]
       return @api_token
     end