fastlane 2.165.0 → 2.170.0

data/scan/lib/scan/runner.rb

@@ -83,6 +83,8 @@ module Scan
     end
 
     def handle_results(tests_exit_status)
+      return if Scan.config[:disable_xcpretty]
+
       result = TestResultParser.new.parse_result(test_results)
       SlackPoster.new.run(result)
 
@@ -144,8 +146,6 @@ module Scan
     end
 
     def test_results
-      return if Scan.config[:disable_xcpretty]
-
       temp_junit_report = Scan.cache[:temp_junit_report]
       return File.read(temp_junit_report) if temp_junit_report && File.file?(temp_junit_report)
 

data/scan/lib/scan/test_command_generator.rb

@@ -32,6 +32,7 @@ module Scan
 
       options = []
       options += project_path_array unless config[:xctestrun]
+      options << "-scmProvider system" if config[:use_system_scm]
       options << "-sdk '#{config[:sdk]}'" if config[:sdk]
       options << destination # generated in `detect_values`
       options << "-toolchain '#{config[:toolchain]}'" if config[:toolchain]

data/snapshot/lib/assets/SnapshotHelper.swift

@@ -180,7 +180,11 @@ open class Snapshot: NSObject {
                 simulator = regex.stringByReplacingMatches(in: simulator, range: range, withTemplate: "")
 
                 let path = screenshotsDir.appendingPathComponent("\(simulator)-\(name).png")
-                try image.pngData()?.write(to: path, options: .atomic)
+                #if swift(<5.0)
+                    UIImagePNGRepresentation(image)?.write(to: path, options: .atomic)
+                #else
+                    try image.pngData()?.write(to: path, options: .atomic)
+                #endif
             } catch let error {
                 NSLog("Problem writing screenshot: \(name) to \(screenshotsDir)/\(simulator)-\(name).png")
                 NSLog(error.localizedDescription)

data/snapshot/lib/snapshot/test_command_generator.rb

@@ -13,7 +13,7 @@ module Snapshot
         parts << "xcodebuild"
         parts += options(language, locale)
         parts += destination(devices)
-        parts += build_settings
+        parts += build_settings(language, locale)
         parts += actions
         parts += suffix
         parts += pipe(log_path: log_path)

data/snapshot/lib/snapshot/test_command_generator_base.rb

@@ -40,11 +40,13 @@ module Snapshot
         return options
       end
 
-      def build_settings
+      def build_settings(language, locale)
         config = Snapshot.config
 
         build_settings = []
         build_settings << "FASTLANE_SNAPSHOT=YES"
+        build_settings << "FASTLANE_LANGUAGE=#{language}" if language
+        build_settings << "FASTLANE_LOCALE=#{locale}" if locale
         build_settings << "TEST_TARGET_NAME=#{config[:test_target_name].shellescape}" if config[:test_target_name]
 
         return build_settings

data/snapshot/lib/snapshot/test_command_generator_xcode_8.rb

@@ -14,7 +14,7 @@ module Snapshot
         parts << "xcodebuild"
         parts += options(language, locale)
         parts += destination(device_type)
-        parts += build_settings
+        parts += build_settings(language, locale)
         parts += actions
         parts += suffix
         parts += pipe(device_type, language, locale)

data/spaceship/lib/spaceship/client.rb

@@ -57,6 +57,7 @@ module Spaceship
     InternalServerError = Spaceship::InternalServerError
     BadGatewayError = Spaceship::BadGatewayError
     AccessForbiddenError = Spaceship::AccessForbiddenError
+    TooManyRequestsError = Spaceship::TooManyRequestsError
 
     def self.hostname
       raise "You must implement self.hostname"
@@ -645,6 +646,17 @@ module Spaceship
         retry
       end
       raise ex # re-raise the exception
+    rescue TooManyRequestsError => ex
+      tries -= 1
+      unless tries.zero?
+        msg = "Timeout received: '#{ex.class}', '#{ex.message}'. Retrying after #{ex.retry_after} seconds (remaining: #{tries})..."
+        puts(msg) if Spaceship::Globals.verbose?
+        logger.warn(msg)
+
+        sleep(ex.retry_after) unless Object.const_defined?("SpecHelper")
+        retry
+      end
+      raise ex # re-raise the exception
     rescue \
         Faraday::ParsingError, # <h2>Internal Server Error</h2> with content type json
         InternalServerError => ex
@@ -873,6 +885,8 @@ module Spaceship
           msg = "Access forbidden"
           logger.warn(msg)
           raise AccessForbiddenError.new, msg
+        elsif resp_hash[:status] == 429
+          raise TooManyRequestsError, resp_hash
         end
 
         return response

data/spaceship/lib/spaceship/connect_api.rb

@@ -35,6 +35,12 @@ require 'spaceship/connect_api/models/custom_app_organization'
 require 'spaceship/connect_api/models/custom_app_user'
 require 'spaceship/connect_api/models/pre_release_version'
 
+require 'spaceship/connect_api/models/app_data_usage'
+require 'spaceship/connect_api/models/app_data_usage_category'
+require 'spaceship/connect_api/models/app_data_usage_data_protection'
+require 'spaceship/connect_api/models/app_data_usage_grouping'
+require 'spaceship/connect_api/models/app_data_usage_purposes'
+require 'spaceship/connect_api/models/app_data_usages_publish_state'
 require 'spaceship/connect_api/models/age_rating_declaration'
 require 'spaceship/connect_api/models/app_category'
 require 'spaceship/connect_api/models/app_info'

data/spaceship/lib/spaceship/connect_api/models/age_rating_declaration.rb

@@ -105,9 +105,10 @@ module Spaceship
       # API
       #
 
-      def update(attributes: nil)
+      def update(client: nil, attributes: nil)
+        client ||= Spaceship::ConnectAPI
         attributes = reverse_attr_mapping(attributes)
-        Spaceship::ConnectAPI.patch_age_rating_declaration(age_rating_declaration_id: id, attributes: attributes)
+        client.patch_age_rating_declaration(age_rating_declaration_id: id, attributes: attributes)
       end
     end
   end

data/spaceship/lib/spaceship/connect_api/models/app.rb

@@ -69,19 +69,22 @@ module Spaceship
       # Apps
       #
 
-      def self.all(filter: {}, includes: ESSENTIAL_INCLUDES, limit: nil, sort: nil)
-        resps = Spaceship::ConnectAPI.get_apps(filter: filter, includes: includes, limit: limit, sort: sort).all_pages
+      def self.all(client: nil, filter: {}, includes: ESSENTIAL_INCLUDES, limit: nil, sort: nil)
+        client ||= Spaceship::ConnectAPI
+        resps = client.get_apps(filter: filter, includes: includes, limit: limit, sort: sort).all_pages
         return resps.flat_map(&:to_models)
       end
 
-      def self.find(bundle_id)
-        return all(filter: { bundleId: bundle_id }).find do |app|
+      def self.find(bundle_id, client: nil)
+        client ||= Spaceship::ConnectAPI
+        return all(client: client, filter: { bundleId: bundle_id }).find do |app|
           app.bundle_id == bundle_id
         end
       end
 
-      def self.create(name: nil, version_string: nil, sku: nil, primary_locale: nil, bundle_id: nil, platforms: nil, company_name: nil)
-        Spaceship::ConnectAPI.post_app(
+      def self.create(client: nil, name: nil, version_string: nil, sku: nil, primary_locale: nil, bundle_id: nil, platforms: nil, company_name: nil)
+        client ||= Spaceship::ConnectAPI
+        client.post_app(
           name: name,
           version_string: version_string,
           sku: sku,
@@ -92,35 +95,40 @@ module Spaceship
         )
       end
 
-      def self.get(app_id: nil, includes: "appStoreVersions")
-        return Spaceship::ConnectAPI.get_app(app_id: app_id, includes: includes).first
+      def self.get(client: nil, app_id: nil, includes: "appStoreVersions")
+        client ||= Spaceship::ConnectAPI
+        return client.get_app(app_id: app_id, includes: includes).first
       end
 
-      def update(attributes: nil, app_price_tier_id: nil, territory_ids: nil)
+      def update(client: nil, attributes: nil, app_price_tier_id: nil, territory_ids: nil)
+        client ||= Spaceship::ConnectAPI
         attributes = reverse_attr_mapping(attributes)
-        return Spaceship::ConnectAPI.patch_app(app_id: id, attributes: attributes, app_price_tier_id: app_price_tier_id, territory_ids: territory_ids)
+        return client.patch_app(app_id: id, attributes: attributes, app_price_tier_id: app_price_tier_id, territory_ids: territory_ids)
       end
 
       #
       # App Info
       #
 
-      def fetch_live_app_info(includes: Spaceship::ConnectAPI::AppInfo::ESSENTIAL_INCLUDES)
+      def fetch_live_app_info(client: nil, includes: Spaceship::ConnectAPI::AppInfo::ESSENTIAL_INCLUDES)
+        client ||= Spaceship::ConnectAPI
         states = [
           Spaceship::ConnectAPI::AppInfo::AppStoreState::READY_FOR_SALE,
           Spaceship::ConnectAPI::AppInfo::AppStoreState::PENDING_APPLE_RELEASE,
           Spaceship::ConnectAPI::AppInfo::AppStoreState::PENDING_DEVELOPER_RELEASE,
           Spaceship::ConnectAPI::AppInfo::AppStoreState::PROCESSING_FOR_APP_STORE,
-          Spaceship::ConnectAPI::AppInfo::AppStoreState::IN_REVIEW
+          Spaceship::ConnectAPI::AppInfo::AppStoreState::IN_REVIEW,
+          Spaceship::ConnectAPI::AppInfo::AppStoreState::DEVELOPER_REMOVED_FROM_SALE
         ]
 
-        resp = Spaceship::ConnectAPI.get_app_infos(app_id: id, includes: includes)
+        resp = client.get_app_infos(app_id: id, includes: includes)
         return resp.to_models.select do |model|
           states.include?(model.app_store_state)
         end.first
       end
 
-      def fetch_edit_app_info(includes: Spaceship::ConnectAPI::AppInfo::ESSENTIAL_INCLUDES)
+      def fetch_edit_app_info(client: nil, includes: Spaceship::ConnectAPI::AppInfo::ESSENTIAL_INCLUDES)
+        client ||= Spaceship::ConnectAPI
         states = [
           Spaceship::ConnectAPI::AppInfo::AppStoreState::PREPARE_FOR_SUBMISSION,
           Spaceship::ConnectAPI::AppInfo::AppStoreState::DEVELOPER_REJECTED,
@@ -130,7 +138,7 @@ module Spaceship
           Spaceship::ConnectAPI::AppInfo::AppStoreState::INVALID_BINARY
         ]
 
-        resp = Spaceship::ConnectAPI.get_app_infos(app_id: id, includes: includes)
+        resp = client.get_app_infos(app_id: id, includes: includes)
         return resp.to_models.select do |model|
           states.include?(model.app_store_state)
         end.first
@@ -140,9 +148,10 @@ module Spaceship
       # Available Territories
       #
 
-      def fetch_available_territories(filter: {}, includes: nil, limit: nil, sort: nil)
+      def fetch_available_territories(client: nil, filter: {}, includes: nil, limit: nil, sort: nil)
+        client ||= Spaceship::ConnectAPI
         filter ||= {}
-        resps = Spaceship::ConnectAPI.get_available_territories(app_id: id, filter: filter, includes: includes, limit: limit, sort: sort).all_pages
+        resps = client.get_available_territories(app_id: id, filter: filter, includes: includes, limit: limit, sort: sort).all_pages
         return resps.flat_map(&:to_models)
       end
 
@@ -150,8 +159,9 @@ module Spaceship
       # App Pricing
       #
 
-      def fetch_app_prices(filter: {}, includes: "priceTier", limit: nil, sort: nil)
-        resp = Spaceship::ConnectAPI.get_app_prices(app_id: id, filter: filter, includes: includes, limit: limit, sort: sort)
+      def fetch_app_prices(client: nil, filter: {}, includes: "priceTier", limit: nil, sort: nil)
+        client ||= Spaceship::ConnectAPI
+        resp = client.get_app_prices(app_id: id, filter: filter, includes: includes, limit: limit, sort: sort)
         return resp.to_models
       end
 
@@ -159,7 +169,8 @@ module Spaceship
       # App Store Versions
       #
 
-      def reject_version_if_possible!(platform: nil)
+      def reject_version_if_possible!(client: nil, platform: nil)
+        client ||= Spaceship::ConnectAPI
         platform ||= Spaceship::ConnectAPI::Platform::IOS
         filter = {
           appStoreState: [
@@ -172,7 +183,7 @@ module Spaceship
         }
 
         # Get the latest version
-        version = get_app_store_versions(filter: filter, includes: "appStoreVersionSubmission")
+        version = get_app_store_versions(client: client, filter: filter, includes: "appStoreVersionSubmission")
                   .sort_by { |v| Gem::Version.new(v.version_string) }
                   .last
 
@@ -184,46 +195,53 @@ module Spaceship
       # This will either create a new version or change the version number
       # from an existing version
       # @return (Bool) Was something changed?
-      def ensure_version!(version_string, platform: nil)
+      def ensure_version!(version_string, platform: nil, client: nil)
+        client ||= Spaceship::ConnectAPI
         app_store_version = get_edit_app_store_version(platform: platform)
 
         if app_store_version
           if version_string != app_store_version.version_string
             attributes = { versionString: version_string }
-            app_store_version.update(attributes: attributes)
+            app_store_version.update(client: client, attributes: attributes)
             return true
           end
           return false
         else
           attributes = { versionString: version_string, platform: platform }
-          Spaceship::ConnectAPI.post_app_store_version(app_id: id, attributes: attributes)
+          client.post_app_store_version(app_id: id, attributes: attributes)
 
           return true
         end
       end
 
-      def get_latest_app_store_version(platform: nil, includes: nil)
+      def get_latest_app_store_version(client: nil, platform: nil, includes: nil)
+        client ||= Spaceship::ConnectAPI
         platform ||= Spaceship::ConnectAPI::Platform::IOS
         filter = {
           platform: platform
         }
 
         # Get the latest version
-        return get_app_store_versions(filter: filter, includes: includes)
+        return get_app_store_versions(client: client, filter: filter, includes: includes)
                .sort_by { |v| Date.parse(v.created_date) }
                .last
       end
 
-      def get_live_app_store_version(platform: nil, includes: Spaceship::ConnectAPI::AppStoreVersion::ESSENTIAL_INCLUDES)
+      def get_live_app_store_version(client: nil, platform: nil, includes: Spaceship::ConnectAPI::AppStoreVersion::ESSENTIAL_INCLUDES)
+        client ||= Spaceship::ConnectAPI
         platform ||= Spaceship::ConnectAPI::Platform::IOS
         filter = {
-          appStoreState: Spaceship::ConnectAPI::AppStoreVersion::AppStoreState::READY_FOR_SALE,
+          appStoreState: [
+            Spaceship::ConnectAPI::AppStoreVersion::AppStoreState::READY_FOR_SALE,
+            Spaceship::ConnectAPI::AppStoreVersion::AppStoreState::DEVELOPER_REMOVED_FROM_SALE
+          ].join(","),
           platform: platform
         }
-        return get_app_store_versions(filter: filter, includes: includes).first
+        return get_app_store_versions(client: client, filter: filter, includes: includes).first
       end
 
-      def get_edit_app_store_version(platform: nil, includes: Spaceship::ConnectAPI::AppStoreVersion::ESSENTIAL_INCLUDES)
+      def get_edit_app_store_version(client: nil, platform: nil, includes: Spaceship::ConnectAPI::AppStoreVersion::ESSENTIAL_INCLUDES)
+        client ||= Spaceship::ConnectAPI
         platform ||= Spaceship::ConnectAPI::Platform::IOS
         filter = {
           appStoreState: [
@@ -238,21 +256,23 @@ module Spaceship
         }
 
         # Get the latest version
-        return get_app_store_versions(filter: filter, includes: includes)
+        return get_app_store_versions(client: client, filter: filter, includes: includes)
                .sort_by { |v| Gem::Version.new(v.version_string) }
                .last
       end
 
-      def get_in_review_app_store_version(platform: nil, includes: Spaceship::ConnectAPI::AppStoreVersion::ESSENTIAL_INCLUDES)
+      def get_in_review_app_store_version(client: nil, platform: nil, includes: Spaceship::ConnectAPI::AppStoreVersion::ESSENTIAL_INCLUDES)
+        client ||= Spaceship::ConnectAPI
         platform ||= Spaceship::ConnectAPI::Platform::IOS
         filter = {
           appStoreState: Spaceship::ConnectAPI::AppStoreVersion::AppStoreState::IN_REVIEW,
           platform: platform
         }
-        return get_app_store_versions(filter: filter, includes: includes).first
+        return get_app_store_versions(client: client, filter: filter, includes: includes).first
       end
 
-      def get_pending_release_app_store_version(platform: nil, includes: Spaceship::ConnectAPI::AppStoreVersion::ESSENTIAL_INCLUDES)
+      def get_pending_release_app_store_version(client: nil, platform: nil, includes: Spaceship::ConnectAPI::AppStoreVersion::ESSENTIAL_INCLUDES)
+        client ||= Spaceship::ConnectAPI
         platform ||= Spaceship::ConnectAPI::Platform::IOS
         filter = {
           appStoreState: [
@@ -261,12 +281,18 @@ module Spaceship
           ].join(','),
           platform: platform
         }
-        return get_app_store_versions(filter: filter, includes: includes).first
+        return get_app_store_versions(client: client, filter: filter, includes: includes).first
       end
 
-      def get_app_store_versions(filter: {}, includes: Spaceship::ConnectAPI::AppStoreVersion::ESSENTIAL_INCLUDES, limit: nil, sort: nil)
-        resps = Spaceship::ConnectAPI.get_app_store_versions(app_id: id, filter: filter, includes: includes, limit: limit, sort: sort).all_pages
-        return resps.flat_map(&:to_models)
+      def get_app_store_versions(client: nil, filter: {}, includes: Spaceship::ConnectAPI::AppStoreVersion::ESSENTIAL_INCLUDES, limit: nil, sort: nil)
+        client ||= Spaceship::ConnectAPI
+        if limit.nil?
+          resps = client.get_app_store_versions(app_id: id, filter: filter, includes: includes, limit: limit, sort: sort).all_pages
+          return resps.flat_map(&:to_models)
+        else
+          resp = client.get_app_store_versions(app_id: id, filter: filter, includes: includes, limit: limit, sort: sort)
+          return resp.to_models
+        end
       end
 
       #
@@ -291,11 +317,12 @@ module Spaceship
       # Beta Feedback
       #
 
-      def get_beta_feedback(filter: {}, includes: "tester,build,screenshots", limit: nil, sort: nil)
+      def get_beta_feedback(client: nil, filter: {}, includes: "tester,build,screenshots", limit: nil, sort: nil)
+        client ||= Spaceship::ConnectAPI
         filter ||= {}
         filter["build.app"] = id
 
-        resps = Spaceship::ConnectAPI.get_beta_feedback(filter: filter, includes: includes, limit: limit, sort: sort).all_pages
+        resps = client.get_beta_feedback(filter: filter, includes: includes, limit: limit, sort: sort).all_pages
         return resps.flat_map(&:to_models)
       end
 
@@ -303,11 +330,12 @@ module Spaceship
       # Beta Testers
       #
 
-      def get_beta_testers(filter: {}, includes: nil, limit: nil, sort: nil)
+      def get_beta_testers(client: nil, filter: {}, includes: nil, limit: nil, sort: nil)
+        client ||= Spaceship::ConnectAPI
         filter ||= {}
         filter[:apps] = id
 
-        resps = Spaceship::ConnectAPI.get_beta_testers(filter: filter, includes: includes, limit: limit, sort: sort).all_pages
+        resps = client.get_beta_testers(filter: filter, includes: includes, limit: limit, sort: sort).all_pages
         return resps.flat_map(&:to_models)
       end
 
@@ -315,40 +343,45 @@ module Spaceship
       # Builds
       #
 
-      def get_builds(filter: {}, includes: nil, limit: nil, sort: nil)
+      def get_builds(client: nil, filter: {}, includes: nil, limit: nil, sort: nil)
+        client ||= Spaceship::ConnectAPI
         filter ||= {}
         filter[:app] = id
 
-        resps = Spaceship::ConnectAPI.get_builds(filter: filter, includes: includes, limit: limit, sort: sort).all_pages
+        resps = client.get_builds(filter: filter, includes: includes, limit: limit, sort: sort).all_pages
         return resps.flat_map(&:to_models)
       end
 
-      def get_build_deliveries(filter: {}, includes: nil, limit: nil, sort: nil)
+      def get_build_deliveries(client: nil, filter: {}, includes: nil, limit: nil, sort: nil)
+        client ||= Spaceship::ConnectAPI
         filter ||= {}
         filter[:app] = id
 
-        resps = Spaceship::ConnectAPI.get_build_deliveries(filter: filter, includes: includes, limit: limit, sort: sort).all_pages
+        resps = client.get_build_deliveries(filter: filter, includes: includes, limit: limit, sort: sort).all_pages
         return resps.flat_map(&:to_models)
       end
 
-      def get_beta_app_localizations(filter: {}, includes: nil, limit: nil, sort: nil)
+      def get_beta_app_localizations(client: nil, filter: {}, includes: nil, limit: nil, sort: nil)
+        client ||= Spaceship::ConnectAPI
         filter ||= {}
         filter[:app] = id
 
-        resps = Spaceship::ConnectAPI.get_beta_app_localizations(filter: filter, includes: includes, limit: limit, sort: sort).all_pages
+        resps = client.get_beta_app_localizations(filter: filter, includes: includes, limit: limit, sort: sort).all_pages
         return resps.flat_map(&:to_models)
       end
 
-      def get_beta_groups(filter: {}, includes: nil, limit: nil, sort: nil)
+      def get_beta_groups(client: nil, filter: {}, includes: nil, limit: nil, sort: nil)
+        client ||= Spaceship::ConnectAPI
         filter ||= {}
         filter[:app] = id
 
-        resps = Spaceship::ConnectAPI.get_beta_groups(filter: filter, includes: includes, limit: limit, sort: sort).all_pages
+        resps = client.get_beta_groups(filter: filter, includes: includes, limit: limit, sort: sort).all_pages
         return resps.flat_map(&:to_models)
       end
 
-      def create_beta_group(group_name: nil, public_link_enabled: false, public_link_limit: 10_000, public_link_limit_enabled: false)
-        resps = Spaceship::ConnectAPI.create_beta_group(
+      def create_beta_group(client: nil, group_name: nil, public_link_enabled: false, public_link_limit: 10_000, public_link_limit_enabled: false)
+        client ||= Spaceship::ConnectAPI
+        resps = client.create_beta_group(
           app_id: id,
           group_name: group_name,
           public_link_enabled: public_link_enabled,
@@ -378,9 +411,10 @@ module Spaceship
       # Users
       #
 
-      def add_users(user_ids: nil)
+      def add_users(client: nil, user_ids: nil)
+        client ||= Spaceship::ConnectAPI
         user_ids.each do |user_id|
-          Spaceship::ConnectAPI.add_user_visible_apps(user_id: user_id, app_ids: [id])
+          client.add_user_visible_apps(user_id: user_id, app_ids: [id])
         end
       end
     end