fastlane 2.163.0 → 2.168.0

data/sigh/lib/sigh/runner.rb

@@ -139,7 +139,7 @@ module Sigh
           # Skip certificates that failed to download
           next unless current_cert[:downloaded]
           file = Tempfile.new('cert')
-          file.write(current_cert[:downloaded])
+          file.write(current_cert[:downloaded].force_encoding('UTF-8'))
           file.close
           if FastlaneCore::CertChecker.installed?(file.path)
             installed = true
@@ -303,7 +303,7 @@ module Sigh
         end
 
         if Sigh.config[:cert_owner_name]
-          next unless c.owner_name.strip == Sigh.config[:cert_owner_name].strip
+          next unless c.display_name.strip == Sigh.config[:cert_owner_name].strip
         end
 
         true
@@ -315,7 +315,7 @@ module Sigh
           certificates = certificates.find_all do |c|
             file = Tempfile.new('cert')
             raw_data = Base64.decode64(c.certificate_content)
-            file.write(raw_data)
+            file.write(raw_data.force_encoding("UTF-8"))
             file.close
 
             FastlaneCore::CertChecker.installed?(file.path)
@@ -327,7 +327,7 @@ module Sigh
         UI.important("Found more than one code signing identity. Choosing the first one. Check out `fastlane sigh --help` to see all available options.")
         UI.important("Available Code Signing Identities for current filters:")
         certificates.each do |c|
-          str = ["\t- Name:", c.owner_name, "- ID:", c.id + " - Expires", c.expires.strftime("%d/%m/%Y")].join(" ")
+          str = ["\t- Name:", c.display_name, "- ID:", c.id + " - Expires", c.expires.strftime("%d/%m/%Y")].join(" ")
           UI.message(str.green)
         end
       end

data/snapshot/lib/snapshot/simulator_launchers/simulator_launcher_base.rb

@@ -18,6 +18,7 @@ module Snapshot
 
     def initialize(launcher_configuration: nil)
       @launcher_config = launcher_configuration
+      @device_boot_datetime = DateTime.now
     end
 
     def collected_errors
@@ -192,7 +193,7 @@ module Snapshot
 
         UI.header("Collecting system logs #{device_name} - #{language}")
         log_identity = Digest::MD5.hexdigest(components.join("-"))
-        FastlaneCore::Simulator.copy_logs(device, log_identity, language_folder)
+        FastlaneCore::Simulator.copy_logs(device, log_identity, language_folder, @device_boot_datetime)
       end
     end
   end

data/snapshot/lib/snapshot/test_command_generator.rb

@@ -13,7 +13,7 @@ module Snapshot
         parts << "xcodebuild"
         parts += options(language, locale)
         parts += destination(devices)
-        parts += build_settings
+        parts += build_settings(language, locale)
         parts += actions
         parts += suffix
         parts += pipe(log_path: log_path)

data/snapshot/lib/snapshot/test_command_generator_base.rb

@@ -40,11 +40,13 @@ module Snapshot
         return options
       end
 
-      def build_settings
+      def build_settings(language, locale)
         config = Snapshot.config
 
         build_settings = []
         build_settings << "FASTLANE_SNAPSHOT=YES"
+        build_settings << "FASTLANE_LANGUAGE=#{language}" if language
+        build_settings << "FASTLANE_LOCALE=#{locale}" if locale
         build_settings << "TEST_TARGET_NAME=#{config[:test_target_name].shellescape}" if config[:test_target_name]
 
         return build_settings

data/snapshot/lib/snapshot/test_command_generator_xcode_8.rb

@@ -14,7 +14,7 @@ module Snapshot
         parts << "xcodebuild"
         parts += options(language, locale)
         parts += destination(device_type)
-        parts += build_settings
+        parts += build_settings(language, locale)
         parts += actions
         parts += suffix
         parts += pipe(device_type, language, locale)

data/spaceship/lib/spaceship/connect_api.rb

@@ -31,6 +31,8 @@ require 'spaceship/connect_api/models/beta_tester_metric'
 require 'spaceship/connect_api/models/build'
 require 'spaceship/connect_api/models/build_delivery'
 require 'spaceship/connect_api/models/build_beta_detail'
+require 'spaceship/connect_api/models/custom_app_organization'
+require 'spaceship/connect_api/models/custom_app_user'
 require 'spaceship/connect_api/models/pre_release_version'
 
 require 'spaceship/connect_api/models/age_rating_declaration'

data/spaceship/lib/spaceship/connect_api/client.rb

@@ -13,20 +13,23 @@ module Spaceship
 
       # Initializes client with Apple's App Store Connect JWT auth key.
       #
-      # This method will automatically use the key id, issuer id, and filepath from environment
+      # This method will automatically use the arguments from environment
       # variables if not given.
       #
-      # All three parameters are needed to authenticate.
+      # The key_id, issuer_id and either filepath or key are needed to authenticate.
       #
       # @param key_id (String) (optional): The key id
       # @param issuer_id (String) (optional): The issuer id
       # @param filepath (String) (optional): The filepath
+      # @param key (String) (optional): The key
+      # @param duration (Integer) (optional): How long this session should last
+      # @param in_house (Boolean) (optional): Whether this session is an Enterprise one
       #
       # @raise InvalidUserCredentialsError: raised if authentication failed
       #
       # @return (Spaceship::ConnectAPI::Client) The client the login method was called for
-      def self.auth(key_id: nil, issuer_id: nil, filepath: nil)
-        token = Spaceship::ConnectAPI::Token.create(key_id: key_id, issuer_id: issuer_id, filepath: filepath)
+      def self.auth(key_id: nil, issuer_id: nil, filepath: nil, key: nil, duration: nil, in_house: nil)
+        token = Spaceship::ConnectAPI::Token.create(key_id: key_id, issuer_id: issuer_id, filepath: filepath, key: key, duration: duration, in_house: in_house)
         return ConnectAPI::Client.new(token: token)
       end
 

data/spaceship/lib/spaceship/connect_api/models/age_rating_declaration.rb

@@ -105,9 +105,10 @@ module Spaceship
       # API
       #
 
-      def update(attributes: nil)
+      def update(client: nil, attributes: nil)
+        client ||= Spaceship::ConnectAPI
         attributes = reverse_attr_mapping(attributes)
-        Spaceship::ConnectAPI.patch_age_rating_declaration(age_rating_declaration_id: id, attributes: attributes)
+        client.patch_age_rating_declaration(age_rating_declaration_id: id, attributes: attributes)
       end
     end
   end

data/spaceship/lib/spaceship/connect_api/models/app.rb

@@ -18,11 +18,26 @@ module Spaceship
       attr_accessor :app_store_versions
       attr_accessor :prices
 
+      # Only available with Apple ID auth
+      attr_accessor :distribution_type
+      attr_accessor :educationDiscountType
+
       module ContentRightsDeclaration
         USES_THIRD_PARTY_CONTENT = "USES_THIRD_PARTY_CONTENT"
         DOES_NOT_USE_THIRD_PARTY_CONTENT = "DOES_NOT_USE_THIRD_PARTY_CONTENT"
       end
 
+      module DistributionType
+        APP_STORE = "APP_STORE"
+        CUSTOM = "CUSTOM"
+      end
+
+      module EducationDiscountType
+        DISCOUNTED = "DISCOUNTED"
+        NOT_APPLICABLE = "NOT_APPLICABLE"
+        NOT_DISCOUNTED = "NOT_DISCOUNTED"
+      end
+
       self.attr_mapping({
         "name" => "name",
         "bundleId" => "bundle_id",
@@ -32,6 +47,8 @@ module Spaceship
         "removed" => "removed",
         "isAAG" => "is_aag",
         "availableInNewTerritories" => "available_in_new_territories",
+        "distributionType" => "distribution_type",
+        "educationDiscountType" => "education_discount_type",
 
         "contentRightsDeclaration" => "content_rights_declaration",
 
@@ -52,19 +69,22 @@ module Spaceship
       # Apps
       #
 
-      def self.all(filter: {}, includes: ESSENTIAL_INCLUDES, limit: nil, sort: nil)
-        resps = Spaceship::ConnectAPI.get_apps(filter: filter, includes: includes, limit: limit, sort: sort).all_pages
+      def self.all(client: nil, filter: {}, includes: ESSENTIAL_INCLUDES, limit: nil, sort: nil)
+        client ||= Spaceship::ConnectAPI
+        resps = client.get_apps(filter: filter, includes: includes, limit: limit, sort: sort).all_pages
         return resps.flat_map(&:to_models)
       end
 
-      def self.find(bundle_id)
-        return all(filter: { bundleId: bundle_id }).find do |app|
+      def self.find(bundle_id, client: nil)
+        client ||= Spaceship::ConnectAPI
+        return all(client: client, filter: { bundleId: bundle_id }).find do |app|
           app.bundle_id == bundle_id
         end
       end
 
-      def self.create(name: nil, version_string: nil, sku: nil, primary_locale: nil, bundle_id: nil, platforms: nil, company_name: nil)
-        Spaceship::ConnectAPI.post_app(
+      def self.create(client: nil, name: nil, version_string: nil, sku: nil, primary_locale: nil, bundle_id: nil, platforms: nil, company_name: nil)
+        client ||= Spaceship::ConnectAPI
+        client.post_app(
           name: name,
           version_string: version_string,
           sku: sku,
@@ -75,20 +95,23 @@ module Spaceship
         )
       end
 
-      def self.get(app_id: nil, includes: "appStoreVersions")
-        return Spaceship::ConnectAPI.get_app(app_id: app_id, includes: includes).first
+      def self.get(client: nil, app_id: nil, includes: "appStoreVersions")
+        client ||= Spaceship::ConnectAPI
+        return client.get_app(app_id: app_id, includes: includes).first
       end
 
-      def update(attributes: nil, app_price_tier_id: nil, territory_ids: nil)
+      def update(client: nil, attributes: nil, app_price_tier_id: nil, territory_ids: nil)
+        client ||= Spaceship::ConnectAPI
         attributes = reverse_attr_mapping(attributes)
-        return Spaceship::ConnectAPI.patch_app(app_id: id, attributes: attributes, app_price_tier_id: app_price_tier_id, territory_ids: territory_ids)
+        return client.patch_app(app_id: id, attributes: attributes, app_price_tier_id: app_price_tier_id, territory_ids: territory_ids)
       end
 
       #
       # App Info
       #
 
-      def fetch_live_app_info(includes: Spaceship::ConnectAPI::AppInfo::ESSENTIAL_INCLUDES)
+      def fetch_live_app_info(client: nil, includes: Spaceship::ConnectAPI::AppInfo::ESSENTIAL_INCLUDES)
+        client ||= Spaceship::ConnectAPI
         states = [
           Spaceship::ConnectAPI::AppInfo::AppStoreState::READY_FOR_SALE,
           Spaceship::ConnectAPI::AppInfo::AppStoreState::PENDING_APPLE_RELEASE,
@@ -97,13 +120,14 @@ module Spaceship
           Spaceship::ConnectAPI::AppInfo::AppStoreState::IN_REVIEW
         ]
 
-        resp = Spaceship::ConnectAPI.get_app_infos(app_id: id, includes: includes)
+        resp = client.get_app_infos(app_id: id, includes: includes)
         return resp.to_models.select do |model|
           states.include?(model.app_store_state)
         end.first
       end
 
-      def fetch_edit_app_info(includes: Spaceship::ConnectAPI::AppInfo::ESSENTIAL_INCLUDES)
+      def fetch_edit_app_info(client: nil, includes: Spaceship::ConnectAPI::AppInfo::ESSENTIAL_INCLUDES)
+        client ||= Spaceship::ConnectAPI
         states = [
           Spaceship::ConnectAPI::AppInfo::AppStoreState::PREPARE_FOR_SUBMISSION,
           Spaceship::ConnectAPI::AppInfo::AppStoreState::DEVELOPER_REJECTED,
@@ -113,7 +137,7 @@ module Spaceship
           Spaceship::ConnectAPI::AppInfo::AppStoreState::INVALID_BINARY
         ]
 
-        resp = Spaceship::ConnectAPI.get_app_infos(app_id: id, includes: includes)
+        resp = client.get_app_infos(app_id: id, includes: includes)
         return resp.to_models.select do |model|
           states.include?(model.app_store_state)
         end.first
@@ -123,9 +147,10 @@ module Spaceship
       # Available Territories
       #
 
-      def fetch_available_territories(filter: {}, includes: nil, limit: nil, sort: nil)
+      def fetch_available_territories(client: nil, filter: {}, includes: nil, limit: nil, sort: nil)
+        client ||= Spaceship::ConnectAPI
         filter ||= {}
-        resps = Spaceship::ConnectAPI.get_available_territories(app_id: id, filter: filter, includes: includes, limit: limit, sort: sort).all_pages
+        resps = client.get_available_territories(app_id: id, filter: filter, includes: includes, limit: limit, sort: sort).all_pages
         return resps.flat_map(&:to_models)
       end
 
@@ -133,8 +158,9 @@ module Spaceship
       # App Pricing
       #
 
-      def fetch_app_prices(filter: {}, includes: "priceTier", limit: nil, sort: nil)
-        resp = Spaceship::ConnectAPI.get_app_prices(app_id: id, filter: filter, includes: includes, limit: limit, sort: sort)
+      def fetch_app_prices(client: nil, filter: {}, includes: "priceTier", limit: nil, sort: nil)
+        client ||= Spaceship::ConnectAPI
+        resp = client.get_app_prices(app_id: id, filter: filter, includes: includes, limit: limit, sort: sort)
         return resp.to_models
       end
 
@@ -142,7 +168,8 @@ module Spaceship
       # App Store Versions
       #
 
-      def reject_version_if_possible!(platform: nil)
+      def reject_version_if_possible!(client: nil, platform: nil)
+        client ||= Spaceship::ConnectAPI
         platform ||= Spaceship::ConnectAPI::Platform::IOS
         filter = {
           appStoreState: [
@@ -155,7 +182,7 @@ module Spaceship
         }
 
         # Get the latest version
-        version = get_app_store_versions(filter: filter, includes: "appStoreVersionSubmission")
+        version = get_app_store_versions(client: client, filter: filter, includes: "appStoreVersionSubmission")
                   .sort_by { |v| Gem::Version.new(v.version_string) }
                   .last
 
@@ -167,46 +194,50 @@ module Spaceship
       # This will either create a new version or change the version number
       # from an existing version
       # @return (Bool) Was something changed?
-      def ensure_version!(version_string, platform: nil)
+      def ensure_version!(version_string, platform: nil, client: nil)
+        client ||= Spaceship::ConnectAPI
         app_store_version = get_edit_app_store_version(platform: platform)
 
         if app_store_version
           if version_string != app_store_version.version_string
             attributes = { versionString: version_string }
-            app_store_version.update(attributes: attributes)
+            app_store_version.update(client: client, attributes: attributes)
             return true
           end
           return false
         else
           attributes = { versionString: version_string, platform: platform }
-          Spaceship::ConnectAPI.post_app_store_version(app_id: id, attributes: attributes)
+          client.post_app_store_version(app_id: id, attributes: attributes)
 
           return true
         end
       end
 
-      def get_latest_app_store_version(platform: nil, includes: nil)
+      def get_latest_app_store_version(client: nil, platform: nil, includes: nil)
+        client ||= Spaceship::ConnectAPI
         platform ||= Spaceship::ConnectAPI::Platform::IOS
         filter = {
           platform: platform
         }
 
         # Get the latest version
-        return get_app_store_versions(filter: filter, includes: includes)
+        return get_app_store_versions(client: client, filter: filter, includes: includes)
                .sort_by { |v| Date.parse(v.created_date) }
                .last
       end
 
-      def get_live_app_store_version(platform: nil, includes: Spaceship::ConnectAPI::AppStoreVersion::ESSENTIAL_INCLUDES)
+      def get_live_app_store_version(client: nil, platform: nil, includes: Spaceship::ConnectAPI::AppStoreVersion::ESSENTIAL_INCLUDES)
+        client ||= Spaceship::ConnectAPI
         platform ||= Spaceship::ConnectAPI::Platform::IOS
         filter = {
           appStoreState: Spaceship::ConnectAPI::AppStoreVersion::AppStoreState::READY_FOR_SALE,
           platform: platform
         }
-        return get_app_store_versions(filter: filter, includes: includes).first
+        return get_app_store_versions(client: client, filter: filter, includes: includes).first
       end
 
-      def get_edit_app_store_version(platform: nil, includes: Spaceship::ConnectAPI::AppStoreVersion::ESSENTIAL_INCLUDES)
+      def get_edit_app_store_version(client: nil, platform: nil, includes: Spaceship::ConnectAPI::AppStoreVersion::ESSENTIAL_INCLUDES)
+        client ||= Spaceship::ConnectAPI
         platform ||= Spaceship::ConnectAPI::Platform::IOS
         filter = {
           appStoreState: [
@@ -221,21 +252,23 @@ module Spaceship
         }
 
         # Get the latest version
-        return get_app_store_versions(filter: filter, includes: includes)
+        return get_app_store_versions(client: client, filter: filter, includes: includes)
                .sort_by { |v| Gem::Version.new(v.version_string) }
                .last
       end
 
-      def get_in_review_app_store_version(platform: nil, includes: Spaceship::ConnectAPI::AppStoreVersion::ESSENTIAL_INCLUDES)
+      def get_in_review_app_store_version(client: nil, platform: nil, includes: Spaceship::ConnectAPI::AppStoreVersion::ESSENTIAL_INCLUDES)
+        client ||= Spaceship::ConnectAPI
         platform ||= Spaceship::ConnectAPI::Platform::IOS
         filter = {
           appStoreState: Spaceship::ConnectAPI::AppStoreVersion::AppStoreState::IN_REVIEW,
           platform: platform
         }
-        return get_app_store_versions(filter: filter, includes: includes).first
+        return get_app_store_versions(client: client, filter: filter, includes: includes).first
       end
 
-      def get_pending_release_app_store_version(platform: nil, includes: Spaceship::ConnectAPI::AppStoreVersion::ESSENTIAL_INCLUDES)
+      def get_pending_release_app_store_version(client: nil, platform: nil, includes: Spaceship::ConnectAPI::AppStoreVersion::ESSENTIAL_INCLUDES)
+        client ||= Spaceship::ConnectAPI
         platform ||= Spaceship::ConnectAPI::Platform::IOS
         filter = {
           appStoreState: [
@@ -244,23 +277,43 @@ module Spaceship
           ].join(','),
           platform: platform
         }
-        return get_app_store_versions(filter: filter, includes: includes).first
+        return get_app_store_versions(client: client, filter: filter, includes: includes).first
       end
 
-      def get_app_store_versions(filter: {}, includes: Spaceship::ConnectAPI::AppStoreVersion::ESSENTIAL_INCLUDES, limit: nil, sort: nil)
-        resps = Spaceship::ConnectAPI.get_app_store_versions(app_id: id, filter: filter, includes: includes, limit: limit, sort: sort).all_pages
+      def get_app_store_versions(client: nil, filter: {}, includes: Spaceship::ConnectAPI::AppStoreVersion::ESSENTIAL_INCLUDES, limit: nil, sort: nil)
+        client ||= Spaceship::ConnectAPI
+        resps = client.get_app_store_versions(app_id: id, filter: filter, includes: includes, limit: limit, sort: sort).all_pages
         return resps.flat_map(&:to_models)
       end
 
+      #
+      # B2B
+      #
+
+      def disable_b2b
+        update(attributes: {
+          distributionType: DistributionType::APP_STORE,
+          education_discount_type: EducationDiscountType::NOT_DISCOUNTED
+        })
+      end
+
+      def enable_b2b
+        update(attributes: {
+          distributionType: App::DistributionType::CUSTOM,
+          education_discount_type: EducationDiscountType::NOT_APPLICABLE
+        })
+      end
+
       #
       # Beta Feedback
       #
 
-      def get_beta_feedback(filter: {}, includes: "tester,build,screenshots", limit: nil, sort: nil)
+      def get_beta_feedback(client: nil, filter: {}, includes: "tester,build,screenshots", limit: nil, sort: nil)
+        client ||= Spaceship::ConnectAPI
         filter ||= {}
         filter["build.app"] = id
 
-        resps = Spaceship::ConnectAPI.get_beta_feedback(filter: filter, includes: includes, limit: limit, sort: sort).all_pages
+        resps = client.get_beta_feedback(filter: filter, includes: includes, limit: limit, sort: sort).all_pages
         return resps.flat_map(&:to_models)
       end
 
@@ -268,11 +321,12 @@ module Spaceship
       # Beta Testers
       #
 
-      def get_beta_testers(filter: {}, includes: nil, limit: nil, sort: nil)
+      def get_beta_testers(client: nil, filter: {}, includes: nil, limit: nil, sort: nil)
+        client ||= Spaceship::ConnectAPI
         filter ||= {}
         filter[:apps] = id
 
-        resps = Spaceship::ConnectAPI.get_beta_testers(filter: filter, includes: includes, limit: limit, sort: sort).all_pages
+        resps = client.get_beta_testers(filter: filter, includes: includes, limit: limit, sort: sort).all_pages
         return resps.flat_map(&:to_models)
       end
 
@@ -280,40 +334,45 @@ module Spaceship
       # Builds
       #
 
-      def get_builds(filter: {}, includes: nil, limit: nil, sort: nil)
+      def get_builds(client: nil, filter: {}, includes: nil, limit: nil, sort: nil)
+        client ||= Spaceship::ConnectAPI
         filter ||= {}
         filter[:app] = id
 
-        resps = Spaceship::ConnectAPI.get_builds(filter: filter, includes: includes, limit: limit, sort: sort).all_pages
+        resps = client.get_builds(filter: filter, includes: includes, limit: limit, sort: sort).all_pages
         return resps.flat_map(&:to_models)
       end
 
-      def get_build_deliveries(filter: {}, includes: nil, limit: nil, sort: nil)
+      def get_build_deliveries(client: nil, filter: {}, includes: nil, limit: nil, sort: nil)
+        client ||= Spaceship::ConnectAPI
         filter ||= {}
         filter[:app] = id
 
-        resps = Spaceship::ConnectAPI.get_build_deliveries(filter: filter, includes: includes, limit: limit, sort: sort).all_pages
+        resps = client.get_build_deliveries(filter: filter, includes: includes, limit: limit, sort: sort).all_pages
         return resps.flat_map(&:to_models)
       end
 
-      def get_beta_app_localizations(filter: {}, includes: nil, limit: nil, sort: nil)
+      def get_beta_app_localizations(client: nil, filter: {}, includes: nil, limit: nil, sort: nil)
+        client ||= Spaceship::ConnectAPI
         filter ||= {}
         filter[:app] = id
 
-        resps = Spaceship::ConnectAPI.get_beta_app_localizations(filter: filter, includes: includes, limit: limit, sort: sort).all_pages
+        resps = client.get_beta_app_localizations(filter: filter, includes: includes, limit: limit, sort: sort).all_pages
         return resps.flat_map(&:to_models)
       end
 
-      def get_beta_groups(filter: {}, includes: nil, limit: nil, sort: nil)
+      def get_beta_groups(client: nil, filter: {}, includes: nil, limit: nil, sort: nil)
+        client ||= Spaceship::ConnectAPI
         filter ||= {}
         filter[:app] = id
 
-        resps = Spaceship::ConnectAPI.get_beta_groups(filter: filter, includes: includes, limit: limit, sort: sort).all_pages
+        resps = client.get_beta_groups(filter: filter, includes: includes, limit: limit, sort: sort).all_pages
         return resps.flat_map(&:to_models)
       end
 
-      def create_beta_group(group_name: nil, public_link_enabled: false, public_link_limit: 10_000, public_link_limit_enabled: false)
-        resps = Spaceship::ConnectAPI.create_beta_group(
+      def create_beta_group(client: nil, group_name: nil, public_link_enabled: false, public_link_limit: 10_000, public_link_limit_enabled: false)
+        client ||= Spaceship::ConnectAPI
+        resps = client.create_beta_group(
           app_id: id,
           group_name: group_name,
           public_link_enabled: public_link_enabled,
@@ -323,13 +382,30 @@ module Spaceship
         return resps.flat_map(&:to_models).first
       end
 
+      #
+      # Education
+      #
+
+      def disable_educational_discount
+        update(attributes: {
+          education_discount_type: EducationDiscountType::NOT_DISCOUNTED
+        })
+      end
+
+      def enable_educational_discount
+        update(attributes: {
+          education_discount_type: EducationDiscountType::DISCOUNTED
+        })
+      end
+
       #
       # Users
       #
 
-      def add_users(user_ids: nil)
+      def add_users(client: nil, user_ids: nil)
+        client ||= Spaceship::ConnectAPI
         user_ids.each do |user_id|
-          Spaceship::ConnectAPI.add_user_visible_apps(user_id: user_id, app_ids: [id])
+          client.add_user_visible_apps(user_id: user_id, app_ids: [id])
         end
       end
     end