fastlane 2.16.0 → 2.17.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 8b23a6ac1c98d9099fd80546792028a9577636ef
-  data.tar.gz: 348db27cd92fa4d8ee520232af4e46e024d77c85
+  metadata.gz: c2018da1149a04271e1861829b2c3174e3fbffa9
+  data.tar.gz: 009843a49c26bc5e69a8741563dce459efea763c
 SHA512:
-  metadata.gz: b7ae6adfd2c431a9f0d98f5d4919a04a94babb87b8669f267de8bd3fb3c028710feb5a72e806960f048947bfadfc9fd3a7e20b393c0b242d8269424cef6e87b3
-  data.tar.gz: 42170999f744728ccda59909a0242b81f7ce8ffcee2b37e98e9d9e6262c90e588618f02b3cf5f8522f2bdae1fc735e224665837c60c13eaa78a27e607c19a271
+  metadata.gz: 8b5fac2721f6284bf23a447e2463d9d7c5ad2a51e44e1c72441b5a6fd5ce9c468d8070881370111fbfe9e19188e62277596c0c5440383455d422df741205dc60
+  data.tar.gz: fa94f1bc432ccd8ab9257a7478d8dfed2ce5267a04a671b3ab7b18206d0dd560a8c37de9199006a8ca6e9ef8f0ba06013d977bf506e8484fb940b5b5d4acb5ed

data/cert/lib/cert/commands_generator.rb

@@ -22,12 +22,12 @@ module Cert
 
       global_option('--verbose') { FastlaneCore::Globals.verbose = true }
 
-      FastlaneCore::CommanderGenerator.new.generate(Cert::Options.available_options)
-
       command :create do |c|
         c.syntax = 'fastlane cert create'
         c.description = 'Create new iOS code signing certificates'
 
+        FastlaneCore::CommanderGenerator.new.generate(Cert::Options.available_options, command: c)
+
         c.action do |args, options|
           Cert.config = FastlaneCore::Configuration.create(Cert::Options.available_options, options.__hash__)
           Cert::Runner.new.launch
@@ -38,6 +38,8 @@ module Cert
         c.syntax = 'fastlane cert revoke_expired'
         c.description = 'Revoke expired iOS code signing certificates'
 
+        FastlaneCore::CommanderGenerator.new.generate(Cert::Options.available_options, command: c)
+
         c.action do |args, options|
           Cert.config = FastlaneCore::Configuration.create(Cert::Options.available_options, options.__hash__)
           Cert::Runner.new.revoke_expired_certs!

data/deliver/lib/deliver/commands_generator.rb

@@ -37,8 +37,6 @@ module Deliver
       program :help, 'GitHub', 'https://github.com/fastlane/fastlane/tree/master/deliver'
       program :help_formatter, :compact
 
-      FastlaneCore::CommanderGenerator.new.generate(deliverfile_options)
-
       global_option('--verbose') { FastlaneCore::Globals.verbose = true }
 
       always_trace!
@@ -46,6 +44,9 @@ module Deliver
       command :run do |c|
         c.syntax = 'fastlane deliver'
         c.description = 'Upload metadata and binary to iTunes Connect'
+
+        FastlaneCore::CommanderGenerator.new.generate(deliverfile_options, command: c)
+
         c.action do |args, options|
           options = FastlaneCore::Configuration.create(deliverfile_options, options.__hash__)
           loaded = options.load_configuration_file("Deliverfile")
@@ -62,9 +63,13 @@ module Deliver
           Deliver::Runner.new(options).run
         end
       end
+
       command :submit_build do |c|
         c.syntax = 'fastlane deliver submit_build'
         c.description = 'Submit a specific build-nr for review, use latest for the latest build'
+
+        FastlaneCore::CommanderGenerator.new.generate(deliverfile_options, command: c)
+
         c.action do |args, options|
           options = FastlaneCore::Configuration.create(deliverfile_options, options.__hash__)
           options.load_configuration_file("Deliverfile")
@@ -73,9 +78,13 @@ module Deliver
           Deliver::Runner.new(options).run
         end
       end
+
       command :init do |c|
         c.syntax = 'fastlane deliver init'
         c.description = 'Create the initial `deliver` configuration based on an existing app'
+
+        FastlaneCore::CommanderGenerator.new.generate(deliverfile_options, command: c)
+
         c.action do |args, options|
           if File.exist?("Deliverfile") or File.exist?("fastlane/Deliverfile")
             UI.important("You already have a running deliver setup in this directory")
@@ -92,6 +101,9 @@ module Deliver
       command :generate_summary do |c|
         c.syntax = 'fastlane deliver generate_summary'
         c.description = 'Generate HTML Summary without uploading/downloading anything'
+
+        FastlaneCore::CommanderGenerator.new.generate(deliverfile_options, command: c)
+
         c.action do |args, options|
           options = FastlaneCore::Configuration.create(deliverfile_options, options.__hash__)
           options.load_configuration_file("Deliverfile")
@@ -106,6 +118,8 @@ module Deliver
         c.syntax = 'fastlane deliver download_screenshots'
         c.description = "Downloads all existing screenshots from iTunes Connect and stores them in the screenshots folder"
 
+        FastlaneCore::CommanderGenerator.new.generate(deliverfile_options, command: c)
+
         c.action do |args, options|
           options = FastlaneCore::Configuration.create(deliverfile_options(skip_verification: true), options.__hash__)
           options.load_configuration_file("Deliverfile")
@@ -120,6 +134,8 @@ module Deliver
         c.syntax = 'fastlane deliver download_metadata'
         c.description = "Downloads existing metadata and stores it locally. This overwrites the local files."
 
+        FastlaneCore::CommanderGenerator.new.generate(deliverfile_options, command: c)
+
         c.action do |args, options|
           options = FastlaneCore::Configuration.create(deliverfile_options(skip_verification: true), options.__hash__)
           options.load_configuration_file("Deliverfile")

data/deliver/lib/deliver/detect_values.rb

@@ -20,7 +20,8 @@ module Deliver
 
       options[:app_identifier] = identifier if identifier.to_s.length > 0
       options[:app_identifier] ||= UI.input("The Bundle Identifier of your App: ")
-    rescue
+    rescue => ex
+      UI.error(ex)
       UI.user_error!("Could not infer your App's Bundle Identifier")
     end
 
@@ -54,7 +55,8 @@ module Deliver
       elsif options[:pkg]
         options[:app_version] ||= FastlaneCore::PkgFileAnalyser.fetch_app_version(options[:pkg])
       end
-    rescue
+    rescue => ex
+      UI.error(ex)
       UI.user_error!("Could not infer your app's version")
     end
 

data/fastlane/lib/fastlane/version.rb

@@ -1,4 +1,4 @@
 module Fastlane
-  VERSION = '2.16.0'.freeze
+  VERSION = '2.17.0'.freeze
   DESCRIPTION = "The easiest way to automate beta deployments and releases for your iOS and Android apps".freeze
 end

data/spaceship/lib/spaceship/portal/portal_client.rb

@@ -26,7 +26,7 @@ module Spaceship
     # @return (Array) A list of all available teams
     def teams
       return @teams if @teams
-      req = request(:post, "https://developerservices2.apple.com/services/QH65B2/listTeams.action")
+      req = request(:post, "account/listTeams.action")
       @teams = parse_response(req, 'teams').sort_by do |team|
         [
           team['name'],
@@ -363,16 +363,15 @@ module Spaceship
     def create_device!(device_name, device_id, mac: false)
       ensure_csrf(Spaceship::Device)
 
-      req = request(:post) do |r|
-        r.url "https://developerservices2.apple.com/services/#{PROTOCOL_VERSION}/#{platform_slug(mac)}/addDevice.action"
-        r.params = {
-          teamId: team_id,
-          deviceNumber: device_id,
-          name: device_name
-        }
-      end
+      req = request(:post, "account/#{platform_slug(mac)}/device/addDevices.action", {
+        teamId: team_id,
+        deviceClasses: mac ? 'mac' : 'iphone',
+        deviceNumbers: device_id,
+        deviceNames: device_name,
+        register: 'single'
+      })
 
-      parse_response(req, 'device')
+      parse_response(req, 'devices').first
     end
 
     def disable_device!(device_id, device_udid, mac: false)
@@ -452,16 +451,18 @@ module Spaceship
     #####################################################
 
     def provisioning_profiles(mac: false)
-      req = request(:post) do |r|
-        r.url "https://developerservices2.apple.com/services/#{PROTOCOL_VERSION}/#{platform_slug(mac)}/listProvisioningProfiles.action"
-        r.params = {
+      paging do |page_number|
+        req = request(:post, "account/#{platform_slug(mac)}/profile/listProvisioningProfiles.action", {
           teamId: team_id,
+          pageNumber: page_number,
+          pageSize: page_size,
+          sort: 'name=asc',
           includeInactiveProfiles: true,
           onlyCountLists: true
-        }
-      end
+        })
 
-      parse_response(req, 'provisioningProfiles')
+        parse_response(req, 'provisioningProfiles')
+      end
     end
 
     def provisioning_profile_details(provisioning_profile_id: nil, mac: false)
@@ -473,9 +474,7 @@ module Spaceship
     end
 
     def create_provisioning_profile!(name, distribution_method, app_id, certificate_ids, device_ids, mac: false, sub_platform: nil)
-      ensure_csrf(Spaceship::ProvisioningProfile) do
-        fetch_csrf_token_for_provisioning
-      end
+      ensure_csrf(Spaceship::ProvisioningProfile)
 
       params = {
         teamId: team_id,
@@ -492,9 +491,7 @@ module Spaceship
     end
 
     def download_provisioning_profile(profile_id, mac: false)
-      ensure_csrf(Spaceship::ProvisioningProfile) do
-        fetch_csrf_token_for_provisioning
-      end
+      ensure_csrf(Spaceship::ProvisioningProfile)
 
       r = request(:get, "account/#{platform_slug(mac)}/profile/downloadProfileContent", {
         teamId: team_id,
@@ -509,9 +506,7 @@ module Spaceship
     end
 
     def delete_provisioning_profile!(profile_id, mac: false)
-      ensure_csrf(Spaceship::ProvisioningProfile) do
-        fetch_csrf_token_for_provisioning
-      end
+      ensure_csrf(Spaceship::ProvisioningProfile)
 
       r = request(:post, "account/#{platform_slug(mac)}/profile/deleteProvisioningProfile.action", {
         teamId: team_id,
@@ -521,9 +516,7 @@ module Spaceship
     end
 
     def repair_provisioning_profile!(profile_id, name, distribution_method, app_id, certificate_ids, device_ids, mac: false, sub_platform: nil)
-      ensure_csrf(Spaceship::ProvisioningProfile) do
-        fetch_csrf_token_for_provisioning
-      end
+      ensure_csrf(Spaceship::ProvisioningProfile)
 
       params = {
           teamId: team_id,
@@ -541,27 +534,6 @@ module Spaceship
       parse_response(r, 'provisioningProfile')
     end
 
-    # We need a custom way to fetch the csrf token for the provisioning profile requests, since
-    # we use a separate API endpoint (host of Xcode API) to fetch the provisioning profiles
-    # All we do is fetch one profile (if exists) to get a valid csrf token with its time stamp
-    # This method is being called from all requests that modify, create or downloading provisioning
-    # profiles.
-    # Source https://github.com/fastlane/fastlane/issues/5903
-    def fetch_csrf_token_for_provisioning(mac: false)
-      req = request(:post) do |r|
-        r.url "https://developer.apple.com/services-account/#{PROTOCOL_VERSION}/account/#{platform_slug(mac)}/profile/listProvisioningProfiles.action"
-        r.params = {
-          teamId: team_id,
-          pageSize: 1,
-          pageNumber: 1,
-          sort: "name=asc"
-        }
-      end
-
-      parse_response(req, 'provisioningProfiles')
-      return nil
-    end
-
     private
 
     # This is a cache of entity type (App, AppGroup, Certificate, Device) to csrf_tokens

data/spaceship/lib/spaceship/portal/provisioning_profile.rb

@@ -174,9 +174,6 @@ module Spaceship
                     raise "Can't find class '#{attrs['distributionMethod']}'"
                   end
 
-          # eagerload the Apps using the same client if we have to.
-          attrs['appId'] = App.set_client(@client).factory(attrs['appId'])
-
           klass.client = @client
           obj = klass.new(attrs)
 
@@ -258,14 +255,18 @@ module Spaceship
         #  If you're calling this from a subclass (like AdHoc), this will
         #  only return the profiles that are of this type
         # @param mac (Bool) (optional): Pass true to get all Mac provisioning profiles
-        # @param xcode (Bool) (optional): Pass true to include Xcode managed provisioning profiles
+        # @param xcode DEPRECATED
         def all(mac: false, xcode: false)
           profiles = client.provisioning_profiles(mac: mac).map do |profile|
             self.factory(profile)
           end
 
           # filter out the profiles managed by xcode
-          profiles.delete_if(&:managed_by_xcode?) unless xcode
+          if xcode
+            warn('Apple API no longer returns XCode managed Provisioning Profiles')
+          else
+            profiles.delete_if(&:managed_by_xcode?)
+          end
 
           return profiles if self == ProvisioningProfile
 
@@ -474,7 +475,13 @@ module Spaceship
           end
         end
 
-        return @certificates
+        @certificates
+      end
+
+      def app
+        fetch_details
+
+        App.set_client(client).new(profile_details['appId'])
       end
 
       # @return (Bool) Is this current provisioning profile adhoc?

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: fastlane
 version: !ruby/object:Gem::Version
-  version: 2.16.0
+  version: 2.17.0
 platform: ruby
 authors:
 - Felix Krause
@@ -14,7 +14,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-02-14 00:00:00.000000000 Z
+date: 2017-02-15 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: slack-notifier