fastlane 2.157.3 → 2.161.0

data/fastlane/swift/Runner.swift

@@ -1,9 +1,5 @@
-//
-//  Runner.swift
-//  FastlaneSwiftRunner
-//
-//  Created by Joshua Liebowitz on 8/26/17.
-//
+// Runner.swift
+// Copyright (c) 2020 FastlaneTools
 
 //
 //  ** NOTE **
@@ -29,7 +25,7 @@ func desc(_: String) {
 class Runner {
     private var thread: Thread!
     private var socketClient: SocketClient!
-    private let dispatchGroup: DispatchGroup = DispatchGroup()
+    private let dispatchGroup = DispatchGroup()
     private var returnValue: String? // lol, so safe
     private var currentlyExecutingCommand: RubyCommandable?
     private var shouldLeaveDispatchGroupDuringDisconnect = false
@@ -42,7 +38,7 @@ class Runner {
 
         let secondsToWait = DispatchTimeInterval.seconds(SocketClient.defaultCommandTimeoutSeconds)
         // swiftlint:disable next
-        let timeoutResult = waitWithPolling(self.executeNext[command.id], toEventually: { $0 == true }, timeout: SocketClient.defaultCommandTimeoutSeconds)
+        let timeoutResult = Self.waitWithPolling(self.executeNext[command.id], toEventually: { $0 == true }, timeout: SocketClient.defaultCommandTimeoutSeconds)
         executeNext.removeValue(forKey: command.id)
         let failureMessage = "command didn't execute in: \(SocketClient.defaultCommandTimeoutSeconds) seconds"
         let success = testDispatchTimeoutResult(timeoutResult, failureMessage: failureMessage, timeToWait: secondsToWait)
@@ -58,7 +54,7 @@ class Runner {
         }
     }
 
-    private func waitWithPolling<T>(_ expression: @autoclosure @escaping () throws -> T, toEventually predicate: @escaping (T) -> Bool, timeout: Int, pollingInterval: DispatchTimeInterval = .milliseconds(4)) -> DispatchTimeoutResult {
+    static func waitWithPolling<T>(_ expression: @autoclosure @escaping () throws -> T, toEventually predicate: @escaping (T) -> Bool, timeout: Int, pollingInterval: DispatchTimeInterval = .milliseconds(4)) -> DispatchTimeoutResult {
         func memoizedClosure<T>(_ closure: @escaping () throws -> T) -> (Bool) throws -> T {
             var cache: T?
             return { withoutCaching in

data/fastlane/swift/RunnerArgument.swift

@@ -1,9 +1,5 @@
-//
-//  RunnerArgument.swift
-//  FastlaneSwiftRunner
-//
-//  Created by Joshua Liebowitz on 9/1/17.
-//
+// RunnerArgument.swift
+// Copyright (c) 2020 FastlaneTools
 
 //
 //  ** NOTE **

data/fastlane/swift/Scanfile.swift

@@ -1,3 +1,6 @@
+// Scanfile.swift
+// Copyright (c) 2020 FastlaneTools
+
 // This class is automatically included in FastlaneRunner during build
 
 // This autogenerated file will be overwritten or replaced during build time, or when you initialize `scan`
@@ -8,10 +11,10 @@
 //  new group so that it won't be marked for upgrade
 //
 
-class Scanfile: ScanfileProtocol {
+public class Scanfile: ScanfileProtocol {
     // If you want to enable `scan`, run `fastlane scan init`
     // After, this file will be replaced with a custom implementation that contains values you supplied
     // during the `init` process, and you won't see this message
 }
 
-// Generated with fastlane 2.157.3
+// Generated with fastlane 2.161.0

data/fastlane/swift/ScanfileProtocol.swift

@@ -1,4 +1,7 @@
-protocol ScanfileProtocol: class {
+// ScanfileProtocol.swift
+// Copyright (c) 2020 FastlaneTools
+
+public protocol ScanfileProtocol: class {
     /// Path to the workspace file
     var workspace: String? { get }
 
@@ -189,7 +192,7 @@ protocol ScanfileProtocol: class {
     var failBuild: Bool { get }
 }
 
-extension ScanfileProtocol {
+public extension ScanfileProtocol {
     var workspace: String? { return nil }
     var project: String? { return nil }
     var scheme: String? { return nil }
@@ -257,4 +260,4 @@ extension ScanfileProtocol {
 
 // Please don't remove the lines below
 // They are used to detect outdated files
-// FastlaneRunnerAPIVersion [0.9.46]
+// FastlaneRunnerAPIVersion [0.9.52]

data/fastlane/swift/Screengrabfile.swift

@@ -1,3 +1,6 @@
+// Screengrabfile.swift
+// Copyright (c) 2020 FastlaneTools
+
 // This class is automatically included in FastlaneRunner during build
 
 // This autogenerated file will be overwritten or replaced during build time, or when you initialize `screengrab`
@@ -8,10 +11,10 @@
 //  new group so that it won't be marked for upgrade
 //
 
-class Screengrabfile: ScreengrabfileProtocol {
+public class Screengrabfile: ScreengrabfileProtocol {
     // If you want to enable `screengrab`, run `fastlane screengrab init`
     // After, this file will be replaced with a custom implementation that contains values you supplied
     // during the `init` process, and you won't see this message
 }
 
-// Generated with fastlane 2.157.3
+// Generated with fastlane 2.161.0

data/fastlane/swift/ScreengrabfileProtocol.swift

@@ -1,4 +1,7 @@
-protocol ScreengrabfileProtocol: class {
+// ScreengrabfileProtocol.swift
+// Copyright (c) 2020 FastlaneTools
+
+public protocol ScreengrabfileProtocol: class {
     /// Path to the root of your Android SDK installation, e.g. ~/tools/android-sdk-macosx
     var androidHome: String? { get }
 
@@ -66,7 +69,7 @@ protocol ScreengrabfileProtocol: class {
     var adbHost: String? { get }
 }
 
-extension ScreengrabfileProtocol {
+public extension ScreengrabfileProtocol {
     var androidHome: String? { return nil }
     var buildToolsVersion: String? { return nil }
     var locales: [String] { return ["en-US"] }
@@ -93,4 +96,4 @@ extension ScreengrabfileProtocol {
 
 // Please don't remove the lines below
 // They are used to detect outdated files
-// FastlaneRunnerAPIVersion [0.9.36]
+// FastlaneRunnerAPIVersion [0.9.42]

data/fastlane/swift/Snapshotfile.swift

@@ -1,3 +1,6 @@
+// Snapshotfile.swift
+// Copyright (c) 2020 FastlaneTools
+
 // This class is automatically included in FastlaneRunner during build
 
 // This autogenerated file will be overwritten or replaced during build time, or when you initialize `snapshot`
@@ -8,10 +11,10 @@
 //  new group so that it won't be marked for upgrade
 //
 
-class Snapshotfile: SnapshotfileProtocol {
+public class Snapshotfile: SnapshotfileProtocol {
     // If you want to enable `snapshot`, run `fastlane snapshot init`
     // After, this file will be replaced with a custom implementation that contains values you supplied
     // during the `init` process, and you won't see this message
 }
 
-// Generated with fastlane 2.157.3
+// Generated with fastlane 2.161.0

data/fastlane/swift/SnapshotfileProtocol.swift

@@ -1,4 +1,7 @@
-protocol SnapshotfileProtocol: class {
+// SnapshotfileProtocol.swift
+// Copyright (c) 2020 FastlaneTools
+
+public protocol SnapshotfileProtocol: class {
     /// Path the workspace file
     var workspace: String? { get }
 
@@ -132,7 +135,7 @@ protocol SnapshotfileProtocol: class {
     var suppressXcodeOutput: Bool? { get }
 }
 
-extension SnapshotfileProtocol {
+public extension SnapshotfileProtocol {
     var workspace: String? { return nil }
     var project: String? { return nil }
     var xcargs: String? { return nil }
@@ -181,4 +184,4 @@ extension SnapshotfileProtocol {
 
 // Please don't remove the lines below
 // They are used to detect outdated files
-// FastlaneRunnerAPIVersion [0.9.30]
+// FastlaneRunnerAPIVersion [0.9.36]

data/fastlane/swift/SocketClient.swift

@@ -1,9 +1,5 @@
-//
-//  SocketClient.swift
-//  FastlaneSwiftRunner
-//
-//  Created by Joshua Liebowitz on 7/30/17.
-//
+// SocketClient.swift
+// Copyright (c) 2020 FastlaneTools
 
 //
 //  ** NOTE **
@@ -40,7 +36,7 @@ class SocketClient: NSObject {
     fileprivate var inputStream: InputStream!
     fileprivate var outputStream: OutputStream!
     fileprivate var cleaningUpAfterDone = false
-    fileprivate let dispatchGroup: DispatchGroup = DispatchGroup()
+    fileprivate let dispatchGroup = DispatchGroup()
     fileprivate let readSemaphore = DispatchSemaphore(value: 1)
     fileprivate let writeSemaphore = DispatchSemaphore(value: 1)
     fileprivate let commandTimeoutSeconds: Int

data/fastlane/swift/SocketClientDelegateProtocol.swift

@@ -1,9 +1,5 @@
-//
-//  SocketClientDelegateProtocol.swift
-//  FastlaneSwiftRunner
-//
-//  Created by Joshua Liebowitz on 8/12/17.
-//
+// SocketClientDelegateProtocol.swift
+// Copyright (c) 2020 FastlaneTools
 
 //
 //  ** NOTE **

data/fastlane/swift/SocketResponse.swift

@@ -1,9 +1,5 @@
-//
-//  SocketResponse.swift
-//  FastlaneSwiftRunner
-//
-//  Created by Joshua Liebowitz on 7/30/17.
-//
+// SocketResponse.swift
+// Copyright (c) 2020 FastlaneTools
 
 //
 //  ** NOTE **

data/fastlane/swift/formatting/Brewfile.lock.json

@@ -2,22 +2,22 @@
   "entries": {
     "brew": {
       "swiftformat": {
-        "version": "0.44.8",
+        "version": "0.45.6",
         "bottle": {
           "cellar": ":any_skip_relocation",
           "prefix": "/usr/local",
           "files": {
             "catalina": {
-              "url": "https://homebrew.bintray.com/bottles/swiftformat-0.44.8.catalina.bottle.tar.gz",
-              "sha256": "9cbd2c21d4579c8c4ffc9df7b44593f7622d13f8517a3fed047c5e5f3f2560c6"
+              "url": "https://homebrew.bintray.com/bottles/swiftformat-0.45.6.catalina.bottle.tar.gz",
+              "sha256": "7f23ff740679b30e313c91533c2f3e6fa4210bb68f8e383c29e7f922f87d8f66"
             },
             "mojave": {
-              "url": "https://homebrew.bintray.com/bottles/swiftformat-0.44.8.mojave.bottle.tar.gz",
-              "sha256": "a8f8b6fa977804c2d13f0cbc9ed223ddaa88e3c0684e91519e005784c8418b36"
+              "url": "https://homebrew.bintray.com/bottles/swiftformat-0.45.6.mojave.bottle.tar.gz",
+              "sha256": "b5349b775ff60c73c284d5de8ad2c0fdfb35428cff92bb7a8e5fcc6536750b89"
             },
             "high_sierra": {
-              "url": "https://homebrew.bintray.com/bottles/swiftformat-0.44.8.high_sierra.bottle.tar.gz",
-              "sha256": "fd43d192d194a8bb02308714b691e6a7101f839889f749dff4a1facf8172b951"
+              "url": "https://homebrew.bintray.com/bottles/swiftformat-0.45.6.high_sierra.bottle.tar.gz",
+              "sha256": "34d900217ca12736a112c31e54a5f4f7e64c1fe224f6e4ea76ad1d25b149f647"
             }
           }
         }
@@ -27,12 +27,20 @@
   "system": {
     "macos": {
       "catalina": {
-        "HOMEBREW_VERSION": "2.2.14-62-g9befd55",
+        "HOMEBREW_VERSION": "2.4.9-133-g0fdf8f2",
         "HOMEBREW_PREFIX": "/usr/local",
-        "Homebrew/homebrew-core": "0b738b77a5a13a66a52d76d34c4f608b719e0485",
+        "Homebrew/homebrew-core": "7141f37f3af0e6702f6dab2263852ddefbbbf8ed",
         "CLT": "11.0.28.3",
-        "Xcode": "11.4.1",
+        "Xcode": "11.6",
         "macOS": "10.15.4"
+      },
+      "big_sur": {
+        "HOMEBREW_VERSION": "2.4.13-249-g6454504",
+        "HOMEBREW_PREFIX": "/usr/local",
+        "Homebrew/homebrew-core": "020491c34515c229d904e6e69e14157cb728d2fa",
+        "CLT": "11.0.28.3",
+        "Xcode": "12.0",
+        "macOS": "11.0"
       }
     }
   }

data/fastlane/swift/main.swift

@@ -1,9 +1,5 @@
-//
-//  main.swift
-//  FastlaneSwiftRunner
-//
-//  Created by Joshua Liebowitz on 8/26/17.
-//
+// main.swift
+// Copyright (c) 2020 FastlaneTools
 
 //
 //  ** NOTE **
@@ -24,7 +20,7 @@ class MainProcess {
     @objc func connectToFastlaneAndRunLane() {
         runner.startSocketThread(port: argumentProcessor.port)
 
-        let completedRun = Fastfile.runLane(named: argumentProcessor.currentLane, parameters: argumentProcessor.laneParameters())
+        let completedRun = Fastfile.runLane(from: nil, named: argumentProcessor.currentLane, parameters: argumentProcessor.laneParameters())
         if completedRun {
             runner.disconnectFromFastlaneProcess()
         }
@@ -39,7 +35,7 @@ class MainProcess {
     }
 }
 
-let process: MainProcess = MainProcess()
+let process = MainProcess()
 process.startFastlaneThread()
 
 while !process.doneRunningLane, RunLoop.current.run(mode: RunLoopMode.defaultRunLoopMode, before: Date(timeIntervalSinceNow: 2)) {

data/fastlane/swift/upgrade_manifest.json

@@ -1 +1 @@
-{"Actions.swift":"Autogenerated API","Fastlane.swift":"Autogenerated API","DeliverfileProtocol.swift":"Autogenerated API","GymfileProtocol.swift":"Autogenerated API","MatchfileProtocol.swift":"Autogenerated API","Plugins.swift":"Autogenerated API","PrecheckfileProtocol.swift":"Autogenerated API","ScanfileProtocol.swift":"Autogenerated API","ScreengrabfileProtocol.swift":"Autogenerated API","SnapshotfileProtocol.swift":"Autogenerated API","LaneFileProtocol.swift":"Fastfile Components","ControlCommand.swift":"Networking","RubyCommand.swift":"Networking","RubyCommandable.swift":"Networking","Runner.swift":"Networking","SocketClient.swift":"Networking","SocketClientDelegateProtocol.swift":"Networking","SocketResponse.swift":"Networking","ArgumentProcessor.swift":"Runner Code","main.swift":"Runner Code","RunnerArgument.swift":"Runner Code"}
+{"Actions.swift":"Autogenerated API","Fastlane.swift":"Autogenerated API","DeliverfileProtocol.swift":"Autogenerated API","GymfileProtocol.swift":"Autogenerated API","MatchfileProtocol.swift":"Autogenerated API","Plugins.swift":"Autogenerated API","PrecheckfileProtocol.swift":"Autogenerated API","ScanfileProtocol.swift":"Autogenerated API","ScreengrabfileProtocol.swift":"Autogenerated API","SnapshotfileProtocol.swift":"Autogenerated API","LaneFileProtocol.swift":"Fastfile Components","ControlCommand.swift":"Networking","RubyCommand.swift":"Networking","RubyCommandable.swift":"Networking","Runner.swift":"Networking","SocketClient.swift":"Networking","SocketClientDelegateProtocol.swift":"Networking","SocketResponse.swift":"Networking","main.swift":"Runner Code","ArgumentProcessor.swift":"Runner Code","RunnerArgument.swift":"Runner Code"}

data/frameit/lib/frameit/editor.rb

@@ -429,6 +429,7 @@ module Frameit
         # Add the actual title
         text_image.combine_options do |i|
           i.font(current_font) if current_font
+          i.weight(@config[key.to_s]['font_weight']) if @config[key.to_s]['font_weight']
           i.gravity("Center")
           i.pointsize(actual_font_size(key))
           i.draw("text 0,0 '#{text}'")

data/match/lib/match/importer.rb

@@ -2,6 +2,7 @@ require_relative 'spaceship_ensure'
 require_relative 'encryption'
 require_relative 'storage'
 require_relative 'module'
+require_relative 'generator'
 require 'fastlane_core/provisioning_profile'
 require 'fileutils'
 
@@ -56,8 +57,9 @@ module Match
         UI.user_error!("Cert type '#{cert_type}' is not supported")
       end
 
+      prov_type = Match.profile_type_sym(params[:type])
       output_dir_certs = File.join(storage.prefixed_working_directory, "certs", cert_type.to_s)
-      output_dir_profiles = File.join(storage.prefixed_working_directory, "profiles", cert_type.to_s)
+      output_dir_profiles = File.join(storage.prefixed_working_directory, "profiles", prov_type.to_s)
 
       # Need to get the cert id by comparing base64 encoded cert content with certificate content from the API responses
       Spaceship::Portal.login(params[:username])
@@ -86,7 +88,8 @@ module Match
         FileUtils.mkdir_p(output_dir_profiles)
         bundle_id = FastlaneCore::ProvisioningProfile.bundle_id(profile_path)
         profile_extension = FastlaneCore::ProvisioningProfile.profile_extension(profile_path)
-        dest_profile_path = File.join(output_dir_profiles, "#{cert_type.to_s.capitalize}_#{bundle_id}#{profile_extension}")
+        profile_type_name = Match::Generator.profile_type_name(prov_type)
+        dest_profile_path = File.join(output_dir_profiles, "#{profile_type_name}_#{bundle_id}#{profile_extension}")
         files_to_commit.push(dest_profile_path)
         IO.copy_stream(profile_path, dest_profile_path)
       end

data/match/lib/match/options.rb

@@ -147,7 +147,7 @@ module Match
         FastlaneCore::ConfigItem.new(key: :git_bearer_authorization,
                                      env_name: "MATCH_GIT_BEARER_AUTHORIZATION",
                                      sensitive: true,
-                                     description: "Use a bearer authorization header to access the git repo (e.g.: access to an Azure Devops repository), usually a string in Base64",
+                                     description: "Use a bearer authorization header to access the git repo (e.g.: access to an Azure DevOps repository), usually a string in Base64",
                                      conflicting_options: [:git_basic_authorization, :git_private_key],
                                      optional: true,
                                      default_value: nil),

data/match/lib/match/spaceship_ensure.rb

@@ -18,14 +18,14 @@ module Match
         UI.important("More information https://docs.fastlane.tools/actions/match/#access-control")
       end
 
+      # Prompts select team if multiple teams and none specified
       UI.message("Verifying that the certificate and profile are still valid on the Dev Portal...")
-      Spaceship::ConnectAPI.login(use_portal: true, use_tunes: false)
-      Spaceship::ConnectAPI.select_team
+      Spaceship::ConnectAPI.login(user, use_portal: true, use_tunes: false, portal_team_id: team_id, team_name: team_name)
     end
 
     # The team ID of the currently logged in team
     def team_id
-      return Spaceship::ConnectAPI.client.team_id
+      return Spaceship::ConnectAPI.client.portal_team_id
     end
 
     def bundle_identifier_exists(username: nil, app_identifier: nil, platform: nil)

data/pilot/lib/pilot/options.rb

@@ -12,7 +12,7 @@ module Pilot
       [
         FastlaneCore::ConfigItem.new(key: :api_key_path,
                                      env_name: "PILOT_API_KEY_PATH",
-                                     description: "Path to your App Store Connect API key JSON file",
+                                     description: "Path to your App Store Connect API Key JSON file (https://docs.fastlane.tools/app-store-connect-api/#using-fastlane-api-key-json-file)",
                                      optional: true,
                                      conflicting_options: [:username],
                                      verify_block: proc do |value|
@@ -20,7 +20,7 @@ module Pilot
                                      end),
         FastlaneCore::ConfigItem.new(key: :api_key,
                                      env_name: "PILOT_API_KEY",
-                                     description: "Path to your App Store Connect API key JSON file",
+                                     description: "Your App Store Connect API Key information (https://docs.fastlane.tools/app-store-connect-api/#use-return-value-and-pass-in-as-an-option)",
                                      type: Hash,
                                      optional: true,
                                      sensitive: true,

data/precheck/lib/precheck/options.rb

@@ -25,6 +25,22 @@ module Precheck
       user ||= CredentialsManager::AppfileConfig.try_fetch_value(:apple_id)
 
       [
+        FastlaneCore::ConfigItem.new(key: :api_key_path,
+                                     env_name: "PRECHECK_API_KEY_PATH",
+                                     description: "Path to your App Store Connect API Key JSON file (https://docs.fastlane.tools/app-store-connect-api/#using-fastlane-api-key-json-file)",
+                                     optional: true,
+                                     conflicting_options: [:username],
+                                     verify_block: proc do |value|
+                                       UI.user_error!("Couldn't find API key JSON file at path '#{value}'") unless File.exist?(value)
+                                     end),
+        FastlaneCore::ConfigItem.new(key: :api_key,
+                                     env_name: "PRECHECK_API_KEY",
+                                     description: "Your App Store Connect API Key information (https://docs.fastlane.tools/app-store-connect-api/#use-return-value-and-pass-in-as-an-option)",
+                                     type: Hash,
+                                     optional: true,
+                                     sensitive: true,
+                                     conflicting_options: [:api_key_path, :username]),
+
         FastlaneCore::ConfigItem.new(key: :app_identifier,
                                      short_option: "-a",
                                      env_name: "PRECHECK_APP_IDENTIFIER",
@@ -60,6 +76,15 @@ module Precheck
                                      verify_block: proc do |value|
                                        ENV["FASTLANE_ITC_TEAM_NAME"] = value.to_s
                                      end),
+        FastlaneCore::ConfigItem.new(key: :platform,
+                                     short_option: "-j",
+                                     env_name: "PRECHECK_PLATFORM",
+                                     description: "The platform to use (optional)",
+                                     optional: true,
+                                     default_value: "ios",
+                                     verify_block: proc do |value|
+                                       UI.user_error!("The platform can only be ios, appletvos, or osx") unless %('ios', 'appletvos', 'osx').include?(value)
+                                     end),
         FastlaneCore::ConfigItem.new(key: :default_rule_level,
                                      short_option: "-r",
                                      env_name: "PRECHECK_DEFAULT_RULE_LEVEL",

data/precheck/lib/precheck/rule_processor.rb

@@ -1,4 +1,5 @@
 require 'spaceship/tunes/language_item'
+require 'spaceship/tunes/iap_list'
 require 'fastlane/markdown_table_formatter'
 
 require_relative 'module'
@@ -43,8 +44,8 @@ module Precheck
   class RuleProcessor
     def self.process_app_and_version(app: nil, app_version: nil, rules: nil)
       items_to_check = []
-      items_to_check += generate_text_items_to_check(app: app, app_version: app_version)
-      items_to_check += generate_url_items_to_check(app: app, app_version: app_version)
+      items_to_check += generate_app_items_to_check(app: app)
+      items_to_check += generate_version_items_to_check(app_version: app_version)
 
       return process_rules(items_to_check: items_to_check, rules: rules)
     end
@@ -125,66 +126,41 @@ module Precheck
       return rule_hash
     end
 
-    def self.generate_url_items_to_check(app: nil, app_version: nil)
+    def self.generate_app_items_to_check(app: nil)
       items = []
-      items += collect_urls_from_hash(hash: app_version.support_url,
-                                 item_name: :support_url,
-                     friendly_name_postfix: "support URL")
-      items += collect_urls_from_hash(hash: app_version.marketing_url,
-                                 item_name: :marketing_url,
-                     friendly_name_postfix: "marketing URL",
-                               is_optional: true)
-
-      items += collect_urls_from_hash(hash: app.details.privacy_url,
-                                 item_name: :privacy_url,
-                     friendly_name_postfix: "privacy URL",
-                               is_optional: true)
-      return items
-    end
 
-    def self.collect_urls_from_hash(hash: nil, item_name: nil, friendly_name_postfix: nil, is_optional: false)
-      items = []
-      hash.each do |key, value|
-        items << URLItemToCheck.new(value, item_name, "#{friendly_name_postfix}: (#{key})", is_optional)
+      # App info localizations
+      app_info = app.fetch_edit_app_info
+      app_info_localizations = app_info.get_app_info_localizations
+      app_info_localizations.each do |localization|
+        items << collect_text_items_from_language_item(locale: localization.locale,
+                                                        value: localization.name,
+                                                    item_name: :app_name,
+                                        friendly_name_postfix: "app name")
+
+        items << collect_text_items_from_language_item(locale: localization.locale,
+                                                        value: localization.subtitle,
+                                                    item_name: :app_subtitle,
+                                        friendly_name_postfix: "app name subtitle",
+                                                  is_optional: true)
+
+        items << collect_text_items_from_language_item(locale: localization.locale,
+                                                        value: localization.privacy_policy_text,
+                                                    item_name: :privacy_policy_text,
+                                        friendly_name_postfix: " tv privacy policy")
+
+        items << collect_urls_from_language_item(locale: localization.locale,
+                                                        value: localization.privacy_policy_url,
+                                                    item_name: :privacy_policy_url,
+                                        friendly_name_postfix: "privacy URL",
+                                                  is_optional: true)
       end
-      return items
-    end
-
-    def self.generate_text_items_to_check(app: nil, app_version: nil)
-      items = []
-
-      items << TextItemToCheck.new(app_version.copyright, :copyright, "copyright")
-
-      items += collect_text_items_from_language_item(hash: app_version.keywords,
-                                                item_name: :keywords,
-                                    friendly_name_postfix: "keywords")
-
-      items += collect_text_items_from_language_item(hash: app_version.description,
-                                                item_name: :description,
-                                    friendly_name_postfix: "description")
-
-      items += collect_text_items_from_language_item(hash: app_version.release_notes,
-                                                item_name: :release_notes,
-                                    friendly_name_postfix: "release notes")
-
-      items += collect_text_items_from_language_item(hash: app.details.name,
-                                                item_name: :app_name,
-                                    friendly_name_postfix: "app name")
-
-      items += collect_text_items_from_language_item(hash: app.details.apple_tv_privacy_policy,
-                                                item_name: :app_subtitle,
-                                    friendly_name_postfix: " tv privacy policy")
-
-      items += collect_text_items_from_language_item(hash: app.details.subtitle,
-                                                item_name: :app_subtitle,
-                                    friendly_name_postfix: "app name subtitle",
-                                              is_optional: true)
 
       should_include_iap = Precheck.config[:include_in_app_purchases]
       if should_include_iap
         UI.message("Reading in-app purchases. If you have a lot, this might take a while")
         UI.message("You can disable IAP checking by setting the `include_in_app_purchases` flag to `false`")
-        in_app_purchases = app.in_app_purchases.all
+        in_app_purchases = get_iaps(app_id: app.id)
         in_app_purchases ||= []
         in_app_purchases.each do |purchase|
           items += collect_iap_language_items(purchase_edit_versions: purchase.edit.versions)
@@ -195,6 +171,64 @@ module Precheck
       return items
     end
 
+    def self.generate_version_items_to_check(app_version: nil)
+      items = []
+
+      items << TextItemToCheck.new(app_version.copyright, :copyright, "copyright")
+
+      # Version localizations
+      version_localizations = app_version.get_app_store_version_localizations
+      version_localizations.each do |localization|
+        items << collect_text_items_from_language_item(locale: localization.locale,
+                                                        value: localization.keywords,
+                                                    item_name: :keywords,
+                                        friendly_name_postfix: "keywords")
+
+        items << collect_text_items_from_language_item(locale: localization.locale,
+                                                        value: localization.description,
+                                                    item_name: :description,
+                                        friendly_name_postfix: "description")
+
+        items << collect_text_items_from_language_item(locale: localization.locale,
+                                                        value: localization.whats_new,
+                                                    item_name: :release_notes,
+                                        friendly_name_postfix: "what's new")
+
+        items << collect_urls_from_language_item(locale: localization.locale,
+                                                        value: localization.support_url,
+                                                    item_name: :support_url,
+                                        friendly_name_postfix: "support URL")
+
+        items << collect_urls_from_language_item(locale: localization.locale,
+                                                        value: localization.marketing_url,
+                                                    item_name: :marketing_url,
+                                        friendly_name_postfix: "marketing URL",
+                                                 is_optional: true)
+      end
+
+      return items
+    end
+
+    # As of 2020-09-04, this is the only non App Store Connect call in prechecks
+    # This will need to get replaced when the API becomes available
+    def self.get_iaps(app_id: nil, include_deleted: false)
+      r = Spaceship::Tunes.client.iaps(app_id: app_id)
+      return_iaps = []
+      r.each do |product|
+        attrs = product
+
+        # This is not great but Spaceship::Tunes::IAPList.factory looks
+        # for `application.apple_id`
+        mock_application = OpenStruct.new({ apple_id: app_id })
+        attrs[:application] = mock_application
+
+        loaded_iap = Spaceship::Tunes::IAPList.factory(attrs)
+        next if loaded_iap.status == "deleted" && !include_deleted
+        return_iaps << loaded_iap
+      end
+      return return_iaps
+    end
+
     def self.collect_iap_language_items(purchase_edit_versions: nil, is_optional: false)
       items = []
       purchase_edit_versions.each do |language_key, hash|
@@ -207,12 +241,12 @@ module Precheck
     end
 
     # a few attributes are LanguageItem this method creates a TextItemToCheck for each pair
-    def self.collect_text_items_from_language_item(hash: nil, item_name: nil, friendly_name_postfix: nil, is_optional: false)
-      items = []
-      hash.each do |key, value|
-        items << TextItemToCheck.new(value, item_name, "#{friendly_name_postfix}: (#{key})", is_optional)
-      end
-      return items
+    def self.collect_text_items_from_language_item(locale: nil, value: nil, item_name: nil, friendly_name_postfix: nil, is_optional: false)
+      return TextItemToCheck.new(value, item_name, "#{friendly_name_postfix}: (#{locale})", is_optional)
+    end
+
+    def self.collect_urls_from_language_item(locale: nil, value: nil, item_name: nil, friendly_name_postfix: nil, is_optional: false)
+      return URLItemToCheck.new(value, item_name, "#{friendly_name_postfix}: (#{locale})", is_optional)
     end
   end
 end