fastlane 2.157.2 → 2.160.0

data/fastlane/lib/fastlane/actions/clean_build_artifacts.rb

@@ -23,6 +23,7 @@ module Fastlane
 
         Actions.lane_context[Actions::SharedValues::SIGH_PROFILE_PATHS] = nil
         Actions.lane_context[Actions::SharedValues::DSYM_PATHS] = nil
+        Actions.lane_context[Actions::SharedValues::DSYM_LATEST_UPLOADED_DATE] = nil
 
         UI.success('Cleaned up build artifacts 🐙')
       end

data/fastlane/lib/fastlane/actions/docs/frame_screenshots.md

@@ -164,6 +164,7 @@ The `keyword` and `title` parameters are both used in `default` and `data`. They
 | `color` | The font color for the text. Specify a hex/html color code. | `#000000` (black) |
 | `font` | The font family for the text. Specify the (relative) path to the font file (e.g. an OpenType Font). | The default `imagemagick` font, which is system dependent. |
 | `font_size` | The font size for the text specified in points. If not specified or `0`, font will be scaled automatically to fit the available space. _frameit_ still shrinks the text, if it would not fit. | NA |
+| `font_weight` | The [font weight for the text](https://imagemagick.org/script/command-line-options.php#weight). Specify an integer value (e.g. 900). | NA |
 | `text` | The text that should be used for the `keyword` or `title`. <p> Note: If you want to use localised text, use [`.strings` files](#strings-files). | NA |
 
 ### Example

data/fastlane/lib/fastlane/actions/docs/upload_to_testflight.md

@@ -32,7 +32,7 @@ For all commands, you can either use an [API Key](#app-store-connect-api-key) or
 
 The App Store Connect API Key is the preferred authentication method (if you are able to use it).
 
-- Uses offial App Store Connect API
+- Uses official App Store Connect API
 - No need for 2FA
 - Better performance over Apple ID
 

data/fastlane/lib/fastlane/actions/download_dsyms.rb

@@ -2,20 +2,24 @@ module Fastlane
   module Actions
     module SharedValues
       DSYM_PATHS = :DSYM_PATHS
+      DSYM_LATEST_UPLOADED_DATE = :DSYM_LATEST_UPLOADED_DATE
     end
     class DownloadDsymsAction < Action
       # rubocop:disable Metrics/PerceivedComplexity
       def self.run(params)
+        require 'openssl'
         require 'spaceship'
         require 'net/http'
+        require 'date'
 
+        # Team selection passed though FASTLANE_ITC_TEAM_ID and FASTLANE_ITC_TEAM_NAME environment variables
+        # Prompts select team if multiple teams and none specified
         UI.message("Login to App Store Connect (#{params[:username]})")
-        Spaceship::Tunes.login(params[:username])
-        Spaceship::Tunes.select_team
+        Spaceship::ConnectAPI.login(params[:username], use_portal: false, use_tunes: true)
         UI.message("Login successful")
 
         # Get App
-        app = Spaceship::Application.find(params[:app_identifier])
+        app = Spaceship::ConnectAPI::App.find(params[:app_identifier])
         unless app
           UI.user_error!("Could not find app with bundle identifier '#{params[:app_identifier]}' on account #{params[:username]}")
         end
@@ -23,38 +27,36 @@ module Fastlane
         # Process options
         version = params[:version]
         build_number = params[:build_number].to_s unless params[:build_number].nil?
-        platform = params[:platform]
+        itc_platform = params[:platform]
         output_directory = params[:output_directory]
         wait_for_dsym_processing = params[:wait_for_dsym_processing]
         wait_timeout = params[:wait_timeout]
         min_version = Gem::Version.new(params[:min_version]) if params[:min_version]
+        after_uploaded_date = DateTime.parse(params[:after_uploaded_date]) unless params[:after_uploaded_date].nil?
+
+        platform = Spaceship::ConnectAPI::Platform.map(itc_platform)
 
         # Set version if it is latest
         if version == 'latest'
           # Try to grab the edit version first, else fallback to live version
           UI.message("Looking for latest version...")
-          latest_version = app.edit_version(platform: platform) || app.live_version(platform: platform)
-
-          UI.user_error!("Could not find latest version for your app, please try setting a specific version") if latest_version.version.nil?
-
-          latest_candidate_build = latest_version.candidate_builds.max_by(&:upload_date)
-          if latest_candidate_build.nil?
-            version = latest_version.version
-            build_number = latest_version.build_version
-          else
-            # The build_version of a candidate build does not always match the one in latest_version so get the version and build number from the same place.
-            version = latest_candidate_build.train_version
-            build_number = latest_candidate_build.build_version
-          end
+          latest_version = app.get_edit_app_store_version(platform: platform) || app.get_live_app_store_version(platform: platform)
+
+          UI.user_error!("Could not find latest version for your app, please try setting a specific version") if latest_version.nil?
+
+          latest_build = get_latest_build!(app_id: app.id, version: latest_version.version_string, platform: platform)
+
+          version = latest_build.app_version
+          build_number = latest_build.version
         elsif version == 'live'
           UI.message("Looking for live version...")
-          live_version = app.live_version(platform: platform)
+          live_version = app.get_live_app_store_version(platform: platform)
 
           UI.user_error!("Could not find live version for your app, please try setting 'latest' or a specific version") if live_version.nil?
 
           # No need to search for candidates, because released App Store version should only have one build
-          version = live_version.version
-          build_number = live_version.build_version
+          version = live_version.version_string
+          build_number = live_version.build.version
         end
 
         # Remove leading zeros from version string (eg. 1.02 -> 1.2)
@@ -74,83 +76,118 @@ module Fastlane
         message << "(#{build_number})" if build_number
         UI.message(message.join(" "))
 
-        app.tunes_all_build_trains(platform: platform).each do |train|
+        filter = { app: app.id }
+        filter["preReleaseVersion.platform"] = platform
+        build_resps = Spaceship::ConnectAPI.get_builds(filter: filter, sort: "-uploadedDate", includes: "preReleaseVersion").all_pages
+        builds = build_resps.flat_map(&:to_models)
+
+        builds.each do |build|
+          asc_app_version = build.app_version
+          asc_build_number = build.version
+          uploaded_date = DateTime.parse(build.uploaded_date)
+
           message = []
-          message << "Found train (version): #{train.version_string}"
+          message << "Found train (version): #{asc_app_version}"
           message << ", comparing to supplied version: #{version}" if version
           UI.verbose(message.join(" "))
 
-          if version && version != train.version_string
-            UI.verbose("Version #{version} doesn't match: #{train.version_string}")
+          if version && version != asc_app_version
+            UI.verbose("Version #{version} doesn't match: #{asc_app_version}")
             next
           end
 
-          if min_version && min_version > Gem::Version.new(train.version_string)
-            UI.verbose("Min version #{min_version} not reached: #{train.version_string}")
+          if min_version && min_version > Gem::Version.new(asc_app_version)
+            UI.verbose("Min version #{min_version} not reached: #{asc_app_version}")
             next
           end
 
-          app.tunes_all_builds_for_train(train: train.version_string, platform: platform).each do |build|
-            message = []
-            message << "Found build version: #{build.build_version}"
-            message << ", comparing to supplied build_number: #{build_number}" if build_number
-            UI.verbose(message.join(" "))
+          if after_uploaded_date && after_uploaded_date >= uploaded_date
+            UI.verbose("Upload date #{after_uploaded_date} not reached: #{uploaded_date}")
+            next
+          end
 
-            if build_number && build.build_version != build_number
-              UI.verbose("build_version: #{build.build_version} doesn't match: #{build_number}")
-              next
-            end
+          message = []
+          message << "Found build version: #{asc_build_number}"
+          message << ", comparing to supplied build_number: #{build_number}" if build_number
+          UI.verbose(message.join(" "))
 
-            UI.verbose("Build_version: #{build.build_version} matches #{build_number}, grabbing dsym_url") if build_number
-
-            start = Time.now
-            download_url = nil
-
-            loop do
-              begin
-                build_details = app.tunes_build_details(train: train.version_string, build_number: build.build_version, platform: platform)
-                download_url = build_details.dsym_url
-                UI.verbose("dsym_url: #{download_url}")
-              rescue Spaceship::TunesClient::ITunesConnectError => ex
-                UI.error("Error accessing dSYM file for build\n\n#{build}\n\nException: #{ex}")
-              end
-
-              unless download_url
-                if !wait_for_dsym_processing || (Time.now - start) > wait_timeout
-                  # In some cases, AppStoreConnect does not process the dSYMs, thus no error should be thrown.
-                  UI.message("Could not find any dSYM for #{build.build_version} (#{train.version_string})")
-                else
-                  UI.message("Waiting for dSYM file to appear...")
-                  sleep(30)
-                  next
-                end
-              end
-
-              break
-            end
+          if build_number && asc_build_number != build_number
+            UI.verbose("build_version: #{asc_build_number} doesn't match: #{build_number}")
+            next
+          end
 
-            if download_url
-              self.download(download_url, app.bundle_id, train.version_string, build.build_version, output_directory)
-              break if build_number
+          UI.verbose("Build_version: #{asc_build_number} matches #{build_number}, grabbing dsym_url") if build_number
+          get_details_and_download_dsym(app: app, train: asc_app_version, build_number: asc_build_number, uploaded_date: uploaded_date, platform: itc_platform, wait_for_dsym_processing: wait_for_dsym_processing, wait_timeout: wait_timeout, output_directory: output_directory)
+        end
+      end
+
+      def self.get_details_and_download_dsym(app: nil, train: nil, build_number: nil, uploaded_date: nil, platform: nil, wait_for_dsym_processing: nil, wait_timeout: nil, output_directory: nil)
+        start = Time.now
+        download_url = nil
+
+        loop do
+          begin
+            resp = Spaceship::Tunes.client.build_details(app_id: app.id, train: train, build_number: build_number, platform: platform)
+
+            resp['apple_id'] = app.id
+            build_details = Spaceship::Tunes::BuildDetails.factory(resp)
+
+            download_url = build_details.dsym_url
+            UI.verbose("dsym_url: #{download_url}")
+          rescue Spaceship::TunesClient::ITunesConnectError => ex
+            UI.error("Error accessing dSYM file for build\n\n#{build}\n\nException: #{ex}")
+          end
+
+          unless download_url
+            if !wait_for_dsym_processing || (Time.now - start) > wait_timeout
+              # In some cases, AppStoreConnect does not process the dSYMs, thus no error should be thrown.
+              UI.message("Could not find any dSYM for #{build_number} (#{train})")
             else
-              UI.message("No dSYM URL for #{build.build_version} (#{train.version_string})")
+              UI.message("Waiting for dSYM file to appear...")
+              sleep(30)
+              next
             end
           end
+
+          break
         end
 
-        if (Actions.lane_context[SharedValues::DSYM_PATHS] || []).count == 0
-          UI.error("No dSYM files found on App Store Connect - this usually happens when no recompiling has happened yet")
+        if download_url
+          self.download(download_url, app.bundle_id, train, build_number, uploaded_date, output_directory)
+          return if build_number
+        else
+          UI.message("No dSYM URL for #{build_number} (#{train})")
         end
       end
       # rubocop:enable Metrics/PerceivedComplexity
 
-      def self.download(download_url, bundle_id, train_number, build_version, output_directory)
+      def self.get_latest_build!(app_id: nil, version: nil, platform: nil)
+        filter = { app: app_id }
+        filter["preReleaseVersion.version"] = version
+        filter["preReleaseVersion.platform"] = platform
+        latest_build = Spaceship::ConnectAPI.get_builds(filter: filter, sort: "-uploadedDate", includes: "preReleaseVersion").first
+
+        if latest_build.nil?
+          UI.user_error!("Could not find latest build for version #{version}")
+        end
+
+        return latest_build
+      end
+
+      def self.download(download_url, bundle_id, train_number, build_version, uploaded_date, output_directory)
         result = self.download_file(download_url)
         path   = write_dsym(result, bundle_id, train_number, build_version, output_directory)
         UI.success("🔑  Successfully downloaded dSYM file for #{train_number} - #{build_version} to '#{path}'")
 
         Actions.lane_context[SharedValues::DSYM_PATHS] ||= []
         Actions.lane_context[SharedValues::DSYM_PATHS] << File.expand_path(path)
+
+        unless uploaded_date.nil?
+          Actions.lane_context[SharedValues::DSYM_LATEST_UPLOADED_DATE] ||= uploaded_date
+          current_latest = Actions.lane_context[SharedValues::DSYM_LATEST_UPLOADED_DATE]
+          Actions.lane_context[SharedValues::DSYM_LATEST_UPLOADED_DATE] = [current_latest, uploaded_date].max
+          UI.verbose("Most recent build uploaded_date #{Actions.lane_context[SharedValues::DSYM_LATEST_UPLOADED_DATE]}")
+        end
       end
 
       def self.write_dsym(data, bundle_id, train_number, build_number, output_directory)
@@ -265,6 +302,12 @@ module Fastlane
                                        env_name: "DOWNLOAD_DSYMS_MIN_VERSION",
                                        description: "The minimum app version for dSYMs you wish to download",
                                        optional: true),
+          FastlaneCore::ConfigItem.new(key: :after_uploaded_date,
+                                       short_option: "-d",
+                                       env_name: "DOWNLOAD_DSYMS_AFTER_UPLOADED_DATE",
+                                       description: "The uploaded date after which you wish to download dSYMs",
+                                       optional: true,
+                                       is_string: true),
           FastlaneCore::ConfigItem.new(key: :output_directory,
                                        short_option: "-s",
                                        env_name: "DOWNLOAD_DSYMS_OUTPUT_DIRECTORY",
@@ -289,7 +332,8 @@ module Fastlane
 
       def self.output
         [
-          ['DSYM_PATHS', 'An array to all the zipped dSYM files']
+          ['DSYM_PATHS', 'An array to all the zipped dSYM files'],
+          ['DSYM_LATEST_UPLOADED_DATE', 'Date of the most recent uploaded time of successfully downloaded dSYM files']
         ]
       end
 
@@ -311,7 +355,8 @@ module Fastlane
           'download_dsyms(version: "1.0.0", build_number: "345")',
           'download_dsyms(version: "1.0.1", build_number: 42)',
           'download_dsyms(version: "live")',
-          'download_dsyms(min_version: "1.2.3")'
+          'download_dsyms(min_version: "1.2.3")',
+          'download_dsyms(after_uploaded_date: "2020-09-11T19:00:00+01:00")'
         ]
       end
 

data/fastlane/lib/fastlane/actions/set_changelog.rb

@@ -4,9 +4,10 @@ module Fastlane
       def self.run(params)
         require 'spaceship'
 
+        # Team selection passed though FASTLANE_ITC_TEAM_ID and FASTLANE_ITC_TEAM_NAME environment variables
+        # Prompts select team if multiple teams and none specified
         UI.message("Login to App Store Connect (#{params[:username]})")
         Spaceship::ConnectAPI.login(params[:username], use_portal: false, use_tunes: true)
-        Spaceship::ConnectAPI.select_team
         UI.message("Login successful")
 
         app = Spaceship::ConnectAPI::App.find(params[:app_identifier])

data/fastlane/lib/fastlane/helper/git_helper.rb

@@ -45,6 +45,8 @@ module Fastlane
       command = %w(git describe)
       command << '--tags' if match_lightweight
       command << hash
+      command << '--match' if tag_match_pattern
+      command << tag_match_pattern if tag_match_pattern
       Actions.sh(*command.compact, log: false).chomp
     rescue
       nil

data/fastlane/lib/fastlane/swift_fastlane_api_generator.rb

@@ -188,6 +188,8 @@ module Fastlane
 
     def write_lanefile(lanefile_implementation_opening: nil, class_name: nil, tool_name: nil)
       disclaimer = []
+      disclaimer << "// *bait*" # As we are using a custom common header, we have to bait with a random comment so it does not remove important text.
+      disclaimer << ""
       disclaimer << "// This class is automatically included in FastlaneRunner during build"
       disclaimer << ""
       disclaimer << "// This autogenerated file will be overwritten or replaced during build time, or when you initialize `#{tool_name}`"
@@ -223,7 +225,7 @@ module Fastlane
         header << "//  new group so that it won't be marked for upgrade"
         header << "//"
         header << ""
-        header << "class #{tool_detail.swift_class}: #{tool_detail.swift_protocol} {"
+        header << "public class #{tool_detail.swift_class}: #{tool_detail.swift_protocol} {"
         lanefile_implementation_opening = header.join("\n")
 
         files_generated << write_lanefile(
@@ -284,7 +286,7 @@ func parseInt(fromString: String, function: String = #function) -> Int {
 
     def generate_lanefile_tool_objects(classes: nil)
       objects = classes.map do |filename|
-        "let #{filename.downcase}: #{filename} = #{filename}()"
+        "public let #{filename.downcase}: #{filename} = #{filename}()"
       end
       return objects
     end
@@ -362,12 +364,12 @@ func parseInt(fromString: String, function: String = #function) -> Int {
       protocol_content_array = []
       protocol_name = tool_swift_function.protocol_name
 
-      protocol_content_array << "protocol #{protocol_name}: class {"
+      protocol_content_array << "public protocol #{protocol_name}: class {"
       protocol_content_array += tool_swift_function.swift_vars
       protocol_content_array << "}"
       protocol_content_array << ""
 
-      protocol_content_array << "extension #{protocol_name} {"
+      protocol_content_array << "public extension #{protocol_name} {"
       protocol_content_array += tool_swift_function.swift_default_implementations
       protocol_content_array << "}"
       protocol_content_array << ""

data/fastlane/lib/fastlane/swift_fastlane_function.rb

@@ -206,7 +206,7 @@ module Fastlane
       # This just creates a string with as many spaces are necessary given whether or not
       # the function has a 'discardableResult' annotation, the 'func' keyword, function name
       # and the opening paren.
-      function_keyword_definition = 'func '
+      function_keyword_definition = 'public func '
       open_paren = '('
       closed_paren = ')'
       indent = ' ' * (discardable_result.length + function_name.length + function_keyword_definition.length + open_paren.length)

data/fastlane/lib/fastlane/version.rb

@@ -1,5 +1,5 @@
 module Fastlane
-  VERSION = '2.157.2'.freeze
+  VERSION = '2.160.0'.freeze
   DESCRIPTION = "The easiest way to automate beta deployments and releases for your iOS and Android apps".freeze
   MINIMUM_XCODE_RELEASE = "7.0".freeze
   RUBOCOP_REQUIREMENT = '0.49.1'.freeze

data/fastlane/swift/Actions.swift

@@ -1,4 +1,5 @@
-// This class is automatically included in FastlaneRunner during build
+// Actions.swift
+// Copyright (c) 2020 FastlaneTools
 
 // This autogenerated file will be overwritten or replaced when running "fastlane generate_swift"
 //

data/fastlane/swift/Appfile.swift

@@ -1,7 +1,5 @@
-// This class is automatically included in FastlaneRunner during build
-// If you have a custom Appfile.swift, this file will be replaced by it
-// Don't modify this file unless you are familiar with how fastlane's swift code generation works
-// *** This file will be overwritten or replaced during build time ***
+// Appfile.swift
+// Copyright (c) 2020 FastlaneTools
 
 var appIdentifier: String { return "" } // The bundle identifier of your app
 var appleID: String { return "" } // Your Apple email address

data/fastlane/swift/ArgumentProcessor.swift

@@ -1,9 +1,5 @@
-//
-//  ArgumentProcessor.swift
-//  FastlaneRunner
-//
-//  Created by Joshua Liebowitz on 9/28/17.
-//
+// ArgumentProcessor.swift
+// Copyright (c) 2020 FastlaneTools
 
 //
 //  ** NOTE **

data/fastlane/swift/ControlCommand.swift

@@ -1,8 +1,5 @@
-//
-//  ControlCommand.swift
-//  FastlaneRunner
-//
-//  Created by Joshua Liebowitz on 1/3/18.
+// ControlCommand.swift
+// Copyright (c) 2020 FastlaneTools
 
 //
 //  ** NOTE **

data/fastlane/swift/Deliverfile.swift

@@ -1,3 +1,6 @@
+// Deliverfile.swift
+// Copyright (c) 2020 FastlaneTools
+
 // This class is automatically included in FastlaneRunner during build
 
 // This autogenerated file will be overwritten or replaced during build time, or when you initialize `deliver`
@@ -8,10 +11,10 @@
 //  new group so that it won't be marked for upgrade
 //
 
-class Deliverfile: DeliverfileProtocol {
+public class Deliverfile: DeliverfileProtocol {
     // If you want to enable `deliver`, run `fastlane deliver init`
     // After, this file will be replaced with a custom implementation that contains values you supplied
     // during the `init` process, and you won't see this message
 }
 
-// Generated with fastlane 2.157.2
+// Generated with fastlane 2.160.0