fastlane 2.150.3 → 2.151.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: ef23a0fed00e3ec93bc286b3f34b22302da611a889c315013c63d929f218ecd7
-  data.tar.gz: e9155805e43cb051508414d3cf19db7b16c50fc5a1e280e944a5416a98dba32d
+  metadata.gz: b4bf7968a4becc2d05ed76545854fd77129c73f42de52ab952a774f84d522caf
+  data.tar.gz: bc298406b0f0bf5ba4e3fea0a8bc0d982a3a80696c19f73e7213fbcd1f7cb738
 SHA512:
-  metadata.gz: 7b5fc44bdda30345ee8f9034e3fadaf03db8689a032a9982db7afa979e1d148becdad574dd202b81a682d98a1a712f15a88575e31c392102e6287d8b0639c04c
-  data.tar.gz: 3019b6947b830e43e7214fcf0caf375e4f48d874bb168f52c146988dc86973e8cd7425bee83847808958c698c7eca3a9b8147ecc70092c444b10783e4a189f70
+  metadata.gz: 7ae665a639dbecf4971f42a298e3c555b338f9cb8438da022d7cdd9d944e2416f6dc0c3b20e3b98efdba4f3ab0b77486c40a0818d06648c88299fcf2029b796f
+  data.tar.gz: e0e6de2a5fca85f486d96f1e1f43439ddab1613af18f72e873eb80d0c644122df16897d87f31654f8acc7ebdc4bdc399df1feb7d3a04553c645485d44115ca11

data/README.md

@@ -34,29 +34,11 @@ If the above doesn't help, please [submit an issue](https://github.com/fastlane/
 <!-- This table is regenerated and resorted on each release -->
 <table id='team'>
 <tr>
-<td id='matthew-ellis'>
-<a href='https://github.com/matthewellis'>
-<img src='https://github.com/matthewellis.png?size=140'>
-</a>
-<h4 align='center'><a href='https://twitter.com/mellis1995'>Matthew Ellis</a></h4>
-</td>
-<td id='jimmy-dee'>
-<a href='https://github.com/jdee'>
-<img src='https://github.com/jdee.png?size=140'>
-</a>
-<h4 align='center'>Jimmy Dee</h4>
-</td>
-<td id='luka-mirosevic'>
-<a href='https://github.com/lmirosevic'>
-<img src='https://github.com/lmirosevic.png?size=140'>
-</a>
-<h4 align='center'><a href='https://twitter.com/lmirosevic'>Luka Mirosevic</a></h4>
-</td>
-<td id='jorge-revuelta-h'>
-<a href='https://github.com/minuscorp'>
-<img src='https://github.com/minuscorp.png?size=140'>
+<td id='joshua-liebowitz'>
+<a href='https://github.com/taquitos'>
+<img src='https://github.com/taquitos.png?size=140'>
 </a>
-<h4 align='center'><a href='https://twitter.com/minuscorp'>Jorge Revuelta H</a></h4>
+<h4 align='center'><a href='https://twitter.com/taquitos'>Joshua Liebowitz</a></h4>
 </td>
 <td id='jérôme-lacoste'>
 <a href='https://github.com/lacostej'>
@@ -64,51 +46,31 @@ If the above doesn't help, please [submit an issue](https://github.com/fastlane/
 </a>
 <h4 align='center'><a href='https://twitter.com/lacostej'>Jérôme Lacoste</a></h4>
 </td>
-</tr>
-<tr>
-<td id='stefan-natchev'>
-<a href='https://github.com/snatchev'>
-<img src='https://github.com/snatchev.png?size=140'>
-</a>
-<h4 align='center'><a href='https://twitter.com/snatchev'>Stefan Natchev</a></h4>
-</td>
-<td id='daniel-jankowski'>
-<a href='https://github.com/mollyIV'>
-<img src='https://github.com/mollyIV.png?size=140'>
-</a>
-<h4 align='center'><a href='https://twitter.com/mollyIV'>Daniel Jankowski</a></h4>
-</td>
-<td id='iulian-onofrei'>
-<a href='https://github.com/revolter'>
-<img src='https://github.com/revolter.png?size=140'>
+<td id='aaron-brager'>
+<a href='https://github.com/getaaron'>
+<img src='https://github.com/getaaron.png?size=140'>
 </a>
-<h4 align='center'><a href='https://twitter.com/Revolt666'>Iulian Onofrei</a></h4>
+<h4 align='center'><a href='https://twitter.com/getaaron'>Aaron Brager</a></h4>
 </td>
-<td id='felix-krause'>
-<a href='https://github.com/KrauseFx'>
-<img src='https://github.com/KrauseFx.png?size=140'>
+<td id='josh-holtz'>
+<a href='https://github.com/joshdholtz'>
+<img src='https://github.com/joshdholtz.png?size=140'>
 </a>
-<h4 align='center'><a href='https://twitter.com/KrauseFx'>Felix Krause</a></h4>
+<h4 align='center'><a href='https://twitter.com/joshdholtz'>Josh Holtz</a></h4>
 </td>
-<td id='maksym-grebenets'>
-<a href='https://github.com/mgrebenets'>
-<img src='https://github.com/mgrebenets.png?size=140'>
+<td id='max-ott'>
+<a href='https://github.com/max-ott'>
+<img src='https://github.com/max-ott.png?size=140'>
 </a>
-<h4 align='center'><a href='https://twitter.com/mgrebenets'>Maksym Grebenets</a></h4>
+<h4 align='center'><a href='https://twitter.com/ott_max'>Max Ott</a></h4>
 </td>
 </tr>
 <tr>
-<td id='helmut-januschka'>
-<a href='https://github.com/hjanuschka'>
-<img src='https://github.com/hjanuschka.png?size=140'>
-</a>
-<h4 align='center'><a href='https://twitter.com/hjanuschka'>Helmut Januschka</a></h4>
-</td>
-<td id='joshua-liebowitz'>
-<a href='https://github.com/taquitos'>
-<img src='https://github.com/taquitos.png?size=140'>
+<td id='jimmy-dee'>
+<a href='https://github.com/jdee'>
+<img src='https://github.com/jdee.png?size=140'>
 </a>
-<h4 align='center'><a href='https://twitter.com/taquitos'>Joshua Liebowitz</a></h4>
+<h4 align='center'>Jimmy Dee</h4>
 </td>
 <td id='olivier-halligon'>
 <a href='https://github.com/AliSoftware'>
@@ -116,37 +78,49 @@ If the above doesn't help, please [submit an issue](https://github.com/fastlane/
 </a>
 <h4 align='center'><a href='https://twitter.com/aligatr'>Olivier Halligon</a></h4>
 </td>
-<td id='fumiya-nakamura'>
-<a href='https://github.com/nafu'>
-<img src='https://github.com/nafu.png?size=140'>
+<td id='jan-piotrowski'>
+<a href='https://github.com/janpio'>
+<img src='https://github.com/janpio.png?size=140'>
 </a>
-<h4 align='center'><a href='https://twitter.com/nafu003'>Fumiya Nakamura</a></h4>
+<h4 align='center'><a href='https://twitter.com/Sujan'>Jan Piotrowski</a></h4>
 </td>
-<td id='aaron-brager'>
-<a href='https://github.com/getaaron'>
-<img src='https://github.com/getaaron.png?size=140'>
+<td id='kohki-miki'>
+<a href='https://github.com/giginet'>
+<img src='https://github.com/giginet.png?size=140'>
 </a>
-<h4 align='center'><a href='https://twitter.com/getaaron'>Aaron Brager</a></h4>
+<h4 align='center'><a href='https://twitter.com/giginet'>Kohki Miki</a></h4>
 </td>
-</tr>
-<tr>
-<td id='josh-holtz'>
-<a href='https://github.com/joshdholtz'>
-<img src='https://github.com/joshdholtz.png?size=140'>
+<td id='luka-mirosevic'>
+<a href='https://github.com/lmirosevic'>
+<img src='https://github.com/lmirosevic.png?size=140'>
 </a>
-<h4 align='center'><a href='https://twitter.com/joshdholtz'>Josh Holtz</a></h4>
+<h4 align='center'><a href='https://twitter.com/lmirosevic'>Luka Mirosevic</a></h4>
 </td>
+</tr>
+<tr>
 <td id='danielle-tomlinson'>
 <a href='https://github.com/endocrimes'>
 <img src='https://github.com/endocrimes.png?size=140'>
 </a>
 <h4 align='center'><a href='https://twitter.com/endocrimes'>Danielle Tomlinson</a></h4>
 </td>
-<td id='max-ott'>
-<a href='https://github.com/max-ott'>
-<img src='https://github.com/max-ott.png?size=140'>
+<td id='fumiya-nakamura'>
+<a href='https://github.com/nafu'>
+<img src='https://github.com/nafu.png?size=140'>
 </a>
-<h4 align='center'><a href='https://twitter.com/ott_max'>Max Ott</a></h4>
+<h4 align='center'><a href='https://twitter.com/nafu003'>Fumiya Nakamura</a></h4>
+</td>
+<td id='felix-krause'>
+<a href='https://github.com/KrauseFx'>
+<img src='https://github.com/KrauseFx.png?size=140'>
+</a>
+<h4 align='center'><a href='https://twitter.com/KrauseFx'>Felix Krause</a></h4>
+</td>
+<td id='helmut-januschka'>
+<a href='https://github.com/hjanuschka'>
+<img src='https://github.com/hjanuschka.png?size=140'>
+</a>
+<h4 align='center'><a href='https://twitter.com/hjanuschka'>Helmut Januschka</a></h4>
 </td>
 <td id='andrew-mcburney'>
 <a href='https://github.com/armcburney'>
@@ -154,12 +128,6 @@ If the above doesn't help, please [submit an issue](https://github.com/fastlane/
 </a>
 <h4 align='center'><a href='https://twitter.com/armcburney'>Andrew McBurney</a></h4>
 </td>
-<td id='jan-piotrowski'>
-<a href='https://github.com/janpio'>
-<img src='https://github.com/janpio.png?size=140'>
-</a>
-<h4 align='center'><a href='https://twitter.com/Sujan'>Jan Piotrowski</a></h4>
-</td>
 </tr>
 <tr>
 <td id='manu-wallner'>
@@ -168,11 +136,43 @@ If the above doesn't help, please [submit an issue](https://github.com/fastlane/
 </a>
 <h4 align='center'><a href='https://twitter.com/acrooow'>Manu Wallner</a></h4>
 </td>
-<td id='kohki-miki'>
-<a href='https://github.com/giginet'>
-<img src='https://github.com/giginet.png?size=140'>
+<td id='daniel-jankowski'>
+<a href='https://github.com/mollyIV'>
+<img src='https://github.com/mollyIV.png?size=140'>
 </a>
-<h4 align='center'><a href='https://twitter.com/giginet'>Kohki Miki</a></h4>
+<h4 align='center'><a href='https://twitter.com/mollyIV'>Daniel Jankowski</a></h4>
+</td>
+<td id='iulian-onofrei'>
+<a href='https://github.com/revolter'>
+<img src='https://github.com/revolter.png?size=140'>
+</a>
+<h4 align='center'><a href='https://twitter.com/Revolt666'>Iulian Onofrei</a></h4>
+</td>
+<td id='matthew-ellis'>
+<a href='https://github.com/matthewellis'>
+<img src='https://github.com/matthewellis.png?size=140'>
+</a>
+<h4 align='center'><a href='https://twitter.com/mellis1995'>Matthew Ellis</a></h4>
+</td>
+<td id='jorge-revuelta-h'>
+<a href='https://github.com/minuscorp'>
+<img src='https://github.com/minuscorp.png?size=140'>
+</a>
+<h4 align='center'><a href='https://twitter.com/minuscorp'>Jorge Revuelta H</a></h4>
+</td>
+</tr>
+<tr>
+<td id='maksym-grebenets'>
+<a href='https://github.com/mgrebenets'>
+<img src='https://github.com/mgrebenets.png?size=140'>
+</a>
+<h4 align='center'><a href='https://twitter.com/mgrebenets'>Maksym Grebenets</a></h4>
+</td>
+<td id='stefan-natchev'>
+<a href='https://github.com/snatchev'>
+<img src='https://github.com/snatchev.png?size=140'>
+</a>
+<h4 align='center'><a href='https://twitter.com/snatchev'>Stefan Natchev</a></h4>
 </td>
 </table>
 

data/deliver/lib/deliver/options.rb

@@ -165,11 +165,17 @@ module Deliver
         FastlaneCore::ConfigItem.new(key: :auto_release_date,
                                      env_name: "DELIVER_AUTO_RELEASE_DATE",
                                      description: "Date in milliseconds for automatically releasing on pending approval (Can not be used together with `automatic_release`)",
-                                     is_string: false,
+                                     type: Integer,
                                      optional: true,
                                      conflicting_options: [:automatic_release],
                                      conflict_block: proc do |value|
                                        UI.user_error!("You can't use 'auto_release_date' and '#{value.key}' options together.")
+                                     end,
+                                     verify_block: proc do |value|
+                                       now_in_ms = Time.now.to_i * 1000
+                                       if value < now_in_ms
+                                         UI.user_error!("'#{value}' needs to be in the future and in milliseonds (current time is '#{now_in_ms}')")
+                                       end
                                      end),
         FastlaneCore::ConfigItem.new(key: :phased_release,
                                      env_name: "DELIVER_PHASED_RELEASE",

data/deliver/lib/deliver/submit_for_review.rb

@@ -134,10 +134,10 @@ module Deliver
       # Create, update, or delete IDFA declaration
       if uses_idfa == false
         if idfa_declaration
-          UI.verbose("Deleting IDFA delcaration")
+          UI.verbose("Deleting IDFA declaration")
           idfa_declaration.delete!
           updated_idfa = true
-          UI.verbose("Deleted IDFA delcaration")
+          UI.verbose("Deleted IDFA declaration")
         end
       elsif uses_idfa == true
         attributes = {
@@ -148,19 +148,19 @@ module Deliver
         }
 
         if idfa_declaration
-          UI.verbose("Updating IDFA delcaration")
+          UI.verbose("Updating IDFA declaration")
           idfa_declaration.update(attributes: attributes)
-          UI.verbose("Updated IDFA delcaration")
+          UI.verbose("Updated IDFA declaration")
         else
-          UI.verbose("Creating IDFA delcaration")
+          UI.verbose("Creating IDFA declaration")
           version.create_idfa_declaration(attributes: attributes)
-          UI.verbose("Created IDFA delcaration")
+          UI.verbose("Created IDFA declaration")
         end
 
         updated_idfa = true
       end
 
-      UI.success("Successfully updated IDFA delcarations on App Store Connect") if updated_idfa
+      UI.success("Successfully updated IDFA declarations on App Store Connect") if updated_idfa
     end
 
     def update_submission_information(options, app)

data/deliver/lib/deliver/upload_metadata.rb

@@ -614,8 +614,8 @@ module Deliver
       end
       UI.deprecated("You can find more info at https://docs.fastlane.tools/actions/deliver/#reference") if has_mapped_values
 
-      age_rating_delcaration = version.fetch_age_rating_declaration
-      age_rating_delcaration.update(attributes: attributes)
+      age_rating_declaration = version.fetch_age_rating_declaration
+      age_rating_declaration.update(attributes: attributes)
     end
   end
   # rubocop:enable Metrics/ClassLength

data/fastlane/lib/fastlane/actions/docs/upload_to_testflight.md

@@ -229,3 +229,6 @@ If you are on multiple App Store Connect teams, iTunes Transporter may need a pr
 ## Use an Application Specific Password to upload
 
 _pilot_/`upload_to_testflight` can use an [Application Specific Password via the `FASTLANE_APPLE_APPLICATION_SPECIFIC_PASSWORD` envirionment variable](https://docs.fastlane.tools/best-practices/continuous-integration/#application-specific-passwords) to upload a binary if both the `skip_waiting_for_build_processing` and `apple_id` options are set. (If any of those are not set, it will use the normal Apple login process that might require 2FA authentication.)
+
+## Role for App Store Connect User
+_pilot_/`upload_to_testflight` updates build information and testers after the build has finished processing. App Store Connect requires the  "App Manager" or "Admin" role for your Apple account to update this information. The "Developer" role will allow builds to be uploaded but _will not_ allow updating of build information and testers.

data/fastlane/lib/fastlane/actions/notarize.rb

@@ -72,13 +72,23 @@ module Fastlane
 
           UI.message('Querying request status')
 
+          # As of July 2020, the request UUID might not be available for polling yet which returns an error code
+          # This is now handled with the error_callback (which prevents an error from being raised)
+          # Catching this error allows for polling to continue until the notarization is complete
+          error = false
           notarization_info_response = Actions.sh(
             "xcrun altool --notarization-info #{notarization_request_id} -u #{apple_id_account.user} -p @env:FL_NOTARIZE_PASSWORD --output-format xml",
-            log: verbose
+            log: verbose,
+            error_callback: lambda { |msg|
+              error = true
+              UI.error("Error polling for notarization info: #{msg}")
+            }
           )
 
-          notarization_info_plist = Plist.parse_xml(notarization_info_response)
-          notarization_info = notarization_info_plist['notarization-info']
+          unless error
+            notarization_info_plist = Plist.parse_xml(notarization_info_response)
+            notarization_info = notarization_info_plist['notarization-info']
+          end
         end
 
         log_url = notarization_info['LogFileURL']

data/fastlane/lib/fastlane/actions/pod_push.rb

@@ -51,6 +51,10 @@ module Fastlane
           command << "--use-modular-headers"
         end
 
+        if params[:synchronous]
+          command << "--synchronous"
+        end
+
         result = Actions.sh(command.join(' '))
         UI.success("Successfully pushed Podspec ⬆️ ")
         return result
@@ -127,7 +131,12 @@ module Fastlane
                                        description: "Use modular headers option during validation",
                                        optional: true,
                                        type: Boolean,
-                                       env_name: "FL_POD_PUSH_USE_MODULAR_HEADERS")
+                                       env_name: "FL_POD_PUSH_USE_MODULAR_HEADERS"),
+          FastlaneCore::ConfigItem.new(key: :synchronous,
+                                       description: "If validation depends on other recently pushed pods, synchronize",
+                                       optional: true,
+                                       type: Boolean,
+                                       env_name: "FL_POD_PUSH_SYNCHRONOUS")
         ]
       end
 

data/fastlane/lib/fastlane/actions/resign.rb

@@ -108,7 +108,7 @@ module Fastlane
                                        optional: true),
           FastlaneCore::ConfigItem.new(key: :use_app_entitlements,
                                        env_name: "FL_USE_APP_ENTITLEMENTS",
-                                       description: "Extract app bundle codesigning entitlements and combine with entitlements from new provisionin profile",
+                                       description: "Extract app bundle codesigning entitlements and combine with entitlements from new provisioning profile",
                                        conflicting_options: [:entitlements],
                                        is_string: false,
                                        optional: true),

data/fastlane/lib/fastlane/actions/setup_ci.rb

@@ -24,6 +24,11 @@ module Fastlane
       end
 
       def self.setup_keychain
+        unless Helper.mac?
+          UI.message("Skipping Keychain setup on non-macOS CI Agent")
+          return
+        end
+
         unless ENV["MATCH_KEYCHAIN_NAME"].nil?
           UI.message("Skipping Keychain setup as a keychain was already specified")
           return

data/fastlane/lib/fastlane/actions/setup_circle_ci.rb

@@ -41,7 +41,7 @@ module Fastlane
       end
 
       def self.is_supported?(platform)
-        [:ios, :mac].include?(platform)
+        true
       end
 
       def self.example_code

data/fastlane/lib/fastlane/actions/setup_travis.rb

@@ -40,7 +40,7 @@ module Fastlane
       end
 
       def self.is_supported?(platform)
-        [:ios, :mac].include?(platform)
+        true
       end
 
       def self.example_code

data/fastlane/lib/fastlane/actions/upload_symbols_to_crashlytics.rb

@@ -56,6 +56,9 @@ module Fastlane
         UI.message("Uploading '#{path}'...")
         command = []
         command << File.expand_path(params[:binary_path]).shellescape
+        if params[:debug]
+          command << "-d"
+        end
         if params[:app_id]
           command << "-ai #{params[:app_id].shellescape}"
         elsif params[:gsp_path]
@@ -68,7 +71,7 @@ module Fastlane
         begin
           command_to_execute = command.join(" ")
           UI.verbose("upload_dsym using command: #{command_to_execute}")
-          Actions.sh(command_to_execute, log: false)
+          Actions.sh(command_to_execute, log: params[:debug])
         rescue => ex
           UI.error(ex.to_s) # it fails, however we don't want to fail everything just for this
         end
@@ -189,7 +192,12 @@ module Fastlane
                                        verify_block: proc do |value|
                                          min_threads = 1
                                          UI.user_error!("Too few threads (#{value}) minimum number of threads: #{min_threads}") unless value >= min_threads
-                                       end)
+                                       end),
+          FastlaneCore::ConfigItem.new(key: :debug,
+                                       env_name: "FL_UPLOAD_SYMBOLS_TO_CRASHLYTICS_DEBUG",
+                                       description: "Enable debug mode for upload-symbols",
+                                       type: Boolean,
+                                       default_value: false)
         ]
       end
 

data/fastlane/lib/fastlane/documentation/docs_generator.rb

@@ -18,7 +18,7 @@ module Fastlane
       output << "```"
       output << "[sudo] gem install fastlane -NV"
       output << "```"
-      output << "or alternatively using `brew cask install fastlane`"
+      output << "or alternatively using `brew install fastlane`"
       output << ""
       output << "# Available Actions"