fastlane 2.150.1 → 2.151.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 8d3237fc06a48b208196d7032e411bd13b963d7c26ddddbf0202e48f53fbd5c8
-  data.tar.gz: db3869ebbf2d643634ef331898b3432b431fb01da909d3dac694d79cc0b4724d
+  metadata.gz: 464c3b50c55d5218b4d201e97b429d41186c250824e8dc4afb147035b22389bd
+  data.tar.gz: 60decb80f61f2690c2a21917dcffc03e5a09e15885abc7f26aa53d8db7bbf27f
 SHA512:
-  metadata.gz: 7f17b8ef0ec7d70e3600ce0d3d9080083c16f347db7dd5d04b21a8c80552bc96ab07358f08a1e4369fb37e348bcef09ffdef5415c715128fe0b7b89d1cbb2b5a
-  data.tar.gz: 30f46c293961f91d1d0ab85cfb6d06cf783b25c13e0ea307059013f20a906c349bbcda19e3e445ad20cfe0576d2c750f54ffef791f3c0c8c7a206ed23929134c
+  metadata.gz: 86eb7c64a1f3bae172c3741700305415337779bcf6fdfd0ad044de2fe1bcafb373579e229637837c90653237d469f1b896023dedb1e7c6cf6a6a04cdd23efe1c
+  data.tar.gz: 39dd908d4e3bb4d8d2bf7bbe569289967818059fdd990665762509f1d28bbdb500069cdddc56dc52889f0f1c58087cf89e906b1966c25748bc7c65c5e94e8184

data/README.md

@@ -34,49 +34,75 @@ If the above doesn't help, please [submit an issue](https://github.com/fastlane/
 <!-- This table is regenerated and resorted on each release -->
 <table id='team'>
 <tr>
+<td id='daniel-jankowski'>
+<a href='https://github.com/mollyIV'>
+<img src='https://github.com/mollyIV.png?size=140'>
+</a>
+<h4 align='center'><a href='https://twitter.com/mollyIV'>Daniel Jankowski</a></h4>
+</td>
+<td id='luka-mirosevic'>
+<a href='https://github.com/lmirosevic'>
+<img src='https://github.com/lmirosevic.png?size=140'>
+</a>
+<h4 align='center'><a href='https://twitter.com/lmirosevic'>Luka Mirosevic</a></h4>
+</td>
 <td id='maksym-grebenets'>
 <a href='https://github.com/mgrebenets'>
 <img src='https://github.com/mgrebenets.png?size=140'>
 </a>
 <h4 align='center'><a href='https://twitter.com/mgrebenets'>Maksym Grebenets</a></h4>
 </td>
-<td id='jérôme-lacoste'>
-<a href='https://github.com/lacostej'>
-<img src='https://github.com/lacostej.png?size=140'>
+<td id='josh-holtz'>
+<a href='https://github.com/joshdholtz'>
+<img src='https://github.com/joshdholtz.png?size=140'>
 </a>
-<h4 align='center'><a href='https://twitter.com/lacostej'>Jérôme Lacoste</a></h4>
+<h4 align='center'><a href='https://twitter.com/joshdholtz'>Josh Holtz</a></h4>
 </td>
+<td id='joshua-liebowitz'>
+<a href='https://github.com/taquitos'>
+<img src='https://github.com/taquitos.png?size=140'>
+</a>
+<h4 align='center'><a href='https://twitter.com/taquitos'>Joshua Liebowitz</a></h4>
+</td>
+</tr>
+<tr>
 <td id='stefan-natchev'>
 <a href='https://github.com/snatchev'>
 <img src='https://github.com/snatchev.png?size=140'>
 </a>
 <h4 align='center'><a href='https://twitter.com/snatchev'>Stefan Natchev</a></h4>
 </td>
-<td id='max-ott'>
-<a href='https://github.com/max-ott'>
-<img src='https://github.com/max-ott.png?size=140'>
+<td id='andrew-mcburney'>
+<a href='https://github.com/armcburney'>
+<img src='https://github.com/armcburney.png?size=140'>
 </a>
-<h4 align='center'><a href='https://twitter.com/ott_max'>Max Ott</a></h4>
+<h4 align='center'><a href='https://twitter.com/armcburney'>Andrew McBurney</a></h4>
 </td>
-<td id='helmut-januschka'>
-<a href='https://github.com/hjanuschka'>
-<img src='https://github.com/hjanuschka.png?size=140'>
+<td id='jorge-revuelta-h'>
+<a href='https://github.com/minuscorp'>
+<img src='https://github.com/minuscorp.png?size=140'>
 </a>
-<h4 align='center'><a href='https://twitter.com/hjanuschka'>Helmut Januschka</a></h4>
+<h4 align='center'><a href='https://twitter.com/minuscorp'>Jorge Revuelta H</a></h4>
 </td>
-</tr>
-<tr>
-<td id='kohki-miki'>
-<a href='https://github.com/giginet'>
-<img src='https://github.com/giginet.png?size=140'>
+<td id='jimmy-dee'>
+<a href='https://github.com/jdee'>
+<img src='https://github.com/jdee.png?size=140'>
 </a>
-<h4 align='center'><a href='https://twitter.com/giginet'>Kohki Miki</a></h4>
+<h4 align='center'>Jimmy Dee</h4>
 </td>
-<td id='matthew-ellis'>
-<a href='https://github.com/matthewellis'>
-<img src='https://github.com/matthewellis.png?size=140'>
+<td id='iulian-onofrei'>
+<a href='https://github.com/revolter'>
+<img src='https://github.com/revolter.png?size=140'>
 </a>
-<h4 align='center'><a href='https://twitter.com/mellis1995'>Matthew Ellis</a></h4>
+<h4 align='center'><a href='https://twitter.com/Revolt666'>Iulian Onofrei</a></h4>
+</td>
+</tr>
+<tr>
+<td id='jan-piotrowski'>
+<a href='https://github.com/janpio'>
+<img src='https://github.com/janpio.png?size=140'>
+</a>
+<h4 align='center'><a href='https://twitter.com/Sujan'>Jan Piotrowski</a></h4>
 </td>
 <td id='danielle-tomlinson'>
 <a href='https://github.com/endocrimes'>
@@ -84,20 +110,12 @@ If the above doesn't help, please [submit an issue](https://github.com/fastlane/
 </a>
 <h4 align='center'><a href='https://twitter.com/endocrimes'>Danielle Tomlinson</a></h4>
 </td>
-<td id='andrew-mcburney'>
-<a href='https://github.com/armcburney'>
-<img src='https://github.com/armcburney.png?size=140'>
-</a>
-<h4 align='center'><a href='https://twitter.com/armcburney'>Andrew McBurney</a></h4>
-</td>
-<td id='fumiya-nakamura'>
-<a href='https://github.com/nafu'>
-<img src='https://github.com/nafu.png?size=140'>
+<td id='kohki-miki'>
+<a href='https://github.com/giginet'>
+<img src='https://github.com/giginet.png?size=140'>
 </a>
-<h4 align='center'><a href='https://twitter.com/nafu003'>Fumiya Nakamura</a></h4>
+<h4 align='center'><a href='https://twitter.com/giginet'>Kohki Miki</a></h4>
 </td>
-</tr>
-<tr>
 <td id='aaron-brager'>
 <a href='https://github.com/getaaron'>
 <img src='https://github.com/getaaron.png?size=140'>
@@ -110,70 +128,52 @@ If the above doesn't help, please [submit an issue](https://github.com/fastlane/
 </a>
 <h4 align='center'><a href='https://twitter.com/acrooow'>Manu Wallner</a></h4>
 </td>
-<td id='jorge-revuelta-h'>
-<a href='https://github.com/minuscorp'>
-<img src='https://github.com/minuscorp.png?size=140'>
-</a>
-<h4 align='center'><a href='https://twitter.com/minuscorp'>Jorge Revuelta H</a></h4>
-</td>
-<td id='felix-krause'>
-<a href='https://github.com/KrauseFx'>
-<img src='https://github.com/KrauseFx.png?size=140'>
-</a>
-<h4 align='center'><a href='https://twitter.com/KrauseFx'>Felix Krause</a></h4>
-</td>
-<td id='josh-holtz'>
-<a href='https://github.com/joshdholtz'>
-<img src='https://github.com/joshdholtz.png?size=140'>
-</a>
-<h4 align='center'><a href='https://twitter.com/joshdholtz'>Josh Holtz</a></h4>
-</td>
 </tr>
 <tr>
-<td id='luka-mirosevic'>
-<a href='https://github.com/lmirosevic'>
-<img src='https://github.com/lmirosevic.png?size=140'>
+<td id='jérôme-lacoste'>
+<a href='https://github.com/lacostej'>
+<img src='https://github.com/lacostej.png?size=140'>
 </a>
-<h4 align='center'><a href='https://twitter.com/lmirosevic'>Luka Mirosevic</a></h4>
+<h4 align='center'><a href='https://twitter.com/lacostej'>Jérôme Lacoste</a></h4>
 </td>
-<td id='iulian-onofrei'>
-<a href='https://github.com/revolter'>
-<img src='https://github.com/revolter.png?size=140'>
+<td id='fumiya-nakamura'>
+<a href='https://github.com/nafu'>
+<img src='https://github.com/nafu.png?size=140'>
 </a>
-<h4 align='center'><a href='https://twitter.com/Revolt666'>Iulian Onofrei</a></h4>
+<h4 align='center'><a href='https://twitter.com/nafu003'>Fumiya Nakamura</a></h4>
 </td>
-<td id='joshua-liebowitz'>
-<a href='https://github.com/taquitos'>
-<img src='https://github.com/taquitos.png?size=140'>
+<td id='matthew-ellis'>
+<a href='https://github.com/matthewellis'>
+<img src='https://github.com/matthewellis.png?size=140'>
 </a>
-<h4 align='center'><a href='https://twitter.com/taquitos'>Joshua Liebowitz</a></h4>
+<h4 align='center'><a href='https://twitter.com/mellis1995'>Matthew Ellis</a></h4>
 </td>
-<td id='jimmy-dee'>
-<a href='https://github.com/jdee'>
-<img src='https://github.com/jdee.png?size=140'>
+<td id='felix-krause'>
+<a href='https://github.com/KrauseFx'>
+<img src='https://github.com/KrauseFx.png?size=140'>
 </a>
-<h4 align='center'>Jimmy Dee</h4>
+<h4 align='center'><a href='https://twitter.com/KrauseFx'>Felix Krause</a></h4>
 </td>
-<td id='jan-piotrowski'>
-<a href='https://github.com/janpio'>
-<img src='https://github.com/janpio.png?size=140'>
+<td id='helmut-januschka'>
+<a href='https://github.com/hjanuschka'>
+<img src='https://github.com/hjanuschka.png?size=140'>
 </a>
-<h4 align='center'><a href='https://twitter.com/Sujan'>Jan Piotrowski</a></h4>
+<h4 align='center'><a href='https://twitter.com/hjanuschka'>Helmut Januschka</a></h4>
 </td>
 </tr>
 <tr>
-<td id='daniel-jankowski'>
-<a href='https://github.com/mollyIV'>
-<img src='https://github.com/mollyIV.png?size=140'>
-</a>
-<h4 align='center'><a href='https://twitter.com/mollyIV'>Daniel Jankowski</a></h4>
-</td>
 <td id='olivier-halligon'>
 <a href='https://github.com/AliSoftware'>
 <img src='https://github.com/AliSoftware.png?size=140'>
 </a>
 <h4 align='center'><a href='https://twitter.com/aligatr'>Olivier Halligon</a></h4>
 </td>
+<td id='max-ott'>
+<a href='https://github.com/max-ott'>
+<img src='https://github.com/max-ott.png?size=140'>
+</a>
+<h4 align='center'><a href='https://twitter.com/ott_max'>Max Ott</a></h4>
+</td>
 </table>
 
 Special thanks to all [contributors](https://github.com/fastlane/fastlane/graphs/contributors) for extending and improving _fastlane_.

data/deliver/lib/deliver/app_screenshot.rb

@@ -51,9 +51,9 @@ module Deliver
       # iPad iMessage
       IOS_IPAD_MESSAGES = "iOS-iPad-messages"
       # iPad 10.5 iMessage
-      IOS_IPAD_10_5_MESSAGES = "iOS-10.5-messages"
+      IOS_IPAD_10_5_MESSAGES = "iOS-iPad-10.5-messages"
       # iPad 11 iMessage
-      IOS_IPAD_11_MESSAGES = "iOS-11-messages"
+      IOS_IPAD_11_MESSAGES = "iOS-iPad-11-messages"
       # iPad Pro iMessage
       IOS_IPAD_PRO_MESSAGES = "iOS-iPad-Pro-messages"
       # iPad Pro (12.9-inch) (3rd generation) iMessage
@@ -113,8 +113,8 @@ module Deliver
         ScreenSize::IOS_58_MESSAGES => Spaceship::ConnectAPI::AppScreenshotSet::DisplayType::IMESSAGE_APP_IPHONE_58,
         ScreenSize::IOS_65_MESSAGES => Spaceship::ConnectAPI::AppScreenshotSet::DisplayType::IMESSAGE_APP_IPHONE_65,
         ScreenSize::IOS_IPAD_MESSAGES => Spaceship::ConnectAPI::AppScreenshotSet::DisplayType::IMESSAGE_APP_IPAD_97,
-        ScreenSize::IOS_IPAD_PRO_MESSAGES => Spaceship::ConnectAPI::AppScreenshotSet::DisplayType::APP_IPAD_PRO_129,
-        ScreenSize::IOS_IPAD_PRO_12_9_MESSAGES => Spaceship::ConnectAPI::AppScreenshotSet::DisplayType::APP_IPAD_PRO_3GEN_129,
+        ScreenSize::IOS_IPAD_PRO_MESSAGES => Spaceship::ConnectAPI::AppScreenshotSet::DisplayType::IMESSAGE_APP_IPAD_PRO_129,
+        ScreenSize::IOS_IPAD_PRO_12_9_MESSAGES => Spaceship::ConnectAPI::AppScreenshotSet::DisplayType::IMESSAGE_APP_IPAD_PRO_3GEN_129,
         ScreenSize::IOS_IPAD_10_5_MESSAGES => Spaceship::ConnectAPI::AppScreenshotSet::DisplayType::IMESSAGE_APP_IPAD_105,
         ScreenSize::IOS_IPAD_11_MESSAGES => Spaceship::ConnectAPI::AppScreenshotSet::DisplayType::IMESSAGE_APP_IPAD_PRO_3GEN_11,
         ScreenSize::MAC => Spaceship::ConnectAPI::AppScreenshotSet::DisplayType::APP_DESKTOP,

data/deliver/lib/deliver/download_screenshots.rb

@@ -28,42 +28,49 @@ module Deliver
       end
 
       localizations = version.get_app_store_version_localizations
+      threads = []
       localizations.each do |localization|
-        screenshot_sets = localization.get_app_screenshot_sets
-        screenshot_sets.each do |screenshot_set|
-          screenshot_set.app_screenshots.each_with_index do |screenshot, index|
-            file_name = [index, screenshot_set.screenshot_display_type, index].join("_")
-            original_file_extension = File.extname(screenshot.file_name).strip.downcase[1..-1]
-            file_name += "." + original_file_extension
-
-            url = screenshot.image_asset_url(type: original_file_extension)
-            next if url.nil?
+        threads << Thread.new do
+          download_screenshots(folder_path, localization)
+        end
+      end
+      threads.each(&:join)
+    end
 
-            language = localization.locale
+    def self.download_screenshots(folder_path, localization)
+      language = localization.locale
+      screenshot_sets = localization.get_app_screenshot_sets
+      screenshot_sets.each do |screenshot_set|
+        screenshot_set.app_screenshots.each_with_index do |screenshot, index|
+          file_name = [index, screenshot_set.screenshot_display_type, index].join("_")
+          original_file_extension = File.extname(screenshot.file_name).strip.downcase[1..-1]
+          file_name += "." + original_file_extension
 
-            UI.message("Downloading existing screenshot '#{file_name}' for language '#{language}'")
+          url = screenshot.image_asset_url(type: original_file_extension)
+          next if url.nil?
 
-            # If the screen shot is for an appleTV we need to store it in a way that we'll know it's an appleTV
-            # screen shot later as the screen size is the same as an iPhone 6 Plus in landscape.
-            if screenshot_set.apple_tv?
-              containing_folder = File.join(folder_path, "appleTV", language)
-            else
-              containing_folder = File.join(folder_path, language)
-            end
+          UI.message("Downloading existing screenshot '#{file_name}' for language '#{language}'")
 
-            if screenshot_set.imessage?
-              containing_folder = File.join(folder_path, "iMessage", language)
-            end
+          # If the screen shot is for an appleTV we need to store it in a way that we'll know it's an appleTV
+          # screen shot later as the screen size is the same as an iPhone 6 Plus in landscape.
+          if screenshot_set.apple_tv?
+            containing_folder = File.join(folder_path, "appleTV", language)
+          else
+            containing_folder = File.join(folder_path, language)
+          end
 
-            begin
-              FileUtils.mkdir_p(containing_folder)
-            rescue
-              # if it's already there
-            end
+          if screenshot_set.imessage?
+            containing_folder = File.join(folder_path, "iMessage", language)
+          end
 
-            path = File.join(containing_folder, file_name)
-            File.binwrite(path, open(url).read)
+          begin
+            FileUtils.mkdir_p(containing_folder)
+          rescue
+            # if it's already there
           end
+
+          path = File.join(containing_folder, file_name)
+          File.binwrite(path, open(url).read)
         end
       end
     end

data/deliver/lib/deliver/options.rb

@@ -165,11 +165,17 @@ module Deliver
         FastlaneCore::ConfigItem.new(key: :auto_release_date,
                                      env_name: "DELIVER_AUTO_RELEASE_DATE",
                                      description: "Date in milliseconds for automatically releasing on pending approval (Can not be used together with `automatic_release`)",
-                                     is_string: false,
+                                     type: Integer,
                                      optional: true,
                                      conflicting_options: [:automatic_release],
                                      conflict_block: proc do |value|
                                        UI.user_error!("You can't use 'auto_release_date' and '#{value.key}' options together.")
+                                     end,
+                                     verify_block: proc do |value|
+                                       now_in_ms = Time.now.to_i * 1000
+                                       if value < now_in_ms
+                                         UI.user_error!("'#{value}' needs to be in the future and in milliseonds (current time is '#{now_in_ms}')")
+                                       end
                                      end),
         FastlaneCore::ConfigItem.new(key: :phased_release,
                                      env_name: "DELIVER_PHASED_RELEASE",

data/deliver/lib/deliver/runner.rb

@@ -34,6 +34,11 @@ module Deliver
 
     def run
       verify_version if options[:app_version].to_s.length > 0 && !options[:skip_app_version_update]
+
+      # Rejecting before upload meta
+      # Screenshots can not be update/deleted if in waiting for review
+      reject_version_if_possible if options[:reject_if_possible]
+
       upload_metadata
 
       has_binary = (options[:ipa] || options[:pkg])
@@ -43,8 +48,6 @@ module Deliver
 
       UI.success("Finished the upload to App Store Connect") unless options[:skip_binary_upload]
 
-      reject_version_if_possible if options[:reject_if_possible]
-
       precheck_success = precheck_app
       submit_for_review if options[:submit_for_review] && precheck_success
     end
@@ -163,7 +166,8 @@ module Deliver
       app_id = legacy_app.apple_id
       app = Spaceship::ConnectAPI::App.get(app_id: app_id)
 
-      if app.reject_version_if_possible!
+      platform = Spaceship::ConnectAPI::Platform.map(options[:platform])
+      if app.reject_version_if_possible!(platform: platform)
         UI.success("Successfully rejected previous version!")
       end
     end

data/deliver/lib/deliver/submit_for_review.rb

@@ -134,10 +134,10 @@ module Deliver
       # Create, update, or delete IDFA declaration
       if uses_idfa == false
         if idfa_declaration
-          UI.verbose("Deleting IDFA delcaration")
+          UI.verbose("Deleting IDFA declaration")
           idfa_declaration.delete!
           updated_idfa = true
-          UI.verbose("Deleted IDFA delcaration")
+          UI.verbose("Deleted IDFA declaration")
         end
       elsif uses_idfa == true
         attributes = {
@@ -148,19 +148,19 @@ module Deliver
         }
 
         if idfa_declaration
-          UI.verbose("Updating IDFA delcaration")
+          UI.verbose("Updating IDFA declaration")
           idfa_declaration.update(attributes: attributes)
-          UI.verbose("Updated IDFA delcaration")
+          UI.verbose("Updated IDFA declaration")
         else
-          UI.verbose("Creating IDFA delcaration")
+          UI.verbose("Creating IDFA declaration")
           version.create_idfa_declaration(attributes: attributes)
-          UI.verbose("Created IDFA delcaration")
+          UI.verbose("Created IDFA declaration")
         end
 
         updated_idfa = true
       end
 
-      UI.success("Successfully updated IDFA delcarations on App Store Connect") if updated_idfa
+      UI.success("Successfully updated IDFA declarations on App Store Connect") if updated_idfa
     end
 
     def update_submission_information(options, app)

data/deliver/lib/deliver/upload_metadata.rb

@@ -271,7 +271,7 @@ module Deliver
           next if k.nil? || v.nil?
           next if k == v
           has_mapped_values = true
-          UI.deprecated("Category '#{k}' from iTunesConnect as been deprecated. Please replace with '#{v}'")
+          UI.deprecated("Category '#{k}' from iTunesConnect has been deprecated. Please replace with '#{v}'")
         end
         UI.deprecated("You can find more info at https://docs.fastlane.tools/actions/deliver/#reference") if has_mapped_values
 
@@ -330,7 +330,7 @@ module Deliver
       seconds_in_hour = 60 * 60
       time_in_s_to_hour = (time_in_s / seconds_in_hour).to_i * seconds_in_hour
 
-      return Time.at(time_in_s_to_hour).strftime("%Y-%m-%dT%H:%M:%S%:z")
+      return Time.at(time_in_s_to_hour).utc.strftime("%Y-%m-%dT%H:%M:%S%:z")
     end
 
     # If the user is using the 'default' language, then assign values where they are needed
@@ -610,12 +610,12 @@ module Deliver
         next if k.nil? || v.nil?
         next if k == v
         has_mapped_values = true
-        UI.deprecated("Age rating '#{k}' from iTunesConnect as been deprecated. Please replace with '#{v}'")
+        UI.deprecated("Age rating '#{k}' from iTunesConnect has been deprecated. Please replace with '#{v}'")
       end
       UI.deprecated("You can find more info at https://docs.fastlane.tools/actions/deliver/#reference") if has_mapped_values
 
-      age_rating_delcaration = version.fetch_age_rating_declaration
-      age_rating_delcaration.update(attributes: attributes)
+      age_rating_declaration = version.fetch_age_rating_declaration
+      age_rating_declaration.update(attributes: attributes)
     end
   end
   # rubocop:enable Metrics/ClassLength