fastlane 2.149.1 → 2.150.0.rc5

data/fastlane/lib/fastlane/actions/docs/upload_to_play_store.md

@@ -171,9 +171,10 @@ A common Play publishing scenario might involve uploading an APK version to a te
 
 This can be done using the `--track_promote_to` parameter. The `--track_promote_to` parameter works with the `--track` parameter to command the Play API to promote existing Play track APK version(s) (those active on the track identified by the `--track` param value) to a new track (`--track_promote_to` value).
 
-## Retrieve Track Version Codes
+## Retrieve Track Release Names & Version Codes
 
-Before performing a new APK upload you may want to check existing track version codes, or you may simply want to provide an informational lane that displays the currently promoted version codes for the production track. You can use the `google_play_track_version_codes` action to retrieve existing version codes for a package and track. For more information, see `fastlane action google_play_track_version_codes` help output.
+Before performing a new APK upload you may want to check existing track version codes or release names, or you may simply want to provide an informational lane that displays the currently promoted version codes or release name for the production track. You can use the `google_play_track_version_codes` action to retrieve existing version codes for a package and track. You can use the `google_play_track_release_names` action to retrieve existing release names for a package and track.
+For more information, see the `fastlane action google_play_track_version_codes` and `fastlane action google_play_track_release_names` help output.
 
 ## Migration from AndroidPublisherV2 to AndroidPublisherV3 in _fastlane_ 2.135.0
 

data/fastlane/lib/fastlane/actions/download_dsyms.rb

@@ -164,7 +164,13 @@ module Fastlane
 
       def self.download_file(url)
         uri = URI.parse(url)
-        http = Net::HTTP.new(uri.host, uri.port)
+        if ENV['http_proxy']
+          UI.verbose("Found 'http_proxy' environment variable so connect via proxy")
+          proxy_uri = URI.parse(ENV['http_proxy'])
+          http = Net::HTTP.new(uri.host, uri.port, proxy_uri.host, proxy_uri.port)
+        else
+          http = Net::HTTP.new(uri.host, uri.port)
+        end
         http.use_ssl = (uri.scheme == "https")
         res = http.get(uri.request_uri)
         res.body

data/fastlane/lib/fastlane/actions/google_play_track_release_names.rb

@@ -0,0 +1,74 @@
+module Fastlane
+  module Actions
+    class GooglePlayTrackReleaseNamesAction < Action
+      # Supply::Options.available_options keys that apply to this action.
+      OPTIONS = [
+        :package_name,
+        :track,
+        :key,
+        :issuer,
+        :json_key,
+        :json_key_data,
+        :root_url,
+        :timeout
+      ]
+
+      def self.run(params)
+        require 'supply'
+        require 'supply/options'
+        require 'supply/reader'
+
+        Supply.config = params
+
+        release_names = Supply::Reader.new.track_release_names || []
+        return release_names.compact
+      end
+
+      #####################################################
+      # @!group Documentation
+      #####################################################
+
+      def self.description
+        "Retrieves release names for a Google Play track"
+      end
+
+      def self.details
+        "More information: [https://docs.fastlane.tools/actions/supply/](https://docs.fastlane.tools/actions/supply/)"
+      end
+
+      def self.available_options
+        require 'supply'
+        require 'supply/options'
+
+        Supply::Options.available_options.select do |option|
+          OPTIONS.include?(option.key)
+        end
+      end
+
+      def self.output
+      end
+
+      def self.return_value
+        "Array of strings representing the release names for the given Google Play track"
+      end
+
+      def self.authors
+        ["raldred"]
+      end
+
+      def self.is_supported?(platform)
+        platform == :android
+      end
+
+      def self.example_code
+        [
+          'google_play_track_release_names'
+        ]
+      end
+
+      def self.category
+        :misc
+      end
+    end
+  end
+end

data/fastlane/lib/fastlane/actions/set_changelog.rb

@@ -9,16 +9,18 @@ module Fastlane
         Spaceship::Tunes.select_team
         UI.message("Login successful")
 
-        app = Spaceship::Application.find(params[:app_identifier]) || Spaceship::Application.find(params[:app_identifier], mac: true)
+        app = Spaceship::ConnectAPI::App.find(params[:app_identifier])
         UI.user_error!("Couldn't find app with identifier #{params[:app_identifier]}") if app.nil?
 
         version_number = params[:version]
-        platform = params[:platform]
+        platform = Spaceship::ConnectAPI::Platform.map(params[:platform])
+
         unless version_number
           # Automatically fetch the latest version
           UI.message("Fetching the latest version for this app")
-          if app.edit_version(platform: platform) && app.edit_version(platform: platform).version
-            version_number = app.edit_version(platform: platform).version
+          edit_version = app.get_edit_app_store_version(platform: platform)
+          if edit_version
+            version_number = edit_version.version_string
           else
             UI.message("You have to specify a new version number: ")
             version_number = STDIN.gets.strip
@@ -42,31 +44,32 @@ module Fastlane
 
         UI.important("Going to update the changelog to:\n\n#{changelog}\n\n")
 
-        if (v = app.edit_version(platform: platform))
-          if v.version != version_number
+        edit_version = app.get_edit_app_store_version(platform: platform)
+        if edit_version
+          if edit_version.version_string != version_number
             # Version is already there, make sure it matches the one we want to create
-            UI.message("Changing existing version number from '#{v.version}' to '#{version_number}'")
-            v.version = version_number
-            v.save!
+            UI.message("Changing existing version number from '#{edit_version.version_string}' to '#{version_number}'")
+            edit_version = edit_version.update(attributes: {
+              versionString: version_number
+            })
           else
-            UI.message("Updating changelog for existing version #{v.version}")
+            UI.message("Updating changelog for existing version #{edit_version.version_string}")
           end
         else
           UI.message("Creating the new version: #{version_number}")
-          app.create_version!(version_number)
-          app = Spaceship::Application.find(params[:app_identifier]) # Replace with .reload method once available
-          v = app.edit_version(platform: platform)
+          attributes = { versionString: version_number, platform: platform }
+          edit_version = Spaceship::ConnectAPI.post_app_store_version(app_id: app.id, attributes: attributes).first
         end
 
-        v.release_notes.languages.each do |lang|
-          v.release_notes[lang] = changelog
+        localizations = edit_version.get_app_store_version_localizations
+        localizations.each do |localization|
+          UI.message("Updating changelog for the '#{localization.locale}'")
+          localization.update(attributes: {
+            whatsNew: changelog
+          })
         end
 
-        UI.message("Found and updated changelog for the following languages: #{v.release_notes.languages.join(', ')}")
-        UI.message("Uploading changes to App Store Connect...")
-        v.save!
-
-        UI.success("👼  Successfully pushed the new changelog to #{v.url}")
+        UI.success("👼  Successfully pushed the new changelog to for #{edit_version.version_string}")
       end
 
       def self.default_changelog_path

data/fastlane/lib/fastlane/actions/slack.rb

@@ -159,7 +159,7 @@ module Fastlane
               "Build Date" => Time.new.to_s,
               "Built by" => "Jenkins",
             },
-            default_payloads: [:git_branch, :git_author], # Optional, lets you specify a whitelist of default payloads to include. Pass an empty array to suppress all the default payloads.
+            default_payloads: [:git_branch, :git_author], # Optional, lets you specify an allowlist of default payloads to include. Pass an empty array to suppress all the default payloads.
                                                           # Don\'t add this key, or pass nil, if you want all the default payloads. The available default payloads are: `lane`, `test_result`, `git_branch`, `git_author`, `last_git_commit`, `last_git_commit_hash`.
             attachment_properties: { # Optional, lets you specify any other properties available for attachments in the slack API (see https://api.slack.com/docs/attachments).
                                      # This hash is deep merged with the existing properties set using the other properties above. This allows your own fields properties to be appended to the existing fields that were created using the `payload` property for instance.

data/fastlane/lib/fastlane/actions/spm.rb

@@ -8,6 +8,7 @@ module Fastlane
         cmd << "--build-path #{params[:build_path]}" if params[:build_path]
         cmd << "--package-path #{params[:package_path]}" if params[:package_path]
         cmd << "--configuration #{params[:configuration]}" if params[:configuration]
+        cmd << "--disable-sandbox" if params[:disable_sandbox]
         cmd << "--verbose" if params[:verbose]
         cmd << params[:command] if package_commands.include?(params[:command])
         if params[:xcconfig]
@@ -63,6 +64,12 @@ module Fastlane
                                        verify_block: proc do |value|
                                          UI.user_error!("Please pass a valid configuration: (debug|release)") unless valid_configurations.include?(value)
                                        end),
+          FastlaneCore::ConfigItem.new(key: :disable_sandbox,
+                                       env_name: "FL_SPM_DISABLE_SANDBOX",
+                                       description: "Disable using the sandbox when executing subprocesses",
+                                       optional: true,
+                                       is_string: false,
+                                       default_value: false),
           FastlaneCore::ConfigItem.new(key: :xcpretty_output,
                                        env_name: "FL_SPM_XCPRETTY_OUTPUT",
                                        description: "Specifies the output type for xcpretty. eg. 'test', or 'simple'",

data/fastlane/lib/fastlane/actions/upload_symbols_to_crashlytics.rb

@@ -45,44 +45,13 @@ module Fastlane
       # @param current_path this is a path to either a dSYM or a zipped dSYM
       #   this might also be either nested or not, we're flexible
       def self.handle_dsym(params, current_path, max_worker_threads)
-        if current_path.end_with?(".dSYM")
+        if current_path.end_with?(".dSYM", ".zip")
           upload_dsym(params, current_path)
-        elsif current_path.end_with?(".zip")
-          UI.message("Extracting '#{current_path}'...")
-
-          current_path = File.expand_path(current_path)
-          Dir.mktmpdir do |dir|
-            Dir.chdir(dir) do
-              Actions.sh("unzip -qo #{current_path.shellescape}")
-              work_q = Queue.new
-              Dir["*.dSYM"].each do |sub|
-                work_q.push(sub)
-              end
-              execute_uploads(params, max_worker_threads, work_q)
-            end
-          end
         else
           UI.error("Don't know how to handle '#{current_path}'")
         end
       end
 
-      def self.execute_uploads(params, max_worker_threads, work_q)
-        number_of_threads = [max_worker_threads, work_q.size].min
-        workers = (0...number_of_threads).map do
-          Thread.new do
-            begin
-              while work_q.size > 0
-                current_path = work_q.pop(true)
-                upload_dsym(params, current_path)
-              end
-            rescue => ex
-              UI.error(ex.to_s)
-            end
-          end
-        end
-        workers.map(&:join)
-      end
-
       def self.upload_dsym(params, path)
         UI.message("Uploading '#{path}'...")
         command = []

data/fastlane/lib/fastlane/lane.rb

@@ -41,8 +41,8 @@ module Fastlane
     class << self
       # Makes sure the lane name is valid
       def verify_lane_name(name)
-        if self.black_list.include?(name.to_s)
-          UI.error("Lane name '#{name}' is invalid! Invalid names are #{self.black_list.join(', ')}.")
+        if self.deny_list.include?(name.to_s)
+          UI.error("Lane name '#{name}' is invalid! Invalid names are #{self.deny_list.join(', ')}.")
           UI.user_error!("Lane name '#{name}' is invalid")
         end
 
@@ -59,7 +59,7 @@ module Fastlane
         self.ensure_name_not_conflicts(name.to_s)
       end
 
-      def black_list
+      def deny_list
         %w(
           run
           init

data/fastlane/lib/fastlane/swift_fastlane_function.rb

@@ -98,7 +98,11 @@ module Fastlane
       elsif type_override == Float
         return "Float"
       elsif type_override == :string_callback
-        return "((String) -> Void)"
+        # David Hart:
+        # It doesn't make sense to add escaping annotations to optional closures because they aren't function types:
+        # they are basically an enum (Optional) containing a function, the same way you would store a closure in any type:
+        # it's implicitly escaping because it's owned by another type.
+        return "((String) -> Void)?"
       else
         return default_type
       end
@@ -106,7 +110,7 @@ module Fastlane
 
     def override_default_value_if_not_correct_type(param_name: nil, param_type: nil, default_value: nil)
       return "[]" if param_type == "[String]" && default_value == ""
-      return "{_ in }" if param_type == "((String) -> Void)"
+      return "nil" if param_type == "((String) -> Void)?"
 
       return default_value
     end
@@ -121,7 +125,7 @@ module Fastlane
 
       optional_specifier = ""
       # if we are optional and don't have a default value, we'll need to use ?
-      optional_specifier = "?" if (optional && default_value.nil?) && type != "((String) -> Void)"
+      optional_specifier = "?" if (optional && default_value.nil?) && type != "((String) -> Void)?"
 
       # If we have a default value of true or false, we can infer it is a Bool
       if default_value.class == FalseClass
@@ -162,7 +166,7 @@ module Fastlane
             # we can't handle default values for Hashes, yet
             # see method swift_default_implementations for similar behavior
             default_value = "[:]"
-          elsif type != "Bool" && type != "[String]" && type != "Int" && type != "((String) -> Void)" && type != "Float" && type != "Double"
+          elsif type != "Bool" && type != "[String]" && type != "Int" && type != "@escaping ((String) -> Void)" && type != "Float" && type != "Double"
             default_value = "\"#{default_value}\""
           end
         end

data/fastlane/lib/fastlane/version.rb

@@ -1,5 +1,5 @@
 module Fastlane
-  VERSION = '2.149.1'.freeze
+  VERSION = '2.150.0.rc5'.freeze
   DESCRIPTION = "The easiest way to automate beta deployments and releases for your iOS and Android apps".freeze
   MINIMUM_XCODE_RELEASE = "7.0".freeze
   RUBOCOP_REQUIREMENT = '0.49.1'.freeze

data/fastlane/swift/ControlCommand.swift

@@ -49,6 +49,7 @@ struct ControlCommand: RubyCommandable {
     }
 
     let message: String?
+    let id: String = UUID().uuidString
     let shutdownCommandType: ShutdownCommandType
     var commandJson: String {
         var jsonDictionary: [String: Any] = [ControlCommand.commandKey : self.shutdownCommandType.token]

data/fastlane/swift/Fastlane.swift

@@ -1491,7 +1491,7 @@ func captureIosScreenshots(workspace: String? = nil,
                            appIdentifier: String? = nil,
                            addPhotos: [String]? = nil,
                            addVideos: [String]? = nil,
-                           htmlTemplate: String = "/Users/josh/Projects/fastlane/fastlane/snapshot/lib/snapshot/page.html.erb",
+                           htmlTemplate: String? = nil,
                            buildlogPath: String = "~/Library/Logs/snapshot",
                            clean: Bool = false,
                            testWithoutBuilding: Bool? = nil,
@@ -1625,7 +1625,7 @@ func captureScreenshots(workspace: String? = nil,
                         appIdentifier: String? = nil,
                         addPhotos: [String]? = nil,
                         addVideos: [String]? = nil,
-                        htmlTemplate: String = "/Users/josh/Projects/fastlane/fastlane/snapshot/lib/snapshot/page.html.erb",
+                        htmlTemplate: String? = nil,
                         buildlogPath: String = "~/Library/Logs/snapshot",
                         clean: Bool = false,
                         testWithoutBuilding: Bool? = nil,
@@ -2039,7 +2039,7 @@ func cocoapods(repoUpdate: Bool = false,
                ansi: Bool = true,
                useBundleExec: Bool = true,
                podfile: String? = nil,
-               errorCallback: Any? = nil,
+               errorCallback: ((String) -> Void)? = nil,
                tryRepoUpdateOnError: Bool = false,
                deployment: Bool = false,
                clean: Bool = true,
@@ -2051,7 +2051,7 @@ func cocoapods(repoUpdate: Bool = false,
                                                                                            RubyCommand.Argument(name: "ansi", value: ansi),
                                                                                            RubyCommand.Argument(name: "use_bundle_exec", value: useBundleExec),
                                                                                            RubyCommand.Argument(name: "podfile", value: podfile),
-                                                                                           RubyCommand.Argument(name: "error_callback", value: errorCallback),
+                                                                                           RubyCommand.Argument(name: "error_callback", value: errorCallback, type: .stringClosure),
                                                                                            RubyCommand.Argument(name: "try_repo_update_on_error", value: tryRepoUpdateOnError),
                                                                                            RubyCommand.Argument(name: "deployment", value: deployment),
                                                                                            RubyCommand.Argument(name: "clean", value: clean),
@@ -3054,7 +3054,7 @@ func frameScreenshots(white: Bool? = nil,
                       useLegacyIphonexr: Bool = false,
                       useLegacyIphonexs: Bool = false,
                       useLegacyIphonexsmax: Bool = false,
-                      forceOrientationBlock: String? = nil,
+                      forceOrientationBlock: ((String) -> Void)? = nil,
                       debugMode: Bool = false,
                       resume: Bool = false,
                       usePlatform: String = "IOS",
@@ -3071,7 +3071,7 @@ func frameScreenshots(white: Bool? = nil,
                                                                                                    RubyCommand.Argument(name: "use_legacy_iphonexr", value: useLegacyIphonexr),
                                                                                                    RubyCommand.Argument(name: "use_legacy_iphonexs", value: useLegacyIphonexs),
                                                                                                    RubyCommand.Argument(name: "use_legacy_iphonexsmax", value: useLegacyIphonexsmax),
-                                                                                                   RubyCommand.Argument(name: "force_orientation_block", value: forceOrientationBlock),
+                                                                                                   RubyCommand.Argument(name: "force_orientation_block", value: forceOrientationBlock, type: .stringClosure),
                                                                                                    RubyCommand.Argument(name: "debug_mode", value: debugMode),
                                                                                                    RubyCommand.Argument(name: "resume", value: resume),
                                                                                                    RubyCommand.Argument(name: "use_platform", value: usePlatform),
@@ -3116,7 +3116,7 @@ func frameit(white: Bool? = nil,
              useLegacyIphonexr: Bool = false,
              useLegacyIphonexs: Bool = false,
              useLegacyIphonexsmax: Bool = false,
-             forceOrientationBlock: String? = nil,
+             forceOrientationBlock: ((String) -> Void)? = nil,
              debugMode: Bool = false,
              resume: Bool = false,
              usePlatform: String = "IOS",
@@ -3133,7 +3133,7 @@ func frameit(white: Bool? = nil,
                                                                                          RubyCommand.Argument(name: "use_legacy_iphonexr", value: useLegacyIphonexr),
                                                                                          RubyCommand.Argument(name: "use_legacy_iphonexs", value: useLegacyIphonexs),
                                                                                          RubyCommand.Argument(name: "use_legacy_iphonexsmax", value: useLegacyIphonexsmax),
-                                                                                         RubyCommand.Argument(name: "force_orientation_block", value: forceOrientationBlock),
+                                                                                         RubyCommand.Argument(name: "force_orientation_block", value: forceOrientationBlock, type: .stringClosure),
                                                                                          RubyCommand.Argument(name: "debug_mode", value: debugMode),
                                                                                          RubyCommand.Argument(name: "resume", value: resume),
                                                                                          RubyCommand.Argument(name: "use_platform", value: usePlatform),
@@ -3639,6 +3639,42 @@ func githubApi(serverUrl: String = "https://api.github.com",
   _ = runner.executeCommand(command)
 }
 
+/**
+ Retrieves release names for a Google Play track
+
+ - parameters:
+   - packageName: The package name of the application to use
+   - track: The track of the application to use. The default available tracks are: production, beta, alpha, internal
+   - key: **DEPRECATED!** Use `--json_key` instead - The p12 File used to authenticate with Google
+   - issuer: **DEPRECATED!** Use `--json_key` instead - The issuer of the p12 file (email address of the service account)
+   - jsonKey: The path to a file containing service account JSON, used to authenticate with Google
+   - jsonKeyData: The raw service account JSON data used to authenticate with Google
+   - rootUrl: Root URL for the Google Play API. The provided URL will be used for API calls in place of https://www.googleapis.com/
+   - timeout: Timeout for read, open, and send (in seconds)
+
+ - returns: Array of strings representing the release names for the given Google Play track
+
+ More information: [https://docs.fastlane.tools/actions/supply/](https://docs.fastlane.tools/actions/supply/)
+*/
+func googlePlayTrackReleaseNames(packageName: String,
+                                 track: String = "production",
+                                 key: String? = nil,
+                                 issuer: String? = nil,
+                                 jsonKey: String? = nil,
+                                 jsonKeyData: String? = nil,
+                                 rootUrl: String? = nil,
+                                 timeout: Int = 300) {
+  let command = RubyCommand(commandID: "", methodName: "google_play_track_release_names", className: nil, args: [RubyCommand.Argument(name: "package_name", value: packageName),
+                                                                                                                 RubyCommand.Argument(name: "track", value: track),
+                                                                                                                 RubyCommand.Argument(name: "key", value: key),
+                                                                                                                 RubyCommand.Argument(name: "issuer", value: issuer),
+                                                                                                                 RubyCommand.Argument(name: "json_key", value: jsonKey),
+                                                                                                                 RubyCommand.Argument(name: "json_key_data", value: jsonKeyData),
+                                                                                                                 RubyCommand.Argument(name: "root_url", value: rootUrl),
+                                                                                                                 RubyCommand.Argument(name: "timeout", value: timeout)])
+  _ = runner.executeCommand(command)
+}
+
 /**
  Retrieves version codes for a Google Play track
 
@@ -6520,10 +6556,10 @@ func setupTravis(force: Bool = false) {
 */
 @discardableResult func sh(command: String,
                            log: Bool = true,
-                           errorCallback: Any? = nil) -> String {
+                           errorCallback: ((String) -> Void)? = nil) -> String {
   let command = RubyCommand(commandID: "", methodName: "sh", className: nil, args: [RubyCommand.Argument(name: "command", value: command),
                                                                                     RubyCommand.Argument(name: "log", value: log),
-                                                                                    RubyCommand.Argument(name: "error_callback", value: errorCallback)])
+                                                                                    RubyCommand.Argument(name: "error_callback", value: errorCallback, type: .stringClosure)])
   return runner.executeCommand(command)
 }
 
@@ -6868,7 +6904,7 @@ func snapshot(workspace: Any? = snapshotfile.workspace,
               appIdentifier: Any? = snapshotfile.appIdentifier,
               addPhotos: [String]? = snapshotfile.addPhotos,
               addVideos: [String]? = snapshotfile.addVideos,
-              htmlTemplate: Any = snapshotfile.htmlTemplate,
+              htmlTemplate: Any? = snapshotfile.htmlTemplate,
               buildlogPath: Any = snapshotfile.buildlogPath,
               clean: Bool = snapshotfile.clean,
               testWithoutBuilding: Bool? = snapshotfile.testWithoutBuilding,
@@ -8924,4 +8960,4 @@ let snapshotfile: Snapshotfile = Snapshotfile()
 
 // Please don't remove the lines below
 // They are used to detect outdated files
-// FastlaneRunnerAPIVersion [0.9.77]
+// FastlaneRunnerAPIVersion [0.9.71]