fastlane 2.145.0 → 2.146.0

data/fastlane/lib/fastlane/actions/upload_symbols_to_crashlytics.rb

@@ -130,7 +130,7 @@ module Fastlane
       end
 
       def self.find_binary_path(params)
-        params[:binary_path] ||= (Dir["/Applications/Fabric.app/**/upload-symbols"] + Dir["./Pods/**/upload-symbols"]).last
+        params[:binary_path] ||= (Dir["/Applications/Fabric.app/**/upload-symbols"] + Dir["./Pods/Fabric/upload-symbols"] + Dir["./Pods/FirebaseCrashlytics/upload-symbols"]).last
         UI.user_error!("Failed to find Fabric's upload_symbols binary at /Applications/Fabric.app/**/upload-symbols or ./Pods/**/upload-symbols. Please specify the location of the binary explicitly by using the binary_path option") unless params[:binary_path]
 
         params[:binary_path] = File.expand_path(params[:binary_path])

data/fastlane/lib/fastlane/helper/s3_client_helper.rb

@@ -7,16 +7,14 @@ module Fastlane
 
       def initialize(access_key: nil, secret_access_key: nil, region: nil)
         creds = Aws::Credentials.new(access_key, secret_access_key)
-        Aws.config.update({
+        Aws.config.update(
           region: region,
           credentials: creds
-        })
-
-        @client = Aws::S3::Client.new
+        )
       end
 
       def list_buckets
-        return @client.list_buckets
+        return client.list_buckets
       end
 
       def upload_file(bucket_name, file_name, file_data, acl)
@@ -40,17 +38,24 @@ module Fastlane
         obj.public_url.to_s
       end
 
-      def delete_file(bucket, file_name)
+      def delete_file(bucket_name, file_name)
         bucket = find_bucket!(bucket_name)
-        bucket.objects[file_name].delete
+        file = bucket.object(file_name)
+        file.delete
       end
 
       def find_bucket!(bucket_name)
-        bucket = Aws::S3::Bucket.new(bucket_name, client: @client)
+        bucket = Aws::S3::Bucket.new(bucket_name, client: client)
         raise "Bucket '#{bucket_name}' not found" unless bucket.exists?
 
         return bucket
       end
     end
+
+    private
+
+    def client
+      @client ||= Aws::S3::Client.new
+    end
   end
 end

data/fastlane/lib/fastlane/version.rb

@@ -1,5 +1,5 @@
 module Fastlane
-  VERSION = '2.145.0'.freeze
+  VERSION = '2.146.0'.freeze
   DESCRIPTION = "The easiest way to automate beta deployments and releases for your iOS and Android apps".freeze
   MINIMUM_XCODE_RELEASE = "7.0".freeze
   RUBOCOP_REQUIREMENT = '0.49.1'.freeze

data/fastlane/swift/Deliverfile.swift

@@ -18,4 +18,4 @@ class Deliverfile: DeliverfileProtocol {
 
 
 
-// Generated with fastlane 2.145.0
+// Generated with fastlane 2.146.0

data/fastlane/swift/Fastlane.swift

@@ -2215,6 +2215,7 @@ func createAppOnManagedPlayStore(jsonKey: String? = nil,
    - appVersion: Initial version number (e.g. '1.0')
    - sku: SKU Number (e.g. '1234')
    - platform: The platform to use (optional)
+   - platforms: The platforms to use (optional)
    - language: Primary Language (e.g. 'English', 'German')
    - companyName: The name of your company. Only required if it's the first app you create
    - skipItc: Skip the creation of the app on App Store Connect
@@ -2238,6 +2239,7 @@ func createAppOnline(username: String,
                      appVersion: String? = nil,
                      sku: String,
                      platform: String = "ios",
+                     platforms: [String]? = nil,
                      language: String = "English",
                      companyName: String? = nil,
                      skipItc: Bool = false,
@@ -2256,6 +2258,7 @@ func createAppOnline(username: String,
                                                                                                    RubyCommand.Argument(name: "app_version", value: appVersion),
                                                                                                    RubyCommand.Argument(name: "sku", value: sku),
                                                                                                    RubyCommand.Argument(name: "platform", value: platform),
+                                                                                                   RubyCommand.Argument(name: "platforms", value: platforms),
                                                                                                    RubyCommand.Argument(name: "language", value: language),
                                                                                                    RubyCommand.Argument(name: "company_name", value: companyName),
                                                                                                    RubyCommand.Argument(name: "skip_itc", value: skipItc),
@@ -2316,6 +2319,7 @@ func createKeychain(name: String? = nil,
    - repo: The name of the repository you want to submit the pull request to
    - title: The title of the pull request
    - body: The contents of the pull request
+   - draft: Indicates whether the pull request is a draft
    - labels: The labels for the pull request
    - milestone: The milestone ID (Integer) for the pull request
    - head: The name of the branch where your changes are implemented (defaults to the current branch name)
@@ -2331,6 +2335,7 @@ func createPullRequest(apiToken: String,
                        repo: String,
                        title: String,
                        body: String? = nil,
+                       draft: Bool? = nil,
                        labels: [String]? = nil,
                        milestone: String? = nil,
                        head: String? = nil,
@@ -2343,6 +2348,7 @@ func createPullRequest(apiToken: String,
                                                                                                      RubyCommand.Argument(name: "repo", value: repo),
                                                                                                      RubyCommand.Argument(name: "title", value: title),
                                                                                                      RubyCommand.Argument(name: "body", value: body),
+                                                                                                     RubyCommand.Argument(name: "draft", value: draft),
                                                                                                      RubyCommand.Argument(name: "labels", value: labels),
                                                                                                      RubyCommand.Argument(name: "milestone", value: milestone),
                                                                                                      RubyCommand.Argument(name: "head", value: head),
@@ -4956,6 +4962,8 @@ func pem(development: Bool = false,
    - usesNonExemptEncryption: Provide the 'Uses Non-Exempt Encryption' for export compliance. This is used if there is 'ITSAppUsesNonExemptEncryption' is not set in the Info.plist
    - distributeExternal: Should the build be distributed to external testers?
    - notifyExternalTesters: Should notify external testers?
+   - appVersion: The version number of the application build to distribute. If the version number is not specified, then the most recent build uploaded to TestFlight will be distributed. If specified, the most recent build for the version number will be distributed
+   - buildNumber: The build number of the application build to distribute. If the build number is not specified, the most recent build is distributed
    - firstName: The tester's first name
    - lastName: The tester's last name
    - email: The tester's email
@@ -4990,6 +4998,8 @@ func pilot(username: String,
            usesNonExemptEncryption: Bool = false,
            distributeExternal: Bool = false,
            notifyExternalTesters: Bool = true,
+           appVersion: String? = nil,
+           buildNumber: String? = nil,
            firstName: String? = nil,
            lastName: String? = nil,
            email: String? = nil,
@@ -5020,6 +5030,8 @@ func pilot(username: String,
                                                                                        RubyCommand.Argument(name: "uses_non_exempt_encryption", value: usesNonExemptEncryption),
                                                                                        RubyCommand.Argument(name: "distribute_external", value: distributeExternal),
                                                                                        RubyCommand.Argument(name: "notify_external_testers", value: notifyExternalTesters),
+                                                                                       RubyCommand.Argument(name: "app_version", value: appVersion),
+                                                                                       RubyCommand.Argument(name: "build_number", value: buildNumber),
                                                                                        RubyCommand.Argument(name: "first_name", value: firstName),
                                                                                        RubyCommand.Argument(name: "last_name", value: lastName),
                                                                                        RubyCommand.Argument(name: "email", value: email),
@@ -5250,6 +5262,7 @@ func println(message: String? = nil) {
    - appVersion: Initial version number (e.g. '1.0')
    - sku: SKU Number (e.g. '1234')
    - platform: The platform to use (optional)
+   - platforms: The platforms to use (optional)
    - language: Primary Language (e.g. 'English', 'German')
    - companyName: The name of your company. Only required if it's the first app you create
    - skipItc: Skip the creation of the app on App Store Connect
@@ -5273,6 +5286,7 @@ func produce(username: String,
              appVersion: String? = nil,
              sku: String,
              platform: String = "ios",
+             platforms: [String]? = nil,
              language: String = "English",
              companyName: String? = nil,
              skipItc: Bool = false,
@@ -5291,6 +5305,7 @@ func produce(username: String,
                                                                                          RubyCommand.Argument(name: "app_version", value: appVersion),
                                                                                          RubyCommand.Argument(name: "sku", value: sku),
                                                                                          RubyCommand.Argument(name: "platform", value: platform),
+                                                                                         RubyCommand.Argument(name: "platforms", value: platforms),
                                                                                          RubyCommand.Argument(name: "language", value: language),
                                                                                          RubyCommand.Argument(name: "company_name", value: companyName),
                                                                                          RubyCommand.Argument(name: "skip_itc", value: skipItc),
@@ -6377,13 +6392,16 @@ func setupCircleCi(force: Bool = false) {
    - resultBundle: Produce the result bundle describing what occurred will be placed
 
  - Adds and unlocks keychains from Jenkins 'Keychains and Provisioning Profiles Plugin'|
+ - Sets unlocked keychain to be used by Match|
  - Sets code signing identity from Jenkins 'Keychains and Provisioning Profiles Plugin'|
  - Sets output directory to './output' (gym, scan and backup_xcarchive)|
  - Sets derived data path to './derivedData' (xcodebuild, gym, scan and clear_derived_data, carthage)|
  - Produce result bundle (gym and scan)|
  >|
  This action helps with Jenkins integration. Creates own derived data for each job. All build results like IPA files and archives will be stored in the `./output` directory.
- The action also works with [Keychains and Provisioning Profiles Plugin](https://wiki.jenkins-ci.org/display/JENKINS/Keychains+and+Provisioning+Profiles+Plugin), the selected keychain will be automatically unlocked and the selected code signing identity will be used. By default this action will only work when _fastlane_ is executed on a CI system.
+ The action also works with [Keychains and Provisioning Profiles Plugin](https://wiki.jenkins-ci.org/display/JENKINS/Keychains+and+Provisioning+Profiles+Plugin), the selected keychain will be automatically unlocked and the selected code signing identity will be used.
+ [Match](https://docs.fastlane.tools/actions/match/) will be also set up to use the unlocked keychain and set in read-only mode, if its environment variables were not yet defined.
+ By default this action will only work when _fastlane_ is executed on a CI system.
 */
 func setupJenkins(force: Bool = false,
                   unlockKeychain: Bool = true,
@@ -7372,6 +7390,8 @@ func testfairy(apiKey: String,
    - usesNonExemptEncryption: Provide the 'Uses Non-Exempt Encryption' for export compliance. This is used if there is 'ITSAppUsesNonExemptEncryption' is not set in the Info.plist
    - distributeExternal: Should the build be distributed to external testers?
    - notifyExternalTesters: Should notify external testers?
+   - appVersion: The version number of the application build to distribute. If the version number is not specified, then the most recent build uploaded to TestFlight will be distributed. If specified, the most recent build for the version number will be distributed
+   - buildNumber: The build number of the application build to distribute. If the build number is not specified, the most recent build is distributed
    - firstName: The tester's first name
    - lastName: The tester's last name
    - email: The tester's email
@@ -7406,6 +7426,8 @@ func testflight(username: String,
                 usesNonExemptEncryption: Bool = false,
                 distributeExternal: Bool = false,
                 notifyExternalTesters: Bool = true,
+                appVersion: String? = nil,
+                buildNumber: String? = nil,
                 firstName: String? = nil,
                 lastName: String? = nil,
                 email: String? = nil,
@@ -7436,6 +7458,8 @@ func testflight(username: String,
                                                                                             RubyCommand.Argument(name: "uses_non_exempt_encryption", value: usesNonExemptEncryption),
                                                                                             RubyCommand.Argument(name: "distribute_external", value: distributeExternal),
                                                                                             RubyCommand.Argument(name: "notify_external_testers", value: notifyExternalTesters),
+                                                                                            RubyCommand.Argument(name: "app_version", value: appVersion),
+                                                                                            RubyCommand.Argument(name: "build_number", value: buildNumber),
                                                                                             RubyCommand.Argument(name: "first_name", value: firstName),
                                                                                             RubyCommand.Argument(name: "last_name", value: lastName),
                                                                                             RubyCommand.Argument(name: "email", value: email),
@@ -7581,6 +7605,7 @@ func updateAppIdentifier(xcodeproj: String,
    - useAutomaticSigning: Defines if project should use automatic signing
    - teamId: Team ID, is used when upgrading project
    - targets: Specify targets you want to toggle the signing mech. (default to all targets)
+   - buildConfigurations: Specify build_configurations you want to toggle the signing mech. (default to all targets)
    - codeSignIdentity: Code signing identity type (iPhone Developer, iPhone Distribution)
    - profileName: Provisioning profile name to use for code signing
    - profileUuid: Provisioning profile UUID to use for code signing
@@ -7594,6 +7619,7 @@ func updateCodeSigningSettings(path: String,
                                useAutomaticSigning: Bool = false,
                                teamId: String? = nil,
                                targets: [String]? = nil,
+                               buildConfigurations: [String]? = nil,
                                codeSignIdentity: String? = nil,
                                profileName: String? = nil,
                                profileUuid: String? = nil,
@@ -7602,6 +7628,7 @@ func updateCodeSigningSettings(path: String,
                                                                                                               RubyCommand.Argument(name: "use_automatic_signing", value: useAutomaticSigning),
                                                                                                               RubyCommand.Argument(name: "team_id", value: teamId),
                                                                                                               RubyCommand.Argument(name: "targets", value: targets),
+                                                                                                              RubyCommand.Argument(name: "build_configurations", value: buildConfigurations),
                                                                                                               RubyCommand.Argument(name: "code_sign_identity", value: codeSignIdentity),
                                                                                                               RubyCommand.Argument(name: "profile_name", value: profileName),
                                                                                                               RubyCommand.Argument(name: "profile_uuid", value: profileUuid),
@@ -8269,6 +8296,8 @@ func uploadToPlayStoreInternalAppSharing(packageName: String,
    - usesNonExemptEncryption: Provide the 'Uses Non-Exempt Encryption' for export compliance. This is used if there is 'ITSAppUsesNonExemptEncryption' is not set in the Info.plist
    - distributeExternal: Should the build be distributed to external testers?
    - notifyExternalTesters: Should notify external testers?
+   - appVersion: The version number of the application build to distribute. If the version number is not specified, then the most recent build uploaded to TestFlight will be distributed. If specified, the most recent build for the version number will be distributed
+   - buildNumber: The build number of the application build to distribute. If the build number is not specified, the most recent build is distributed
    - firstName: The tester's first name
    - lastName: The tester's last name
    - email: The tester's email
@@ -8303,6 +8332,8 @@ func uploadToTestflight(username: String,
                         usesNonExemptEncryption: Bool = false,
                         distributeExternal: Bool = false,
                         notifyExternalTesters: Bool = true,
+                        appVersion: String? = nil,
+                        buildNumber: String? = nil,
                         firstName: String? = nil,
                         lastName: String? = nil,
                         email: String? = nil,
@@ -8333,6 +8364,8 @@ func uploadToTestflight(username: String,
                                                                                                       RubyCommand.Argument(name: "uses_non_exempt_encryption", value: usesNonExemptEncryption),
                                                                                                       RubyCommand.Argument(name: "distribute_external", value: distributeExternal),
                                                                                                       RubyCommand.Argument(name: "notify_external_testers", value: notifyExternalTesters),
+                                                                                                      RubyCommand.Argument(name: "app_version", value: appVersion),
+                                                                                                      RubyCommand.Argument(name: "build_number", value: buildNumber),
                                                                                                       RubyCommand.Argument(name: "first_name", value: firstName),
                                                                                                       RubyCommand.Argument(name: "last_name", value: lastName),
                                                                                                       RubyCommand.Argument(name: "email", value: email),
@@ -8787,4 +8820,4 @@ let snapshotfile: Snapshotfile = Snapshotfile()
 
 // Please don't remove the lines below
 // They are used to detect outdated files
-// FastlaneRunnerAPIVersion [0.9.73]
+// FastlaneRunnerAPIVersion [0.9.74]

data/fastlane/swift/Gymfile.swift

@@ -18,4 +18,4 @@ class Gymfile: GymfileProtocol {
 
 
 
-// Generated with fastlane 2.145.0
+// Generated with fastlane 2.146.0

data/fastlane/swift/Matchfile.swift

@@ -18,4 +18,4 @@ class Matchfile: MatchfileProtocol {
 
 
 
-// Generated with fastlane 2.145.0
+// Generated with fastlane 2.146.0

data/fastlane/swift/Precheckfile.swift

@@ -18,4 +18,4 @@ class Precheckfile: PrecheckfileProtocol {
 
 
 
-// Generated with fastlane 2.145.0
+// Generated with fastlane 2.146.0

data/fastlane/swift/Scanfile.swift

@@ -18,4 +18,4 @@ class Scanfile: ScanfileProtocol {
 
 
 
-// Generated with fastlane 2.145.0
+// Generated with fastlane 2.146.0

data/fastlane/swift/Screengrabfile.swift

@@ -18,4 +18,4 @@ class Screengrabfile: ScreengrabfileProtocol {
 
 
 
-// Generated with fastlane 2.145.0
+// Generated with fastlane 2.146.0

data/fastlane/swift/Snapshotfile.swift

@@ -18,4 +18,4 @@ class Snapshotfile: SnapshotfileProtocol {
 
 
 
-// Generated with fastlane 2.145.0
+// Generated with fastlane 2.146.0

data/fastlane_core/lib/fastlane_core/configuration/config_item.rb

@@ -2,6 +2,7 @@ require_relative '../ui/ui'
 require_relative '../ui/errors/fastlane_error'
 require_relative '../helper'
 require_relative '../module'
+require 'json'
 
 module FastlaneCore
   class ConfigItem
@@ -227,6 +228,7 @@ module FastlaneCore
       true
     end
 
+    # rubocop:disable Metrics/PerceivedComplexity
     # Returns an updated value type (if necessary)
     def auto_convert_value(value)
       return nil if value.nil?
@@ -240,6 +242,12 @@ module FastlaneCore
       elsif allow_shell_conversion
         return value.shelljoin if value.kind_of?(Array)
         return value.map { |k, v| "#{k.to_s.shellescape}=#{v.shellescape}" }.join(' ') if value.kind_of?(Hash)
+      elsif data_type == Hash && value.kind_of?(String)
+        begin
+          parsed = JSON.parse(value)
+          return parsed if parsed.kind_of?(Hash)
+        rescue JSON::ParserError
+        end
       elsif data_type != String
         # Special treatment if the user specified true, false or YES, NO
         # There is no boolean type, so we just do it here
@@ -249,6 +257,7 @@ module FastlaneCore
           return false
         end
       end
+      # rubocop:enable Metrics/PerceivedComplexity
 
       return value # fallback to not doing anything
     end

data/fastlane_core/lib/fastlane_core/device_manager.rb

@@ -49,8 +49,8 @@ module FastlaneCore
 
             # "    iPad (5th generation) (852A5796-63C3-4641-9825-65EBDC5C4259) (Shutdown)"
             # This line will turn the above string into
-            # ["iPad", "(5th generation)", "(852A5796-63C3-4641-9825-65EBDC5C4259)", "(Shutdown)"]
-            matches = line.strip.scan(/(.*?) (\(.*?\))/).flatten.reject(&:empty?)
+            # ["iPad (5th generation)", "(852A5796-63C3-4641-9825-65EBDC5C4259)", "(Shutdown)"]
+            matches = line.strip.scan(/^(.*?) (\([^)]*?\)) (\([^)]*?\))$/).flatten.reject(&:empty?)
             state = matches.pop.to_s.delete('(').delete(')')
             udid = matches.pop.to_s.delete('(').delete(')')
             name = matches.join(' ')

data/frameit/lib/frameit/editor.rb

@@ -535,7 +535,7 @@ module Frameit
         fonts.each do |font|
           if font['supported']
             font['supported'].each do |language|
-              if screenshot.path.include?(language)
+              if screenshot.language == language
                 return font["font"]
               end
             end

data/frameit/lib/frameit/screenshot.rb

@@ -122,6 +122,10 @@ module Frameit
       return File.mtime(path) > File.mtime(output_path)
     end
 
+    def language
+      @language ||= Pathname.new(path).parent.basename.to_s
+    end
+
     def to_s
       self.path
     end

data/match/lib/match/importer.rb

@@ -50,6 +50,8 @@ module Match
         certificate_type = Spaceship::ConnectAPI::Certificate::CertificateType::IOS_DEVELOPMENT + "," + Spaceship::ConnectAPI::Certificate::CertificateType::DEVELOPMENT
       when :distribution, :enterprise
         certificate_type = Spaceship::ConnectAPI::Certificate::CertificateType::IOS_DISTRIBUTION + "," + Spaceship::ConnectAPI::Certificate::CertificateType::DISTRIBUTION
+      when :developer_id_application
+        certificate_type = Spaceship::ConnectAPI::Certificate::CertificateType::DEVELOPER_ID_APPLICATION
       else
         UI.user_error!("Cert type '#{cert_type}' is not supported")
       end

data/match/lib/match/storage/s3_storage.rb

@@ -89,7 +89,7 @@ module Match
         self.working_directory = Dir.mktmpdir
 
         s3_client.find_bucket!(s3_bucket).objects.each do |object|
-          file_path = object.public_url.to_s.split("s3.amazonaws.com/").last
+          file_path = object.key # :team_id/path/to/file
           download_path = File.join(self.working_directory, file_path)
 
           FileUtils.mkdir_p(File.expand_path("..", download_path))
@@ -111,17 +111,17 @@ module Match
         # Those doesn't mean they're new, it might just be they're changed
         # Either way, we'll upload them using the same technique
 
-        files_to_upload.each do |current_file|
+        files_to_upload.each do |file_name|
           # Go from
           #   "/var/folders/px/bz2kts9n69g8crgv4jpjh6b40000gn/T/d20181026-96528-1av4gge/profiles/development/Development_me.mobileprovision"
           # to
           #   "profiles/development/Development_me.mobileprovision"
           #
 
-          target_path = current_file.gsub(self.working_directory + "/", "")
+          target_path = sanitize_file_name(file_name)
           UI.verbose("Uploading '#{target_path}' to S3 Storage...")
 
-          body = File.read(current_file)
+          body = File.read(file_name)
           acl = 'private'
           s3_url = s3_client.upload_file(s3_bucket, target_path, body, acl)
           UI.verbose("Uploaded '#{s3_url}' to S3 Storage.")
@@ -130,7 +130,8 @@ module Match
 
       def delete_files(files_to_delete: [], custom_message: nil)
         files_to_delete.each do |file_name|
-          s3_client.delete_file(s3_bucket, file_name)
+          target_path = sanitize_file_name(file_name)
+          s3_client.delete_file(s3_bucket, target_path)
         end
       end
 
@@ -147,6 +148,10 @@ module Match
 
       private
 
+      def sanitize_file_name(file_name)
+        file_name.gsub(self.working_directory + "/", "")
+      end
+
       def currently_used_team_id
         if self.readonly
           # In readonly mode, we still want to see if the user provided a team_id

data/pilot/lib/pilot/build_manager.rb

@@ -118,9 +118,17 @@ module Pilot
 
       # Get latest uploaded build if no build specified
       if build.nil?
-        UI.important("No build specified - fetching latest build")
+        app_version = config[:app_version]
+        build_number = config[:build_number]
+        if build_number.nil?
+          if app_version.nil?
+            UI.important("No build specified - fetching latest build")
+          else
+            UI.important("No build specified - fetching latest build for version #{app_version}")
+          end
+        end
         platform = Spaceship::ConnectAPI::Platform.map(fetch_app_platform)
-        build ||= Spaceship::ConnectAPI::Build.all(app_id: app.id, sort: "-uploadedDate", platform: platform, limit: 1).first
+        build ||= Spaceship::ConnectAPI::Build.all(app_id: app.id, version: app_version, build_number: build_number, sort: "-uploadedDate", platform: platform, limit: 1).first
       end
 
       # Verify the build has all the includes that we need
@@ -207,8 +215,11 @@ module Pilot
     end
 
     def update_beta_app_meta(options, build)
-      # Setting account required wth AppStore Connect API
-      update_review_detail(build, { demo_account_required: options[:demo_account_required] })
+      # If demo_account_required is a parameter, it should added into beta_app_review_info
+      unless options[:demo_account_required].nil?
+        options[:beta_app_review_info] = {} if options[:beta_app_review_info].nil?
+        options[:beta_app_review_info][:demo_account_required] = options[:demo_account_required]
+      end
 
       if should_update_beta_app_review_info(options)
         update_review_detail(build, options[:beta_app_review_info])