fastlane 2.141.0 → 2.146.0

data/spaceship/lib/spaceship/connect_api/models/build.rb

@@ -79,8 +79,7 @@ module Spaceship
       end
 
       def ready_for_internal_testing?
-        raise "No build_beta_detail included" unless build_beta_detail
-        return build_beta_detail.ready_for_internal_testing?
+        return build_beta_detail.nil? == false && build_beta_detail.ready_for_internal_testing?
       end
 
       def ready_for_beta_submission?

data/spaceship/lib/spaceship/connect_api/models/certificate.rb

@@ -22,6 +22,8 @@ module Spaceship
       })
 
       module CertificateType
+        DEVELOPMENT = "DEVELOPMENT"
+        DISTRIBUTION = "DISTRIBUTION"
         IOS_DEVELOPMENT = "IOS_DEVELOPMENT"
         IOS_DISTRIBUTION = "IOS_DISTRIBUTION"
         MAC_APP_DISTRIBUTION = "MAC_APP_DISTRIBUTION"

data/spaceship/lib/spaceship/connect_api/testflight/testflight.rb

@@ -181,6 +181,29 @@ module Spaceship
         Client.instance.post("builds/#{build_id}/relationships/betaGroups", body)
       end
 
+      def create_beta_group(app_id: nil, group_name: nil, public_link_enabled: false, public_link_limit: 10_000, public_link_limit_enabled: false)
+        body = {
+          data: {
+            attributes: {
+              name: group_name,
+              publicLinkEnabled: public_link_enabled,
+              publicLinkLimit: public_link_limit,
+              publicLinkLimitEnabled: public_link_limit_enabled
+            },
+            relationships: {
+              app: {
+                data: {
+                  id: app_id,
+                  type: "apps"
+                }
+              }
+            },
+            type: "betaGroups"
+          }
+        }
+        Client.instance.post("betaGroups", body)
+      end
+
       #
       # betaTesters
       #

data/spaceship/lib/spaceship/portal/app_service.rb

@@ -59,11 +59,11 @@ module Spaceship
       NetworkExtension = AppService.new_service("NWEXT04537")
       NFCTagReading = AppService.new_service("NFCTRMAY17")
       PersonalVPN = AppService.new_service("V66P55NK2I")
-      Passbook = AppService.new_service("pass")
+      Passbook = AppService.new_service("passbook")
       PushNotification = AppService.new_service("push")
       SiriKit = AppService.new_service("SI015DKUHP")
       VPNConfiguration = AppService.new_service("V66P55NK2I")
-      Wallet = AppService.new_service("pass")
+      Wallet = AppService.new_service("passbook")
       WirelessAccessory = AppService.new_service("WC421J6T7P")
 
       constants.each do |c|

data/spaceship/lib/spaceship/portal/portal_client.rb

@@ -100,6 +100,19 @@ module Spaceship
     end
     private :platform_slug
 
+    def list_pending_agreements(language: "en")
+      r = request(:post) do |req|
+        req.url("account/listPendingAgreements")
+        req.body = {
+          teamId: team_id,
+          languageIsoCode: language
+        }.to_json
+        req.headers['Content-Type'] = 'application/json'
+      end
+
+      return parse_response(r)
+    end
+
     #####################################################
     # @!group Apps
     #####################################################

data/spaceship/lib/spaceship/tunes/app_version.rb

@@ -767,14 +767,19 @@ module Spaceship
       end
 
       def setup_screenshots
-        # Enable Scaling for all screen sizes that don't have at least one screenshot
+        # Enable Scaling for all screen sizes that don't have at least one screenshot or at least one trailer (app_preview)
         # We automatically disable scaling once we upload at least one screenshot
         language_details = raw_data_details.each do |current_language|
           language_details = (current_language["displayFamilies"] || {})["value"]
           (language_details || []).each do |device_language_details|
+            # Do not enable scaling if a screenshot already exists
             next if device_language_details["screenshots"].nil?
             next if device_language_details["screenshots"]["value"].count > 0
 
+            # Do not enable scaling if a trailer already exists
+            next if device_language_details["trailers"].nil?
+            next if device_language_details["trailers"]["value"].count > 0
+
             # The current row includes screenshots for all device types
             # so we need to enable scaling for both iOS and watchOS apps
             device_language_details["scaled"]["value"] = true if device_language_details["scaled"]

data/spaceship/lib/spaceship/tunes/application.rb

@@ -91,7 +91,7 @@ module Spaceship
         # @param platform (String): Platform one of (ios,osx)
         #  should it be an ios or an osx app
 
-        def create!(name: nil, primary_language: nil, version: nil, sku: nil, bundle_id: nil, bundle_id_suffix: nil, company_name: nil, platform: nil, itunes_connect_users: nil)
+        def create!(name: nil, primary_language: nil, version: nil, sku: nil, bundle_id: nil, bundle_id_suffix: nil, company_name: nil, platform: nil, platforms: nil, itunes_connect_users: nil)
           puts("The `version` parameter is deprecated. Use `ensure_version!` method instead") if version
           client.create_application!(name: name,
                          primary_language: primary_language,
@@ -100,6 +100,7 @@ module Spaceship
                                 bundle_id_suffix: bundle_id_suffix,
                                 company_name: company_name,
                                     platform: platform,
+                                    platforms: platforms,
                                     itunes_connect_users: itunes_connect_users)
         end
 

data/spaceship/lib/spaceship/tunes/tunes_client.rb

@@ -286,7 +286,7 @@ module Spaceship
     # @param sku (String): A unique ID for your app that is not visible on the App Store.
     # @param bundle_id (String): The bundle ID must match the one you used in Xcode. It
     #   can't be changed after you submit your first build.
-    def create_application!(name: nil, primary_language: nil, version: nil, sku: nil, bundle_id: nil, bundle_id_suffix: nil, company_name: nil, platform: nil, itunes_connect_users: nil)
+    def create_application!(name: nil, primary_language: nil, version: nil, sku: nil, bundle_id: nil, bundle_id_suffix: nil, company_name: nil, platform: nil, platforms: nil, itunes_connect_users: nil)
       puts("The `version` parameter is deprecated. Use `Spaceship::Tunes::Application.ensure_version!` method instead") if version
 
       # First, we need to fetch the data from Apple, which we then modify with the user's values
@@ -307,7 +307,7 @@ module Spaceship
       data['enabledPlatformsForCreation'] = { value: [platform] }
 
       data['initialPlatform'] = platform
-      data['enabledPlatformsForCreation'] = { value: [platform] }
+      data['enabledPlatformsForCreation'] = { value: platforms || [platform] }
 
       unless itunes_connect_users.nil?
         data['iTunesConnectUsers']['grantedAllUsers'] = false

data/spaceship/lib/spaceship/two_step_or_factor_client.rb

@@ -131,18 +131,33 @@ module Spaceship
         puts("Environment variable `SPACESHIP_2FA_SMS_DEFAULT_PHONE_NUMBER` is set, automatically requesting 2FA token via SMS to that number")
         puts("SPACESHIP_2FA_SMS_DEFAULT_PHONE_NUMBER = #{env_2fa_sms_default_phone_number}")
         puts("")
+
         phone_number = env_2fa_sms_default_phone_number
         phone_id = phone_id_from_number(response.body["trustedPhoneNumbers"], phone_number)
+        # don't request sms if no trusted devices and env default is the only trusted number,
+        # code was automatically sent
+        should_request_code = !sms_automatically_sent(response)
+        code_type = 'phone'
+        body = request_two_factor_code_from_phone(phone_id, phone_number, code_length, should_request_code)
+      elsif sms_automatically_sent(response) # sms fallback, code was automatically sent
+        fallback_number = response.body["trustedPhoneNumbers"].first
+        phone_number = fallback_number["numberWithDialCode"]
+        phone_id = fallback_number["id"]
+
+        code_type = 'phone'
+        body = request_two_factor_code_from_phone(phone_id, phone_number, code_length, false)
+      elsif sms_fallback(response) # sms fallback but code wasn't sent bec > 1 phone number
         code_type = 'phone'
-        body = request_two_factor_code_from_phone(phone_id, phone_number, code_length)
+        body = request_two_factor_code_from_phone_choose(response.body["trustedPhoneNumbers"], code_length)
       else
         puts("(Input `sms` to escape this prompt and select a trusted phone number to send the code as a text message)")
         puts("")
         puts("(You can also set the environment variable `SPACESHIP_2FA_SMS_DEFAULT_PHONE_NUMBER` to automate this)")
-        puts("(Read more at: https://github.com/fastlane/fastlane/blob/master/spaceship/docs/Authentication.md#auto-select-sms-via-spaceship-2fa-sms-default-phone-number)")
+        puts("(Read more at: https://github.com/fastlane/fastlane/blob/master/spaceship/docs/Authentication.md#auto-select-sms-via-spaceship_2fa_sms_default_phone_number)")
         puts("")
-        code_type = 'trusteddevice'
+
         code = ask_for_2fa_code("Please enter the #{code_length} digit code:")
+        code_type = 'trusteddevice'
         body = { "securityCode" => { "code" => code.to_s } }.to_json
 
         # User exited by entering `sms` and wants to choose phone number for SMS
@@ -191,11 +206,30 @@ module Spaceship
       return true
     end
 
+    # For reference in case auth behavior changes:
+    # The "noTrustedDevices" field is only present
+    # in the response for `GET /appleauth/auth`
+
+    # Account is not signed into any devices that can display a verification code
+    def sms_fallback(response)
+      response.body["noTrustedDevices"]
+    end
+
+    # see `sms_fallback` + account has only one trusted number for receiving an sms
+    def sms_automatically_sent(response)
+      (response.body["trustedPhoneNumbers"] || []).count == 1 && sms_fallback(response)
+    end
+
     # extracted into its own method for testing
     def ask_for_2fa_code(text)
       ask(text)
     end
 
+    # extracted into its own method for testing
+    def choose_phone_number(opts)
+      choose(*opts)
+    end
+
     def phone_id_from_number(phone_numbers, phone_number)
       characters_to_remove_from_phone_numbers = ' \-()"'
 
@@ -247,27 +281,29 @@ If it is, please open an issue at https://github.com/fastlane/fastlane/issues/ne
       available = phone_numbers.collect do |current|
         current['numberWithDialCode']
       end
-      chosen = choose(*available)
+      chosen = choose_phone_number(available)
       phone_id = phone_id_from_masked_number(phone_numbers, chosen)
 
       request_two_factor_code_from_phone(phone_id, chosen, code_length)
     end
 
     # this is used in two places: after choosing a phone number and when a phone number is set via ENV var
-    def request_two_factor_code_from_phone(phone_id, phone_number, code_length)
-      # Request code
-      r = request(:put) do |req|
-        req.url("https://idmsa.apple.com/appleauth/auth/verify/phone")
-        req.headers['Content-Type'] = 'application/json'
-        req.body = { "phoneNumber" => { "id" => phone_id }, "mode" => "sms" }.to_json
-        update_request_headers(req)
-      end
+    def request_two_factor_code_from_phone(phone_id, phone_number, code_length, should_request_code = true)
+      if should_request_code
+        # Request code
+        r = request(:put) do |req|
+          req.url("https://idmsa.apple.com/appleauth/auth/verify/phone")
+          req.headers['Content-Type'] = 'application/json'
+          req.body = { "phoneNumber" => { "id" => phone_id }, "mode" => "sms" }.to_json
+          update_request_headers(req)
+        end
 
-      # we use `Spaceship::TunesClient.new.handle_itc_response`
-      # since this might be from the Dev Portal, but for 2 step
-      Spaceship::TunesClient.new.handle_itc_response(r.body)
+        # we use `Spaceship::TunesClient.new.handle_itc_response`
+        # since this might be from the Dev Portal, but for 2 step
+        Spaceship::TunesClient.new.handle_itc_response(r.body)
 
-      puts("Successfully requested text message to #{phone_number}")
+        puts("Successfully requested text message to #{phone_number}")
+      end
 
       code = ask_for_2fa_code("Please enter the #{code_length} digit code you received at #{phone_number}:")
 

data/supply/lib/supply/client.rb

@@ -244,7 +244,7 @@ module Supply
         UI.message("Found '#{version}' in '#{filtered_track.track}' track.")
       end
 
-      filtered_release = filtered_track.releases.first { |r| r.name == version }
+      filtered_release = filtered_track.releases.first { |r| !r.name.nil? && r.name == version }
 
       # Since we can release on Alpha/Beta without release notes.
       if filtered_release.release_notes.nil?
@@ -258,13 +258,13 @@ module Supply
     end
 
     def latest_version(track)
-      latest_version = tracks.select { |t| t.track == Supply::Tracks::DEFAULT }.map(&:releases).flatten.max_by(&:name)
+      latest_version = tracks.select { |t| t.track == Supply::Tracks::DEFAULT }.map(&:releases).flatten.reject { |r| r.name.nil? }.max_by(&:name)
 
       # Check if user specified '--track' option if version information from 'production' track is nil
       if latest_version.nil? && track == Supply::Tracks::DEFAULT
         UI.user_error!(%(Unable to find latest version information from "#{Supply::Tracks::DEFAULT}" track. Please specify track information by using the '--track' option.))
       else
-        latest_version = tracks.select { |t| t.track == track }.map(&:releases).flatten.max_by(&:name)
+        latest_version = tracks.select { |t| t.track == track }.map(&:releases).flatten.reject { |r| r.name.nil? }.max_by(&:name)
       end
 
       return latest_version
@@ -405,7 +405,7 @@ module Supply
         )
         return result.releases.flat_map(&:version_codes) || []
       rescue Google::Apis::ClientError => e
-        return [] if e.status_code == 404 && e.to_s.include?("trackEmpty")
+        return [] if e.status_code == 404 && (e.to_s.include?("trackEmpty") || e.to_s.include?("Track not found"))
         raise
       end
     end

data/supply/lib/supply/setup.rb

@@ -98,9 +98,11 @@ module Supply
         FileUtils.mkdir_p(containing)
       end
 
-      path = File.join(containing, "#{release_listing.version}.txt")
-      UI.message("Writing to #{path}...")
-      File.write(path, release_listing.release_notes)
+      release_listing.versioncodes.each do |versioncode|
+        path = File.join(containing, "#{versioncode}.txt")
+        UI.message("Writing to #{path}...")
+        File.write(path, release_listing.release_notes)
+      end
     end
 
     private

metadata

@@ -1,35 +1,35 @@
 --- !ruby/object:Gem::Specification
 name: fastlane
 version: !ruby/object:Gem::Version
-  version: 2.141.0
+  version: 2.146.0
 platform: ruby
 authors:
-- Jorge Revuelta H
-- Maksym Grebenets
-- Olivier Halligon
-- Daniel Jankowski
-- Fumiya Nakamura
-- Josh Holtz
-- Andrew McBurney
-- Iulian Onofrei
 - Kohki Miki
-- Joshua Liebowitz
-- Max Ott
-- Stefan Natchev
+- Jan Piotrowski
+- Fumiya Nakamura
 - Jérôme Lacoste
+- Manu Wallner
 - Aaron Brager
-- Jan Piotrowski
 - Danielle Tomlinson
-- Jimmy Dee
-- Manu Wallner
+- Joshua Liebowitz
 - Luka Mirosevic
+- Iulian Onofrei
 - Felix Krause
+- Daniel Jankowski
+- Maksym Grebenets
+- Max Ott
 - Matthew Ellis
+- Andrew McBurney
+- Stefan Natchev
+- Olivier Halligon
 - Helmut Januschka
+- Jorge Revuelta H
+- Josh Holtz
+- Jimmy Dee
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2020-01-29 00:00:00.000000000 Z
+date: 2020-04-22 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: slack-notifier
@@ -667,6 +667,20 @@ dependencies:
     - - "<"
       - !ruby/object:Gem::Version
         version: '2.0'
+- !ruby/object:Gem::Dependency
+  name: aws-sdk-s3
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '1.0'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '1.0'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
@@ -1002,6 +1016,7 @@ files:
 - fastlane/lib/fastlane.rb
 - fastlane/lib/fastlane/action.rb
 - fastlane/lib/fastlane/action_collector.rb
+- fastlane/lib/fastlane/actions/.update_code_signing_settings.rb.swp
 - fastlane/lib/fastlane/actions/README.md
 - fastlane/lib/fastlane/actions/actions_helper.rb
 - fastlane/lib/fastlane/actions/adb.rb
@@ -1140,6 +1155,7 @@ files:
 - fastlane/lib/fastlane/actions/min_fastlane_version.rb
 - fastlane/lib/fastlane/actions/modify_services.rb
 - fastlane/lib/fastlane/actions/nexus_upload.rb
+- fastlane/lib/fastlane/actions/notarize.rb
 - fastlane/lib/fastlane/actions/notification.rb
 - fastlane/lib/fastlane/actions/notify.rb
 - fastlane/lib/fastlane/actions/number_of_commits.rb
@@ -1209,6 +1225,7 @@ files:
 - fastlane/lib/fastlane/actions/unlock_keychain.rb
 - fastlane/lib/fastlane/actions/update_app_group_identifiers.rb
 - fastlane/lib/fastlane/actions/update_app_identifier.rb
+- fastlane/lib/fastlane/actions/update_code_signing_settings.rb
 - fastlane/lib/fastlane/actions/update_fastlane.rb
 - fastlane/lib/fastlane/actions/update_icloud_container_identifiers.rb
 - fastlane/lib/fastlane/actions/update_info_plist.rb
@@ -1262,6 +1279,7 @@ files:
 - fastlane/lib/fastlane/helper/git_helper.rb
 - fastlane/lib/fastlane/helper/gradle_helper.rb
 - fastlane/lib/fastlane/helper/podspec_helper.rb
+- fastlane/lib/fastlane/helper/s3_client_helper.rb
 - fastlane/lib/fastlane/helper/sh_helper.rb
 - fastlane/lib/fastlane/helper/xcodeproj_helper.rb
 - fastlane/lib/fastlane/helper/xcversion_helper.rb
@@ -1421,6 +1439,7 @@ files:
 - frameit/lib/frameit/commands_generator.rb
 - frameit/lib/frameit/config_parser.rb
 - frameit/lib/frameit/dependency_checker.rb
+- frameit/lib/frameit/device.rb
 - frameit/lib/frameit/device_types.rb
 - frameit/lib/frameit/editor.rb
 - frameit/lib/frameit/frame_downloader.rb
@@ -1476,6 +1495,7 @@ files:
 - match/lib/match/storage/git_storage.rb
 - match/lib/match/storage/google_cloud_storage.rb
 - match/lib/match/storage/interface.rb
+- match/lib/match/storage/s3_storage.rb
 - match/lib/match/table_printer.rb
 - match/lib/match/utils.rb
 - pem/README.md
@@ -1588,6 +1608,7 @@ files:
 - snapshot/lib/snapshot/error_handler.rb
 - snapshot/lib/snapshot/fixes/README.md
 - snapshot/lib/snapshot/fixes/hardware_keyboard_fix.rb
+- snapshot/lib/snapshot/fixes/simulator_shared_pasteboard.rb
 - snapshot/lib/snapshot/fixes/simulator_zoom_fix.rb
 - snapshot/lib/snapshot/latest_os_version.rb
 - snapshot/lib/snapshot/module.rb