fastlane 2.141.0 → 2.142.0

data/fastlane/swift/Gymfile.swift

@@ -18,4 +18,4 @@ class Gymfile: GymfileProtocol {
 
 
 
-// Generated with fastlane 2.141.0
+// Generated with fastlane 2.142.0

data/fastlane/swift/Matchfile.swift

@@ -18,4 +18,4 @@ class Matchfile: MatchfileProtocol {
 
 
 
-// Generated with fastlane 2.141.0
+// Generated with fastlane 2.142.0

data/fastlane/swift/Precheckfile.swift

@@ -18,4 +18,4 @@ class Precheckfile: PrecheckfileProtocol {
 
 
 
-// Generated with fastlane 2.141.0
+// Generated with fastlane 2.142.0

data/fastlane/swift/RubyCommand.swift

@@ -49,7 +49,7 @@ struct RubyCommand: RubyCommandable {
                     let typeJson: String
                     if let type = type {
                         typeJson = ", \"value_type\" : \"\(type.typeString)\""
-                    }else {
+                    } else {
                         typeJson = ""
                     }
 

data/fastlane/swift/Scanfile.swift

@@ -18,4 +18,4 @@ class Scanfile: ScanfileProtocol {
 
 
 
-// Generated with fastlane 2.141.0
+// Generated with fastlane 2.142.0

data/fastlane/swift/ScanfileProtocol.swift

@@ -102,6 +102,9 @@ protocol ScanfileProtocol: class {
   /// Generate the json compilation database with clang naming convention (compile_commands.json)
   var useClangReportName: Bool { get }
 
+  /// Specify the exact number of test runners that will be spawned during parallel testing. Equivalent to -parallel-testing-worker-count
+  var concurrentWorkers: Int? { get }
+
   /// Constrain the number of simulator devices on which to test concurrently. Equivalent to -maximum-concurrent-test-simulator-destinations
   var maxConcurrentSimulators: Int? { get }
 
@@ -210,6 +213,7 @@ extension ScanfileProtocol {
   var shouldZipBuildProducts: Bool { return false }
   var resultBundle: Bool { return false }
   var useClangReportName: Bool { return false }
+  var concurrentWorkers: Int? { return nil }
   var maxConcurrentSimulators: Int? { return nil }
   var disableConcurrentTesting: Bool { return false }
   var skipBuild: Bool { return false }
@@ -238,4 +242,4 @@ extension ScanfileProtocol {
 
 // Please don't remove the lines below
 // They are used to detect outdated files
-// FastlaneRunnerAPIVersion [0.9.25]
+// FastlaneRunnerAPIVersion [0.9.26]

data/fastlane/swift/Screengrabfile.swift

@@ -18,4 +18,4 @@ class Screengrabfile: ScreengrabfileProtocol {
 
 
 
-// Generated with fastlane 2.141.0
+// Generated with fastlane 2.142.0

data/fastlane/swift/Snapshotfile.swift

@@ -18,4 +18,4 @@ class Snapshotfile: SnapshotfileProtocol {
 
 
 
-// Generated with fastlane 2.141.0
+// Generated with fastlane 2.142.0

data/fastlane_core/lib/fastlane_core/keychain_importer.rb

@@ -10,6 +10,7 @@ module FastlaneCore
       command << " -P #{certificate_password.shellescape}"
       command << " -T /usr/bin/codesign" # to not be asked for permission when running a tool like `gym` (before Sierra)
       command << " -T /usr/bin/security"
+      command << " -T /usr/bin/productbuild" # to not be asked for permission when using an installer cert for macOS
       command << " 1> /dev/null" unless output
 
       UI.command(command) if output
@@ -37,6 +38,7 @@ module FastlaneCore
       if Helper.backticks('security -h | grep set-key-partition-list', print: false).length > 0
         command = "security set-key-partition-list"
         command << " -S apple-tool:,apple:"
+        command << " -s" # This is a needed in Catalina to prevent "security: SecKeychainItemCopyAccess: A missing value was detected."
         command << " -k #{keychain_password.to_s.shellescape}"
         command << " #{keychain_path.shellescape}"
         command << " 1> /dev/null" # always disable stdout. This can be very verbose, and leak potentially sensitive info

data/fastlane_core/lib/fastlane_core/project.rb

@@ -294,6 +294,10 @@ module FastlaneCore
       supported_platforms.include?(:iOS)
     end
 
+    def watchos?
+      supported_platforms.include?(:watchOS)
+    end
+
     def supported_platforms
       supported_platforms = build_settings(key: "SUPPORTED_PLATFORMS")
       if supported_platforms.nil?

data/gym/lib/gym/runner.rb

@@ -25,11 +25,11 @@ module Gym
 
       # Determine platform to archive
       is_mac = Gym.project.mac? || Gym.building_mac_catalyst_for_mac?
-      is_ios = !is_mac && (Gym.project.ios? || Gym.project.tvos?)
+      is_ios = !is_mac && (Gym.project.ios? || Gym.project.tvos? || Gym.project.watchos?)
 
       # Archive
       if is_ios
-        fix_generic_archive # See https://github.com/fastlane/fastlane/pull/4325
+        fix_generic_archive unless Gym.project.watchos? # See https://github.com/fastlane/fastlane/pull/4325
         return BuildCommandGenerator.archive_path if Gym.config[:skip_package_ipa]
 
         package_app

data/match/lib/match/storage/google_cloud_storage.rb

@@ -181,7 +181,7 @@ module Match
       end
 
       def generate_matchfile_content
-        return "bucket_name(\"#{self.bucket_name}\")"
+        return "google_cloud_bucket_name(\"#{self.bucket_name}\")"
       end
 
       private
@@ -349,7 +349,7 @@ module Match
           UI.message("\t\t 1. Click on your bucket to open it".cyan)
           UI.message("\t\t 2. Click 'Permissions'".cyan)
           UI.message("\t\t 3. Click 'Add members'".cyan)
-          UI.message("\t\t 4. Enter the email of your service account".cyan)
+          UI.message("\t\t 4. Enter the service account email address".cyan)
           UI.message("\t\t 5. Set the role to 'Storage Admin'".cyan)
           UI.message("\t\t 6. Click 'Save'".cyan)
           UI.message("")

data/pilot/lib/pilot/build_manager.rb

@@ -481,12 +481,18 @@ module Pilot
     end
 
     def update_build_beta_details(build, info)
-      build_beta_detail = build.build_beta_detail
-
       attributes = {}
       attributes[:autoNotifyEnabled] = info[:auto_notify_enabled] if info.key?(:auto_notify_enabled)
+      build_beta_detail = build.build_beta_detail
 
-      Spaceship::ConnectAPI.patch_build_beta_details(build_beta_details_id: build_beta_detail.id, attributes: attributes)
+      # https://github.com/fastlane/fastlane/pull/16006
+      if build_beta_detail
+        Spaceship::ConnectAPI.patch_build_beta_details(build_beta_details_id: build_beta_detail.id, attributes: attributes)
+      else
+        if attributes[:autoNotifyEnabled]
+          UI.important("Unable to auto notify testers as the build did not include beta detail information - this is likely a temporary issue on TestFlight.")
+        end
+      end
     end
   end
   # rubocop:enable Metrics/ClassLength

data/scan/lib/scan/options.rb

@@ -254,6 +254,11 @@ module Scan
                                      default_value: false),
 
         # concurrency
+        FastlaneCore::ConfigItem.new(key: :concurrent_workers,
+                                     type: Integer,
+                                     env_name: "SCAN_CONCURRENT_WORKERS",
+                                     description: "Specify the exact number of test runners that will be spawned during parallel testing. Equivalent to -parallel-testing-worker-count",
+                                     optional: true),
         FastlaneCore::ConfigItem.new(key: :max_concurrent_simulators,
                                      type: Integer,
                                      env_name: "SCAN_MAX_CONCURRENT_SIMULATORS",

data/scan/lib/scan/runner.rb

@@ -25,15 +25,17 @@ module Scan
     def test_app
       force_quit_simulator_processes if Scan.config[:force_quit_simulator]
 
-      if Scan.config[:reset_simulator]
-        Scan.devices.each do |device|
-          FastlaneCore::Simulator.reset(udid: device.udid)
+      if Scan.devices
+        if Scan.config[:reset_simulator]
+          Scan.devices.each do |device|
+            FastlaneCore::Simulator.reset(udid: device.udid)
+          end
         end
-      end
 
-      if Scan.config[:disable_slide_to_type]
-        Scan.devices.each do |device|
-          FastlaneCore::Simulator.disable_slide_to_type(udid: device.udid)
+        if Scan.config[:disable_slide_to_type]
+          Scan.devices.each do |device|
+            FastlaneCore::Simulator.disable_slide_to_type(udid: device.udid)
+          end
         end
       end
 

data/scan/lib/scan/test_command_generator.rb

@@ -27,7 +27,7 @@ module Scan
       UI.user_error!("No project/workspace found")
     end
 
-    def options
+    def options # rubocop:disable Metrics/PerceivedComplexity
       config = Scan.config
 
       options = []
@@ -37,8 +37,11 @@ module Scan
       options << "-toolchain '#{config[:toolchain]}'" if config[:toolchain]
       options << "-derivedDataPath '#{config[:derived_data_path]}'" if config[:derived_data_path]
       options << "-resultBundlePath '#{result_bundle_path}'" if config[:result_bundle]
-      options << "-maximum-concurrent-test-simulator-destinations #{config[:max_concurrent_simulators]}" if config[:max_concurrent_simulators]
-      options << "-disable-concurrent-testing" if config[:disable_concurrent_testing]
+      options << "-parallel-testing-worker-count #{config[:concurrent_workers]}" if config[:concurrent_workers]
+      if FastlaneCore::Helper.xcode_at_least?(10)
+        options << "-maximum-concurrent-test-simulator-destinations #{config[:max_concurrent_simulators]}" if config[:max_concurrent_simulators]
+        options << "-disable-concurrent-testing" if config[:disable_concurrent_testing]
+      end
       options << "-enableCodeCoverage #{config[:code_coverage] ? 'YES' : 'NO'}" unless config[:code_coverage].nil?
       options << "-enableAddressSanitizer #{config[:address_sanitizer] ? 'YES' : 'NO'}" unless config[:address_sanitizer].nil?
       options << "-enableThreadSanitizer #{config[:thread_sanitizer] ? 'YES' : 'NO'}" unless config[:thread_sanitizer].nil?

data/screengrab/lib/screengrab/runner.rb

@@ -73,15 +73,11 @@ module Screengrab
 
       validate_apk(app_apk_path)
 
-      enable_clean_status_bar(device_serial, app_apk_path)
-
-      run_tests(device_serial, app_apk_path, tests_apk_path, test_classes_to_use, test_packages_to_use, @config[:launch_arguments])
-
-      number_of_screenshots = pull_screenshots_from_device(device_serial, device_screenshots_paths, device_type_dir_name)
+      number_of_screenshots = run_tests(device_type_dir_name, device_screenshots_paths, device_serial, app_apk_path, tests_apk_path, test_classes_to_use, test_packages_to_use, @config[:launch_arguments])
 
       ReportsGenerator.new.generate
 
-      UI.success("Captured #{number_of_screenshots} screenshots! 📷✨")
+      UI.success("Captured #{number_of_screenshots} new screenshots! 📷✨")
     end
 
     def select_device
@@ -232,23 +228,29 @@ module Screengrab
       end
     end
 
-    def run_tests(device_serial, app_apk_path, tests_apk_path, test_classes_to_use, test_packages_to_use, launch_arguments)
+    def run_tests(device_type_dir_name, device_screenshots_paths, device_serial, app_apk_path, tests_apk_path, test_classes_to_use, test_packages_to_use, launch_arguments)
       unless @config[:reinstall_app]
         install_apks(device_serial, app_apk_path, tests_apk_path)
         grant_permissions(device_serial)
+        enable_clean_status_bar(device_serial, app_apk_path)
       end
 
+      number_of_screenshots = 0
+
       @config[:locales].each do |locale|
         if @config[:reinstall_app]
           uninstall_apks(device_serial, @config[:app_package_name], @config[:tests_package_name])
           install_apks(device_serial, app_apk_path, tests_apk_path)
           grant_permissions(device_serial)
+          enable_clean_status_bar(device_serial, app_apk_path)
         end
-        run_tests_for_locale(locale, device_serial, test_classes_to_use, test_packages_to_use, launch_arguments)
+        number_of_screenshots += run_tests_for_locale(device_type_dir_name, device_screenshots_paths, locale, device_serial, test_classes_to_use, test_packages_to_use, launch_arguments)
       end
+
+      number_of_screenshots
     end
 
-    def run_tests_for_locale(locale, device_serial, test_classes_to_use, test_packages_to_use, launch_arguments)
+    def run_tests_for_locale(device_type_dir_name, device_screenshots_paths, locale, device_serial, test_classes_to_use, test_packages_to_use, launch_arguments)
       UI.message("Running tests for locale: #{locale}")
 
       instrument_command = ["-s #{device_serial} shell am instrument --no-window-animation -w",
@@ -271,10 +273,12 @@ module Screengrab
           UI.error("Tests failed")
         end
       end
+
+      pull_screenshots_from_device(locale, device_serial, device_screenshots_paths, device_type_dir_name)
     end
 
-    def pull_screenshots_from_device(device_serial, device_screenshots_paths, device_type_dir_name)
-      UI.message("Pulling captured screenshots from the device")
+    def pull_screenshots_from_device(locale, device_serial, device_screenshots_paths, device_type_dir_name)
+      UI.message("Pulling captured screenshots for locale #{locale} from the device")
       starting_screenshot_count = screenshot_file_names_in(@config[:output_directory], device_type_dir_name).length
 
       UI.verbose("Starting screenshot count is: #{starting_screenshot_count}")
@@ -296,7 +300,7 @@ module Screengrab
         #
         # Therefore, we'll move the pulled screenshots from their genericly named folder to one named by the
         # user provided device_type option value to match the directory structure that supply expects
-        move_pulled_screenshots(tempdir, device_type_dir_name)
+        move_pulled_screenshots(locale, tempdir, device_type_dir_name)
       end
 
       ending_screenshot_count = screenshot_file_names_in(@config[:output_directory], device_type_dir_name).length
@@ -305,7 +309,8 @@ module Screengrab
 
       # Because we can't guarantee the screenshot output directory will be empty when we pull, we determine
       # success based on whether there are more screenshots there than when we started.
-      if starting_screenshot_count == ending_screenshot_count
+      # This is only applicable though when `clear_previous_screenshots` is set to `true`.
+      if starting_screenshot_count == ending_screenshot_count && @config[:clear_previous_screenshots]
         UI.error("Make sure you've used Screengrab.screenshot() in your tests and that your expected tests are being run.")
         UI.abort_with_message!("No screenshots were detected 📷❌")
       end
@@ -313,7 +318,7 @@ module Screengrab
       ending_screenshot_count - starting_screenshot_count
     end
 
-    def move_pulled_screenshots(pull_dir, device_type_dir_name)
+    def move_pulled_screenshots(locale, pull_dir, device_type_dir_name)
       # Glob pattern that finds the pulled screenshots directory for each locale
       # Possible matches:
       #   [pull_dir]/en-US/images/screenshots
@@ -337,7 +342,7 @@ module Screengrab
         # specific name, as expected by supply
         #
         # (Moved to: fastlane/metadata/android/en-US/images/phoneScreenshots)
-        dest_dir = File.join(File.dirname(dest_dir), device_type_dir_name)
+        dest_dir = File.join(File.dirname(dest_dir), locale, 'images', device_type_dir_name)
 
         FileUtils.mkdir_p(dest_dir)
         FileUtils.cp_r(src_screenshots, dest_dir)

data/snapshot/lib/snapshot/fixes/simulator_shared_pasteboard.rb

@@ -0,0 +1,16 @@
+require_relative '../module'
+
+module Snapshot
+  module Fixes
+    # Becoming first responder can trigger Pasteboard sync, which can stall and crash the simulator
+    # See https://twitter.com/steipete/status/1227551552317140992
+
+    class SharedPasteboardFix
+      def self.patch
+        UI.verbose("Patching simulator to disable Pasteboard automatic sync")
+
+        Helper.backticks("defaults write com.apple.iphonesimulator PasteboardAutomaticSync -bool false", print: FastlaneCore::Globals.verbose?)
+      end
+    end
+  end
+end

data/snapshot/lib/snapshot/simulator_launchers/simulator_launcher_base.rb

@@ -5,6 +5,7 @@ require_relative '../test_command_generator'
 require_relative '../collector'
 require_relative '../fixes/hardware_keyboard_fix'
 require_relative '../fixes/simulator_zoom_fix'
+require_relative '../fixes/simulator_shared_pasteboard'
 
 module Snapshot
   class SimulatorLauncherBase
@@ -53,6 +54,7 @@ module Snapshot
 
       Fixes::SimulatorZoomFix.patch
       Fixes::HardwareKeyboardFix.patch
+      Fixes::SharedPasteboardFix.patch
 
       device_types.each do |type|
         if launcher_config.erase_simulator || launcher_config.localize_simulator || !launcher_config.dark_mode.nil?

metadata

@@ -1,35 +1,35 @@
 --- !ruby/object:Gem::Specification
 name: fastlane
 version: !ruby/object:Gem::Version
-  version: 2.141.0
+  version: 2.142.0
 platform: ruby
 authors:
-- Jorge Revuelta H
-- Maksym Grebenets
-- Olivier Halligon
-- Daniel Jankowski
-- Fumiya Nakamura
+- Manu Wallner
 - Josh Holtz
-- Andrew McBurney
 - Iulian Onofrei
-- Kohki Miki
+- Luka Mirosevic
+- Danielle Tomlinson
 - Joshua Liebowitz
-- Max Ott
-- Stefan Natchev
 - Jérôme Lacoste
+- Fumiya Nakamura
 - Aaron Brager
-- Jan Piotrowski
-- Danielle Tomlinson
-- Jimmy Dee
-- Manu Wallner
-- Luka Mirosevic
 - Felix Krause
+- Olivier Halligon
 - Matthew Ellis
+- Daniel Jankowski
+- Maksym Grebenets
+- Max Ott
+- Kohki Miki
+- Jimmy Dee
+- Stefan Natchev
 - Helmut Januschka
+- Andrew McBurney
+- Jan Piotrowski
+- Jorge Revuelta H
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2020-01-29 00:00:00.000000000 Z
+date: 2020-02-18 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: slack-notifier
@@ -1140,6 +1140,7 @@ files:
 - fastlane/lib/fastlane/actions/min_fastlane_version.rb
 - fastlane/lib/fastlane/actions/modify_services.rb
 - fastlane/lib/fastlane/actions/nexus_upload.rb
+- fastlane/lib/fastlane/actions/notarize.rb
 - fastlane/lib/fastlane/actions/notification.rb
 - fastlane/lib/fastlane/actions/notify.rb
 - fastlane/lib/fastlane/actions/number_of_commits.rb
@@ -1438,6 +1439,7 @@ files:
 - gym/lib/assets/GymfileTemplate.swift
 - gym/lib/assets/wrap_xcodebuild/xcbuild-safe.sh
 - gym/lib/gym.rb
+- gym/lib/gym/.code_signing_mapping.rb.swp
 - gym/lib/gym/code_signing_mapping.rb
 - gym/lib/gym/commands_generator.rb
 - gym/lib/gym/detect_values.rb
@@ -1588,6 +1590,7 @@ files:
 - snapshot/lib/snapshot/error_handler.rb
 - snapshot/lib/snapshot/fixes/README.md
 - snapshot/lib/snapshot/fixes/hardware_keyboard_fix.rb
+- snapshot/lib/snapshot/fixes/simulator_shared_pasteboard.rb
 - snapshot/lib/snapshot/fixes/simulator_zoom_fix.rb
 - snapshot/lib/snapshot/latest_os_version.rb
 - snapshot/lib/snapshot/module.rb