fastlane 2.139.0 → 2.144.0

data/fastlane/lib/fastlane/actions/build_mac_app.rb

@@ -0,0 +1,46 @@
+module Fastlane
+  module Actions
+    require 'fastlane/actions/build_app'
+    class BuildMacAppAction < BuildAppAction
+      # Gym::Options.available_options keys that don't apply to mac apps.
+      REJECT_OPTIONS = [
+        :ipa,
+        :skip_package_ipa,
+        :catalyst_platform
+      ]
+
+      def self.run(params)
+        # Adding reject options back in  so gym has everything it needs
+        params.available_options += Gym::Options.available_options.select do |option|
+          REJECT_OPTIONS.include?(option.key)
+        end
+
+        # Defaulting to mac specific values
+        params[:catalyst_platform] = "macos"
+
+        super(params)
+      end
+
+      #####################################################
+      # @!group Documentation
+      #####################################################
+
+      def self.available_options
+        require 'gym'
+        require 'gym/options'
+
+        Gym::Options.available_options.reject do |option|
+          REJECT_OPTIONS.include?(option.key)
+        end
+      end
+
+      def self.is_supported?(platform)
+        [:mac].include?(platform)
+      end
+
+      def self.description
+        "Alias for the `build_app` action but only for macOS"
+      end
+    end
+  end
+end

data/fastlane/lib/fastlane/actions/clean_build_artifacts.rb

@@ -21,6 +21,9 @@ module Fastlane
           File.delete(file)
         end
 
+        Actions.lane_context[Actions::SharedValues::SIGH_PROFILE_PATHS] = nil
+        Actions.lane_context[Actions::SharedValues::DSYM_PATHS] = nil
+
         UI.success('Cleaned up build artifacts 🐙')
       end
 

data/fastlane/lib/fastlane/actions/cocoapods.rb

@@ -19,7 +19,7 @@ module Fastlane
 
         cmd << '--no-clean' unless params[:clean]
         cmd << '--no-integrate' unless params[:integrate]
-        cmd << '--clean-install' if params[:clean_install] && pod_version.to_f >= 1.7
+        cmd << '--clean-install' if params[:clean_install] && pod_version(params).to_f >= 1.7
         cmd << '--repo-update' if params[:repo_update]
         cmd << '--silent' if params[:silent]
         cmd << '--verbose' if params[:verbose]
@@ -42,7 +42,7 @@ module Fastlane
         params[:use_bundle_exec] && shell_out_should_use_bundle_exec?
       end
 
-      def self.pod_version
+      def self.pod_version(params)
         use_bundle_exec?(params) ? `bundle exec pod --version` : `pod --version`
       end
 

data/fastlane/lib/fastlane/actions/crashlytics.rb

@@ -66,7 +66,7 @@ module Fastlane
       end
 
       def self.description
-        "Upload a new build to [Crashlytics Beta](http://try.crashlytics.com/beta/)"
+        "Refer to [Firebase App Distribution](https://appdistro.page.link/fastlane-repo)"
       end
 
       def self.available_options
@@ -169,6 +169,10 @@ module Fastlane
 
       def self.details
         [
+          "Crashlytics Beta has been deprecated and replaced with Firebase App Distribution.",
+          "Beta will continue working until May 4, 2020.",
+          "Check out the [Firebase App Distribution docs](https://github.com/fastlane/fastlane-plugin-firebase_app_distribution) to get started.",
+          "",
           "Additionally, you can specify `notes`, `emails`, `groups` and `notifications`.",
           "Distributing to Groups: When using the `groups` parameter, it's important to use the group **alias** names for each group you'd like to distribute to. A group's alias can be found in the web UI. If you're viewing the Beta page, you can open the groups dialog by clicking the 'Manage Groups' button.",
           "This action uses the `submit` binary provided by the Crashlytics framework. If the binary is not found in its usual path, you'll need to specify the path manually by using the `crashlytics_path` option."
@@ -196,7 +200,15 @@ module Fastlane
       end
 
       def self.category
-        :beta
+        :deprecated
+      end
+
+      def self.deprecated_notes
+        [
+          "Crashlytics Beta has been deprecated and replaced with Firebase App Distribution.",
+          "Beta will continue working until May 4, 2020.",
+          "Check out the [Firebase App Distribution docs](https://github.com/fastlane/fastlane-plugin-firebase_app_distribution) to get started."
+        ].join("\n")
       end
     end
   end

data/fastlane/lib/fastlane/actions/create_pull_request.rb

@@ -43,6 +43,9 @@ module Fastlane
           # Add reviewers to pull request
           add_reviewers(params, number) if params[:reviewers] || params[:team_reviewers]
 
+          # Add a milestone to pull request
+          add_milestone(params, number) if params[:milestone]
+
           Actions.lane_context[SharedValues::CREATE_PULL_REQUEST_HTML_URL] = html_url
           Actions.lane_context[SharedValues::CREATE_PULL_REQUEST_NUMBER] = number
           return html_url
@@ -111,6 +114,27 @@ module Fastlane
         )
       end
 
+      def self.add_milestone(params, number)
+        payload = {}
+        if params[:milestone]
+          payload["milestone"] = params[:milestone]
+        end
+
+        GithubApiAction.run(
+          server_url: params[:api_url],
+          api_token: params[:api_token],
+          http_method: 'PATCH',
+          path: "repos/#{params[:repo]}/issues/#{number}",
+          body: payload,
+          error_handlers: {
+              '*' => proc do |result|
+                UI.error("GitHub responded with #{result[:status]}: #{result[:body]}")
+                return nil
+              end
+          }
+        )
+      end
+
       #####################################################
       # @!group Documentation
       #####################################################
@@ -157,6 +181,11 @@ module Fastlane
                                        description: "The labels for the pull request",
                                        type: Array,
                                        optional: true),
+          FastlaneCore::ConfigItem.new(key: :milestone,
+                                       env_name: "GITHUB_PULL_REQUEST_MILESTONE",
+                                       description: "The milestone ID (Integer) for the pull request",
+                                       type: Numeric,
+                                       optional: true),
           FastlaneCore::ConfigItem.new(key: :head,
                                        env_name: "GITHUB_PULL_REQUEST_HEAD",
                                        description: "The name of the branch where your changes are implemented (defaults to the current branch name)",

data/fastlane/lib/fastlane/actions/docs/{build_ios_app.md → build_app.md}

@@ -146,7 +146,7 @@ export_options({
 Optional: If _gym_ can't automatically detect the provisioning profiles to use, you can pass a mapping of bundle identifiers to provisioning profiles:
 
 ```ruby
-build_ios_app(
+build_app(
   scheme: "Release",
   export_options: {
     method: "app-store",

data/fastlane/lib/fastlane/actions/docs/frame_screenshots.md

@@ -4,7 +4,7 @@
 
 ###### Easily put your screenshots into the right device frames
 
-_frameit_ allows you to put a gorgeous device frame around your iOS and macOS screenshots just by running one simple command. Use _frameit_ to prepare perfect screenshots for the App Store, your website, QA or emails.
+_frameit_ allows you to put a gorgeous device frame around your iOS, macOS and Android screenshots just by running one simple command. Use _frameit_ to prepare perfect screenshots for the App Store, your website, QA or emails.
 
 -------
 
@@ -23,9 +23,10 @@ _frameit_ allows you to put a gorgeous device frame around your iOS and macOS sc
 
 ## Frame screenshot
 
-Put a gorgeous device frame around your iOS and macOS screenshots just by running one simple command. Support for:
+Put a gorgeous device frame around your iOS, macOS and Android screenshots just by running one simple command. Support for:
 
 - iPhone, iPad and Mac
+- Set of Android devices
 - Portrait and Landscape modes
 - Several device frame colors
 
@@ -69,12 +70,18 @@ More information about this process and how to update the frames can be found [h
 
 Why should you have to use Photoshop, just to add a frame around your screenshots?
 
-Just navigate to your folder of screenshots and use the following command:
+Just navigate to your folder of screenshots and use the following command (iOS and Mac OS are default platforms for backward compatibility):
 
 ```no-highlight
 fastlane frameit
 ```
 
+To frame Android screenshots:
+
+```no-highlight
+fastlane frameit android
+```
+
 To use the silver version of the frames:
 
 ```no-highlight
@@ -129,8 +136,10 @@ The general parameters are defined in the `default` key and can be:
 | `padding` | The content of the framed screenshot will be resized to match the specified `padding` around all edges. The vertical padding is also applied between the text and the top or bottom (depending on `title_below_image`) of the device frame. <p> There are 3 different options of specyfying the padding: <p> 1. Default: An integer value that defines both horizontal and vertical padding in pixels. <br> 2. A string that defines (different) padding values in pixels for horizontal and vertical padding. The syntax is `"<horizontal>x<vertical>"`, e.g. `"30x60"`. <br> 3. A string that defines (different) padding values in percentage for horizontal and vertical padding. The syntax is `"<horizontal>%x<vertical>%"`, e.g. `"5%x10%"`. <br> **Note:** The percentage is calculated from the smallest image dimension (height or width). <p> A combination of option 2 and 3 is possible, e.g. `"5%x40"`. | `50` |
 | `interline_spacing` | Specifies whether _frameit_ should add or subtract this many pixels between the individual lines of text. This only applies to a multi-line `title` and/or `keyword` to expand or squash together the individual lines of text. | `0` |
 | `font_scale_factor` | Specifies whether _frameit_ should increase or decrease the font size of the text. | `0.1` |
-| `frame` | Overrides the color of the frame to be used. (Valid values are `BLACK, `WHITE`, `GOLD` and `ROSE_GOLD`) | NA |
+| `frame` | Overrides the color of the frame to be used. (Valid values are `BLACK`, `WHITE`, `GOLD` and `ROSE_GOLD`) | NA |
 | `title_min_height` | Specifies a height always reserved for the title. Value can be a percentage of the height or an absolute value. The device will be placed below (or above) this area. Convenient to ensure the device top (or bottom) will be consistently placed at the same height on the different screenshots. | NA |
+| `use_platform` | Overrides the platform used for the screenshot. Valid values are `IOS`, `ANDROID` and `ANY`. | `IOS` |
+| `force_device_type` | Forces a specific device. Valid values are: Huawei P8, Motorola Moto E, Motorola Moto G, Nexus 4, Nexus 5X, Nexus 6P, Nexus 9, Samsung Galaxy Grand Prime, Samsung Galaxy Note 5, Samsung Galaxy S Duos, Samsung Galaxy S3, Samsung Galaxy S5, Samsung Galaxy S7, Samsung Galaxy S8, Samsung Galaxy S9, iPhone 5s, iPhone 5c, iPhone SE, iPhone 6s, iPhone 6s Plus, iPhone 7, iPhone 7 Plus, iPhone 8, iPhone 8 Plus, iPhone X, iPhone XS, iPhone XR, iPhone XS Max, iPad Air 2, iPad Mini 4, iPad Pro, MacBook, Google Pixel 3, Google Pixel 3 XL, HTC One A9, HTC One M8 | NA |
 
 ### Specific parameters
 
@@ -142,7 +151,9 @@ These are defined in the `data` key. This is an array with the following keys fo
 | `filter` | This is mandatory to link the individual configuration to the screenshot, based on part of the file name. <p>Example:<br>If a screenshot is named `iPhone 8-Brainstorming.png` you can use value `Brainstorming` for `filter`.  If there are more than one `filter` matching an entry, they will all be applied in order (which means that the last one has the highest precedence). All other keys from that array element will only be applied on this specific screenshot. |
 | `keyword` | Similar use as in `default`, except that parameter `text` can be used here because it is screenshot specific. |
 | `title` | Similar use as in `default`, except that parameter `text` can be used here because it is screenshot specific. |
-| `frame` | Overrides the color of the frame to be used. (Valid values are `BLACK, `WHITE`, `GOLD` and `ROSE_GOLD`) | NA |
+| `frame` | Overrides the color of the frame to be used. (Valid values are `BLACK`, `WHITE`, `GOLD` and `ROSE_GOLD`) | NA |
+| `use_platform` | Overrides the platform used for the screenshot. Valid values are `IOS`, `ANDROID` and `ANY`. | `IOS` |
+| `force_device_type` | Forces a specific device. Valid values are the same as for the general parameter. | NA |
 
 ### <a name="keyword-and-title-parameters"></a>Framefile `keyword` and `title` parameters
 
@@ -172,7 +183,8 @@ The `keyword` and `title` parameters are both used in `default` and `data`. They
     "show_complete_frame": false,
     "stack_title" : false,
     "title_below_image": true,
-    "frame": "WHITE"
+    "frame": "WHITE",
+    "use_platform": "IOS"
   },
 
   "data": [
@@ -200,6 +212,10 @@ The `keyword` and `title` parameters are both used in `default` and `data`. They
       "keyword": {
         "color": "#31bb48"
       }
+    },
+    {
+      "filter": "Android",
+      "use_platform": "ANDROID"
     }
   ]
 }

data/fastlane/lib/fastlane/actions/docs/sync_code_signing.md

@@ -73,7 +73,7 @@ fastlane match init
 
 <img src="/img/actions/match_init.gif" width="550" />
 
-You'll be asked if you want to store your code signing identities inside a **Git repo**, or on **Google Cloud**.
+You'll be asked if you want to store your code signing identities inside a **Git repo**, **Google Cloud** or **Amazon S3**.
 
 #### Git Storage
 
@@ -142,6 +142,18 @@ Example content (for more advanced setups check out the [fastlane section](#fast
 google_cloud_bucket_name("major-key-certificates")
 ```
 
+#### Amazon S3
+
+Use [Amazon S3](https://aws.amazon.com/s3/) for a fully hosted solution for your code signing identities. Certificates are stored on S3, inside a storage bucket you provide. You can also directly access the files using the web console.
+
+This will create a `Matchfile` in your current directory (or in your `./fastlane/` folder).
+
+Example content (for more advanced setups check out the [fastlane section](#fastlane)):
+
+```ruby-skip-tests
+s3_bucket("ios-certificates")
+```
+
 ### Multiple teams
 
 _match_ can store the codesigning files for multiple development teams:
@@ -155,9 +167,9 @@ match(git_branch: "team1", username: "user@team1.com")
 match(git_branch: "team2", username: "user@team2.com")
 ```
 
-#### Google Cloud Storage
+#### Google Cloud or Amazon S3 Storage
 
-If you use Google Cloud Storage, you don't need to do anything manually for multiple teams. Just use Google Cloud Storage, and the top level folder will be the team ID.
+If you use Google Cloud or Amazon S3 Storage, you don't need to do anything manually. Just use Google Cloud or Amazon S3 Storage, and the top level folder will be the team ID.
 
 ### Run
 
@@ -194,7 +206,7 @@ fastlane action match
 
 #### Handle multiple targets
 
-_match_ can use the same one Git repository or Google Cloud Storage for all bundle identifiers.
+_match_ can use the same one Git repository, Google Cloud, or Amazon S3 Storage for all bundle identifiers.
 
 If you have several targets with different bundle identifiers, supply them as a comma-separated list:
 
@@ -419,6 +431,10 @@ Once you've decided which approach to take, all that's left to do is to set your
 
 Accessing Google Cloud Storage from your CI system requires you to provide the `gc_keys.json` file as part of your build. How you implement this is your decision. You can inject that file during build time.
 
+#### Amazon S3 Storage access
+
+Accessing Amazon S3 Storage from your CI system requires you to provide the `s3_region`, `s3_access_key`, `s3_secret_access_key` and `s3_bucket` options (or environment variables), with keys that has read access to the bucket.
+
 ### Nuke
 
 If you never really cared about code signing and have a messy Apple Developer account with a lot of invalid, expired or Xcode managed profiles/certificates, you can use the `match nuke` command to revoke your certificates and provisioning profiles. Don't worry, apps that are already available in the App Store / TestFlight will still work. Builds distributed via Ad Hoc or Enterprise will be disabled after nuking your account, so you'll have to re-upload a new build. After clearing your account you'll start from a clean state, and you can run _match_ to generate your certificates and profiles again.
@@ -449,13 +465,13 @@ You'll be asked for the new password on all your machines on the next run.
 
 ### Import
 
-To import and encrypt a certificate (`.cer`) and the private key (`.p12`) into the _match_ repo run:
+To import and encrypt a certificate (`.cer`), the private key (`.p12`) and the provisioning profiles (`.mobileprovision` or `.provisionprofile`) into the _match_ repo run:
 
 ```no-highlight
 fastlane match import
 ```
 
-You'll be prompted for the certificate (`.cer`) and the private key (`.p12`) paths. _match_ will first validate the certificate (`.cer`) against the Developer Portal before importing the certificate (`.cer`) and the private key (`.p12`).
+You'll be prompted for the certificate (`.cer`), the private key (`.p12`) and the provisioning profiles (`.mobileprovision` or `.provisionprofile`) paths. _match_ will first validate the certificate (`.cer`) against the Developer Portal before importing the certificate, the private key and the provisioning profiles into the specified _match_ repository.
 
 ### Manual Decrypt
 

data/fastlane/lib/fastlane/actions/ensure_git_branch.rb

@@ -34,7 +34,7 @@ module Fastlane
         [
           FastlaneCore::ConfigItem.new(key: :branch,
                                        env_name: "FL_ENSURE_GIT_BRANCH_NAME",
-                                       description: "The branch that should be checked for. String that can be either the full name of the branch or a regex to match",
+                                       description: "The branch that should be checked for. String that can be either the full name of the branch or a regex e.g. `^feature\/.*$` to match",
                                        is_string: true,
                                        default_value: 'master')
         ]

data/fastlane/lib/fastlane/actions/ensure_xcode_version.rb

@@ -4,6 +4,7 @@ module Fastlane
       def self.run(params)
         Actions.verify_gem!('xcode-install')
         required_version = params[:version]
+        strict = params[:strict]
 
         if required_version.to_s.length == 0
           # The user didn't provide an Xcode version, let's see
@@ -30,16 +31,38 @@ module Fastlane
           UI.user_error!("Invalid version number provided, make sure it's valid: #{ex}")
         end
 
-        if selected_version == required_version
-          UI.success("Selected Xcode version is correct: #{selected_version}")
+        if strict == true
+          if selected_version == required_version
+            success(selected_version)
+          else
+            error(selected_version, required_version)
+          end
         else
-          UI.message("Selected Xcode version is not correct: #{selected_version}. You expected #{required_version}.")
-          UI.message("To correct this, use: `xcode_select(version: #{required_version})`.")
+          required_version_numbers = required_version.to_s.split(".")
+          selected_version_numbers = selected_version.to_s.split(".")
+
+          required_version_numbers.each_with_index do |required_version_number, index|
+            selected_version_number = selected_version_numbers[index]
+            next unless required_version_number != selected_version_number
+            error(selected_version, required_version)
+            break
+          end
 
-          UI.user_error!("Selected Xcode version doesn't match your requirement.\nExpected: Xcode #{required_version}\nActual: Xcode #{selected_version}\n")
+          success(selected_version)
         end
       end
 
+      def self.success(selected_version)
+        UI.success("Selected Xcode version is correct: #{selected_version}")
+      end
+
+      def self.error(selected_version, required_version)
+        UI.message("Selected Xcode version is not correct: #{selected_version}. You expected #{required_version}.")
+        UI.message("To correct this, use: `xcode_select(version: #{required_version})`.")
+
+        UI.user_error!("Selected Xcode version doesn't match your requirement.\nExpected: Xcode #{required_version}\nActual: Xcode #{selected_version}\n")
+      end
+
       #####################################################
       # @!group Documentation
       #####################################################
@@ -52,7 +75,8 @@ module Fastlane
         [
           "If building your app requires a specific version of Xcode, you can invoke this command before using gym.",
           "For example, to ensure that a beta version of Xcode is not accidentally selected to build, which would make uploading to TestFlight fail.",
-          "You can either manually provide a specific version using `version: ` or you make use of the `.xcode-version` file."
+          "You can either manually provide a specific version using `version: ` or you make use of the `.xcode-version` file.",
+          "Using the `strict` parameter, you can either verify the full set of version numbers strictly (i.e. `11.3.1`) or only a subset of them (i.e. `11.3` or `11`)."
         ].join("\n")
       end
 
@@ -62,7 +86,11 @@ module Fastlane
                                        env_name: "FL_ENSURE_XCODE_VERSION",
                                        description: "Xcode version to verify that is selected",
                                        is_string: true,
-                                       optional: true)
+                                       optional: true),
+          FastlaneCore::ConfigItem.new(key: :strict,
+                                       description: "Should the version be verified strictly (all 3 version numbers), or matching only the given version numbers (i.e. `11.3` == `11.3.x`)",
+                                       type: Boolean,
+                                       default_value: true)
         ]
       end
 

data/fastlane/lib/fastlane/actions/frame_screenshots.rb

@@ -45,6 +45,7 @@ module Fastlane
         [
           'frame_screenshots',
           'frameit # alias for "frame_screenshots"',
+          'frame_screenshots(use_platform: "ANDROID")',
           'frame_screenshots(silver: true)',
           'frame_screenshots(path: "/screenshots")',
           'frame_screenshots(rose_gold: true)'
@@ -56,7 +57,7 @@ module Fastlane
       end
 
       def self.is_supported?(platform)
-        [:ios, :mac].include?(platform)
+        [:ios, :mac, :android].include?(platform)
       end
     end
   end

data/fastlane/lib/fastlane/actions/get_github_release.rb

@@ -129,6 +129,9 @@ module Fastlane
           FastlaneCore::ConfigItem.new(key: :api_token,
                                        env_name: "FL_GITHUB_RELEASE_API_TOKEN",
                                        sensitive: true,
+                                       code_gen_sensitive: true,
+                                       default_value: ENV["GITHUB_API_TOKEN"],
+                                       default_value_dynamic: true,
                                        description: "GitHub Personal Token (required for private repositories)",
                                        optional: true)
         ]

data/fastlane/lib/fastlane/actions/gradle.rb

@@ -17,12 +17,16 @@ module Fastlane
     end
 
     class GradleAction < Action
+      # rubocop:disable Metrics/PerceivedComplexity
       def self.run(params)
         task = params[:task]
         flavor = params[:flavor]
         build_type = params[:build_type]
+        tasks = params[:tasks]
 
-        gradle_task = [task, flavor, build_type].join
+        gradle_task = gradle_task(task, flavor, build_type, tasks)
+
+        UI.user_error!('Please pass a gradle task or tasks') if gradle_task.empty?
 
         project_dir = params[:project_dir]
 
@@ -101,6 +105,28 @@ module Fastlane
 
         return result
       end
+      # rubocop:enable Metrics/PerceivedComplexity
+
+      def self.gradle_task(task, flavor, build_type, tasks)
+        gradle_task = [task, flavor, build_type].join
+
+        if gradle_task.empty? && !tasks.nil?
+          gradle_task = tasks.join(' ')
+        end
+
+        gradle_task
+      end
+
+      def self.step_text(params)
+        task = params[:task]
+        flavor = params[:flavor]
+        build_type = params[:build_type]
+        tasks = params[:tasks]
+
+        gradle_task = gradle_task(task, flavor, build_type, tasks)
+
+        return gradle_task
+      end
 
       #####################################################
       # @!group Documentation
@@ -119,7 +145,8 @@ module Fastlane
           FastlaneCore::ConfigItem.new(key: :task,
                                        env_name: 'FL_GRADLE_TASK',
                                        description: 'The gradle task you want to execute, e.g. `assemble`, `bundle` or `test`. For tasks such as `assembleMyFlavorRelease` you should use gradle(task: \'assemble\', flavor: \'Myflavor\', build_type: \'Release\')',
-                                       optional: false,
+                                       conflicting_options: [:tasks],
+                                       optional: true,
                                        is_string: true),
           FastlaneCore::ConfigItem.new(key: :flavor,
                                        env_name: 'FL_GRADLE_FLAVOR',
@@ -131,6 +158,13 @@ module Fastlane
                                        description: 'The build type that you want the task for, e.g. `Release`. Useful for some tasks such as `assemble`',
                                        optional: true,
                                        is_string: true),
+          FastlaneCore::ConfigItem.new(key: :tasks,
+                                       type: Array,
+                                       env_name: 'FL_GRADLE_TASKS',
+                                       description: 'The multiple gradle tasks that you want to execute, e.g. `[assembleDebug, bundleDebug]`',
+                                       conflicting_options: [:task],
+                                       optional: true,
+                                       is_string: false),
           FastlaneCore::ConfigItem.new(key: :flags,
                                        env_name: 'FL_GRADLE_FLAGS',
                                        description: 'All parameter flags you want to pass to the gradle command, e.g. `--exitcode --xml file.xml`',
@@ -219,6 +253,13 @@ module Fastlane
           )
           ```
 
+          You can pass multiple gradle tasks:
+          ```ruby
+          gradle(
+            tasks: ["assembleDebug", "bundleDebug"]
+          )
+          ```
+
           You can pass properties to gradle:
           ```ruby
           gradle(