fastlane 2.138.0 → 2.143.0

data/fastlane/lib/fastlane/actions/swiftlint.rb

@@ -37,6 +37,7 @@ module Fastlane
           Actions.sh(command)
         rescue
           handle_swiftlint_error(params[:ignore_exit_status], $?.exitstatus)
+          raise if params[:raise_if_swiftlint_error]
         end
       end
 
@@ -106,10 +107,22 @@ module Fastlane
                                        is_string: false,
                                        type: Boolean,
                                        optional: true),
+          FastlaneCore::ConfigItem.new(key: :raise_if_swiftlint_error,
+                                       description: "Raises an error if swiftlint fails, so you can fail CI/CD jobs if necessary \
+                                                    (true/false)",
+                                       default_value: false,
+                                       is_string: false,
+                                       type: Boolean,
+                                       optional: true),
           FastlaneCore::ConfigItem.new(key: :reporter,
-                                       description: 'Choose output reporter',
+                                       description: "Choose output reporter. Available: xcode, json, csv, checkstyle, junit, html, \
+                                                     emoji, sonarqube, markdown, github-actions-logging",
                                        is_string: true,
-                                       optional: true),
+                                       optional: true,
+                                       verify_block: proc do |value|
+                                         available = ['xcode', 'json', 'csv', 'checkstyle', 'junit', 'html', 'emoji', 'sonarqube', 'markdown', 'github-actions-logging']
+                                         UI.user_error!("Available values are '#{available.join("', '")}'") unless available.include?(value)
+                                       end),
           FastlaneCore::ConfigItem.new(key: :quiet,
                                        description: "Don't print status logs like 'Linting <file>' & 'Done linting'",
                                        default_value: false,
@@ -161,7 +174,9 @@ module Fastlane
               "AppDelegate.swift",
               "path/to/project/Model.swift"
             ],
+            raise_if_swiftlint_error: true,      # Allow fastlane to raise an error if swiftlint fails
             ignore_exit_status: true              # Allow fastlane to continue even if SwiftLint returns a non-zero exit status
+
           )'
         ]
       end

data/fastlane/lib/fastlane/actions/update_plist.rb

@@ -39,7 +39,7 @@ module Fastlane
       end
 
       def self.details
-        "This action allows you to modify any `plist` file."
+        "This action allows you to modify any value inside any `plist` file."
       end
 
       def self.available_options
@@ -57,11 +57,46 @@ module Fastlane
       end
 
       def self.author
-        'rishabhtayal'
+        ["rishabhtayal", "matthiaszarzecki"]
       end
 
       def self.example_code
         [
+          'update_plist( # Updates the CLIENT_ID and GOOGLE_APP_ID string entries in the plist-file
+            plist_path: "path/to/your_plist_file.plist",
+            block: proc do |plist|
+              plist[:CLIENT_ID] = "new_client_id"
+              plist[:GOOGLE_APP_ID] = "new_google_app_id"
+            end
+          )',
+          'update_plist( # Sets a boolean entry
+            plist_path: "path/to/your_plist_file.plist",
+            block: proc do |plist|
+              plist[:boolean_entry] = true
+            end
+          )',
+          'update_plist( # Sets a number entry
+            plist_path: "path/to/your_plist_file.plist",
+            block: proc do |plist|
+              plist[:number_entry] = 13
+            end
+          )',
+          'update_plist( # Sets an array-entry with multiple sub-types
+            plist_path: "path/to/your_plist_file.plist",
+            block: proc do |plist|
+              plist[:array_entry] = ["entry_01", true, 1243]
+            end
+          )',
+          'update_plist( # The block can contain logic too
+            plist_path: "path/to/your_plist_file.plist",
+            block: proc do |plist|
+              if options[:environment] == "production"
+                plist[:CLIENT_ID] = "new_client_id_production"
+              else
+                plist[:CLIENT_ID] = "new_client_id_development"
+              end
+            end
+          )',
           'update_plist( # Advanced processing: find URL scheme for particular key and replace value
             plist_path: "path/to/Info.plist",
             block: proc do |plist|

data/fastlane/lib/fastlane/actions/upload_symbols_to_crashlytics.rb

@@ -10,8 +10,8 @@ module Fastlane
         find_gsp_path(params)
         find_api_token(params)
 
-        if !params[:api_token] && !params[:gsp_path]
-          UI.user_error!('Either Fabric API key or path to Firebase Crashlytics GoogleService-Info.plist must be given.')
+        if !params[:app_id] && !params[:gsp_path] && !params[:api_token]
+          UI.user_error!('Either Firebase Crashlytics App ID, path to GoogleService-Info.plist or legacy Fabric API key must be given.')
         end
 
         dsym_paths = []
@@ -87,7 +87,9 @@ module Fastlane
         UI.message("Uploading '#{path}'...")
         command = []
         command << File.expand_path(params[:binary_path]).shellescape
-        if params[:gsp_path]
+        if params[:app_id]
+          command << "-ai #{params[:app_id].shellescape}"
+        elsif params[:gsp_path]
           command << "-gsp #{params[:gsp_path].shellescape}"
         elsif params[:api_token]
           command << "-a #{params[:api_token]}"
@@ -186,6 +188,14 @@ module Fastlane
                                          UI.user_error!("Couldn't find file at path '#{File.expand_path(value)}'") unless File.exist?(value)
                                          UI.user_error!("No Path to GoogleService-Info.plist for Firebase Crashlytics given, pass using `gsp_path: 'path'`") if value.to_s.length == 0
                                        end),
+          FastlaneCore::ConfigItem.new(key: :app_id,
+                                       env_name: "CRASHLYTICS_APP_ID",
+                                       sensitive: true,
+                                       optional: true,
+                                       description: "Firebase Crashlytics APP ID",
+                                       verify_block: proc do |value|
+                                         UI.user_error!("No App ID for Firebase Crashlytics given, pass using `app_id: 'appId'`") if value.to_s.length == 0
+                                       end),
           FastlaneCore::ConfigItem.new(key: :binary_path,
                                        env_name: "FL_UPLOAD_SYMBOLS_TO_CRASHLYTICS_BINARY_PATH",
                                        description: "The path to the upload-symbols file of the Fabric app",

data/fastlane/lib/fastlane/actions/upload_to_app_store.rb

@@ -11,6 +11,7 @@ module Fastlane
           config.load_configuration_file("Deliverfile")
           config[:screenshots_path] = Actions.lane_context[SharedValues::SNAPSHOT_SCREENSHOTS_PATH] if Actions.lane_context[SharedValues::SNAPSHOT_SCREENSHOTS_PATH]
           config[:ipa] = Actions.lane_context[SharedValues::IPA_OUTPUT_PATH] if Actions.lane_context[SharedValues::IPA_OUTPUT_PATH]
+          config[:pkg] = Actions.lane_context[SharedValues::PKG_OUTPUT_PATH] if Actions.lane_context[SharedValues::PKG_OUTPUT_PATH]
 
           return config if Helper.test?
           Deliver::Runner.new(config).run

data/fastlane/lib/fastlane/actions/upload_to_play_store_internal_app_sharing.rb

@@ -0,0 +1,78 @@
+module Fastlane
+  module Actions
+    class UploadToPlayStoreInternalAppSharingAction < Action
+      def self.run(params)
+        require 'supply'
+
+        # If no APK params were provided, try to fill in the values from lane context, preferring
+        # the multiple APKs over the single APK if set.
+        if params[:apk_paths].nil? && params[:apk].nil?
+          all_apk_paths = Actions.lane_context[SharedValues::GRADLE_ALL_APK_OUTPUT_PATHS] || []
+          if all_apk_paths.size > 1
+            params[:apk_paths] = all_apk_paths
+          else
+            params[:apk] = Actions.lane_context[SharedValues::GRADLE_APK_OUTPUT_PATH]
+          end
+        end
+
+        # If no AAB param was provided, try to fill in the value from lane context.
+        # First GRADLE_ALL_AAB_OUTPUT_PATHS if only one
+        # Else from GRADLE_AAB_OUTPUT_PATH
+        if params[:aab].nil?
+          all_aab_paths = Actions.lane_context[SharedValues::GRADLE_ALL_AAB_OUTPUT_PATHS] || []
+          if all_aab_paths.count == 1
+            params[:aab] = all_aab_paths.first
+          else
+            params[:aab] = Actions.lane_context[SharedValues::GRADLE_AAB_OUTPUT_PATH]
+          end
+        end
+
+        Supply.config = params # we already have the finished config
+
+        Supply::Uploader.new.perform_upload_to_internal_app_sharing
+      end
+
+      #####################################################
+      # @!group Documentation
+      #####################################################
+
+      def self.description
+        "Upload binaries to Google Play Internal App Sharing (via _supply_)"
+      end
+
+      def self.details
+        "More information: https://docs.fastlane.tools/actions/upload_to_play_store_internal_app_sharing/"
+      end
+
+      def self.available_options
+        require 'supply'
+        require 'supply/options'
+        options = Supply::Options.available_options.clone
+
+        # remove all the unnecessary (for this action) options
+        options_to_keep = [:package_name, :apk, :apk_paths, :aab, :aab_paths, :json_key, :json_key_data, :root_url, :timeout]
+        options.delete_if { |option| options_to_keep.include?(option.key) == false }
+      end
+
+      def self.return_value
+        "Returns a string containing the download URL for the uploaded APK/AAB (or array of strings if multiple were uploaded)."
+      end
+
+      def self.authors
+        ["andrewhavens"]
+      end
+
+      def self.is_supported?(platform)
+        platform == :android
+      end
+
+      def self.example_code
+        ["upload_to_play_store_internal_app_sharing"]
+      end
+
+      def self.category
+        :production
+      end
+    end
+  end
+end

data/fastlane/lib/fastlane/fast_file.rb

@@ -263,7 +263,7 @@ module Fastlane
     # @param branch [String] The branch to checkout in the repository
     # @param path [String] The path to the Fastfile
     # @param version [String, Array] Version requirement for repo tags
-    def import_from_git(url: nil, branch: 'HEAD', path: 'fastlane/Fastfile', version: nil)
+    def import_from_git(url: nil, branch: 'HEAD', path: 'fastlane/Fastfile', version: nil, dependencies: [])
       UI.user_error!("Please pass a path to the `import_from_git` action") if url.to_s.length == 0
 
       Actions.execute_action('import_from_git') do
@@ -280,6 +280,10 @@ module Fastlane
 
           branch_option = "--branch #{branch}" if branch != 'HEAD'
 
+          checkout_dependencies = dependencies.map(&:shellescape).join(" ")
+
+          checkout_path = "#{path.shellescape} #{checkout_dependencies}"
+
           UI.message("Cloning remote git repo...")
           Helper.with_env_values('GIT_TERMINAL_PROMPT' => '0') do
             Actions.sh("git clone #{url.shellescape} #{clone_folder.shellescape} --depth 1 -n #{branch_option}")
@@ -292,7 +296,7 @@ module Fastlane
             UI.user_error!("No tag found matching #{version.inspect}") if checkout_param.nil?
           end
 
-          Actions.sh("cd #{clone_folder.shellescape} && git checkout #{checkout_param.shellescape} #{path.shellescape}")
+          Actions.sh("cd #{clone_folder.shellescape} && git checkout #{checkout_param.shellescape} #{checkout_path}")
 
           # We also want to check out all the local actions of this fastlane setup
           containing = path.split(File::SEPARATOR)[0..-2]
@@ -304,7 +308,13 @@ module Fastlane
             # We don't care about a failure here, as local actions are optional
           end
 
-          return_value = import(File.join(clone_folder, path))
+          return_value = nil
+          if dependencies.any?
+            return_value = [import(File.join(clone_folder, path))]
+            return_value += dependencies.map { |file_path| import(File.join(clone_folder, file_path)) }
+          else
+            return_value = import(File.join(clone_folder, path))
+          end
 
           action_completed('import_from_git', status: FastlaneCore::ActionCompletionStatus::SUCCESS)
 

data/fastlane/lib/fastlane/helper/adb_helper.rb

@@ -24,7 +24,7 @@ module Fastlane
           adb_path = File.join(android_home, "platform-tools", "adb")
         end
 
-        self.adb_path = adb_path
+        self.adb_path = File.expand_path(adb_path)
         self.adb_host = adb_host
       end
 

data/fastlane/lib/fastlane/helper/s3_client_helper.rb

@@ -0,0 +1,56 @@
+require 'aws-sdk'
+
+module Fastlane
+  module Helper
+    class S3ClientHelper
+      attr_reader :client
+
+      def initialize(access_key: nil, secret_access_key: nil, region: nil)
+        creds = Aws::Credentials.new(access_key, secret_access_key)
+        Aws.config.update({
+          region: region,
+          credentials: creds
+        })
+
+        @client = Aws::S3::Client.new
+      end
+
+      def list_buckets
+        return @client.list_buckets
+      end
+
+      def upload_file(bucket_name, file_name, file_data, acl)
+        bucket = find_bucket!(bucket_name)
+        details = {
+          acl: acl,
+          key: file_name,
+          body: file_data
+        }
+        obj = bucket.put_object(details)
+
+        # When you enable versioning on a S3 bucket,
+        # writing to an object will create an object version
+        # instead of replacing the existing object.
+        # http://docs.aws.amazon.com/AWSRubySDK/latest/AWS/S3/ObjectVersion.html
+        if obj.kind_of?(Aws::S3::ObjectVersion)
+          obj = obj.object
+        end
+
+        # Return public url
+        obj.public_url.to_s
+      end
+
+      def delete_file(bucket, file_name)
+        bucket = find_bucket!(bucket_name)
+        bucket.objects[file_name].delete
+      end
+
+      def find_bucket!(bucket_name)
+        bucket = Aws::S3::Bucket.new(bucket_name, client: @client)
+        raise "Bucket '#{bucket_name}' not found" unless bucket.exists?
+
+        return bucket
+      end
+    end
+  end
+end

data/fastlane/lib/fastlane/plugins/plugin_manager.rb

@@ -373,7 +373,7 @@ module Fastlane
       # (a plugin may contain any number of actions)
       version_number = Fastlane::ActionCollector.determine_version(gem_name)
       references = Fastlane.const_get(module_name).all_classes.collect do |path|
-        next unless File.dirname(path).end_with?("/actions") # we only want to match actions
+        next unless File.dirname(path).include?("/actions") # we only want to match actions
 
         File.basename(path).gsub("_action", "").gsub(".rb", "").to_sym # the _action is optional
       end

data/fastlane/lib/fastlane/plugins/template/.rubocop.yml

@@ -157,7 +157,9 @@ CrossPlatform/ForkUsage:
   - "**/plugins/template/**/*"
 Lint/IsStringUsage:
   Include:
+  - cert/**/*
   - gym/**/*
+  - match/**/*
   - screengrab/**/*
   - supply/**/*
 Style/MethodCallWithArgsParentheses:

data/fastlane/lib/fastlane/runner.rb

@@ -225,27 +225,32 @@ module Fastlane
 
       begin
         Dir.chdir(custom_dir) do # go up from the fastlane folder, to the project folder
-          # If another action is calling this action, we shouldn't show it in the summary
+          # Removing step_name before its parsed into configurations
+          args = arguments.kind_of?(Array) && arguments.first.kind_of?(Hash) ? arguments.first : {}
+          step_name = args.delete(:step_name)
+
+          # arguments is an array by default, containing an hash with the actual parameters
+          # Since we usually just need the passed hash, we'll just use the first object if there is only one
+          if arguments.count == 0
+            configurations = ConfigurationHelper.parse(class_ref, {}) # no parameters => empty hash
+          elsif arguments.count == 1 && arguments.first.kind_of?(Hash)
+            configurations = ConfigurationHelper.parse(class_ref, arguments.first) # Correct configuration passed
+          elsif !class_ref.available_options
+            # This action does not use the new action format
+            # Just passing the arguments to this method
+            configurations = arguments
+          else
+            UI.user_error!("You have to call the integration like `#{method_sym}(key: \"value\")`. Run `fastlane action #{method_sym}` for all available keys. Please check out the current documentation on GitHub.")
+          end
 
+          # If another action is calling this action, we shouldn't show it in the summary
+          # A nil value for action_name will hide it from the summary
           unless from_action
-            args = arguments.kind_of?(Array) && arguments.first.kind_of?(Hash) ? arguments.first : {}
-            action_name = args[:step_name] || class_ref.step_text
-            args.delete(:step_name)
+            action_name = step_name
+            action_name ||= class_ref.method(:step_text).arity == 1 ? class_ref.step_text(configurations) : class_ref.step_text
           end
-          Actions.execute_action(action_name) do
-            # arguments is an array by default, containing an hash with the actual parameters
-            # Since we usually just need the passed hash, we'll just use the first object if there is only one
-            if arguments.count == 0
-              arguments = ConfigurationHelper.parse(class_ref, {}) # no parameters => empty hash
-            elsif arguments.count == 1 && arguments.first.kind_of?(Hash)
-              arguments = ConfigurationHelper.parse(class_ref, arguments.first) # Correct configuration passed
-            elsif !class_ref.available_options
-              # This action does not use the new action format
-              # Just passing the arguments to this method
-            else
-              UI.user_error!("You have to call the integration like `#{method_sym}(key: \"value\")`. Run `fastlane action #{method_sym}` for all available keys. Please check out the current documentation on GitHub.")
-            end
 
+          Actions.execute_action(action_name) do
             if Fastlane::Actions.is_deprecated?(class_ref)
               puts("==========================================".deprecated)
               puts("This action (#{method_sym}) is deprecated".deprecated)
@@ -253,7 +258,7 @@ module Fastlane
               puts("==========================================\n".deprecated)
             end
             class_ref.runner = self # needed to call another action from an action
-            return class_ref.run(arguments)
+            return class_ref.run(configurations)
           end
         end
       rescue Interrupt => e

data/fastlane/lib/fastlane/server/socket_server_action_command_executor.rb

@@ -83,7 +83,7 @@ module Fastlane
 
       case command.method_name
       when "sh"
-        error_callback = proc { |string_value| closure_argument_value = string_value }
+        error_callback = proc { |string_value| closure_argument_value = string_value } if parameter_map[:error_callback]
         command_param = parameter_map[:command]
         log_param = parameter_map[:log]
         action_return = Fastlane::FastFile.sh(command_param, log: log_param, error_callback: error_callback)

data/fastlane/lib/fastlane/version.rb

@@ -1,5 +1,5 @@
 module Fastlane
-  VERSION = '2.138.0'.freeze
+  VERSION = '2.143.0'.freeze
   DESCRIPTION = "The easiest way to automate beta deployments and releases for your iOS and Android apps".freeze
   MINIMUM_XCODE_RELEASE = "7.0".freeze
   RUBOCOP_REQUIREMENT = '0.49.1'.freeze

data/fastlane/swift/Deliverfile.swift

@@ -18,4 +18,4 @@ class Deliverfile: DeliverfileProtocol {
 
 
 
-// Generated with fastlane 2.138.0
+// Generated with fastlane 2.143.0

data/fastlane/swift/DeliverfileProtocol.swift

@@ -57,10 +57,10 @@ protocol DeliverfileProtocol: class {
   /// Rejects the previously submitted build if it's in a state where it's possible
   var rejectIfPossible: Bool { get }
 
-  /// Should the app be automatically released once it's approved?
+  /// Should the app be automatically released once it's approved? (Can not be used together with `auto_release_date`)
   var automaticRelease: Bool { get }
 
-  /// Date in milliseconds for automatically releasing on pending approval
+  /// Date in milliseconds for automatically releasing on pending approval (Can not be used together with `automatic_release`)
   var autoReleaseDate: String? { get }
 
   /// Enable the phased release feature of iTC
@@ -246,4 +246,4 @@ extension DeliverfileProtocol {
 
 // Please don't remove the lines below
 // They are used to detect outdated files
-// FastlaneRunnerAPIVersion [0.9.18]
+// FastlaneRunnerAPIVersion [0.9.19]