fastlane 2.136.0 → 2.141.0

data/fastlane/lib/fastlane/actions/build_ios_app.rb

@@ -1,150 +1,46 @@
 module Fastlane
   module Actions
-    module SharedValues
-      IPA_OUTPUT_PATH ||= :IPA_OUTPUT_PATH
-      DSYM_OUTPUT_PATH ||= :DSYM_OUTPUT_PATH
-      XCODEBUILD_ARCHIVE ||= :XCODEBUILD_ARCHIVE # originally defined in XcodebuildAction
-    end
-
-    class BuildIosAppAction < Action
-      def self.run(values)
-        require 'gym'
-
-        unless Actions.lane_context[SharedValues::SIGH_PROFILE_TYPE].to_s == "development"
-          values[:export_method] ||= Actions.lane_context[SharedValues::SIGH_PROFILE_TYPE]
-        end
-
-        if Actions.lane_context[SharedValues::MATCH_PROVISIONING_PROFILE_MAPPING]
-          # Since Xcode 9 you need to explicitly provide the provisioning profile per app target
-          # If the user is smart and uses match and gym together with fastlane, we can do all
-          # the heavy lifting for them
-          values[:export_options] ||= {}
-          # It's not always a hash, because the user might have passed a string path to a ready plist file
-          # If that's the case, we won't set the provisioning profiles
-          # see https://github.com/fastlane/fastlane/issues/9490
-          if values[:export_options].kind_of?(Hash)
-            match_mapping = (Actions.lane_context[SharedValues::MATCH_PROVISIONING_PROFILE_MAPPING] || {}).dup
-            existing_mapping = (values[:export_options][:provisioningProfiles] || {}).dup
-
-            # Be smart about how we merge those mappings in case there are conflicts
-            mapping_object = Gym::CodeSigningMapping.new
-            hash_to_use = mapping_object.merge_profile_mapping(primary_mapping: existing_mapping,
-                                                             secondary_mapping: match_mapping,
-                                                                export_method: values[:export_method])
-
-            values[:export_options][:provisioningProfiles] = hash_to_use
-          else
-            self.show_xcode_9_warning
-          end
-        elsif Actions.lane_context[SharedValues::SIGH_PROFILE_PATHS]
-          # Since Xcode 9 you need to explicitly provide the provisioning profile per app target
-          # If the user used sigh we can match the profiles from sigh
-          values[:export_options] ||= {}
-          if values[:export_options].kind_of?(Hash)
-            # It's not always a hash, because the user might have passed a string path to a ready plist file
-            # If that's the case, we won't set the provisioning profiles
-            # see https://github.com/fastlane/fastlane/issues/9684
-            values[:export_options][:provisioningProfiles] ||= {}
-            Actions.lane_context[SharedValues::SIGH_PROFILE_PATHS].each do |profile_path|
-              begin
-                profile = FastlaneCore::ProvisioningProfile.parse(profile_path)
-                app_id_prefix = profile["ApplicationIdentifierPrefix"].first
-                bundle_id = profile["Entitlements"]["application-identifier"].gsub("#{app_id_prefix}.", "")
-                values[:export_options][:provisioningProfiles][bundle_id] = profile["Name"]
-              rescue => ex
-                UI.error("Couldn't load profile at path: #{profile_path}")
-                UI.error(ex)
-                UI.verbose(ex.backtrace.join("\n"))
-              end
-            end
-          else
-            self.show_xcode_9_warning
-          end
+    require 'fastlane/actions/build_app'
+    class BuildIosAppAction < BuildAppAction
+      # Gym::Options.available_options keys that don't apply to ios apps.
+      REJECT_OPTIONS = [
+        :pkg,
+        :skip_package_pkg,
+        :catalyst_platform,
+        :installer_cert_name
+      ]
+
+      def self.run(params)
+        # Adding reject options back in  so gym has everything it needs
+        params.available_options += Gym::Options.available_options.select do |option|
+          REJECT_OPTIONS.include?(option.key)
         end
 
-        gym_output_path = Gym::Manager.new.work(values)
-        if gym_output_path.nil?
-          UI.important("No output path received from gym")
-          return nil
-        end
-
-        absolute_ipa_path = File.expand_path(gym_output_path)
-        absolute_dsym_path = absolute_ipa_path.gsub(".ipa", ".app.dSYM.zip")
-
-        # This might be the mac app path, so we don't want to set it here
-        # https://github.com/fastlane/fastlane/issues/5757
-        if absolute_ipa_path.include?(".ipa")
-          Actions.lane_context[SharedValues::IPA_OUTPUT_PATH] = absolute_ipa_path
-          ENV[SharedValues::IPA_OUTPUT_PATH.to_s] = absolute_ipa_path # for deliver
-        end
-
-        Actions.lane_context[SharedValues::DSYM_OUTPUT_PATH] = absolute_dsym_path if File.exist?(absolute_dsym_path)
-        Actions.lane_context[SharedValues::XCODEBUILD_ARCHIVE] = Gym::BuildCommandGenerator.archive_path
-        ENV[SharedValues::DSYM_OUTPUT_PATH.to_s] = absolute_dsym_path if File.exist?(absolute_dsym_path)
-
-        return absolute_ipa_path
-      end
-
-      def self.description
-        "Easily build and sign your app (via _gym_)"
-      end
-
-      def self.details
-        "More information: https://fastlane.tools/gym"
-      end
-
-      def self.output
-        [
-          ['IPA_OUTPUT_PATH', 'The path to the newly generated ipa file'],
-          ['DSYM_OUTPUT_PATH', 'The path to the dSYM files'],
-          ['XCODEBUILD_ARCHIVE', 'The path to the xcodebuild archive']
-        ]
-      end
+        # Defaulting to ios specific values
+        params[:catalyst_platform] = "ios"
 
-      def self.return_value
-        "The absolute path to the generated ipa file"
+        super(params)
       end
 
-      def self.author
-        "KrauseFx"
-      end
+      #####################################################
+      # @!group Documentation
+      #####################################################
 
       def self.available_options
         require 'gym'
-        Gym::Options.available_options
-      end
-
-      def self.is_supported?(platform)
-        [:ios, :mac].include?(platform)
-      end
+        require 'gym/options'
 
-      def self.example_code
-        [
-          'build_ios_app(scheme: "MyApp", workspace: "MyApp.xcworkspace")',
-          'build_ios_app(
-            workspace: "MyApp.xcworkspace",
-            configuration: "Debug",
-            scheme: "MyApp",
-            silent: true,
-            clean: true,
-            output_directory: "path/to/dir", # Destination directory. Defaults to current directory.
-            output_name: "my-app.ipa",       # specify the name of the .ipa file to generate (including file extension)
-            sdk: "iOS 11.1"                  # use SDK as the name or path of the base SDK when building the project.
-          )',
-          'gym         # alias for "build_ios_app"',
-          'build_app   # alias for "build_ios_app"'
-        ]
+        Gym::Options.available_options.reject do |option|
+          REJECT_OPTIONS.include?(option.key)
+        end
       end
 
-      def self.category
-        :building
+      def self.is_supported?(platform)
+        [:ios].include?(platform)
       end
 
-      def self.show_xcode_9_warning
-        return unless Helper.xcode_at_least?("9.0")
-        UI.message("You passed a path to a custom plist file for exporting the binary.")
-        UI.message("Make sure to include information about what provisioning profiles to use with Xcode 9")
-        UI.message("More information: https://docs.fastlane.tools/codesigning/xcode-project/#xcode-9-and-up")
+      def self.description
+        "Alias for the `build_app` action but only for iOS"
       end
     end
   end

data/fastlane/lib/fastlane/actions/build_mac_app.rb

@@ -0,0 +1,46 @@
+module Fastlane
+  module Actions
+    require 'fastlane/actions/build_app'
+    class BuildMacAppAction < BuildAppAction
+      # Gym::Options.available_options keys that don't apply to mac apps.
+      REJECT_OPTIONS = [
+        :ipa,
+        :skip_package_ipa,
+        :catalyst_platform
+      ]
+
+      def self.run(params)
+        # Adding reject options back in  so gym has everything it needs
+        params.available_options += Gym::Options.available_options.select do |option|
+          REJECT_OPTIONS.include?(option.key)
+        end
+
+        # Defaulting to mac specific values
+        params[:catalyst_platform] = "macos"
+
+        super(params)
+      end
+
+      #####################################################
+      # @!group Documentation
+      #####################################################
+
+      def self.available_options
+        require 'gym'
+        require 'gym/options'
+
+        Gym::Options.available_options.reject do |option|
+          REJECT_OPTIONS.include?(option.key)
+        end
+      end
+
+      def self.is_supported?(platform)
+        [:mac].include?(platform)
+      end
+
+      def self.description
+        "Alias for the `build_app` action but only for macOS"
+      end
+    end
+  end
+end

data/fastlane/lib/fastlane/actions/create_pull_request.rb

@@ -2,6 +2,7 @@ module Fastlane
   module Actions
     module SharedValues
       CREATE_PULL_REQUEST_HTML_URL = :CREATE_PULL_REQUEST_HTML_URL
+      CREATE_PULL_REQUEST_NUMBER = :CREATE_PULL_REQUEST_NUMBER
     end
 
     class CreatePullRequestAction < Action
@@ -39,7 +40,14 @@ module Fastlane
           # Add assignees to pull request
           add_assignees(params, number) if params[:assignees]
 
+          # Add reviewers to pull request
+          add_reviewers(params, number) if params[:reviewers] || params[:team_reviewers]
+
+          # Add a milestone to pull request
+          add_milestone(params, number) if params[:milestone]
+
           Actions.lane_context[SharedValues::CREATE_PULL_REQUEST_HTML_URL] = html_url
+          Actions.lane_context[SharedValues::CREATE_PULL_REQUEST_NUMBER] = number
           return html_url
         end
       end
@@ -82,6 +90,51 @@ module Fastlane
         )
       end
 
+      def self.add_reviewers(params, number)
+        payload = {}
+        if params[:reviewers]
+          payload["reviewers"] = params[:reviewers]
+        end
+
+        if params[:team_reviewers]
+          payload["team_reviewers"] = params[:team_reviewers]
+        end
+        GithubApiAction.run(
+          server_url: params[:api_url],
+          api_token: params[:api_token],
+          http_method: 'POST',
+          path: "repos/#{params[:repo]}/pulls/#{number}/requested_reviewers",
+          body: payload,
+          error_handlers: {
+            '*' => proc do |result|
+              UI.error("GitHub responded with #{result[:status]}: #{result[:body]}")
+              return nil
+            end
+          }
+        )
+      end
+
+      def self.add_milestone(params, number)
+        payload = {}
+        if params[:milestone]
+          payload["milestone"] = params[:milestone]
+        end
+
+        GithubApiAction.run(
+          server_url: params[:api_url],
+          api_token: params[:api_token],
+          http_method: 'PATCH',
+          path: "repos/#{params[:repo]}/issues/#{number}",
+          body: payload,
+          error_handlers: {
+              '*' => proc do |result|
+                UI.error("GitHub responded with #{result[:status]}: #{result[:body]}")
+                return nil
+              end
+          }
+        )
+      end
+
       #####################################################
       # @!group Documentation
       #####################################################
@@ -92,7 +145,8 @@ module Fastlane
 
       def self.output
         [
-          ['CREATE_PULL_REQUEST_HTML_URL', 'The HTML URL to the created pull request']
+          ['CREATE_PULL_REQUEST_HTML_URL', 'The HTML URL to the created pull request'],
+          ['CREATE_PULL_REQUEST_NUMBER', 'The identifier number of the created pull request']
         ]
       end
 
@@ -127,6 +181,11 @@ module Fastlane
                                        description: "The labels for the pull request",
                                        type: Array,
                                        optional: true),
+          FastlaneCore::ConfigItem.new(key: :milestone,
+                                       env_name: "GITHUB_PULL_REQUEST_MILESTONE",
+                                       description: "The milestone ID (Integer) for the pull request",
+                                       type: Numeric,
+                                       optional: true),
           FastlaneCore::ConfigItem.new(key: :head,
                                        env_name: "GITHUB_PULL_REQUEST_HEAD",
                                        description: "The name of the branch where your changes are implemented (defaults to the current branch name)",
@@ -152,12 +211,22 @@ module Fastlane
                                        env_name: "GITHUB_PULL_REQUEST_ASSIGNEES",
                                        description: "The assignees for the pull request",
                                        type: Array,
+                                       optional: true),
+          FastlaneCore::ConfigItem.new(key: :reviewers,
+                                       env_name: "GITHUB_PULL_REQUEST_REVIEWERS",
+                                       description: "The reviewers (slug) for the pull request",
+                                       type: Array,
+                                       optional: true),
+          FastlaneCore::ConfigItem.new(key: :team_reviewers,
+                                       env_name: "GITHUB_PULL_REQUEST_TEAM_REVIEWERS",
+                                       description: "The team reviewers (slug) for the pull request",
+                                       type: Array,
                                        optional: true)
         ]
       end
 
       def self.author
-        ["seei", "tommeier", "marumemomo"]
+        ["seei", "tommeier", "marumemomo", "elneruda"]
       end
 
       def self.is_supported?(platform)

data/fastlane/lib/fastlane/actions/docs/{build_ios_app.md → build_app.md}

@@ -146,7 +146,7 @@ export_options({
 Optional: If _gym_ can't automatically detect the provisioning profiles to use, you can pass a mapping of bundle identifiers to provisioning profiles:
 
 ```ruby
-build_ios_app(
+build_app(
   scheme: "Release",
   export_options: {
     method: "app-store",

data/fastlane/lib/fastlane/actions/docs/sync_code_signing.md

@@ -111,6 +111,25 @@ match
 
 You can find more information about GitHub basic authentication and personal token generation here: [https://developer.github.com/v3/auth/#basic-authentication](https://developer.github.com/v3/auth/#basic-authentication)
 
+##### Git Storage on Azure Devops
+
+If you're running a pipeline on Azure Devops and using git storage in a another repository on the same project, you might want to use `bearer` token authentication.
+
+Using parameter:
+
+```
+match(git_bearer_authorization: '<YOUR TOKEN>')
+```
+
+Using environment variable:
+
+```
+ENV['MATCH_GIT_BEARER_AUTHORIZATION'] = '<YOUR TOKEN>'
+match
+```
+
+You can find more information about this use case here: [https://docs.microsoft.com/en-us/azure/devops/pipelines/repos/azure-repos-git?view=azure-devops&tabs=yaml#authorize-access-to-your-repositories](https://docs.microsoft.com/en-us/azure/devops/pipelines/repos/azure-repos-git?view=azure-devops&tabs=yaml#authorize-access-to-your-repositories)
+
 #### Google Cloud Storage
 
 Use [Google Cloud Storage](https://cloud.google.com/storage/) for a fully hosted solution for your code signing identities. Certificates are stored on Google Cloud, encrypted using Google managed keys. Everything will be stored on your Google account, inside a storage bucket you provide. You can also directly access the files using the web console.

data/fastlane/lib/fastlane/actions/docs/upload_to_app_store.md.erb

@@ -706,6 +706,16 @@ DELIVER_ITMSTRANSPORTER_ADDITIONAL_UPLOAD_PARAMETERS="-t DAV" fastlane deliver
 ## HTTP Proxy
 iTunes Transporter is a Java application bundled with Xcode. In addition to utilizing the `DELIVER_ITMSTRANSPORTER_ADDITIONAL_UPLOAD_PARAMETERS="-t DAV"`, you need to configure the transporter application to use the proxy independently from the system proxy or any environment proxy settings. You can find the configuration file within Xcode:
 
+**for Xcode11 and later**
+
+```no-highlight
+TOOLS_PATH=$( xcode-select -p )
+REL_PATH='../SharedFrameworks/ContentDeliveryServices.framework/Versions/A/itms/java/lib/net.properties'
+echo "$TOOLS_PATH/$REL_PATH"
+```
+
+**for Xcode10 or earlier**
+
 ```no-highlight
 TOOLS_PATH=$( xcode-select -p )
 REL_PATH='../Applications/Application Loader.app/Contents/itms/java/lib/net.properties'

data/fastlane/lib/fastlane/actions/docs/upload_to_play_store.md

@@ -136,7 +136,7 @@ Note that these will replace the current images and screenshots on the play stor
 
 ## Changelogs (What's new)
 
-You can add changelog files under the `changelogs/` directory for each locale. The filename should exactly match the [version code](https://developer.android.com/studio/publish/versioning#appversioning) of the APK that it represents. `fastlane supply init` will populate changelog files from existing data on Google Play if no `metadata/` directory exists when it is run.
+You can add changelog files under the `changelogs/` directory for each locale. The filename should exactly match the [version code](https://developer.android.com/studio/publish/versioning#appversioning) of the APK that it represents. You can also provide default notes that will be used if no files match the version code by adding a `default.txt` file. `fastlane supply init` will populate changelog files from existing data on Google Play if no `metadata/` directory exists when it is run.
 
 ```no-highlight
 └── fastlane
@@ -144,10 +144,12 @@ You can add changelog files under the `changelogs/` directory for each locale. T
         └── android
             ├── en-US
             │   └── changelogs
+            │       ├── default.txt
             │       ├── 100000.txt
             │       └── 100100.txt
             └── fr-FR
                 └── changelogs
+                    ├── default.txt
                     └── 100100.txt
 ```
 
@@ -168,7 +170,7 @@ Before performing a new APK upload you may want to check existing track version
   - Used when uploading with `:apk_path`, `:apk_paths`, `:aab_path`, and `:aab_paths`
   - Can be any string such (example: "October Release" or "Awesome New Feature")
   - Defaults to the version name in app/build.gradle or AndroidManifest.xml
-- `:release_status` 
+- `:release_status`
   - Used when uploading with `:apk_path`, `:apk_paths`, `:aab_path`, and `:aab_paths`
   - Can set as  "draft" to complete the release at some other time
   - Defaults to "completed"

data/fastlane/lib/fastlane/actions/ensure_bundle_exec.rb

@@ -10,7 +10,7 @@ module Fastlane
         if FastlaneCore::Helper.bundler?
           UI.success("Using bundled fastlane ✅")
         else
-          UI.user_error!("fastlane detected a Gemfile in the current directory. However it seems like you don't use `bundle exec`. Use `bundle exec fastlane #{ARGV.join(' ')}`")
+          UI.user_error!("fastlane detected a Gemfile in the current directory. However, it seems like you didn't use `bundle exec`. Use `bundle exec fastlane #{ARGV.join(' ')}` instead.")
         end
       end
 
@@ -24,8 +24,8 @@ module Fastlane
 
       def self.details
         [
-          "This action will check if you are using bundle exec to run fastlane.",
-          "You can put it into `before_all` and make sure that fastlane is run using `bundle exec fastlane` command."
+          "This action will check if you are using `bundle exec` to run fastlane.",
+          "You can put it into `before_all` to make sure that fastlane is ran using the `bundle exec fastlane` command."
         ].join("\n")
       end