fastlane 2.132.0.beta.20190921200021 → 2.132.0.beta.20190922200014

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: a9a1370c917620f6b6c1343a7c77d36be8f56b48
-  data.tar.gz: 6b12512f2c5a89b7a44f7d488f9a76924603ebcf
+  metadata.gz: 9a1ca53c03f79a2ab3085b365d28c70023b6b30a
+  data.tar.gz: 73dc05ecd0c1da1b68098c0aae53893297f5918c
 SHA512:
-  metadata.gz: cb7b0fbdcfc4223bedb37c6cebba6e6df517f200bcf26089e2ce7af8a470975ad8ff7b9465738b683c5051a2cf6b3711dbcdd08a72da240c2169d256629c12b3
-  data.tar.gz: 017fdafd04e914ffc94f1572a30bd2b7c0f0c8077de032f80f8d7697e9fddb491bce20d4e0f14e6767280bb12925235720afc5fa6bd8d436ee5a45f47c21b001
+  metadata.gz: 0da136f1a574afca72055877880ce358a0b46cfe66382216374790b94e2a5485cc50e201f6f3f8d1f0c88dc9dce892a7bde9437e22c13fa3dda364f542d518f1
+  data.tar.gz: 87eefbf93477988092f8be024a4694a8ffe3b5972a46b86c7c1fa4ba43d29db7e65dba082ee2aee3e34483439c50dad1f4ccadcbb067d346d14048aa496b5919

data/fastlane/lib/fastlane/actions/app_store_build_number.rb

@@ -36,6 +36,7 @@ module Fastlane
           return build_nr
         else
           version_number = params[:version]
+          platform = params[:platform]
 
           # Create filter for get_builds with optional version number
           filter = { app: app.apple_id }
@@ -46,18 +47,25 @@ module Fastlane
             version_number_message = "any version"
           end
 
+          if platform
+            filter["preReleaseVersion.platform"] = Spaceship::ConnectAPI::Platform.map(platform)
+            platform_message = "#{platform} platform"
+          else
+            platform_message = "any platform"
+          end
+
           UI.message("Fetching the latest build number for #{version_number_message}")
 
           # Get latest build for optional version number and return build number if found
           build = Spaceship::ConnectAPI.get_builds(filter: filter, sort: "-uploadedDate", includes: "preReleaseVersion", limit: 1).first
           if build
             build_nr = build.version
-            UI.message("Latest upload for version #{build.app_version} is build: #{build_nr}")
+            UI.message("Latest upload for version #{build.app_version} on #{platform_message} is build: #{build_nr}")
             return build_nr
           end
 
           # Let user know that build couldn't be found
-          UI.important("Could not find a build for #{version_number_message} on App Store Connect")
+          UI.important("Could not find a build for #{version_number_message} on #{platform_message} on App Store Connect")
 
           if params[:initial_build_number].nil?
             UI.user_error!("Could not find a build on App Store Connect - and 'initial_build_number' option is not set")

data/fastlane/lib/fastlane/actions/docs/sync_code_signing.md

@@ -6,7 +6,7 @@
 
 A new approach to iOS code signing: Share one code signing identity across your development team to simplify your codesigning setup and prevent code signing issues.
 
-_match_ is the implementation of the [https://codesigning.guide concept](https://codesigning.guide). _match_ creates all required certificates & provisioning profiles and stores them in a separate git repository. Every team member with access to the repo can use those credentials for code signing. _match_ also automatically repairs broken and expired credentials. It's the easiest way to share signing credentials across teams
+_match_ is the implementation of the [codesigning.guide concept](https://codesigning.guide). _match_ creates all required certificates & provisioning profiles and stores them in a separate git repository. Every team member with access to the repo can use those credentials for code signing. _match_ also automatically repairs broken and expired credentials. It's the easiest way to share signing credentials across teams
 
 [More information on how to get started with codesigning](https://docs.fastlane.tools/codesigning/getting-started/)
 
@@ -138,7 +138,7 @@ match(git_branch: "team2", username: "user@team2.com")
 
 #### Google Cloud Storage
 
-If you use Google Cloud Storage, you don't need to do anything manually. Just use Google Cloud Storage, and the top level folder will be the team ID.
+If you use Google Cloud Storage, you don't need to do anything manually for multiple teams. Just use Google Cloud Storage, and the top level folder will be the team ID.
 
 ### Run
 
@@ -233,7 +233,7 @@ There are two cases for reading and writing certificates stored in a Google Clou
 1. Continuous integration jobs. These will authenticate to your Google Cloud project via a service account, and use a `gc_keys.json` file as credentials.
 1. Developers on a local workstation. In this case, you should choose whether everyone on your team will create their own `gc_keys.json` file, or whether you want to manage access to the bucket directly using your developers' Google accounts.
 
-When running `fastlane match init` the first time, the setup process will give you the option to create your `gc_keys.json` file. This file contains the auth credentials needed to access your Google Cloud storage bucket. Make sure to keep that file secret and never add it to version control. We recommend adding `gc_keys.json` to your `.gitignore`
+When running `fastlane match init` the first time, the setup process will give you the option to create your `gc_keys.json` file. This file contains the authentication credentials needed to access your Google Cloud storage bucket. Make sure to keep that file secret and never add it to version control. We recommend adding `gc_keys.json` to your `.gitignore`
 
 ##### Managing developer access via keys
 If you want to manage developer access to your certificates via authentication keys, every developer should create their own `gc_keys.json` and add the file to all their work machines. This will give the admin full control over who has read/write access to the given Storage bucket. At the same time it allows your team to revoke a single key if a file gets compromised.

data/fastlane/lib/fastlane/version.rb

@@ -1,5 +1,5 @@
 module Fastlane
-  VERSION = '2.132.0.beta.20190921200021'.freeze
+  VERSION = '2.132.0.beta.20190922200014'.freeze
   DESCRIPTION = "The easiest way to automate beta deployments and releases for your iOS and Android apps".freeze
   MINIMUM_XCODE_RELEASE = "7.0".freeze
   RUBOCOP_REQUIREMENT = '0.49.1'.freeze

data/match/lib/match/storage/google_cloud_storage.rb

@@ -97,6 +97,7 @@ module Match
         end
 
         ensure_bucket_is_selected
+        check_bucket_permissions
       end
 
       def currently_used_team_id
@@ -234,74 +235,122 @@ module Match
           end
         end
 
-        # User doesn't seem to have provided a keys file.
-        UI.message("Looks like you don't have a Google Cloud #{DEFAULT_KEYS_FILE_NAME.cyan} file")
-        UI.message("If you have one, make sure to put it into the '#{Dir.pwd}' directory and call it '#{DEFAULT_KEYS_FILE_NAME.cyan}'")
+        # User doesn't seem to have provided a keys file
+        UI.message("Looks like you don't have a Google Cloud #{DEFAULT_KEYS_FILE_NAME.cyan} file yet.")
+        UI.message("If you have one, make sure to put it into the '#{Dir.pwd}' directory and call it '#{DEFAULT_KEYS_FILE_NAME.cyan}'.")
         unless UI.confirm("Do you want fastlane to help you to create a #{DEFAULT_KEYS_FILE_NAME} file?")
           UI.user_error!("Process stopped, run fastlane again to start things up again")
         end
 
-        UI.message("fastlane will help you create a keys file. First, open the following website")
+        UI.message("fastlane will help you create a keys file. Start by opening the following website:")
         UI.message("")
         UI.message("\t\thttps://console.cloud.google.com".cyan)
         UI.message("")
-        UI.input("Press enter once you're logged in")
+        UI.input("Press [Enter] once you're logged in")
 
-        UI.message("Now it's time to generate a new JSON auth file for fastlane to access Google Cloud")
         UI.message("First, switch to the Google Cloud project you want to use.")
-        UI.message("If you don't have one yet, create a new one and switch to it")
+        UI.message("If you don't have one yet, create a new one and switch to it.")
         UI.message("")
-        UI.message("\t\thttps://console.cloud.google.com/apis/credentials".cyan)
+        UI.message("\t\thttps://console.cloud.google.com/projectcreate".cyan)
         UI.message("")
-        UI.input("Ensure the right project is selected on top of the page and confirm with enter")
+        UI.input("Press [Enter] once you selected the right project")
 
-        UI.message("Now create a new JSON auth file by clicking on")
+        UI.message("Next fastlane will show you the steps to create a keys file.")
+        UI.message("For this it might be useful to switch the Google Cloud interface to English.")
+        UI.message("Append " + "&hl=en".cyan + " to the URL and the interface should be in English.")
+        UI.input("Press [Enter] to continue")
+
+        UI.message("Now it's time to generate a new JSON auth file for fastlane to access Google Cloud Storage:")
         UI.message("")
-        UI.message("\t\t 1. Create credentials".cyan)
-        UI.message("\t\t 2. Service account key".cyan)
-        UI.message("\t\t 3. App Engine default service account".cyan)
-        UI.message("\t\t 4. JSON".cyan)
-        UI.message("\t\t 5. Create".cyan)
+        UI.message("\t\t 1. From the side menu choose 'APIs & Services' and then 'Credentials'".cyan)
+        UI.message("\t\t 2. Click 'Create credentials'".cyan)
+        UI.message("\t\t 3. Choose 'Service account key'".cyan)
+        UI.message("\t\t 4. Select 'New service account'".cyan)
+        UI.message("\t\t 5. Enter a name and ID for the service account".cyan)
+        UI.message("\t\t 6. Don't give the service account a role just yet!".cyan)
+        UI.message("\t\t 7. Make sure the key type is set to 'JSON'".cyan)
+        UI.message("\t\t 8. Click 'Create'".cyan)
         UI.message("")
-        UI.input("Confirm with enter once you created and download the JSON file")
+        UI.input("Confirm with [Enter] once you created and downloaded the JSON file")
 
         UI.message("Copy the file to the current directory (#{Dir.pwd})")
         UI.message("and rename it to `#{DEFAULT_KEYS_FILE_NAME.cyan}`")
         UI.message("")
-        UI.input("Confirm with enter")
+        UI.input("Confirm with [Enter]")
 
         until File.exist?(DEFAULT_KEYS_FILE_NAME)
           UI.message("Make sure to place the file in '#{Dir.pwd.cyan}' and name it '#{DEFAULT_KEYS_FILE_NAME.cyan}'")
-          UI.input("Confirm with enter")
+          UI.message("")
+          UI.input("Confirm with [Enter]")
         end
 
         UI.important("Please never add the #{DEFAULT_KEYS_FILE_NAME.cyan} file in version control.")
-        UI.important("Instead please add the file to your .gitignore")
-        UI.input("Confirm with enter")
+        UI.important("Instead please add the file to your `.gitignore` file")
+        UI.message("")
+        UI.input("Confirm with [Enter]")
 
         return DEFAULT_KEYS_FILE_NAME
       end
 
       def ensure_bucket_is_selected
-        # In case the user didn't provide a bucket name yet, they will
-        # be asked to provide one here
+        created_bucket = UI.confirm("Did you already create a Google Cloud Storage bucket?")
         while self.bucket_name.to_s.length == 0
-          # Have a nice selection of the available buckets here
-          # This can only happen after we went through auth of Google Cloud
-          available_bucket_identifiers = self.gc_storage.buckets.collect(&:id)
-          if available_bucket_identifiers.count > 0
-            @bucket_name = UI.select("What Google Cloud Storage bucket do you want to use? (you can define it using the `google_cloud_bucket_name` key)", available_bucket_identifiers)
-          else
-            UI.error("Looks like your Google Cloud account for the project ID '#{self.google_cloud_project_id}' doesn't")
-            UI.error("have any available storage buckets yet. Please visit the following URL")
+          unless created_bucket
+            UI.message("Create a bucket at the following URL:")
             UI.message("")
             UI.message("\t\thttps://console.cloud.google.com/storage/browser".cyan)
             UI.message("")
-            UI.message("and make sure to have the right project selected on top of the page")
-            UI.message("click on " + "Create Bucket".cyan + ", choose a name and confirm")
+            UI.message("Make sure to select the right project at the top of the page!")
+            UI.message("")
+            UI.message("\t\t 1. Click 'Create bucket'".cyan)
+            UI.message("\t\t 2. Enter a unique name".cyan)
+            UI.message("\t\t 3. Select a geographic location for your bucket".cyan)
+            UI.message("\t\t 4. Make sure the storage class is set to 'Standard'".cyan)
+            UI.message("\t\t 5. Click 'Create' to create the bucket".cyan)
             UI.message("")
-            UI.input("Once you're finished, please confirm with enter")
+            UI.input("Press [Enter] once you created a bucket")
+          end
+          bucket_name = UI.input("Enter the name of your bucket: ")
+
+          # Verify if the bucket exists
+          begin
+            bucket_exists = !self.gc_storage.bucket(bucket_name).nil?
+          rescue Google::Cloud::PermissionDeniedError
+            bucket_exists = true
+          end
+          created_bucket = bucket_exists
+          if bucket_exists
+            @bucket_name = bucket_name
+          else
+            UI.error("It looks like the bucket '#{bucket_name}' doesn't exist. Make sure to create it first.")
+          end
+        end
+      end
+
+      def check_bucket_permissions
+        bucket = nil
+        while bucket.nil?
+          begin
+            bucket = self.gc_storage.bucket(self.bucket_name)
+          rescue Google::Cloud::PermissionDeniedError
+            bucket = nil
           end
+          return if bucket.nil? == false
+          UI.error("Looks like your Google Cloud account for the project ID '#{self.google_cloud_project_id}' doesn't")
+          UI.error("have access to the storage bucket '#{self.bucket_name}'. Please visit the following URL:")
+          UI.message("")
+          UI.message("\t\thttps://console.cloud.google.com/storage/browser".cyan)
+          UI.message("")
+          UI.message("You need to give your account the correct permissions:")
+          UI.message("")
+          UI.message("\t\t 1. Click on your bucket to open it".cyan)
+          UI.message("\t\t 2. Click 'Permissions'".cyan)
+          UI.message("\t\t 3. Click 'Add members'".cyan)
+          UI.message("\t\t 4. Enter the email of your service account".cyan)
+          UI.message("\t\t 5. Set the role to 'Storage Admin'".cyan)
+          UI.message("\t\t 6. Click 'Save'".cyan)
+          UI.message("")
+          UI.input("Confirm with [Enter] once you're finished")
         end
       end
     end

data/spaceship/lib/spaceship/tunes/app_version.rb

@@ -192,6 +192,9 @@ module Spaceship
       # @return (Hash) Represents the trailers of this app version (read-only)
       attr_reader :trailers
 
+      # @return (Hash) A hash representing all in-app purchases that can get submitted with this version
+      attr_reader :in_app_purchases
+
       # @return (Hash) Represents the phased_release hash (read-only)
       #   For now, please use the `toggle_phased_release` method and call `.save!`
       #   as the API will probably change in the future
@@ -233,6 +236,7 @@ module Spaceship
         'supportsAppleWatch' => :supports_apple_watch,
         'versionId' => :version_id,
         'version.value' => :version,
+        'submittableAddOns.value' => :in_app_purchases,
         'phasedRelease' => :phased_release,
 
         # GeoJson

data/spaceship/lib/spaceship/tunes/iap_family_details.rb

@@ -9,12 +9,20 @@ module Spaceship
       # @return (String) the family name
       attr_accessor :name
 
-      # @return (Intger) the Family Id
+      # @return (Intger) the family id
       attr_accessor :family_id
 
+      # @return (Array) all linked in-app purchases of this family
+      attr_accessor :linked_iaps
+
+      # @return (Intger) amount of linked in-app purchases of this family (read-only)
+      attr_accessor :iap_count
+
       attr_mapping({
         'id' => :family_id,
-        'name.value' => :name
+        'name.value' => :name,
+        'activeAddOns' => :linked_iaps,
+        'totalActiveAddOns' => :iap_count
       })
 
       def versions=(value = {})

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: fastlane
 version: !ruby/object:Gem::Version
-  version: 2.132.0.beta.20190921200021
+  version: 2.132.0.beta.20190922200014
 platform: ruby
 authors:
 - Andrew McBurney
@@ -27,7 +27,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-09-21 00:00:00.000000000 Z
+date: 2019-09-22 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: slack-notifier
@@ -1747,24 +1747,24 @@ metadata:
 post_install_message: 
 rdoc_options: []
 require_paths:
-- scan/lib
-- deliver/lib
-- fastlane_core/lib
-- spaceship/lib
-- produce/lib
-- fastlane/lib
-- gym/lib
-- match/lib
-- sigh/lib
+- precheck/lib
 - credentials_manager/lib
 - cert/lib
-- frameit/lib
-- pem/lib
 - supply/lib
+- deliver/lib
+- sigh/lib
+- match/lib
+- pem/lib
+- produce/lib
 - screengrab/lib
-- pilot/lib
-- precheck/lib
+- gym/lib
+- spaceship/lib
 - snapshot/lib
+- frameit/lib
+- fastlane_core/lib
+- fastlane/lib
+- pilot/lib
+- scan/lib
 required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="