fastlane 2.126.0.beta.20190616200045 → 2.126.0.beta.20190617200114

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: bf65da45eb0c23435ac2be3d68775851e6356b52
-  data.tar.gz: 5122d1e20b42fb9476f839b43459591054f05142
+  metadata.gz: eccba11a51b1f8bc129b1bc0c78ca0bd65f6b92f
+  data.tar.gz: ba18bf6c703836eaebe985ac3e4bea001c94ccab
 SHA512:
-  metadata.gz: f8f92b38b8406fa43124d42211f63617cd5b595707043987fb4c315ee378d90a1e41c38775294cee82d4d2e626d4844fefda2a13a8015c1b6505a48c1aeda73f
-  data.tar.gz: dec4da2271ed4743b57e8476f5f826f61664454622aa3a974f5d88d693f11159e222cf828a16bf81c34888770eed2f7f34ae8155b892c26571ccdc998efdfb87
+  metadata.gz: 80f5a0affed6278cb9dc0eb22534a4524634abbc6800da5b0849df34d8f5710f2a9497a035eec21e43feec0594d3ee2506019d1589d03b93ad0bb3308b5c67ba
+  data.tar.gz: a915231c378eee871930f7fbb1353d0fa9b17613ec2a375cae7f403637487fc504e77bb6a08dac0e4618c982bd1464dba1df5f9ae7a8d6e5e91404520b4fb6b3

data/deliver/lib/deliver/options.rb

@@ -324,6 +324,10 @@ module Deliver
                                      optional: true,
                                      is_string: false,
                                      type: Hash),
+        FastlaneCore::ConfigItem.new(key: :app_review_attachment_file,
+                                     description: "Metadata: Path to the app review attachment file",
+                                     optional: true,
+                                     is_string: true),
         # Localised
         FastlaneCore::ConfigItem.new(key: :description,
                                      description: "Metadata: The localised app description",

data/deliver/lib/deliver/upload_metadata.rb

@@ -132,6 +132,8 @@ module Deliver
       set_app_rating(v, options)
       v.ratings_reset = options[:reset_ratings] unless options[:reset_ratings].nil?
 
+      set_review_attachment_file(v, options)
+
       Helper.show_loading_indicator("Uploading metadata to App Store Connect")
       v.save!
       Helper.hide_loading_indicator
@@ -367,6 +369,11 @@ module Deliver
       v.review_user_needed = (v.review_demo_user.to_s.chomp + v.review_demo_password.to_s.chomp).length > 0
     end
 
+    def set_review_attachment_file(v, options)
+      return unless options[:app_review_attachment_file]
+      v.upload_review_attachment!(options[:app_review_attachment_file])
+    end
+
     def set_app_rating(v, options)
       return unless options[:app_rating_config_path]
 

data/fastlane/lib/fastlane/actions/docs/upload_to_app_store.md.erb

@@ -237,6 +237,15 @@ app_review_information(
 
 You can also provide these values by creating files in a `metadata/review_information/` directory. The file names must match the pattern `<key>.txt` (e.g. `first_name.txt`, `notes.txt` etc.). The contents of each file will be used as the value for the matching key. Values provided in the `Deliverfile` or `Fastfile` will be take priority over values from these files.
 
+##### app_review_attachment_file
+You can provide additional information to the app review team as a file attachment. As of this writing, Apple supports following file attachment formats: .pdf, .doc, .docx, .rtf, .pages, .xls, .xlsx, .numbers, .zip, .rar, .plist, .crash, .jpg, .png, .mp4, or .avi.
+
+Provide an empty string (i.e. "", not null) to remove the existing attachment file (if any) from the review information being edited.
+
+```ruby-skip-tests
+app_review_attachment_file: "./readme.txt"
+```
+
 ##### submission_information
 Must be a hash. This is used as the last step for the deployment process, where you define if you use third party content or use encryption. [A list of available options](https://github.com/fastlane/fastlane/blob/master/spaceship/lib/spaceship/tunes/app_submission.rb).
 

data/fastlane/lib/fastlane/version.rb

@@ -1,5 +1,5 @@
 module Fastlane
-  VERSION = '2.126.0.beta.20190616200045'.freeze
+  VERSION = '2.126.0.beta.20190617200114'.freeze
   DESCRIPTION = "The easiest way to automate beta deployments and releases for your iOS and Android apps".freeze
   MINIMUM_XCODE_RELEASE = "7.0".freeze
   RUBOCOP_REQUIREMENT = '0.49.1'.freeze

data/spaceship/lib/spaceship/du/du_client.rb

@@ -46,6 +46,10 @@ module Spaceship
       upload_file(app_version: app_version, upload_file: upload_file, path: '/upload/image', content_provider_id: content_provider_id, sso_token: sso_token_for_image, du_validation_rule_set: screenshot_picture_type(device, nil))
     end
 
+    def upload_app_review_attachment(app_version, upload_file, content_provider_id, sso_token_for_attachment)
+      upload_file(app_version: app_version, upload_file: upload_file, path: '/upload/app-resolution-file', content_provider_id: content_provider_id, sso_token: sso_token_for_attachment)
+    end
+
     def get_picture_type(upload_file)
       resolution = Utilities.resolution(upload_file.file_path)
       result = device_resolution_map.find do |key, resolutions|

data/spaceship/lib/spaceship/du/utilities.rb

@@ -8,14 +8,32 @@ module Spaceship
     # Supports all formats required by DU-UTC right now (video, images and json)
     # @param path (String) the path to the file
     def content_type(path)
-      path = path.downcase
-      return 'image/jpeg' if path.end_with?('.jpg')
-      return 'image/jpeg' if path.end_with?('.jpeg')
-      return 'image/png' if path.end_with?('.png')
-      return 'application/json' if path.end_with?('.geojson')
-      return 'video/quicktime' if path.end_with?('.mov')
-      return 'video/mp4' if path.end_with?('.m4v')
-      return 'video/mp4' if path.end_with?('.mp4')
+      supported_file_types = {
+        '.jpg' => 'image/jpeg',
+        '.jpeg' => 'image/jpeg',
+        '.png' => 'image/png',
+        '.geojson' => 'application/json',
+        '.mov' => 'video/quicktime',
+        '.m4v' => 'video/mp4',
+        '.mp4' => 'video/mp4',
+        '.txt' => 'text/plain',
+        '.pdf' => 'application/pdf',
+        '.doc' => 'application/msword',
+        '.docx' => 'application/vnd.openxmlformats-officedocument.wordprocessingml.document',
+        '.rtf' => 'application/rtf',
+        '.pages' => 'application/x-iwork-pages-sffpages',
+        '.xls' => 'application/vnd.ms-excel',
+        '.xlsx' => 'application/vnd.openxmlformats-officedocument.spreadsheetml.sheet',
+        '.numbers' => 'application/x-iwork-numbers-sffnumbers',
+        '.rar' => 'application/x-rar-compressed',
+        '.plist' => 'application/xml',
+        '.crash' => 'text/x-apport',
+        '.avi' => 'video/x-msvideo',
+        '.zip' => 'application/zip'
+      }
+
+      extension = File.extname(path.downcase)
+      return supported_file_types[extension] if supported_file_types[extension]
       raise "Unknown content-type for file #{path}"
     end
 

data/spaceship/lib/spaceship/tunes/app_review_attachment.rb

@@ -0,0 +1,49 @@
+require_relative 'tunes_base'
+
+module Spaceship
+  module Tunes
+    # Represents an image hosted on App Store Connect. Used for app store review attachment file.
+    class AppReviewAttachment < TunesBase
+      HOST_URL = "https://iosapps-ssl.itunes.apple.com/itunes-assets"
+
+      attr_accessor :asset_token
+
+      attr_accessor :original_file_name
+
+      attr_accessor :url
+
+      attr_accessor :type_of_file
+
+      attr_mapping(
+        'assetToken' => :asset_token,
+        'fileType' => :type_of_file,
+        'url' => :url,
+        'name' => :original_file_name
+      )
+
+      def reset!(attrs = {})
+        update_raw_data!(
+          {
+            asset_token: nil,
+            type_of_file: nil,
+            url: nil,
+            original_file_name: nil
+          }.merge(attrs)
+        )
+      end
+
+      def setup
+        # Since September 2015 we don't get the url any more, so we have to manually build it
+        self.url = "#{HOST_URL}/#{self.asset_token}"
+      end
+
+      private
+
+      def update_raw_data!(hash)
+        hash.each do |k, v|
+          self.send("#{k}=", v)
+        end
+      end
+    end
+  end
+end

data/spaceship/lib/spaceship/tunes/app_version.rb

@@ -1,3 +1,4 @@
+
 require_relative 'tunes_client'
 require_relative 'app_trailer'
 require_relative 'app_screenshot'
@@ -8,6 +9,7 @@ require_relative 'language_item'
 require_relative 'transit_app_file'
 require_relative 'build'
 require_relative 'app_status'
+require_relative 'app_review_attachment'
 
 module Spaceship
   module Tunes
@@ -79,6 +81,9 @@ module Spaceship
       # @return (Integer) a unqiue ID for this version generated by App Store Connect
       attr_accessor :version_id
 
+      # @return (Spaceship::Tunes::AppReviewAttachment) the structure containing information about the review attachment file
+      attr_accessor :review_attachment_file
+
       ####
       # GeoJson
       ####
@@ -417,6 +422,7 @@ module Spaceship
 
         setup_large_app_icon
         setup_watch_app_icon
+        setup_review_attachment_file if supports_review_attachment_file?
         setup_transit_app_file if supports_app_transit?
         setup_screenshots
         setup_trailers
@@ -435,6 +441,17 @@ module Spaceship
         }
       end
 
+      # This method will generate the required keys/values
+      # for App Store Connect to validate the review attachment file
+      def generate_review_attachment_file(review_attachment_data, review_attachment_file)
+        {
+          assetToken: review_attachment_data["token"],
+          name: File.basename(review_attachment_file),
+          fileType: Utilities.content_type(review_attachment_file),
+          url: nil
+        }
+      end
+
       # Uploads or removes the large icon
       # @param icon_path (String): The path to the icon. Use nil to remove it
       def upload_large_icon!(icon_path)
@@ -609,6 +626,34 @@ module Spaceship
         setup_trailers
       end
 
+      # Uploads, app review attachments
+      #
+      # while submitting for review, ITC allow developers to attach file.
+      #
+      # Following list can be found at https://appstoreconnect.apple.com
+      # on iOS app edit version, above the attachment label/button there is
+      # a question mark if it is press the a dialog is shown which has the list.
+      #
+      # File types allowed by Apple are: pdf, doc, docx, rtf, pages, xls, xlsx, numbers
+      # zip, rar, plist, crash, jpg, png, mp4 or avi.
+      #
+      #
+      # @param review_attachment_path (String): The path to the attachment file.
+      def upload_review_attachment!(review_attachment_path)
+        raise 'cannot upload review attachment for live edition.' if self.is_live?
+
+        if !review_attachment_path || review_attachment_path.size < 1
+          @review_attachment_file.reset!
+          return
+        end
+
+        raise "cannot find file: #{review_attachment_path}." unless File.exist?(review_attachment_path)
+
+        review_attachment_file = UploadFile.from_path(review_attachment_path)
+        review_attachment_data = client.upload_app_review_attachment(self, review_attachment_file)
+        raw_data["appReviewInfo"]["attachmentFiles"]["value"] = generate_review_attachment_file(review_attachment_data, review_attachment_path)
+      end
+
       # Prefill name, keywords, etc...
       def unfold_languages
         {
@@ -672,6 +717,16 @@ module Spaceship
         @watch_app_icon = Tunes::AppImage.factory(watch_app_icon) if watch_app_icon
       end
 
+      def setup_review_attachment_file
+        review_attachment_file = raw_data["appReviewInfo"]["attachmentFiles"]["value"]
+        @review_attachment_file = nil
+        @review_attachment_file = Tunes::AppReviewAttachment.factory(review_attachment_file)
+      end
+
+      def supports_review_attachment_file?
+        raw_data["appReviewInfo"]["attachmentFiles"] && raw_data["appReviewInfo"]["attachmentFiles"]["value"]
+      end
+
       def supports_app_transit?
         raw_data["transitAppFile"] != nil
       end

data/spaceship/lib/spaceship/tunes/tunes_client.rb

@@ -873,6 +873,21 @@ module Spaceship
       du_client.upload_trailer_preview(app_version, upload_trailer_preview, content_provider_id, sso_token_for_image, device)
     end
 
+    #####################################################
+    # @!review attachment file
+    #####################################################
+    # Uploads a attachment file
+    # @param app_version (AppVersion): The version of your app(must be edit version)
+    # @param upload_attachment_file (file): File to upload
+    # @return [JSON] the response
+    def upload_app_review_attachment(app_version, upload_attachment_file)
+      raise "app_version is required" unless app_version
+      raise "app_version must be live version" if app_version.is_live?
+      raise "upload_attachment_file is required" unless upload_attachment_file
+
+      du_client.upload_app_review_attachment(app_version, upload_attachment_file, content_provider_id, sso_token_for_image)
+    end
+
     # Fetches the App Version Reference information from ITC
     # @return [AppVersionRef] the response
     def ref_data

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: fastlane
 version: !ruby/object:Gem::Version
-  version: 2.126.0.beta.20190616200045
+  version: 2.126.0.beta.20190617200114
 platform: ruby
 authors:
 - Joshua Liebowitz
@@ -27,7 +27,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-06-16 00:00:00.000000000 Z
+date: 2019-06-17 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: slack-notifier
@@ -1657,6 +1657,7 @@ files:
 - spaceship/lib/spaceship/tunes/app_image.rb
 - spaceship/lib/spaceship/tunes/app_ratings.rb
 - spaceship/lib/spaceship/tunes/app_review.rb
+- spaceship/lib/spaceship/tunes/app_review_attachment.rb
 - spaceship/lib/spaceship/tunes/app_screenshot.rb
 - spaceship/lib/spaceship/tunes/app_status.rb
 - spaceship/lib/spaceship/tunes/app_submission.rb
@@ -1725,24 +1726,24 @@ metadata:
 post_install_message: 
 rdoc_options: []
 require_paths:
-- supply/lib
-- match/lib
+- frameit/lib
 - snapshot/lib
-- credentials_manager/lib
+- supply/lib
+- gym/lib
 - produce/lib
-- pilot/lib
-- frameit/lib
+- spaceship/lib
+- scan/lib
 - deliver/lib
-- fastlane/lib
+- cert/lib
 - fastlane_core/lib
-- sigh/lib
-- gym/lib
-- pem/lib
+- pilot/lib
+- credentials_manager/lib
 - precheck/lib
-- cert/lib
+- sigh/lib
 - screengrab/lib
-- spaceship/lib
-- scan/lib
+- match/lib
+- fastlane/lib
+- pem/lib
 required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="