fastlane 2.123.0.beta.20190507200014 → 2.123.0.beta.20190508200056

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 714d78ecd9db9feaf14e5f1f4a1e1eb60ef518aa
-  data.tar.gz: 247f87bf9ea9ee1a1d36a4cf91a7582520cadd0c
+  metadata.gz: 44ba9c053828aa330fdf2b970e8877979f5c6aaa
+  data.tar.gz: 3146fe676e7313faace99f3159a772f2f8724e5a
 SHA512:
-  metadata.gz: de4fa0b8654b8dcb82c30ed03070e1af68a61dbf323ed4da50f9c7c8f7d186bfb178bd466816a51b90006f61259efee035d205ac8ab6274991e6d541a0d25b61
-  data.tar.gz: b6fe8945643fe778bfd23a06c300cd5ad6e9a50ef4099deafd2f86a003eef07f94e873872a08c72f057954794408768818cbbb34ab22460244e7fd42eadc605b
+  metadata.gz: a2a08a63a529b9d0c56309cc075ea867e1ac3d04ebc039c69b622bdbe93a765e921a563af6b20a5cfd507c560dc7575bcc38f0d971fcaca759ea748d0f68ee91
+  data.tar.gz: 60119ef1dc886d456b9f02c7cfefe84999b16436289c524777556df6226c95531fabb53c051ff17b77a86de85eecbf83db03c7277d082dff01ea7451ff943a9b

data/fastlane/lib/fastlane/actions/docs/upload_to_testflight.md

@@ -225,3 +225,7 @@ _pilot_ uses the [CredentialsManager](https://github.com/fastlane/fastlane/tree/
 
 ## Provider Short Name
 If you are on multiple App Store Connect teams, iTunes Transporter may need a provider short name to know where to upload your binary. _pilot_ will try to use the long name of the selected team to detect the provider short name. To override the detected value with an explicit one, use the `itc_provider` option.
+
+## Use an Application Specific Password to upload
+
+_pilot_/`upload_to_testflight` can use an [Application Specific Password via the `FASTLANE_APPLE_APPLICATION_SPECIFIC_PASSWORD` envirionment variable](https://docs.fastlane.tools/best-practices/continuous-integration/#application-specific-passwords) to upload a binary if both the `skip_waiting_for_build_processing` and `apple_id` options are set. (If any of those are not set, it will use the normal Apple login process that might require 2FA authentication.)

data/fastlane/lib/fastlane/version.rb

@@ -1,5 +1,5 @@
 module Fastlane
-  VERSION = '2.123.0.beta.20190507200014'.freeze
+  VERSION = '2.123.0.beta.20190508200056'.freeze
   DESCRIPTION = "The easiest way to automate beta deployments and releases for your iOS and Android apps".freeze
   MINIMUM_XCODE_RELEASE = "7.0".freeze
   RUBOCOP_REQUIREMENT = '0.49.1'.freeze

data/pilot/lib/pilot/build_manager.rb

@@ -10,7 +10,10 @@ require_relative 'manager'
 module Pilot
   class BuildManager < Manager
     def upload(options)
-      start(options)
+      # Only need to login before upload if no apple_id was given
+      # 'login' will be deferred until before waiting for build processing
+      should_login_in_start = options[:apple_id].nil?
+      start(options, should_login: should_login_in_start)
 
       options[:changelog] = self.class.sanitize_changelog(options[:changelog]) if options[:changelog]
 
@@ -24,18 +27,18 @@ module Pilot
         end
       end
 
-      UI.success("Ready to upload new build to TestFlight (App: #{app.apple_id})...")
+      UI.success("Ready to upload new build to TestFlight (App: #{fetch_apple_id})...")
 
       dir = Dir.mktmpdir
 
       platform = fetch_app_platform
-      package_path = FastlaneCore::IpaUploadPackageBuilder.new.generate(app_id: app.apple_id,
-                                                                      ipa_path: config[:ipa],
+      package_path = FastlaneCore::IpaUploadPackageBuilder.new.generate(app_id: fetch_apple_id,
+                                                                      ipa_path: options[:ipa],
                                                                   package_path: dir,
                                                                       platform: platform)
 
       transporter = transporter_for_selected_team(options)
-      result = transporter.upload(app.apple_id, package_path)
+      result = transporter.upload(fetch_apple_id, package_path)
 
       unless result
         UI.user_error!("Error uploading ipa file, for more information see above")
@@ -49,6 +52,9 @@ module Pilot
         return
       end
 
+      # Calling login again here is needed if login was not called during 'start'
+      login unless should_login_in_start
+
       UI.message("If you want to skip waiting for the processing to be finished, use the `skip_waiting_for_build_processing` option")
       latest_build = wait_for_build_processing_to_be_complete
       distribute(options, build: latest_build)
@@ -58,7 +64,7 @@ module Pilot
       platform = fetch_app_platform
       app_version = FastlaneCore::IpaFileAnalyser.fetch_app_version(config[:ipa])
       app_build = FastlaneCore::IpaFileAnalyser.fetch_app_build(config[:ipa])
-      latest_build = FastlaneCore::BuildWatcher.wait_for_build_processing_to_be_complete(app_id: app.apple_id, platform: platform, train_version: app_version, build_version: app_build, poll_interval: config[:wait_processing_interval])
+      latest_build = FastlaneCore::BuildWatcher.wait_for_build_processing_to_be_complete(app_id: app.apple_id, platform: platform, train_version: app_version, build_version: app_build, poll_interval: config[:wait_processing_interval], strict_build_watch: config[:wait_for_uploaded_build])
 
       unless latest_build.train_version == app_version && latest_build.build_version == app_build
         UI.important("Uploaded app #{app_version} - #{app_build}, but received build #{latest_build.train_version} - #{latest_build.build_version}.")
@@ -220,7 +226,8 @@ module Pilot
     # If there are fewer than two teams, don't infer the provider.
     def transporter_for_selected_team(options)
       generic_transporter = FastlaneCore::ItunesTransporter.new(options[:username], nil, false, options[:itc_provider])
-      return generic_transporter unless options[:itc_provider].nil? && Spaceship::Tunes.client.teams.count > 1
+      return generic_transporter if options[:itc_provider] || Spaceship::Tunes.client.nil?
+      return generic_transporter unless Spaceship::Tunes.client.teams.count > 1
 
       begin
         team = Spaceship::Tunes.client.teams.find { |t| t['contentProvider']['contentProviderId'].to_s == Spaceship::Tunes.client.team_id }

data/pilot/lib/pilot/manager.rb

@@ -10,10 +10,10 @@ require_relative 'module'
 
 module Pilot
   class Manager
-    def start(options)
+    def start(options, should_login: true)
       return if @config # to not login multiple times
       @config = options
-      login
+      login if should_login
     end
 
     def login
@@ -27,7 +27,7 @@ module Pilot
 
     # The app object we're currently using
     def app
-      @apple_id ||= fetch_app_id
+      @apple_id ||= fetch_apple_id
 
       @app ||= Spaceship::Tunes::Application.find(@apple_id)
       unless @app
@@ -42,19 +42,20 @@ module Pilot
     # Config Related
     ################
 
-    def fetch_app_id
+    def fetch_apple_id
+      @apple_id ||= config[:apple_id]
       return @apple_id if @apple_id
       config[:app_identifier] = fetch_app_identifier
 
       if config[:app_identifier]
         @app ||= Spaceship::Tunes::Application.find(config[:app_identifier])
         UI.user_error!("Couldn't find app '#{config[:app_identifier]}' on the account of '#{config[:username]}' on App Store Connect") unless @app
-        app_id ||= @app.apple_id
+        apple_id ||= @app.apple_id
       end
 
-      app_id ||= UI.input("Could not automatically find the app ID, please enter it here (e.g. 956814360): ")
+      apple_id ||= UI.input("Could not automatically find the app ID, please enter it here (e.g. 956814360): ")
 
-      return app_id
+      return apple_id
     end
 
     def fetch_app_identifier

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: fastlane
 version: !ruby/object:Gem::Version
-  version: 2.123.0.beta.20190507200014
+  version: 2.123.0.beta.20190508200056
 platform: ruby
 authors:
 - Jimmy Dee
@@ -27,7 +27,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-05-07 00:00:00.000000000 Z
+date: 2019-05-08 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: slack-notifier
@@ -1706,24 +1706,24 @@ metadata:
 post_install_message: 
 rdoc_options: []
 require_paths:
-- produce/lib
-- match/lib
 - screengrab/lib
-- credentials_manager/lib
-- gym/lib
-- spaceship/lib
-- pilot/lib
-- fastlane/lib
-- pem/lib
 - deliver/lib
-- cert/lib
+- supply/lib
+- pilot/lib
+- precheck/lib
+- scan/lib
+- credentials_manager/lib
+- frameit/lib
+- match/lib
 - snapshot/lib
+- cert/lib
+- produce/lib
+- fastlane/lib
 - sigh/lib
+- pem/lib
+- gym/lib
+- spaceship/lib
 - fastlane_core/lib
-- precheck/lib
-- supply/lib
-- frameit/lib
-- scan/lib
 required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="