fastlane 2.120.0.beta.20190409200021 → 2.120.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 0f362836779ae94d1375000a6bd541c1590fc613
-  data.tar.gz: 06605ed056708f0bb519c65fe82247d20259cac4
+  metadata.gz: 0ef2c55dc80f08a06f973a22f3497f780c98f071
+  data.tar.gz: e55e8f9723433c7179e5c2ba711e249c7c6f7a13
 SHA512:
-  metadata.gz: ef32f05c5fd00b1f931f499e016b9dd755b455b8a73b6f6c51e796408051c6ca321da54dae7d8febc1ad9b63a9987cc866b4d91c5b64ee9a8b21084ff18942a8
-  data.tar.gz: cfc325565ed8aab5f69fd2ff0c720ad72b58363ed61928f47ac23dc993d8cc0a3b3e542ca36c6123090872111537c05aabc596d087a7726406a2b2404f387e5e
+  metadata.gz: 7579b03ba7dea736f98b6107e01628849d0748763f1191c741cc7c76aa002f367907598135823a71f62b07552fc1e385a04817546077791cb3b31eda5c4f4e30
+  data.tar.gz: be2d8ae35276ec9ac10ddeab361b0db8467e1f4e034eb19f52cd3b737e8379f71e7c62f83c65caf07e4a1c94898e1f38098b4f1e28220ed18055e24c18bc6efb

data/README.md

@@ -33,29 +33,17 @@ If the above doesn't help, please [submit an issue](https://github.com/fastlane/
 <!-- This table is regenerated and resorted on each release -->
 <table id='team'>
 <tr>
-<td id='jan-piotrowski'>
-<a href='https://github.com/janpio'>
-<img src='https://github.com/janpio.png?size=140'>
-</a>
-<h4 align='center'><a href='https://twitter.com/Sujan'>Jan Piotrowski</a></h4>
-</td>
-<td id='danielle-tomlinson'>
-<a href='https://github.com/DanToml'>
-<img src='https://github.com/DanToml.png?size=140'>
-</a>
-<h4 align='center'><a href='https://twitter.com/DanToml'>Danielle Tomlinson</a></h4>
-</td>
-<td id='jorge-revuelta-h'>
-<a href='https://github.com/minuscorp'>
-<img src='https://github.com/minuscorp.png?size=140'>
+<td id='manu-wallner'>
+<a href='https://github.com/milch'>
+<img src='https://github.com/milch.png?size=140'>
 </a>
-<h4 align='center'><a href='https://twitter.com/minuscorp'>Jorge Revuelta H</a></h4>
+<h4 align='center'><a href='https://twitter.com/acrooow'>Manu Wallner</a></h4>
 </td>
-<td id='helmut-januschka'>
-<a href='https://github.com/hjanuschka'>
-<img src='https://github.com/hjanuschka.png?size=140'>
+<td id='kohki-miki'>
+<a href='https://github.com/giginet'>
+<img src='https://github.com/giginet.png?size=140'>
 </a>
-<h4 align='center'><a href='https://twitter.com/hjanuschka'>Helmut Januschka</a></h4>
+<h4 align='center'><a href='https://twitter.com/giginet'>Kohki Miki</a></h4>
 </td>
 <td id='aaron-brager'>
 <a href='https://github.com/getaaron'>
@@ -63,37 +51,17 @@ If the above doesn't help, please [submit an issue](https://github.com/fastlane/
 </a>
 <h4 align='center'><a href='https://twitter.com/getaaron'>Aaron Brager</a></h4>
 </td>
-</tr>
-<tr>
-<td id='jérôme-lacoste'>
-<a href='https://github.com/lacostej'>
-<img src='https://github.com/lacostej.png?size=140'>
-</a>
-<h4 align='center'><a href='https://twitter.com/lacostej'>Jérôme Lacoste</a></h4>
-</td>
 <td id='luka-mirosevic'>
 <a href='https://github.com/lmirosevic'>
 <img src='https://github.com/lmirosevic.png?size=140'>
 </a>
 <h4 align='center'><a href='https://twitter.com/lmirosevic'>Luka Mirosevic</a></h4>
 </td>
-<td id='kohki-miki'>
-<a href='https://github.com/giginet'>
-<img src='https://github.com/giginet.png?size=140'>
-</a>
-<h4 align='center'><a href='https://twitter.com/giginet'>Kohki Miki</a></h4>
-</td>
-<td id='fumiya-nakamura'>
-<a href='https://github.com/nafu'>
-<img src='https://github.com/nafu.png?size=140'>
-</a>
-<h4 align='center'><a href='https://twitter.com/nafu003'>Fumiya Nakamura</a></h4>
-</td>
-<td id='josh-holtz'>
-<a href='https://github.com/joshdholtz'>
-<img src='https://github.com/joshdholtz.png?size=140'>
+<td id='jimmy-dee'>
+<a href='https://github.com/jdee'>
+<img src='https://github.com/jdee.png?size=140'>
 </a>
-<h4 align='center'><a href='https://twitter.com/joshdholtz'>Josh Holtz</a></h4>
+<h4 align='center'>Jimmy Dee</h4>
 </td>
 </tr>
 <tr>
@@ -103,17 +71,17 @@ If the above doesn't help, please [submit an issue](https://github.com/fastlane/
 </a>
 <h4 align='center'><a href='https://twitter.com/mellis1995'>Matthew Ellis</a></h4>
 </td>
-<td id='olivier-halligon'>
-<a href='https://github.com/AliSoftware'>
-<img src='https://github.com/AliSoftware.png?size=140'>
+<td id='fumiya-nakamura'>
+<a href='https://github.com/nafu'>
+<img src='https://github.com/nafu.png?size=140'>
 </a>
-<h4 align='center'><a href='https://twitter.com/aligatr'>Olivier Halligon</a></h4>
+<h4 align='center'><a href='https://twitter.com/nafu003'>Fumiya Nakamura</a></h4>
 </td>
-<td id='andrew-mcburney'>
-<a href='https://github.com/armcburney'>
-<img src='https://github.com/armcburney.png?size=140'>
+<td id='danielle-tomlinson'>
+<a href='https://github.com/DanToml'>
+<img src='https://github.com/DanToml.png?size=140'>
 </a>
-<h4 align='center'><a href='https://twitter.com/armcburney'>Andrew McBurney</a></h4>
+<h4 align='center'><a href='https://twitter.com/DanToml'>Danielle Tomlinson</a></h4>
 </td>
 <td id='iulian-onofrei'>
 <a href='https://github.com/revolter'>
@@ -121,31 +89,31 @@ If the above doesn't help, please [submit an issue](https://github.com/fastlane/
 </a>
 <h4 align='center'><a href='https://twitter.com/Revolt666'>Iulian Onofrei</a></h4>
 </td>
-<td id='maksym-grebenets'>
-<a href='https://github.com/mgrebenets'>
-<img src='https://github.com/mgrebenets.png?size=140'>
+<td id='josh-holtz'>
+<a href='https://github.com/joshdholtz'>
+<img src='https://github.com/joshdholtz.png?size=140'>
 </a>
-<h4 align='center'><a href='https://twitter.com/mgrebenets'>Maksym Grebenets</a></h4>
+<h4 align='center'><a href='https://twitter.com/joshdholtz'>Josh Holtz</a></h4>
 </td>
 </tr>
 <tr>
-<td id='stefan-natchev'>
-<a href='https://github.com/snatchev'>
-<img src='https://github.com/snatchev.png?size=140'>
-</a>
-<h4 align='center'><a href='https://twitter.com/snatchev'>Stefan Natchev</a></h4>
-</td>
 <td id='felix-krause'>
 <a href='https://github.com/KrauseFx'>
 <img src='https://github.com/KrauseFx.png?size=140'>
 </a>
 <h4 align='center'><a href='https://twitter.com/KrauseFx'>Felix Krause</a></h4>
 </td>
-<td id='jimmy-dee'>
-<a href='https://github.com/jdee'>
-<img src='https://github.com/jdee.png?size=140'>
+<td id='helmut-januschka'>
+<a href='https://github.com/hjanuschka'>
+<img src='https://github.com/hjanuschka.png?size=140'>
 </a>
-<h4 align='center'>Jimmy Dee</h4>
+<h4 align='center'><a href='https://twitter.com/hjanuschka'>Helmut Januschka</a></h4>
+</td>
+<td id='jan-piotrowski'>
+<a href='https://github.com/janpio'>
+<img src='https://github.com/janpio.png?size=140'>
+</a>
+<h4 align='center'><a href='https://twitter.com/Sujan'>Jan Piotrowski</a></h4>
 </td>
 <td id='joshua-liebowitz'>
 <a href='https://github.com/taquitos'>
@@ -153,11 +121,43 @@ If the above doesn't help, please [submit an issue](https://github.com/fastlane/
 </a>
 <h4 align='center'><a href='https://twitter.com/taquitos'>Joshua Liebowitz</a></h4>
 </td>
-<td id='manu-wallner'>
-<a href='https://github.com/milch'>
-<img src='https://github.com/milch.png?size=140'>
+<td id='olivier-halligon'>
+<a href='https://github.com/AliSoftware'>
+<img src='https://github.com/AliSoftware.png?size=140'>
 </a>
-<h4 align='center'><a href='https://twitter.com/acrooow'>Manu Wallner</a></h4>
+<h4 align='center'><a href='https://twitter.com/aligatr'>Olivier Halligon</a></h4>
+</td>
+</tr>
+<tr>
+<td id='maksym-grebenets'>
+<a href='https://github.com/mgrebenets'>
+<img src='https://github.com/mgrebenets.png?size=140'>
+</a>
+<h4 align='center'><a href='https://twitter.com/mgrebenets'>Maksym Grebenets</a></h4>
+</td>
+<td id='jorge-revuelta-h'>
+<a href='https://github.com/minuscorp'>
+<img src='https://github.com/minuscorp.png?size=140'>
+</a>
+<h4 align='center'><a href='https://twitter.com/minuscorp'>Jorge Revuelta H</a></h4>
+</td>
+<td id='stefan-natchev'>
+<a href='https://github.com/snatchev'>
+<img src='https://github.com/snatchev.png?size=140'>
+</a>
+<h4 align='center'><a href='https://twitter.com/snatchev'>Stefan Natchev</a></h4>
+</td>
+<td id='jérôme-lacoste'>
+<a href='https://github.com/lacostej'>
+<img src='https://github.com/lacostej.png?size=140'>
+</a>
+<h4 align='center'><a href='https://twitter.com/lacostej'>Jérôme Lacoste</a></h4>
+</td>
+<td id='andrew-mcburney'>
+<a href='https://github.com/armcburney'>
+<img src='https://github.com/armcburney.png?size=140'>
+</a>
+<h4 align='center'><a href='https://twitter.com/armcburney'>Andrew McBurney</a></h4>
 </td>
 </tr>
 </table>

data/fastlane/lib/fastlane/actions/app_store_build_number.rb

@@ -24,47 +24,50 @@ module Fastlane
         Spaceship::Tunes.select_team
         UI.message("Login successful")
 
-        platform = params[:platform]
-
         app = Spaceship::Tunes::Application.find(params[:app_identifier])
         if params[:live]
           UI.message("Fetching the latest build number for live-version")
           UI.user_error!("Could not find a live-version of #{params[:app_identifier]} on iTC") unless app.live_version
           build_nr = app.live_version.current_build_number
+
+          UI.message("Latest upload for live-version #{app.live_version.version} is build: #{build_nr}")
         else
           version_number = params[:version]
-          unless version_number
-            # Automatically fetch the latest version in testflight
-            begin
-              train_numbers = app.all_build_train_numbers(platform: platform)
-              testflight_version = self.order_versions(train_numbers).last
-            rescue
-              testflight_version = params[:version]
-            end
-
-            if testflight_version
-              version_number = testflight_version
-            else
-              version_number = UI.input("You have to specify a new version number, as there are multiple to choose from")
-            end
 
+          # Filter on app (and version is specified)
+          filter = { app: app.apple_id }
+          filter["version"] = version_number if version_number
+
+          # Get version number from latest pre-release if no version number given
+          client = Spaceship::ConnectAPI::Base.client
+          version = client.get_pre_release_versions(filter: filter, sort: "-version", limit: 1).first
+          unless version
+            UI.user_error!("Could not find a build number for version #{version_number}")
           end
 
+          # Need pre_release_version_id for filtering build numbers
+          pre_release_version_id = version["id"]
+          version_number = version["attributes"]["version"]
+
           UI.message("Fetching the latest build number for version #{version_number}")
 
-          begin
-            build_numbers = app.all_builds_for_train(train: version_number, platform: platform).map(&:build_version)
-            build_nr = self.order_versions(build_numbers).last
-            if build_nr.nil? && params[:initial_build_number]
-              UI.message("Could not find a build on iTC. Using supplied 'initial_build_number' option")
-              build_nr = params[:initial_build_number]
-            end
-          rescue
-            UI.user_error!("Could not find a build on iTC - and 'initial_build_number' option is not set") unless params[:initial_build_number]
+          # Get latest build for version number
+          build = client.get_builds(filter: { app: app.apple_id, "preReleaseVersion" => pre_release_version_id }, sort: "-uploadedDate", limit: 1).first
+          if build
+            build_nr = build["attributes"]["version"]
+            build_nr
+          else
+            UI.important("Could not find a build number for version #{version_number} on App Store Connect")
+          end
+
+          # Show error and set initial build number
+          unless build_nr
+            UI.user_error!("Could not find a build on App Store Connect - and 'initial_build_number' option is not set") unless params[:initial_build_number]
             build_nr = params[:initial_build_number]
           end
+
+          UI.message("Latest upload for version #{version_number} is build: #{build_nr}")
         end
-        UI.message("Latest upload for version #{version_number} is build: #{build_nr}")
 
         build_nr
       end

data/fastlane/lib/fastlane/version.rb

@@ -1,5 +1,5 @@
 module Fastlane
-  VERSION = '2.120.0.beta.20190409200021'.freeze
+  VERSION = '2.120.0'.freeze
   DESCRIPTION = "The easiest way to automate beta deployments and releases for your iOS and Android apps".freeze
   MINIMUM_XCODE_RELEASE = "7.0".freeze
   RUBOCOP_REQUIREMENT = '0.49.1'.freeze

data/fastlane/swift/Deliverfile.swift

@@ -18,4 +18,4 @@ class Deliverfile: DeliverfileProtocol {
 
 
 
-// Generated with fastlane 2.119.0
+// Generated with fastlane 2.120.0

data/fastlane/swift/Fastlane.swift

@@ -1681,10 +1681,12 @@ func gitAdd(path: String? = nil,
 }
 func gitCommit(path: String,
                message: String,
-               skipGitHooks: Bool? = nil) {
+               skipGitHooks: Bool? = nil,
+               allowNothingToCommit: Bool? = nil) {
   let command = RubyCommand(commandID: "", methodName: "git_commit", className: nil, args: [RubyCommand.Argument(name: "path", value: path),
                                                                                             RubyCommand.Argument(name: "message", value: message),
-                                                                                            RubyCommand.Argument(name: "skip_git_hooks", value: skipGitHooks)])
+                                                                                            RubyCommand.Argument(name: "skip_git_hooks", value: skipGitHooks),
+                                                                                            RubyCommand.Argument(name: "allow_nothing_to_commit", value: allowNothingToCommit)])
   _ = runner.executeCommand(command)
 }
 func gitPull(onlyTags: Bool = false) {
@@ -2591,14 +2593,16 @@ func pushToGitRemote(localBranch: String? = nil,
                      forceWithLease: Bool = false,
                      tags: Bool = true,
                      remote: String = "origin",
-                     noVerify: Bool = false) {
+                     noVerify: Bool = false,
+                     setUpstream: Bool = false) {
   let command = RubyCommand(commandID: "", methodName: "push_to_git_remote", className: nil, args: [RubyCommand.Argument(name: "local_branch", value: localBranch),
                                                                                                     RubyCommand.Argument(name: "remote_branch", value: remoteBranch),
                                                                                                     RubyCommand.Argument(name: "force", value: force),
                                                                                                     RubyCommand.Argument(name: "force_with_lease", value: forceWithLease),
                                                                                                     RubyCommand.Argument(name: "tags", value: tags),
                                                                                                     RubyCommand.Argument(name: "remote", value: remote),
-                                                                                                    RubyCommand.Argument(name: "no_verify", value: noVerify)])
+                                                                                                    RubyCommand.Argument(name: "no_verify", value: noVerify),
+                                                                                                    RubyCommand.Argument(name: "set_upstream", value: setUpstream)])
   _ = runner.executeCommand(command)
 }
 func puts(message: String? = nil) {
@@ -4301,4 +4305,4 @@ let screengrabfile: Screengrabfile = Screengrabfile()
 let snapshotfile: Snapshotfile = Snapshotfile()
 // Please don't remove the lines below
 // They are used to detect outdated files
-// FastlaneRunnerAPIVersion [0.9.44]
+// FastlaneRunnerAPIVersion [0.9.45]

data/fastlane/swift/Gymfile.swift

@@ -18,4 +18,4 @@ class Gymfile: GymfileProtocol {
 
 
 
-// Generated with fastlane 2.119.0
+// Generated with fastlane 2.120.0

data/fastlane/swift/Matchfile.swift

@@ -18,4 +18,4 @@ class Matchfile: MatchfileProtocol {
 
 
 
-// Generated with fastlane 2.119.0
+// Generated with fastlane 2.120.0

data/fastlane/swift/Precheckfile.swift

@@ -18,4 +18,4 @@ class Precheckfile: PrecheckfileProtocol {
 
 
 
-// Generated with fastlane 2.119.0
+// Generated with fastlane 2.120.0

data/fastlane/swift/Scanfile.swift

@@ -18,4 +18,4 @@ class Scanfile: ScanfileProtocol {
 
 
 
-// Generated with fastlane 2.119.0
+// Generated with fastlane 2.120.0

data/fastlane/swift/Screengrabfile.swift

@@ -18,4 +18,4 @@ class Screengrabfile: ScreengrabfileProtocol {
 
 
 
-// Generated with fastlane 2.119.0
+// Generated with fastlane 2.120.0

data/fastlane/swift/Snapshotfile.swift

@@ -18,4 +18,4 @@ class Snapshotfile: SnapshotfileProtocol {
 
 
 
-// Generated with fastlane 2.119.0
+// Generated with fastlane 2.120.0

data/fastlane_core/lib/fastlane_core/build_watcher.rb

@@ -7,22 +7,15 @@ module FastlaneCore
     class << self
       # @return The build we waited for. This method will always return a build
       def wait_for_build_processing_to_be_complete(app_id: nil, platform: nil, train_version: nil, build_version: nil, poll_interval: 10, strict_build_watch: false)
-        unless strict_build_watch
-          # First, find the train and build version we want to watch for
-          watched_build = watching_build(app_id: app_id, platform: platform)
-          UI.crash!("Could not find a build for app: #{app_id} on platform: #{platform}") if watched_build.nil?
-
-          unless watched_build.train_version == train_version && watched_build.build_version == build_version
-            UI.important("Started watching build #{watched_build.train_version} - #{watched_build.build_version} but expected #{train_version} - #{build_version}")
-          end
-          train_version = watched_build.train_version
-          build_version = watched_build.build_version
+        # Warn about strict_build_watch being removed in the future
+        if strict_build_watch
+          UI.deprecated(":strict_build_watch is no longer a used argument on FastlaneCore::BuildWatcher.")
         end
 
         loop do
-          matched_build = matching_build(watched_train_version: train_version, watched_build_version: build_version, app_id: app_id, platform: platform)
+          matched_build, build_delivery = matching_build(watched_train_version: train_version, watched_build_version: build_version, app_id: app_id, platform: platform)
 
-          report_status(build: matched_build)
+          report_status(build: matched_build, build_delivery: build_delivery)
 
           if matched_build && matched_build.processed?
             return matched_build
@@ -34,32 +27,30 @@ module FastlaneCore
 
       private
 
-      def watching_build(app_id: nil, platform: nil)
-        processing_builds = Spaceship::TestFlight::Build.all_processing_builds(app_id: app_id, platform: platform, retry_count: 2)
-
-        watched_build = processing_builds.sort_by(&:upload_date).last
-        watched_build || Spaceship::TestFlight::Build.latest(app_id: app_id, platform: platform)
-      end
-
       def matching_build(watched_train_version: nil, watched_build_version: nil, app_id: nil, platform: nil)
-        matched_builds = Spaceship::TestFlight::Build.builds_for_train(app_id: app_id, platform: platform, train_version: watched_train_version, retry_count: 2)
-        matched_builds.find { |build| build.build_version == watched_build_version }
+        # Get build deliveries (newly uploaded processing builds)
+        client = Spaceship::ConnectAPI::Base.client
+        build_deliveries = client.get_build_deliveries(filter: { app: app_id, cfBundleShortVersionString: watched_train_version, cfBundleVersion: watched_build_version }, limit: 1)
+        build_delivery = build_deliveries.first
+
+        # Get processed builds when no longer in build deliveries
+        unless build_delivery
+          matched_builds = Spaceship::TestFlight::Build.all(app_id: app_id, platform: platform)
+          matched_build = matched_builds.find { |build| build.train_version.to_s == watched_train_version.to_s && build.build_version.to_s == watched_build_version.to_s }
+        end
+
+        return matched_build, build_delivery
       end
 
-      def report_status(build: nil)
-        # Due to App Store Connect, builds disappear from the build list altogether
-        # after they finished processing. Before returning this build, we have to
-        # wait for the build to appear in the build list again
-        # As this method is very often used to wait for a build, and then do something
-        # with it, we have to be sure that the build actually is ready
-        if build.nil?
-          UI.message("Build doesn't show up in the build list anymore, waiting for it to appear again (check your email for processing issues if this continues)")
-        elsif build.active?
-          UI.success("Build #{build.train_version} - #{build.build_version} is already being tested")
-        elsif build.ready_to_submit? || build.export_compliance_missing? || build.review_rejected?
+      def report_status(build: nil, build_delivery: nil)
+        if build_delivery
+          UI.message("Waiting for App Store Connect to finish processing the new build (#{build_delivery['attributes']['cfBundleShortVersionString']} - #{build_delivery['attributes']['cfBundleVersion']})")
+        elsif build && !build.processed?
+          UI.message("Waiting for App Store Connect to finish processing the new build (#{build.train_version} - #{build.build_version})")
+        elsif build && build.processed?
           UI.success("Successfully finished processing the build #{build.train_version} - #{build.build_version}")
         else
-          UI.message("Waiting for App Store Connect to finish processing the new build (#{build.train_version} - #{build.build_version})")
+          UI.message("Build doesn't show up in the build list anymore, waiting for it to appear again (check your email for processing issues if this continues)")
         end
       end
     end

data/pilot/lib/pilot/build_manager.rb

@@ -58,10 +58,10 @@ module Pilot
       platform = fetch_app_platform
       app_version = FastlaneCore::IpaFileAnalyser.fetch_app_version(config[:ipa])
       app_build = FastlaneCore::IpaFileAnalyser.fetch_app_build(config[:ipa])
-      latest_build = FastlaneCore::BuildWatcher.wait_for_build_processing_to_be_complete(app_id: app.apple_id, platform: platform, train_version: app_version, build_version: app_build, poll_interval: config[:wait_processing_interval], strict_build_watch: config[:wait_for_uploaded_build])
+      latest_build = FastlaneCore::BuildWatcher.wait_for_build_processing_to_be_complete(app_id: app.apple_id, platform: platform, train_version: app_version, build_version: app_build, poll_interval: config[:wait_processing_interval])
 
       unless latest_build.train_version == app_version && latest_build.build_version == app_build
-        UI.important("Uploaded app #{app_version} - #{app_build}, but received build #{latest_build.train_version} - #{latest_build.build_version}. If you want to wait for uploaded build to be finished processing, use the `wait_for_uploaded_build` option")
+        UI.important("Uploaded app #{app_version} - #{app_build}, but received build #{latest_build.train_version} - #{latest_build.build_version}.")
       end
 
       return latest_build
@@ -121,6 +121,9 @@ module Pilot
     end
 
     def update_beta_app_meta(options, build)
+      # App Store Connect API build id
+      build_id = build.find_app_store_connect_build["id"]
+
       # Setting account required wth AppStore Connect API
       update_review_detail(build.app_id, { demo_account_required: options[:demo_account_required] })
 
@@ -143,17 +146,17 @@ module Pilot
       end
 
       if should_update_localized_build_information?(options)
-        update_localized_build_review(build, options[:localized_build_info])
+        update_localized_build_review(build_id, options[:localized_build_info])
       elsif should_update_build_information?(options)
         begin
-          update_localized_build_review(build, {}, default_info: { whats_new: options[:changelog] })
+          update_localized_build_review(build_id, {}, default_info: { whats_new: options[:changelog] })
           UI.success("Successfully set the changelog for build")
         rescue => ex
           UI.user_error!("Could not set changelog: #{ex}")
         end
       end
 
-      update_build_beta_details(build, {
+      update_build_beta_details(build_id, {
         auto_notify_enabled: options[:notify_external_testers]
       })
     end
@@ -251,23 +254,27 @@ module Pilot
       end
 
       if options[:groups]
-        groups = Spaceship::TestFlight::Group.filter_groups(app_id: uploaded_build.app_id) do |group|
-          options[:groups].include?(group.name)
-        end
-        groups.each do |group|
-          uploaded_build.add_group!(group)
+        client = Spaceship::ConnectAPI::Base.client
+        beta_group_ids = client.get_beta_groups(filter: { app: uploaded_build.app_id }).select do |group|
+          options[:groups].include?(group["attributes"]["name"])
+        end.map do |group|
+          group["id"]
         end
-      end
 
-      if options[:distribute_external]
-        external_group = Spaceship::TestFlight::Group.default_external_group(app_id: uploaded_build.app_id)
-        uploaded_build.add_group!(external_group) unless external_group.nil?
+        unless beta_group_ids.empty?
+          build = uploaded_build.find_app_store_connect_build
+          build_id = build["id"]
 
-        if external_group.nil? && options[:groups].nil?
-          UI.user_error!("You must specify at least one group using the `:groups` option to distribute externally")
+          client.add_beta_groups_to_build(build_id: build_id, beta_group_ids: beta_group_ids)
         end
       end
 
+      if options[:distribute_external] && options[:groups].nil?
+        # Legacy Spaceship::TestFlight API used to have a `default_external_group` that would automatically
+        # get selected but this no longer exists with Spaceship::ConnectAPI
+        UI.user_error!("You must specify at least one group using the `:groups` option to distribute externally")
+      end
+
       true
     end
 
@@ -353,10 +360,7 @@ module Pilot
       end
     end
 
-    def update_localized_build_review(build, info_by_lang, default_info: nil)
-      resp = Spaceship::ConnectAPI::Base.client.get_builds(filter: { expired: false, processingState: "PROCESSING,VALID", version: build.build_version })
-      build_id = resp.first["id"]
-
+    def update_localized_build_review(build_id, info_by_lang, default_info: nil)
       info_by_lang = info_by_lang.collect { |k, v| [k.to_sym, v] }.to_h
 
       if default_info
@@ -401,12 +405,8 @@ module Pilot
       end
     end
 
-    def update_build_beta_details(build, info)
+    def update_build_beta_details(build_id, info)
       client = Spaceship::ConnectAPI::Base.client
-
-      build = build.find_app_store_connect_build
-      build_id = build["id"]
-
       resp = client.get_build_beta_details(filter: { build: build_id })
       build_beta_details_id = resp.first["id"]
 

data/pilot/lib/pilot/options.rb

@@ -240,6 +240,7 @@ module Pilot
                                      end),
         FastlaneCore::ConfigItem.new(key: :wait_for_uploaded_build,
                                      env_name: "PILOT_WAIT_FOR_UPLOADED_BUILD",
+                                     deprecated: "No longer needed with the transition over to the App Store Connect API",
                                      description: "Use version info from uploaded ipa file to determine what build to use for distribution. If set to false, latest processing or any latest build will be used",
                                      is_string: false,
                                      default_value: false),

data/spaceship/lib/spaceship/client.rb

@@ -513,8 +513,9 @@ module Spaceship
     end
 
     # Get the `itctx` from the new (22nd May 2017) API endpoint "olympus"
+    # Update (29th March 2019) olympus migrates to new appstoreconnect API
     def fetch_olympus_session
-      response = request(:get, "https://olympus.itunes.apple.com/v1/session")
+      response = request(:get, "https://appstoreconnect.apple.com/olympus/v1/session")
       body = response.body
       if body
         body = JSON.parse(body) if body.kind_of?(String)
@@ -543,7 +544,7 @@ module Spaceship
       # Fixes issue https://github.com/fastlane/fastlane/issues/13281
       # Even though we are using https://appstoreconnect.apple.com, the service key needs to still use a
       # hostname through itunesconnect.apple.com
-      response = request(:get, "https://olympus.itunes.apple.com/v1/app/config?hostname=itunesconnect.apple.com")
+      response = request(:get, "https://appstoreconnect.apple.com/olympus/v1/app/config?hostname=itunesconnect.apple.com")
       @service_key = response.body["authServiceKey"].to_s
 
       raise "Service key is empty" if @service_key.length == 0
@@ -599,7 +600,7 @@ module Spaceship
     def fetch_program_license_agreement_messages
       all_messages = []
 
-      messages_request = request(:get, "https://olympus.itunes.apple.com/v1/contractMessages")
+      messages_request = request(:get, "https://appstoreconnect.apple.com/olympus/v1/contractMessages")
       body = messages_request.body
       if body
         body = JSON.parse(body) if body.kind_of?(String)

data/spaceship/lib/spaceship/connect_api/client.rb

@@ -18,13 +18,14 @@ module Spaceship
         'https://appstoreconnect.apple.com/iris/v1/'
       end
 
-      def build_params(filter: nil, includes: nil, limit: nil, sort: nil)
+      def build_params(filter: nil, includes: nil, limit: nil, sort: nil, cursor: nil)
         params = {}
 
         params[:filter] = filter if filter && !filter.empty?
         params[:include] = includes if includes
         params[:limit] = limit if limit
         params[:sort] = sort if sort
+        params[:cursor] = cursor if cursor
 
         return params
       end
@@ -218,18 +219,30 @@ module Spaceship
         handle_response(response)
       end
 
-      def get_builds(filter: {}, includes: "buildBetaDetail,betaBuildMetrics", limit: 10, sort: "uploadedDate")
+      def get_build_deliveries(filter: {}, includes: nil, limit: 10, sort: nil)
         # GET
-        # https://appstoreconnect.apple.com/iris/v1/builds
+        # https://appstoreconnect.apple.com/iris/v1/buildDeliveries
         params = build_params(filter: filter, includes: includes, limit: limit, sort: sort)
 
-        response = request(:get, "builds") do |req|
+        response = request(:get, "buildDeliveries") do |req|
           req.options.params_encoder = Faraday::NestedParamsEncoder
           req.params = params
         end
         handle_response(response)
       end
 
+      def get_builds(filter: {}, includes: "buildBetaDetail,betaBuildMetrics", limit: 10, sort: "uploadedDate", cursor: nil, only_data: true)
+        # GET
+        # https://appstoreconnect.apple.com/iris/v1/builds
+        params = build_params(filter: filter, includes: includes, limit: limit, sort: sort, cursor: cursor)
+
+        response = request(:get, "builds") do |req|
+          req.options.params_encoder = Faraday::NestedParamsEncoder
+          req.params = params
+        end
+        handle_response(response, only_data: only_data)
+      end
+
       def patch_builds(build_id: nil, attributes: {})
         # PATCH
         # https://appstoreconnect.apple.com/iris/v1/builds/<build_id>
@@ -277,9 +290,54 @@ module Spaceship
         handle_response(response)
       end
 
+      def get_pre_release_versions(filter: {}, includes: nil, limit: 40, sort: nil)
+        # GET
+        # https://appstoreconnect.apple.com/iris/v1/preReleaseVersions
+        params = build_params(filter: filter, includes: includes, limit: limit, sort: sort)
+
+        response = request(:get, "preReleaseVersions") do |req|
+          req.options.params_encoder = Faraday::NestedParamsEncoder
+          req.params = params
+        end
+        handle_response(response)
+      end
+
+      def get_beta_groups(filter: {}, includes: nil, limit: 40, sort: nil)
+        # GET
+        # https://appstoreconnect.apple.com/iris/v1/betaGroups
+        params = build_params(filter: filter, includes: includes, limit: limit, sort: sort)
+
+        response = request(:get, "betaGroups") do |req|
+          req.options.params_encoder = Faraday::NestedParamsEncoder
+          req.params = params
+        end
+        handle_response(response)
+      end
+
+      def add_beta_groups_to_build(build_id: nil, beta_group_ids: [])
+        # POST
+        # https://appstoreconnect.apple.com/iris/v1/builds/<build_id>/relationships/betaGroups
+
+        body = {
+          data: beta_group_ids.map do |id|
+            {
+              type: "betaGroups",
+              id: id
+            }
+          end
+        }
+
+        response = request(:post) do |req|
+          req.url("builds/#{build_id}/relationships/betaGroups")
+          req.body = body.to_json
+          req.headers['Content-Type'] = 'application/json'
+        end
+        handle_response(response)
+      end
+
       protected
 
-      def handle_response(response)
+      def handle_response(response, only_data: true)
         if (200...300).cover?(response.status) && (response.body.nil? || response.body.empty?)
           return
         end
@@ -296,7 +354,7 @@ module Spaceship
 
         raise UnexpectedResponse, "Temporary App Store Connect error: #{response.body}" if response.body['statusCode'] == 'ERROR'
 
-        return response.body['data'] if response.body['data']
+        return response.body['data'] if response.body['data'] && only_data
 
         return response.body
       end

data/spaceship/lib/spaceship/test_flight/build.rb

@@ -231,7 +231,7 @@ module Spaceship
 
       # Bridges the TestFlight::Build to the App Store Connect API build
       def find_app_store_connect_build
-        resp = Spaceship::ConnectAPI::Base.client.get_builds(filter: { expired: false, processingState: "PROCESSING,VALID", version: self.build_version, app: app_id })
+        resp = Spaceship::ConnectAPI::Base.client.get_builds(filter: { expired: false, processingState: "PROCESSING,VALID", version: self.build_version, "preReleaseVersion.version" => self.train_version, app: app_id })
         resp.first
       end
     end

data/spaceship/lib/spaceship/test_flight/build_trains.rb

@@ -13,12 +13,65 @@ module Spaceship::TestFlight
     # See `Spaceship::TestFlight::Build#reload`
 
     def self.all(app_id: nil, platform: nil, retry_count: 3)
-      data = client.get_build_trains(app_id: app_id, platform: platform)
-      trains = {}
+      client = Spaceship::ConnectAPI::Base.client
+
+      builds = []
+      included = []
+      cursor = nil
+
+      loop do
+        builds_resp = client.get_builds(filter: { app: app_id, processingState: "VALID,PROCESSING,FAILED,INVALID" }, limit: 100, sort: "uploadedDate", includes: "preReleaseVersion,app", cursor: cursor, only_data: false)
+        builds += builds_resp["data"]
+        included += (builds_resp["included"] || [])
+
+        next_page = builds_resp["links"]["next"]
+        break if next_page.nil?
+
+        uri = URI.parse(next_page)
+        params = CGI.parse(uri.query)
+        cursor = params["cursor"].first
 
-      data.each do |train_version|
-        builds_data = client.get_builds_for_train(app_id: app_id, platform: platform, train_version: train_version, retry_count: retry_count)
-        trains[train_version] = builds_data.map { |attrs| Spaceship::TestFlight::Build.new(attrs) }
+        break if cursor.nil?
+      end
+
+      # Load with all of the data
+      builds.map do |build|
+        r = build["relationships"]["app"]["data"]
+        build["app"] = included.find { |h| h["type"] == r["type"] && h["id"] == r["id"] }
+
+        r = build["relationships"]["preReleaseVersion"]["data"]
+        build["preReleaseVersion"] = included.find { |h| h["type"] == r["type"] && h["id"] == r["id"] }
+
+        build
+      end
+
+      # Map to testflight build response????
+      train_builds = builds.map do |build|
+        h = {}
+
+        h['buildVersion'] = build["attributes"]["version"]
+        h['uploadDate'] = build["attributes"]["uploadedDate"]
+
+        processing_state = build["attributes"]["processingState"]
+        if processing_state == "VALID"
+          h['externalState'] = Spaceship::TestFlight::Build::BUILD_STATES[:active]
+        elsif processing_state == "PROCESSING"
+          h['externalState'] = Spaceship::TestFlight::Build::BUILD_STATES[:processing]
+        end
+
+        h['appAdamId'] = build["app"]["id"]
+        h['bundleId'] = build["app"]["attributes"]["bundleId"]
+
+        h['trainVersion'] = build["preReleaseVersion"]["attributes"]["version"]
+
+        h
+      end
+
+      trains = {}
+      train_builds.each do |build|
+        train_version = build["trainVersion"]
+        trains[train_version] ||= []
+        trains[train_version] << Spaceship::TestFlight::Build.new(build)
       end
 
       self.new(trains)

metadata

@@ -1,33 +1,33 @@
 --- !ruby/object:Gem::Specification
 name: fastlane
 version: !ruby/object:Gem::Version
-  version: 2.120.0.beta.20190409200021
+  version: 2.120.0
 platform: ruby
 authors:
-- Stefan Natchev
-- Josh Holtz
-- Maksym Grebenets
+- Kohki Miki
+- Iulian Onofrei
 - Manu Wallner
-- Fumiya Nakamura
-- Luka Mirosevic
-- Jan Piotrowski
 - Danielle Tomlinson
-- Helmut Januschka
-- Kohki Miki
 - Aaron Brager
-- Jimmy Dee
-- Andrew McBurney
-- Jorge Revuelta H
-- Joshua Liebowitz
-- Olivier Halligon
 - Jérôme Lacoste
+- Maksym Grebenets
+- Helmut Januschka
 - Felix Krause
-- Iulian Onofrei
+- Fumiya Nakamura
+- Stefan Natchev
+- Jorge Revuelta H
 - Matthew Ellis
+- Jan Piotrowski
+- Andrew McBurney
+- Josh Holtz
+- Luka Mirosevic
+- Joshua Liebowitz
+- Jimmy Dee
+- Olivier Halligon
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-04-09 00:00:00.000000000 Z
+date: 2019-04-10 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: slack-notifier
@@ -966,6 +966,8 @@ files:
 - fastlane/lib/fastlane.rb
 - fastlane/lib/fastlane/action.rb
 - fastlane/lib/fastlane/action_collector.rb
+- fastlane/lib/fastlane/actions/.slack.rb.swp
+- fastlane/lib/fastlane/actions/.update_project_provisioning.rb.swp
 - fastlane/lib/fastlane/actions/README.md
 - fastlane/lib/fastlane/actions/actions_helper.rb
 - fastlane/lib/fastlane/actions/adb.rb
@@ -1287,6 +1289,7 @@ files:
 - fastlane/swift/Fastlane.swift
 - fastlane/swift/FastlaneSwiftRunner/FastlaneSwiftRunner.xcodeproj/project.pbxproj
 - fastlane/swift/FastlaneSwiftRunner/FastlaneSwiftRunner.xcodeproj/project.xcworkspace/contents.xcworkspacedata
+- fastlane/swift/FastlaneSwiftRunner/FastlaneSwiftRunner.xcodeproj/project.xcworkspace/xcuserdata/josh.xcuserdatad/UserInterfaceState.xcuserstate
 - fastlane/swift/FastlaneSwiftRunner/FastlaneSwiftRunner.xcodeproj/xcshareddata/xcschemes/FastlaneRunner.xcscheme
 - fastlane/swift/FastlaneSwiftRunner/README.txt
 - fastlane/swift/Gymfile.swift
@@ -1569,6 +1572,7 @@ files:
 - spaceship/lib/spaceship/client.rb
 - spaceship/lib/spaceship/commands_generator.rb
 - spaceship/lib/spaceship/connect_api.rb
+- spaceship/lib/spaceship/connect_api/.DS_Store
 - spaceship/lib/spaceship/connect_api/base.rb
 - spaceship/lib/spaceship/connect_api/client.rb
 - spaceship/lib/spaceship/du/du_client.rb
@@ -1601,6 +1605,7 @@ files:
 - spaceship/lib/spaceship/portal/provisioning_profile.rb
 - spaceship/lib/spaceship/portal/provisioning_profile_template.rb
 - spaceship/lib/spaceship/portal/spaceship.rb
+- spaceship/lib/spaceship/portal/ui/.select_team.rb.swp
 - spaceship/lib/spaceship/portal/ui/select_team.rb
 - spaceship/lib/spaceship/portal/website_push.rb
 - spaceship/lib/spaceship/provider.rb
@@ -1688,24 +1693,24 @@ metadata:
 post_install_message: 
 rdoc_options: []
 require_paths:
+- credentials_manager/lib
+- pem/lib
+- snapshot/lib
 - frameit/lib
-- spaceship/lib
-- cert/lib
-- sigh/lib
-- precheck/lib
-- gym/lib
+- match/lib
 - fastlane_core/lib
+- deliver/lib
+- scan/lib
 - supply/lib
-- produce/lib
-- match/lib
+- cert/lib
+- fastlane/lib
+- spaceship/lib
 - pilot/lib
-- snapshot/lib
+- gym/lib
+- precheck/lib
 - screengrab/lib
-- fastlane/lib
-- deliver/lib
-- pem/lib
-- scan/lib
-- credentials_manager/lib
+- sigh/lib
+- produce/lib
 required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
@@ -1713,12 +1718,12 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: 2.0.0
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ">"
+  - - ">="
     - !ruby/object:Gem::Version
-      version: 1.3.1
+      version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.6.8
+rubygems_version: 2.5.2.3
 signing_key: 
 specification_version: 4
 summary: The easiest way to automate beta deployments and releases for your iOS and