fastlane 2.119.0.beta.20190322200024 → 2.119.0.beta.20190323200019

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 32e40d34dcba02ba54da7e540386b796f23c43f4
-  data.tar.gz: d71ed86556bb104dedc41d7440e6c6844438914c
+  metadata.gz: 00f9fa9bd7eb8220d067769a4379a73604cd9034
+  data.tar.gz: b94cd6409e2a6c2f5f05fed2401b5b07e4fd5fb1
 SHA512:
-  metadata.gz: 286507a7ae15a1e4d80909ada8cac0d942e23ebe438eeb8205e04e48424a6864c3dcbba547d7f941305dd22fd73e675d8f49f74069b471b146df5f47c31802dd
-  data.tar.gz: a75754be648467ed2186ba62ae8637d198465e2019c4111154a2712cea0cc20a53dd010739cbc893acd90a69a7e3ab08a587e6cca74a35a835feb56ca3b62496
+  metadata.gz: 8a4f4f70c1c40a6f597c12fb0c64df16dc0d44c7cd5baebb530796d843b2c73e72e34668ce106b97af20e59f819e32febedd9dca8241a1674d5079657528e33c
+  data.tar.gz: d1af8896830579581e945a7c174079f9f4b9eb8863e5ac27cbaac359c8ef0cdbd58479f25e0f88686beb755781709c10a688ec906840769b9534cb2531626ae6

data/deliver/lib/deliver/app_screenshot.rb

@@ -6,14 +6,15 @@ module Deliver
   # AppScreenshot represents one screenshots for one specific locale and
   # device type.
   class AppScreenshot
+    #
     module ScreenSize
       # iPhone 4
       IOS_35 = "iOS-3.5-in"
       # iPhone 5
       IOS_40 = "iOS-4-in"
-      # iPhone 6
+      # iPhone 6, 7, & 8
       IOS_47 = "iOS-4.7-in"
-      # iPhone 6 Plus
+      # iPhone 6 Plus, 7 Plus, & 8 Plus
       IOS_55 = "iOS-5.5-in"
       # iPhone XS
       IOS_58 = "iOS-5.8-in"
@@ -21,6 +22,7 @@ module Deliver
       IOS_61 = "iOS-6.1-in"
       # iPhone XS Max
       IOS_65 = "iOS-6.5-in"
+
       # iPad
       IOS_IPAD = "iOS-iPad"
       # iPad 10.5
@@ -29,11 +31,12 @@ module Deliver
       IOS_IPAD_11 = "iOS-iPad-11"
       # iPad Pro
       IOS_IPAD_PRO = "iOS-iPad-Pro"
+
       # iPhone 5 iMessage
       IOS_40_MESSAGES = "iOS-4-in-messages"
-      # iPhone 6 iMessage
+      # iPhone 6, 7, & 8 iMessage
       IOS_47_MESSAGES = "iOS-4.7-in-messages"
-      # iPhone 6 Plus iMessage
+      # iPhone 6 Plus, 7 Plus, & 8 Plus iMessage
       IOS_55_MESSAGES = "iOS-5.5-in-messages"
       # iPhone XS iMessage
       IOS_58_MESSAGES = "iOS-5.8-in-messages"
@@ -41,6 +44,7 @@ module Deliver
       IOS_61_MESSAGES = "iOS-6.1-in-messages"
       # iPhone XS Max iMessage
       IOS_65_MESSAGES = "iOS-6.5-in-messages"
+
       # iPad iMessage
       IOS_IPAD_MESSAGES = "iOS-iPad-messages"
       # iPad 10.5 iMessage
@@ -49,14 +53,17 @@ module Deliver
       IOS_IPAD_11_MESSAGES = "iOS-11-messages"
       # iPad Pro iMessage
       IOS_IPAD_PRO_MESSAGES = "iOS-iPad-Pro-messages"
+
       # Apple Watch
       IOS_APPLE_WATCH = "iOS-Apple-Watch"
       # Apple Watch Series 4
       IOS_APPLE_WATCH_SERIES4 = "iOS-Apple-Watch-Series4"
-      # Mac
-      MAC = "Mac"
+
       # Apple TV
       APPLE_TV = "Apple-TV"
+
+      # Mac
+      MAC = "Mac"
     end
 
     # @return [Deliver::ScreenSize] the screen size (device type)
@@ -68,7 +75,7 @@ module Deliver
     attr_accessor :language
 
     # @param path (String) path to the screenshot file
-    # @param path (String) Language of this screenshot (e.g. English)
+    # @param language (String) Language of this screenshot (e.g. English)
     # @param screen_size (Deliver::AppScreenshot::ScreenSize) the screen size, which
     #  will automatically be calculated when you don't set it.
     def initialize(path, language, screen_size = nil)
@@ -88,8 +95,8 @@ module Deliver
       matching = {
         ScreenSize::IOS_35 => "iphone35",
         ScreenSize::IOS_40 => "iphone4",
-        ScreenSize::IOS_47 => "iphone6",
-        ScreenSize::IOS_55 => "iphone6Plus",
+        ScreenSize::IOS_47 => "iphone6", # also 7 and 8
+        ScreenSize::IOS_55 => "iphone6Plus", # also 7 Plus & 8 Plus
         ScreenSize::IOS_58 => "iphone58",
         ScreenSize::IOS_65 => "iphone65",
         ScreenSize::IOS_IPAD => "ipad",
@@ -97,8 +104,8 @@ module Deliver
         ScreenSize::IOS_IPAD_11 => "ipadPro11",
         ScreenSize::IOS_IPAD_PRO => "ipadPro",
         ScreenSize::IOS_40_MESSAGES => "iphone4",
-        ScreenSize::IOS_47_MESSAGES => "iphone6",
-        ScreenSize::IOS_55_MESSAGES => "iphone6Plus",
+        ScreenSize::IOS_47_MESSAGES => "iphone6", # also 7 & 8
+        ScreenSize::IOS_55_MESSAGES => "iphone6Plus", # also 7 Plus & 8 Plus
         ScreenSize::IOS_58_MESSAGES => "iphone58",
         ScreenSize::IOS_65_MESSAGES => "iphone65",
         ScreenSize::IOS_IPAD_MESSAGES => "ipad",
@@ -120,8 +127,8 @@ module Deliver
       matching = {
         ScreenSize::IOS_35 => "iPhone 4",
         ScreenSize::IOS_40 => "iPhone 5",
-        ScreenSize::IOS_47 => "iPhone 6",
-        ScreenSize::IOS_55 => "iPhone 6 Plus",
+        ScreenSize::IOS_47 => "iPhone 6", # and 7
+        ScreenSize::IOS_55 => "iPhone 6 Plus", # and 7 Plus
         ScreenSize::IOS_58 => "iPhone XS",
         ScreenSize::IOS_61 => "iPhone XR",
         ScreenSize::IOS_65 => "iPhone XS Max",
@@ -130,8 +137,8 @@ module Deliver
         ScreenSize::IOS_IPAD_11 => "iPad 11",
         ScreenSize::IOS_IPAD_PRO => "iPad Pro",
         ScreenSize::IOS_40_MESSAGES => "iPhone 5 (iMessage)",
-        ScreenSize::IOS_47_MESSAGES => "iPhone 6 (iMessage)",
-        ScreenSize::IOS_55_MESSAGES => "iPhone 6 Plus (iMessage)",
+        ScreenSize::IOS_47_MESSAGES => "iPhone 6 (iMessage)", # also 7 & 8
+        ScreenSize::IOS_55_MESSAGES => "iPhone 6 Plus (iMessage)", # also 7 Plus & 8 Plus
         ScreenSize::IOS_58_MESSAGES => "iPhone XS (iMessage)",
         ScreenSize::IOS_61_MESSAGES => "iPhone XR (iMessage)",
         ScreenSize::IOS_65_MESSAGES => "iPhone XS Max (iMessage)",

data/deliver/lib/deliver/options.rb

@@ -243,7 +243,7 @@ module Deliver
         # rubocop:disable Metrics/LineLength
         FastlaneCore::ConfigItem.new(key: :itc_provider,
                                      env_name: "DELIVER_ITC_PROVIDER",
-                                     description: "The provider short name to be used with the iTMSTransporter to identify your team. To get provider short name run `pathToXcode.app/Contents/Applications/Application\\ Loader.app/Contents/itms/bin/iTMSTransporter -m provider -u 'USERNAME' -p 'PASSWORD' -account_type itunes_connect -v off`. The short names of providers should be listed in the second column",
+                                     description: "The provider short name to be used with the iTMSTransporter to identify your team. This value will override the automatically detected provider short name. To get provider short name run `pathToXcode.app/Contents/Applications/Application\\ Loader.app/Contents/itms/bin/iTMSTransporter -m provider -u 'USERNAME' -p 'PASSWORD' -account_type itunes_connect -v off`. The short names of providers should be listed in the second column",
                                      optional: true),
         # rubocop:enable Metrics/LineLength
 

data/deliver/lib/deliver/runner.rb

@@ -156,7 +156,7 @@ module Deliver
         )
       end
 
-      transporter = FastlaneCore::ItunesTransporter.new(options[:username], nil, false, options[:itc_provider])
+      transporter = transporter_for_selected_team
       result = transporter.upload(options[:app].apple_id, package_path)
       UI.user_error!("Could not upload binary to App Store Connect. Check out the error above", show_github_issues: true) unless result
     end
@@ -174,6 +174,25 @@ module Deliver
 
     private
 
+    # If itc_provider was explicitly specified, use it.
+    # If there are multiple teams, infer the provider from the selected team name.
+    # If there are fewer than two teams, don't infer the provider.
+    def transporter_for_selected_team
+      generic_transporter = FastlaneCore::ItunesTransporter.new(options[:username], nil, false, options[:itc_provider])
+      return generic_transporter unless options[:itc_provider].nil? && Spaceship::Tunes.client.teams.count > 1
+
+      begin
+        team = Spaceship::Tunes.client.teams.find { |t| t['contentProvider']['contentProviderId'].to_s == Spaceship::Tunes.client.team_id }
+        name = team['contentProvider']['name']
+        provider_id = generic_transporter.provider_ids[name]
+        UI.verbose("Inferred provider id #{provider_id} for team #{name}.")
+        return FastlaneCore::ItunesTransporter.new(options[:username], nil, false, provider_id)
+      rescue => ex
+        UI.verbose("Couldn't infer a provider short name for team with id #{Spaceship::Tunes.client.team_id} automatically: #{ex}. Proceeding without provider short name.")
+        return generic_transporter
+      end
+    end
+
     def validate_html(screenshots)
       return if options[:force]
       return if options[:skip_metadata] && options[:skip_screenshots]

data/deliver/lib/deliver/upload_screenshots.rb

@@ -104,9 +104,9 @@ module Deliver
         files = Dir.glob(File.join(lng_folder, "*.#{extensions}"), File::FNM_CASEFOLD).sort
         next if files.count == 0
 
-        prefer_framed = Dir.glob(File.join(lng_folder, "*_framed.#{extensions}"), File::FNM_CASEFOLD).count > 0
+        framed_screenshots_found = Dir.glob(File.join(lng_folder, "*_framed.#{extensions}"), File::FNM_CASEFOLD).count > 0
 
-        UI.important("Framed screenshots are detected! 🖼 Non-framed screenshot files may be skipped. 🏃") if prefer_framed
+        UI.important("Framed screenshots are detected! 🖼 Non-framed screenshot files may be skipped. 🏃") if framed_screenshots_found
 
         language_dir_name = File.basename(lng_folder)
 
@@ -120,7 +120,7 @@ module Deliver
           is_framed = file_path.downcase.include?("_framed.")
           is_watch = file_path.downcase.include?("watch")
 
-          if prefer_framed && !is_framed && !is_watch
+          if framed_screenshots_found && !is_framed && !is_watch
             UI.important("🏃 Skipping screenshot file: #{file_path}")
             next
           end

data/fastlane/lib/fastlane/actions/docs/upload_to_app_store.md.erb

@@ -743,3 +743,6 @@ App Store Connect has a limit of 150 binary uploads per day.
 
 ## Editing the `Deliverfile`
 Change syntax highlighting to *Ruby*.
+
+## Provider Short Name
+If you are on multiple App Store Connect teams, _deliver_ needs a provider short name to know where to upload your binary. _deliver_ will try to use the long name of the selected team to detect the provider short name. To override the detected value with an explicit one, use the `itc_provider` option.

data/fastlane/lib/fastlane/actions/docs/upload_to_testflight.md

@@ -222,3 +222,6 @@ If your password contains special characters, _pilot_ may throw a confusing erro
 ## How is my password stored?
 
 _pilot_ uses the [CredentialsManager](https://github.com/fastlane/fastlane/tree/master/credentials_manager) from _fastlane_.
+
+## Provider Short Name
+If you are on multiple App Store Connect teams, iTunes Transporter may need a provider short name to know where to upload your binary. _pilot_ will try to use the long name of the selected team to detect the provider short name. To override the detected value with an explicit one, use the `itc_provider` option.

data/fastlane/lib/fastlane/actions/update_project_provisioning.rb

@@ -79,7 +79,7 @@ module Fastlane
         project.save
 
         # complete
-        UI.success("Successfully updated project settings in '#{params[:xcodeproj]}'")
+        UI.success("Successfully updated project settings in '#{folder}'")
       end
 
       def self.description

data/fastlane/lib/fastlane/version.rb

@@ -1,5 +1,5 @@
 module Fastlane
-  VERSION = '2.119.0.beta.20190322200024'.freeze
+  VERSION = '2.119.0.beta.20190323200019'.freeze
   DESCRIPTION = "The easiest way to automate beta deployments and releases for your iOS and Android apps".freeze
   MINIMUM_XCODE_RELEASE = "7.0".freeze
   RUBOCOP_REQUIREMENT = '0.49.1'.freeze

data/fastlane_core/lib/fastlane_core/itunes_transporter.rb

@@ -31,7 +31,10 @@ module FastlaneCore
     private_constant :ERROR_REGEX, :WARNING_REGEX, :OUTPUT_REGEX, :RETURN_VALUE_REGEX, :SKIP_ERRORS
 
     def execute(command, hide_output)
-      return command if Helper.test?
+      if Helper.test?
+        yield(nil) if block_given?
+        return command
+      end
 
       @errors = []
       @warnings = []
@@ -87,7 +90,8 @@ module FastlaneCore
         UI.important("Although errors occurred during execution of iTMSTransporter, it returned success status.")
       end
 
-      exit_status.zero?
+      yield(@all_lines) if block_given?
+      return exit_status.zero?
     end
 
     private
@@ -185,6 +189,15 @@ module FastlaneCore
       ].compact.join(' ')
     end
 
+    def build_provider_ids_command(username, password)
+      [
+        '"' + Helper.transporter_path + '"',
+        '-m provider',
+        "-u \"#{username}\"",
+        "-p #{shell_escaped_password(password)}"
+      ].compact.join(' ')
+    end
+
     def handle_error(password)
       # rubocop:disable Style/CaseEquality
       # rubocop:disable Style/YodaCondition
@@ -270,6 +283,24 @@ module FastlaneCore
       ].compact.join(' ')
     end
 
+    def build_provider_ids_command(username, password)
+      [
+        Helper.transporter_java_executable_path.shellescape,
+        "-Djava.ext.dirs=#{Helper.transporter_java_ext_dir.shellescape}",
+        '-XX:NewSize=2m',
+        '-Xms32m',
+        '-Xmx1024m',
+        '-Xms1024m',
+        '-Djava.awt.headless=true',
+        '-Dsun.net.http.retryPost=false',
+        java_code_option,
+        '-m provider',
+        "-u #{username.shellescape}",
+        "-p #{password.shellescape}",
+        '2>&1' # cause stderr to be written to stdout
+      ].compact.join(' ')
+    end
+
     def java_code_option
       if Helper.mac? && Helper.xcode_at_least?(9)
         return "-jar #{Helper.transporter_java_jar_path.shellescape}"
@@ -297,6 +328,8 @@ module FastlaneCore
   end
 
   class ItunesTransporter
+    # Matches a line in the provider table: "12  Initech Systems Inc     LG89CQY559"
+    PROVIDER_REGEX = /^\d+\s{2,}.+\s{2,}[^\s]+$/
     TWO_STEP_HOST_PREFIX = "deliver.appspecific"
 
     # This will be called from the Deliverfile, and disables the logging of the transporter output
@@ -401,6 +434,21 @@ module FastlaneCore
       result
     end
 
+    def provider_ids
+      command = @transporter_executor.build_provider_ids_command(@user, @password)
+      UI.verbose(@transporter_executor.build_provider_ids_command(@user, 'YourPassword'))
+      lines = []
+      begin
+        result = @transporter_executor.execute(command, ItunesTransporter.hide_transporter_output?) { |xs| lines = xs }
+        return result if Helper.test?
+      rescue TransporterRequiresApplicationSpecificPasswordError => ex
+        handle_two_step_failure(ex)
+        return provider_ids
+      end
+
+      lines.map { |line| provider_pair(line) }.compact.to_h
+    end
+
     private
 
     TWO_FACTOR_ENV_VARIABLE = "FASTLANE_APPLE_APPLICATION_SPECIFIC_PASSWORD"
@@ -462,5 +510,11 @@ module FastlaneCore
     def handle_error(password)
       @transporter_executor.handle_error(password)
     end
+
+    def provider_pair(line)
+      line = line.strip
+      return nil unless line =~ PROVIDER_REGEX
+      line.split(/\s{2,}/).drop(1)
+    end
   end
 end

data/frameit/lib/frameit/offsets.rb

@@ -3,19 +3,18 @@ require_relative 'frame_downloader'
 
 module Frameit
   class Offsets
-    # Returns the image offset needed for a certain device type for a given orientation
-    # uses deliver to detect the screen size
+    # Returns the image offset needed for a certain device type
     def self.image_offset(screenshot)
       require 'json'
 
-      unless @offsets
+      unless @offsets_cache
         offsets_json_path = File.join(FrameDownloader.new.templates_path, "offsets.json")
         UI.user_error!("Could not find offsets.json file at path '#{offsets_json_path}'") unless File.exist?(offsets_json_path)
-        @offsets = JSON.parse(File.read(offsets_json_path))
+        @offsets_cache = JSON.parse(File.read(offsets_json_path))
       end
 
-      offset_value = @offsets["portrait"][screenshot.device_name]
-      UI.error("Tried looking for offset information for 'portrait', #{screenshot.device_name}") unless offset_value
+      offset_value = @offsets_cache["portrait"][screenshot.device_name]
+      UI.error("Tried looking for offset information for 'portrait', #{screenshot.device_name} in '#{offsets_json_path}'") unless offset_value
       return offset_value
     end
   end

data/pilot/lib/pilot/build_manager.rb

@@ -34,7 +34,7 @@ module Pilot
                                                                   package_path: dir,
                                                                       platform: platform)
 
-      transporter = FastlaneCore::ItunesTransporter.new(options[:username], nil, false, options[:itc_provider])
+      transporter = transporter_for_selected_team(options)
       result = transporter.upload(app.apple_id, package_path)
 
       unless result
@@ -212,6 +212,25 @@ module Pilot
       !options[:localized_build_info].nil?
     end
 
+    # If itc_provider was explicitly specified, use it.
+    # If there are multiple teams, infer the provider from the selected team name.
+    # If there are fewer than two teams, don't infer the provider.
+    def transporter_for_selected_team(options)
+      generic_transporter = FastlaneCore::ItunesTransporter.new(options[:username], nil, false, options[:itc_provider])
+      return generic_transporter unless options[:itc_provider].nil? && Spaceship::Tunes.client.teams.count > 1
+
+      begin
+        team = Spaceship::Tunes.client.teams.find { |t| t['contentProvider']['contentProviderId'].to_s == Spaceship::Tunes.client.team_id }
+        name = team['contentProvider']['name']
+        provider_id = generic_transporter.provider_ids[name]
+        UI.verbose("Inferred provider id #{provider_id} for team #{name}.")
+        return FastlaneCore::ItunesTransporter.new(options[:username], nil, false, provider_id)
+      rescue => ex
+        UI.verbose("Couldn't infer a provider short name for team with id #{Spaceship::Tunes.client.team_id} automatically: #{ex}. Proceeding without provider short name.")
+        return generic_transporter
+      end
+    end
+
     def distribute_build(uploaded_build, options)
       UI.message("Distributing new build to testers: #{uploaded_build.train_version} - #{uploaded_build.build_version}")
 

data/pilot/lib/pilot/options.rb

@@ -224,7 +224,7 @@ module Pilot
         # rubocop:disable Metrics/LineLength
         FastlaneCore::ConfigItem.new(key: :itc_provider,
                                      env_name: "PILOT_ITC_PROVIDER",
-                                     description: "The provider short name to be used with the iTMSTransporter to identify your team. To get provider short name run `pathToXcode.app/Contents/Applications/Application\\ Loader.app/Contents/itms/bin/iTMSTransporter -m provider -u 'USERNAME' -p 'PASSWORD' -account_type itunes_connect -v off`. The short names of providers should be listed in the second column",
+                                     description: "The provider short name to be used with the iTMSTransporter to identify your team. This value will override the automatically detected provider short name. To get provider short name run `pathToXcode.app/Contents/Applications/Application\\ Loader.app/Contents/itms/bin/iTMSTransporter -m provider -u 'USERNAME' -p 'PASSWORD' -account_type itunes_connect -v off`. The short names of providers should be listed in the second column",
                                      optional: true),
         # rubocop:enable Metrics/LineLength
 

data/screengrab/lib/screengrab/runner.rb

@@ -195,15 +195,21 @@ module Screengrab
     end
 
     def uninstall_apks(device_serial, app_package_name, tests_package_name)
-      UI.message('Uninstalling app APK')
-      run_adb_command("adb -s #{device_serial} uninstall #{app_package_name}",
-                      print_all: true,
-                      print_command: true)
+      packages = installed_packages(device_serial)
 
-      UI.message('Uninstalling tests APK')
-      run_adb_command("adb -s #{device_serial} uninstall #{tests_package_name}",
-                      print_all: true,
-                      print_command: true)
+      if packages.include?(app_package_name.to_s)
+        UI.message('Uninstalling app APK')
+        run_adb_command("adb -s #{device_serial} uninstall #{app_package_name}",
+                        print_all: true,
+                        print_command: true)
+      end
+
+      if packages.include?(tests_package_name.to_s)
+        UI.message('Uninstalling tests APK')
+        run_adb_command("adb -s #{device_serial} uninstall #{tests_package_name}",
+                        print_all: true,
+                        print_command: true)
+      end
     end
 
     def grant_permissions(device_serial)
@@ -351,6 +357,14 @@ module Screengrab
       # We can safely ignore that and treat it as if it returned 'No such file'
     end
 
+    # Return an array of packages that are installed on the device
+    def installed_packages(device_serial)
+      packages = run_adb_command("adb -s #{device_serial} shell pm list packages",
+                                 print_all: true,
+                                 print_command: true)
+      packages.split("\n").map { |package| package.gsub("package:", "") }
+    end
+
     def run_adb_command(command, print_all: false, print_command: false)
       adb_path = @android_env.adb_path.chomp("adb")
       output = @executor.execute(command: adb_path + command,

data/spaceship/README.md

@@ -97,11 +97,11 @@ This requires you to install `pry` using `sudo gem install pry`. `pry` is not in
 
 ## Apple Developer Portal API
 
-##### Open [DeveloperPortal.md](docs/DeveloperPortal.md) for code samples
+Open [DeveloperPortal.md](docs/DeveloperPortal.md) for code samples
 
 ## App Store Connect API
 
-##### Open [AppStoreConnect.md](docs/AppStoreConnect.md) for code samples
+Open [AppStoreConnect.md](docs/AppStoreConnect.md) for code samples
 
 ## 2 Step Verification
 
@@ -123,24 +123,9 @@ This will authenticate you and provide a string that can be transferred to your
 export FASTLANE_SESSION='---\n- !ruby/object:HTTP::Cookie\n  name: DES5c148586dfd451e55afbaaa5f62418f91\n  value: HSARMTKNSRVTWFla1+yO4gVPowH17VaaaxPFnUdMUegQZxqy1Ie1c2v6bM1vSOzIbuOmrl/FNenlScsd/NbF7/Lw4cpnL15jsyg0TOJwP32tC/NguPiyOaaaU+jrj4tf4uKdIywVaaaFSRVT\n  domain: idmsa.apple.com\n  for_domain: true\n  path: "/"\n  secure: true\n  httponly: true\n  expires: 2016-04-27 23:55:56.000000000 Z\n  max_age: \n  created_at: 2016-03-28 16:55:57.032086000 -07:00\n  accessed_at: 2016-03-28 19:11:17.828141000 -07:00\n'
 ```
 
-#### Bypass trusted device and use SMS for verification
-
-If you have a trusted device configured, Apple will not send a SMS code to your phone for your Apple account when you try to generate a web session with _fastlane_. Instead, a code will be displayed on one of your account's trusted devices. This can be problematic if you are trying to authenticate but don't have access to a trusted device. Take the following steps to circumvent the device and use SMS instead:
-
-- Attempt to generate a web session with `fastlane spaceauth -u [email]` and wait for security code prompt to appear
-- Open a browser to [appleid.apple.com](https://appleid.apple.com) or an address that requires you to login with your Apple ID, and logout of any previous session
-- Login with your Apple ID and request a code be sent to the desired phone when prompted for a security code
-- Use the code sent to phone with _fastlane_ instead of with the browser
-
 #### Transporter
 
-If you want to upload builds to TestFlight/App Store Connect from your CI, you have to generate and use an application specific password:
-
-1. Visit [appleid.apple.com/account/manage](https://appleid.apple.com/account/manage)
-1. Generate a new application specific password
-1. Provide the application specific password using an environment variable `FASTLANE_APPLE_APPLICATION_SPECIFIC_PASSWORD`.
-
-Alternatively you can enter the application specific password when you're asked the first time _fastlane_ uploads a build.
+See [Continuous Integration > Authentication with Apple services > Application specific passwords](https://docs.fastlane.tools/best-practices/continuous-integration/#application-specific-passwords)
 
 ## _spaceship_ in use
 
@@ -152,7 +137,8 @@ All [fastlane tools](https://fastlane.tools) that communicate with Apple's web s
 
 Overview of the used API endpoints
 
-- `https://idmsa.apple.com`: Used to authenticate to get a valid session
+- `https://idmsa.apple.com`: 
+  - Used to authenticate to get a valid session
 - `https://developerservices2.apple.com`:
   - Get a list of all available provisioning profiles
   - Register new devices

data/spaceship/lib/spaceship/tunes/device_type.rb

@@ -1,7 +1,33 @@
 module Spaceship
   module Tunes
+    # identifiers of devices that App Store Connect accepts screenshots for
     class DeviceType
-      @types = ['iphone35', 'iphone4', 'iphone6', 'iphone6Plus', 'iphone58', 'iphone65', 'ipad', 'ipad105', 'ipadPro', 'ipadPro11', 'ipadPro129', 'watch', 'watchSeries4', 'appleTV', 'desktop']
+      @types = [
+        # iPhone
+        'iphone35',
+        'iphone4',
+        'iphone6', # 4.7-inch Display
+        'iphone6Plus', # 5.5-inch Display
+        'iphone58', # iPhone XS
+        'iphone65', # iPhone XS Max
+
+        # iPad
+        'ipad', # 9.7-inch Display
+        'ipad105',
+        'ipadPro',
+        'ipadPro11',
+        'ipadPro129',
+
+        # Apple Watch
+        'watch', # series 3
+        'watchSeries4',
+
+        # Apple TV
+        'appleTV',
+
+        # Mac
+        'desktop'
+      ]
       class << self
         attr_accessor :types
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: fastlane
 version: !ruby/object:Gem::Version
-  version: 2.119.0.beta.20190322200024
+  version: 2.119.0.beta.20190323200019
 platform: ruby
 authors:
 - Iulian Onofrei
@@ -27,7 +27,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-03-22 00:00:00.000000000 Z
+date: 2019-03-23 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: slack-notifier
@@ -1688,24 +1688,24 @@ metadata:
 post_install_message: 
 rdoc_options: []
 require_paths:
-- scan/lib
-- frameit/lib
+- deliver/lib
+- cert/lib
+- produce/lib
+- fastlane_core/lib
 - pilot/lib
-- snapshot/lib
+- match/lib
 - spaceship/lib
 - supply/lib
-- gym/lib
-- match/lib
+- precheck/lib
+- sigh/lib
 - fastlane/lib
-- fastlane_core/lib
-- deliver/lib
 - credentials_manager/lib
-- screengrab/lib
-- cert/lib
-- sigh/lib
-- precheck/lib
+- frameit/lib
+- snapshot/lib
+- gym/lib
 - pem/lib
-- produce/lib
+- scan/lib
+- screengrab/lib
 required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="