fastlane 2.118.0.beta.20190308200057 → 2.118.0.beta.20190309200014

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: f00659a78dd038033596cc8745944e14031b3671
-  data.tar.gz: 86e48d4991bff2b4318018ace0cc9c235c6a7a5b
+  metadata.gz: 3975190e06ff4d2cb4deff79ce4371145b6b9270
+  data.tar.gz: 7f118e4b20687863b6467aab23cc05afa90edeb1
 SHA512:
-  metadata.gz: 6993dacbe3234ce05a4dd9c0a7c17b1ad06f59f0210261bdaacf8ca419b829bdf8a7c5d29f9c79711b498ed5ba298b362a43197229071e2620bd134f8ea74e02
-  data.tar.gz: bd7b67a95eb90fe1f35621a4ec1dd8e39b01fbb7a5e6a158a4fd5b889053201a1c6640dcca4e2f3bd0867ab461f1ac94c176b9d7d80e47e2d5546bfa58343401
+  metadata.gz: 1484610059064c95fd36543564e31614bc8a781f69d25b4a52c2aefc3655bfa6a973e2c8c3dc831a58a1d1403d2b38ed628cc73551b7ae7e74b6071033b7d6a1
+  data.tar.gz: 8dab0578678cf2ab5b4a46e1ba04f0369262755eb6d1d55e285737dc41579f7ea0878e1f5c8caf18a24b47f894aa0ee372e0df68a7252356390684aa074a61e4

data/fastlane/lib/fastlane/actions/create_keychain.rb

@@ -11,20 +11,20 @@ module Fastlane
         escaped_password = params[:password].shellescape
 
         if params[:name]
-          escaped_name = params[:name].shellescape
-          keychain_path = "~/Library/Keychains/#{escaped_name}"
+          keychain_path = "~/Library/Keychains/#{params[:name]}"
         else
-          keychain_path = params[:path].shellescape
+          keychain_path = params[:path]
         end
+        escaped_keychain_path = keychain_path.shellescape
 
-        if keychain_path.nil?
+        if escaped_keychain_path.nil?
           UI.user_error!("You either have to set :name or :path")
         end
 
         commands = []
 
-        if !exists?(keychain_path)
-          commands << Fastlane::Actions.sh("security create-keychain -p #{escaped_password} #{keychain_path}", log: false)
+        if !exists?(escaped_keychain_path)
+          commands << Fastlane::Actions.sh("security create-keychain -p #{escaped_password} #{escaped_keychain_path}", log: false)
         elsif params[:require_create]
           UI.abort_with_message!("`require_create` option passed, but found keychain '#{keychain_path}', failing create_keychain action")
         else
@@ -38,21 +38,22 @@ module Fastlane
             Actions.lane_context[Actions::SharedValues::ORIGINAL_DEFAULT_KEYCHAIN] = Fastlane::Actions.sh("security default-keychain", log: false).strip
           rescue
           end
-          commands << Fastlane::Actions.sh("security default-keychain -s #{keychain_path}", log: false)
+          commands << Fastlane::Actions.sh("security default-keychain -s #{escaped_keychain_path}", log: false)
         end
 
-        commands << Fastlane::Actions.sh("security unlock-keychain -p #{escaped_password} #{keychain_path}", log: false) if params[:unlock]
+        commands << Fastlane::Actions.sh("security unlock-keychain -p #{escaped_password} #{escaped_keychain_path}", log: false) if params[:unlock]
 
         command = "security set-keychain-settings"
         command << " -t #{params[:timeout]}" if params[:timeout]
         command << " -l" if params[:lock_when_sleeps]
         command << " -u" if params[:lock_after_timeout]
-        command << " #{keychain_path}"
+        command << " #{escaped_keychain_path}"
 
         commands << Fastlane::Actions.sh(command, log: false)
 
         if params[:add_to_search_list]
           keychains = Action.sh("security list-keychains -d user").shellsplit
+          # Do not use 'escaped_keychain_path' here because .shelljoin will cause double escaping
           keychains << File.expand_path(keychain_path)
           commands << Fastlane::Actions.sh("security list-keychains -s #{keychains.shelljoin}", log: false)
         end
@@ -60,12 +61,12 @@ module Fastlane
         commands
       end
 
-      def self.exists?(keychain_path)
-        keychain_path = File.expand_path(keychain_path)
+      def self.exists?(escaped_keychain_path)
+        escaped_keychain_path = File.expand_path(escaped_keychain_path)
 
         # Creating Keychains using the security
         # CLI appends `-db` to the file name.
-        File.exist?("#{keychain_path}-db") || File.exist?(keychain_path)
+        File.exist?("#{escaped_keychain_path}-db") || File.exist?(escaped_keychain_path)
       end
 
       def self.description

data/fastlane/lib/fastlane/version.rb

@@ -1,5 +1,5 @@
 module Fastlane
-  VERSION = '2.118.0.beta.20190308200057'.freeze
+  VERSION = '2.118.0.beta.20190309200014'.freeze
   DESCRIPTION = "The easiest way to automate beta deployments and releases for your iOS and Android apps".freeze
   MINIMUM_XCODE_RELEASE = "7.0".freeze
   RUBOCOP_REQUIREMENT = '0.49.1'.freeze

data/fastlane_core/lib/fastlane_core/keychain_importer.rb

@@ -6,7 +6,7 @@ module FastlaneCore
     def self.import_file(path, keychain_path, keychain_password: "", certificate_password: "", output: FastlaneCore::Globals.verbose?)
       UI.user_error!("Could not find file '#{path}'") unless File.exist?(path)
 
-      command = "security import #{path.shellescape} -k '#{keychain_path.shellescape}'"
+      command = "security import #{path.shellescape} -k #{keychain_path.shellescape}"
       command << " -P #{certificate_password.shellescape}"
       command << " -T /usr/bin/codesign" # to not be asked for permission when running a tool like `gym` (before Sierra)
       command << " -T /usr/bin/security"

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: fastlane
 version: !ruby/object:Gem::Version
-  version: 2.118.0.beta.20190308200057
+  version: 2.118.0.beta.20190309200014
 platform: ruby
 authors:
 - Jimmy Dee
@@ -27,7 +27,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-03-08 00:00:00.000000000 Z
+date: 2019-03-09 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: slack-notifier
@@ -1687,24 +1687,24 @@ metadata:
 post_install_message: 
 rdoc_options: []
 require_paths:
-- credentials_manager/lib
+- supply/lib
+- screengrab/lib
+- spaceship/lib
+- produce/lib
 - sigh/lib
 - snapshot/lib
+- match/lib
+- pem/lib
 - frameit/lib
+- deliver/lib
+- gym/lib
 - fastlane/lib
+- scan/lib
+- cert/lib
 - pilot/lib
-- gym/lib
-- produce/lib
-- pem/lib
-- match/lib
 - fastlane_core/lib
-- cert/lib
+- credentials_manager/lib
 - precheck/lib
-- deliver/lib
-- scan/lib
-- spaceship/lib
-- supply/lib
-- screengrab/lib
 required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="