fastlane 2.116.0.beta.20190201200019 → 2.116.0.beta.20190202200022

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 3b190bb3cbf57f3c6c4fbff2c712c71e3c143391
-  data.tar.gz: 62fda1dafe44885e078babe3f05b14ff1af34857
+  metadata.gz: b98421e72126a08adc16c4f061bb737a09c204de
+  data.tar.gz: 44f3a1be01fa5f90d73e3e79c60699f2f8f5a07d
 SHA512:
-  metadata.gz: f56a55288d182c8ecd46962902884385c989e764bbd58b2de3a367fd3ad67d19a66cb93253b843e312ce5e83b006ade76caf72cf777cd21c4de2e3175a943b3a
-  data.tar.gz: 7887b15558375bd3a0de91f542fd69aa5689808e723f22ee233d22bb7c125e96f8f9b6526980326a438a405f834cfc0f0a7114956a5782d99bf1d7cadd14c9d5
+  metadata.gz: 7f4491cc42ec02abd01edbdd0565131c40541b607c50687ac4d4f334e4b0549ff0b9fd58e39551a35cbfb496379d4303eaf28a892b9ec4435c73203a36974a2e
+  data.tar.gz: 5bc8da6371f34146594325bc0eaa153c0a14c839aee118a3f0049d5f5ea6f4131b2f706f089e3fb85d90911d95b0fb3dd05045cd07ff5509de16edc2fb2ea98b

data/fastlane/lib/fastlane/version.rb

@@ -1,5 +1,5 @@
 module Fastlane
-  VERSION = '2.116.0.beta.20190201200019'.freeze
+  VERSION = '2.116.0.beta.20190202200022'.freeze
   DESCRIPTION = "The easiest way to automate beta deployments and releases for your iOS and Android apps".freeze
   MINIMUM_XCODE_RELEASE = "7.0".freeze
   RUBOCOP_REQUIREMENT = '0.49.1'.freeze

data/fastlane_core/lib/fastlane_core/keychain_importer.rb

@@ -12,8 +12,26 @@ module FastlaneCore
       command << " -T /usr/bin/security"
       command << " 1> /dev/null" unless output
 
-      Helper.backticks(command, print: output)
+      UI.command(command) if output
+      Open3.popen3(command) do |stdin, stdout, stderr, thrd|
+        UI.command_output(stdout.read.to_s) if output
 
+        # Set partition list only if success since it can be a time consuming process if a lot of keys are installed
+        if thrd.value.success?
+          set_partition_list(path, keychain_path, keychain_password: keychain_password, output: output)
+        else
+          # Output verbose if file is already installed since not an error otherwise we will show the whole error
+          err = stderr.read.to_s.strip
+          if err.include?("SecKeychainItemImport") && err.include?("The specified item already exists in the keychain")
+            UI.verbose("'#{File.basename(path)}' is already installed on this machine")
+          else
+            UI.error(err)
+          end
+        end
+      end
+    end
+
+    def self.set_partition_list(path, keychain_path, keychain_password: "", output: FastlaneCore::Globals.verbose?)
       # When security supports partition lists, also add the partition IDs
       # See https://openradar.appspot.com/28524119
       if Helper.backticks('security -h | grep set-key-partition-list', print: false).length > 0
@@ -33,14 +51,14 @@ module FastlaneCore
 
             # Inform user when no/wrong password was used as its needed to prevent UI permission popup from Xcode when signing
             if err.include?("SecKeychainItemSetAccessWithPassword")
-              UI.error("")
-              UI.error("Could not configure imported keychain item (certificate) to prevent UI permission popup when code signing\n" \
+              UI.important("")
+              UI.important("Could not configure imported keychain item (certificate) to prevent UI permission popup when code signing\n" \
                        "Check if you supplied the correct `keychain_password` for keychain: `#{keychain_path}`\n" \
                        "#{err}")
-              UI.error("")
-              UI.error("Please look at the following docs to see how to set a keychain password:")
-              UI.error(" - https://docs.fastlane.tools/actions/sync_code_signing")
-              UI.error(" - https://docs.fastlane.tools/actions/get_certificates")
+              UI.important("")
+              UI.important("Please look at the following docs to see how to set a keychain password:")
+              UI.important(" - https://docs.fastlane.tools/actions/sync_code_signing")
+              UI.important(" - https://docs.fastlane.tools/actions/get_certificates")
             else
               UI.error(err)
             end

data/match/lib/match/runner.rb

@@ -169,7 +169,6 @@ module Match
         self.files_to_commit << private_key_path
       else
         cert_path = certs.last
-
         if Helper.mac?
           UI.message("Installing certificate...")
 
@@ -185,6 +184,7 @@ module Match
 
           # Import the private key
           # there seems to be no good way to check if it's already installed - so just install it
+          # Key will only be added to the partition list if it isn't already installed
           Utils.import(keys.last, params[:keychain_name], password: params[:keychain_password])
         else
           UI.message("Skipping installation of certificate as it would not work on this operating system.")

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: fastlane
 version: !ruby/object:Gem::Version
-  version: 2.116.0.beta.20190201200019
+  version: 2.116.0.beta.20190202200022
 platform: ruby
 authors:
 - Matthew Ellis
@@ -27,7 +27,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-02-01 00:00:00.000000000 Z
+date: 2019-02-02 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: slack-notifier
@@ -1687,24 +1687,24 @@ metadata:
 post_install_message: 
 rdoc_options: []
 require_paths:
-- gym/lib
-- match/lib
-- produce/lib
-- sigh/lib
-- scan/lib
 - cert/lib
-- pilot/lib
 - spaceship/lib
-- pem/lib
-- frameit/lib
+- scan/lib
 - fastlane/lib
-- deliver/lib
-- supply/lib
-- screengrab/lib
 - snapshot/lib
-- fastlane_core/lib
+- pem/lib
+- gym/lib
 - credentials_manager/lib
+- screengrab/lib
+- pilot/lib
+- match/lib
+- sigh/lib
+- fastlane_core/lib
+- supply/lib
+- deliver/lib
 - precheck/lib
+- frameit/lib
+- produce/lib
 required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="