fastlane 2.115.0.beta.20190118200015 → 2.115.0.beta.20190119200019

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 51ab10a7382ae32cee2a6e59fb082b49ca4b8f0b
-  data.tar.gz: d6c3298d585b07353a610a859c155b1641d3e261
+  metadata.gz: 405a7ac48ad02e28a6b26a3dda7458028411060b
+  data.tar.gz: c1df6b742f5a232012d94e42d2e04c935a3ec201
 SHA512:
-  metadata.gz: ec0d3d18e0aa30c47d26d39aaab9859416ccb1a33b4d2d0aaa16346b8ecccf21378d6bb6c5255e8b10471589f61bbfcd14b048f30ac5e5f7087c9e644568435f
-  data.tar.gz: 6926d1231b6c0b14fd998af06b8f1a1d07e2c7791e657b354075f3d27b531c108799846845cc37afbee210435f2615a47c7858888be49f91943515321b042e8f
+  metadata.gz: e072c405cda86946bac1343f0a8d9de9ac72ee822385443633ed550022f6fdfd331d78d9d50c632fb7afdc30d8d5d348d837e8df632ca5645b79ce1769e87ced
+  data.tar.gz: 8a939edd7c093b7c4a291ac5651fcaafa77910279fdf13bb65a1c6d629458bd5f98b42701bb2ffc34698f7d201a3990043ace5cf8c25865e95b9264f4d54adaf

data/fastlane/lib/fastlane/actions/download_dsyms.rb

@@ -35,8 +35,15 @@ module Fastlane
 
           UI.user_error!("Could not find latest version for your app, please try setting a specific version") if latest_version.version.nil?
 
-          version = get_version(latest_version)
-          build_number = latest_version.build_version
+          latest_candidate_build = latest_version.candidate_builds.max_by(&:upload_date)
+          if latest_candidate_build.nil?
+            version = latest_version.version
+            build_number = latest_version.build_version
+          else
+            # The build_version of a candidate build does not always match the one in latest_version so get the version and build number from the same place.
+            version = latest_candidate_build.train_version
+            build_number = latest_candidate_build.build_version
+          end
         end
 
         # Make sure output_directory has a slash on the end
@@ -112,16 +119,6 @@ module Fastlane
         Actions.lane_context[SharedValues::DSYM_PATHS] << File.expand_path(path)
       end
 
-      def self.get_version(latest_version)
-        candidate_build = latest_version.candidate_builds.first
-        if candidate_build.nil?
-          latest_version.version
-        else
-          candidate_build.train_version
-        end
-      end
-      private_class_method :get_version
-
       def self.write_dsym(data, bundle_id, train_number, build_number, output_directory)
         file_name = "#{bundle_id}-#{train_number}-#{build_number}.dSYM.zip"
         if output_directory

data/fastlane/lib/fastlane/actions/git_commit.rb

@@ -8,7 +8,9 @@ module Fastlane
           paths = params[:path].map(&:shellescape).join(' ')
         end
 
-        result = Actions.sh("git commit -m #{params[:message].shellescape} #{paths}")
+        skip_git_hooks = params[:skip_git_hooks] ? '--no-verify' : ''
+
+        result = Actions.sh("git commit -m #{params[:message].shellescape} #{paths} #{skip_git_hooks}".strip)
         UI.success("Successfully committed \"#{params[:path]}\" 💾.")
         return result
       end
@@ -27,7 +29,11 @@ module Fastlane
                                        description: "The file you want to commit",
                                        is_string: false),
           FastlaneCore::ConfigItem.new(key: :message,
-                                       description: "The commit message that should be used")
+                                       description: "The commit message that should be used"),
+          FastlaneCore::ConfigItem.new(key: :skip_git_hooks,
+                                       description: "Set to true to pass --no-verify to git",
+                                       type: Boolean,
+                                       optional: true)
         ]
       end
 
@@ -50,7 +56,8 @@ module Fastlane
         [
           'git_commit(path: "./version.txt", message: "Version Bump")',
           'git_commit(path: ["./version.txt", "./changelog.txt"], message: "Version Bump")',
-          'git_commit(path: ["./*.txt", "./*.md"], message: "Update documentation")'
+          'git_commit(path: ["./*.txt", "./*.md"], message: "Update documentation")',
+          'git_commit(path: ["./*.txt", "./*.md"], message: "Update documentation", skip_git_hooks: true)'
         ]
       end
 

data/fastlane/lib/fastlane/version.rb

@@ -1,5 +1,5 @@
 module Fastlane
-  VERSION = '2.115.0.beta.20190118200015'.freeze
+  VERSION = '2.115.0.beta.20190119200019'.freeze
   DESCRIPTION = "The easiest way to automate beta deployments and releases for your iOS and Android apps".freeze
   MINIMUM_XCODE_RELEASE = "7.0".freeze
   RUBOCOP_REQUIREMENT = '0.49.1'.freeze

data/sigh/lib/assets/resign.sh

@@ -63,6 +63,9 @@
 # new features November 2018
 # 1. only create the archived-expanded-entitlements.xcent file if the version of Xcode < 9.3 as Xcode 10 does not create it.
 #
+# new features January 2019
+# 1. fixed bug where the com.apple.icloud-container-environment entitlement was being assigned an incorrect value
+#
 
 # Logging functions
 
@@ -743,7 +746,19 @@ function resign {
                 # This value is set by Xcode during export (manually selected for Development and AdHoc, automatically set to Production for Store)
                 # Would need an additional dedicated option to specify the iCloud environment to be used (Development or Production)
                 # For now, we assume Production is to be used when signing with a Distribution certificate, Development if not
-                if [[ "$CERTIFICATE" =~ "Distribution:" ]]; then
+                local certificate_name=$CERTIFICATE
+                local sha1_pattern='[0-9A-F]{40}'
+
+                if [[ "$CERTIFICATE" =~ $sha1_pattern ]]; then
+                    log "Certificate $CERTIFICATE matches a SHA1 pattern"
+                    local certificate_matches="$( security find-identity -v -p codesigning | grep -m 1 "$CERTIFICATE" )"
+                    if [ -n "$certificate_matches" ]; then
+                        certificate_name="$( sed -E s/[^\"]+\"\([^\"]+\)\".*/\\1/ <<< $certificate_matches )"
+                        log "Certificate name: $certificate_name"
+                    fi
+                fi
+
+                if [[ "$certificate_name" =~ "Distribution:" ]]; then
                     ICLOUD_ENV="Production"
                 else
                     ICLOUD_ENV="Development"

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: fastlane
 version: !ruby/object:Gem::Version
-  version: 2.115.0.beta.20190118200015
+  version: 2.115.0.beta.20190119200019
 platform: ruby
 authors:
 - Danielle Tomlinson
@@ -27,7 +27,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-01-18 00:00:00.000000000 Z
+date: 2019-01-19 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: slack-notifier
@@ -1688,24 +1688,24 @@ metadata:
 post_install_message: 
 rdoc_options: []
 require_paths:
+- cert/lib
+- spaceship/lib
+- scan/lib
+- fastlane/lib
 - snapshot/lib
+- pem/lib
+- gym/lib
 - credentials_manager/lib
 - screengrab/lib
-- pem/lib
-- fastlane/lib
 - pilot/lib
-- frameit/lib
-- scan/lib
-- cert/lib
-- precheck/lib
-- supply/lib
+- match/lib
 - sigh/lib
-- deliver/lib
-- gym/lib
-- spaceship/lib
 - fastlane_core/lib
+- supply/lib
+- deliver/lib
+- precheck/lib
+- frameit/lib
 - produce/lib
-- match/lib
 required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="