fastlane 2.114.0.beta.20190115200110 → 2.114.0.beta.20190116200018

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: ce412e8b3e2f6f853fb84786b51b5715e971769a
-  data.tar.gz: 4cd640aa23816cc6b328979bb7e029f199c037b2
+  metadata.gz: 8823faa01f6b91b8f1d75874a92e31c24e5baf7b
+  data.tar.gz: 798b9258cdccc86dd157343f01948b7b64329a01
 SHA512:
-  metadata.gz: 7f2d02755278043cc75b02eaaf0984131fafc84a7887f3b04bfbba267be04ae4e178dbab5f6207077addef3ccce5c6ce4002c27b0857a3e8993e2f840345868b
-  data.tar.gz: f3e8e389e1c76bb3f68ad90948ebf6273e2b06f3c2841e9a8169061a83d353d6636e113fc0e46bb4f8ca4a7a35954fc6bef72cdc4cc63467a206badcb398a162
+  metadata.gz: eb89b5429909549a65ad93a6f2192de69a1d33834ffb3260d413adde31da4e1b072a72953a4b35938b97c19982d0afdef08e04bcdc98c9bfc2931abf8e341107
+  data.tar.gz: 7f60cd65995378cb001435f2a6202f45ce800b52d4607fe0b738b7be4aa45741d7100edf57537db568c1cccba18953612d0afae6328916840728d915a54cf722

data/fastlane/lib/fastlane/actions/create_pull_request.rb

@@ -132,7 +132,7 @@ module Fastlane
       end
 
       def self.return_value
-        "The parsed JSON when successful"
+        "The pull request URL when successful"
       end
 
       def self.example_code

data/fastlane/lib/fastlane/actions/download_dsyms.rb

@@ -25,6 +25,7 @@ module Fastlane
         build_number = params[:build_number]
         platform = params[:platform]
         output_directory = params[:output_directory]
+        min_version = Gem::Version.new(params[:min_version]) if params[:min_version]
 
         # Set version if it is latest
         if version == 'latest'
@@ -51,21 +52,35 @@ module Fastlane
         UI.message(message.join(" "))
 
         app.tunes_all_build_trains(platform: platform).each do |train|
-          UI.verbose("Found train: #{train.version_string}, comparing to supplied version: #{version}")
+          message = []
+          message << "Found train (version): #{train.version_string}"
+          message << ", comparing to supplied version: #{version}" if version
+          UI.verbose(message.join(" "))
+
           if version && version != train.version_string
             UI.verbose("Version #{version} doesn't match: #{train.version_string}")
             next
           end
+
+          if min_version && min_version > Gem::Version.new(train.version_string)
+            UI.verbose("Min version #{min_version} not reached: #{train.version_string}")
+            next
+          end
+
           app.tunes_all_builds_for_train(train: train.version_string, platform: platform).each do |build|
-            UI.verbose("Found build version: #{build.build_version}, comparing to supplied build_number: #{build_number}")
+            message = []
+            message << "Found build version: #{build.build_version}"
+            message << ", comparing to supplied build_number: #{build_number}" if build_number
+            UI.verbose(message.join(" "))
+
             if build_number && build.build_version != build_number
               UI.verbose("build_version: #{build.build_version} doesn't match: #{build_number}")
               next
             end
 
             begin
-              # need to call reload here or dsym_url is nil
-              UI.verbose("Build_version: #{build.build_version} matches #{build_number}, grabbing dsym_url")
+              UI.verbose("Build_version: #{build.build_version} matches #{build_number}, grabbing dsym_url") if build_number
+
               build_details = app.tunes_build_details(train: train.version_string, build_number: build.build_version, platform: platform)
               download_url = build_details.dsym_url
               UI.verbose("dsym_url: #{download_url}")
@@ -207,6 +222,11 @@ module Fastlane
                                        env_name: "DOWNLOAD_DSYMS_BUILD_NUMBER",
                                        description: "The app build_number for dSYMs you wish to download",
                                        optional: true),
+          FastlaneCore::ConfigItem.new(key: :min_version,
+                                       short_option: "-m",
+                                       env_name: "DOWNLOAD_DSYMS_MIN_VERSION",
+                                       description: "The minimum app version for dSYMs you wish to download",
+                                       optional: true),
           FastlaneCore::ConfigItem.new(key: :output_directory,
                                        short_option: "-s",
                                        env_name: "DOWNLOAD_DSYMS_OUTPUT_DIRECTORY",
@@ -236,7 +256,8 @@ module Fastlane
       def self.example_code
         [
           'download_dsyms',
-          'download_dsyms(version: "1.0.0", build_number: "345")'
+          'download_dsyms(version: "1.0.0", build_number: "345")',
+          'download_dsyms(min_version: "1.2.3")'
         ]
       end
 

data/fastlane/lib/fastlane/actions/increment_version_number.rb

@@ -23,20 +23,25 @@ module Fastlane
           '&&'
         ].join(' ')
 
-        current_version = `#{command_prefix} agvtool what-marketing-version -terse1`.split("\n").last || ''
+        begin
+          current_version = Actions
+                            .sh("#{command_prefix} agvtool what-marketing-version -terse1", log: FastlaneCore::Globals.verbose?)
+                            .split("\n")
+                            .last
+                            .strip
+        rescue
+          current_version = ''
+        end
 
+        version_regex = /^\d+\.\d+\.\d+$/
         if params[:version_number]
-          UI.verbose("Your current version (#{current_version}) does not respect the format A.B.C") unless current_version =~ /\d.\d.\d/
+          UI.verbose("Your current version (#{current_version}) does not respect the format A.B.C") unless current_version =~ version_regex
 
           # Specific version
           next_version_number = params[:version_number]
         else
-          if Helper.test?
-            version_array = [1, 0, 0]
-          else
-            UI.user_error!("Your current version (#{current_version}) does not respect the format A.B.C") unless current_version =~ /\d+.\d+.\d+/
-            version_array = current_version.split(".").map(&:to_i)
-          end
+          UI.user_error!("Your current version (#{current_version}) does not respect the format A.B.C") unless current_version =~ version_regex
+          version_array = current_version.split(".").map(&:to_i)
 
           case params[:bump_type]
           when "patch"

data/fastlane/lib/fastlane/actions/prompt.rb

@@ -15,7 +15,18 @@ module Fastlane
           # Multi line
           end_tag = params[:multi_line_end_keyword]
           UI.important("Submit inputs using \"#{params[:multi_line_end_keyword]}\"")
-          user_input = STDIN.gets(end_tag).chomp.gsub(end_tag, "").strip
+          user_input = ""
+          loop do
+            line = STDIN.gets
+            end_tag_index = line.index(end_tag)
+            if end_tag_index.nil?
+              user_input << line
+            else
+              user_input << line.slice(0, end_tag_index)
+              user_input = user_input.strip
+              break
+            end
+          end
         else
           # Standard one line input
           if params[:secure_text]

data/fastlane/lib/fastlane/version.rb

@@ -1,5 +1,5 @@
 module Fastlane
-  VERSION = '2.114.0.beta.20190115200110'.freeze
+  VERSION = '2.114.0.beta.20190116200018'.freeze
   DESCRIPTION = "The easiest way to automate beta deployments and releases for your iOS and Android apps".freeze
   MINIMUM_XCODE_RELEASE = "7.0".freeze
   RUBOCOP_REQUIREMENT = '0.49.1'.freeze

data/fastlane_core/lib/fastlane_core/keychain_importer.rb

@@ -10,7 +10,7 @@ module FastlaneCore
       command << " -P #{certificate_password.shellescape}"
       command << " -T /usr/bin/codesign" # to not be asked for permission when running a tool like `gym` (before Sierra)
       command << " -T /usr/bin/security"
-      command << " &> /dev/null" unless output
+      command << " 1> /dev/null" unless output
 
       Helper.backticks(command, print: output)
 
@@ -19,31 +19,37 @@ module FastlaneCore
       if Helper.backticks('security -h | grep set-key-partition-list', print: false).length > 0
         command = "security set-key-partition-list"
         command << " -S apple-tool:,apple:"
-        command << " -l 'Imported Private Key'"
         command << " -k #{keychain_password.to_s.shellescape}"
         command << " #{keychain_path.shellescape}"
-        command << " &> /dev/null" # always disable stdout. This can be very verbose, and leak potentially sensitive info
+        command << " 1> /dev/null" # always disable stdout. This can be very verbose, and leak potentially sensitive info
+
+        # Showing loading indicator as this can take some time if a lot of keys installed
+        Helper.show_loading_indicator("Setting key partition list... (this can take a minute if there are a lot of keys installed)")
 
         UI.command(command) if output
         Open3.popen3(command) do |stdin, stdout, stderr, thrd|
-          if output
-            Helper.show_loading_indicator("Importing keys...")
-            UI.command(command)
-            UI.command_output(stdout.read)
-            Helper.hide_loading_indicator
-          end
-
           unless thrd.value.success?
-            UI.error("")
-            UI.error("Could not configure imported keychain item (certificate) to prevent UI permission popup when code signing\n" \
-                     "Check if you supplied the correct `keychain_password` for keychain: `#{keychain_path}`\n" \
-                     "#{stderr.read.to_s.strip}")
-            UI.error("")
-            UI.error("Please look at the following docs to see how to set a keychain password:")
-            UI.error(" - https://docs.fastlane.tools/actions/sync_code_signing")
-            UI.error(" - https://docs.fastlane.tools/actions/get_certificates")
+            err = stderr.read.to_s.strip
+
+            # Inform user when no/wrong password was used as its needed to prevent UI permission popup from Xcode when signing
+            if err.include?("SecKeychainItemSetAccessWithPassword")
+              UI.error("")
+              UI.error("Could not configure imported keychain item (certificate) to prevent UI permission popup when code signing\n" \
+                       "Check if you supplied the correct `keychain_password` for keychain: `#{keychain_path}`\n" \
+                       "#{err}")
+              UI.error("")
+              UI.error("Please look at the following docs to see how to set a keychain password:")
+              UI.error(" - https://docs.fastlane.tools/actions/sync_code_signing")
+              UI.error(" - https://docs.fastlane.tools/actions/get_certificates")
+            else
+              UI.error(err)
+            end
           end
         end
+
+        # Hiding after Open3 finishes
+        Helper.hide_loading_indicator
+
       end
     end
   end

data/scan/lib/scan/options.rb

@@ -69,6 +69,13 @@ module Scan
                                      type: Boolean,
                                      optional: true),
 
+        # reset simulator
+        FastlaneCore::ConfigItem.new(key: :reset_simulator,
+                                     env_name: 'SCAN_RESET_SIMULATOR',
+                                     description: "Enabling this option will automatically erase the simulator before running the application",
+                                     default_value: false,
+                                     type: Boolean),
+
         # reinstall app
         FastlaneCore::ConfigItem.new(key: :reinstall_app,
                                      env_name: 'SCAN_REINSTALL_APP',

data/scan/lib/scan/runner.rb

@@ -40,7 +40,11 @@ module Scan
       ]
       exit_status = 0
 
-      if Scan.config[:reinstall_app]
+      if Scan.config[:reset_simulator]
+        Scan.devices.each do |device|
+          FastlaneCore::Simulator.reset(udid: device.udid)
+        end
+      elsif Scan.config[:reinstall_app]
         app_identifier = Scan.config[:app_identifier]
         app_identifier ||= UI.input("App Identifier: ")
 

data/sigh/lib/sigh/resign.rb

@@ -21,6 +21,19 @@ module Sigh
 
     def resign(ipa, signing_identity, provisioning_profiles, entitlements, version, display_name, short_version, bundle_version, new_bundle_id, use_app_entitlements, keychain_path)
       resign_path = find_resign_path
+
+      if keychain_path
+        keychain_path_absolute = File.expand_path(keychain_path)
+
+        current_keychains = `security list-keychains`
+        current_keychains.delete!("\n")
+
+        unless current_keychains.include?(keychain_path_absolute)
+          previous_keychains = current_keychains
+          `security list-keychains -s #{current_keychains} '#{keychain_path_absolute}'`
+        end
+      end
+
       signing_identity = find_signing_identity(signing_identity)
 
       unless provisioning_profiles.kind_of?(Enumerable)
@@ -68,6 +81,8 @@ module Sigh
         UI.error("Something went wrong while code signing #{ipa}")
         false
       end
+    ensure
+      `security list-keychains -s #{previous_keychains}` if previous_keychains
     end
 
     def get_inputs(options, args)
@@ -103,9 +118,10 @@ module Sigh
     end
 
     def find_signing_identity(signing_identity)
-      until (signing_identity = sha1_for_signing_identity(signing_identity))
-        UI.error("Couldn't find signing identity '#{signing_identity}'.")
-        signing_identity = ask_for_signing_identity
+      signing_identity_input = signing_identity
+      until (signing_identity = sha1_for_signing_identity(signing_identity_input))
+        UI.error("Couldn't find signing identity '#{signing_identity_input}'.")
+        signing_identity_input = ask_for_signing_identity
       end
 
       signing_identity

data/snapshot/lib/snapshot/simulator_launchers/launcher_configuration.rb

@@ -42,7 +42,9 @@ module Snapshot
 
       launch_arguments = Array(snapshot_config[:launch_arguments])
       # if more than 1 set of arguments, use a tuple with an index
-      if launch_arguments.count == 1
+      if launch_arguments.count == 0
+        @launch_args_set = [[""]]
+      elsif launch_arguments.count == 1
         @launch_args_set = [launch_arguments]
       else
         @launch_args_set = launch_arguments.map.with_index { |e, i| [i, e] }

data/supply/lib/supply/options.rb

@@ -228,7 +228,17 @@ module Supply
                                      optional: true,
                                      description: "When promoting to a new track, deactivate the binary in the origin track",
                                      is_string: false,
-                                     default_value: true)
+                                     default_value: true),
+        FastlaneCore::ConfigItem.new(key: :version_codes_to_retain,
+                                     optional: true,
+                                     type: Array,
+                                     description: "An array of version codes to retain when publishing a new APK",
+                                     verify_block: proc do |version_codes|
+                                       UI.user_error!("Could not evaluate array from '#{version_codes}'") unless version_codes.kind_of?(Array)
+                                       version_codes.each do |version_code|
+                                         UI.user_error!("Version code '#{version_code}' is not an integer") unless version_code.kind_of?(Integer)
+                                       end
+                                     end)
       ]
     end
     # rubocop:enable Metrics/PerceivedComplexity

data/supply/lib/supply/uploader.rb

@@ -28,6 +28,8 @@ module Supply
       apk_version_codes.concat(upload_bundles) unless Supply.config[:skip_upload_aab]
       upload_mapping(apk_version_codes)
 
+      apk_version_codes.concat(Supply.config[:version_codes_to_retain]) if Supply.config[:version_codes_to_retain]
+
       # Only update tracks if we have version codes
       # Updating a track with empty version codes can completely clear out a track
       update_track(apk_version_codes) unless apk_version_codes.empty?

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: fastlane
 version: !ruby/object:Gem::Version
-  version: 2.114.0.beta.20190115200110
+  version: 2.114.0.beta.20190116200018
 platform: ruby
 authors:
 - Stefan Natchev
@@ -27,7 +27,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-01-15 00:00:00.000000000 Z
+date: 2019-01-16 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: slack-notifier
@@ -1683,23 +1683,23 @@ post_install_message:
 rdoc_options: []
 require_paths:
 - frameit/lib
-- precheck/lib
+- pilot/lib
+- fastlane/lib
+- snapshot/lib
 - gym/lib
-- deliver/lib
+- precheck/lib
+- scan/lib
+- pem/lib
 - produce/lib
-- snapshot/lib
-- sigh/lib
-- screengrab/lib
-- pilot/lib
+- spaceship/lib
 - fastlane_core/lib
 - supply/lib
+- deliver/lib
+- credentials_manager/lib
 - match/lib
-- fastlane/lib
+- screengrab/lib
+- sigh/lib
 - cert/lib
-- scan/lib
-- spaceship/lib
-- pem/lib
-- credentials_manager/lib
 required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="