fastlane 2.114.0.beta.20190108200048 → 2.114.0.beta.20190109200053

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: feed8ba2b3bc085a57282cf9aedecd3f39ce114f
-  data.tar.gz: ea73f53da8df3a8f5cb73a118da36a7704737c5d
+  metadata.gz: a73ead0de5efc0718340251a5bdd378228eae2a8
+  data.tar.gz: 2f4ba76bd4e4ac058ad99aff90af961fc240930b
 SHA512:
-  metadata.gz: deaedcca1136b1d6577da61c2604020c3e09f29075cb9a38b8c91dc6cca1df408286a53eaf41246154f2f459a92eefd93ef78d618ae0ad2f206197d7e69049f0
-  data.tar.gz: aebaef0f88a44be2135df61a59879354e0ff85200e29a1e8ce57149b126cb0703fb0bfdf6c003a201cdd845f4c9412035976d1a47d7a67a1a994f68392d8ea4e
+  metadata.gz: a7f0d58368481d30fa79bb99149ee25f7106997c37bd243d12565e89d3202b380e605827590117d885178c5015b48b884e3b38408aa5eb81c5468a67b310f765
+  data.tar.gz: 05e195103651240363101d5f11b0b708933af9ee74ff496c4ddac369e29b01c6b57bd3d6c672d6d8606e655391ad247764ed4202a383a27f10b8e94e9cf1e6be

data/fastlane/lib/fastlane/actions/crashlytics.rb

@@ -6,24 +6,31 @@ module Fastlane
         params[:emails] = params[:emails].join(",") if params[:emails].kind_of?(Array)
 
         params.values # to validate all inputs before looking for the ipa/apk
+        tempfiles = []
 
         # We need to store notes in a file, because the crashlytics CLI (iOS) says so
         if params[:notes]
           UI.error("Overwriting :notes_path, because you specified :notes") if params[:notes_path]
 
-          params[:notes_path] = Helper::CrashlyticsHelper.write_to_tempfile(params[:notes], 'changelog').path
+          changelog = Helper::CrashlyticsHelper.write_to_tempfile(params[:notes], 'changelog')
+          tempfiles << changelog
+          params[:notes_path] = changelog.path
         elsif Actions.lane_context[SharedValues::FL_CHANGELOG] && !params[:notes_path]
           UI.message("Sending FL_CHANGELOG as release notes to Beta by Crashlytics")
 
-          params[:notes_path] = Helper::CrashlyticsHelper.write_to_tempfile(
+          changelog = Helper::CrashlyticsHelper.write_to_tempfile(
             Actions.lane_context[SharedValues::FL_CHANGELOG], 'changelog'
-          ).path
+          )
+          tempfiles << changelog
+          params[:notes_path] = changelog.path
         end
 
         if params[:ipa_path]
           command = Helper::CrashlyticsHelper.generate_ios_command(params)
         elsif params[:apk_path]
-          command = Helper::CrashlyticsHelper.generate_android_command(params)
+          android_manifest = Helper::CrashlyticsHelper.generate_android_manifest_tempfile
+          tempfiles << android_manifest
+          command = Helper::CrashlyticsHelper.generate_android_command(params, android_manifest.path)
         else
           UI.user_error!("You have to either pass an ipa or an apk file to the Crashlytics action")
         end
@@ -49,6 +56,7 @@ module Fastlane
           error_callback: error_callback
         )
 
+        tempfiles.each(&:unlink)
         return command if Helper.test?
 
         UI.verbose(sanitizer.call(result)) if FastlaneCore::Globals.verbose?

data/fastlane/lib/fastlane/actions/update_info_plist.rb

@@ -14,6 +14,7 @@ module Fastlane
 
           # Assign folder from parameter or search for xcodeproj file
           folder = params[:xcodeproj] || Dir["*.xcodeproj"].first
+          UI.user_error!("Could not figure out your xcodeproj path. Please specify it using the `xcodeproj` parameter") if folder.nil?
 
           if params[:scheme]
             project = Xcodeproj::Project.open(folder)

data/fastlane/lib/fastlane/helper/crashlytics_helper.rb

@@ -56,13 +56,7 @@ module Fastlane
           return command
         end
 
-        def generate_android_command(params)
-          # We have to generate an empty XML file to make the crashlytics CLI happy :)
-          require 'tempfile'
-          xml = Tempfile.new('xml')
-          xml.write('<?xml version="1.0" encoding="utf-8"?><manifest></manifest>')
-          xml.close
-
+        def generate_android_command(params, android_manifest_path)
           params[:crashlytics_path] = download_android_tools unless params[:crashlytics_path]
 
           UI.user_error!("The `crashlytics_path` must be a jar file for Android") unless params[:crashlytics_path].end_with?(".jar") || Helper.test?
@@ -77,7 +71,7 @@ module Fastlane
           command << "-apiKey #{params[:api_token]}"
           command << "-apiSecret #{params[:build_secret]}"
           command << "-uploadDist #{File.expand_path(params[:apk_path]).shellescape}"
-          command << "-androidManifest #{xml.path.shellescape}"
+          command << "-androidManifest #{File.expand_path(android_manifest_path).shellescape}"
 
           # Optional
           command << "-betaDistributionEmails #{params[:emails].shellescape}" if params[:emails]
@@ -124,6 +118,11 @@ module Fastlane
           return jar_path
         end
 
+        def generate_android_manifest_tempfile
+          # We have to generate an empty XML file to make the crashlytics CLI happy :)
+          write_to_tempfile('<?xml version="1.0" encoding="utf-8"?><manifest></manifest>', 'xml')
+        end
+
         def write_to_tempfile(value, tempfilename)
           require 'tempfile'
 

data/fastlane/lib/fastlane/version.rb

@@ -1,5 +1,5 @@
 module Fastlane
-  VERSION = '2.114.0.beta.20190108200048'.freeze
+  VERSION = '2.114.0.beta.20190109200053'.freeze
   DESCRIPTION = "The easiest way to automate beta deployments and releases for your iOS and Android apps".freeze
   MINIMUM_XCODE_RELEASE = "7.0".freeze
   RUBOCOP_REQUIREMENT = '0.49.1'.freeze

data/spaceship/lib/spaceship/spaceauth_runner.rb

@@ -57,6 +57,16 @@ module Spaceship
       puts("")
       puts("Example:")
       puts("export FASTLANE_SESSION='#{yaml}'".cyan.underline)
+
+      if mac? && Spaceship::Client::UserInterface.interactive? && agree("🙄 Should fastlane copy the cookie into your clipboard, so you can easily paste it? (y/n)", true)
+        require 'open3'
+        Open3.popen3('pbcopy') { |input, _, _| input << yaml }
+        puts("Successfully copied text into your clipboard 🎨".green)
+      end
+    end
+
+    def mac?
+      (/darwin/ =~ RUBY_PLATFORM) != nil
     end
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: fastlane
 version: !ruby/object:Gem::Version
-  version: 2.114.0.beta.20190108200048
+  version: 2.114.0.beta.20190109200053
 platform: ruby
 authors:
 - Stefan Natchev
@@ -27,7 +27,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-01-08 00:00:00.000000000 Z
+date: 2019-01-09 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: slack-notifier
@@ -1682,24 +1682,24 @@ metadata:
 post_install_message: 
 rdoc_options: []
 require_paths:
+- sigh/lib
+- deliver/lib
+- gym/lib
+- cert/lib
 - scan/lib
-- screengrab/lib
-- precheck/lib
-- snapshot/lib
-- pilot/lib
-- pem/lib
 - supply/lib
+- produce/lib
 - match/lib
-- frameit/lib
-- gym/lib
+- pem/lib
+- pilot/lib
+- screengrab/lib
+- fastlane_core/lib
 - spaceship/lib
-- deliver/lib
-- produce/lib
-- credentials_manager/lib
-- cert/lib
+- snapshot/lib
+- precheck/lib
+- frameit/lib
 - fastlane/lib
-- fastlane_core/lib
-- sigh/lib
+- credentials_manager/lib
 required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="