fastlane 2.102.0 → 2.103.0

data/fastlane/swift/Gymfile.swift

@@ -18,4 +18,4 @@ class Gymfile: GymfileProtocol {
 
 
 
-// Generated with fastlane 2.102.0
+// Generated with fastlane 2.103.0

data/fastlane/swift/Matchfile.swift

@@ -18,4 +18,4 @@ class Matchfile: MatchfileProtocol {
 
 
 
-// Generated with fastlane 2.102.0
+// Generated with fastlane 2.103.0

data/fastlane/swift/Precheckfile.swift

@@ -18,4 +18,4 @@ class Precheckfile: PrecheckfileProtocol {
 
 
 
-// Generated with fastlane 2.102.0
+// Generated with fastlane 2.103.0

data/fastlane/swift/Scanfile.swift

@@ -18,4 +18,4 @@ class Scanfile: ScanfileProtocol {
 
 
 
-// Generated with fastlane 2.102.0
+// Generated with fastlane 2.103.0

data/fastlane/swift/Screengrabfile.swift

@@ -18,4 +18,4 @@ class Screengrabfile: ScreengrabfileProtocol {
 
 
 
-// Generated with fastlane 2.102.0
+// Generated with fastlane 2.103.0

data/fastlane/swift/Snapshotfile.swift

@@ -18,4 +18,4 @@ class Snapshotfile: SnapshotfileProtocol {
 
 
 
-// Generated with fastlane 2.102.0
+// Generated with fastlane 2.103.0

data/fastlane_core/lib/fastlane_core/command_executor.rb

@@ -49,23 +49,18 @@ module FastlaneCore
 
         begin
           status = FastlaneCore::FastlanePty.spawn(command) do |command_stdout, command_stdin, pid|
-            begin
-              command_stdout.each do |l|
-                line = l.strip # strip so that \n gets removed
-                output << line
+            command_stdout.each do |l|
+              line = l.strip # strip so that \n gets removed
+              output << line
 
-                next unless print_all
+              next unless print_all
 
-                # Prefix the current line with a string
-                prefix.each do |element|
-                  line = element[:prefix] + line if element[:block] && element[:block].call(line)
-                end
-
-                UI.command_output(line)
+              # Prefix the current line with a string
+              prefix.each do |element|
+                line = element[:prefix] + line if element[:block] && element[:block].call(line)
               end
-            rescue Errno::EIO
-              # This is expected on some linux systems, that indicates that the subcommand finished
-              # and we kept trying to read, ignore it
+
+              UI.command_output(line)
             end
           end
         rescue => ex

data/fastlane_core/lib/fastlane_core/fastlane_pty.rb

@@ -3,13 +3,22 @@
 # https://github.com/DragonBox/u3d/blob/59e471ad78ac00cb629f479dbe386c5ad2dc5075/lib/u3d_core/command_runner.rb#L88-L96
 module FastlaneCore
   class FastlanePty
-    def self.spawn(command, &block)
+    def self.spawn(command)
       require 'pty'
       PTY.spawn(command) do |command_stdout, command_stdin, pid|
         begin
-          block.call(command_stdout, command_stdin, pid)
+          yield(command_stdout, command_stdin, pid)
+        rescue Errno::EIO
+          # Exception ignored intentionally.
+          # https://stackoverflow.com/questions/10238298/ruby-on-linux-pty-goes-away-without-eof-raises-errnoeio
+          # This is expected on some linux systems, that indicates that the subcommand finished
+          # and we kept trying to read, ignore it
         ensure
-          Process.wait(pid)
+          begin
+            Process.wait(pid)
+          rescue Errno::ECHILD, PTY::ChildExited
+            # The process might have exited.
+          end
         end
       end
       $?.exitstatus

data/fastlane_core/lib/fastlane_core/helper.rb

@@ -193,22 +193,34 @@ module FastlaneCore
 
     # @return the full path to the iTMSTransporter executable
     def self.transporter_path
-      return File.join(self.itms_path, 'bin', 'iTMSTransporter')
+      return File.join(self.itms_path, 'bin', 'iTMSTransporter') unless Helper.windows?
+      return File.join(self.itms_path, 'iTMSTransporter')
     end
 
     # @return the full path to the iTMSTransporter executable
     def self.itms_path
       return ENV["FASTLANE_ITUNES_TRANSPORTER_PATH"] if FastlaneCore::Env.truthy?("FASTLANE_ITUNES_TRANSPORTER_PATH")
-      return '' unless self.mac? # so tests work on Linux and Windows too
-
-      [
-        "../Applications/Application Loader.app/Contents/MacOS/itms",
-        "../Applications/Application Loader.app/Contents/itms"
-      ].each do |path|
-        result = File.expand_path(File.join(self.xcode_path, path))
-        return result if File.exist?(result)
+
+      if self.mac?
+        [
+          "../Applications/Application Loader.app/Contents/MacOS/itms",
+          "../Applications/Application Loader.app/Contents/itms"
+        ].each do |path|
+          result = File.expand_path(File.join(self.xcode_path, path))
+          return result if File.exist?(result)
+        end
+        UI.user_error!("Could not find transporter at #{self.xcode_path}. Please make sure you set the correct path to your Xcode installation.")
+      elsif self.windows?
+        [
+          "C:/Program Files (x86)/itms"
+        ].each do |path|
+          return path if File.exist?(path)
+        end
+        UI.user_error!("Could not find transporter at usual locations. Please use environment variable `FASTLANE_ITUNES_TRANSPORTER_PATH` to specify your installation path.")
+      else
+        # not Mac or Windows
+        return ''
       end
-      UI.user_error!("Could not find transporter at #{self.xcode_path}. Please make sure you set the correct path to your Xcode installation.")
     end
 
     # keychain

data/fastlane_core/lib/fastlane_core/ipa_upload_package_builder.rb

@@ -21,7 +21,7 @@ module FastlaneCore
         apple_id: app_id,
         file_size: File.size(ipa_path),
         ipa_path: File.basename(ipa_path), # this is only the base name as the ipa is inside the package
-        md5: Digest::MD5.hexdigest(File.read(ipa_path)),
+        md5: Digest::MD5.file(ipa_path).hexdigest,
         archive_type: "bundle",
         platform: (platform || "ios") # pass "appletvos" for Apple TV's IPA
       }

data/fastlane_core/lib/fastlane_core/itunes_transporter.rb

@@ -52,24 +52,18 @@ module FastlaneCore
       end
 
       begin
-        FastlaneCore::FastlanePty.spawn(command) do |command_stdout, command_stdin, pid|
+        exit_status = FastlaneCore::FastlanePty.spawn(command) do |command_stdout, command_stdin, pid|
           begin
             command_stdout.each do |line|
               @all_lines << line
               parse_line(line, hide_output) # this is where the parsing happens
             end
-          rescue Errno::EIO
-            # Exception ignored intentionally.
-            # https://stackoverflow.com/questions/10238298/ruby-on-linux-pty-goes-away-without-eof-raises-errnoeio
-          ensure
-            Process.wait(pid)
           end
         end
       rescue => ex
         @errors << ex.to_s
       end
 
-      exit_status = $?.exitstatus
       unless exit_status.zero?
         @errors << "The call to the iTMSTransporter completed with a non-zero exit status: #{exit_status}. This indicates a failure."
       end
@@ -165,10 +159,11 @@ module FastlaneCore
         "-m upload",
         "-u \"#{username}\"",
         "-p #{shell_escaped_password(password)}",
-        "-f '#{source}'",
+        "-f \"#{source}\"",
         ENV["DELIVER_ITMSTRANSPORTER_ADDITIONAL_UPLOAD_PARAMETERS"], # that's here, because the user might overwrite the -t option
-        "-t 'Signiant'",
+        "-t Signiant",
         "-k 100000",
+        ("-WONoPause true" if Helper.windows?), # Windows only: process instantly returns instead of waiting for key press
         ("-itc_provider #{provider_short_name}" unless provider_short_name.to_s.empty?)
       ].compact.join(' ')
     end
@@ -187,13 +182,16 @@ module FastlaneCore
 
     def handle_error(password)
       # rubocop:disable Style/CaseEquality
-      unless password === /^[0-9a-zA-Z\.\$\_]*$/
+      # rubocop:disable Style/YodaCondition
+      unless /^[0-9a-zA-Z\.\$\_\-]*$/ === password
         UI.error([
           "Password contains special characters, which may not be handled properly by iTMSTransporter.",
           "If you experience problems uploading to App Store Connect, please consider changing your password to something with only alphanumeric characters."
         ].join(' '))
       end
       # rubocop:enable Style/CaseEquality
+      # rubocop:enable Style/YodaCondition
+
       UI.error("Could not download/upload from App Store Connect! It's probably related to your password or your internet connection.")
     end
 
@@ -210,8 +208,11 @@ module FastlaneCore
         "'\"\\'\"'"
       end
 
-      # wrap the fully-escaped password in single quotes, since the transporter expects a escaped password string (which must be single-quoted for the shell's benefit)
-      "'" + password + "'"
+      # wrap the fully-escaped password in single quotes, since the transporter expects a escaped password string
+      # (which must be single-quoted for the shell's benefit [on non-Windows platforms])
+      password = "'" + password + "'" unless Helper.windows?
+
+      password
     end
   end
 
@@ -314,8 +315,9 @@ module FastlaneCore
     #                            short names
     def initialize(user = nil, password = nil, use_shell_script = false, provider_short_name = nil)
       # Xcode 6.x doesn't have the same iTMSTransporter Java setup as later Xcode versions, so
-      # we can't default to using the better direct Java invocation strategy for those versions.
-      use_shell_script ||= Helper.xcode_version.start_with?('6.')
+      # we can't default to using the newer direct Java invocation strategy for those versions.
+      use_shell_script ||= Helper.is_mac? && Helper.xcode_version.start_with?('6.')
+      use_shell_script ||= Helper.windows?
       use_shell_script ||= Feature.enabled?('FASTLANE_ITUNES_TRANSPORTER_USE_SHELL_SCRIPT')
 
       @user = user
@@ -419,8 +421,11 @@ module FastlaneCore
     def handle_two_step_failure(ex)
       if ENV[TWO_FACTOR_ENV_VARIABLE].to_s.length > 0
         # Password provided, however we already used it
-        UI.error("Application specific password you provided using #{TWO_FACTOR_ENV_VARIABLE}")
+        UI.error("")
+        UI.error("Application specific password you provided using")
+        UI.error("environment variable #{TWO_FACTOR_ENV_VARIABLE}")
         UI.error("is invalid, please make sure it's correct")
+        UI.error("")
         UI.user_error!("Invalid application specific password provided")
       end
 
@@ -433,10 +438,12 @@ module FastlaneCore
         UI.error("Please make sure to follow the instructions")
         a.remove_from_keychain
       end
+      UI.error("")
       UI.error("Your account has 2 step verification enabled")
       UI.error("Please go to https://appleid.apple.com/account/manage")
       UI.error("and generate an application specific password for")
       UI.error("the iTunes Transporter, which is used to upload builds")
+      UI.error("")
       UI.error("To set the application specific password on a CI machine using")
       UI.error("an environment variable, you can set the")
       UI.error("#{TWO_FACTOR_ENV_VARIABLE} variable")

data/pilot/lib/pilot/build_manager.rb

@@ -18,7 +18,7 @@ module Pilot
 
       if options[:changelog].nil? && options[:distribute_external] == true
         if UI.interactive?
-          options[:changelog] = UI.input("No changelog provided for new build. Please provide a changelog. You can also provide a changelog using the `changelog` option")
+          options[:changelog] = UI.input("No changelog provided for new build. You can provide a changelog using the `changelog` option. For now, please provide a changelog here:")
         else
           UI.user_error!("No changelog provided for new build. Please either disable `distribute_external` or provide a changelog using the `changelog` option")
         end

data/pilot/lib/pilot/tester_importer.rb

@@ -42,8 +42,8 @@ module Pilot
         begin
           tester_manager.add_tester(config)
           imported_tester_count += 1
-        rescue
-          # do nothing, move on to the next row
+        rescue => exception
+          UI.error("Error adding tester #{email}: #{exception}")
         end
       end
 

data/precheck/lib/precheck/rules/unreachable_urls_rule.rb

@@ -29,13 +29,13 @@ module Precheck
         begin
           uri = Addressable::URI.parse(url)
           uri.fragment = nil
-          request = Faraday.new(URI.encode(uri.to_s)) do |connection|
+          request = Faraday.new(uri.normalize.to_s) do |connection|
             connection.use(FaradayMiddleware::FollowRedirects)
             connection.adapter(:net_http)
           end
           return RuleReturn.new(validation_state: Precheck::VALIDATION_STATES[:failed], failure_data: url) unless request.head.status == 200
-        rescue
-          UI.verbose("URL #{url} not reachable 😵")
+        rescue StandardError => e
+          UI.verbose("URL #{url} not reachable 😵: #{e.message}")
           # I can only return :fail here, but I also want to return #{url}
           return RuleReturn.new(validation_state: VALIDATION_STATES[:failed], failure_data: "unreachable: #{url}")
         end

data/produce/lib/produce/cloud_container.rb

@@ -0,0 +1,82 @@
+require 'spaceship'
+require_relative 'module'
+
+module Produce
+  class CloudContainer
+    def create(options, _args)
+      login
+
+      container_identifier = options.container_identifier || UI.input("iCloud Container identifier: ")
+
+      if container_exists?(container_identifier)
+        UI.success("[DevCenter] iCloud Container '#{options.container_name} (#{options.container_identifier})' already exists, nothing to do on the Dev Center")
+        # Nothing to do here
+      else
+        container_name = options.container_name || container_identifier.gsub('.', ' ')
+
+        UI.success("Creating new iCloud Container '#{container_name}' with identifier '#{container_identifier}' on the Apple Dev Center")
+
+        container = Spaceship.cloud_container.create!(identifier: container_identifier, name: container_name)
+
+        if container.name != container_name
+          UI.important("Your container name includes non-ASCII characters, which are not supported by the Apple Developer Portal.")
+          UI.important("To fix this a unique (internal) name '#{container.name}' has been created for you.")
+        end
+
+        UI.message("Created iCloud Container #{container.cloud_container}")
+        UI.user_error!("Something went wrong when creating the new iCloud Container - it's not listed in the iCloud Container list") unless container_exists?(container_identifier)
+        UI.success("Finished creating new iCloud Container '#{container_name}' on the Dev Center")
+      end
+
+      return true
+    end
+
+    def associate(_options, args)
+      login
+
+      if !app_exists?
+        UI.message("[DevCenter] App '#{Produce.config[:app_identifier]}' does not exist, nothing to associate with the containers")
+      else
+        app = Spaceship.app.find(app_identifier)
+        UI.user_error!("Something went wrong when fetching the app - it's not listed in the apps list") if app.nil?
+
+        new_containers = []
+
+        UI.message("Validating containers before association")
+
+        args.each do |container_identifier|
+          if !container_exists?(container_identifier)
+            UI.message("[DevCenter] iCloud Container '#{container_identifier}' does not exist, please create it first, skipping for now")
+          else
+            new_containers.push(Spaceship.cloud_container.find(container_identifier))
+          end
+        end
+
+        UI.message("Finalising association with #{new_containers.count} containers")
+        app.associate_cloud_containers(new_containers)
+        UI.success("Done!")
+      end
+
+      return true
+    end
+
+    def login
+      UI.message("Starting login with user '#{Produce.config[:username]}'")
+      Spaceship.login(Produce.config[:username], nil)
+      Spaceship.select_team
+      UI.message("Successfully logged in")
+    end
+
+    def app_identifier
+      Produce.config[:app_identifier].to_s
+    end
+
+    def container_exists?(identifier)
+      Spaceship.cloud_container.find(identifier) != nil
+    end
+
+    def app_exists?
+      Spaceship.app.find(app_identifier) != nil
+    end
+  end
+end

data/produce/lib/produce/commands_generator.rb

@@ -152,6 +152,40 @@ module Produce
         end
       end
 
+      command :cloud_container do |c|
+        c.syntax = 'fastlane produce cloud_container'
+        c.description = 'Ensure that a specific iCloud Container exists'
+        c.example('Create iCloud Container', 'fastlane produce cloud_container -g iCloud.com.example.app -n "Example iCloud Container"')
+
+        c.option('-n', '--container_name STRING', String, 'Name for the iCloud Container that is created (PRODUCE_CLOUD_CONTAINER_NAME)')
+        c.option('-g', '--container_identifier STRING', String, 'Identifier for the iCloud Container (PRODUCE_CLOUD_CONTAINER_IDENTIFIER')
+
+        FastlaneCore::CommanderGenerator.new.generate(Produce::Options.available_options, command: c)
+
+        c.action do |args, options|
+          allowed_keys = Produce::Options.available_options.collect(&:key)
+          Produce.config = FastlaneCore::Configuration.create(Produce::Options.available_options, options.__hash__.select { |key, value| allowed_keys.include?(key) })
+
+          require 'produce/cloud_container'
+          Produce::CloudContainer.new.create(options, args)
+        end
+      end
+
+      command :associate_cloud_container do |c|
+        c.syntax = 'fastlane produce associate_cloud_container -a APP_IDENTIFIER CONTAINER_IDENTIFIER1, CONTAINER_IDENTIFIER2, ...'
+        c.description = 'Associate with a iCloud Container, which is created if needed or simply located otherwise'
+        c.example('Associate with iCloud Container', 'fastlane produce associate_cloud_container -a com.example.app iCloud.com.example.com')
+
+        FastlaneCore::CommanderGenerator.new.generate(Produce::Options.available_options, command: c)
+
+        c.action do |args, options|
+          Produce.config = FastlaneCore::Configuration.create(Produce::Options.available_options, options.__hash__)
+
+          require 'produce/cloud_container'
+          Produce::CloudContainer.new.associate(options, args)
+        end
+      end
+
       command :merchant do |c|
         c.syntax = 'fastlane produce merchant'
         c.description = 'Ensure that a specific Merchant exists'

data/produce/lib/produce/itunes_connect.rb

@@ -18,7 +18,7 @@ module Produce
     def create_new_app
       application = fetch_application
       if application
-        UI.success("[iTC] App '#{Produce.config[:app_identifier]}' already exists (#{application.apple_id}), nothing to do on App Store Connect")
+        UI.success("App '#{Produce.config[:app_identifier]}' already exists (#{application.apple_id}), nothing to do on App Store Connect")
         # Nothing to do here
       else
         UI.success("Creating new app '#{Produce.config[:app_name]}' on App Store Connect")

data/snapshot/lib/snapshot/commands_generator.rb

@@ -50,8 +50,6 @@ module Snapshot
           path = Snapshot::Helper.fastlane_enabled? ? FastlaneCore::FastlaneFolder.path : '.'
           is_swift_fastfile = args.include?("swift")
           Snapshot::Setup.create(path, is_swift_fastfile: is_swift_fastfile)
-          # We do this outside of `Setup`, as it shouldn't be part of `fastlane init`
-          puts("More information: https://docs.fastlane.tools/getting-started/ios/screenshots/".green)
         end
       end