fastlane 1.94.0 → 1.94.1

data/lib/fastlane/actions/slack.rb

@@ -4,7 +4,6 @@
 module Fastlane
   module Actions
     class SlackAction < Action
-
       def self.is_supported?(platform)
         true
       end

data/lib/fastlane/actions/slather.rb

@@ -105,8 +105,7 @@ Slather is available at https://github.com/SlatherOrg/slather
           FastlaneCore::ConfigItem.new(key: :build_directory,
                                        env_name: "FL_SLATHER_BUILD_DIRECTORY", # The name of the environment variable
                                        description: "The location of the build output", # a short description of this parameter
-                                       optional: true
-                                      ),
+                                       optional: true),
           FastlaneCore::ConfigItem.new(key: :proj,
                                        env_name: "FL_SLATHER_PROJ", # The name of the environment variable
                                        description: "The project file that slather looks at", # a short description of this parameter
@@ -117,18 +116,15 @@ Slather is available at https://github.com/SlatherOrg/slather
           FastlaneCore::ConfigItem.new(key: :workspace,
                                        env_name: "FL_SLATHER_WORKSPACE",
                                        description: "The workspace that slather looks at",
-                                       optional: true
-                                      ),
+                                       optional: true),
           FastlaneCore::ConfigItem.new(key: :scheme,
                                        env_name: "FL_SLATHER_SCHEME", # The name of the environment variable
                                        description: "Scheme to use when calling slather",
-                                       optional: true
-                                      ),
+                                       optional: true),
           FastlaneCore::ConfigItem.new(key: :input_format,
                                        env_name: "FL_SLATHER_INPUT_FORMAT", # The name of the environment variable
                                        description: "The input format that slather should look for",
-                                       optional: true
-                                      ),
+                                       optional: true),
           FastlaneCore::ConfigItem.new(key: :buildkite,
                                        env_name: "FL_SLATHER_BUILDKITE_ENABLED", # The name of the environment variable
                                        description: "Tell slather that it is running on Buildkite",

data/lib/fastlane/actions/ssh.rb

@@ -6,7 +6,7 @@ module Fastlane
     end
 
     class SshAction < Action
-      def self.ssh_exec!(ssh, command)
+      def self.ssh_exec!(ssh, command, log = true)
         stdout_data = ""
         stderr_data = ""
         exit_code = nil
@@ -18,10 +18,13 @@ module Fastlane
             end
             channel.on_data do |ch1, data|
               stdout_data += data
+              UI.command_output(data) if log
             end
 
             channel.on_extended_data do |ch2, type, data|
-              stderr_data += data
+              # Only type 1 data is stderr (though no other types are defined by the standard)
+              # See http://net-ssh.github.io/net-ssh/Net/SSH/Connection/Channel.html#method-i-on_extended_data
+              stderr_data += data if type == 1
             end
 
             channel.on_request("exit-status") do |ch3, data|
@@ -33,8 +36,10 @@ module Fastlane
             end
           end
         end
+
+        # Wait for all open channels to close
         ssh.loop
-        {stdout: stdout_data, stderr: stderr_data, exit_code: exit_code, exit_signal: exit_signal}
+        { stdout: stdout_data, stderr: stderr_data, exit_code: exit_code, exit_signal: exit_signal }
       end
 
       def self.run(params)
@@ -46,22 +51,24 @@ module Fastlane
         stdout = ""
         stderr = ""
 
-        Net::SSH.start(params[:host], params[:username], {port: params[:port].to_i, password: params[:password]}) do |ssh|
+        Net::SSH.start(params[:host], params[:username], { port: params[:port].to_i, password: params[:password] }) do |ssh|
           params[:commands].each do |cmd|
-            UI.important(['[SSH COMMAND]', cmd].join(': ')) if params[:log]
-            return_value = ssh_exec!(ssh, cmd)
-            UI.error("SSH Command failed '#{cmd}' Exit-Code: #{return_value[:exit_code]}") if return_value[:exit_code] > 0
-            UI.user_error!("SSH Command failed") if return_value[:exit_code] > 0
+            UI.command(cmd) if params[:log]
+            return_value = ssh_exec!(ssh, cmd, params[:log])
+            if return_value[:exit_code] != 0
+              UI.error("SSH Command failed '#{cmd}' Exit-Code: #{return_value[:exit_code]}")
+              UI.user_error!("SSH Command failed")
+            end
 
             stderr << return_value[:stderr]
             stdout << return_value[:stdout]
           end
         end
-        UI.message("Succesfully executed #{params[:commands].count} commands on host: #{params[:host]}")
-        UI.message("\n########### \n #{stdout} \n###############".magenta) if params[:log]
+        command_word = params[:commands].count == 1 ? "command" : "commands"
+        UI.success("Succesfully executed #{params[:commands].count} #{command_word} on host #{params[:host]}")
         Actions.lane_context[SharedValues::SSH_STDOUT_VALUE] = stdout
         Actions.lane_context[SharedValues::SSH_STDERR_VALUE] = stderr
-        return {stdout: Actions.lane_context[SharedValues::SSH_STDOUT_VALUE], stderr: Actions.lane_context[SharedValues::SSH_STDERR_VALUE]}
+        return { stdout: Actions.lane_context[SharedValues::SSH_STDOUT_VALUE], stderr: Actions.lane_context[SharedValues::SSH_STDERR_VALUE] }
       end
 
       #####################################################
@@ -82,52 +89,46 @@ module Fastlane
                                        short_option: "-u",
                                        env_name: "FL_SSH_USERNAME",
                                        description: "Username",
-                                       is_string: true
-                                      ),
+                                       is_string: true),
           FastlaneCore::ConfigItem.new(key: :password,
                                        short_option: "-p",
                                        env_name: "FL_SSH_PASSWORD",
                                        description: "Password",
                                        optional: true,
-                                       is_string: true
-                                      ),
+                                       is_string: true),
           FastlaneCore::ConfigItem.new(key: :host,
                                        short_option: "-H",
                                        env_name: "FL_SSH_HOST",
                                        description: "Hostname",
-                                       is_string: true
-                                      ),
+                                       is_string: true),
           FastlaneCore::ConfigItem.new(key: :port,
                                        short_option: "-P",
                                        env_name: "FL_SSH_PORT",
                                        description: "Port",
                                        optional: true,
                                        default_value: "22",
-                                       is_string: true
-                                      ),
+                                       is_string: true),
           FastlaneCore::ConfigItem.new(key: :commands,
                                        short_option: "-C",
                                        env_name: "FL_SSH_COMMANDS",
                                        description: "Commands",
                                        optional: true,
                                        is_string: false,
-                                       type: Array
-                                      ),
+                                       type: Array),
           FastlaneCore::ConfigItem.new(key: :log,
                                        short_option: "-l",
                                        env_name: "FL_SSH_LOG",
-                                       description: "Log Commands",
+                                       description: "Log commands and output",
                                        optional: true,
                                        default_value: true,
-                                       is_string: false
-                                      )
+                                       is_string: false)
         ]
       end
 
       def self.output
         [
-          ['SSH_STDOUT_VALUE', 'Holds the standard-output of all commands'],
-          ['SSH_STDERR_VALUE', 'Holds the standard-error of all commands']
+          ['SSH_STDOUT_VALUE', 'Holds the standard output of all commands'],
+          ['SSH_STDERR_VALUE', 'Holds the standard error of all commands']
         ]
       end
 

data/lib/fastlane/actions/tryouts.rb

@@ -5,7 +5,6 @@ module Fastlane
       TRYOUTS_BUILD_INFORMATION = :TRYOUTS_BUILD_INFORMATION
     end
     class TryoutsAction < Action
-
       TRYOUTS_API_BUILD_RELEASE_TEMPLATE = "https://api.tryouts.io/v1/applications/%s/releases/"
 
       def self.run(params)

data/lib/fastlane/actions/twitter.rb

@@ -31,32 +31,27 @@ module Fastlane
                                        env_name: "FL_TW_CONSUMER_KEY",
                                        description: "Consumer Key",
                                        is_string: true,
-                                       optional: false
-                                      ),
+                                       optional: false),
           FastlaneCore::ConfigItem.new(key: :consumer_secret,
                                        env_name: "FL_TW_CONSUMER_SECRET",
                                        description: "Consumer Secret",
                                        is_string: true,
-                                       optional: false
-                                      ),
+                                       optional: false),
           FastlaneCore::ConfigItem.new(key: :access_token,
                                        env_name: "FL_TW_ACCESS_TOKEN",
                                        description: "Access Token",
                                        is_string: true,
-                                       optional: false
-                                      ),
+                                       optional: false),
           FastlaneCore::ConfigItem.new(key: :access_token_secret,
                                        env_name: "FL_TW_ACCESS_TOKEN_SECRET",
                                        description: "Access Token Secret",
                                        is_string: true,
-                                       optional: false
-                                      ),
+                                       optional: false),
           FastlaneCore::ConfigItem.new(key: :message,
                                        env_name: "FL_TW_MESSAGE",
                                        description: "The tweet",
                                        is_string: true,
-                                       optional: false
-                                      )
+                                       optional: false)
 
         ]
       end

data/lib/fastlane/actions/typetalk.rb

@@ -36,8 +36,8 @@ module Fastlane
         require 'uri'
 
         uri = URI.parse("https://typetalk.in/api/v1/topics/#{topic_id}")
-        response = Net::HTTP.post_form(uri, {'message' => message,
-                                             'typetalkToken' => typetalk_token})
+        response = Net::HTTP.post_form(uri, { 'message' => message,
+                                             'typetalkToken' => typetalk_token })
 
         self.check_response(response)
       end

data/lib/fastlane/actions/update_fastlane.rb

@@ -5,7 +5,6 @@ module Fastlane
   module Actions
     # Makes sure fastlane tools are up-to-date when running fastlane
     class UpdateFastlaneAction < Action
-
       ALL_TOOLS = [
         "fastlane",
         "fastlane_core",

data/lib/fastlane/actions/upload_symbols_to_sentry.rb

@@ -17,7 +17,7 @@ module Fastlane
 
         # Url to post dSYMs to
         url = "#{host}/projects/#{org}/#{project}/files/dsyms/"
-        resource = RestClient::Resource.new( url, api_key, '' )
+        resource = RestClient::Resource.new(url, api_key, '')
 
         UI.message "Will upload dSYM(s) to #{url}"
 
@@ -64,8 +64,7 @@ module Fastlane
                                        description: "API host url for Sentry",
                                        is_string: true,
                                        default_value: "https://app.getsentry.com/api/0",
-                                       optional: true
-                                      ),
+                                       optional: true),
           FastlaneCore::ConfigItem.new(key: :api_key,
                                        env_name: "SENTRY_API_KEY",
                                        description: "API Key for Sentry",

data/lib/fastlane/actions/verify_build.rb

@@ -85,7 +85,7 @@ module Fastlane
             columns << key
             columns << case value
                        when Hash
-                         value.map {|k, v| "#{k}: #{v}"}.join("\n")
+                         value.map { |k, v| "#{k}: #{v}" }.join("\n")
                        when Array
                          value.join("\n")
                        else

data/lib/fastlane/actions/xcode_server_get_assets.rb

@@ -7,7 +7,6 @@ module Fastlane
     end
 
     class XcodeServerGetAssetsAction < Action
-
       require 'excon'
       require 'json'
       require 'fileutils'
@@ -108,7 +107,6 @@ module Fastlane
       end
 
       class XcodeServer
-
         def initialize(host, username, password)
           @host = host.start_with?('https://') ? host : "https://#{host}"
           @username = username
@@ -131,7 +129,7 @@ module Fastlane
         def fetch_assets(integration_id, target_folder, action)
           # create a temp folder and a file, stream the download into it
           Dir.mktmpdir do |dir|
-            temp_file = File.join(dir, "tmp_download.#{rand(1000000)}")
+            temp_file = File.join(dir, "tmp_download.#{rand(1_000_000)}")
             f = open(temp_file, 'w')
             streamer = lambda do |chunk, remaining_bytes, total_bytes|
               if remaining_bytes && total_bytes
@@ -149,7 +147,7 @@ module Fastlane
             UI.user_error!("Failed to fetch Assets zip for Integration #{integration_id} from Xcode Server at #{@host}, response: #{response.status}: #{response.body}") if response.status != 200
 
             # unzip it, it's a .tar.gz file
-            out_folder = File.join(dir, "out_#{rand(1000000)}")
+            out_folder = File.join(dir, "out_#{rand(1_000_000)}")
             FileUtils.mkdir_p(out_folder)
 
             action.sh "cd \"#{out_folder}\"; cat \"#{temp_file}\" | gzip -d | tar -x"

data/lib/fastlane/actions/xcversion.rb

@@ -26,8 +26,7 @@ module Fastlane
                                        env_name: "FL_XCODE_VERSION",
                                        description: "The version of Xcode to select specified as a Gem::Version requirement string (e.g. '~> 7.1.0')",
                                        optional: false,
-                                       verify_block: Helper::XcversionHelper::Verify.method(:requirement)
-                                      )
+                                       verify_block: Helper::XcversionHelper::Verify.method(:requirement))
         ]
       end
 

data/lib/fastlane/commands_generator.rb

@@ -27,7 +27,8 @@ module Fastlane
       program :description, [
         "CLI for 'fastlane' - #{Fastlane::DESCRIPTION}\n",
         "\tRun using `fastlane [platform] [lane_name]`",
-        "\tTo pass values to the lanes use `fastlane [platform] [lane_name] key:value key2:value2`"].join("\n")
+        "\tTo pass values to the lanes use `fastlane [platform] [lane_name] key:value key2:value2`"
+      ].join("\n")
       program :help, 'Author', 'Felix Krause <fastlane@krausefx.com>'
       program :help, 'Website', 'https://fastlane.tools'
       program :help, 'GitHub', 'https://github.com/fastlane/fastlane'

data/lib/fastlane/core_ext/bundler_monkey_patch.rb

@@ -3,12 +3,12 @@
 # There is an issue with Rubygems 2.6.2 where it attempts to call Bundler::SpecSet#size, which doesn't exist.
 # If a gem is not installed, a `Gem::Specification.find_by_name` call will trigger this problem.
 if Object.const_defined?(:Bundler) &&
-    Bundler.const_defined?(:SpecSet) &&
-    Bundler::SpecSet.instance_methods.include?(:length) &&
-    !Bundler::SpecSet.instance_methods.include?(:size)
+   Bundler.const_defined?(:SpecSet) &&
+   Bundler::SpecSet.instance_methods.include?(:length) &&
+   !Bundler::SpecSet.instance_methods.include?(:size)
   module Bundler
     class SpecSet
-      alias_method :size, :length
+      alias size length
     end
   end
 end

data/lib/fastlane/documentation/actions_list.rb

@@ -126,7 +126,7 @@ module Fastlane
 
     # Iterates through all available actions and yields from there
     def self.all_actions(platform = nil)
-      action_symbols = Fastlane::Actions.constants.select {|c| Fastlane::Actions.const_get(c).kind_of? Class }
+      action_symbols = Fastlane::Actions.constants.select { |c| Fastlane::Actions.const_get(c).kind_of? Class }
       action_symbols.sort.each do |symbol|
         action = Fastlane::Actions.const_get(symbol)
 

data/lib/fastlane/erb_template_helper.rb

@@ -16,7 +16,6 @@ module Fastlane
     def self.render(template, template_vars_hash)
       Fastlane::ErbalT.new(template_vars_hash).render(template)
     end
-
   end
   class ErbalT < OpenStruct
     def render(template)

data/lib/fastlane/helper/podspec_helper.rb

@@ -51,7 +51,7 @@ module Fastlane
         new_version = version || @version_value
         updated_podspec_content = @podspec_content.gsub(@version_regex, "#{@version_match[:begin]}#{new_version}#{@version_match[:end]}")
 
-        File.open(@path, "w") {|file| file.puts updated_podspec_content} unless Helper.test?
+        File.open(@path, "w") { |file| file.puts updated_podspec_content } unless Helper.test?
 
         updated_podspec_content
       end

data/lib/fastlane/one_off.rb

@@ -24,6 +24,8 @@ module Fastlane
     end
 
     def self.run(action: nil, parameters: nil)
+      Fastlane.load_actions
+
       class_name = action.fastlane_class + 'Action'
       class_ref = nil
       begin

data/lib/fastlane/plugins/plugin_info.rb

@@ -39,9 +39,9 @@ module Fastlane
 
     def ==(other)
       @plugin_name == other.plugin_name &&
-      @author == other.author &&
-      @email == other.email &&
-      @summary == other.summary
+        @author == other.author &&
+        @email == other.email &&
+        @summary == other.summary
     end
   end
 end

data/lib/fastlane/plugins/plugin_info_collector.rb

@@ -147,6 +147,5 @@ module Fastlane
     def summary_valid?(summary)
       !summary.to_s.strip.empty?
     end
-
   end
 end

data/lib/fastlane/plugins/template/.rubocop.yml

@@ -1,27 +1,32 @@
-
+# kind_of? is a good way to check a type
 Style/ClassCheck:
   EnforcedStyle: kind_of?
 
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle, SupportedStyles.
+# It's better to be more explicit about the type
 Style/BracesAroundHashParameters:
   Enabled: false
 
+# specs sometimes have useless assignments, which is fine
 Lint/UselessAssignment:
   Exclude:
     - '**/spec/**/*'
 
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle, SupportedStyles.
+# We could potentially enable the 2 below:
 Style/IndentHash:
   Enabled: false
 
-Style/RaiseArgs:
-  EnforcedStyle: exploded
+Style/AlignHash:
+  Enabled: false
+
+# HoundCI doesn't like this rule
+Style/DotPosition:
+  Enabled: false
 
+# We allow !! as it's an easy way to convert ot boolean
 Style/DoubleNegation:
   Enabled: false
 
+# Sometimes we allow a rescue block that doesn't contain code
 Lint/HandleExceptions:
   Enabled: false
 
@@ -33,33 +38,23 @@ Lint/UnusedBlockArgument:
 Style/GlobalVars:
   Enabled: false
 
-Style/FileName:
+# We want to allow class Fastlane::Class
+Style/ClassAndModuleChildren:
   Enabled: false
 
 # $? Exit
 Style/SpecialGlobalVars:
   Enabled: false
 
-Style/RaiseArgs:
-  Enabled: false
-
 Metrics/AbcSize:
-  Max: 63
+  Max: 60
   Exclude:
     - '**/lib/*/options.rb'
 
-# Both string notations are okay
-Style/StringLiterals:
-  Enabled: false
-
 # The %w might be confusing for new users
 Style/WordArray:
   MinSize: 19
 
-# Not a good thing
-Style/RedundantSelf:
-  Enabled: false
-
 # raise and fail are both okay
 Style/SignalException:
   Enabled: false
@@ -72,10 +67,6 @@ Style/RedundantReturn:
 Style/IfUnlessModifier:
   Enabled: false
 
-# That looks wrong
-Style/AlignHash:
-  Enabled: false
-
 # and and or is okay
 Style/AndOr:
   Enabled: false
@@ -98,16 +89,22 @@ Metrics/ParameterLists:
 Metrics/PerceivedComplexity:
   Max: 18
 
-Style/DotPosition:
-  Enabled: false
-
+# Sometimes it's easier to read without guards
 Style/GuardClause:
   Enabled: false
 
+# We allow both " and '
+Style/StringLiterals:
+  Enabled: false
 
+# something = if something_else
+# that's confusing
+Style/ConditionalAssignment:
+  Enabled: false
 
-# Split
-
+# Better to have too much self than missing a self
+Style/RedundantSelf:
+  Enabled: false
 
 # e.g.
 # def self.is_supported?(platform)
@@ -120,10 +117,15 @@ Lint/ParenthesesAsGroupedExpression:
   Exclude:
     - '**/spec/**/*'
 
+# This would reject is_ in front of methods
 # We use `is_supported?` everywhere already
 Style/PredicateName:
   Enabled: false
 
+# We allow the $
+Style/PerlBackrefs:
+  Enabled: false
+
 # Disable '+ should be surrounded with a single space' for xcodebuild_spec.rb
 Style/SpaceAroundOperators:
   Exclude:
@@ -134,7 +136,6 @@ Metrics/MethodLength:
     - '**/lib/fastlane/actions/*.rb'
     - '**/bin/fastlane'
     - '**/lib/*/options.rb'
-    - '**/bin/sigh'
   Max: 60
 
 AllCops:
@@ -142,146 +143,13 @@ AllCops:
     - '**/fastlane/Fastfile'
   Exclude:
     - '**/lib/assets/custom_action_template.rb'
+    - './vendor/**/*'
 
-##################
-# TODO
-##################
-
-# Offense count: 7
-# Configuration parameters: CountComments.
-Metrics/ClassLength:
-  Max: 320
-
-# Offense count: 4
-Metrics/CyclomaticComplexity:
-  Max: 17
-
-# Offense count: 489
-# Configuration parameters: AllowURI, URISchemes.
-Metrics/LineLength:
-  Max: 372
-
-# Offense count: 5
-# Configuration parameters: CountKeywordArgs.
-Metrics/ParameterLists:
-  Max: 17
-
-# Offense count: 3
-Metrics/PerceivedComplexity:
-  Max: 18
-
-# Offense count: 1
-# Cop supports --auto-correct.
-Style/Alias:
-  Enabled: false
-
-# Offense count: 14
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedHashRocketStyle, EnforcedColonStyle, EnforcedLastArgumentHashStyle, SupportedLastArgumentHashStyles.
-Style/AlignHash:
-  Enabled: false
-
-# Offense count: 22
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle, SupportedStyles.
-Style/AndOr:
-  Enabled: false
-
-# Offense count: 1
-# Configuration parameters: EnforcedStyle, SupportedStyles.
-Style/ClassAndModuleChildren:
-  Enabled: false
-
-# Offense count: 19
+# We're not there yet
 Style/Documentation:
   Enabled: false
 
-# Offense count: 112
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle, SupportedStyles.
-Style/DotPosition:
-  Enabled: false
-
-# Offense count: 12
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle, SupportedStyles.
-Style/EmptyLinesAroundClassBody:
-  Enabled: false
-
-# Configuration parameters: MinBodyLength.
-Style/GuardClause:
-  Enabled: false
-
-# Offense count: 4
-# Cop supports --auto-correct.
-# Configuration parameters: MaxLineLength.
-Style/IfUnlessModifier:
-  Enabled: false
-
-# Offense count: 74
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle, SupportedStyles.
-Style/MultilineOperationIndentation:
-  Enabled: false
-
-# Offense count: 10
-# Cop supports --auto-correct.
-Style/NumericLiterals:
-  MinDigits: 14
-
-# Offense count: 2
-# Cop supports --auto-correct.
-Style/PerlBackrefs:
-  Enabled: false
-
-# Offense count: 19
-# Cop supports --auto-correct.
-# Configuration parameters: AllowMultipleReturnValues.
-Style/RedundantReturn:
-  Enabled: false
-
-# Offense count: 77
-# Cop supports --auto-correct.
-Style/RedundantSelf:
-  Enabled: false
-
-# Offense count: 38
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle, SupportedStyles.
-Style/SignalException:
-  Enabled: false
-
-# Offense count: 5
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle, SupportedStyles, EnforcedStyleForEmptyBraces, SpaceBeforeBlockParameters.
-Style/SpaceInsideBlockBraces:
-  Enabled: false
-
-# Offense count: 291
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle, EnforcedStyleForEmptyBraces, SupportedStyles.
-Style/SpaceInsideHashLiteralBraces:
-  Enabled: false
-
-# Offense count: 8
-# Cop supports --auto-correct.
-Style/SpaceInsideParens:
-  Enabled: false
-
-# Offense count: 881
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle, SupportedStyles.
-Style/StringLiterals:
-  Enabled: false
-
-# Offense count: 9
-# Cop supports --auto-correct.
-# Configuration parameters: WordRegex.
-Style/WordArray:
-  MinSize: 19
-
 # Added after upgrade to 0.38.0
-
 Style/MutableConstant:
   Enabled: false
 
@@ -289,11 +157,6 @@ Style/MutableConstant:
 Style/ZeroLengthPredicate:
   Enabled: false
 
-Style/ConditionalAssignment:
-  Enabled: false
-
-Style/SpaceAroundKeyword:
-  Enabled: false
-
+# Adds complexity
 Style/IfInsideElse:
-  Enabled: false
+  Enabled: false