fastlane 1.91.0 → 1.92.0.beta1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: f1d4a4bff3477ad2e6df2b81a2ddcdfd577d7b4f
-  data.tar.gz: 75f1a9db251bbd7662503824567d4386a81bf7f6
+  metadata.gz: 11c062b639b48558f8a67f695822bd1221f686cc
+  data.tar.gz: 2c7f32bede228b71ad947f7588fbb90504444d92
 SHA512:
-  metadata.gz: 012b1ca9c1e9f7c9734db2beb69b4e6379b88efd676a6278a1a129388c7f06b837939fb75f2af592b267721f416ee84bc7b62f50fc8e506c32a7b7d1c87f5362
-  data.tar.gz: 600f5e8c1ca9f9309eda91fef62f47a2d9dbe66d10555eab8f99f9764067d1e5c76ef4bbaa52b145fdde4b69d992c86cbd733cbdd7f9c56e2d5f5784aacb93de
+  metadata.gz: 3c00514d3fa235fd2f1122437f5607d789cfa9d1155aade0843091b3c274307a967cb0fa7789d99a498cfef1277804b69d1986d8571d366e14d5c672e4f7a536
+  data.tar.gz: 34fa8b804fd61537df2d9a51ffe0270a3a58d6083b82bd1e25b2cb391546f2a734d2060ad684810b7a63bebe0cd64fad71ef580fadccced3385f3526a34eea1b

data/README.md

@@ -173,6 +173,8 @@ See how [Wikipedia](https://github.com/fastlane/examples#wikipedia-by-wikimedia-
 
 You can easily opt-out by adding `opt_out_usage` to your `Fastfile` or by setting the environment variable `FASTLANE_OPT_OUT_USAGE`. To also disable update checks, set the `FASTLANE_SKIP_UPDATE_CHECK` variable.
 
+You can optionally submit crash reports, run `fastlane enable_crash_reporting` to get started. This makes resolving issues much easier and helps improve fastlane. [More information](https://github.com/fastlane/fastlane/releases/tag/1.33.3)
+
 ## Credentials
 A detailed description about how `fastlane` stores your credentials is available on a [separate repo](https://github.com/fastlane/fastlane/tree/master/credentials_manager).
 

data/lib/assets/Plugins.md.erb

@@ -0,0 +1,8 @@
+### Available Plugins
+
+| Plugin Name | Description | Downloads
+--------------|-------------|----------|----------
+<% @plugins.each do |current| %>
+<%= current.linked_title %> | <%= current.info %> | <%= current.downloads %>
+
+<% end %>

data/lib/fastlane.rb

@@ -18,6 +18,7 @@ require 'fastlane/one_off'
 require 'fastlane/command_line_handler'
 require 'fastlane/documentation/docs_generator'
 require 'fastlane/other_action'
+require 'fastlane/plugins/plugins'
 
 module Fastlane
   Helper = FastlaneCore::Helper # you gotta love Ruby: Helper.* should use the Helper class contained in FastlaneCore

data/lib/fastlane/action_collector.rb

@@ -1,8 +1,19 @@
 module Fastlane
   class ActionCollector < FastlaneCore::ToolCollector
+    # Is this an official fastlane action, that is bundled with fastlane?
     def is_official?(name)
       return true if name == :lane_switch
-      Actions.get_all_official_actions.include? name
+      Actions.get_all_official_actions.include?(name)
+    end
+
+    def name_to_track(name)
+      return name if is_official?(name)
+
+      PluginManager.plugin_references.each do |plugin_name, value|
+        return "#{plugin_name}/#{name}" if value[:actions].include?(name)
+      end
+
+      return nil
     end
 
     def show_message
@@ -15,7 +26,28 @@ module Fastlane
     end
 
     def determine_version(name)
-      super(name) || Fastlane::VERSION
+      self.class.determine_version(name)
+    end
+
+    # e.g.
+    #   :gym
+    #   :xcversion
+    #   "fastlane-plugin-my_plugin/xcversion"
+    def self.determine_version(name)
+      return super(name) if super(name)
+
+      if name.to_s.include?(PluginManager.plugin_prefix)
+        # That's an action from a plugin, we need to fetch its version number
+        begin
+          plugin_name = name.split("/").first.gsub(PluginManager.plugin_prefix, '')
+          return Fastlane.const_get(plugin_name.fastlane_class)::VERSION
+        rescue => ex
+          UI.verbose(ex)
+          return "undefined"
+        end
+      end
+
+      return Fastlane::VERSION # that's the case for all built-in actions
     end
   end
 end

data/lib/fastlane/actions/actions_helper.rb

@@ -101,5 +101,9 @@ module Fastlane
         end
       end
     end
+
+    def self.formerly_bundled_actions
+      ["xcake"]
+    end
   end
 end

data/lib/fastlane/actions/copy_artifacts.rb

@@ -1,38 +1,26 @@
-require 'fileutils'
-require 'shellwords'
-
 module Fastlane
   module Actions
     class CopyArtifactsAction < Action
       def self.run(params)
         # we want to make sure that our target folder exist already
-        FileUtils.mkdir_p(params[:target_path])
-
-        # Ensure that artifacts is an array
-        artifacts_to_search = [params[:artifacts]].flatten
+        target_folder_command = 'mkdir -p ' + params[:target_path]
+        Actions.sh(target_folder_command)
 
-        # If any of the paths include "*", we assume that we are referring to the Unix entries
-        # e.g /tmp/fastlane/* refers to all the files in /tmp/fastlane
-        # We use Dir.glob to expand all those paths, this would create an array of arrays though, so flatten
-        # Lastly, we shell escape everything in case they contain incompatible symbols (e.g. spaces)
-        artifacts = artifacts_to_search.map { |f| f.include?("*") ? Dir.glob(f) : f }.flatten.map(&:shellescape)
+        # construct the main command that will do the copying/moving for us
+        base_command = params[:keep_original] ? 'cp' : 'mv'
+        options = []
+        options << '-f'
+        options << '-R' if params[:keep_original] # we only want the -R flag for the cp command, which we get when the user asks to keep the original
+        options << params[:artifacts].map { |e| e.tr(' ', '\ ') }
+        options << params[:target_path]
 
-        UI.verbose("Copying artifacts #{artifacts.join(', ')} to #{params[:target_path]}")
-        UI.verbose(params[:keep_original] ? "Keeping original files" : "Not keeping original files")
+        command = ([base_command] + options).join(' ')
 
-        if params[:fail_on_missing]
-          missing = artifacts.select { |a| !File.exist?(a) }
-          UI.user_error! "Not all files were present in copy artifacts. Missing #{missing.join(', ')}" unless missing.empty?
-        else
-          # If we don't fail on non-existant files, don't try to copy non-existant files
-          artifacts.reject! { |artifact| !File.exist?(artifact) }
-        end
+        # if we don't want to fail on missing files, then we need to swallow the error from our command, by ORing with the nil command, guaranteeing a 0 status code
+        command += ' || :' unless params[:fail_on_missing]
 
-        if params[:keep_original]
-          FileUtils.cp_r(artifacts, params[:target_path], remove_destination: true)
-        else
-          FileUtils.mv(artifacts, params[:target_path], force: true)
-        end
+        # call our command
+        Actions.sh(command)
 
         UI.success('Build artifacts successfully copied!')
       end

data/lib/fastlane/actions/jira.rb

@@ -3,7 +3,7 @@ module Fastlane
     class JiraAction < Action
 
       def self.run(params)
-        Actions.verify_gem!('jira-ruby')
+        Actions.verify_gem!('jira')
         require 'jira'
 
         site         = params[:url]

data/lib/fastlane/actions/pod_lib_lint.rb

@@ -23,11 +23,6 @@ module Fastlane
           command << "--allow-warnings"
         end
 
-        command << "--use-libraries" if params[:use_libraries]
-        command << "--fail-fast" if params[:fail_fast]
-        command << "--private" if params[:private]
-        command << "--quick" if params[:quick]
-
         result = Actions.sh(command.join(' '))
         UI.success("Pod lib lint Successfully ⬆️ ")
         return result
@@ -65,23 +60,7 @@ module Fastlane
                                          is_string: false,
                                          verify_block: proc do |value|
                                            UI.user_error!("Sources must be an array.") unless value.kind_of?(Array)
-                                         end),
-          FastlaneCore::ConfigItem.new(key: :use_libraries,
-                                       description: "Lint uses static libraries to install the spec",
-                                       is_string: false,
-                                       default_value: false),
-          FastlaneCore::ConfigItem.new(key: :fail_fast,
-                                       description: "Lint stops on the first failing platform or subspec",
-                                       is_string: false,
-                                       default_value: false),
-          FastlaneCore::ConfigItem.new(key: :private,
-                                       description: "Lint skips checks that apply only to public specs",
-                                       is_string: false,
-                                       default_value: false),
-          FastlaneCore::ConfigItem.new(key: :quick,
-                                       description: "Lint skips checks that would require to download and build the spec",
-                                       is_string: false,
-                                       default_value: false)
+                                         end)
         ]
       end
 

data/lib/fastlane/actions/push_to_git_remote.rb

@@ -1,6 +1,6 @@
 module Fastlane
   module Actions
-    # Push local changes to the remote branch
+    # Adds a git tag to the current commit
     class PushToGitRemoteAction < Action
       def self.run(params)
         local_branch = params[:local_branch]

data/lib/fastlane/actions/slather.rb

@@ -5,34 +5,27 @@ module Fastlane
     end
 
     class SlatherAction < Action
-      # https://github.com/SlatherOrg/slather/blob/cbc5099cd25beb43fd978b7a3e5428f02230122d/lib/slather/command/coverage_command.rb#L24
+
       ARGS_MAP = {
-          travis: '--travis',
-          circleci: '--circleci',
-          jenkins: '--jenkins',
-          buildkite: '--buildkite',
-          teamcity: '--teamcity',
-
-          coveralls: '--coveralls',
-          simple_output: '--simple-output',
-          gutter_json: '--gutter-json',
-          cobertura_xml: '--cobertura-xml',
-          html: '--html',
-          show: '--show',
-
-          build_directory: '--build-directory',
-          source_directory: '--source-directory',
-          output_directory: '--output-directory',
-          ignore: '--ignore',
-          verbose: '--verbose',
-
-          input_format: '--input-format',
-          scheme: '--scheme',
-          workspace: '--workspace',
-          binary_file: '--binary-file',
-          binary_basename: '--binary-basename',
-          source_files: '--source-files',
-          decimals: '--decimals'
+        build_directory: "--build-directory",
+        input_format: "--input-format",
+        scheme: "--scheme",
+        buildkite: "--buildkite",
+        jenkins: "--jenkins",
+        travis: "--travis",
+        circleci: "--circleci",
+        coveralls: "--coveralls",
+        simple_output: "--simple-output",
+        gutter_json: "--gutter-json",
+        cobertura_xml: "--cobertura-xml",
+        html: "--html",
+        show: "--show",
+        source_directory: "--source-directory",
+        output_directory: "--output-directory",
+        binary_basename: "--binary-basename",
+        binary_file: "--binary-file",
+        ignore: "--ignore",
+        workspace: "--workspace"
       }.freeze
 
       def self.run(params)
@@ -134,11 +127,6 @@ Slather is available at https://github.com/SlatherOrg/slather
                                        description: "Tell slather that it is running on Buildkite",
                                        is_string: false,
                                        optional: true),
-          FastlaneCore::ConfigItem.new(key: :teamcity,
-                                       env_name: "FL_SLATHER_TEAMCITY_ENABLED", # The name of the environment variable
-                                       description: "Tell slather that it is running on TeamCity",
-                                       is_string: false,
-                                       optional: true),
           FastlaneCore::ConfigItem.new(key: :jenkins,
                                        env_name: "FL_SLATHER_JENKINS_ENABLED", # The name of the environment variable
                                        description: "Tell slather that it is running on Jenkins",
@@ -197,11 +185,6 @@ Slather is available at https://github.com/SlatherOrg/slather
                                        description: "Tell slather to ignore files matching a path or any path from an array of paths",
                                        is_string: false,
                                        optional: true),
-          FastlaneCore::ConfigItem.new(key: :verbose,
-                                       env_name: "FL_SLATHER_VERBOSE",
-                                       description: "Tell slather to enable verbose mode",
-                                       is_string: false,
-                                       optional: true),
           FastlaneCore::ConfigItem.new(key: :use_bundle_exec,
                                       env_name: "FL_SLATHER_USE_BUNDLE_EXEC",
                                       description: "Use bundle exec to execute slather. Make sure it is in the Gemfile",
@@ -214,17 +197,7 @@ Slather is available at https://github.com/SlatherOrg/slather
           FastlaneCore::ConfigItem.new(key: :binary_file,
                                       env_name: "FL_SLATHER_BINARY_FILE",
                                       description: "Binary file name to be used for code coverage",
-                                      default_value: false),
-          FastlaneCore::ConfigItem.new(key: :source_files,
-                                       env_name: "FL_SLATHER_SOURCE_FILES",
-                                       description: "A Dir.glob compatible pattern used to limit the lookup to specific source files. Ignored in gcov mode",
-                                       default_value: false,
-                                       optional: true),
-          FastlaneCore::ConfigItem.new(key: :decimals,
-                                      env_name: "FL_SLATHER_DECIMALS",
-                                      description: "The amount of decimals to use for % coverage reporting",
-                                      default_value: false,
-                                      optional: true)
+                                      default_value: false)
         ]
       end
 

data/lib/fastlane/commands_generator.rb

@@ -10,6 +10,7 @@ module Fastlane
     def self.start
       FastlaneCore::UpdateChecker.start_looking_for_update('fastlane')
       Fastlane.load_actions
+      Fastlane::PluginManager.load_plugins
       self.new.run
     ensure
       FastlaneCore::UpdateChecker.show_update_status('fastlane', Fastlane::VERSION)
@@ -146,17 +147,17 @@ module Fastlane
 
       command :enable_crash_reporting do |c|
         c.syntax = 'fastlane enable_crash_reporting'
-        c.description = "Deprecated: fastlane doesn't use a crash reporter any more"
+        c.description = 'Enable crash reporting to improve fastlane'
         c.action do |args, options|
-          show_crashreporter_note
+          FastlaneCore::CrashReporting.enable
         end
       end
 
       command :disable_crash_reporting do |c|
         c.syntax = 'fastlane disable_crash_reporting'
-        c.description = "Deprecated: fastlane doesn't use a crash reporter any more"
+        c.description = 'Disable crash reporting'
         c.action do |args, options|
-          show_crashreporter_note
+          FastlaneCore::CrashReporting.disable
         end
       end
 
@@ -170,8 +171,64 @@ module Fastlane
         end
       end
 
-      default_command :trigger
+      #####################################################
+      # @!group Plugins
+      #####################################################
+
+      command :new_plugin do |c|
+        c.syntax = 'fastlane create_plugin [plugin_name]'
+        c.description = 'Create a new plugin that can be used with fastlane'
+
+        c.action do |args, options|
+          PluginGenerator.new.generate args.shift
+        end
+      end
+
+      command :add_plugin do |c|
+        c.syntax = 'fastlane add_plugin [plugin_name]'
+        c.description = 'Add a new plugin to your fastlane setup'
+
+        c.action do |args, options|
+          pm = PluginManager.new
+          args << UI.input("Enter the name of the plugin to install: ") if args.empty?
+          args.each do |plugin_name|
+            pm.add_dependency(plugin_name)
+          end
+
+          UI.important("Make sure to commit your Gemfile, Gemfile.lock and #{PluginManager::PLUGINFILE_NAME} to version control")
+          pm.install_dependencies!
+        end
+      end
+
+      command :install_plugins do |c|
+        c.syntax = 'fastlane install_plugins'
+        c.description = 'Install all plugins for this project'
 
+        c.action do |args, options|
+          PluginManager.new.install_dependencies!
+        end
+      end
+
+      command :update_plugins do |c|
+        c.syntax = 'fastlane update_plugins'
+        c.description = 'Update all plugin dependencies'
+
+        c.action do |args, options|
+          PluginManager.new.update_dependencies!
+        end
+      end
+
+      command :search_plugins do |c|
+        c.syntax = 'fastlane search_plugins [search_query]'
+        c.description = 'Search for plugins, search query is optional'
+
+        c.action do |args, options|
+          search_query = args.last
+          PluginSearch.print_plugins(search_query: search_query)
+        end
+      end
+
+      default_command :trigger
       run!
     end
 
@@ -187,12 +244,6 @@ module Fastlane
       return false
     end
 
-    def show_crashreporter_note
-      UI.important("fastlane doesn't use a crash reporter any more")
-      UI.important("Instead please submit an issue on GitHub: https://github.com/fastlane/fastlane/issues")
-      UI.important("This command will be removed in one of the next releases")
-    end
-
     # rubocop:enable Metrics/AbcSize
     # rubocop:enable Metrics/MethodLength
   end

data/lib/fastlane/lane_manager.rb

@@ -44,10 +44,14 @@ module Fastlane
       e = nil
       begin
         ff.runner.execute(lane, platform, parameters)
-      rescue => ex
+      rescue Exception => ex # rubocop:disable Lint/RescueException
+        # We also catch Exception, since the implemented action might send a SystemExit signal
+        # (or similar). We still want to catch that, since we want properly finish running fastlane
+        # Tested with `xcake`, which throws a `Xcake::Informative` object
+
         UI.important 'Variable Dump:'.yellow
         UI.message Actions.lane_context
-        UI.error ex.to_s
+        UI.error ex.to_s if ex.kind_of?(StandardError) # we don't want to print things like 'system exit'
         e = ex
       end
 

data/lib/fastlane/one_off.rb

@@ -29,7 +29,13 @@ module Fastlane
       begin
         class_ref = Fastlane::Actions.const_get(class_name)
       rescue NameError
-        UI.user_error!("Action '#{action}' not available, run `fastlane actions` to get a full list")
+        if Fastlane::Actions.formerly_bundled_actions.include?(action)
+          # This was a formerly bundled action which is now a plugin.
+          UI.verbose(caller.join("\n"))
+          UI.user_error!("The action '#{action}' is no longer bundled with fastlane. You can install it using `fastlane add_plugin #{action}`")
+        else
+          UI.user_error!("Action '#{action}' not available, run `fastlane actions` to get a full list")
+        end
       end
 
       r = Runner.new