fastlane 1.85.0 → 1.86.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 5f00e39921c28effcc81677360d5922347caee20
-  data.tar.gz: 49c4f159f75869eda5692feff918c76827fa7b8e
+  metadata.gz: f9c9b5874340da8868b5536d71f394c40aea0705
+  data.tar.gz: 8fadb3ff20ccc551f5d0933089dea99dab1974da
 SHA512:
-  metadata.gz: bce5e5db952069eee25cd64dab6da6ca2ae1ed2dd028795bffade38b895c7739f9972f107f52eb041ab7ff384e4b0d8267d90385858076488d5f11bf51601a1d
-  data.tar.gz: e42639ca6e7697722a4120d5ca8b6ed53822292f0e7921c82907c32d80ee10945c80a65d7d18ab460de9bfb6983f784ef3b87688edf4f10e82344f3fdb222ba1
+  metadata.gz: 104f28cc136ea24e172200213dffdf3c5bf300ef1cce035f1f72c77fb140d3c621a1e8f0e392cc1e5fe313bf1a37d3545dc7f7e87c00b5da95254a8147c29676
+  data.tar.gz: 5777323ac3e25f85a78a587a5ffeffeaab262288700d821c1e31f5c9238cbb0b6076030d98309dbcef271b27927cd33bddd770d9206f13081fbb4e6d92b216be

data/bin/fastlane

@@ -1,6 +1,5 @@
 #!/usr/bin/env ruby
 $LOAD_PATH.push File.expand_path("../../lib", __FILE__)
 
-require "fastlane"
-require "fastlane/commands_generator"
-Fastlane::CommandsGenerator.start
+require "fastlane/cli_tools_distributor"
+Fastlane::CLIToolsDistributor.take_off

data/bin//360/237/232/200

@@ -1,6 +1,5 @@
 #!/usr/bin/env ruby
 $LOAD_PATH.push File.expand_path("../../lib", __FILE__)
 
-require "fastlane"
-require "fastlane/commands_generator"
-Fastlane::CommandsGenerator.start
+require "fastlane/cli_tools_distributor"
+Fastlane::CLIToolsDistributor.take_off

data/lib/fastlane.rb

@@ -2,6 +2,7 @@ require 'fastlane_core'
 
 require 'fastlane/core_ext/string' # this has to be above most of the other requires
 require 'fastlane/version'
+require 'fastlane/tools'
 require 'fastlane/actions/actions_helper' # has to be before fast_file
 require 'fastlane/fast_file'
 require 'fastlane/runner'
@@ -17,16 +18,19 @@ require 'fastlane/configuration_helper'
 require 'fastlane/one_off'
 require 'fastlane/command_line_handler'
 require 'fastlane/documentation/docs_generator'
+require 'fastlane/other_action'
 
 module Fastlane
   Helper = FastlaneCore::Helper # you gotta love Ruby: Helper.* should use the Helper class contained in FastlaneCore
   UI = FastlaneCore::UI
 
-  Fastlane::Actions.load_default_actions
-  Fastlane::Actions.load_helpers
+  def self.load_actions
+    Fastlane::Actions.load_default_actions
+    Fastlane::Actions.load_helpers
 
-  if Fastlane::FastlaneFolder.path
-    actions_path = File.join(Fastlane::FastlaneFolder.path, 'actions')
-    Fastlane::Actions.load_external_actions(actions_path) if File.directory?(actions_path)
+    if Fastlane::FastlaneFolder.path
+      actions_path = File.join(Fastlane::FastlaneFolder.path, 'actions')
+      Fastlane::Actions.load_external_actions(actions_path) if File.directory?(actions_path)
+    end
   end
 end

data/lib/fastlane/action.rb

@@ -2,6 +2,10 @@ require 'fastlane/actions/actions_helper'
 
 module Fastlane
   class Action
+    class << self
+      attr_accessor :runner
+    end
+
     def self.run(params)
     end
 
@@ -62,13 +66,26 @@ module Fastlane
     end
 
     # to allow a simple `sh` in the custom actions
-    def self.sh(command, print_command: true, print_command_output: true)
-      Fastlane::Actions.sh_control_output(command, print_command: print_command, print_command_output: print_command_output)
+    def self.sh(command, print_command: true, print_command_output: true, error_callback: nil)
+      Fastlane::Actions.sh_control_output(command, print_command: print_command, print_command_output: print_command_output, error_callback: error_callback)
     end
 
     # instead of "AddGitAction", this will return "add_git" to print it to the user
     def self.action_name
       self.name.split('::').last.gsub('Action', '').fastlane_underscore
     end
+
+    # Allows the user to call an action from an action
+    def self.method_missing(method_sym, *arguments, &_block)
+      UI.error("Unknown method '#{method_sym}'")
+      UI.user_error!("To call another action from an action use `OtherAction.#{method_sym}` instead")
+    end
+
+    # Return a new instance of the OtherAction action
+    # We need to do this, since it has to have access to
+    # the runner object
+    def self.other_action
+      return OtherAction.new(self.runner)
+    end
   end
 end

data/lib/fastlane/actions/appaloosa.rb

@@ -43,7 +43,7 @@ module Fastlane
         params = { store_id: store_id, api_key: api_key, key: path }
         uri.query = URI.encode_www_form(params)
         url_for_download_response = Net::HTTP.get_response(uri)
-        if url_for_download_response.kind_of?(Net::HTTPNotFound)
+        if invalid_response?(url_for_download_response)
           UI.user_error!("ERROR: A problem occurred with your API token and your store id. Please try again.")
         end
         json_res = JSON.parse(url_for_download_response.body)
@@ -99,6 +99,7 @@ module Fastlane
         screenshots = all_screenshots_links(screenshots)
         uri = URI("#{APPALOOSA_SERVER}/#{store_id}/mobile_application_updates/upload")
         http = Net::HTTP.new(uri.host, uri.port)
+        http.use_ssl = true
         req = Net::HTTP::Post.new(uri.path, { 'Content-Type' => 'application/json' })
         req.body = { store_id: store_id,
                      api_key: api_key,
@@ -216,6 +217,11 @@ module Fastlane
       def self.is_supported?(platform)
         [:ios, :mac, :android].include? platform
       end
+
+      def self.invalid_response?(url_for_download_response)
+        url_for_download_response.kind_of?(Net::HTTPNotFound) ||
+          url_for_download_response.kind_of?(Net::HTTPForbidden)
+      end
     end
   end
 end

data/lib/fastlane/actions/apteligent.rb

@@ -0,0 +1,89 @@
+module Fastlane
+  module Actions
+    class ApteligentAction < Action
+      def self.run(params)
+        command = []
+        command << "curl"
+        command += upload_options(params)
+        command << upload_url(params[:app_id].shellescape)
+
+        # Fastlane::Actions.sh has buffering issues, no progress bar is shown in real time
+        # will reanable it when it is fixed
+        # result = Fastlane::Actions.sh(command.join(' '), log: false)
+        shell_command = command.join(' ')
+        return shell_command if Helper.is_test?
+        result = Actions.sh(shell_command)
+        fail_on_error(result)
+      end
+
+      def self.fail_on_error(result)
+        if result != "200"
+          UI.crash! "Server error, failed to upload the dSYM file."
+        else
+          UI.success 'dSYM successfully uploaded to Apteligent!'
+        end
+      end
+
+      def self.upload_url(app_id)
+        "https://api.crittercism.com/api_beta/dsym/#{app_id}"
+      end
+
+      def self.dsym_path(params)
+        file_path = params[:dsym]
+        file_path ||= Actions.lane_context[SharedValues::DSYM_OUTPUT_PATH] || ENV[SharedValues::DSYM_OUTPUT_PATH.to_s]
+        file_path ||= Actions.lane_context[SharedValues::DSYM_ZIP_PATH] || ENV[SharedValues::DSYM_ZIP_PATH.to_s]
+
+        if file_path
+          expanded_file_path = File.expand_path(file_path)
+          UI.user_error!("Couldn't find file at path '#{expanded_file_path}'") unless File.exist?(expanded_file_path)
+          return expanded_file_path
+        else
+          UI.user_error!("Couldn't find dSYM file")
+        end
+      end
+
+      def self.upload_options(params)
+        file_path = dsym_path(params).shellescape
+
+        options = []
+        options << "--write-out %{http_code} --silent --output /dev/null"
+        options << "-F dsym=@#{file_path}"
+        options << "-F key=#{params[:api_key].shellescape}"
+        options
+      end
+
+      #####################################################
+      # @!group Documentation
+      #####################################################
+
+      def self.description
+        "Upload dSYM file to Apteligent (Crittercism)"
+      end
+
+      def self.available_options
+        [
+          FastlaneCore::ConfigItem.new(key: :dsym,
+                                       env_name: "FL_APTELIGENT_FILE",
+                                       description: "dSYM.zip file to upload to Apteligent",
+                                       optional: true),
+          FastlaneCore::ConfigItem.new(key: :app_id,
+                                       env_name: "FL_APTELIGENT_APP_ID",
+                                      description: "Apteligent App ID key e.g. 569f5c87cb99e10e00c7xxxx",
+                                      optional: false),
+          FastlaneCore::ConfigItem.new(key: :api_key,
+                                       env_name: "FL_APTELIGENT_API_KEY",
+                                       description: "Apteligent App API key e.g. IXPQIi8yCbHaLliqzRoo065tH0lxxxxx",
+                                       optional: false)
+        ]
+      end
+
+      def self.authors
+        ["Mo7amedFouad"]
+      end
+
+      def self.is_supported?(platform)
+        platform == :ios
+      end
+    end
+  end
+end

data/lib/fastlane/actions/crashlytics.rb

@@ -28,11 +28,29 @@ module Fastlane
         end
 
         UI.success('Uploading the build to Crashlytics Beta. Time for some ☕️.')
-        UI.verbose(command.join(" ")) if $verbose
-        Actions.sh(command.join(" "), log: false)
+
+        sanitizer = proc do |message|
+          message.gsub(params[:api_token], '[[API_TOKEN]]')
+                 .gsub(params[:build_secret], '[[BUILD_SECRET]]')
+        end
+
+        UI.verbose sanitizer.call(command.join(' ')) if $verbose
+
+        error_callback = proc do |error|
+          clean_error = sanitizer.call(error)
+          UI.error(clean_error)
+        end
+
+        result = Actions.sh_control_output(
+          command.join(" "),
+          print_command: false,
+          print_command_output: false,
+          error_callback: error_callback)
 
         return command if Helper.test?
 
+        UI.verbose sanitizer.call(result) if $verbose
+
         UI.success('Build successfully uploaded to Crashlytics Beta 🌷')
       end
 
@@ -41,12 +59,23 @@ module Fastlane
       end
 
       def self.available_options
+        platform = Actions.lane_context[Actions::SharedValues::PLATFORM_NAME]
+
+        ipa_path_default = nil
+        if platform == :ios or platform.nil?
+          ipa_path_default = Dir["*.ipa"].last
+        end
+        apk_path_default = nil
+        if platform == :android
+          apk_path_default = Dir["*.apk"].last || Dir[File.join("app", "build", "outputs", "apk", "app-release.apk")].last
+        end
+
         [
           # iOS Specific
           FastlaneCore::ConfigItem.new(key: :ipa_path,
                                        env_name: "CRASHLYTICS_IPA_PATH",
                                        description: "Path to your IPA file. Optional if you use the `gym` or `xcodebuild` action",
-                                       default_value: Actions.lane_context[SharedValues::IPA_OUTPUT_PATH] || Dir["*.ipa"].last,
+                                       default_value: Actions.lane_context[SharedValues::IPA_OUTPUT_PATH] || ipa_path_default,
                                        optional: true,
                                        verify_block: proc do |value|
                                          UI.user_error!("Couldn't find ipa file at path '#{value}'") unless File.exist?(value)
@@ -55,7 +84,7 @@ module Fastlane
           FastlaneCore::ConfigItem.new(key: :apk_path,
                                        env_name: "CRASHLYTICS_APK_PATH",
                                        description: "Path to your APK file",
-                                       default_value: Actions.lane_context[SharedValues::GRADLE_APK_OUTPUT_PATH] || Dir["*.apk"].last || Dir[File.join("app", "build", "outputs", "apk", "app-Release.apk")].last,
+                                       default_value: Actions.lane_context[SharedValues::GRADLE_APK_OUTPUT_PATH] || apk_path_default,
                                        optional: true,
                                        verify_block: proc do |value|
                                          UI.user_error!("Couldn't find apk file at path '#{value}'") unless File.exist?(value)
@@ -64,7 +93,6 @@ module Fastlane
           FastlaneCore::ConfigItem.new(key: :crashlytics_path,
                                        env_name: "CRASHLYTICS_FRAMEWORK_PATH",
                                        description: "Path to the submit binary in the Crashlytics bundle (iOS) or `crashlytics-devtools.jar` file (Android)",
-                                       default_value: Dir["./Pods/iOS/Crashlytics/Crashlytics.framework"].last || Dir["./**/Crashlytics.framework"].last,
                                        optional: true,
                                        verify_block: proc do |value|
                                          UI.user_error!("Couldn't find crashlytics at path '#{File.expand_path(value)}'`") unless File.exist?(File.expand_path(value))

data/lib/fastlane/actions/nexus_upload.rb

@@ -32,6 +32,11 @@ module Fastlane
         options << "-F g=#{params[:repo_group_id].shellescape}"
         options << "-F a=#{params[:repo_project_name].shellescape}"
         options << "-F v=#{params[:repo_project_version].shellescape}"
+
+        if params[:repo_classifier]
+          options << "-F c=#{params[:repo_classifier].shellescape}"
+        end
+
         options << "-F e=#{file_extension}"
         options << "-F file=@#{file_path}"
         options << "-u #{params[:username].shellescape}:#{params[:password].shellescape}"
@@ -92,6 +97,10 @@ module Fastlane
                                        env_name: "FL_NEXUS_REPO_PROJECT_VERSION",
                                        description: "Nexus repository commandect version",
                                        optional: false),
+          FastlaneCore::ConfigItem.new(key: :repo_classifier,
+                                       env_name: "FL_NEXUS_REPO_CLASSIFIER",
+                                       description: "Nexus repository artifact classifier (optional)",
+                                       optional: true),
           FastlaneCore::ConfigItem.new(key: :endpoint,
                                        env_name: "FL_NEXUS_ENDPOINT",
                                        description: "Nexus endpoint e.g. http://nexus:8081",

data/lib/fastlane/actions/pod_push.rb

@@ -22,6 +22,10 @@ module Fastlane
           command << " --allow-warnings"
         end
 
+        if params[:use_libraries]
+          command << " --use-libraries"
+        end
+
         result = Actions.sh(command.to_s)
         UI.success("Successfully pushed Podspec ⬆️ ")
         return result
@@ -55,6 +59,10 @@ module Fastlane
                                        description: "Allow warnings during pod push",
                                        optional: true,
                                        is_string: false),
+          FastlaneCore::ConfigItem.new(key: :use_libraries,
+                                       description: "Allow lint to use static libraries to install the spec",
+                                       optional: true,
+                                       is_string: false),
           FastlaneCore::ConfigItem.new(key: :sources,
                                        description: "The sources of repos you want the pod spec to lint with, separated by commas",
                                        optional: true,

data/lib/fastlane/actions/resign.rb

@@ -6,7 +6,7 @@ module Fastlane
         require 'sigh'
 
         # try to resign the ipa
-        if Sigh::Resign.resign(params[:ipa], params[:signing_identity], params[:provisioning_profile], params[:entitlements], params[:version], params[:display_name], params[:short_version], params[:bundle_version])
+        if Sigh::Resign.resign(params[:ipa], params[:signing_identity], params[:provisioning_profile], params[:entitlements], params[:version], params[:display_name], params[:short_version], params[:bundle_version], params[:bundle_id])
           UI.success('Successfully re-signed .ipa 🔏.')
         else
           UI.user_error!("Failed to re-sign .ipa")
@@ -85,6 +85,11 @@ module Fastlane
                                        description: "Bundle version to force resigned ipa to use (CFBundleIdentifier)",
                                        conflicting_options: [:version],
                                        is_string: true,
+                                       optional: true),
+          FastlaneCore::ConfigItem.new(key: :bundle_id,
+                                       env_name: "FL_RESIGN_BUNDLE_ID",
+                                       description: "Set new bundle ID during resign",
+                                       is_string: true,
                                        optional: true)
         ]
       end

data/lib/fastlane/actions/rocket.rb

@@ -37,6 +37,7 @@ module Fastlane
          ##
          ##
          "
+        return "🚀"
       end
 
       #####################################################

data/lib/fastlane/actions/set_pod_key.rb

@@ -0,0 +1,60 @@
+module Fastlane
+  module Actions
+    class SetPodKeyAction < Action
+      def self.run(params)
+        Actions.verify_gem!('cocoapods-keys')
+        cmd = []
+
+        cmd << ['bundle exec'] if File.exist?('Gemfile') && params[:use_bundle_exec]
+        cmd << ['pod keys set']
+
+        cmd << ["\"#{params[:key].shellescape}\""]
+        cmd << ["\"#{params[:value].shellescape}\""]
+        cmd << ["\"#{params[:project].shellescape}\""] if params[:project]
+
+        Actions.sh(cmd.join(' '))
+      end
+
+      def self.author
+        "marcelofabri"
+      end
+
+      #####################################################
+      # @!group Documentation
+      #####################################################
+
+      def self.description
+        "Sets a value for a key with cocoapods-keys"
+      end
+
+      def self.available_options
+        [
+          FastlaneCore::ConfigItem.new(key: :use_bundle_exec,
+                                       env_name: "FL_SET_POD_KEY_USE_BUNDLE_EXEC",
+                                       description: "Use bundle exec when there is a Gemfile presented",
+                                       is_string: false,
+                                       default_value: true),
+          FastlaneCore::ConfigItem.new(key: :key,
+                                       env_name: "FL_SET_POD_KEY_ITEM_KEY",
+                                       description: "The key to be saved with cocoapods-keys",
+                                       is_string: true,
+                                       optional: false),
+          FastlaneCore::ConfigItem.new(key: :value,
+                                       env_name: "FL_SET_POD_KEY_ITEM_VALUE",
+                                       description: "The value to be saved with cocoapods-keys",
+                                       is_string: true,
+                                       optional: false),
+          FastlaneCore::ConfigItem.new(key: :project,
+                                       env_name: "FL_SET_POD_KEY_PROJECT",
+                                       description: "The project name",
+                                       is_string: true,
+                                       optional: true)
+        ]
+      end
+
+      def self.is_supported?(platform)
+        [:ios, :mac].include? platform
+      end
+    end
+  end
+end

data/lib/fastlane/actions/slather.rb

@@ -35,10 +35,24 @@ module Fastlane
           Actions.verify_gem!('slather')
         end
 
+        validate_params!(params)
+
         command = build_command(params)
         sh command
       end
 
+      def self.has_config_file
+        File.file?('.slather.yml')
+      end
+
+      def self.validate_params!(params)
+        if params[:proj] || has_config_file
+          true
+        else
+          UI.user_error!("You have to provide a project with `:proj` or use a .slather.yml")
+        end
+      end
+
       def self.build_command(params)
         command = []
         command.push("bundle exec") if params[:use_bundle_exec]
@@ -60,7 +74,7 @@ module Fastlane
           end
         end
 
-        command << params[:proj].shellescape
+        command << params[:proj].shellescape if params[:proj]
         command.join(" ")
       end
 
@@ -91,7 +105,8 @@ Slather is available at https://github.com/SlatherOrg/slather
                                        description: "The project file that slather looks at", # a short description of this parameter
                                        verify_block: proc do |value|
                                          UI.user_error!("No project file specified, pass using `proj: 'Project.xcodeproj'`") unless value and !value.empty?
-                                       end),
+                                       end,
+                                       optional: true),
           FastlaneCore::ConfigItem.new(key: :workspace,
                                        env_name: "FL_SLATHER_WORKSPACE",
                                        description: "The workspace that slather looks at",

data/lib/fastlane/cli_tools_distributor.rb

@@ -0,0 +1,52 @@
+module Fastlane
+  # This class is responsible for checking the ARGV
+  # to see if the user wants to launch another fastlane
+  # tool or fastlane itself
+  class CLIToolsDistributor
+    class << self
+      def take_off
+        require "fastlane"
+
+        # Array of symbols for the names of the available lanes
+        # This doesn't actually use the Fastfile parser, but only
+        # the available lanes. This way it's much faster, which
+        # is very important in this case, since it will be executed
+        # every time one of the tools is launched
+        available_lanes = Fastlane::FastlaneFolder.available_lanes
+
+        tool_name = ARGV.first
+        if tool_name && Fastlane::TOOLS.include?(tool_name.to_sym) && !available_lanes.include?(tool_name.to_sym)
+          # Triggering a specific tool
+          # This happens when the users uses things like
+          #
+          #   fastlane sigh
+          #   fastlane snapshot
+          #
+          require tool_name
+          begin
+            # First, remove the tool's name from the arguments
+            # Since it will be parsed by the `commander` at a later point
+            # and it must not contain the binary name
+            ARGV.shift
+
+            # Import the CommandsGenerator class, which is used to parse
+            # the user input
+            require File.join(tool_name, "commands_generator")
+
+            # Call the tool's CommandsGenerator class and let it do its thing
+            Object.const_get(tool_name.fastlane_class)::CommandsGenerator.start
+          rescue LoadError
+            # This will only happen if the tool we call here, doesn't provide
+            # a CommandsGenerator class yet
+            # When we launch this feature, this should never be the case
+            abort("#{tool_name} can't be called via `fastlane #{tool_name}`, run '#{tool_name}' directly instead".red)
+          end
+        else
+          # Triggering fastlane to call a lane
+          require "fastlane/commands_generator"
+          Fastlane::CommandsGenerator.start
+        end
+      end
+    end
+  end
+end

data/lib/fastlane/commands_generator.rb

@@ -9,6 +9,7 @@ module Fastlane
 
     def self.start
       FastlaneCore::UpdateChecker.start_looking_for_update('fastlane')
+      Fastlane.load_actions
       self.new.run
     ensure
       FastlaneCore::UpdateChecker.show_update_status('fastlane', Fastlane::VERSION)

data/lib/fastlane/fast_file.rb

@@ -127,29 +127,7 @@ module Fastlane
 
     # Is used to look if the method is implemented as an action
     def method_missing(method_sym, *arguments, &_block)
-      method_str = method_sym.to_s
-      method_str.delete!('?') # as a `?` could be at the end of the method name
-
-      # First, check if there is a predefined method in the actions folder
-      class_name = method_str.fastlane_class + 'Action'
-      class_ref = nil
-      begin
-        class_ref = Fastlane::Actions.const_get(class_name)
-      rescue NameError
-        # Action not found
-        # Is there a lane under this name?
-        return self.runner.try_switch_to_lane(method_sym, arguments)
-      end
-
-      # It's important to *not* have this code inside the rescue block
-      # otherwise all NameErrors will be catched and the error message is
-      # confusing
-      if class_ref && class_ref.respond_to?(:run)
-        # Action is available, now execute it
-        return self.runner.execute_action(method_sym, class_ref, arguments)
-      else
-        UI.user_error!("Action '#{method_sym}' of class '#{class_name}' was found, but has no `run` method.")
-      end
+      self.runner.trigger_action_by_name(method_sym, *arguments)
     end
 
     #####################################################

data/lib/fastlane/fastlane_folder.rb

@@ -13,10 +13,15 @@ module Fastlane
       return value
     end
 
+    def self.fastfile_path
+      return nil if path.nil?
+      File.join(path, "Fastfile")
+    end
+
     # Does a fastlane configuration already exist?
     def self.setup?
       return false unless path
-      File.exist?(File.join(path, "Fastfile"))
+      File.exist?(self.fastfile_path)
     end
 
     def self.create_folder!(path = nil)
@@ -24,5 +29,15 @@ module Fastlane
       FileUtils.mkdir_p(path)
       UI.success "Created new folder '#{path}'."
     end
+
+    # Returns an array of symbols for the available lanes for the Fastfile
+    # This doesn't actually use the Fastfile parser, but only
+    # the available lanes. This way it's much faster
+    # Use this only if performance is :key:
+    def self.available_lanes
+      return [] if fastfile_path.nil?
+      output = Helper.backticks("cat #{fastfile_path.shellescape} | grep \"^\s*lane \:\" | awk -F ':' '{print $2}' | awk -F ' ' '{print $1}'")
+      return output.strip.split(" ").collect(&:to_sym)
+    end
   end
 end

data/lib/fastlane/helper/crashlytics_helper.rb

@@ -3,6 +3,7 @@ module Fastlane
     class CrashlyticsHelper
       class << self
         def generate_ios_command(params)
+          params[:crashlytics_path] = Dir["./Pods/iOS/Crashlytics/Crashlytics.framework"].last || Dir["./**/Crashlytics.framework"].last unless params[:crashlytics_path]
           UI.user_error!("No value found for 'crashlytics_path'") unless params[:crashlytics_path]
           submit_binary = Dir[File.join(params[:crashlytics_path], '**', 'submit')].last
           submit_binary ||= "Crashlytics.framework/submit" if Helper.test?

data/lib/fastlane/helper/sh_helper.rb

@@ -4,16 +4,21 @@ module Fastlane
     # This method will output the string and execute it
     # Just an alias for sh_no_action
     # When running this in tests, it will return the actual command instead of executing it
-    # @param log [boolean] should fastlane print out the executed command
-    def self.sh(command, log: true)
-      sh_control_output(command, print_command: log, print_command_output: log)
+    # @param log [Boolean] should fastlane print out the executed command
+    # @param error_callback [Block] a callback invoked with the command ouptut if there is a non-zero exit status
+    def self.sh(command, log: true, error_callback: nil)
+      sh_control_output(command, print_command: log, print_command_output: log, error_callback: error_callback)
     end
 
-    def self.sh_no_action(command, log: true)
-      sh_control_output(command, print_command: log, print_command_output: log)
+    def self.sh_no_action(command, log: true, error_callback: nil)
+      sh_control_output(command, print_command: log, print_command_output: log, error_callback: error_callback)
     end
 
-    def self.sh_control_output(command, print_command: true, print_command_output: true)
+    # @param command [String] The command to be executed
+    # @param print_command [Boolean] Should we print the command that's being executed
+    # @param print_command_output [Boolean] Should we print the command output during execution
+    # @param error_callback [Block] A block that's called if the command exits with a non-zero status
+    def self.sh_control_output(command, print_command: true, print_command_output: true, error_callback: nil)
       # Set the encoding first, the user might have set it wrong
       previous_encoding = [Encoding.default_external, Encoding.default_internal]
       Encoding.default_external = Encoding::UTF_8
@@ -44,6 +49,8 @@ module Fastlane
                       "Shell command exited with exit status #{exit_status} instead of 0."
                     end
           message += "\n#{result}" if print_command_output
+
+          error_callback.call(result) if error_callback
           UI.user_error!(message)
         end
       end

data/lib/fastlane/lane.rb

@@ -19,10 +19,7 @@ module Fastlane
       UI.user_error!("lane name must not contain any spaces") if name.to_s.include? " "
       UI.user_error!("lane name must start with :") unless name.kind_of? Symbol
 
-      if self.class.black_list.include?(name.to_s)
-        UI.error "Lane Name '#{name}' can not be one of the followings: #{self.class.black_list}".red
-        UI.user_error!("Name '#{name}' is already taken")
-      end
+      self.class.verify_lane_name(name)
 
       self.platform = platform
       self.name = name
@@ -42,9 +39,28 @@ module Fastlane
     end
 
     class << self
+      # Makes sure the lane name is valid
+      def verify_lane_name(name)
+        if self.black_list.include?(name.to_s)
+          UI.error "Lane Name '#{name}' can not be one of the followings: #{self.black_list}"
+          UI.user_error!("Name '#{name}' is already taken")
+        end
+
+        if self.gray_list.include?(name.to_sym)
+          UI.error "Lane name '#{name}' should not be used because it is the name of a fastlane tool"
+          UI.error "It is recommended to not use '#{name}' as the name of your lane"
+          # We still allow it, because we're nice
+          # Otherwise we might break existing setups
+        end
+      end
+
       def black_list
         %w(run init new_action lanes list docs action actions help)
       end
+
+      def gray_list
+        Fastlane::TOOLS
+      end
     end
   end
 end

data/lib/fastlane/other_action.rb

@@ -0,0 +1,17 @@
+module Fastlane
+  # This class is used to call other actions from within actions
+  # We use a separate class so that we can easily identify when
+  # we have dependencies between actions
+  class OtherAction
+    attr_accessor :runner
+
+    def initialize(runner)
+      self.runner = runner
+    end
+
+    # Allows the user to call an action from an action
+    def method_missing(method_sym, *arguments, &_block)
+      self.runner.trigger_action_by_name(method_sym, *arguments)
+    end
+  end
+end

data/lib/fastlane/runner.rb

@@ -86,6 +86,34 @@ module Fastlane
       all
     end
 
+    # This is being called from `method_missing` from the Fastfile
+    # It's also used when an action is called from another action
+    def trigger_action_by_name(method_sym, *arguments)
+      method_str = method_sym.to_s
+      method_str.delete!('?') # as a `?` could be at the end of the method name
+
+      # First, check if there is a predefined method in the actions folder
+      class_name = method_str.fastlane_class + 'Action'
+      class_ref = nil
+      begin
+        class_ref = Fastlane::Actions.const_get(class_name)
+      rescue NameError
+        # Action not found
+        # Is there a lane under this name?
+        return self.try_switch_to_lane(method_sym, arguments)
+      end
+
+      # It's important to *not* have this code inside the rescue block
+      # otherwise all NameErrors will be caugth and the error message is
+      # confusing
+      if class_ref && class_ref.respond_to?(:run)
+        # Action is available, now execute it
+        return self.execute_action(method_sym, class_ref, arguments)
+      else
+        UI.user_error!("Action '#{method_sym}' of class '#{class_name}' was found, but has no `run` method.")
+      end
+    end
+
     #
     # All the methods that are usually called on execution
     #
@@ -140,6 +168,7 @@ module Fastlane
               UI.user_error!("You have to call the integration like `#{method_sym}(key: \"value\")`. Run `fastlane action #{method_sym}` for all available keys. Please check out the current documentation on GitHub.")
             end
 
+            class_ref.runner = self # needed to call another action form an action
             class_ref.run(arguments)
           end
         end

data/lib/fastlane/tools.rb

@@ -0,0 +1,20 @@
+module Fastlane
+  TOOLS = [
+    :fastlane,
+    :pilot,
+    :spaceship,
+    :produce,
+    :cert,
+    :deliver,
+    :frameit,
+    :pem,
+    :snapshot,
+    :screengrab,
+    :supply,
+    :cert,
+    :sigh,
+    :match,
+    :scan,
+    :gym
+  ]
+end

data/lib/fastlane/version.rb

@@ -1,4 +1,4 @@
 module Fastlane
-  VERSION = '1.85.0'.freeze
+  VERSION = '1.86.0'.freeze
   DESCRIPTION = "The easiest way to automate building and releasing your iOS and Android apps"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: fastlane
 version: !ruby/object:Gem::Version
-  version: 1.85.0
+  version: 1.86.0
 platform: ruby
 authors:
 - Felix Krause
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-05-04 00:00:00.000000000 Z
+date: 2016-05-05 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: krausefx-shenzhen
@@ -248,7 +248,7 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 2.6.0
+        version: 2.6.1
     - - "<"
       - !ruby/object:Gem::Version
         version: 3.0.0
@@ -258,7 +258,7 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 2.6.0
+        version: 2.6.1
     - - "<"
       - !ruby/object:Gem::Version
         version: 3.0.0
@@ -288,7 +288,7 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 1.4.0
+        version: 1.4.1
     - - "<"
       - !ruby/object:Gem::Version
         version: 2.0.0
@@ -298,7 +298,7 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 1.4.0
+        version: 1.4.1
     - - "<"
       - !ruby/object:Gem::Version
         version: 2.0.0
@@ -308,7 +308,7 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 1.7.0
+        version: 1.8.0
     - - "<"
       - !ruby/object:Gem::Version
         version: 2.0.0
@@ -318,7 +318,7 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 1.7.0
+        version: 1.8.0
     - - "<"
       - !ruby/object:Gem::Version
         version: 2.0.0
@@ -328,7 +328,7 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 1.1.1
+        version: 1.1.2
     - - "<"
       - !ruby/object:Gem::Version
         version: 2.0.0
@@ -338,7 +338,7 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 1.1.1
+        version: 1.1.2
     - - "<"
       - !ruby/object:Gem::Version
         version: 2.0.0
@@ -368,7 +368,7 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 1.5.0
+        version: 1.5.1
     - - "<"
       - !ruby/object:Gem::Version
         version: 2.0.0
@@ -378,7 +378,7 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 1.5.0
+        version: 1.5.1
     - - "<"
       - !ruby/object:Gem::Version
         version: 2.0.0
@@ -408,7 +408,7 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 0.5.2
+        version: 0.6.0
     - - "<"
       - !ruby/object:Gem::Version
         version: 1.0.0
@@ -418,7 +418,7 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 0.5.2
+        version: 0.6.0
     - - "<"
       - !ruby/object:Gem::Version
         version: 1.0.0
@@ -685,6 +685,7 @@ files:
 - lib/fastlane/actions/appium.rb
 - lib/fastlane/actions/appledoc.rb
 - lib/fastlane/actions/appstore.rb
+- lib/fastlane/actions/apteligent.rb
 - lib/fastlane/actions/artifactory.rb
 - lib/fastlane/actions/backup_file.rb
 - lib/fastlane/actions/backup_xcarchive.rb
@@ -807,6 +808,7 @@ files:
 - lib/fastlane/actions/set_changelog.rb
 - lib/fastlane/actions/set_github_release.rb
 - lib/fastlane/actions/set_info_plist_value.rb
+- lib/fastlane/actions/set_pod_key.rb
 - lib/fastlane/actions/setup_jenkins.rb
 - lib/fastlane/actions/sigh.rb
 - lib/fastlane/actions/skip_docs.rb
@@ -852,6 +854,7 @@ files:
 - lib/fastlane/actions/xctool.rb
 - lib/fastlane/actions/zip.rb
 - lib/fastlane/auto_complete.rb
+- lib/fastlane/cli_tools_distributor.rb
 - lib/fastlane/command_line_handler.rb
 - lib/fastlane/commands_generator.rb
 - lib/fastlane/configuration_helper.rb
@@ -876,11 +879,13 @@ files:
 - lib/fastlane/lane_manager.rb
 - lib/fastlane/new_action.rb
 - lib/fastlane/one_off.rb
+- lib/fastlane/other_action.rb
 - lib/fastlane/runner.rb
 - lib/fastlane/setup/setup.rb
 - lib/fastlane/setup/setup_android.rb
 - lib/fastlane/setup/setup_ios.rb
 - lib/fastlane/supported_platforms.rb
+- lib/fastlane/tools.rb
 - lib/fastlane/version.rb
 homepage: https://fastlane.tools
 licenses:
@@ -902,7 +907,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.4.0
+rubygems_version: 2.6.2
 signing_key: 
 specification_version: 4
 summary: The easiest way to automate building and releasing your iOS and Android apps