fastlane 1.111.0 → 2.0.1

data/{lib → fastlane/lib}/fastlane/actions/hipchat.rb

@@ -102,6 +102,7 @@ module Fastlane
                                        description: "The room or @username"),
           FastlaneCore::ConfigItem.new(key: :api_token,
                                        env_name: "HIPCHAT_API_TOKEN",
+                                       sensitive: true,
                                        description: "Hipchat API Token",
                                        verify_block: proc do |value|
                                          unless value.to_s.length > 0

data/{lib → fastlane/lib}/fastlane/actions/hockey.rb

@@ -1,7 +1,3 @@
-# Workaround, since hockeyapp.rb from shenzhen includes the code for commander
-def command(_param)
-end
-
 module Fastlane
   module Actions
     module SharedValues
@@ -10,12 +6,39 @@ module Fastlane
     end
 
     class HockeyAction < Action
+      def self.upload_build(api_token, ipa, options)
+        require 'faraday'
+        require 'faraday_middleware'
+
+        connection = Faraday.new(url: "https://upload.hockeyapp.net") do |builder|
+          builder.request :multipart
+          builder.request :url_encoded
+          builder.response :json, content_type: /\bjson$/
+          builder.use FaradayMiddleware::FollowRedirects
+          builder.adapter :net_http
+        end
+
+        options[:ipa] = Faraday::UploadIO.new(ipa, 'application/octet-stream') if ipa and File.exist?(ipa)
+
+        dsym_filename = options.delete(:dsym_filename)
+        if dsym_filename
+          options[:dsym] = Faraday::UploadIO.new(dsym_filename, 'application/octet-stream')
+        end
+
+        connection.post do |req|
+          if options[:public_identifier].nil?
+            req.url("/api/2/apps/upload")
+          else
+            req.url("/api/2/apps/#{options.delete(:public_identifier)}/app_versions/upload")
+          end
+          req.headers['X-HockeyAppToken'] = api_token
+          req.body = options
+        end
+      end
+
       def self.run(options)
         # Available options: http://support.hockeyapp.net/kb/api/api-versions#upload-version
 
-        require 'shenzhen'
-        require 'shenzhen/plugins/hockeyapp'
-
         build_file = [
           options[:ipa],
           options[:apk]
@@ -42,9 +65,11 @@ module Fastlane
 
         UI.user_error!("Symbols on path '#{File.expand_path(dsym_filename)}' not found") if dsym_filename && !File.exist?(dsym_filename)
 
-        UI.success('Starting with ipa upload to HockeyApp... this could take some time.')
-
-        client = Shenzhen::Plugins::HockeyApp::Client.new(options[:api_token])
+        if options[:upload_dsym_only]
+          UI.success('Starting with dSYM upload to HockeyApp... this could take some time.')
+        else
+          UI.success('Starting with ipa upload to HockeyApp... this could take some time.')
+        end
 
         values = options.values
         values[:dsym_filename] = dsym_filename
@@ -55,7 +80,7 @@ module Fastlane
         ipa_filename = build_file
         ipa_filename = nil if options[:upload_dsym_only]
 
-        response = client.upload_build(ipa_filename, values)
+        response = self.upload_build(options[:api_token], ipa_filename, values)
         case response.status
         when 200...300
           url = response.body['public_url']
@@ -94,6 +119,7 @@ module Fastlane
                                        end),
           FastlaneCore::ConfigItem.new(key: :api_token,
                                        env_name: "FL_HOCKEY_API_TOKEN",
+                                       sensitive: true,
                                        description: "API Token for Hockey Access",
                                        verify_block: proc do |value|
                                          UI.user_error!("No API token for Hockey given, pass using `api_token: 'token'`") unless value and !value.empty?

data/{lib → fastlane/lib}/fastlane/actions/ifttt.rb

@@ -39,6 +39,7 @@ module Fastlane
         [
           FastlaneCore::ConfigItem.new(key: :api_key,
                                       env_name: "IFTTT_API_KEY",
+                                      sensitive: true,
                                       description: "API key",
                                       verify_block: proc do |value|
                                         raise UI.error "No API key given, pass using `api_key: 'key'`" if value.to_s.empty?

data/{lib → fastlane/lib}/fastlane/actions/import_certificate.rb

@@ -22,12 +22,14 @@ module Fastlane
           FastlaneCore::ConfigItem.new(key: :keychain_password,
                                        env_name: "FL_IMPORT_CERT_KEYCHAIN_PASSWORD",
                                        description: "The password for the keychain. Note that for the login keychain this is your user's password",
+                                       sensitive: true,
                                        optional: true),
           FastlaneCore::ConfigItem.new(key: :certificate_path,
                                        description: "Path to certificate",
                                        optional: false),
           FastlaneCore::ConfigItem.new(key: :certificate_password,
                                        description: "Certificate password",
+                                       sensitive: true,
                                        default_value: "",
                                        optional: true),
           FastlaneCore::ConfigItem.new(key: :log_output,

data/{lib → fastlane/lib}/fastlane/actions/installr.rb

@@ -67,6 +67,7 @@ module Fastlane
         [
           FastlaneCore::ConfigItem.new(key: :api_token,
                                      env_name: "INSTALLR_API_TOKEN",
+                                     sensitive: true,
                                      description: "API Token for Installr Access",
                                      verify_block: proc do |value|
                                        UI.user_error!("No API token for Installr given, pass using `api_token: 'token'`") unless value and !value.empty?

data/{lib → fastlane/lib}/fastlane/actions/ipa.rb

@@ -23,7 +23,18 @@ module Fastlane
         platform == :ios
       end
 
+      def self.deprecation_warning
+        UI.error("You are using legacy `shenzhen` to build your app, which will be removed soon!")
+        UI.error("It is recommended to upgrade to `gym`")
+        UI.error("To do so, just replace `ipa(...)` with `gym(...)` in your Fastfile")
+        UI.error("https://github.com/fastlane/fastlane/tree/master/gym")
+      end
+
       def self.run(params)
+        Actions.verify_gem!('krausefx-shenzhen')
+
+        deprecation_warning
+
         # The output directory of the IPA and dSYM
         absolute_dest_directory = nil
 
@@ -69,10 +80,7 @@ module Fastlane
           ENV[SharedValues::IPA_OUTPUT_PATH.to_s] = absolute_ipa_path # for deliver
           ENV[SharedValues::DSYM_OUTPUT_PATH.to_s] = absolute_dsym_path
 
-          UI.important("You are using legacy `shenzhen` to build your app")
-          UI.important("It is recommended to upgrade to `gym`")
-          UI.important("To do so, just replace `ipa(...)` with `gym(...)` in your Fastfile")
-          UI.important("https://github.com/fastlane/fastlane/tree/master/gym")
+          deprecation_warning
         rescue => ex
           [
             "-------------------------------------------------------",

data/{lib → fastlane/lib}/fastlane/actions/jira.rb

@@ -52,6 +52,7 @@ module Fastlane
           FastlaneCore::ConfigItem.new(key: :password,
                                        env_name: "FL_JIRA_PASSWORD",
                                        description: "Password for Jira",
+                                       sensitive: true,
                                        verify_block: proc do |value|
                                          UI.user_error!("No password") if value.to_s.length == 0
                                        end),

data/{lib → fastlane/lib}/fastlane/actions/mailgun.rb

@@ -33,6 +33,7 @@ module Fastlane
           # This is here just for while due to the transition, should use apikey instead
           FastlaneCore::ConfigItem.new(key: :mailgun_apikey,
                                        env_name: "MAILGUN_APIKEY",
+                                       sensitive: true,
                                        optional: true,
                                        description: "Mailgun apikey for your mail. Please use postmaster instead"),
 
@@ -41,6 +42,7 @@ module Fastlane
                                        description: "Mailgun sandbox domain postmaster for your mail"),
           FastlaneCore::ConfigItem.new(key: :apikey,
                                        env_name: "MAILGUN_APIKEY",
+                                       sensitive: true,
                                        description: "Mailgun apikey for your mail"),
           FastlaneCore::ConfigItem.new(key: :to,
                                        env_name: "MAILGUN_TO",

data/{lib → fastlane/lib}/fastlane/actions/match.rb

@@ -4,16 +4,10 @@ module Fastlane
       def self.run(params)
         require 'match'
 
-        begin
-          FastlaneCore::UpdateChecker.start_looking_for_update('match') unless Helper.is_test?
+        params.load_configuration_file("Matchfile")
+        Match::Runner.new.run(params)
 
-          params.load_configuration_file("Matchfile")
-          Match::Runner.new.run(params)
-
-          define_profile_type(params)
-        ensure
-          FastlaneCore::UpdateChecker.show_update_status('match', Match::VERSION)
-        end
+        define_profile_type(params)
       end
 
       def self.define_profile_type(values)

data/{lib → fastlane/lib}/fastlane/actions/nexus_upload.rb

@@ -135,6 +135,7 @@ module Fastlane
                                        optional: true),
           FastlaneCore::ConfigItem.new(key: :proxy_password,
                                        env_name: "FL_NEXUS_PROXY_PASSWORD",
+                                       sensitive: true,
                                        description: "Proxy password",
                                        optional: true),
           FastlaneCore::ConfigItem.new(key: :proxy_address,

data/{lib → fastlane/lib}/fastlane/actions/onesignal.rb

@@ -67,6 +67,7 @@ module Fastlane
         [
           FastlaneCore::ConfigItem.new(key: :auth_token,
                                       env_name: "ONE_SIGNAL_AUTH_KEY",
+                                      sensitive: true,
                                       description: "OneSignal Authorization Key",
                                       verify_block: proc do |value|
                                         unless value.to_s.length > 0
@@ -88,6 +89,7 @@ module Fastlane
           FastlaneCore::ConfigItem.new(key: :android_token,
                                        env_name: "ANDROID_TOKEN",
                                        description: "ANDROID GCM KEY",
+                                       sensitive: true,
                                        optional: true),
 
           FastlaneCore::ConfigItem.new(key: :apns_p12,
@@ -97,6 +99,7 @@ module Fastlane
 
           FastlaneCore::ConfigItem.new(key: :apns_p12_password,
                                        env_name: "APNS_P12_PASSWORD",
+                                       sensitive: true,
                                        description: "APNS P12 password",
                                        optional: true),
 

data/{lib → fastlane/lib}/fastlane/actions/pem.rb

@@ -6,24 +6,18 @@ module Fastlane
         require 'pem/options'
         require 'pem/manager'
 
-        begin
-          FastlaneCore::UpdateChecker.start_looking_for_update('pem') unless Helper.is_test?
+        success_block = params[:new_profile]
 
-          success_block = params[:new_profile]
+        PEM.config = params
 
-          PEM.config = params
-
-          if Helper.is_test?
-            profile_path = './test.pem'
-          else
-            profile_path = PEM::Manager.start
-          end
+        if Helper.is_test?
+          profile_path = './test.pem'
+        else
+          profile_path = PEM::Manager.start
+        end
 
-          if success_block and profile_path
-            success_block.call(File.expand_path(profile_path)) if success_block
-          end
-        ensure
-          FastlaneCore::UpdateChecker.show_update_status('pem', PEM::VERSION)
+        if success_block and profile_path
+          success_block.call(File.expand_path(profile_path)) if success_block
         end
       end
 

data/{lib → fastlane/lib}/fastlane/actions/pilot.rb

@@ -5,20 +5,14 @@ module Fastlane
         require 'pilot'
         require 'pilot/options'
 
-        begin
-          FastlaneCore::UpdateChecker.start_looking_for_update('pilot') unless Helper.is_test?
+        changelog = Actions.lane_context[SharedValues::FL_CHANGELOG]
+        values[:changelog] ||= changelog if changelog
 
-          changelog = Actions.lane_context[SharedValues::FL_CHANGELOG]
-          values[:changelog] ||= changelog if changelog
+        values[:ipa] ||= Actions.lane_context[SharedValues::IPA_OUTPUT_PATH]
 
-          values[:ipa] ||= Actions.lane_context[SharedValues::IPA_OUTPUT_PATH]
+        return values if Helper.test?
 
-          return values if Helper.test?
-
-          Pilot::BuildManager.new.upload(values) # we already have the finished config
-        ensure
-          FastlaneCore::UpdateChecker.show_update_status('pilot', Pilot::VERSION)
-        end
+        Pilot::BuildManager.new.upload(values) # we already have the finished config
       end
 
       #####################################################
@@ -64,7 +58,7 @@ module Fastlane
       end
 
       def self.is_supported?(platform)
-        platform == :ios
+        true
       end
     end
   end

data/{lib → fastlane/lib}/fastlane/actions/podio_item.rb

@@ -43,6 +43,7 @@ module Fastlane
                                        end),
           FastlaneCore::ConfigItem.new(key: :client_secret,
                                        env_name: 'PODIO_ITEM_CLIENT_SECRET',
+                                       sensitive: true,
                                        description: 'Client secret for Podio API (see https://developers.podio.com/api-key)',
                                        is_string: true,
                                        verify_block: proc do |value|
@@ -57,6 +58,7 @@ module Fastlane
                                        end),
           FastlaneCore::ConfigItem.new(key: :app_token,
                                        env_name: 'PODIO_ITEM_APP_TOKEN',
+                                       sensitive: true,
                                        description: 'App token of the app you intend to authenticate with (see https://developers.podio.com/authentication/app_auth)',
                                        is_string: true,
                                        verify_block: proc do |value|

data/{lib → fastlane/lib}/fastlane/actions/produce.rb

@@ -10,19 +10,15 @@ module Fastlane
 
         return if Helper.test?
 
-        begin
-          FastlaneCore::UpdateChecker.start_looking_for_update('produce')
-          Produce.config = params # we alread have the finished config
+        FastlaneCore::UpdateChecker.start_looking_for_update('produce')
+        Produce.config = params # we alread have the finished config
 
-          Dir.chdir(FastlaneFolder.path || Dir.pwd) do
-            # This should be executed in the fastlane folder
-            apple_id = Produce::Manager.start_producing.to_s
+        Dir.chdir(FastlaneCore::FastlaneFolder.path || Dir.pwd) do
+          # This should be executed in the fastlane folder
+          apple_id = Produce::Manager.start_producing.to_s
 
-            Actions.lane_context[SharedValues::PRODUCE_APPLE_ID] = apple_id
-            ENV['PRODUCE_APPLE_ID'] = apple_id
-          end
-        ensure
-          FastlaneCore::UpdateChecker.show_update_status('produce', Produce::VERSION)
+          Actions.lane_context[SharedValues::PRODUCE_APPLE_ID] = apple_id
+          ENV['PRODUCE_APPLE_ID'] = apple_id
         end
       end
 

data/{lib → fastlane/lib}/fastlane/actions/prompt.rb

@@ -2,7 +2,11 @@ module Fastlane
   module Actions
     class PromptAction < Action
       def self.run(params)
-        params[:text] += " (y/n)" if params[:boolean]
+        if params[:boolean]
+          return params[:ci_input] unless UI.interactive?
+          return UI.confirm(params[:text])
+        end
+
         UI.message(params[:text])
 
         return params[:ci_input] unless UI.interactive?
@@ -17,7 +21,6 @@ module Fastlane
           user_input = STDIN.gets.chomp.strip while (user_input || "").length == 0
         end
 
-        user_input = user_input.casecmp('y').zero? if params[:boolean]
         return user_input
       end
 

data/{lib → fastlane/lib}/fastlane/actions/puts.rb

@@ -21,6 +21,14 @@ module Fastlane
         true
       end
 
+      def self.alias_used(action_alias, params)
+        UI.important("#{action_alias} called, please use 'puts' instead!")
+      end
+
+      def self.aliases
+        ["println", "echo"]
+      end
+
       # We don't want to show this as step
       def self.step_text
         nil