fastlane 0.11.0 → 0.12.0

data/lib/fastlane/actions/team_id.rb

@@ -5,7 +5,7 @@ module Fastlane
 
     class TeamIdAction < Action
       def self.run(params)
-        team = params.first
+        team = (params.first rescue nil)
         raise "Please pass your Team ID (e.g. team_id 'Q2CBPK58CA')".red unless team.to_s.length > 0
 
         Helper.log.info "Setting Team ID to '#{team}' for all build steps"

data/lib/fastlane/actions/team_name.rb

@@ -5,7 +5,7 @@ module Fastlane
 
     class TeamNameAction < Action
       def self.run(params)
-        team = params.first
+        team = (params.first rescue nil)
         raise "Please pass your Team Name (e.g. team_name 'Felix Krause')".red unless team.to_s.length > 0
 
         Helper.log.info "Setting Team Name to '#{team}' for all build steps"

data/lib/fastlane/actions/testmunk.rb

@@ -12,20 +12,13 @@
 module Fastlane
   module Actions
     class TestmunkAction < Action
-      def self.run(_params)
-        raise "Please pass your Testmunk email address using `ENV['TESTMUNK_EMAIL'] = 'value'`" unless ENV['TESTMUNK_EMAIL']
-        raise "Please pass your Testmunk API Key using `ENV['TESTMUNK_API'] = 'value'`" unless ENV['TESTMUNK_API']
-        raise "Please pass your Testmunk app name using `ENV['TESTMUNK_APP'] = 'value'`" unless ENV['TESTMUNK_APP']
-
-        ipa_path = ENV['TESTMUNK_IPA'] || ENV[Actions::SharedValues::IPA_OUTPUT_PATH.to_s]
-        raise "Please pass a path to your ipa file using `ENV['TESTMUNK_IPA'] = 'value'`" unless ipa_path
-
+      def self.run(config)
         Helper.log.info 'Testmunk: Uploading the .ipa and starting your tests'.green
 
         response = system("#{"curl -H 'Accept: application/vnd.testmunk.v1+json'" +
-            " -F 'file=@#{ipa_path}' -F 'autoStart=true'" +
-            " -F 'email=#{ENV['TESTMUNK_EMAIL']}'" +
-            " https://#{ENV['TESTMUNK_API']}@api.testmunk.com/apps/#{ENV['TESTMUNK_APP']}/testruns"}")
+            " -F 'file=@#{config[:ipa]}' -F 'autoStart=true'" +
+            " -F 'email=#{config[:email]}'" +
+            " https://#{config[:api]}@api.testmunk.com/apps/#{config[:app]}/testruns"}")
 
         if response
           Helper.log.info 'Your tests are being executed right now. Please wait for the mail with results and decide if you want to continue.'.green
@@ -40,9 +33,30 @@ module Fastlane
 
       def self.available_options
         [
-          ['', 'Your email address', 'TESTMUNK_EMAIL'],
-          ['', 'Testmunk API Key', 'TESTMUNK_API'],
-          ['', 'Testmunk App Name', 'TESTMUNK_APP']
+          FastlaneCore::ConfigItem.new(key: :ipa,
+                                       env_name: "TESTMUNK_IPA",
+                                       description: "Path to IPA",
+                                       verify_block: Proc.new do |value|
+                                        raise "Please pass to existing ipa" unless File.exists?value
+                                       end),
+          FastlaneCore::ConfigItem.new(key: :email,
+                                       env_name: "TESTMUNK_EMAIL",
+                                       description: "Your email address",
+                                       verify_block: Proc.new do |value|
+                                        raise "Please pass your Testmunk email address using `ENV['TESTMUNK_EMAIL'] = 'value'`" unless value
+                                       end),
+          FastlaneCore::ConfigItem.new(key: :api,
+                                       env_name: "TESTMUNK_API",
+                                       description: "Testmunk API Key",
+                                       verify_block: Proc.new do |value|
+                                          raise "Please pass your Testmunk API Key using `ENV['TESTMUNK_API'] = 'value'`" unless value
+                                       end),
+          FastlaneCore::ConfigItem.new(key: :app,
+                                       env_name: "TESTMUNK_APP",
+                                       description: "Testmunk App Name",
+                                       verify_block: Proc.new do |value|
+                                        raise "Please pass your Testmunk app name using `ENV['TESTMUNK_APP'] = 'value'`" unless value
+                                       end),
         ]
       end
 

data/lib/fastlane/actions/typetalk.rb

@@ -8,7 +8,7 @@ module Fastlane
             success: true,
             topicId: nil,
             typetalk_token: nil,
-        }.merge(params.first || {})
+        }.merge(params || {})
 
         [:message, :topicId, :typetalk_token].each { |key|
           raise "No #{key} given.".red unless options[key]

data/lib/fastlane/actions/update_fastlane.rb

@@ -0,0 +1,115 @@
+require 'rubygems/spec_fetcher'
+require 'rubygems/commands/update_command'
+
+module Fastlane
+  module Actions
+    # Makes sure fastlane tools are up-to-date when running fastlane 
+    class UpdateFastlaneAction < Action
+
+      ALL_TOOLS = [
+        "fastlane",
+        "fastlane_core",
+        "deliver",
+        "snapshot",
+        "frameit",
+        "pem",
+        "sigh",
+        "produce",
+        "cert",
+        "codes",
+        "credentials_manager"
+      ]
+
+      def self.run(options)
+        if options[:no_update]
+          return
+        end
+
+        tools_to_update = options[:tools].split ',' unless options[:tools].nil?
+        tools_to_update ||= all_installed_tools
+
+        if tools_to_update.count == 0
+          Helper.log.error "No tools specified or couldn't find any installed fastlane.tools".red
+          return
+        end
+
+        updater = Gem::Commands::UpdateCommand.new
+
+        sudo_needed = !File.writable?(Gem.dir)
+
+        if sudo_needed
+          Helper.log.warn "It seems that your Gem directory is not writable by your current User."
+          Helper.log.warn "Fastlane would need sudo rights to update itself, however, running 'sudo fastlane' is not recommended."
+          Helper.log.warn "If you still want to use this action, please read the Actions.md documentation on a guide how to set this up."
+          return
+        end
+
+        highest_versions = updater.highest_installed_gems.keep_if {|key| tools_to_update.include? key }
+        update_needed = updater.which_to_update(highest_versions, tools_to_update)
+
+        if update_needed.count == 0
+          Helper.log.info "Nothing to update! 😮".yellow
+          return
+        end
+
+        #suppress updater output - very noisy
+        Gem::DefaultUserInteraction.ui = Gem::SilentUI.new
+
+        update_needed.each do |tool_info| 
+          tool = tool_info[0]
+          local_version = Gem::Version.new(highest_versions[tool].version)
+          latest_version = FastlaneCore::UpdateChecker.fetch_latest(tool)
+          Helper.log.info "Updating #{tool} from #{local_version} to #{latest_version} ... 🚀"
+
+          # Approximate_recommendation will create a string like "~> 0.10" from a version 0.10.0, e.g. one that is valid for versions >= 0.10 and <1.0
+          updater.update_gem tool, Gem::Requirement.new(local_version.approximate_recommendation)
+          
+          Helper.log.info "Finished updating #{tool}"
+        end
+
+        any_updates = updater.installer.installed_gems.any? do |updated_tool|
+          updated_tool.version > highest_versions[updated_tool.name].version
+        end
+
+        if any_updates
+          Helper.log.info "fastlane.tools succesfully updated! I will now restart myself... 😴"
+          
+          # Set no_update to true so we don't try to update again
+          exec "FL_NO_UPDATE=true #{$PROGRAM_NAME} #{ARGV.join ' '}"
+        else 
+          Helper.log.info "All fastlane tools are up-to-date!"
+        end
+      end
+
+      def self.all_installed_tools
+        Gem::Specification.select { |s| ALL_TOOLS.include? s.name }.map {|s| s.name}.uniq
+      end
+
+      def self.description
+        "Makes sure fastlane-tools are up-to-date when running fastlane"
+      end
+
+      def self.available_options
+        [
+          FastlaneCore::ConfigItem.new(key: :tools,
+                                       env_name: "FL_TOOLS_TO_UPDATE",
+                                       description: "Comma separated list of fastlane tools to update (e.g. fastlane,deliver,sigh). If not specified, all currently installed fastlane-tools will be updated",
+                                       optional: true),
+         FastlaneCore::ConfigItem.new(key: :no_update,
+                                      env_name: "FL_NO_UPDATE",
+                                      description: "Don't update during this run. Defaults to false",
+                                      is_string: false,
+                                      default_value: false),
+        ]
+      end
+
+      def self.author
+        "milch"
+      end
+
+      def self.is_supported?(platform)
+        true
+      end
+    end
+  end
+end

data/lib/fastlane/actions/update_project_code_signing.rb

@@ -5,19 +5,16 @@ module Fastlane
 
     class UpdateProjectCodeSigningAction < Action
       def self.run(params)
-        path = params.first
+        path = params[:path]
         path = File.join(path, "project.pbxproj")
         raise "Could not find path to project config '#{path}'. Pass the path to your project (not workspace)!".red unless File.exists?(path)
 
-        udid = (params[1] rescue nil)
-        udid ||= ENV["SIGH_UDID"]
-
-        Helper.log.info("Updating provisioning profile UDID (#{udid}) for the given project '#{path}'")
+        Helper.log.info("Updating provisioning profile UDID (#{params[:udid]}) for the given project '#{path}'")
 
         p = File.read(path)
-        File.write(path, p.gsub(/PROVISIONING_PROFILE = ".*";/, "PROVISIONING_PROFILE = \"#{udid}\";"))
+        File.write(path, p.gsub(/PROVISIONING_PROFILE = ".*";/, "PROVISIONING_PROFILE = \"#{params[:udid]}\";"))
 
-        Helper.log.info("Successfully updated project settings to use UDID '#{udid}'".green)
+        Helper.log.info("Successfully updated project settings to use UDID '#{params[:udid]}'".green)
       end
 
       def self.description
@@ -28,6 +25,24 @@ module Fastlane
         "This feature is not yet 100% finished"
       end
 
+      def self.available_options
+        [
+          FastlaneCore::ConfigItem.new(key: :path,
+                                       env_name: "FL_PROJECT_SIGNING_PROJECT_PATH",
+                                       description: "Path to your Xcode project",
+                                       verify_block: Proc.new do |value|
+                                        raise "Path is invalid".red unless File.exists?(value)
+                                       end),
+          FastlaneCore::ConfigItem.new(key: :udid,
+                                       env_name: "FL_PROJECT_SIGNING_UDID",
+                                       description: "The UDID of the provisioning profile you want to use",
+                                       default_value: ENV["SIGH_UDID"],
+                                       verify_block: Proc.new do |value|
+                                        raise "Path is invalid".red unless File.exists?(value)
+                                       end)
+        ]
+      end
+
       def self.author
         "KrauseFx"
       end

data/lib/fastlane/actions/xcode_select.rb

@@ -19,7 +19,7 @@ module Fastlane
     #
     class XcodeSelectAction < Action
       def self.run(params)
-        xcode_path = params.first
+        xcode_path = (params.first rescue nil)
 
         # Verify that a param was passed in
         raise "Path to Xcode application required (e.x. \"/Applications/Xcode.app\")".red unless xcode_path.to_s.length > 0

data/lib/fastlane/actions/xcodebuild.rb

@@ -66,7 +66,7 @@ module Fastlane
         end
 
 
-        if params = params.first
+        if params
           # Operation bools
           archiving = params.key? :archive
           exporting = params.key? :export_archive
@@ -246,9 +246,9 @@ module Fastlane
 
     class XcarchiveAction < Action
       def self.run(params)
-        params_hash = params.first || {}
+        params_hash = params || {}
         params_hash[:archive] = true
-        XcodebuildAction.run([params_hash])
+        XcodebuildAction.run(params_hash)
       end
 
       def self.description
@@ -262,13 +262,22 @@ module Fastlane
       def self.is_supported?(platform)
         platform == :ios
       end
+
+      def self.available_options
+        [
+          ['archive_path', 'The path to archive the to. Must contain `.xcarchive`'],
+          ['workspace', 'The workspace to use'],
+          ['scheme', 'The scheme to build'],
+          ['build_settings', 'Hash of additional build information']
+        ]
+      end
     end
 
     class XcbuildAction < Action
       def self.run(params)
-        params_hash = params.first || {}
+        params_hash = params || {}
         params_hash[:build] = true
-        XcodebuildAction.run([params_hash])
+        XcodebuildAction.run(params_hash)
       end
 
       def self.description
@@ -282,13 +291,23 @@ module Fastlane
       def self.is_supported?(platform)
         platform == :ios
       end
+
+      def self.available_options
+        [
+          ['archive', 'Set to true to build archive'],
+          ['archive_path', 'The path to archive the to. Must contain `.xcarchive`'],
+          ['workspace', 'The workspace to use'],
+          ['scheme', 'The scheme to build'],
+          ['build_settings', 'Hash of additional build information']
+        ]
+      end
     end
 
     class XccleanAction < Action
       def self.run(params)
-        params_hash = params.first || {}
+        params_hash = params || {}
         params_hash[:clean] = true
-        XcodebuildAction.run([params_hash])
+        XcodebuildAction.run(params_hash)
       end
 
       def self.description
@@ -302,13 +321,23 @@ module Fastlane
       def self.is_supported?(platform)
         platform == :ios
       end
+
+      def self.available_options
+        [
+          ['archive', 'Set to true to build archive'],
+          ['archive_path', 'The path to archive the to. Must contain `.xcarchive`'],
+          ['workspace', 'The workspace to use'],
+          ['scheme', 'The scheme to build'],
+          ['build_settings', 'Hash of additional build information']
+        ]
+      end
     end
 
     class XcexportAction < Action
       def self.run(params)
-        params_hash = params.first || {}
+        params_hash = params || {}
         params_hash[:export_archive] = true
-        XcodebuildAction.run([params_hash])
+        XcodebuildAction.run(params_hash)
       end
 
       def self.description
@@ -319,6 +348,16 @@ module Fastlane
         "dtrenz"
       end
 
+      def self.available_options
+        [
+          ['archive', 'Set to true to build archive'],
+          ['archive_path', 'The path to archive the to. Must contain `.xcarchive`'],
+          ['workspace', 'The workspace to use'],
+          ['scheme', 'The scheme to build'],
+          ['build_settings', 'Hash of additional build information']
+        ]
+      end
+
       def self.is_supported?(platform)
         platform == :ios
       end
@@ -326,17 +365,22 @@ module Fastlane
 
     class XctestAction < Action
       def self.run(params)
-        params_hash = params.first || {}
+        params_hash = params || {}
         params_hash[:test] = true
-        XcodebuildAction.run([params_hash])
+        XcodebuildAction.run(params_hash)
       end
 
       def self.description
         "Runs tests on the given simulator"
       end
 
-      def available_options
+      def self.available_options
         [
+          ['archive', 'Set to true to build archive'],
+          ['archive_path', 'The path to archive the to. Must contain `.xcarchive`'],
+          ['workspace', 'The workspace to use'],
+          ['scheme', 'The scheme to build'],
+          ['build_settings', 'Hash of additional build information'],
           ['destination', 'The simulator to use, e.g. "name=iPhone 5s,OS=8.1"']
         ]
       end

data/lib/fastlane/actions_list.rb

@@ -107,7 +107,7 @@ module Fastlane
     end
     
     private
-      def self.parse_options(options, fill_three = true)
+      def self.parse_options(options, fill_all = true)
         rows = []
         rows << [options] if options.kind_of?String
 
@@ -119,7 +119,7 @@ module Fastlane
               raise "Invalid number of elements in this row: #{current}. Must be 2 or 3".red unless ([2, 3].include?current.count)
               rows << current
               rows.last[0] = rows.last.first.yellow # color it yellow :) 
-              rows.last << nil if (fill_three and rows.last.count == 2) # to have a nice border in the table
+              rows.last << nil while (fill_all and rows.last.count < 3) # to have a nice border in the table
             end
           end
         end

data/lib/fastlane/configuration_helper.rb

@@ -0,0 +1,28 @@
+module Fastlane
+  class ConfigurationHelper
+    def self.parse(action, params)
+      begin
+        first_element = (action.available_options.first rescue nil) # might also be nil
+        
+        if first_element and first_element.kind_of?FastlaneCore::ConfigItem
+          # default use case
+          return FastlaneCore::Configuration.create(action.available_options, params)
+
+        elsif first_element
+          Helper.log.error "Action '#{action}' uses the old configuration format."
+          puts "Old configuration format for action '#{action}'".red if Helper.is_test?
+          return params
+        else
+
+          # No parameters... we still need the configuration object array
+          FastlaneCore::Configuration.create(action.available_options, {})
+
+        end
+      rescue => ex
+        Helper.log.fatal "You provided an option to action #{action.action_name} which is not supported.".red
+        Helper.log.fatal "Check out the available options below or run `fastlane action #{action.action_name}`".red
+        raise ex
+      end
+    end
+  end
+end